December 2024 - U-Boot

[PATCH v2 00/18] vbe: Series part E
by Simon Glass 07 Dec '24

07 Dec '24

This includes various patches towards implementing the VBE abrec bootmeth in U-Boot. It mostly focuses on SPL tweaks and adjusting what fatures are available in VPL. Changes in v2: - Add field names into the message - Fix 'depends on SPL' to depend on TPL - Depend on TPL/VPL as well - Drop patch 'serial: ns16550: Allow clocks to be missing' Simon Glass (18): image: Add a prototype for fit_image_get_phase() boot: Allow FIT to fall back from best-match option bootstd: Avoid sprintf() in SPL when creating bootdevs boot: Respect the load_op in fit_image_load() malloc: Show amount of used space when memory runs out malloc: Provide a simple malloc for VPL Support setting a maximum size for the VPL image spl: Report a loader failure spl: Allow serial to be disabled in any XPL phase spl: Support a relocated stack in any XPL phase spl: Drop use of uintptr_t spl: Drop a duplicate variable in boot_from_devices() spl: Add some more debugging to load_simple_fit() spl: lib: Allow for decompression in any SPL build boot: Allow use of FIT in TPL and VPL lib: Allow crc8 in TPL and VPL boot: Imply CRC8 with VBE hash: Plumb crc8 into the hash functions boot/Kconfig | 71 ++++++++++++++++++++++++++++++++++- boot/Makefile | 4 +- boot/bootdev-uclass.c | 10 ++++- boot/image-fit.c | 29 ++++++++------ common/hash.c | 8 ++++ common/malloc_simple.c | 3 +- common/spl/Kconfig.vpl | 17 +++++++++ common/spl/spl.c | 15 +++++--- common/spl/spl_atf.c | 36 +++++++++--------- common/spl/spl_fit.c | 12 +++++- common/spl/spl_legacy.c | 8 ++-- configs/sandbox_vpl_defconfig | 3 +- include/image.h | 16 +++++++- include/spl.h | 28 +++++++------- include/u-boot/crc.h | 3 ++ lib/Kconfig | 53 ++++++++++++++++++++++++++ lib/Makefile | 8 ++-- lib/crc8.c | 6 +++ 18 files changed, 262 insertions(+), 68 deletions(-) -- 2.43.0

2 21

[PATCH 0/3] board: ti: k3-am65: covert last board to OF_UPSTREAM
by Bryan Brattlof 07 Dec '24

07 Dec '24

Hello Everyone! This small series converts TI's AM65x reference board to use CONFIG_OF_UPSTREAM and removes the unused device tree files from arch/arm/dts. Because it's the last board using a AM65x without enabling OF_UPSTREAM it allows us to also remove all the SoC FDT files as well and keep a single version of the SoC's DT files in the dts/upstream directory going forward. Happy Hacking ~Bryan Signed-off-by: Bryan Brattlof <bb(a)ti.com> --- Bryan Brattlof (3): board: ti: am65x: migrate to OF_UPSTREAM arm: dts: k3-am654: cleanup unused board files arm: dts: k3-am65: remove unsused am65x SoC fdt files arch/arm/dts/Makefile | 4 +- arch/arm/dts/k3-am65-main.dtsi | 1568 ------------------------- arch/arm/dts/k3-am65-mcu.dtsi | 440 ------- arch/arm/dts/k3-am65-wakeup.dtsi | 105 -- arch/arm/dts/k3-am65.dtsi | 110 -- arch/arm/dts/k3-am654-base-board.dts | 630 ---------- arch/arm/dts/k3-am654-icssg2.dtso | 145 --- arch/arm/dts/k3-am654-industrial-thermal.dtsi | 45 - arch/arm/dts/k3-am654.dtsi | 122 -- arch/arm/dts/k3-am65x-binman.dtsi | 4 +- arch/arm/mach-k3/am65x/Kconfig | 1 + configs/am65x_evm_a53_defconfig | 3 +- 12 files changed, 6 insertions(+), 3171 deletions(-) --- base-commit: 7fe55182d9263a62e18b450c97bdf0b8031e5667 change-id: 20241118-am65x-ed4ab74db41d Best regards, -- Bryan Brattlof <bb(a)ti.com>

2 4

[PATCH 0/3] PLL Sequencing update
by Manorit Chawdhry 07 Dec '24

07 Dec '24

It has done a re-write of the full driver and the commits aren't split to keep the bisectability intact. Boot Logs: https://gist.github.com/manorit2001/1eaba109d722715a233244da693133d3 Signed-off-by: Manorit Chawdhry <m-chawdhry(a)ti.com> --- Manorit Chawdhry (3): arm: dts: k3-*-r5: Remove clocks from mcu_timer0 clk: ti: clk-k3-pll: Change variable name reg to base clk: ti: clk-k3-pll: Add additional robustness steps to the PLL sequence arch/arm/dts/k3-am62-lp-sk-u-boot.dtsi | 10 - arch/arm/dts/k3-am62-r5-lp-sk.dts | 9 + arch/arm/dts/k3-am625-r5-sk.dts | 9 + arch/arm/dts/k3-am625-sk-u-boot.dtsi | 10 - arch/arm/dts/k3-am62a7-r5-sk.dts | 10 + arch/arm/dts/k3-am62a7-sk-u-boot.dtsi | 5 - arch/arm/dts/k3-am62p5-r5-sk.dts | 8 + arch/arm/dts/k3-j7200-r5-common-proc-board.dts | 4 + arch/arm/dts/k3-j721e-r5.dtsi | 6 +- arch/arm/dts/k3-j721s2-r5.dtsi | 4 + arch/arm/dts/k3-j722s-r5-evm.dts | 8 + arch/arm/dts/k3-j784s4-r5.dtsi | 5 +- drivers/clk/ti/clk-k3-pll.c | 357 +++++++++++++++++++------ 13 files changed, 337 insertions(+), 108 deletions(-) --- base-commit: a38390284ad4261723d3a2411ba988828e994535 change-id: 20240920-b4-upstream-pll-fix-7b6a420adbb6 Best regards, -- Manorit Chawdhry <m-chawdhry(a)ti.com>

2 4

[PATCH V2] env: Switch the callback static list to Kconfig
by Christoph Niedermaier 07 Dec '24

07 Dec '24

Switch the callback static list from the board configuration variable CFG_ENV_CALLBACK_LIST_STATIC to Kconfig CONFIG_ENV_CALLBACK_LIST_STATIC. Signed-off-by: Christoph Niedermaier <cniedermaier(a)dh-electronics.com> Reviewed-by: Marek Vasut <marex(a)denx.de> --- Cc: Joe Hershberger <joe.hershberger(a)ni.com> Cc: Marek Vasut <marex(a)denx.de> Cc: Tom Rini <trini(a)konsulko.com> Cc: u-boot(a)dh-electronics.com --- V2: - Fix typo in commit message --- doc/develop/environment.rst | 4 ++-- env/Kconfig | 13 +++++++++++++ include/env_callback.h | 7 +------ 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/doc/develop/environment.rst b/doc/develop/environment.rst index e1783462bb..e46cd39d60 100644 --- a/doc/develop/environment.rst +++ b/doc/develop/environment.rst @@ -18,8 +18,8 @@ The callbacks are named and associated with a function using the U_BOOT_ENV_CALLBACK macro in your board or driver code. These callbacks are associated with variables in one of two ways. The -static list can be added to by defining CFG_ENV_CALLBACK_LIST_STATIC -in the board configuration to a string that defines a list of +static list can be added to by defining CONFIG_ENV_CALLBACK_LIST_STATIC +in the board defconfig via menuconfig to a string that defines a list of associations. The list must be in the following format:: entry = variable_name[:callback_name] diff --git a/env/Kconfig b/env/Kconfig index 031cf58186..aaf0b1fe9a 100644 --- a/env/Kconfig +++ b/env/Kconfig @@ -21,6 +21,19 @@ config ENV_SOURCE_FILE environment is assumed to come from the ad-hoc CFG_EXTRA_ENV_SETTINGS #define +config ENV_CALLBACK_LIST_STATIC + string "Static callbacks list" + default "" + help + The environment callbacks are associated with variables in a + static list. Define this list in the following format: + + entry = variable_name[:callback_name] + list = entry[,list] + + If the callback name is not specified, then the callback is deleted. + Spaces are also allowed anywhere in the list. + config SAVEENV def_bool y if CMD_SAVEENV diff --git a/include/env_callback.h b/include/env_callback.h index bc8ff1923e..47a31f6cf5 100644 --- a/include/env_callback.h +++ b/include/env_callback.h @@ -14,11 +14,6 @@ #define ENV_CALLBACK_VAR ".callbacks" -/* Board configs can define additional static callback bindings */ -#ifndef CFG_ENV_CALLBACK_LIST_STATIC -#define CFG_ENV_CALLBACK_LIST_STATIC -#endif - #ifdef CONFIG_SILENT_CONSOLE #define SILENT_CALLBACK "silent:silent," #else @@ -90,7 +85,7 @@ SILENT_CALLBACK \ "stdin:console,stdout:console,stderr:console," \ "serial#:serialno," \ - CFG_ENV_CALLBACK_LIST_STATIC + CONFIG_ENV_CALLBACK_LIST_STATIC #ifndef CONFIG_XPL_BUILD void env_callback_init(struct env_entry *var_entry); -- 2.30.2

2 1

[PATCH] ram: k3-ddrss: drop debug() in timing-sensitive sequence
by Théo Lebrun 07 Dec '24

07 Dec '24

Those debug() calls might be useful, but beware. They can cause the DDR controller to hang if we do not run the sequence quickly enough. They usually are not an issue with upstream U-Boot and the default DDR config, but they have become troublesome with custom DDR configs. Drop those debug() statements that shouldn't be present in time-sensitive code, to avoid anyone else falling into the trap. Signed-off-by: Théo Lebrun <theo.lebrun(a)bootlin.com> --- drivers/ram/k3-ddrss/k3-ddrss.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/ram/k3-ddrss/k3-ddrss.c b/drivers/ram/k3-ddrss/k3-ddrss.c index 525b6d5b79fce18819946e1714e98290057ccccf..6e9202b957962ec95fbad2469a0ef8c8557c5d95 100644 --- a/drivers/ram/k3-ddrss/k3-ddrss.c +++ b/drivers/ram/k3-ddrss/k3-ddrss.c @@ -216,9 +216,6 @@ static void k3_lpddr4_freq_update(struct k3_ddrss_desc *ddrss) req_type = readl(ddrss->ddrss_ctrl_mmr + CTRLMMR_DDR4_FSP_CLKCHNG_REQ_OFFS + ddrss->instance * 0x10) & 0x03; - debug("%s: received freq change req: req type = %d, req no. = %d, instance = %d\n", - __func__, req_type, counter, ddrss->instance); - if (req_type == 1) clk_set_rate(&ddrss->ddr_clk, ddrss->ddr_freq1); else if (req_type == 2) @@ -245,8 +242,6 @@ static void k3_lpddr4_ack_freq_upd_req(const lpddr4_privatedata *pd) { struct k3_ddrss_desc *ddrss = (struct k3_ddrss_desc *)pd->ddr_instance; - debug("--->>> LPDDR4 Initialization is in progress ... <<<---\n"); - switch (ddrss->dram_class) { case DENALI_CTL_0_DRAM_CLASS_DDR4: break; --- base-commit: 2bf2615b8004e4a296fb25498ad0c183fd5c7b94 change-id: 20241115-k3-debug-30505f24e214 Best regards, -- Théo Lebrun <theo.lebrun(a)bootlin.com>

2 1

[PATCH v2 0/4] Better smartphone support (Qualcomm)
by Caleb Connolly 07 Dec '24

07 Dec '24

Improve support for running U-Boot on [Qualcomm] smartphones, with: * A boot menu which can be entered by holding power during boot * Hang on panic (so errors can be read on the display) * Serial gadget which can be enabled by holding volume down or via boot menu In its current form, U-Boot's boot menu is perfectly adequate, however once an option is picked U-Boot will just drop to the CLI again. On a phone (with no keyboard), dropping to the CLI effectively makes the device unusable until manually rebooted, since there is no way to run any commands... To rectify this, let's revive CONFIG_BOOT_RETRY for the hush parser and make it run the contents of "bootcmd", as well as re-reading the value of the bootretry environment variable. In tandem, this provides for a flexible menu system which we can enter and exit. See qcom-phone.env in patch 1 for more details. Finally, provide some rough-ish documentation to describe how Qualcomm phone support works and outline some debugging steps for when UART and the framebuffer are unavailable. This series depends on CONFIG_REMAP_PHONE_KEYS [1] to enable navigating the boot menu when using upstream DT. [1]: https://lore.kernel.org/u-boot/20240714194948.1271135-1-caleb.connolly@lina… --- Changes in v2: - Fix CONFIG_BUTTON_REMAP_PHONE_KEYS name in qcom-phone.config - Add Tom and Simon to CC - Link to v1: https://lore.kernel.org/r/20240831-qcom-phones-v1-0-08614edd8e35@linaro.org --- Caleb Connolly (4): board/qualcomm: introduce phone config cli_hush: run bootmenu on retry bootretry: check for bootretry variable changes doc: board/qualcomm: describe phone support and bringup board/qualcomm/qcom-phone.config | 12 ++++ board/qualcomm/qcom-phone.env | 49 ++++++++++++++++ boot/bootretry.c | 2 + common/cli_hush.c | 2 +- common/cli_hush_upstream.c | 2 +- doc/board/qualcomm/board.rst | 5 ++ doc/board/qualcomm/index.rst | 1 + doc/board/qualcomm/phones.rst | 122 +++++++++++++++++++++++++++++++++++++++ 8 files changed, 193 insertions(+), 2 deletions(-) --- change-id: 20240831-qcom-phones-c789d14de657 base-commit: 00292c6b39b3f7dcb34e8c3ae6ef276ac862a146 // Caleb (they/them)

5 10

[PATCH v2 0/8] led: update LED boot/activity to new property implementation
by Christian Marangi 06 Dec '24

06 Dec '24

This series is split in 2 part. While adapting the LED boot and activity code to the new property accepted by Rob in dt-schema repository, a big BUG was discovered. The reason wasn't clear at start and took me some days to figure it out. This was triggered by adding a new phandle in the test.dts to introduce test for the new OPs. This single addition caused the sandbox CI test to fail in the dm_test_ofnode_phandle_ot test. This doesn't make sense as reverting the change made the CI test to correctly finish. Also moving the uboot node down after the first phandle (in test.dts the gpio one) also made the CI test to correctly finish. A little bit of searching and debugging made me realize the parse phandle OPs didn't support other.dts at all and they were still referencing phandle index from test.dts. (more info in the related commit) In short the test was broken all along and was working by pure luck. The first 4 patch address and fix the problem for good. The other 4 patch expand and address the property change for LED boot/activity. Posting in a single series as changes are trivial and just to speedup review process. (and also because the second part depends on the first) All CI tested with azure pipeline. Changes v2: - Fix handling of flat tree for phandle - Fix test and other.dts changes Christian Marangi (8): dm: core: implement oftree variant of parse_phandle OPs test: dm: fix broken dm_test_ofnode_phandle_ot and get_by_phandle_ot dm: core: implement ofnode/tree_parse_phandle() helper test: dm: Expand dm_test_ofnode_phandle(_ot) with new ofnode/tree_parse_phandle dm: core: implement phandle ofnode_options helper test: dm: Add test for ofnode options phandle helper led: update LED boot/activity to new property implementation test: dm: Update test for LED activity and boot arch/sandbox/dts/other.dts | 31 ++++++++- arch/sandbox/dts/test.dts | 16 +++-- drivers/core/of_access.c | 61 ++++++++++++----- drivers/core/ofnode.c | 124 ++++++++++++++++++++++++++++++++- drivers/led/led-uclass.c | 30 +++++--- include/dm/of_access.h | 86 +++++++++++++++++++++++ include/dm/ofnode.h | 107 +++++++++++++++++++++++++++++ test/dm/led.c | 18 +++-- test/dm/ofnode.c | 136 ++++++++++++++++++++++++++++++++----- 9 files changed, 551 insertions(+), 58 deletions(-) -- 2.45.2

3 21

[PATCH v3 0/5] Add OPP_LOW support for J7200
by Aniket Limaye 06 Dec '24

06 Dec '24

This series adds OPP_LOW spec data in k3_avs driver and enables a config option to select the OPP_LOW performance point. J7200 SOC supports OPP_LOW and OPP_NOM as two Operating Performance Points as per (7.5 Operating Performance Points) section in the Datasheet [0]. - A72SS/MSMC at 2 GHz/1GHz operation must use OPP_NOM. - A72SS/MSMC at 1 GHz/500 MHz operation can use OPP_NOM or OPP_LOW voltage (though OPP_LOW voltage is recommended to reduce power consumption). The actual OPP voltage for the device is read from the efuse and updated in k3_avs_probe(). The default j7200 devicetree and k3_avs driver set OPP_NOM spec frequency and voltage. In the board init file, if K3_OPP_LOW config is enabled, Check if OPP_LOW AVS voltage read from efuse is valid and update frequency (A72 and MSMC) and voltage (VDD_CPU) as per the OPP_LOW spec. [0]: https://www.ti.com/lit/gpn/dra821u (J7200 Datasheet) Test logs: https://gist.github.com/aniket-l/328ad93ed60c2419ed7be9f85e6b6075 - With series applied on master and CONFIG_K3_OPP_LOW enabled in j7200_evm_r5_defconfig - Logs shown with and without efuse register programmed for OPP_0 (Errors out if OPP_0 not found, programs OPP_LOW spec if found) - Voltage update verified using 'i2c md 0x4c 0xe' in u-boot - Frequency update verified using 'k3conf clock dump' in linux --- v4: * Manorit - Update function name to k3_avs_check_opp and update description - Move Kconfig definition to arch/arm/mach-k3/r5/Kconfig - Update commit messages - Fixup patch styling problems - In previous versions, fdt_fixup_a72ss_clock_frequency() assumed a fixed order of assigned-clock-rates in the DT to update clk freqs. This may not always be a valid assumption. So, add a new function get_clock_index_by_dev_id() to search the indices for A72 CPU and MSMC clk IDs and then use that index to update the clock rates in place. - Link to v3: https://lore.kernel.org/u-boot/20241116071615.839623-1-a-limaye@ti.com/ v3: * Manorit - Use more descriptive name for fdt_fixup_a72ss_clock_frequency() and make function static. - Move error prints (with error codes) before else conditions. Helps with code readability to map error print with the function. - Remove k3_avs_set_opp() from board_init_f altogether. Reasoning being that the value being set through k3_avs_set_opp() will anyway be (correctly) overridden by the k3_avs_notify_freq() call later in the boot process, when a72 freq is actually set from clk_k3. - Add msmc clock at the end to preserve current ordering of core and gtc clocks - Add Kconfig dependency on K3_AVS0 and Update commit msg to make it more clear - Link to v2: https://lore.kernel.org/u-boot/20241023130033.1826413-1-a-limaye@ti.com/ v2: * Neha - Fix indentation - Updates to commit msgs - Re-format patches 3/5 and 4/5 with logical changes in each patch - Link to v1: https://lore.kernel.org/u-boot/20241017062911.2241167-1-a-limaye@ti.com/ Reid Tonking (5): arm: dts: k3-j7200-r5-common: Add msmc clk to a72 node misc: k3_avs: Add OPP_LOW voltage and frequency to vd_data misc: k3_avs: Check validity of efuse voltage data arm: mach-k3: j721e-init.c: Add support for CONFIG_K3_OPP_LOW configs: j7200_evm_r5_defconfig: Define K3_OPP_LOW .../arm/dts/k3-j7200-r5-common-proc-board.dts | 10 ++--- arch/arm/mach-k3/Kconfig | 7 ++++ arch/arm/mach-k3/j721e/j721e_init.c | 41 ++++++++++++++++++- configs/j7200_evm_r5_defconfig | 1 + drivers/misc/k3_avs.c | 34 +++++++++++++++ include/k3-avs.h | 2 + 6 files changed, 89 insertions(+), 6 deletions(-) -- 2.47.0

4 12

[PATCH 0/5] Enable AVS support for AM68, AM69 and J784S4
by Neha Malcom Francis 06 Dec '24

06 Dec '24

This series adds AVS support for AM68 SK, AM69 SK and J784S4 EVM. Boot logs: https://gist.github.com/nehamalcom/db5dbf98357ebac46f648c24ad1a17e2 Neha Malcom Francis (4): arm: dts: k3-j784s4-r5: Add VTM node to R5 stage arm: dts: k3-am68-sk-r5-base-board: Add VTM node to R5 stage arch: arm: mach-k3: j784s4_init: Probe AVS driver configs: j784s4_evm_r5_defconfig: Enable AVS Udit Kumar (1): configs: am68_sk_r5: Add AVS Configs arch/arm/dts/k3-am68-sk-r5-base-board.dts | 5 +++++ arch/arm/dts/k3-j784s4-r5.dtsi | 6 ++++++ arch/arm/mach-k3/j784s4/j784s4_init.c | 10 ++++++++++ configs/am68_sk_r5_defconfig | 3 ++- configs/j784s4_evm_r5_defconfig | 4 ++++ 5 files changed, 27 insertions(+), 1 deletion(-) -- 2.34.1

3 9

[PATCH] arm: dts: k3-am68: Enable OSPI boot
by Udit Kumar 06 Dec '24

06 Dec '24

Enable OSPI node to allow OSPI boot on AM68 Signed-off-by: Udit Kumar <u-kumar1(a)ti.com> --- Bootlogs : https://gist.github.com/uditkumarti/bd3fc0690d6daec037a9fd18adc7266d arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi b/arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi index 4b8d73a92d..4ca05f32f0 100644 --- a/arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi +++ b/arch/arm/dts/k3-am68-sk-base-board-u-boot.dtsi @@ -109,10 +109,6 @@ bootph-all; }; -&ospi0 { - status = "disabled"; -}; - &ospi1 { status = "disabled"; }; -- 2.34.1

2 1