November 2022 - U-Boot

[PATCH 1/1] disk: fix blk_get_device_part_str()
by Heinrich Schuchardt 21 Nov '22

21 Nov '22

blk_get_device_part_str() should always initialize all info fields including sys_ind. As a side effect the code is simplified. Replace '(0 ==' by '(!' to conform with Linux coding style. Fixes: 4d907025d6a5 ("sandbox: restore ability to access host fs through standard commands") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- disk/part.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/disk/part.c b/disk/part.c index 2eb30ebe97..5ee60a7fb5 100644 --- a/disk/part.c +++ b/disk/part.c @@ -433,25 +433,17 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str, int part; struct disk_partition tmpinfo; + *dev_desc = NULL; + memset(info, 0, sizeof(*info)); + #if IS_ENABLED(CONFIG_SANDBOX) || IS_ENABLED(CONFIG_SEMIHOSTING) /* * Special-case a pseudo block device "hostfs", to allow access to the * host's own filesystem. */ - if (0 == strcmp(ifname, "hostfs")) { - *dev_desc = NULL; - info->start = 0; - info->size = 0; - info->blksz = 0; - info->bootable = 0; + if (!strcmp(ifname, "hostfs")) { strcpy((char *)info->type, BOOT_PART_TYPE); strcpy((char *)info->name, "Host filesystem"); -#if CONFIG_IS_ENABLED(PARTITION_UUIDS) - info->uuid[0] = 0; -#endif -#ifdef CONFIG_PARTITION_TYPE_GUID - info->type_guid[0] = 0; -#endif return 0; } @@ -462,19 +454,14 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str, * Special-case ubi, ubi goes through a mtd, rather than through * a regular block device. */ - if (0 == strcmp(ifname, "ubi")) { + if (!strcmp(ifname, "ubi")) { if (!ubifs_is_mounted()) { printf("UBIFS not mounted, use ubifsmount to mount volume first!\n"); return -EINVAL; } - *dev_desc = NULL; - memset(info, 0, sizeof(*info)); strcpy((char *)info->type, BOOT_PART_TYPE); strcpy((char *)info->name, "UBI"); -#if CONFIG_IS_ENABLED(PARTITION_UUIDS) - info->uuid[0] = 0; -#endif return 0; } #endif -- 2.37.2

2 1

Re: [PATCH] riscv: use imply instead of select for SPL_SEPARATE_BSS
by Rick Chen 21 Nov '22

21 Nov '22

> From: Zong Li <zong.li(a)sifive.com> > Sent: Wednesday, November 16, 2022 3:09 PM > To: sjg(a)chromium.org; michal.simek(a)amd.com; sean.anderson(a)seco.com; Leo Yu-Chi Liang(梁育齊) <ycliang(a)andestech.com>; Rick Jian-Zhi Chen(陳建志) <rick(a)andestech.com>; u-boot(a)lists.denx.de > Cc: Zong Li <zong.li(a)sifive.com> > Subject: [PATCH] riscv: use imply instead of select for SPL_SEPARATE_BSS > > Use imply instead of select, then it can still be disabled by board-specific defconfig, or be set to n manually. > > Signed-off-by: Zong Li <zong.li(a)sifive.com> > --- > arch/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rick Chen <rick(a)andestech.com>

1 0

[PATCH 1/1] cli: always show cursor
by Heinrich Schuchardt 20 Nov '22

20 Nov '22

We may enter the command line interface in a state where on the remote console the cursor is not shown. Send an escape sequence to enable it. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- common/main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/common/main.c b/common/main.c index 682f3359ea..4e7e7b17d6 100644 --- a/common/main.c +++ b/common/main.c @@ -7,6 +7,7 @@ /* #define DEBUG */ #include <common.h> +#include <ansi.h> #include <autoboot.h> #include <bootstage.h> #include <cli.h> @@ -66,6 +67,9 @@ void main_loop(void) autoboot_command(s); + if (!CONFIG_IS_ENABLED(DM_VIDEO) || CONFIG_IS_ENABLED(VIDEO_ANSI)) + printf(ANSI_CURSOR_SHOW "\n"); + cli_loop(); panic("No CLI available"); } -- 2.37.2

3 12

Broken u-boot on n900 hw (possibly CONFIG_POSITION_INDEPENDENT)
by Pali Rohár 20 Nov '22

20 Nov '22

Hello! Current u-boot from master branch does not work on n900 hw. It does not show anything on display, there just nokia logo. In qemu it is working fine and all tests are passing. Also in qemu is display working without any problem. Could you help me to debug it? Maybe something is printed to serial console? Or maybe serial console could be used for printf-debugging? I just figured out that disabling CONFIG_POSITION_INDEPENDENT u-boot option make it working again. But it requires to restoring older version of lowlevel_init.S file which does not depend on POSITION_INDEPENDENT: git checkout 7c4ad9821758f98db127e9d6864671c906c02d3b -- board/nokia/rx51/lowlevel_init.S And also setting CONFIG_SYS_TEXT_BASE=0x80008000 (to some value in RAM). I'm looking at the POSITION_INDEPENDENT usage and seems that only few boards have it enabled and even less of them are 32-bit ARM. So it is possible that there is bug in POSITION_INDEPENDENT code? I just do not understand how it is possible that u-boot binary is working fine in qemu, but not on the real HW...

4 10

[PATCH v3 0/2] rtc: Add fallbacks for dm functions
by Sean Anderson 20 Nov '22

20 Nov '22

This adds some fallbacks for DM RTC consumers, so they don't have to ifdef out their RTC code. There's some funkiness going on with FSP on x86, but I don't know what the correct behavior is. See patch 1 for details. Changes in v3: - Select SPL_DM_RTC for HAVE_FSP. Before this series, even if just DM_RTC was selected, the DM RTC functions would be forward-declared. This probably would result in funky things at runtime. Changes in v2: - Include linux/errno.h for ENOSYS. This is needed for some mips boards when CONFIG_BLK is enabled for whatever reason. Sean Anderson (2): x86: fsp: Depend on DM_RTC rtc: Add fallbacks for dm functions arch/x86/Kconfig | 2 ++ include/rtc.h | 32 +++++++++++++++++++++++++++++--- 2 files changed, 31 insertions(+), 3 deletions(-) -- 2.35.1.1320.gc452695387.dirty

4 11

[PATCH v9 0/5] eficonfig: add UEFI Secure Boot key maintenance interface
by Masahisa Kojima 20 Nov '22

20 Nov '22

This series adds the UEFI Secure Boot key maintenance interface to the eficonfig command. User can enroll PK, KEK, db and dbx. Source code can be cloned with: $ git clone https://git.linaro.org/people/masahisa.kojima/u-boot.git -b kojima/eficonfig_sbkey_v9 Masahisa Kojima (5): eficonfig: refactor file selection handling eficonfig: expose append entry function eficonfig: refactor change boot order implementation eficonfig: add UEFI Secure Boot Key enrollment interface eficonfig: add "Show Signature Database" menu entry cmd/Makefile | 5 + cmd/eficonfig.c | 201 ++++---- cmd/eficonfig_sbkey.c | 482 ++++++++++++++++++ include/efi_config.h | 12 +- .../py/tests/test_eficonfig/test_eficonfig.py | 1 + 5 files changed, 597 insertions(+), 104 deletions(-) create mode 100644 cmd/eficonfig_sbkey.c -- 2.17.1

3 14

Boot Loader Specification (UAPI Group)
by Sebastian Veit 18 Nov '22

18 Nov '22

Dear devs of U-Boot, I'd like to know if there's already a work in progress on the support of the "fairly new" Boot Loader Specification [1]. Summary of the new spec: Defines a set of file formats and naming conventions to allow distribution independent boot loader menus supportable by multiple bootloaders. Don't confuse this specification with the one you've already implemented for syslinux [2]. It seems like the similar name confused people in the past [3]. Maybe it'll be part of the new bootflow design - that has been introduced in v2022.07 [4] - some time in the future? Thanks in advance, Sebastian Veit [1] https://uapi-group.org/specifications/specs/boot_loader_specification/ [2] https://wiki.syslinux.org/wiki/index.php?title=EXTLINUX [3] https://lists.denx.de/pipermail/u-boot/2018-October/344721.html [4] https://source.denx.de/u-boot/u-boot/-/issues/1

5 4

[PATCH] fdt: Fix bounds check in devfdt_get_addr_index
by Samuel Holland 18 Nov '22

18 Nov '22

reg must contain enough cells for the entire next address/size pair after skipping `index` pairs. The previous code allows an out-of-bounds read when na + ns > 1. Fixes: 69b41388ba45 ("dm: core: Add a new api to get indexed device address") Signed-off-by: Samuel Holland <samuel(a)sholland.org> --- drivers/core/fdtaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/fdtaddr.c b/drivers/core/fdtaddr.c index 91bcd1a2c2..50ea05263e 100644 --- a/drivers/core/fdtaddr.c +++ b/drivers/core/fdtaddr.c @@ -43,7 +43,7 @@ fdt_addr_t devfdt_get_addr_index(const struct udevice *dev, int index) } reg = fdt_getprop(gd->fdt_blob, offset, "reg", &len); - if (!reg || (len <= (index * sizeof(fdt32_t) * (na + ns)))) { + if (!reg || (len < ((index + 1) * sizeof(fdt32_t) * (na + ns)))) { debug("Req index out of range\n"); return FDT_ADDR_T_NONE; } -- 2.37.3

2 4

[PATCH] pinctrl: sunxi: Add P2WI and RSB pinmuxes
by Samuel Holland 18 Nov '22

18 Nov '22

P2WI and RSB are used to communicate with a PMIC. Most SoCs have only one possible pinmux. F1C100s has two possibilities, with different mux values, so omit it until some board needs one of them. Signed-off-by: Samuel Holland <samuel(a)sholland.org> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 061104be056..716dd7b5815 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -338,6 +338,7 @@ static const struct sunxi_pinctrl_function sun6i_a31_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 2 }, /* PL0-PL1 */ + { "s_p2wi", 3 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; @@ -404,6 +405,7 @@ static const struct sunxi_pinctrl_function sun8i_a23_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 3 }, /* PL0-PL1 */ + { "s_rsb", 2 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; @@ -469,6 +471,7 @@ static const struct sunxi_pinctrl_function sun8i_a83t_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 2 }, /* PL8-PL9 */ + { "s_rsb", 2 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; @@ -574,6 +577,7 @@ static const struct sunxi_pinctrl_function sun9i_a80_r_pinctrl_functions[] = { { "gpio_out", 1 }, { "s_i2c0", 2 }, /* PN0-PN1 */ { "s_i2c1", 3 }, /* PM8-PM9 */ + { "s_rsb", 3 }, /* PL0-PL1 */ { "s_uart", 3 }, /* PL0-PL1 */ }; @@ -615,6 +619,7 @@ static const struct sunxi_pinctrl_function sun50i_a64_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 2 }, /* PL8-PL9 */ + { "s_rsb", 2 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; @@ -680,6 +685,7 @@ static const struct sunxi_pinctrl_function sun50i_h6_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 3 }, /* PL0-PL1 */ + { "s_rsb", 2 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; @@ -717,6 +723,7 @@ static const struct sunxi_pinctrl_function sun50i_h616_r_pinctrl_functions[] = { { "gpio_in", 0 }, { "gpio_out", 1 }, { "s_i2c", 3 }, /* PL0-PL1 */ + { "s_rsb", 2 }, /* PL0-PL1 */ { "s_uart", 2 }, /* PL2-PL3 */ }; -- 2.37.4

1 0

[PATCH 1/1] doc: in cmp man-page replace 'tuples' by 'values'
by Heinrich Schuchardt 17 Nov '22

17 Nov '22

The word tuples might be misleading. Suggested-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- doc/usage/cmd/cmp.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/usage/cmd/cmp.rst b/doc/usage/cmd/cmp.rst index 241320d328..8d196ee578 100644 --- a/doc/usage/cmd/cmp.rst +++ b/doc/usage/cmd/cmp.rst @@ -14,20 +14,20 @@ Description ----------- The cmp command is used to compare two memory areas. By default it works on -four byte tuples. By appending .b, .w, .l, .q the size of the tuples is -controlled: +four byte (32-bit) values. By appending .b, .w, .l, .q the size of the +values is controlled: cmp.b - compare 1 byte tuples + compare 1 byte (8-bit) values cmp.w - compare 2 byte tuples + compare 2 byte (16-bit) values cmp.l - compare 4 byte tuples + compare 4 byte (32-bit) values cmp.q - compare 8 byte tuples + compare 8 byte (64-bit) values The parameters are used as follows: -- 2.37.2

2 1