November 2022 - U-Boot

[PATCH v2 0/2] tools: mkimage: cleanups + allow to create legacy image with type flat_dt
by Marc Kleine-Budde 17 Nov '22

17 Nov '22

Hello, the first patch cleans up the error message output if struct image_type_params::set_header is set, the other adds support for creating legacy images with type flat_dt. regards, Marc Changes since v1: - introduce new image type (suggested by Sean Anderson) instead of adding new cmd line parameter

3 9

[PATCH 1/1] doc: add man-page for cmp command
by Heinrich Schuchardt 17 Nov '22

17 Nov '22

Provide a man-page for the cmp command. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- doc/usage/cmd/cmp.rst | 105 ++++++++++++++++++++++++++++++++++++++++++ doc/usage/index.rst | 1 + 2 files changed, 106 insertions(+) create mode 100644 doc/usage/cmd/cmp.rst diff --git a/doc/usage/cmd/cmp.rst b/doc/usage/cmd/cmp.rst new file mode 100644 index 0000000000..241320d328 --- /dev/null +++ b/doc/usage/cmd/cmp.rst @@ -0,0 +1,105 @@ +.. SPDX-License-Identifier: GPL-2.0+: + +cmp command +=========== + +Synopsis +-------- + +:: + + cmp [.b, .w, .l, .q] addr1 addr2 count + +Description +----------- + +The cmp command is used to compare two memory areas. By default it works on +four byte tuples. By appending .b, .w, .l, .q the size of the tuples is +controlled: + +cmp.b + compare 1 byte tuples + +cmp.w + compare 2 byte tuples + +cmp.l + compare 4 byte tuples + +cmp.q + compare 8 byte tuples + +The parameters are used as follows: + +addr1 + Address of the first memory area. + +addr2 + Address of the second memory area. + +count + Number of bytes to compare (as hexadecimal number). + +Example +------- + +In the example below the strings "Hello world\n" and "Hello World\n" are written +to memory and then compared. + +:: + + => mm.b 0x1000000 + 01000000: 00 ? 48 + 01000001: 00 ? 65 + 01000002: 00 ? 6c + 01000003: 00 ? 6c + 01000004: 00 ? 6f + 01000005: 00 ? 20 + 01000006: 00 ? 77 + 01000007: 00 ? 6f + 01000008: 00 ? 72 + 01000009: 00 ? 6c + 0100000a: 00 ? 64 + 0100000b: 00 ? 0d + 0100000c: 00 ? => <INTERRUPT> + => mm.b 0x101000 + 00101000: 00 ? 48 + 00101001: 00 ? 65 + 00101002: 00 ? 6c + 00101003: 00 ? 6c + 00101004: 00 ? 6f + 00101005: 00 ? 20 + 00101006: 00 ? 57 + 00101007: 00 ? 6f + 00101008: 00 ? 72 + 00101009: 00 ? 6c + 0010100a: 00 ? 64 + 0010100b: 00 ? 0d + 0010100c: 00 ? => <INTERRUPT> + => cmp 0x1000000 0x101000 0xc + word at 0x01000004 (0x6f77206f) != word at 0x00101004 (0x6f57206f) + Total of 1 word(s) were the same + => cmp.b 0x1000000 0x101000 0xc + byte at 0x01000006 (0x77) != byte at 0x00101006 (0x57) + Total of 6 byte(s) were the same + => cmp.w 0x1000000 0x101000 0xc + halfword at 0x01000006 (0x6f77) != halfword at 0x00101006 (0x6f57) + Total of 3 halfword(s) were the same + => cmp.l 0x1000000 0x101000 0xc + word at 0x01000004 (0x6f77206f) != word at 0x00101004 (0x6f57206f) + Total of 1 word(s) were the same + => cmp.q 0x1000000 0x101000 0xc + double word at 0x01000000 (0x6f77206f6c6c6548) != double word at 0x00101000 (0x6f57206f6c6c6548) + Total of 0 double word(s) were the same + +Configuration +------------- + +The cmp command is only available if CONFIG_CMD_MEMORY=y. The cmp.q command is +only available if additionally CONFIG_MEM_SUPPORT_64BIT_DATA=y. + +Return value +------------ + +The return value $? is true (0) if the compared memory areas are equal. +The reutrn value is false (1) if the compared memory areas differ. diff --git a/doc/usage/index.rst b/doc/usage/index.rst index f7f03aeac1..b012cfc64b 100644 --- a/doc/usage/index.rst +++ b/doc/usage/index.rst @@ -34,6 +34,7 @@ Shell commands cmd/cat cmd/cbsysinfo cmd/cls + cmd/cmp cmd/conitrace cmd/cyclic cmd/dm -- 2.37.2

2 1

Pull request for efi-2023-01-rc2
by Heinrich Schuchardt 16 Nov '22

16 Nov '22

Dear Tom, The following changes since commit c4ee4fe92e9be120be6d12718273dec6b63cc7d9: Merge tag 'u-boot-imx-20221114' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-11-14 09:33:36 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2023-01-rc2 for you to fetch changes up to a930d69baa958d5f308b3910187c5f3c083fe171: efi_loader: replace a u16_strdup with alloc + memcpy (2022-11-16 08:34:06 +0100) Gitlab CI showed no issues: https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/14127 ---------------------------------------------------------------- Pull request for efi-2023-01-rc2 Documentation: * fix building with Sphinx 5.0+ * man-pages for cmp and bootd commands UEFI: * Avoid unaligned access in efi_file_from_path() * More bug fixes ---------------------------------------------------------------- Heinrich Schuchardt (7): doc: fix documentation of enum gd_flags sandbox: fix documentation of struct host_ops Documentation: man-page for command bootd doc: add man-page for cmp command MAINTAINERS: add UEFI commands to EFI PAYLOAD cmd: remove superfluous if in eficonfig_edit_boot_option efi_loader: improve description of efi_file_from_path() Ilias Apalodimas (4): efi_loader: initialize return values in efi_uninstall_multiple_protocol_interfaces_int() efi_loader: add comments on efi_file_from_path() regarding alignment efi_loader: add missing EFI_CALL when closing a file efi_loader: replace a u16_strdup with alloc + memcpy Masahisa Kojima (1): eficonfig: fix missing variable initialization Quentin Schulz (1): doc: fix build with sphinx 5.0 and later. MAINTAINERS | 4 ++ cmd/eficonfig.c | 4 +- doc/conf.py | 2 +- doc/usage/cmd/bootd.rst | 38 ++++++++++++++ doc/usage/cmd/cmp.rst | 105 ++++++++++++++++++++++++++++++++++++++ doc/usage/index.rst | 2 + include/asm-generic/global_data.h | 2 +- include/sandbox_host.h | 19 +++---- lib/efi_loader/efi_boottime.c | 2 +- lib/efi_loader/efi_file.c | 24 ++++++++- 10 files changed, 183 insertions(+), 19 deletions(-) create mode 100644 doc/usage/cmd/bootd.rst create mode 100644 doc/usage/cmd/cmp.rst

2 1

[PULL] u-boot-riscv/master
by Leo Liang 16 Nov '22

16 Nov '22

Hi Tom, The following changes since commit c4ee4fe92e9be120be6d12718273dec6b63cc7d9: Merge tag 'u-boot-imx-20221114' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2022-11-14 09:33:36 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git for you to fetch changes up to 591e0f878083925e7afff82e1774ba295a7767aa: riscv: enable reset via SBI on PolarFire Icicle Kit (2022-11-15 15:37:17 +0800) CI shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/14105 ---------------------------------------------------------------- - Fix and improve microchip's clock driver to allow sync'ing DTS with linux - Improve the help message in "SBI_V02" Kconfig - Improve DTS property "isa-string" parsing rule ---------------------------------------------------------------- Conor Dooley (6): dt-bindings: clk: add missing clk ids for microchip mpfs clk: microchip: mpfs: convert parent rate acquistion to get_get_rate() clk: microchip: mpfs: fix reference clock handling clk: microchip: mpfs: fix periph clk parentage clk: microchip: mpfs: fix criticality of peripheral clocks riscv: dts: fix the mpfs's reference clock frequency Heinrich Schuchardt (2): riscv: clarify meaning of CONFIG_SBI_V02 riscv: enable reset via SBI on PolarFire Icicle Kit Yu Chien Peter Lin (1): riscv: Fix detecting FPU support in standard extension arch/riscv/Kconfig | 14 +++++++------- arch/riscv/cpu/cpu.c | 14 +++++++++++--- arch/riscv/dts/microchip-mpfs-icicle-kit.dts | 4 ++++ arch/riscv/dts/microchip-mpfs.dtsi | 14 ++++++-------- configs/microchip_mpfs_icicle_defconfig | 2 ++ drivers/clk/microchip/Makefile | 2 +- drivers/clk/microchip/mpfs_clk.c | 37 +++++++++++++++++++++++++++---------- drivers/clk/microchip/mpfs_clk.h | 20 ++++++++++++-------- drivers/clk/microchip/mpfs_clk_cfg.c | 7 +++---- drivers/clk/microchip/mpfs_clk_msspll.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/clk/microchip/mpfs_clk_periph.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------ include/dt-bindings/clock/microchip-mpfs-clock.h | 3 +++ 12 files changed, 249 insertions(+), 83 deletions(-) create mode 100644 drivers/clk/microchip/mpfs_clk_msspll.c Best regards, Leo

2 1

[PATCH] doc: fix build with sphinx 5.0 and later.
by Quentin Schulz 16 Nov '22

16 Nov '22

From: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> Sphinx 5.0 and later fails to build when language is set to None: Warning, treated as error: Invalid configuration value found: 'language = None'. Update your configuration to a valid langauge code. Falling back to 'en' (English) Let's set the language to English since it is the language used for the documentation. Cc: Quentin Schulz <foss+uboot(a)0leil.net> Signed-off-by: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> --- Cc: u-boot(a)lists.denx.de --- doc/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/conf.py b/doc/conf.py index eac3accd56..62c8d31270 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -178,7 +178,7 @@ finally: # # This is also used if you do content translation via gettext catalogs. # Usually you set "language" from the command line for these cases. -language = None +language = 'en' # There are two options for replacing |today|: either, you set today to some # non-false value, then it is used: --- base-commit: d25b11ae9f10a7455fb16680ac2e0e573d02c79e change-id: 20221107-upstream-sphinx-5-language-3a3f21715614 Best regards, -- Quentin Schulz <quentin.schulz(a)theobroma-systems.com>

2 1

Re: Peculiar problem executing boot.scr
by Simon Glass 15 Nov '22

15 Nov '22

+U-Boot Mailing List On Mon, 14 Nov 2022 at 22:24, Terzidis Tasos <terzanasta(a)teemail.gr> wrote: > > Hello, > > > Can you post the whole console output so we can see version, etc.? > Unfortunately I don’t have a serial console, so I will reproduce by writing the monitor output > > Boot.scr.uimg Script is > printenv > fatload mmc 0:1 ${kernel_addr_r} kernel7.img > bootz ${kernel_addr_r} - ${fdt_addr} > > > I manually load and run the script > > U-Boot> Fatload mmc 0:1 0x30000000 boot.scr.uimg > 168 bytes read in 3 ms (54.7 KiB/s) > U-Boot> source 0x30000000 > ## Executing script at 30000000 > ' - try 'help'd ' printenv > 'ailed to load 'kernel7.img > zimage: Bad magic! > ' - try 'help' d ' > > The version is > U-Boot> version > U-Boot 2023.01-rc1-00041-g0cbeed4f66-dirty (Nov 14 2022 - 18:44:50 +0200) > Gcc (Rasbian 10.2.1 -6+rpi1) 10.2.1 20210110 > GNU id (GNU Binutils for Raspbian) 2.35.2 > > > I installed U-boot again at 14 November just in case I made something wrong > > The same error result I get, when let U-boot to automatically read and execute the script after autocount. > > Thank you > > Tasos Terzidis This seems to be a mystery. Probably need to debug U-Boot and narrow down what is happening. I assume that the board is reliable. Regards, Simon > > -----Original Message----- > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Simon Glass > Sent: Tuesday, November 15, 2022 12:51 AM > To: terzanasta(a)yahoo.gr > Cc: u-boot(a)lists.denx.de > Subject: Re: Peculiar problem executing boot.scr > > Hi, > > On Mon, 14 Nov 2022 at 06:50, Tasos Terzidis <terzanasta(a)gmail.com> wrote: > > > > Hello, > > > > I have a very peculiar problem. > > > > I have a very simple boot.scr script so that u-boot can load it and run it. > > > > My set up is a Raspberry 3 B (32 bit) > > > > Sript is > > > > Fatload mmc 0:1 ${kernel_addr_r} kernel7.img > > > > Bootz ${kernel_addr_r} - ${fdt_addr} > > > > > > > > When u-boot stops autocounting, finds the script loads it and the error > > message is > > > > -à ‘ailed to find kernel7.img ß-- > > > > > > > > Instead of F for word Failed, prints ‘ailed. > > > > > > > > If I stop auto counting and enter the commands of script by hand it runs > > and loads kernel as expected > > > > > > > > As a matter of fact whatever command I add to the script gives an error > > > > Example : if I add printenv the error is “can not find command” > > > > > > > > I can not understand what the problem is. > > > > > > > > Has anyone encountered such a problem ?? > > Can you post the whole console output so we can see version, etc.? > > I cannot immediately even find that 'Failed to find %s' string in U-Boot. > > Regards, > Simon > > > -- > This email has been checked for viruses by Avast antivirus software. > www.avast.com

1 0

[PATCH v3 0/5] add support for Theobroma Systems PX30-µQ7 (Ringneck) with Haikou devkit
by Quentin Schulz 15 Nov '22

15 Nov '22

The PX30-uQ7 (Ringneck) SoM is a µQseven-compatible (40mmx70mm, MXM-230 connector) system-on-module from Theobroma Systems[1], featuring the Rockchip PX30. It provides the following feature set: * up to 4GB DDR4 * up to 128GB on-module eMMC (with 8-bit 1.8V interface) * SD card (on a baseboard) via edge connector * Fast Ethernet with on-module TI DP83825I PHY * MIPI-DSI/LVDS * MIPI-CSI * USB - 1x USB 2.0 dual-role - 3x USB 2.0 host * on-module companion controller (STM32 Cortex-M0 or ATtiny), implementing: - low-power RTC functionality (ISL1208 emulation) - fan controller (AMC6821 emulation) - USB<->CAN bridge controller (STM32 only) * on-module Espressif ESP32 for Bluetooth + 2.4GHz WiFi * on-module NXP SE05x Secure Element [1] https://www.theobroma-systems.com/som-product/px30-uq7/ Cheers, Quentin To: Heiko Stuebner <heiko(a)sntech.de> To: Simon Glass <sjg(a)chromium.org> To: Philipp Tomsich <philipp.tomsich(a)vrull.eu> To: Klaus Goger <klaus.goger(a)theobroma-systems.com> Cc: Quentin Schulz <foss+uboot(a)0leil.net> Cc: u-boot(a)lists.denx.de Cc: Kever Yang <kever.yang(a)rock-chips.com> Signed-off-by: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> --- Changes in v3: - added Rb, - rebased on top of master, - fixed http links to use u instead of encoded µ, - updated u-boot,mmc-env-offset from 16KB to 20KB to avoid GPT corruption when saving env + reduced env size to 0x3000 to adapt to the offset change, - removed video support from defconfig as there's no display support ATM, - Link to v2: https://lore.kernel.org/r/20221017-upstream-ringneck-v2-0-0f03912ebac2@theo… Changes in v2: - updated DTS from Linux with v2 of the Linux kernel patch series, - updated node nade for bios-disable-override-hog to match v2 of Linux kernel, - removed uapi input patch since it is not needed anymore, --- Quentin Schulz (5): rockchip: px30: fix CONFIG_IRAM_BASE rockchip: px30: list possible SPL boot devices rockchip: px30: insert u-boot,spl-boot-device into U-Boot device tree arm64: dts: rockchip: sync px30 DTSI with Linux kernel next-20221114 rockchip: add support for PX30 Ringneck SoM on Haikou Devkit arch/arm/dts/px30-ringneck-haikou-u-boot.dtsi | 91 +++++ arch/arm/dts/px30-ringneck-haikou.dts | 232 +++++++++++++ arch/arm/dts/px30-ringneck.dtsi | 382 +++++++++++++++++++++ arch/arm/dts/px30.dtsi | 28 +- arch/arm/mach-rockchip/px30/Kconfig | 25 ++ arch/arm/mach-rockchip/px30/px30.c | 56 +++ board/theobroma-systems/ringneck_px30/Kconfig | 18 + board/theobroma-systems/ringneck_px30/MAINTAINERS | 9 + board/theobroma-systems/ringneck_px30/Makefile | 7 + board/theobroma-systems/ringneck_px30/README | 69 ++++ .../ringneck_px30/ringneck-px30.c | 175 ++++++++++ configs/ringneck-px30_defconfig | 127 +++++++ doc/board/rockchip/rockchip.rst | 1 + include/configs/px30_common.h | 3 +- include/configs/ringneck_px30.h | 15 + 15 files changed, 1233 insertions(+), 5 deletions(-) --- base-commit: c4ee4fe92e9be120be6d12718273dec6b63cc7d9 change-id: 20221017-upstream-ringneck-57abd09a7aaa Best regards, -- Quentin Schulz <quentin.schulz(a)theobroma-systems.com>

1 5

RE: [TF-A] Re: [RFC] Proposed location to host the firmware handoff specification.
by Dan Handley 15 Nov '22

15 Nov '22

Hi all Just picking up this old thread again... There seemed to be general agreement to host the firmware hand-off spec in a separate repo with separate maintainers at TrustedFirmware.org, at least initially. Arm intends to progress with the initial population of this repo. We intend to use the CC-BY-SA-4.0 (https://spdx.org/licenses/CC-BY-SA-4.0.html) license, the same as used for EBBR (https://github.com/ARM-software/ebbr). Please say if you have any objections to this. We will also seek approval from the TrustedFirmware.org board. Regards Dan.

4 4

[PATCH 1/1] doc: fix documentation of enum gd_flags
by Heinrich Schuchardt 15 Nov '22

15 Nov '22

Correct GD_FLG_CYCLIC_RUNNING documentation to match Sphinx style. Fixes: d7de5ef62935 ("cyclic: use a flag in gd->flags for recursion protection") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/global_data.h b/include/asm-generic/global_data.h index 02ad8ca595..88829126fb 100644 --- a/include/asm-generic/global_data.h +++ b/include/asm-generic/global_data.h @@ -651,7 +651,7 @@ enum gd_flags { */ GD_FLG_FDT_CHANGED = 0x100000, /** - * GD_FLG_CYCLIC_RUNNING: cyclic_run is in progress + * @GD_FLG_CYCLIC_RUNNING: cyclic_run is in progress */ GD_FLG_CYCLIC_RUNNING = 0x200000, }; -- 2.37.2

4 4

[PATCH] spi: cadence-qspi: use STIG mode for small reads
by Dhruva Gole 15 Nov '22

15 Nov '22

Fix the issue where some flash chips like cypress S25HS256T for example return the value of the same register once a SPI transaction starts. So for example if read reg of 0x2 is requested and we start reading registers in DAC mode we start reading 4 byte aligned ie. 0x0, 0x1, 0x2 and then 0x3. In such a case the flash chip keeps returning the value of 0x0 even though we actually want the value of 0x2. STIG mode solves the above issue by not issuing a read continuosly for 4 byte aligned data. Signed-off-by: Dhruva Gole <d-gole(a)ti.com> --- Tested using a TI AM 625 SK-EVM with a QSPI Flash on board. sf read, upate and also booted up using xSPI mode till uboot prompt. drivers/spi/cadence_qspi.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c index ab0a681c8376..6f2924fe4515 100644 --- a/drivers/spi/cadence_qspi.c +++ b/drivers/spi/cadence_qspi.c @@ -307,7 +307,22 @@ static int cadence_spi_mem_exec_op(struct spi_slave *spi, priv->is_decoded_cs); if (op->data.dir == SPI_MEM_DATA_IN && op->data.buf.in) { - if (!op->addr.nbytes) + /* + * In some cases there is a layer of digital logic in front of the QSPI + * /OSPI Driver when used in DAC mode. This digital logic layer ensures + * that even if we are trying to read 1 or 2 bytes of data, it will + * always align it to 4 bytes from a 4byte aligned address. In some + * flash chips like cypress for example, if we try to read some regs + * in DAC mode then it keeps sending the value of the first register + * who was requested and inorder to read the next register we have to + * stop and re-initiate a new transaction. + * This causes wrong registers values to be read than what is desired + * when registers are read in DAC mode. Hence if the data.nbytes + * is very less then do not use DAC mode. Registers are generally only + * 1-2 bytes and thus switching to STIG mode will be a work around. + */ + if (!op->addr.nbytes || + op->data.nbytes < CQSPI_STIG_DATA_LEN_MAX) mode = CQSPI_STIG_READ; else mode = CQSPI_READ; -- 2.25.1

1 1