January 2019 - U-Boot

[U-Boot] TPL max size for RK3288 ?
by Tom Rini 21 Jan '19

21 Jan '19

Hey, So I was playing with how to make our linker scripts more re-usable and have the kinds of link error on excessive size checks that we find really useful to avoid introducing run time failures, and I found something. On rk3288 we don't size TPL_MAX_SIZE, only for rk3368. Is there a reasonable one to set here? Thanks! -- Tom

2 1

[U-Boot] [PATCH] dtoc: make generated platdata structs const
by Simon Goldschmidt 21 Jan '19

21 Jan '19

The platdata initialization structs are currently generated into .rwdata. Make sure the are put into .rodata by generating them as const. Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt(a)gmail.com> --- tools/dtoc/dtb_platdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index 6cb1259446..ca580b45d4 100644 --- a/tools/dtoc/dtb_platdata.py +++ b/tools/dtoc/dtb_platdata.py @@ -461,7 +461,7 @@ class DtbPlatdata(object): """ struct_name, _ = get_compat_name(node) var_name = conv_name_to_c(node.name) - self.buf('static struct %s%s %s%s = {\n' % + self.buf('static const struct %s%s %s%s = {\n' % (STRUCT_PREFIX, struct_name, VAL_PREFIX, var_name)) for pname, prop in node.props.items(): if pname in PROP_IGNORE_LIST or pname[0] == '#': -- 2.17.1

4 5

[U-Boot] [PATCH v4 0/9] cmd: add efitool for efi environment
by AKASHI Takahiro 21 Jan '19

21 Jan '19

This patch set is a collection of patches to enhance efi user interfaces /commands. It will help improve user experience on efi boot and make it more usable *without* edk2's shell utility. Let's see how it works: => efitool boot add 1 SHELL mmc 0:1 /Shell.efi "" => efitool boot add 2 HELLO mmc 0:1 /hello.efi "" => efitool boot dump Boot0001: attributes: A-- (0x00000001) label: SHELL file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\Shell.efi data: Boot0002: attributes: A-- (0x00000001) label: HELLO file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\hello.efi data: => efitool boot order 1 2 => efitool boot order 1: Boot0001: SHELL 2: Boot0002: HELLO => run -e Boot0002 (or bootefi bootmgr - 2) ; '-' means no dtb specified WARNING: booting without device tree Booting: HELLO ## Starting EFI application at 000000007db8b040 ... Hello, world! ## Application terminated, r = 0 => env set -e PlatformLang en ; important! (or you can do "efitool setvar PlatformLang en") => env print -e Boot0001: {boot,run}(blob) 00000000: 01 00 00 00 68 00 53 00 ....h.S. 00000010: 48 00 45 00 4c 00 4c 00 H.E.L.L. 00000020: 00 00 01 04 14 00 b9 73 .......s 00000030: 1d e6 84 a3 cc 4a ae ab .....J.. 00000040: 82 e8 28 f3 62 8b 03 1a ..(.b... 00000050: 05 00 00 03 1a 05 00 00 ........ 00000060: 04 01 2a 00 01 00 00 00 ..*..... 00000070: 00 08 00 00 00 00 00 00 ........ 00000080: 00 00 04 00 00 00 00 00 ........ 00000090: ba 46 62 08 00 00 00 00 .Fb..... 000000a0: 00 00 00 00 00 00 00 00 ........ 000000b0: 01 01 04 04 1c 00 5c 00 ......\. 000000c0: 5c 00 53 00 68 00 65 00 \.S.h.e. 000000d0: 6c 00 6c 00 2e 00 65 00 l.l...e. 000000e0: 66 00 69 00 00 00 7f ff f.i.... 000000f0: 04 00 00 ... Boot0002: {boot,run}(blob) 00000000: 01 00 00 00 68 00 48 00 ....h.H. 00000010: 45 00 4c 00 4c 00 4f 00 E.L.L.O. 00000020: 00 00 01 04 14 00 b9 73 .......s 00000030: 1d e6 84 a3 cc 4a ae ab .....J.. 00000040: 82 e8 28 f3 62 8b 03 1a ..(.b... 00000050: 05 00 00 03 1a 05 00 00 ........ 00000060: 04 01 2a 00 01 00 00 00 ..*..... 00000070: 00 08 00 00 00 00 00 00 ........ 00000080: 00 00 04 00 00 00 00 00 ........ 00000090: ba 46 62 08 00 00 00 00 .Fb..... 000000a0: 00 00 00 00 00 00 00 00 ........ 000000b0: 01 01 04 04 1c 00 5c 00 ......\. 000000c0: 5c 00 68 00 65 00 6c 00 \.h.e.l. 000000d0: 6c 00 6f 00 2e 00 65 00 l.o...e. 000000e0: 66 00 69 00 00 00 7f ff f.i.... 000000f0: 04 00 00 ... BootOrder: {boot,run}(blob) 00000000: 01 00 02 00 .... OsIndicationsSupported: {ro,boot}(blob) 00000000: 00 00 00 00 00 00 00 00 ........ PlatformLang: {boot,run}(blob) 00000000: 65 6e en => run -e Boot0001 or bootefi bootmgr (UEFI shell ...) "setvar" command now supports efi shell-like syntax: => env set -e foo =S\"akashi\" =0x012345 =Habcdef => env print -e foo foo: {boot,run}(blob) 00000000: 61 6b 61 73 68 69 45 23 akashiE# 00000010: 01 00 ab cd ef ..... Other useful sub commands are: => efitool devices ; print uefi devices => efitool drivers ; print uefi drivers => efitool dh ; print uefi handles => efitool images ; print loaded images => efitool memmap ; dump uefi memory map Enjoy! -Takahiro Akashi Changes in v4 (Jan 15, 2019) * rename the command name from efishell to efitool * use efi_uintn_t for "size" if appropriate * correct a help text for "boot add" sub-command * "boot" sub-command always takes a hexadecimal number * use systab.boottime directly instead of a local variable, bs * fix a bug in "setvar" sub-command * fix a bug in "devices" and "dh" sub-command * fix a bug in "memmap" sub-command * add "boot next" sub-command to set BootNext variable * "drivers" sub-command prints more useful info, including a driver's name which originates from a corresponding u-boot efi driver * "dh" sub-commands prints more useful info, including a list of protocols which are bound to a given handle Changes in v3 (Dec 18, 2018) * split v2 into two separate patch series * add CONFIG_CMD_EFISHELL to enable/disable efishell command * add missing free() at several places in efishell command Changes in v2 (Nov 5, 2018) * modify efi_dp_from_name() for use in efishell * rename efi_marshal_load_option() to efi_serialize_load_option(), taking a "struct efi_load_option" as an argument * improve a format in dumping uefi variables * enhance a setvar syntax as efi's shell does * change a syntax from "bootefi bootmgr -2" to "bootefi bootmgr - 2" * add -e option to run command * add -e option to env command * add more sub-commands AKASHI Takahiro (9): cmd: add efitool command cmd: efitool: add devices command efi_driver: add name to driver binding protocol cmd: efitool: add drivers command cmd: efitool: add dh command cmd: efitool: add images command cmd: efitool: add memmap command cmd: efitool: export uefi variable helper functions cmd: env: add "-e" option for handling UEFI variables cmd/Kconfig | 10 + cmd/Makefile | 1 + cmd/efitool.c | 1103 +++++++++++++++++++++++++++++++++++ cmd/nvedit.c | 61 +- include/command.h | 4 + include/efi_driver.h | 1 + lib/efi_driver/efi_uclass.c | 1 + 7 files changed, 1179 insertions(+), 2 deletions(-) create mode 100644 cmd/efitool.c -- 2.19.1

3 30

[U-Boot] [PATCH v2 0/2] efi_loader: add GetNextVariableName
by AKASHI Takahiro 21 Jan '19

21 Jan '19

In this patch, GetNextVariableName runtime service will be implemented. Changes in v2 (Jan 21, 2019) * update variable_name_size in GetNextVariableName * add more comments * change some internal variable names AKASHI Takahiro (2): efi_loader: implement GetNextVariableName() efi_selftest: fix variables test for GetNextVariableName() lib/efi_loader/efi_variable.c | 154 +++++++++++++++++++++- lib/efi_selftest/efi_selftest_variables.c | 13 +- 2 files changed, 160 insertions(+), 7 deletions(-) -- 2.19.1

2 3

[U-Boot] [PATCH 00/18] rockchip: Add support for Bob Chromebook
by Simon Glass 21 Jan '19

21 Jan '19

This series adds basic support for Bob which is based on RK3399. Quite a bit of work remains to get this into fully working condition. This series is based on the rockchip pinctrl drivers series by David Wu. Simon Glass (18): lib: Allow using display_buffer() in SPL clk: Improve debug message in clk_set_default_rates() gpio: Use more command-specific enums values gpio: Add a simple GPIO API for SPL rockchip: Add mention of other boards rockchip: Drop note about supporting other SoCs rockchip: Bring in device tree files for rk3399-gru rockchip: Adjust rk3399 device tree to be closer to linux rockchip: evb_rk3399: Tidy up the README rockchip: Clarify docs on SPI writing rockchip: Allow booting from SPI rockchip: Add settings for Samsung LPDDR3 4GB SDRAM 1866MHz rockchip: clk: Add mention of four new clocks rockchip: Tidy up board include-file ordering rockchip: rk3399: Add ROCKCHIP_DEVICE_SETTINGS to set env rockchip: Implement spl_gpio in the GPIO driver rockchip: gru: Add extra device-tree settings rockchip: Add support for chromebook_bob arch/arm/dts/rk3399-gru-bob.dts | 80 + arch/arm/dts/rk3399-gru-chromebook.dtsi | 398 +++++ arch/arm/dts/rk3399-gru-kevin.dts | 309 ++++ arch/arm/dts/rk3399-gru.dtsi | 844 +++++++++ arch/arm/dts/rk3399-op1-opp.dtsi | 141 ++ .../rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi | 1542 +++++++++++++++++ arch/arm/dts/rk3399.dtsi | 432 ++++- arch/arm/include/asm/arch-rockchip/gpio.h | 29 + .../arm/include/asm/arch-rockchip/sys_proto.h | 3 + arch/arm/mach-rockchip/rk3036-board.c | 2 +- arch/arm/mach-rockchip/rk3188-board-spl.c | 2 +- arch/arm/mach-rockchip/rk3188-board.c | 2 +- arch/arm/mach-rockchip/rk322x-board.c | 2 +- arch/arm/mach-rockchip/rk3368-board-spl.c | 2 +- arch/arm/mach-rockchip/rk3368-board-tpl.c | 4 +- arch/arm/mach-rockchip/rk3399-board-spl.c | 49 +- arch/arm/mach-rockchip/rk3399/Kconfig | 10 + arch/arm/mach-rockchip/spl-boot-order.c | 3 + board/google/gru/Kconfig | 15 + board/google/gru/MAINTAINERS | 6 + board/google/gru/Makefile | 5 + board/google/gru/gru.c | 16 + board/rockchip/evb_rk3399/README | 33 +- cmd/gpio.c | 37 +- configs/chromebook_bob_defconfig | 100 ++ doc/README.rockchip | 58 +- drivers/clk/clk-uclass.c | 4 +- drivers/clk/rockchip/clk_rk3399.c | 12 + drivers/gpio/rk_gpio.c | 46 + include/configs/gru.h | 18 + include/configs/rk3399_common.h | 5 + include/spl_gpio.h | 62 + lib/display_options.c | 4 +- 33 files changed, 4159 insertions(+), 116 deletions(-) create mode 100644 arch/arm/dts/rk3399-gru-bob.dts create mode 100644 arch/arm/dts/rk3399-gru-chromebook.dtsi create mode 100644 arch/arm/dts/rk3399-gru-kevin.dts create mode 100644 arch/arm/dts/rk3399-gru.dtsi create mode 100644 arch/arm/dts/rk3399-op1-opp.dtsi create mode 100644 arch/arm/dts/rk3399-sdram-lpddr3-samsung-4GB-1866.dtsi create mode 100644 board/google/gru/Kconfig create mode 100644 board/google/gru/MAINTAINERS create mode 100644 board/google/gru/Makefile create mode 100644 board/google/gru/gru.c create mode 100644 configs/chromebook_bob_defconfig create mode 100644 include/configs/gru.h create mode 100644 include/spl_gpio.h -- 2.20.1.97.g81188d93c3-goog

3 20

Re: [U-Boot] Convert Pico-Pi i.MX7D to DM
by Fabio Estevam 20 Jan '19

20 Jan '19

Hi Joris, [Please keep the list on Cc] On Sun, Jan 20, 2019 at 3:27 PM Joris Offouga <offougajoris(a)gmail.com> wrote: > I convert I2C first , it work but pmic function return wrong error : > > read error from device: 9df65458 register: 0x3! > PMIC: PFUZE3000 DEV_ID=0x18764000 REV_ID=0xfffffffb > read error from device: 9df65458 register: 0x69! > write error to device: 9df65458 register: 0x23! > write error to device: 9df65458 register: 0x31! > write error to device: 9df65458 register: 0x21! > write error to device: 9df65458 register: 0x2f! > read error from device: 9df65458 register: 0x2e! > write error to device: 9df65458 register: 0x2e! > > When DM_USB is enable, I use dfu 0 mmc 0 for update spl and u-boot. SPL > update normally but u-boot.img is causing an error : > > #Deferred dfu_flush() failed!=> > > For the moment here is the result of the conversion : > > U-Boot SPL 2019.01-rc3-dirty (Jan 20 2019 - 18:17:05 +0100) > Trying to boot from USB SDP > SDP: initialize... > SDP: handle requests... > Downloading file of size 553025 to 0x877fffc0... done > Jumping to header at 0x877fffc0 > Header Tag is not an IMX image > > U-Boot 2019.01-rc3-dirty (Jan 20 2019 - 18:17:05 +0100) Could you please use a more recent U-Boot? 2019.01 has been released already. > CPU: Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz) > CPU: Commercial temperature grade (0C to 95C) at 48C > Reset cause: POR > Model: TechNexion PICO-IMX7D Board and PI baseboard > Board: i.MX7D PICOSOM > DRAM: 512 MiB > read error from device: 9df65458 register: 0x3! > PMIC: PFUZE3000 DEV_ID=0x18764000 REV_ID=0xfffffffb > read error from device: 9df65458 register: 0x69! > write error to device: 9df65458 register: 0x23! > write error to device: 9df65458 register: 0x31! > write error to device: 9df65458 register: 0x21! > write error to device: 9df65458 register: 0x2f! > read error from device: 9df65458 register: 0x2e! > write error to device: 9df65458 register: 0x2e! > MMC: FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0 > Loading Environment from MMC... OK > In: serial@30a70000 > Out: serial@30a70000 > Err: serial@30a70000 > Net: eth0: ethernet@30be0000 > Hit any key to stop autoboot: 0 At least the Ethernet GPIO error is gone :-) Could you please post your patch as RFC to the list so that we can try to understand what is going wrong? Thanks

1 0

[U-Boot] [PATCH v2 1/1] powerpc: enabled building with CONFIG_DM=y
by Heinrich Schuchardt 20 Jan '19

20 Jan '19

Moving to the driver model requires CONFIG_DM to be enabled. Currently several boards like kmeter1_defconfig produce a build error when CONFIG_DM is enabled: In file included from include/common.h:35, from ./arch/powerpc/include/asm/fsl_lbc.h:10, from include/mpc83xx.h:10, from ./arch/powerpc/include/asm/ppc.h:27, from ./arch/powerpc/include/asm/u-boot.h:18, from include/dm/of.h:10, from include/dm/ofnode.h:12, from include/dm/device.h:13, from include/linux/mtd/mtd.h:26, from drivers/mtd/mtdconcat.c:25: include/image.h: In function ‘image_check_target_arch’: include/image.h:846:3: error: #error "please define IH_ARCH_DEFAULT in your arch asm/u-boot.h" # error "please define IH_ARCH_DEFAULT in your arch asm/u-boot.h" ^~~~~ include/image.h:848:31: error: ‘IH_ARCH_DEFAULT’ undeclared (first use in this function); did you mean ‘IH_ARCH_COUNT’? return image_check_arch(hdr, IH_ARCH_DEFAULT); The error can be avoided by moving the definition of IH_ARCH_DEFAULT before #include <asm/ppc.h> Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 move the comment too --- arch/powerpc/include/asm/u-boot.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/u-boot.h b/arch/powerpc/include/asm/u-boot.h index 9e7e2d45e8..1841565d0a 100644 --- a/arch/powerpc/include/asm/u-boot.h +++ b/arch/powerpc/include/asm/u-boot.h @@ -13,11 +13,11 @@ #ifndef __U_BOOT_H__ #define __U_BOOT_H__ +/* For image.h:image_check_target_arch() */ +#define IH_ARCH_DEFAULT IH_ARCH_PPC + /* Use the generic board which requires a unified bd_info */ #include <asm-generic/u-boot.h> #include <asm/ppc.h> -/* For image.h:image_check_target_arch() */ -#define IH_ARCH_DEFAULT IH_ARCH_PPC - #endif /* __U_BOOT_H__ */ -- 2.20.1

1 0

[U-Boot] [PATCH] armv8: layerscape: move TZASC and TZPC configs to Kconfig
by Rajesh Bhagat 20 Jan '19

20 Jan '19

Moves FSL_TZASC_400 and FSL_TZPC_BP147 configs to Kconfig for LS1088A and LS2088A platforms. Signed-off-by: Rajesh Bhagat <rajesh.bhagat(a)nxp.com> --- arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 9 +++++++++ arch/arm/include/asm/arch-fsl-layerscape/config.h | 3 --- include/configs/ls2080a_common.h | 1 - scripts/config_whitelist.txt | 2 -- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig index 01c5068ab6..bb480ab270 100644 --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig @@ -113,6 +113,8 @@ config ARCH_LS1088A select SYS_FSL_SRDS_1 select SYS_FSL_SRDS_2 select FSL_TZASC_1 + select FSL_TZASC_400 + select FSL_TZPC_BP147 select ARCH_EARLY_INIT_R select BOARD_EARLY_INIT_F select SYS_I2C_MXC @@ -145,6 +147,8 @@ config ARCH_LS2080A select SYS_FSL_SRDS_2 select FSL_TZASC_1 select FSL_TZASC_2 + select FSL_TZASC_400 + select FSL_TZPC_BP147 select SYS_FSL_ERRATUM_A008336 if !TFABOOT select SYS_FSL_ERRATUM_A008511 if !TFABOOT select SYS_FSL_ERRATUM_A008514 if !TFABOOT @@ -404,6 +408,11 @@ config FSL_TZASC_1 config FSL_TZASC_2 bool +config FSL_TZASC_400 + bool + +config FSL_TZPC_BP147 + bool endmenu menu "Layerscape clock tree configuration" diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h index d4f80a24cd..903d5096c7 100644 --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h @@ -26,7 +26,6 @@ #ifndef L1_CACHE_BYTES #define L1_CACHE_SHIFT 6 #define L1_CACHE_BYTES BIT(L1_CACHE_SHIFT) -#define CONFIG_FSL_TZASC_400 #endif #define CONFIG_SYS_FSL_OCRAM_BASE 0x18000000 /* initial RAM */ @@ -121,8 +120,6 @@ #define CONFIG_SYS_FSL_NUM_CC_PLLS 3 #define CONFIG_SYS_FSL_CLUSTER_CLOCKS { 1, 1 } #define CONFIG_GICV3 -#define CONFIG_FSL_TZPC_BP147 -#define CONFIG_FSL_TZASC_400 #define CONFIG_SYS_PAGE_SIZE 0x10000 #define SRDS_MAX_LANES 4 diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h index 235a757f75..bc6a6c1924 100644 --- a/include/configs/ls2080a_common.h +++ b/include/configs/ls2080a_common.h @@ -10,7 +10,6 @@ #define CONFIG_REMAKE_ELF #define CONFIG_FSL_LAYERSCAPE #define CONFIG_GICV3 -#define CONFIG_FSL_TZPC_BP147 #include <asm/arch/stream_id_lsch3.h> #include <asm/arch/config.h> diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index e2c2889acf..bbdbbbcc70 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -675,8 +675,6 @@ CONFIG_FSL_SGMII_RISER CONFIG_FSL_SPI_INTERFACE CONFIG_FSL_TBCLK_EXTRA_DIV CONFIG_FSL_TRUST_ARCH_v1 -CONFIG_FSL_TZASC_400 -CONFIG_FSL_TZPC_BP147 CONFIG_FSL_USDHC CONFIG_FSL_VIA CONFIG_FSMC_NAND_BASE -- 2.17.1

1 0

[U-Boot] test vs itest command confusion when using setexpr
by Jörg Krause 19 Jan '19

19 Jan '19

Hi, I noticed a difference between the `test` and the `itest` command when using `setexpr`: Running the test vs the itest command in the shell: ``` => setexpr i 0xf; while test ${i} -gt 0; do echo $i; setexpr i ${i} - 1; done => setexpr i 0xf; while itest ${i} -gt 0; do echo $i; setexpr i ${i} - 1; done f e d c b a 9 8 7 6 5 4 3 2 1 => ``` The difference between the test and the itest command is that the integer operations for the test command is done using the base of 10 while for the itest command the operations are done using a base of 16. lib/test.c ``` simple_strtol(ap[0], NULL, 10) > simple_strtol(ap[2], NULL, 10); ``` lib/itest.c ``` simple_strtol(s, NULL, 16) > simple_strtol(t, NULL, 16); ``` As setexpr stores the variables as hex values, it becomes obvious why `itest` works, but `test` does not. Is this different behaviour intended? Best regards Jörg Krause

1 0

[U-Boot] [PATCH v3 0/5] Migrate BOUNCE_BUFFER
by Philipp Tomsich 19 Jan '19

19 Jan '19

5 16