January 2019 - U-Boot

[U-Boot] [PATCH v2 0/3] Introduce regulator_set_enable_if_allowed()
by Lokesh Vutla 21 Jan '19

21 Jan '19

As per the discussion happenned here[1], introducing a new api regulator_set_enable_if_allowed() that discards certain error cases where consumer driver might not be intrested in. Also using the same api for omap_hsmmc driver which fixes the boot on dra7-evm. [1] https://patchwork.ozlabs.org/patch/1018222/ Changes since v1: - Add dm test for regulator_set_enable_if_allowed. Lokesh Vutla (3): Revert "power: regulator: Return success on attempt to disable an always-on regulator" power: regulator: Introduce regulator_set_enable_if_allowed api mmc: omap_hsmmc: Use regulator_set_enable_if_allowed for enabling regulator drivers/mmc/omap_hsmmc.c | 16 ++++++++-------- drivers/power/regulator/regulator-uclass.c | 13 ++++++++++++- include/power/regulator.h | 11 +++++++++++ test/dm/regulator.c | 21 +++++++++++++++++++++ 4 files changed, 52 insertions(+), 9 deletions(-) -- 2.19.2

3 7

[U-Boot] [PATCH 1/1] efi_loader: do not use symbolic links
by Heinrich Schuchardt 21 Jan '19

21 Jan '19

Symbolic links are not supported on all file systems, e.g. not on FAT. So it is not wise to use them in our source tree. Use a qualified path to refer to lib/efi_loader/efi_freestanding.c in scripts/Makefile.lib instead. Reported-by: Alexander Graf <agraf(a)suse.de> Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- Hello Alex, may be it is better to merge this patch with efi-next commit 78501c873594 ("efi_loader: use freestanding library for efi apps") to avoid trouble. But this would require that you shuffle the commits on the efi-next branch. Best regards Heinrich --- lib/efi_selftest/efi_freestanding.c | 1 - scripts/Makefile.lib | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) delete mode 120000 lib/efi_selftest/efi_freestanding.c diff --git a/lib/efi_selftest/efi_freestanding.c b/lib/efi_selftest/efi_freestanding.c deleted file mode 120000 index 4b7edd52bd..0000000000 --- a/lib/efi_selftest/efi_freestanding.c +++ /dev/null @@ -1 +0,0 @@ -../efi_loader/efi_freestanding.c \ No newline at end of file diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 4facb76ace..9e331ee9d9 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -389,7 +389,7 @@ $(obj)/efi_reloc.o: $(srctree)/arch/$(ARCH)/lib/$(EFI_RELOC:.o=.c) $(recordmcoun $(call cmd,force_checksrc) $(call if_changed_rule,cc_o_c) -$(obj)/%_efi.so: $(obj)/%.o $(obj)/efi_crt0.o $(obj)/efi_reloc.o $(obj)/efi_freestanding.o +$(obj)/%_efi.so: $(obj)/%.o $(obj)/efi_crt0.o $(obj)/efi_reloc.o $(srctree)/lib/efi_loader/efi_freestanding.o $(call cmd,efi_ld) # ACPI -- 2.20.1

1 0

[U-Boot] [PATCH] buildman: fix typo
by Chris Packham 21 Jan '19

21 Jan '19

Fix a typo in the error message from CheckOutputDir(). Signed-off-by: Chris Packham <judge.packham(a)gmail.com> --- tools/buildman/control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index 27916d3c355d..fcf531c5f143 100644 --- a/tools/buildman/control.py +++ b/tools/buildman/control.py @@ -99,7 +99,7 @@ def CheckOutputDir(output_dir): cwd_path = os.path.realpath('.') while True: if os.path.realpath(path) == cwd_path: - Print("Cannot use output directory '%s' since it is within the current directtory '%s'" % + Print("Cannot use output directory '%s' since it is within the current directory '%s'" % (path, cwd_path)) sys.exit(1) parent = os.path.dirname(path) -- 2.20.1

2 1

[U-Boot] [PATCH v2 0/7] Fixes for previous -dm pull request
by Simon Glass 21 Jan '19

21 Jan '19

It turns out that the 'clang' support in buildman did not actually work, i.e. it failed to build with clang. This is because the U-Boot Makefile overrides the environment variables supplied by buildman. This series fixes that as well as an EFI loader warning that would be introduced by checking log() arguments. This is sent as a new series on top of dm/master. Changes in v2: - Use the command line instead of environment for make variables - Drop patches previously applied - Add fixes needed to get clang building running Simon Glass (7): efi_loader: Add a wchar_t cast in efi_file_open() log: Check printf() arguments buildman: Add support for building with clang travis: Use buildman for building with clang net: Fix error handling in sb_eth_raw_ofdata_to_platdata() buildman: Write the environment out to an 'env' file buildman: Fix tabs in GetWrapper() .travis.yml | 13 +++------- drivers/net/sandbox-raw.c | 9 ++++--- include/log.h | 3 ++- lib/efi_loader/efi_file.c | 4 ++-- tools/buildman/README | 10 ++++++++ tools/buildman/builderthread.py | 4 ++++ tools/buildman/cmdline.py | 2 ++ tools/buildman/control.py | 2 +- tools/buildman/toolchain.py | 42 ++++++++++++++++++++++++++++----- 9 files changed, 64 insertions(+), 25 deletions(-) -- 2.20.1.97.g81188d93c3-goog

4 18

[U-Boot] [PATCH v3 00/10] samsung: Tidy up sound, DM_MMC drop dead code
by Simon Glass 21 Jan '19

21 Jan '19

This series was previously sent as a v1 without a cover letter. Since then I have added a few more patches: - Support for spring's audio codec - Dropping unused MMC and audio code - Removing unused fdt_compat_id values Changes in v3: - Fix s3p_goni typo - Fix remaining 'return -1' statements to use a real error - Drop patch 1, previously applied Changes in v2: - Remove stranded comments in the header files - Update to convert s5p_goni also - Add new patches as per the cover letter Simon Glass (10): Convert CONFIG_BOARD_TYPES to Kconfig exynos: Drop duplicate 'model' line exynos: Convert to use CONFIG_BLK sound: Add a driver for max98088 spring: Update sound to use max98088 codec spring: Update flashmap details samsung: Drop board_enable_audio_codec() samsung: mmc: Drop old MMC init code fdt: samsung: Drop unused fdt_compat_id values fdt: tegra: Drop COMPAT_AMS_AS3722 arch/arm/dts/exynos5250-spring.dts | 77 +++-- arch/arm/mach-exynos/Kconfig | 7 + arch/arm/mach-exynos/include/mach/mmc.h | 2 - arch/arm/mach-s5pc1xx/Kconfig | 2 + arch/arm/mach-s5pc1xx/Makefile | 1 + arch/arm/mach-s5pc1xx/pinmux.c | 20 ++ board/samsung/common/board.c | 52 +-- board/samsung/common/exynos5-dt.c | 29 -- common/Kconfig | 8 + configs/axs101_defconfig | 1 + configs/axs103_defconfig | 1 + configs/odroid-xu3_defconfig | 1 + configs/odroid_defconfig | 1 + configs/spring_defconfig | 1 + drivers/mmc/s5p_sdhci.c | 50 --- drivers/sound/Kconfig | 8 + drivers/sound/Makefile | 1 + drivers/sound/max98088.c | 431 ++++++++++++++++++++++++ drivers/sound/max98088.h | 192 +++++++++++ drivers/sound/samsung_sound.c | 2 +- include/configs/axs10x.h | 5 - include/configs/hsdk.h | 5 - include/configs/odroid.h | 1 - include/configs/odroid_xu3.h | 1 - include/fdtdec.h | 7 - include/samsung/misc.h | 2 - lib/fdtdec.c | 7 - scripts/config_whitelist.txt | 1 - 28 files changed, 739 insertions(+), 177 deletions(-) create mode 100644 arch/arm/mach-s5pc1xx/pinmux.c create mode 100644 drivers/sound/max98088.c create mode 100644 drivers/sound/max98088.h -- 2.20.1.97.g81188d93c3-goog

4 26

Re: [U-Boot] [PATCH] buildman: fix typo
by sjg＠google.com 21 Jan '19

21 Jan '19

On Fri, 18 Jan 2019 at 20:40, Chris Packham <judge.packham(a)gmail.com> wrote: > > Fix a typo in the error message from CheckOutputDir(). > > Signed-off-by: Chris Packham <judge.packham(a)gmail.com> > --- > > tools/buildman/control.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg(a)chromium.org> Applied to u-boot-dm, thanks!

1 0

[U-Boot] [PATCH] am335x: chilisom: Initial support for different DDR3 chips
by Maciej Zagrabski 21 Jan '19

21 Jan '19

Manufacturing process changes caused that several versions of chiliSOM with different memory chips are present on market. Patch introduces method for selecting actual memory chip on som through Kconfig. Patch creates space for adding more memory chips in future. Memory chip configuration is constructed by preprocesor basing on DDR3 part no from Kconfig. To do this, Makefile translates string from Kconfig into preprocesor token. Signed-off-by: Maciej Zagrabski <maciej.zagrabski(a)grinn-global.com> --- arch/arm/include/asm/arch-am33xx/ddr_defs.h | 16 ++++++++++ arch/arm/mach-omap2/am33xx/Kconfig | 21 +++++++++++++ arch/arm/mach-omap2/am33xx/Makefile | 1 + arch/arm/mach-omap2/am33xx/chilisom.c | 48 ++++++++++++++++------------- 4 files changed, 64 insertions(+), 22 deletions(-) diff --git a/arch/arm/include/asm/arch-am33xx/ddr_defs.h b/arch/arm/include/asm/arch-am33xx/ddr_defs.h index d8ddecc0bd2..94c1fac9a24 100644 --- a/arch/arm/include/asm/arch-am33xx/ddr_defs.h +++ b/arch/arm/include/asm/arch-am33xx/ddr_defs.h @@ -154,6 +154,22 @@ #define K4B2G1646EBIH9_PHY_WR_DATA 0x76 #define K4B2G1646EBIH9_IOCTRL_VALUE 0x18B +/* Samsung K4B4G1646D-BIK0 */ +#define K4B4G1646DBIK0_EMIF_READ_LATENCY 0x100007 +#define K4B4G1646DBIK0_EMIF_TIM1 0x0AAAE51B +#define K4B4G1646DBIK0_EMIF_TIM2 0x2A6B7FDA +#define K4B4G1646DBIK0_EMIF_TIM3 0x501F867F +#define K4B4G1646DBIK0_EMIF_SDCFG 0x61C05332 +#define K4B4G1646DBIK0_EMIF_SDREF 0xC30 +#define K4B4G1646DBIK0_ZQ_CFG 0x50074BE4 +#define K4B4G1646DBIK0_RATIO 0x80 +#define K4B4G1646DBIK0_INVERT_CLKOUT 0x0 +#define K4B4G1646DBIK0_RD_DQS 0x3C +#define K4B4G1646DBIK0_WR_DQS 0x38 +#define K4B4G1646DBIK0_PHY_FIFO_WE 0x98 +#define K4B4G1646DBIK0_PHY_WR_DATA 0x73 +#define K4B4G1646DBIK0_IOCTRL_VALUE 0x18B + #define LPDDR2_ADDRCTRL_IOCTRL_VALUE 0x294 #define LPDDR2_ADDRCTRL_WD0_IOCTRL_VALUE 0x00000000 #define LPDDR2_ADDRCTRL_WD1_IOCTRL_VALUE 0x00000000 diff --git a/arch/arm/mach-omap2/am33xx/Kconfig b/arch/arm/mach-omap2/am33xx/Kconfig index 57284c4ae12..535bcd6c3d0 100644 --- a/arch/arm/mach-omap2/am33xx/Kconfig +++ b/arch/arm/mach-omap2/am33xx/Kconfig @@ -24,6 +24,27 @@ config AM33XX_CHILISOM bool select SUPPORT_SPL +if AM33XX_CHILISOM + +choice + prompt "DDR3 chip on chiliSOM" + default CHILISOM_MT41K256M16HA125E + +config CHILISOM_MT41K256M16HA125E + bool "Micron MT41K256" + +config CHILISOM_K4B4G1646DBIK0 + bool "Samsung K4B4G1646" + +endchoice + +config CHILISOM_DDR3_CHIP_NAME + string + default K4B4G1646DBIK0 if CHILISOM_K4B4G1646DBIK0 + default MT41K256M16HA125E + +endif + choice prompt "AM33xx board select" diff --git a/arch/arm/mach-omap2/am33xx/Makefile b/arch/arm/mach-omap2/am33xx/Makefile index 61c76d045f3..81c7a82f21e 100644 --- a/arch/arm/mach-omap2/am33xx/Makefile +++ b/arch/arm/mach-omap2/am33xx/Makefile @@ -26,3 +26,4 @@ obj-y += fdt.o obj-$(CONFIG_CLOCK_SYNTHESIZER) += clk_synthesizer.o obj-$(CONFIG_AM33XX_CHILISOM) += chilisom.o +CFLAGS_chilisom.o := -DCHILISOM_DDR3_CHIP_NAME=$(CONFIG_CHILISOM_DDR3_CHIP_NAME) diff --git a/arch/arm/mach-omap2/am33xx/chilisom.c b/arch/arm/mach-omap2/am33xx/chilisom.c index 39423051088..3cfb611cc89 100644 --- a/arch/arm/mach-omap2/am33xx/chilisom.c +++ b/arch/arm/mach-omap2/am33xx/chilisom.c @@ -23,6 +23,10 @@ #ifndef CONFIG_SKIP_LOWLEVEL_INIT +#define DDR_NAME_TOKEN(CHIP, NAME) CHIP ## _ ## NAME +#define DDR_NAME_UNWRAP(CHIP, NAME) DDR_NAME_TOKEN(CHIP, NAME) +#define DDR_NAME(NAME) DDR_NAME_UNWRAP(CHILISOM_DDR3_CHIP_NAME, NAME) + static struct ctrl_dev *cdev = (struct ctrl_dev *)CTRL_DEVICE_BASE; static struct module_pin_mux i2c0_pin_mux[] = { @@ -64,32 +68,32 @@ void chilisom_enable_pin_mux(void) } static const struct ddr_data ddr3_chilisom_data = { - .datardsratio0 = MT41K256M16HA125E_RD_DQS, - .datawdsratio0 = MT41K256M16HA125E_WR_DQS, - .datafwsratio0 = MT41K256M16HA125E_PHY_FIFO_WE, - .datawrsratio0 = MT41K256M16HA125E_PHY_WR_DATA, + .datardsratio0 = DDR_NAME(RD_DQS), + .datawdsratio0 = DDR_NAME(WR_DQS), + .datafwsratio0 = DDR_NAME(PHY_FIFO_WE), + .datawrsratio0 = DDR_NAME(PHY_WR_DATA), }; static const struct cmd_control ddr3_chilisom_cmd_ctrl_data = { - .cmd0csratio = MT41K256M16HA125E_RATIO, - .cmd0iclkout = MT41K256M16HA125E_INVERT_CLKOUT, + .cmd0csratio = DDR_NAME(RATIO), + .cmd0iclkout = DDR_NAME(INVERT_CLKOUT), - .cmd1csratio = MT41K256M16HA125E_RATIO, - .cmd1iclkout = MT41K256M16HA125E_INVERT_CLKOUT, + .cmd1csratio = DDR_NAME(RATIO), + .cmd1iclkout = DDR_NAME(INVERT_CLKOUT), - .cmd2csratio = MT41K256M16HA125E_RATIO, - .cmd2iclkout = MT41K256M16HA125E_INVERT_CLKOUT, + .cmd2csratio = DDR_NAME(RATIO), + .cmd2iclkout = DDR_NAME(INVERT_CLKOUT), }; static struct emif_regs ddr3_chilisom_emif_reg_data = { - .sdram_config = MT41K256M16HA125E_EMIF_SDCFG, - .ref_ctrl = MT41K256M16HA125E_EMIF_SDREF, - .sdram_tim1 = MT41K256M16HA125E_EMIF_TIM1, - .sdram_tim2 = MT41K256M16HA125E_EMIF_TIM2, - .sdram_tim3 = MT41K256M16HA125E_EMIF_TIM3, + .sdram_config = DDR_NAME(EMIF_SDCFG), + .ref_ctrl = DDR_NAME(EMIF_SDREF), + .sdram_tim1 = DDR_NAME(EMIF_TIM1), + .sdram_tim2 = DDR_NAME(EMIF_TIM2), + .sdram_tim3 = DDR_NAME(EMIF_TIM3), .ocp_config = 0x00141414, - .zq_config = MT41K256M16HA125E_ZQ_CFG, - .emif_ddr_phy_ctlr_1 = MT41K256M16HA125E_EMIF_READ_LATENCY, + .zq_config = DDR_NAME(ZQ_CFG), + .emif_ddr_phy_ctlr_1 = DDR_NAME(EMIF_READ_LATENCY), }; void chilisom_spl_board_init(void) @@ -166,11 +170,11 @@ const struct dpll_params *get_dpll_ddr_params(void) } const struct ctrl_ioregs ioregs_chilisom = { - .cm0ioctl = MT41K256M16HA125E_IOCTRL_VALUE, - .cm1ioctl = MT41K256M16HA125E_IOCTRL_VALUE, - .cm2ioctl = MT41K256M16HA125E_IOCTRL_VALUE, - .dt0ioctl = MT41K256M16HA125E_IOCTRL_VALUE, - .dt1ioctl = MT41K256M16HA125E_IOCTRL_VALUE, + .cm0ioctl = DDR_NAME(IOCTRL_VALUE), + .cm1ioctl = DDR_NAME(IOCTRL_VALUE), + .cm2ioctl = DDR_NAME(IOCTRL_VALUE), + .dt0ioctl = DDR_NAME(IOCTRL_VALUE), + .dt1ioctl = DDR_NAME(IOCTRL_VALUE), }; void sdram_init(void) -- 2.11.0

3 2

[U-Boot] boot.bin on SD Card for SAMA5D3 Xplained
by Daniel Evans 21 Jan '19

21 Jan '19

Trying to get uboot SPL boot.bin to run on an SD card for the sama5d3 xplained board. All I get is RomBOOT and no other messages. I have tried throwing in a couple test pins to toggle in board_early_init_f but still not getting any debug. I can get at91bootstrap to produce a boot.bin that works on the sama5d3 xplained so I am assuming I don’t have a bad board. My boot partition is FAT16. To compile I just run the following on Debian Buster : make mrproper make sama5d3_xplained_mmc_defconfig make Cross Compiler is gcc-linaro-6.4.1-2018.05-x86_64_arm-linux-gnueabihf When finished compiling I just copy the boot.bin to my BOOT partition. Has to be something obvious that I am missing. Any insight is appreciated… Dan

6 31

[U-Boot] [RFC PATCH] am335x: Changes in DDR init procedure to Support Samsung K4B2G1646EBIH9 memory chip
by Maciej Zagrabski 21 Jan '19

21 Jan '19

K4B2G1646EBIH9 Samsung memory chip used now on chiliSOM requires refresh register REF CTRL to be initialized with large enough value, faster than it is implemented in `config_sdram` in ddr.c for am33xx, that mean before setting ZQ CTRL. Change should not interferee with already supported DDR chips cause refresh rate value is large enough to cover initialization, but it will finish during `udelay` below anyway. If this is not acceptable I can `ifdef` this line with config introduced in previous patch. Signed-off-by: Maciej Zagrabski <maciej.zagrabski(a)grinn-global.com> --- arch/arm/mach-omap2/am33xx/ddr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/am33xx/ddr.c b/arch/arm/mach-omap2/am33xx/ddr.c index be6f4d72ccd..3684508bb1c 100644 --- a/arch/arm/mach-omap2/am33xx/ddr.c +++ b/arch/arm/mach-omap2/am33xx/ddr.c @@ -171,12 +171,13 @@ void config_sdram(const struct emif_regs *regs, int nr) writel(regs->ref_ctrl, &emif_reg[nr]->emif_sdram_ref_ctrl); #else if (regs->zq_config) { + /* Trigger initialization */ + writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl); + writel(regs->zq_config, &emif_reg[nr]->emif_zq_config); writel(regs->sdram_config, &cstat->secure_emif_sdram_config); writel(regs->sdram_config, &emif_reg[nr]->emif_sdram_config); - /* Trigger initialization */ - writel(0x00003100, &emif_reg[nr]->emif_sdram_ref_ctrl); /* Wait 1ms because of L3 timeout error */ udelay(1000); -- 2.11.0

2 1

[U-Boot] [PATCH] env: sf: fix environment in SPI NOR
by Heiko Schocher 21 Jan '19

21 Jan '19

commit 9a9d66f5eff0 ("env: add spi_flash_read_env function") breaks Environment functionality, as it reads only until 2 \0 are found, but fills the buffer with 0x0 instead 0xff which leads in an incorrect crc sum. Fix: init the read buffer with 0xff instead 0x00 Signed-off-by: Heiko Schocher <hs(a)denx.de> --- env/sf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/sf.c b/env/sf.c index b3dec82c35..31dd003575 100644 --- a/env/sf.c +++ b/env/sf.c @@ -98,7 +98,7 @@ static int spi_flash_read_env(struct spi_flash *flash, u32 offset, size_t len, u32 addr = 0; u32 page_size = flash->page_size; - memset(buf, 0x0, len); + memset(buf, 0xff, len); for (int i = 0; i < len / page_size; ++i) { int ret = spi_flash_read(flash, offset, page_size, &((char *)buf)[addr]); -- 2.17.2

2 3