November 2007 - U-Boot

[U-Boot-Users] [PATCH] Add additional fdt fixup helper functions
by Kumar Gala 21 Nov '07

21 Nov '07

Added the following fdt fixup helpers: * do_fixup_by_prop{_u32} - Find matching nodes by property name/value * do_fixup_by_compat{_u32} - Find matching nodes by compat The _u32 variants work the same only the property they are setting is know to be a 32-bit integer instead of a byte buffer. Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- common/fdt_support.c | 80 ++++++++++++++++++++++++++++++++++++++++++++----- include/fdt_support.h | 11 +++++++ 2 files changed, 83 insertions(+), 8 deletions(-) diff --git a/common/fdt_support.c b/common/fdt_support.c index 0e61f6d..b50f064 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -160,6 +160,7 @@ int fdt_chosen(void *fdt, ulong initrd_start, ulong initrd_end, int force) printf("WARNING: could not set linux,initrd-end %s.\n", fdt_strerror(err)); } + #ifdef OF_STDOUT_PATH err = fdt_setprop(fdt, nodeoffset, "linux,stdout-path", OF_STDOUT_PATH, strlen(OF_STDOUT_PATH)+1); @@ -386,6 +387,61 @@ void do_fixup_by_path_u32(void *fdt, const char *path, const char *prop, do_fixup_by_path(fdt, path, prop, &val, sizeof(val), create); } +void do_fixup_by_prop(void *fdt, + const char *pname, const void *pval, int plen, + const char *prop, const void *val, int len, + int create) +{ + int off; +#if defined(DEBUG) + int i; + debug("Updating property '%s/%s' = ", node, prop); + for (i = 0; i < len; i++) + debug(" %.2x", *(u8*)(val+i)); + debug("\n"); +#endif + off = fdt_node_offset_by_prop_value(fdt, -1, pname, pval, plen); + while (off != -FDT_ERR_NOTFOUND) { + if (create || (fdt_get_property(fdt, off, prop, 0) != NULL)) + fdt_setprop(fdt, off, prop, val, len); + off = fdt_node_offset_by_prop_value(fdt, off, pname, pval, plen); + } +} + +void do_fixup_by_prop_u32(void *fdt, + const char *pname, const void *pval, int plen, + const char *prop, u32 val, int create) +{ + val = cpu_to_fdt32(val); + do_fixup_by_prop(fdt, pname, pval, plen, prop, &val, 4, create); +} + +void do_fixup_by_compat(void *fdt, const char *compat, + const char *prop, const void *val, int len, int create) +{ + int off = -1; +#if defined(DEBUG) + int i; + debug("Updating property '%s/%s' = ", node, prop); + for (i = 0; i < len; i++) + debug(" %.2x", *(u8*)(val+i)); + debug("\n"); +#endif + off = fdt_node_offset_by_compatible(fdt, -1, compat); + while (off != -FDT_ERR_NOTFOUND) { + if (create || (fdt_get_property(fdt, off, prop, 0) != NULL)) + fdt_setprop(fdt, off, prop, val, len); + off = fdt_node_offset_by_compatible(fdt, off, compat); + } +} + +void do_fixup_by_compat_u32(void *fdt, const char *compat, + const char *prop, u32 val, int create) +{ + val = cpu_to_fdt32(val); + do_fixup_by_compat(fdt, compat, prop, &val, 4, create); +} + void fdt_fixup_ethernet(void *fdt, bd_t *bd) { int node; @@ -396,29 +452,37 @@ void fdt_fixup_ethernet(void *fdt, bd_t *bd) #if defined(CONFIG_HAS_ETH0) path = fdt_getprop(fdt, node, "ethernet0", NULL); if (path) { - do_fixup_by_path(fdt, path, "mac-address", bd->bi_enetaddr, 6, 0); - do_fixup_by_path(fdt, path, "local-mac-address", bd->bi_enetaddr, 6, 1); + do_fixup_by_path(fdt, path, "mac-address", + bd->bi_enetaddr, 6, 0); + do_fixup_by_path(fdt, path, "local-mac-address", + bd->bi_enetaddr, 6, 1); } #endif #if defined(CONFIG_HAS_ETH1) path = fdt_getprop(fdt, node, "ethernet1", NULL); if (path) { - do_fixup_by_path(fdt, path, "mac-address", bd->bi_enet1addr, 6, 0); - do_fixup_by_path(fdt, path, "local-mac-address", bd->bi_enet1addr, 6, 1); + do_fixup_by_path(fdt, path, "mac-address", + bd->bi_enet1addr, 6, 0); + do_fixup_by_path(fdt, path, "local-mac-address", + bd->bi_enet1addr, 6, 1); } #endif #if defined(CONFIG_HAS_ETH2) path = fdt_getprop(fdt, node, "ethernet2", NULL); if (path) { - do_fixup_by_path(fdt, path, "mac-address", bd->bi_enet2addr, 6, 0); - do_fixup_by_path(fdt, path, "local-mac-address", bd->bi_enet2addr, 6, 1); + do_fixup_by_path(fdt, path, "mac-address", + bd->bi_enet2addr, 6, 0); + do_fixup_by_path(fdt, path, "local-mac-address", + bd->bi_enet2addr, 6, 1); } #endif #if defined(CONFIG_HAS_ETH3) path = fdt_getprop(fdt, node, "ethernet3", NULL); if (path) { - do_fixup_by_path(fdt, path, "mac-address", bd->bi_enet3addr, 6, 0); - do_fixup_by_path(fdt, path, "local-mac-address", bd->bi_enet3addr, 6, 1); + do_fixup_by_path(fdt, path, "mac-address", + bd->bi_enet3addr, 6, 0); + do_fixup_by_path(fdt, path, "local-mac-address", + bd->bi_enet3addr, 6, 1); } #endif } diff --git a/include/fdt_support.h b/include/fdt_support.h index 150dd2b..8f781d4 100644 --- a/include/fdt_support.h +++ b/include/fdt_support.h @@ -33,6 +33,17 @@ void do_fixup_by_path(void *fdt, const char *path, const char *prop, const void *val, int len, int create); void do_fixup_by_path_u32(void *fdt, const char *path, const char *prop, u32 val, int create); +void do_fixup_by_prop(void *fdt, + const char *pname, const void *pval, int plen, + const char *prop, const void *val, int len, + int create); +void do_fixup_by_prop_u32(void *fdt, + const char *pname, const void *pval, int plen, + const char *prop, u32 val, int create); +void do_fixup_by_compat(void *fdt, const char *compat, + const char *prop, const void *val, int len, int create); +void do_fixup_by_compat_u32(void *fdt, const char *compat, + const char *prop, u32 val, int create); void fdt_fixup_ethernet(void *fdt, bd_t *bd); #ifdef CONFIG_OF_HAS_UBOOT_ENV -- 1.5.3.4

1 0

[U-Boot-Users] [PATCH] Fix warnings from import of libfdt
by Kumar Gala 21 Nov '07

21 Nov '07

cmd_fdt.c: In function fdt_print: cmd_fdt.c:586: warning: assignment discards qualifiers from pointer target type cmd_fdt.c:613: warning: assignment discards qualifiers from pointer target type cmd_fdt.c:635: warning: assignment discards qualifiers from pointer target type cmd_fdt.c:636: warning: assignment discards qualifiers from pointer target type Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- common/cmd_fdt.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c index d84c6f0..362d39d 100644 --- a/common/cmd_fdt.c +++ b/common/cmd_fdt.c @@ -44,7 +44,7 @@ DECLARE_GLOBAL_DATA_PTR; static int fdt_valid(void); static int fdt_parse_prop(char *pathp, char *prop, char *newval, char *data, int *len); -static int fdt_print(char *pathp, char *prop, int depth); +static int fdt_print(const char *pathp, char *prop, int depth); /* * Flattened Device Tree command, see the help for parameter definitions. @@ -555,13 +555,13 @@ static void print_data(const void *data, int len) * Recursively print (a portion of) the fdt. The depth parameter * determines how deeply nested the fdt is printed. */ -static int fdt_print(char *pathp, char *prop, int depth) +static int fdt_print(const char *pathp, char *prop, int depth) { static int offstack[MAX_LEVEL]; static char tabs[MAX_LEVEL+1] = "\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t" "\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t"; - void *nodep; /* property node pointer */ + const void *nodep; /* property node pointer */ int nodeoffset; /* node offset from libfdt */ int nextoffset; /* next node offset from libfdt */ uint32_t tag; /* tag */ -- 1.5.3.4

1 0

[U-Boot-Users] Problems writing to memory with mw
by robert lazarski 21 Nov '07

21 Nov '07

Hi all, I'm trying to track down problems loading a linux kernel on my custom 8548 board off of 1.3RC3 - it loads sometimes via a ramdisk and gives me a bash shell - but most times it crashes in unusual, different places. I ram mtest in the monitor and it crashes at 00000a90 . When using mw I get: => mw 00000a90 cafecafe NIP: CAFECAFC XER: 00000000 LR: 1FFC109C REGS: 1ff9dc40 TRAP: 0700 DAR: 00000000 MSR: 00001000 EE: 0 PR: 0 FP: 0 ME: 1 IR/DR: 00 GPR00: 1FFD9C44 1FF9DD30 00000200 1FF9DD40 00000338 00000018 1FFEA258 1FFEA308 GPR08: 1FFEA2F0 1FF9E00C 00000C01 1FFA03F0 1FFEA250 00000000 1FFEFB00 20040000 GPR16: 00000000 00000000 00000000 00000000 00001000 1FF9DD30 00000000 1FFC109C GPR24: CAFECAFE 1FFEA244 00000339 1FFE71B8 00000049 1FF9DF80 1FFF0860 00000338 ** Illegal Instruction ** Call backtrace: 00000000 1FFD6C80 1FFD74CC 1FFDB6A8 1FFDC0A4 1FFDC6D0 1FFD0AE0 1FFC8294 1FFC161C I can write to 00000a90 via the bdi . u-boot otherwise runs perfectly. Any ideas? Robert

5 10

[U-Boot-Users] [PATCH] [BUILD] conditionally compile libfdt/*.c in libfdt/Makefile
by Kumar Gala 21 Nov '07

21 Nov '07

Modify libfdt/Makefile to conditionally compile the *.c files based on the board config. Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- This is against u-boot-testing libfdt/Makefile | 2 +- libfdt/fdt.c | 5 ----- libfdt/fdt_ro.c | 5 ----- libfdt/fdt_rw.c | 5 ----- libfdt/fdt_strerror.c | 5 ----- libfdt/fdt_sw.c | 5 ----- libfdt/fdt_wip.c | 5 ----- 7 files changed, 1 insertions(+), 31 deletions(-) diff --git a/libfdt/Makefile b/libfdt/Makefile index 126fa2c..d166cce 100644 --- a/libfdt/Makefile +++ b/libfdt/Makefile @@ -27,7 +27,7 @@ LIB = $(obj)libfdt.a SOBJS = -COBJS-y += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o +COBJS-$(CONFIG_OF_LIBFDT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o COBJS := $(COBJS-y) SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) diff --git a/libfdt/fdt.c b/libfdt/fdt.c index 1ee67ad..212b838 100644 --- a/libfdt/fdt.c +++ b/libfdt/fdt.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -86,5 +83,3 @@ int fdt_move(const void *fdt, void *buf, int bufsize) memmove(buf, fdt, fdt_totalsize(fdt)); return 0; } - -#endif /* CONFIG_OF_LIBFDT */ diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c index 46d525d..bc1a5f4 100644 --- a/libfdt/fdt_ro.c +++ b/libfdt/fdt_ro.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -532,5 +529,3 @@ int fdt_get_reservemap(void *fdt, int n, struct fdt_reserve_entry *re) } return 0; } - -#endif /* CONFIG_OF_LIBFDT */ diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c index 55fcc41..852b6e6 100644 --- a/libfdt/fdt_rw.c +++ b/libfdt/fdt_rw.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -320,5 +317,3 @@ int fdt_pack(void *fdt) fdt_set_header(fdt, totalsize, _blob_data_size(fdt)); return 0; } - -#endif /* CONFIG_OF_LIBFDT */ diff --git a/libfdt/fdt_strerror.c b/libfdt/fdt_strerror.c index b49c952..7f231ce 100644 --- a/libfdt/fdt_strerror.c +++ b/libfdt/fdt_strerror.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -65,5 +62,3 @@ const char *fdt_strerror(int errval) return "<unknown error>"; } - -#endif /* CONFIG_OF_LIBFDT */ diff --git a/libfdt/fdt_sw.c b/libfdt/fdt_sw.c index c7eea8f..672f4dd 100644 --- a/libfdt/fdt_sw.c +++ b/libfdt/fdt_sw.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -227,5 +224,3 @@ int fdt_finish(void *fdt) fdt_set_header(fdt, magic, FDT_MAGIC); return 0; } - -#endif /* CONFIG_OF_LIBFDT */ diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c index 2d39aab..2d2ed37 100644 --- a/libfdt/fdt_wip.c +++ b/libfdt/fdt_wip.c @@ -16,9 +16,6 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include "config.h" -#if CONFIG_OF_LIBFDT - #include "libfdt_env.h" #include <fdt.h> @@ -138,5 +135,3 @@ int fdt_replace_reservemap_entry(void *fdt, int n, uint64_t addr, uint64_t size) return 0; } - -#endif /* CONFIG_OF_LIBFDT */ -- 1.5.3.4

3 4

[U-Boot-Users] [PATCH] [BUILD] Remove libraries when updating autoconf.mk
by Grant Likely 21 Nov '07

21 Nov '07

From: Grant Likely <grant.likely(a)secretlab.ca> Fix library problems caused by conditional compilation. Using autoconf.mk to decide which files to compile has caused a problem when changing configuration from one board to another without clearing out the library (*.a) files. It used to be that the linker was always passed the same list of .o files when building the .a files. However, that is not longer true with conditional compilation. Now, a different board config will have a different file list passed to the linker. The problem occurs when a library has already been built and the board config is changed. Since the linker will update instead of replace a preexisting library, then if the file list changes to remove some object files the old objects will still exist in the library. The solution is to remove all old library files when autoconf.mk is made. Signed-off-by: Grant Likely <grant.likely(a)secretlab.ca> --- 0 files changed, 0 insertions(+), 0 deletions(-)

1 1

[U-Boot-Users] Thanksgiving News
by marsha＠rtharris.co.uk 21 Nov '07

21 Nov '07

e t gU Is Stuffing Investors Like A Thanksgiving Turkey. EnerBrite Technologies Group, Inc. (Et GU) $0.01 EnerBrite is still trading heavy and brining awesome returns for investors. The news released today on International inquiries for EnerBrite technologies is only going to keep this frenzy rolling. Don't let the holiday pass without first moving on e TgU.

1 0

Re: [U-Boot-Users] uboot clock configuration on mpc5200 boards
by Grant Likely 21 Nov '07

21 Nov '07

On 11/20/07, Jon Smirl <jonsmirl(a)gmail.com> wrote: > On the Linux kernel the mpc52xx_setup_cpu() function used to do this > fix up. Does uboot handle this for mpc5200 boards? If so, which > version? > > uboot is accessing these registers but it is not clear to me if the > clocks are completely being set up. > > The 5200lite code has been changed to this: > > /* > * Fix clock configuration. > * > * Firmware is supposed to be responsible for this. If you are creating a > * new board port, do *NOT* duplicate this code. Fix your boot firmware > * to set it correctly in the first place > */ > static void __init > lite5200_fix_clock_config(void) > { ----8<----snip---->8---- > } > > Is uboot setting this up correct now that they kernel has been changed? > Strictly speaking; firmware should be responsible for configuring the SoC (clocks, pinouts, etc). It makes it easier to add new boards if each one doesn't need it's own fixups. I haven't checked the clock setup for lite5200 in u-boot yet, but it is not a complex change. And even if I do change it for the lite5200 in u-boot; this code probably won't go away in the kernel so as not to break compatibility with lite5200's with older u-boot firmware. The point is that firmware should setup the CPU correctly at boot. It should not be Linux's responsibility. However, if there is *existing* firmware that needs to be supported; then I'll grudgingly accept hacks like this to keep the board bootable. If it is a new board, do it right the first time and do it in firmware (be it u-boot or otherwise) Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely(a)secretlab.ca (403) 399-0195

4 6

[U-Boot-Users] Writing to flash device from ELDK Linux Shell prompt
by Verma 21 Nov '07

21 Nov '07

Hi , Is it possible to copy(store) a binary file into the flash device from the Linux shell prompt of ELDK. Thank You, Verma. -- View this message in context: http://www.nabble.com/Writing-to-flash-device-from-ELDK-Linux-Shell-prompt-… Sent from the Uboot - Users mailing list archive at Nabble.com.

3 2

[U-Boot-Users] TFTP usage at Linux shell prompt
by Verma 21 Nov '07

21 Nov '07

Hi, I am using JFFS2 file system for running the Linux on incaip board and would like to download a file from another host using TFTP.The following are the various commands and the respective outputs I have obtained when trying to download the file. 1.command: "#tftp 192.168.0.215" output message: BusyBox v1.00 (2007.11.20-05:01+0000) multi-call binary Usage: tftp [OPTION]... HOST [PORT] 2.command: "# tftp -m binary 192.168.0.215" output message: "tftp: illegal option -- m BusyBox v1.00 (2007.11.20-05:01+0000) multi-call binary" 3.command: "tftp v 192.168.0.215" output message: "BusyBox v1.00 (2007.11.20-05:01+0000) multi-call binary Usage: tftp [OPTION]... HOST [PORT]" Is the format of the commands valid, what are the list of options that could be given under OPTION field. Kindly, give me some pointers to proceed in solving this issue. Thank You, Verma. -- View this message in context: http://www.nabble.com/TFTP-usage-at-Linux-shell-prompt-tf4848314.html#a1387… Sent from the Uboot - Users mailing list archive at Nabble.com.

2 1

[U-Boot-Users] 82551ER driver in u-boot
by Nancy Isaac 21 Nov '07

21 Nov '07

Hi, I saw someone else post this question without a reply, so I'll try my luck. Does anyone know if eepro100.c that is in u-boot work with 82551ER chip? I am trying to see if it will work and I am running into problems. I get the error: can not reset ethernet controller. I checked all the settings for the pci and it seems to be correct. So, I am curious if anyone has used the driver in u-boot with the 82551ER chip. Thanks Nancy

1 0