November 2007 - U-Boot

[U-Boot-Users] [PATCH 0/1] Fix warning: passing argument 1 of 'move64' discards qualifiers from pointer target type
by Jean-Christophe PLAGNIOL-VILLARD 20 Nov '07

20 Nov '07

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj(a)jcrosoft.com> diff --git a/post/drivers/memory.c b/post/drivers/memory.c index fbc349a..bf16157 100644 --- a/post/drivers/memory.c +++ b/post/drivers/memory.c @@ -207,7 +207,7 @@ static void move64(unsigned long long *src, unsigned long long *dest) * than the test pattern. This is for detecting floating bus lines. * */ -const static unsigned long long pattern[] = { +static unsigned long long pattern[] = { 0xaaaaaaaaaaaaaaaaULL, 0xccccccccccccccccULL, 0xf0f0f0f0f0f0f0f0ULL, @@ -221,7 +221,7 @@ const static unsigned long long pattern[] = { 0x3333333333333333ULL, 0x5555555555555555ULL }; -const unsigned long long otherpattern = 0x0123456789abcdefULL; +unsigned long long otherpattern = 0x0123456789abcdefULL; static int memory_post_dataline(unsigned long long * pmem) -- 1.5.3.2

2 3

[U-Boot-Users] [PATCH] MPC8360E-MDS: configure and enable second UART
by Anton Vorontsov 20 Nov '07

20 Nov '07

Despite user manual, BCSR9.7 is negated (high) on HRST, so UART2 is disabled. Fix that and configure QE pins properly. Signed-off-by: Anton Vorontsov <avorontsov(a)ru.mvista.com> --- board/freescale/mpc8360emds/mpc8360emds.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/board/freescale/mpc8360emds/mpc8360emds.c b/board/freescale/mpc8360emds/mpc8360emds.c index e050cd4..538a556 100644 --- a/board/freescale/mpc8360emds/mpc8360emds.c +++ b/board/freescale/mpc8360emds/mpc8360emds.c @@ -87,6 +87,11 @@ const qe_iop_conf_t qe_iop_conf_tab[] = { {0, 1, 3, 0, 2}, /* MDIO */ {0, 2, 1, 0, 1}, /* MDC */ + {5, 0, 1, 0, 2}, /* UART2_SOUT */ + {5, 1, 2, 0, 3}, /* UART2_CTS */ + {5, 2, 1, 0, 1}, /* UART2_RTS */ + {5, 3, 2, 0, 2}, /* UART2_SIN */ + {0, 0, 0, 0, QE_IOP_TAB_END}, /* END of table */ }; @@ -106,6 +111,9 @@ int board_early_init_f(void) immr->sysconf.spridr == SPR_8360E_REV21) bcsr[0xe] = 0x30; + /* Enable second UART */ + bcsr[0x9] &= ~0x01; + return 0; } -- 1.5.2.2

2 1

[U-Boot-Users] [PATCH v3] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE definitions
by Timur Tabi 20 Nov '07

20 Nov '07

Fix the definitions of CFG_ENV_ADDR and CFG_ENV_SECT_SIZE for all of the currently-defined 83xx boards. This change guarantees that the environment will be located on the first flash sector after the U-Boot image. Signed-off-by: Timur Tabi <timur(a)freescale.com> --- Reworded the changelog. include/configs/MPC8313ERDB.h | 3 ++- include/configs/MPC8323ERDB.h | 5 +++-- include/configs/MPC832XEMDS.h | 5 +++-- include/configs/MPC8349EMDS.h | 2 +- include/configs/MPC8349ITX.h | 3 ++- include/configs/MPC8360EMDS.h | 5 +++-- 6 files changed, 14 insertions(+), 9 deletions(-) diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h index 6568fe1..0c3bc16 100644 --- a/include/configs/MPC8313ERDB.h +++ b/include/configs/MPC8313ERDB.h @@ -178,6 +178,7 @@ #define CFG_GBL_DATA_OFFSET (CFG_INIT_RAM_END - CFG_GBL_DATA_SIZE) #define CFG_INIT_SP_OFFSET CFG_GBL_DATA_OFFSET +/* CFG_MONITOR_LEN must be a multiple of CFG_ENV_SECT_SIZE */ #define CFG_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ #define CFG_MALLOC_LEN (512 * 1024) /* Reserved for malloc */ @@ -326,7 +327,7 @@ */ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH 1 - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + 0x40000) + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) #define CFG_ENV_SECT_SIZE 0x10000 /* 64K(one sector) for env */ #define CFG_ENV_SIZE 0x2000 diff --git a/include/configs/MPC8323ERDB.h b/include/configs/MPC8323ERDB.h index 376973b..558f94b 100644 --- a/include/configs/MPC8323ERDB.h +++ b/include/configs/MPC8323ERDB.h @@ -116,6 +116,7 @@ #undef CFG_RAMBOOT #endif +/* CFG_MONITOR_LEN must be a multiple of CFG_ENV_SECT_SIZE */ #define CFG_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ #define CFG_MALLOC_LEN (128 * 1024) /* Reserved for malloc */ @@ -354,8 +355,8 @@ */ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH 1 - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + 0x40000) - #define CFG_ENV_SECT_SIZE 0x40000 /* 256K(one sector) for env */ + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) + #define CFG_ENV_SECT_SIZE 0x20000 #define CFG_ENV_SIZE 0x2000 #else #define CFG_NO_FLASH 1 /* Flash is not usable now */ diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index c9c6d88..5345fc6 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -145,6 +145,7 @@ #undef CFG_RAMBOOT #endif +/* CFG_MONITOR_LEN must be a multiple of CFG_ENV_SECT_SIZE */ #define CFG_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ #define CFG_MALLOC_LEN (128 * 1024) /* Reserved for malloc */ @@ -410,8 +411,8 @@ */ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH 1 - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + 0x40000) - #define CFG_ENV_SECT_SIZE 0x40000 /* 256K(one sector) for env */ + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) + #define CFG_ENV_SECT_SIZE 0x20000 #define CFG_ENV_SIZE 0x2000 #else #define CFG_NO_FLASH 1 /* Flash is not usable now */ diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 92555ba..7d5b17b 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -456,7 +456,7 @@ */ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH 1 - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + 0x40000) + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) #define CFG_ENV_SECT_SIZE 0x20000 /* 128K(one sector) for env */ #define CFG_ENV_SIZE 0x2000 diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h index 54cab52..2a2e753 100644 --- a/include/configs/MPC8349ITX.h +++ b/include/configs/MPC8349ITX.h @@ -261,6 +261,7 @@ boards, we say we have two, but don't display a message if we find only one. */ #define CFG_GBL_DATA_OFFSET (CFG_INIT_RAM_END - CFG_GBL_DATA_SIZE) #define CFG_INIT_SP_OFFSET CFG_GBL_DATA_OFFSET +/* CFG_MONITOR_LEN must be a multiple of CFG_ENV_SECT_SIZE */ #define CFG_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ #define CFG_MALLOC_LEN (128 * 1024) /* Reserved for malloc */ @@ -404,8 +405,8 @@ boards, we say we have two, but don't display a message if we find only one. */ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) #define CFG_ENV_SECT_SIZE 0x10000 /* 64K (one sector) for environment */ - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + (4 * CFG_ENV_SECT_SIZE)) #define CFG_ENV_SIZE 0x2000 #else #define CFG_NO_FLASH /* Flash is not usable now */ diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index 41f062c..8098951 100644 --- a/include/configs/MPC8360EMDS.h +++ b/include/configs/MPC8360EMDS.h @@ -170,6 +170,7 @@ #undef CFG_RAMBOOT #endif +/* CFG_MONITOR_LEN must be a multiple of CFG_ENV_SECT_SIZE */ #define CFG_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ #define CFG_MALLOC_LEN (128 * 1024) /* Reserved for malloc */ @@ -443,8 +444,8 @@ #ifndef CFG_RAMBOOT #define CFG_ENV_IS_IN_FLASH 1 - #define CFG_ENV_ADDR (CFG_MONITOR_BASE + 0x40000) - #define CFG_ENV_SECT_SIZE 0x40000 /* 256K(one sector) for env */ + #define CFG_ENV_ADDR (CFG_MONITOR_BASE + CFG_MONITOR_LEN) + #define CFG_ENV_SECT_SIZE 0x20000 #define CFG_ENV_SIZE 0x2000 #else #define CFG_NO_FLASH 1 /* Flash is not usable now */ -- 1.5.2.4

3 3

[U-Boot-Users] Please pull u-boot-mpc83xx.git mpc83xx branch into testing
by Kim Phillips 19 Nov '07

19 Nov '07

Wolfgang, Please pull the mpc83xx branch into your testing tree: git pull git://www.denx.de/git/u-boot-mpc83xx.git mpc83xx to get the following changes (essentially support for the MPC837xEMDS board): Dave Liu (6): mpc83xx: Add the support of MPC837x SoC mpc83xx: Add the support of MPC8315E SoC mpc83xx: Add the support of MPC837xEMDS board mpc83xx: Add the MPC837xEMDS board readme mpc83xx: add MAINTAINER and MAKEALL entries for the mpc837xemds mpc83xx: update the CREDITS and MAINTAINERS CREDITS | 5 + MAINTAINERS | 2 + MAKEALL | 1 + Makefile | 10 + board/freescale/mpc837xemds/Makefile | 50 +++ board/freescale/mpc837xemds/config.mk | 28 ++ board/freescale/mpc837xemds/mpc837xemds.c | 144 +++++++ board/freescale/mpc837xemds/pci.c | 65 +++ cpu/mpc83xx/cpu.c | 36 ++- cpu/mpc83xx/cpu_init.c | 6 +- cpu/mpc83xx/spd_sdram.c | 7 +- cpu/mpc83xx/speed.c | 201 ++++++++-- doc/README.mpc837xemds | 104 +++++ drivers/tsec.c | 10 + include/asm-ppc/global_data.h | 15 +- include/asm-ppc/immap_83xx.h | 145 +++++++- include/configs/MPC837XEMDS.h | 605 +++++++++++++++++++++++++++++ include/mpc83xx.h | 261 +++++++++++-- 18 files changed, 1635 insertions(+), 60 deletions(-) create mode 100644 board/freescale/mpc837xemds/Makefile create mode 100644 board/freescale/mpc837xemds/config.mk create mode 100644 board/freescale/mpc837xemds/mpc837xemds.c create mode 100644 board/freescale/mpc837xemds/pci.c create mode 100644 doc/README.mpc837xemds create mode 100644 include/configs/MPC837XEMDS.h Thanks, Kim

5 16

[U-Boot-Users] [GIT PULL] [ARM] Please pullfromgit://www.denx.de/git/u-boot-arm.git
by Peter Pearse 19 Nov '07

19 Nov '07

Wolfgang Please pull from git://www.denx.de/git/u-boot-arm.git This is the apollon port - tested on apollon by Kyungmin Park - MAKEALL tested by Peter Pearse Signed-off-by: Peter Pearse <peter.pearse(a)arm.com> Signed-off-by: Kyungmin Park <kmpark(a)infradead.org> Regards Peter --- The following changes since commit 1ce55151c85d068f70317a8d65c61058b891afb4: Heiko Schocher (1): [UC101] SRAM now with 2 MB working. are found in the git repository at: git://www.denx.de/git/u-boot-arm.git Peter Pearse (4): Add apollon board support Merge with git://www.denx.de/git/u-boot.git Correction patch Remove warnings re CONFIG_EXTRA_ENV_SETTINGS MAKEALL | 1 + Makefile | 5 +- board/apollon/Makefile | 48 +++ board/apollon/apollon.c | 472 +++++++++++++++++++++++++++++++ board/apollon/config.mk | 25 ++ board/apollon/lowlevel_init.S | 337 ++++++++++++++++++++++ board/apollon/mem.c | 235 +++++++++++++++ board/apollon/mem.h | 170 +++++++++++ board/apollon/sys_info.c | 403 ++++++++++++++++++++++++++ board/apollon/u-boot.lds | 63 ++++ common/env_onenand.c | 4 +- include/asm-arm/arch-arm1136/mux.h | 18 ++ include/asm-arm/arch-arm1136/omap2420.h | 33 ++- include/asm-arm/mach-types.h | 13 + include/configs/apollon.h | 238 ++++++++++++++++ 15 files changed, 2058 insertions(+), 7 deletions(-) create mode 100644 board/apollon/Makefile create mode 100644 board/apollon/apollon.c create mode 100644 board/apollon/config.mk create mode 100644 board/apollon/lowlevel_init.S create mode 100644 board/apollon/mem.c create mode 100644 board/apollon/mem.h create mode 100644 board/apollon/sys_info.c create mode 100644 board/apollon/u-boot.lds create mode 100755 include/configs/apollon.h ---

3 2

[U-Boot-Users] Final call: last minute fixes for 1.3.0 release ?
by Wolfgang Denk 19 Nov '07

19 Nov '07

Hallo, this is the final call for any bug fixes that must go into the U-Boot 1.3.0 release. Please submit these *now*, I intend to release 1.3.0 in a day or two. Since 1.3.0-rc4, I checked in a couple of fixes for compile issues (get rid of compiler warnings). Using a GCC 4.0 / binutils 2.16.1 based toolchain (ELDK 4.1) I get the following status: * PPC builds for all boards in the MAKEALL script without warnings, except for the MPC8641HPCN board which throws these warnings: Configuring for MPC8641HPCN board... {standard input}: Assembler messages: {standard input}:16: Warning: ignoring changed section type for .got2 {standard input}: Assembler messages: {standard input}:14: Warning: ignoring changed section type for .got2 {standard input}: Assembler messages: {standard input}:14: Warning: ignoring changed section type for .got2 * ARM builds for many boards OK, but there are problems that will probably remain unfixed in 1.3.0: mp2usb board: usb_ohci.c: In function 'usb_lowlevel_init': usb_ohci.c:1846: error: 'AT91_USB_HOST_BASE' undeclared (first use in this function) usb_ohci.c:1846: error: (Each undeclared identifier is reported only once usb_ohci.c:1846: error: for each function it appears in.) mx1ads board: mx1ads.c: In function 'board_init': mx1ads.c:106: error: invalid lvalue in assignment mx1ads.c:107: error: invalid lvalue in assignment mx1fs2 board: mx1fs2.c: In function 'logo_init': mx1fs2.c:75: error: invalid lvalue in assignment scb9328 board: flash.c:85: warning: type qualifiers ignored on function return type generic.c: In function 'imx_gpio_mode': generic.c:41: error: invalid lvalue in assignment generic.c:43: error: invalid lvalue in assignment generic.c:47: error: invalid lvalue in assignment generic.c:49: error: invalid lvalue in assignment generic.c:53: error: invalid lvalue in assignment generic.c:55: error: invalid lvalue in assignment generic.c:59: error: invalid lvalue in assignment generic.c:61: error: invalid lvalue in assignment generic.c:71: error: invalid lvalue in assignment generic.c:74: error: invalid lvalue in assignment generic.c:76: error: invalid lvalue in assignment generic.c:81: error: invalid lvalue in assignment generic.c:84: error: invalid lvalue in assignment generic.c:86: error: invalid lvalue in assignment VCMA9 board: common/libcommon.a(usb.o): In function `usb_submit_int_msg': /home/wd/git/u-boot/work/common/usb.c:157: undefined reference to `submit_int_msg' common/libcommon.a(usb.o): In function `usb_control_msg': /home/wd/git/u-boot/work/common/usb.c:187: undefined reference to `submit_control_msg' common/libcommon.a(usb.o): In function `usb_bulk_msg': /home/wd/git/u-boot/work/common/usb.c:214: undefined reference to `submit_bulk_msg' common/libcommon.a(usb.o): In function `usb_init': /home/wd/git/u-boot/work/common/usb.c:109: undefined reference to `usb_lowlevel_init' common/libcommon.a(usb.o): In function `usb_stop': /home/wd/git/u-boot/work/common/usb.c:133: undefined reference to `usb_lowlevel_stop' common/libcommon.a(usb_storage.o): In function `usb_stor_CBI_get_status': /home/wd/git/u-boot/work/common/usb_storage.c:551: undefined reference to `submit_int_msg' adsvix board: start.S:183:1: warning: "ICMR" redefined In file included from start.S:33: /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:935:1: warning: this is the location of the previous definition start.S:187:1: warning: "RCSR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:1602:1: warning: this is the location of the previous definition start.S:191:1: warning: "OSMR3" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:869:1: warning: this is the location of the previous definition start.S:192:1: warning: "OSCR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:870:1: warning: this is the location of the previous definition start.S:193:1: warning: "OWER" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:872:1: warning: this is the location of the previous definition start.S:194:1: warning: "OIER" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:873:1: warning: this is the location of the previous definition start.S:207:1: warning: "CCCR" redefined /work/wd/tmp-arm/include/asm/arch/pxa-regs.h:1770:1: warning: this is the location of the previous definition pcmcia.c:39:2: warning: #warning "Board will only supply 5V, wait for next HW spin for selectable power" pxa_pcmcia.c: In function 'pcmcia_on': pxa_pcmcia.c:39: warning: operation on 'i' may be undefined cmd_ide.c: In function '__ide_outb': cmd_ide.c:808: warning: implicit declaration of function 'outb' cmd_ide.c: In function '__ide_inb': cmd_ide.c:817: warning: implicit declaration of function 'inb' common/libcommon.a(cmd_ide.o): In function `__ide_outb': /home/wd/git/u-boot/work/common/cmd_ide.c:808: undefined reference to `outb' common/libcommon.a(cmd_ide.o): In function `__ide_inb': /home/wd/git/u-boot/work/common/cmd_ide.c:817: undefined reference to `inb' ixdp425, ixdpg425, pdnb3, pdnb3 boards: make[1]: *** No rule to make target `cpu/ixp/npe/IxNpeMicrocode.o', needed by `cpu/ixp/npe/libnpe.a'. Stop. * MIPS looks mostly OK, too, except here: gth2 board: lowlevel_init.S: Assembler messages: lowlevel_init.S:413: Warning: Pretending global symbol used as branch target is local. Please help with final tresting, and report any serious problems ASAP! Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de Anything free is worth what you pay for it.

5 13

Re: [U-Boot-Users] [PATCH 2/2 (resubmit)] NET: Add Ethernet 1000BASE-X support for PPC4xx
by Larry Johnson 19 Nov '07

19 Nov '07

Ben Warren wrote: > Larry Johnson wrote: >> Hi Ben, >> >> Thank you for your comments. See below... >> >> Ben Warren wrote: >> >>> Larry, >>> >>> I think this can be simplified a bit. More later on... >>> >>> Larry Johnson wrote: >>> >>>> This patch adds a new switch: "CONFIG_PHY_DYNAMIC_ANEG". When this symbol >>>> is defined, the PHY will advertise it's capabilities for autonegotiation >>>> based on the capabilities shown in the PHY's status registers, including >>>> 1000BASE-X. When "CONFIG_PHY_DYNAMIC_ANEG" is not defined, the PHY will >>>> advertise hard-coded capabilities, as before. >>>> >>>> Signed-off-by: Larry Johnson <lrj(a)acm.org> >>>> --- >>>> >>>> common/miiphyutil.c | 155 >>>> +++++++++++++++++++++++++++++++++------------------ >>>> include/miiphy.h | 21 +++++++ >>>> 2 files changed, 121 insertions(+), 55 deletions(-) >>>> >>>> diff --git a/common/miiphyutil.c b/common/miiphyutil.c >>>> index 58ebc5e..b2f62d0 100644 >>>> --- a/common/miiphyutil.c >>>> +++ b/common/miiphyutil.c >>>> @@ -344,101 +344,146 @@ int miiphy_reset (char *devname, unsigned char >>>> addr) >>>> >>>> /***************************************************************************** >>>> >>>> >>>> * >>>> - * Determine the ethernet speed (10/100). >>>> + * Determine the ethernet speed (10/100/1000). Return 10 on error. >>>> */ >>>> int miiphy_speed (char *devname, unsigned char addr) >>>> { >>>> - unsigned short reg; >>>> + u16 bmcr; >>>> >>>> #if defined(CONFIG_PHY_GIGE) >>>> - if (miiphy_read (devname, addr, PHY_1000BTSR, &reg)) { >>>> - printf ("PHY 1000BT Status read failed\n"); >>>> - } else { >>>> - if (reg != 0xFFFF) { >>>> - if ((reg & (PHY_1000BTSR_1000FD | PHY_1000BTSR_1000HD)) >>>> - != 0) { >>>> - return (_1000BASET); >>>> - } >>>> + u16 btsr; >>>> + >>>> +#if defined(CONFIG_PHY_DYNAMIC_ANEG) >>>> >>> I don't think you need this CONFIG. It doesn't really do anything. >>> >> >> I only put it in to keep the footprint smaller for boards that aren't >> using fiber, so I'll get rid if it. >> >> > Yeah, and I like that train of thought, but I think clarity wins out > here, and I doubt there are that many GigE boards that can't handle a > few extra bytes (Don't tell Wolfgang I said that) > [snip] Hi Ben and Stefan, Thank you for incorporating my patch, Ben. I have merged my changes into the PPC4xx "for-1.3.1" branch. When I do the MAKEALL there, the build for Ocotea board fails because the binary is now 0xAC byte too large. What are your opinions on the best way to handle this? Best regards, Larry

3 6

[U-Boot-Users] Annual Conference Information
by DiversityBusiness 19 Nov '07

19 Nov '07

1 0

[U-Boot-Users] Not using filter tags in message headers
by Peter Pearse 19 Nov '07

19 Nov '07

Wolfgang Sorry sorry sorry for recusrive GIT PULL error...... Peter

3 2

[U-Boot-Users] [PATCH] net/eth.c: Fix env_enetaddr signed overflow
by Shinya Kuribayashi 19 Nov '07

19 Nov '07

My colleague founded this problem months ago. I'd like to see this bug fixed in 1.3.0. Please apply. --- net/eth.c: Fix env_enetaddr signed overflow Assigning the output of simple_strtoul(CB:A9:87:65:43:21) to `char', we are warned as below: U-Boot 1.2.0 (Aug 30 2007 - 08:27:37) DRAM: 256 MB Flash: 32 MB In: serial Out: serial Err: serial Net: NEC-Candy Warning: NEC-Candy MAC addresses don't match: Address in SROM is 00:00:4C:80:92:A2 Address in environment is FFFFFFCB:FFFFFFA9:FFFFFF87:65:43:21 This patch changes env_enetaddr type from `char' to `unsigned char'. Cc: Masaki Ishikawa <ishikawa-masaki(a)cnt.mxe.nes.nec.co.jp> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi(a)necel.com> --- net/eth.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/eth.c b/net/eth.c index 1b56a35..64ef312 100644 --- a/net/eth.c +++ b/net/eth.c @@ -138,7 +138,8 @@ int eth_register(struct eth_device* dev) int eth_initialize(bd_t *bis) { - char enetvar[32], env_enetaddr[6]; + char enetvar[32]; + unsigned char env_enetaddr[6]; int i, eth_number = 0; char *tmp, *end; -- Shinya Kuribayashi NEC Electronics

3 2