November 2007 - U-Boot

Re: [U-Boot-Users] post memory test
by Dongying_Xu＠us.alphanetworks.com 19 Nov '07

19 Nov '07

Hi, I have a question about post memory test. According to the following code, even if memory size is greater than 256M, only 256M memory will be tested. Is it true or I missed something. Thanks a lot. In U-BOOT-1.2.0 u-boot\post\drivers\memory.c, int memory_post_test (int flags) { int ret = 0; DECLARE_GLOBAL_DATA_PTR; bd_t *bd = gd->bd; unsigned long memsize = (bd->bi_memsize >= 256 << 20 ? 256 << 20 : bd->bi_memsize) - (1 << 20); if (flags & POST_SLOWTEST) { ret = memory_post_tests (CFG_SDRAM_BASE, memsize); } else { /* POST_NORMAL */ unsigned long i; for (i = 0; i < (memsize >> 20) && ret == 0; i++) { if (ret == 0) ret = memory_post_tests (i << 20, 0x800); if (ret == 0) ret = memory_post_tests ((i << 20) + 0xff800, 0x800); } } return ret; } Best Regards dongy

4 6

[U-Boot-Users] USB Storage Device on other Boards
by Nilson Bastos Jr 19 Nov '07

19 Nov '07

Hi ALL, I'm trying to put the u-Boot working with Embedded Artists board, and I need the USB features. Unfortunatly, EA supplies just the patch for 1.1.6 version of u-boot, that works fine, but doenst have the USB features implemented. What files / defines are necessary to put 1.1.6 working with USB feature ??? I could detect until USB Host adding some 1.3 files in the 1.1.6 version with EA patches. But is there something wrong in the storage devices detection procedure for my board. I think is a missing file or a bad declared define. I thank you in advance for helping. Best Regards Nilson

2 1

Re: [U-Boot-Users] [GIT PULL] [ARM] Please pull fromgit://www.denx.de/git/u-boot-arm.git
by Peter Pearse 19 Nov '07

19 Nov '07

> -----Original Message----- > From: wd(a)denx.de [mailto:wd@denx.de] > Sent: 17 November 2007 00:41 > To: Peter Pearse > Subject: Re: [U-Boot-Users] [GIT PULL] [ARM] Please pull > fromgit://www.denx.de/git/u-boot-arm.git > > Dear Peter, > > in message <000001c8269c$09538000$9a4d010a(a)Emea.Arm.com> you wrote: > > > ... > > Please supply details - if I add your new patch we'll > probably get the > > same problems! > > Could you *please* avoid to have '[GIT PULL]" and "Please > pull from..." in the subject of messages that are NOT pull requests? > Will do - apologies for any inconvenience Peter > Thanks in advance. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: > wd(a)denx.de Microsoft Compatibility: > your old Windows 3.11 application crash exactly as the new ones. >

1 0

Re: [U-Boot-Users] What if eth_init() fails?
by Upakul Barkakaty 19 Nov '07

19 Nov '07

Hi Wolfgang/Detlev, Thanks for writing in. Yes, I do agree with your suggestion that changing the code in eth.c would be, logically, the best way to handle this. The reason why I had suggested changing the code in Netloop() in net.c, was because I had observed the Linux open source file dev.c, where positive error codes had been handled in the dev_init() function, so I thought that would not be a bad idea. Here is the code snippet from the Linux file dev.c /* Init, if this function is available */ if (dev->init) { ret = dev->init(dev); if (ret) { if (ret > 0) ret = -EIO; goto out_err; } } But on second thoughts, yes, logically, it would be best to leave the Netloop() code as it is: if (eth_init(bd) < 0) ... /* error handling */ and modify the code in eth.c file to make it return a negative code in case of errors, to somewhat like this: int eth_init(bd_t *bis) { struct eth_device* old_current; if (!eth_current) return -1; old_current = eth_current; do { debug ("Trying %s\n", eth_current->name); if (!eth_current->init(eth_current,bis)) { eth_current->state = ETH_STATE_ACTIVE; return 0; } debug ("FAIL\n"); eth_try_another(0); } while (old_current != eth_current); return -1; } Regards, Upakul Barkakaty Conexant Systems, Inc. On 11/16/07, Wolfgang Denk <wd(a)denx.de> wrote: Dear Upakul, in message <bb58ac4d0711152213y4e4520ay44ae0b9d5302b9c2(a)mail.gmail.com> you wrote: > > Thanks for the replies. I am attaching herewith, the patch which I suppose > should fix the issue in NetLoop(). I'm sorry, but I think this is actually not a good idea. Tradition is that a function returns <0 (typical -1) in case of problems, and a return code >=0 indicates success (eventually including a useful return value). It seems that the original call was based on that expectation, too: --- u-boot-1.2.0_orig/net/net.c 2007-01-07 04:43:11.000000000 +0530 +++ u-boot-1.2.0/net/net.c 2007-11-14 18:03:03.000000000 +0530 @@ -305,7 +305,7 @@ #ifdef CONFIG_NET_MULTI eth_set_current(); #endif - if (eth_init(bd) < 0) { The test for "< 0" reads to me: "if there was an error"... + if (eth_init(bd) > 0) { Now this is completely misleading. Assuming that eth_init() can only result in sucess or failure, the test should be written either as if (eth_init(bd) != 0) ... /* error handling */ or be left as is: if (eth_init(bd) < 0) ... /* error handling */ Actually I strongly prefer the second form which perfectly matches my internal C parser :-) So the real fix for this problem is to change the code of eth_init() instead and to make it return -1 in case of errors (instead of 1). Note that all places where eth_init() is called should be checked. And BTW: please stop posting HTML! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de There is an order of things in this universe. -- Apollo, "Who Mourns for Adonais?" stardate 3468.1 Conexant E-mail Firewall (Conexant.Com) made the following annotations --------------------------------------------------------------------- ********************** Legal Disclaimer **************************** "This email may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message in error, please advise the sender by reply email and delete the message. Thank you." ********************************************************************** ---------------------------------------------------------------------

2 1

[U-Boot-Users] flash hardware protection with CFI driver does not autoprotect monitor completely
by Matthias Fuchs 19 Nov '07

19 Nov '07

Hi, I noticed that the monitor flash autoprotection from drivers/cfi_flash.c is not completely safe. It does not protect all bootloader sectors in some situations: /* Monitor protection ON by default */ #if (CFG_MONITOR_BASE >= CFG_FLASH_BASE) flash_protect (FLAG_PROTECT_SET, CFG_MONITOR_BASE, CFG_MONITOR_BASE + monitor_flash_len - 1, flash_get_info(CFG_MONITOR_BASE)); #endif I noticed this on the APC405 board after modifying it to use the common CFI flash driver. Here are some lines from its config file: #define CFG_MONITOR_BASE 0xFFF80000 #define CFG_MONITOR_LEN (512 * 1024) /* Reserve 512 kB for Monitor */ #define CFG_FLASH_CFI 1 /* Flash is CFI conformant */ #define CFG_FLASH_CFI_DRIVER 1 /* Use the common driver */ #define CFG_MAX_FLASH_SECT 128 /* max num of sects on one chip */ #define CFG_MAX_FLASH_BANKS 2 /* max num of flash banks */ #define CFG_FLASH_PROTECTION 1 /* use hardware protection */ #define CFG_FLASH_USE_BUFFER_WRITE 1 /* use buffered writes (20x faster) */ #define CFG_FLASH_BANKS_LIST {CFG_FLASH_BASE, CFG_FLASH_BASE + CFG_FLASH_INCREMENT} With this setup 'CFG_MONITOR_BASE + monitor_flash_len - 1' evalutaes to fffc00ff and therefore the last sector will not be protected. But on 4xx CPUs you have the reset vector in the last sector so you definetely want it to be protected. => flinfo ... FFDC0000 FFDE0000 FFE00000 FFE20000 FFE40000 FFE60000 FFE80000 FFEA0000 FFEC0000 FFEE0000 E FFF00000 E FFF20000 E FFF40000 E FFF60000 E FFF80000 RO FFFA0000 RO FFFC0000 RO FFFE0000 Question: what's the best way to fix this? We could modify the call to flash_protect() like this: flash_protect (FLAG_PROTECT_SET, CFG_MONITOR_BASE, CFG_MONITOR_BASE + CFG_MONITOR_LEN - 1, flash_get_info(CFG_MONITOR_BASE)); But I am not sure if this is fine for all architectures. Any ideas? Matthias

3 6

[U-Boot-Users] [PATCH] mpc8544ds.c: Fix warning in MPC8544DS build
by Kumar Gala 19 Nov '07

19 Nov '07

mpc8544ds.c: In function 'pci_init_board': mpc8544ds.c:230: warning: passing argument 1 of 'in_be32' makes pointer from integer without a cast Signed-off-by: Kumar Gala <galak(a)kernel.crashing.org> --- This fixes the only warning on 85xx in -rc4 when testing with ./MAKEALL 85xx board/freescale/mpc8544ds/mpc8544ds.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/board/freescale/mpc8544ds/mpc8544ds.c b/board/freescale/mpc8544ds/mpc8544ds.c index 76d9091..23e2466 100644 --- a/board/freescale/mpc8544ds/mpc8544ds.c +++ b/board/freescale/mpc8544ds/mpc8544ds.c @@ -227,7 +227,7 @@ pci_init_board(void) * Activate ULI1575 legacy chip by performing a fake * memory access. Needed to make ULI RTC work. */ - in_be32(CFG_PCIE3_MEM_BASE); + in_be32((volatile unsigned *)CFG_PCIE3_MEM_BASE); } else { printf (" PCIE3: disabled\n"); } -- 1.5.3.4

2 2

[U-Boot-Users] [PATCH] Fix u16 status declaration when PCMCIA is defined
by Jean-Christophe PLAGNIOL-VILLARD 18 Nov '07

18 Nov '07

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj(a)jcrosoft.com> diff --git a/board/pb1x00/pb1x00.c b/board/pb1x00/pb1x00.c index 95b7d82..536c954 100644 --- a/board/pb1x00/pb1x00.c +++ b/board/pb1x00/pb1x00.c @@ -42,7 +42,9 @@ void write_one_tlb( int index, u32 pagemask, u32 hi, u32 low0, u32 low1 ); int checkboard (void) { +#if defined(CONFIG_IDE_PCMCIA) && 0 u16 status; +#endif /* volatile u32 *pcmcia_bcsr = (u32*)(DB1000_BCSR_ADDR+0x10); */ volatile u32 *sys_counter = (volatile u32*)SYS_COUNTER_CNTRL; u32 proc_id; -- 1.5.3.2

2 5

[U-Boot-Users] [PATCH 0/2] Fix warning differ in signedness in common/cmd_ide.c
by Jean-Christophe PLAGNIOL-VILLARD 18 Nov '07

18 Nov '07

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj(a)jcrosoft.com> diff --git a/common/cmd_ide.c b/common/cmd_ide.c index bb064ea..27cecac 100644 --- a/common/cmd_ide.c +++ b/common/cmd_ide.c @@ -1136,9 +1136,9 @@ static void ide_ident (block_dev_desc_t *dev_desc) input_swap_data (device, iobuf, ATA_SECTORWORDS); - ident_cpy (dev_desc->revision, iop->fw_rev, sizeof(dev_desc->revision)); - ident_cpy (dev_desc->vendor, iop->model, sizeof(dev_desc->vendor)); - ident_cpy (dev_desc->product, iop->serial_no, sizeof(dev_desc->product)); + ident_cpy ((unsigned char*)dev_desc->revision, iop->fw_rev, sizeof(dev_desc->revision)); + ident_cpy ((unsigned char*)dev_desc->vendor, iop->model, sizeof(dev_desc->vendor)); + ident_cpy ((unsigned char*)dev_desc->product, iop->serial_no, sizeof(dev_desc->product)); #ifdef __LITTLE_ENDIAN /* * firmware revision and model number have Big Endian Byte @@ -1953,9 +1953,9 @@ static void atapi_inquiry(block_dev_desc_t * dev_desc) return; /* copy device ident strings */ - ident_cpy(dev_desc->vendor,&iobuf[8],8); - ident_cpy(dev_desc->product,&iobuf[16],16); - ident_cpy(dev_desc->revision,&iobuf[32],5); + ident_cpy((unsigned char*)dev_desc->vendor,&iobuf[8],8); + ident_cpy((unsigned char*)dev_desc->product,&iobuf[16],16); + ident_cpy((unsigned char*)dev_desc->revision,&iobuf[32],5); dev_desc->lun=0; dev_desc->lba=0; -- 1.5.3.2

4 10

[U-Boot-Users] [GIT PULL] MIPS updates
by Shinya Kuribayashi 18 Nov '07

18 Nov '07

Dear Wolfgang, please pull MIPS updates. These patches contain build fixes, style cleanups and trivial optimizations. I also note that the results of MAKEALL mips/mips_el are good for the next release. The following changes since commit 5947f6999aafa7c54c1390983d264a8463dfea8e: Wolfgang Denk (1): Update CHANGELOIG, prepare for -rc4 are available in the git repository at: git://www.denx.de/git/u-boot-mips.git master Shinya Kuribayashi (9): [MIPS] u-boot.lds: Cleanup __u_boot_cmd_{start,end} [MIPS] pb1000: Replace obsolete memsetup.S with lowlevel_init.S MAKEALL: Added missing pb1000 board [MIPS] au1x00_eth.c: Fix au1x00_miiphy_{read,write} build error [MIPS] au1x00_eth.c: Fixed a warning on pb1000 build. [MIPS] gth2.c: Fix a warning on gth2 build. [MIPS] MIPS 4K core: Coding style cleanups [MIPS] Remove useless instructions for initializing $gp. [MIPS] cpu/mips/config.mk: Fix GNU assembler minor version picker MAKEALL | 1 + board/dbau1x00/u-boot.lds | 9 +- board/gth2/gth2.c | 2 +- board/gth2/u-boot.lds | 8 +- board/incaip/u-boot.lds | 9 +- board/pb1x00/Makefile | 2 +- board/pb1x00/{memsetup.S => lowlevel_init.S} | 4 +- board/pb1x00/u-boot.lds | 8 +- board/purple/u-boot.lds | 9 +- board/tb0229/u-boot.lds | 9 +- cpu/mips/au1x00_eth.c | 118 +++++++++++++------------- cpu/mips/cache.S | 30 +++---- cpu/mips/config.mk | 3 +- cpu/mips/cpu.c | 6 +- cpu/mips/start.S | 50 +++++------ 15 files changed, 133 insertions(+), 135 deletions(-) rename board/pb1x00/{memsetup.S => lowlevel_init.S} (99%) thanks, Shinya

2 1

[U-Boot-Users] [MIPS] Remove useless instructions for initializing $gp.
by Shinya Kuribayashi 18 Nov '07

18 Nov '07

Signed-off-by: Shinya Kuribayashi <skuribay(a)ruby.dti.ne.jp> --- cpu/mips/start.S | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/cpu/mips/start.S b/cpu/mips/start.S index 5a278b6..c92b162 100644 --- a/cpu/mips/start.S +++ b/cpu/mips/start.S @@ -238,9 +238,7 @@ reset: nop .word _gp 1: - move gp, ra - lw t1, 0(ra) - move gp, t1 + lw gp, 0(ra) #ifdef CONFIG_INCA_IP /* Disable INCA-IP Watchdog.

2 1