[U-Boot] PATCH: IXP465 support and some IXP4xx rework, Sidewinder board support
Hi,
on the matter of getting u-boot work with the ADI Sidewinder Reference Platform, I found the previously posted patches and used them as starting point for my own patch set. The Sidewinder board works with this patch, including ECC (optional).
There is a minimum set of ifdefs in cpu/ixp/start.S and no board-specific low-level.S and thus no endless code-duplication. The SDRAM parameters are handled by configuration definitions. The ixp425.h and ixp465.h header files should be merged but that can follow in a different patch, possibly renaming the defines and fixing all board specific code. The new initialisation routine was also tested on an IXP425, it really works on both.
The npe_less_fw.patch allows to have NPE-C firmware and still use NPE-B. There is no need to load firmware to NPE-C if you are not going to use it.
This work was done for Erhardt+Leimer GmbH.
Note: I hope this can be merged, however, your description at http://www.denx.de/wiki/U-Boot/Patches makes me worry. I can only use Lotus Notes and that's a bit limited. No, I cannot use another MUA from here, really! If you can accept them at attachments (patches with description header, diff index and Signed-off-by line, I use quilt locallly).
Sincerly,
Hendrik Sattler
PS: please CC on answers as I am not subscribed.
Hi,
h.sattler@erhardt-leimer.com wrote:
Hi,
on the matter of getting u-boot work with the ADI Sidewinder Reference Platform, I found the previously posted patches and used them as starting point for my own patch set. The Sidewinder board works with this patch, including ECC (optional).
There is a minimum set of ifdefs in cpu/ixp/start.S and no board-specific low-level.S and thus no endless code-duplication. The SDRAM parameters are handled by configuration definitions. The ixp425.h and ixp465.h header files should be merged but that can follow in a different patch, possibly renaming the defines and fixing all board specific code.
I think that you use my patchset. It is true?
The new initialisation routine was also tested on an IXP425, it really works on both.
Great :)
The npe_less_fw.patch allows to have NPE-C firmware and still use NPE-B. There is no need to load firmware to NPE-C if you are not going to use it.
This work was done for Erhardt+Leimer GmbH.
Regards Michael
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 12:14:48:
Hi,
h.sattler@erhardt-leimer.com wrote:
Hi,
on the matter of getting u-boot work with the ADI Sidewinder Reference
Platform, I found the previously posted patches and used them as
starting
point for my own patch set. The Sidewinder board works with this patch, including ECC (optional).
There is a minimum set of ifdefs in cpu/ixp/start.S and no
board-specific
low-level.S and thus no endless code-duplication. The SDRAM parameters are handled by configuration definitions. The ixp425.h and ixp465.h header files should be merged but that can follow in a different patch, possibly renaming the defines and fixing
all
board specific code.
I think that you use my patchset. It is true?
Almost. I used it as base but modified it quite a bit. There is almost no difference between IXP465 and IXP425 anymore (except header files), no lowlevel-init.S anymore and correct CPU info display.
BTW: ixdp425_config, ixdpg425_config and pdnb3_config are broken if IxNpeMicrocode.o is not present
HS
Hi,
h.sattler@erhardt-leimer.com wrote:
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 12:14:48:
Hi,
h.sattler@erhardt-leimer.com wrote:
Hi,
on the matter of getting u-boot work with the ADI Sidewinder Reference
Platform, I found the previously posted patches and used them as
starting
point for my own patch set. The Sidewinder board works with this patch, including ECC (optional).
There is a minimum set of ifdefs in cpu/ixp/start.S and no
board-specific
low-level.S and thus no endless code-duplication. The SDRAM parameters are handled by configuration definitions. The ixp425.h and ixp465.h header files should be merged but that can follow in a different patch, possibly renaming the defines and fixing
all
board specific code.
I think that you use my patchset. It is true?
Almost. I used it as base but modified it quite a bit. There is almost no difference between IXP465 and IXP425 anymore (except header files), no lowlevel-init.S anymore and correct CPU info display.
Ok, It was Walfgang ask to my version, but I don't have spare time to work on it.
BTW: ixdp425_config, ixdpg425_config and pdnb3_config are broken if IxNpeMicrocode.o is not present
HS
Regards Michael
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 13:43:44:
h.sattler@erhardt-leimer.com wrote:
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 12:14:48:
Hi,
h.sattler@erhardt-leimer.com wrote:
Hi,
on the matter of getting u-boot work with the ADI Sidewinder
Reference
Platform, I found the previously posted patches and used them as
starting
point for my own patch set. The Sidewinder board works with this patch, including ECC
(optional).
There is a minimum set of ifdefs in cpu/ixp/start.S and no
board-specific
low-level.S and thus no endless code-duplication. The SDRAM parameters are handled by configuration definitions. The ixp425.h and ixp465.h header files should be merged but that can
follow in a different patch, possibly renaming the defines and
fixing
all
board specific code.
I think that you use my patchset. It is true?
Almost. I used it as base but modified it quite a bit. There is almost
no
difference between IXP465 and IXP425 anymore (except header files), no
lowlevel-init.S anymore and correct CPU info display.
Ok, It was Walfgang ask to my version, but I don't have spare time to work on it.
Here are my patches. Maybe you want to test them. I didn't use or update the ixdp465 but you can use the sidewinder_config as starting point. Order is: ixp425_rework.patch ixp465.patch npe_less_fw.patch sidewinder.patch
HS
Hi,
Here are my patches. Maybe you want to test them. I didn't use or update the ixdp465 but you can use the sidewinder_config as starting point. Order is: ixp425_rework.patch ixp465.patch
I see only the ixp465.patch. Some comments: - remove c++ comment - i prefer sdram controller inizialization in board specific part
Clean up the code of print_cpuinfo.
npe_less_fw.patch sidewinder.patch
HS
I can't comment anymore because your patch is not inlined in the email
Regards Michael
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 14:16:15:
Here are my patches. Maybe you want to test them. I didn't use or
update
the ixdp465 but you can use the sidewinder_config as starting point. Order is: ixp425_rework.patch ixp465.patch
I see only the ixp465.patch.
??? The mail included all 4 patches.
Some comments:
- remove c++ comment
Ok.
- i prefer sdram controller inizialization in board specific part
I don't because that will be 99,999% the same code for all IXP46x boards. That's avoidable code duplication. And the SDRAM initialisation is specified by intel to very specific steps, anyway. All important differences can be (and are) expressed as variables. What would you do differently? If you do it completely different, add a define like CFG_CUSTOM_DRAM_INIT that disables the generic code and forces you to add your own.
Clean up the code of print_cpuinfo.
What do you mean?
I can't comment anymore because your patch is not inlined in the email
Sorry, I didn't find out how to inline patches with Lotus Notes, yet. :-( Yes, that software really sucks :-(
HS
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 14:16:15:
Here are my patches. Maybe you want to test them. I didn't use or
update
the ixdp465 but you can use the sidewinder_config as starting point. Order is: ixp425_rework.patch ixp465.patchcd trun
I see only the ixp465.patch.
To work around the limitation of this MUA, the patches are available at http://www.hendrik-sattler.de/patches/ixp465/
Note: these patches are for u-boot 1.3.4! Maybe some incompatible changes that followed that version.
HS
Dear h.sattler@erhardt-leimer.com,
Please STOP prepending the non-standard "Antwort: " to the subject, as this essentially makes the Subjkect line useless. Please make sure to use a RCF-conformant MUA to compose your messages.
In message OF8F1EBCA2.E6BA03A3-ONC12574DC.003A8028-C12574DC.003A7339@erhardt-leimer.com you wrote:
To work around the limitation of this MUA, the patches are available at http://www.hendrik-sattler.de/patches/ixp465/
It doesn;t work like that. Patches have to be posted on the mailing list, or they will be ignored.
Note: these patches are for u-boot 1.3.4! Maybe some incompatible changes that followed that version.
Then please rebase your patches against top of tree, and send them to the ML.
Thanks.
Best regards,
Wolfgang Denk
Ups, fixed the subject line manually. Sorry.
michael trimarchi@gandalf.sssup.it schrieb am 07.10.2008 14:16:15:
Here are my patches. Maybe you want to test them. I didn't use or
update
the ixdp465 but you can use the sidewinder_config as starting point. Order is: ixp425_rework.patch ixp465.patchcd trun
I see only the ixp465.patch.
To work around the limitation of this MUA, the patches are available at http://www.hendrik-sattler.de/patches/ixp465/
Note: these patches are for u-boot 1.3.4! Maybe some incompatible changes that followed that version.
HS
Dear h.sattler@erhardt-leimer.com,
In message OF8F1EBCA2.E6BA03A3-ONC12574DC.003A8028-C12574DC.003AD57D@erhardt-leimer.com you wrote:
Ups, fixed the subject line manually. Sorry.
Note: your mailer also fails to add threading information (i. e. "In-reply-to: " and "References: " headers.
Best regards,
Wolfgang Denk
Wolfgang Denk wd@denx.de schrieb am 08.10.2008 12:56:28:
Dear h.sattler@erhardt-leimer.com,
In message <OF8F1EBCA2.E6BA03A3-ONC12574DC.003A8028-C12574DC. 003AD57D@erhardt-leimer.com> you wrote:
Ups, fixed the subject line manually. Sorry.
Note: your mailer also fails to add threading information (i. e. "In-reply-to: " and "References: " headers.
which is beyond my control
*sigh* Please use my other mail address and I'll find a way to use Thunderbird...
HS
participants (3)
-
h.sattler＠erhardt-leimer.com -
michael -
Wolfgang Denk