April 2022 - U-Boot

[BUG] keyboard doesn't work on Olimex teres-I notebook
by Milan P. Stanić 08 Jun '22

08 Jun '22

[ Please CC to me, I'm not subscribed to mailing list ] Hi, On u-boot release 2022.04 keyboard doesn't work in u-boot on Olimex TERES-I notebook. With git bisect I found that commit 35ae126c16a6a9149edc6638faaa247f67b8a400 is introduced this. Reverting this commit solved problem and in my test keyboard now works. -- Kind regards

2 2

[PATCH] watchdog: Fix SPL build with watchdog disabled in asm files
by Pali Rohár 07 Jun '22

07 Jun '22

Allow to compile assembler files in SPL build which calls WATCHDOG_RESET function when watchdog is disabled in SPL and enabled in U-Boot proper. This issue was fixed in past by commit 7fbd42f5afc4 ("watchdog: Handle SPL build with watchdog disabled") for C source files, but not for assembler source files. Currently the only assembler source file which calls WATCHDOG_RESET is arch/powerpc/lib/ticks.S, so this patch affects and fixes powerpc SPL builds. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- include/watchdog.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/watchdog.h b/include/watchdog.h index 14fa5fda259e..813cc8f2a5d3 100644 --- a/include/watchdog.h +++ b/include/watchdog.h @@ -49,7 +49,13 @@ int init_func_watchdog_reset(void); */ #if defined(CONFIG_WATCHDOG) #if defined(__ASSEMBLY__) - #define WATCHDOG_RESET bl watchdog_reset + /* Don't require the watchdog to be enabled in SPL */ + #if defined(CONFIG_SPL_BUILD) && \ + !defined(CONFIG_SPL_WATCHDOG) + #define WATCHDOG_RESET /*XXX DO_NOT_DEL_THIS_COMMENT*/ + #else + #define WATCHDOG_RESET bl watchdog_reset + #endif #else /* Don't require the watchdog to be enabled in SPL */ #if defined(CONFIG_SPL_BUILD) && \ -- 2.20.1

2 3

[BUG] RockPro64 not booting since 3ae64582fb
by Aleksei 05 Jun '22

05 Jun '22

Hi U-boot developers, I'm booting RockPro64 by writing compiled u-boot-rockchip.bin to SD card offset 64 as described in doc/board/rockchip/rockchip.rst. There is a USB flash drive plugged into USB2 port containing ext4 filesystem with extlinux/exlinux.conf and a kernel+initrd images. This setup boots fine on 02ce99ec91 but not on the next 3ae64582fb. It gets stuck on "Booting using the fdt blob at 0x1f000000". Let me know if I can help debug this. I have a "daily driver" RockPro64 v2.1, can pull from git repos/branches or apply patches to source tree - whichever you prefer. Best regards, Aleksei, U-boot user

4 5

[PATCH] powerpc: mpc85xx: Fix compilation with CONFIG_WDT
by Pali Rohár 04 Jun '22

04 Jun '22

When CONFIG_WDT is enabled then non-DM watchdog code cannot be used due to conflicting functions like watchdog_reset(). So disable compilation of mpc85xx watchdog_reset() function when CONFIG_WDT is enabled. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- arch/powerpc/cpu/mpc85xx/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/cpu/mpc85xx/cpu.c b/arch/powerpc/cpu/mpc85xx/cpu.c index 261f79e40585..226a26ba320a 100644 --- a/arch/powerpc/cpu/mpc85xx/cpu.c +++ b/arch/powerpc/cpu/mpc85xx/cpu.c @@ -348,6 +348,7 @@ __weak unsigned long get_tbclk(void) } +#ifndef CONFIG_WDT #if defined(CONFIG_WATCHDOG) #define WATCHDOG_MASK (TCR_WP(63) | TCR_WRC(3) | TCR_WIE) void @@ -376,6 +377,7 @@ watchdog_reset(void) enable_interrupts(); } #endif /* CONFIG_WATCHDOG */ +#endif /* * Initializes on-chip MMC controllers. -- 2.20.1

1 1

[PATCH] squashfs: Fix compilation on big endian systems
by Pali Rohár 03 Jun '22

03 Jun '22

Signed-off-by: Pali Rohár <pali(a)kernel.org> --- fs/squashfs/sqfs.c | 3 +-- fs/squashfs/sqfs_dir.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c index 5d9c52af80ba..41cb811c1b32 100644 --- a/fs/squashfs/sqfs.c +++ b/fs/squashfs/sqfs.c @@ -11,8 +11,7 @@ #include <errno.h> #include <fs.h> #include <linux/types.h> -#include <linux/byteorder/little_endian.h> -#include <linux/byteorder/generic.h> +#include <asm/byteorder.h> #include <memalign.h> #include <stdlib.h> #include <string.h> diff --git a/fs/squashfs/sqfs_dir.c b/fs/squashfs/sqfs_dir.c index a265b98fe685..ed83c90682ff 100644 --- a/fs/squashfs/sqfs_dir.c +++ b/fs/squashfs/sqfs_dir.c @@ -7,8 +7,7 @@ #include <errno.h> #include <linux/types.h> -#include <linux/byteorder/little_endian.h> -#include <linux/byteorder/generic.h> +#include <asm/byteorder.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> -- 2.20.1

3 9

[PATCH] efi_loader: disk: allow blk devices even without UCLASS_PARTITION
by AKASHI Takahiro 01 Jun '22

01 Jun '22

While GPT partition is mandated in UEFI specification, CONFIG_PARTITION is seen optional under the current implementation. So modify efi_disk_rw_blocks() to allow accepting UCLASS_BLK devices. Fixes: commit d97e98c887ed ("efi_loader: disk: use udevice instead of blk_desc") Signed-off-by: AKASHI Takahiro <takahiro.akashi(a)linaro.org> --- lib/efi_loader/efi_disk.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index 8fb5b2363c45..f5b462fb164a 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -99,21 +99,22 @@ static efi_status_t efi_disk_rw_blocks(struct efi_block_io *this, if (buffer_size & (blksz - 1)) return EFI_BAD_BUFFER_SIZE; -#if CONFIG_IS_ENABLED(PARTITIONS) - if (direction == EFI_DISK_READ) - n = dev_read(diskobj->dev, lba, blocks, buffer); - else - n = dev_write(diskobj->dev, lba, blocks, buffer); -#else - /* dev is always a block device (UCLASS_BLK) */ - struct blk_desc *desc; + if (CONFIG_IS_ENABLED(PARTITIONS) && + device_get_uclass_id(diskobj->dev) == UCLASS_PARTITION) { + if (direction == EFI_DISK_READ) + n = dev_read(diskobj->dev, lba, blocks, buffer); + else + n = dev_write(diskobj->dev, lba, blocks, buffer); + } else { + /* dev is a block device (UCLASS_BLK) */ + struct blk_desc *desc; - desc = dev_get_uclass_plat(diskobj->dev); - if (direction == EFI_DISK_READ) - n = blk_dread(desc, lba, blocks, buffer); - else - n = blk_dwrite(desc, lba, blocks, buffer); -#endif + desc = dev_get_uclass_plat(diskobj->dev); + if (direction == EFI_DISK_READ) + n = blk_dread(desc, lba, blocks, buffer); + else + n = blk_dwrite(desc, lba, blocks, buffer); + } /* We don't do interrupts, so check for timers cooperatively */ efi_timer_check(); -- 2.33.0

3 5

[PATCH v7 0/7] fpga: zynqmp: Adding support of loading authenticated images
by Adrian Fiergolski 01 Jun '22

01 Jun '22

This patchset introduces support for the authenticated FPGA images on ZynqMP boards, besides that introducing common way to pass the compatible property to any fpga driver. It bases on the initial work by Jorge Ramirez-Ortiz <jorge(a)foundries.io> https://patchwork.ozlabs.org/project/uboot/patch/20211015091506.2602-1-jorg… https://patchwork.ozlabs.org/project/uboot/patch/20211005111324.19749-3-jor… Changed in v7: - apply Michal Simek's suggestions As I applied changes on Oleksandr's patches, I indicated it by specifying myself as co-author in the commits logs. I am not sure if that is the convention of marking it. Changed in v6: - add support for the encrypted bitfiles Changes in v5: - replace ifdef with if() where it's possible Changes in v4: - change interface to xilinx_desc->operations->open() callback. - fix a bug from previous version of the patchset in dereferencing of a parent fpga_desc structure. Changes in v3: - remove the patch which introduced CMD_SPL_FPGA_LOAD_SECURE. - fix mixing definitions/declarations. - replace strcmp() calls with more secure strncmp(). - document the "u-boot,zynqmp-fpga-ddrauth" compatible string. - fix code style by check-patch recommendations. Changes in v2: - add function fit_fpga_load() to simplify calls of fpga_load() from contexts without a compatible attribute. - move all ZynqMP-specific logic to drivers/fpga/zynqmppl.c - prepare for passing a "compatible" FDT property to any fpga driver. Oleksandr Suvorov (6): fpga: add option for loading FPGA secure bitstreams fpga: add fit_fpga_load function fpga: xilinx: pass an address of xilinx_desc in fpga_desc fpga: xilinx: add missed identifier names fpga: xilinx: pass xilinx_desc pointer address into load() ops fpga: zynqmp: support loading authenticated images Adrian Fiergolski (1): fpga: zynqmp: support loading encrypted bitfiles boot/Kconfig | 4 +-- cmd/Kconfig | 3 ++- common/spl/spl_fit.c | 6 ++--- doc/uImage.FIT/source_file_format.txt | 7 +++++- drivers/fpga/Kconfig | 14 +++++++++++ drivers/fpga/fpga.c | 29 ++++++++++++++++++--- drivers/fpga/spartan2.c | 3 ++- drivers/fpga/spartan3.c | 3 ++- drivers/fpga/versalpl.c | 2 +- drivers/fpga/virtex2.c | 3 ++- drivers/fpga/xilinx.c | 8 +++--- drivers/fpga/zynqmppl.c | 36 ++++++++++++++++++++++++--- drivers/fpga/zynqpl.c | 3 ++- include/fpga.h | 5 ++++ include/xilinx.h | 12 +++++---- 15 files changed, 109 insertions(+), 29 deletions(-) -- 2.35.1

3 24

[PATCH v6 0/2] sf: Check protection before writing/erasing flash
by Jan Kiszka 31 May '22

31 May '22

Changes in v6: - fixed embarrassingly inverted logic in unlock check (and properly tested it this time) Changes in v5: - adjust unused is_locked callback to our is_unlocked needs - use this callback in sf command instead Jan Jan Kiszka (2): mtd: spi: Convert is_locked callback to is_unlocked sf: Query write-protection status before operating the flash cmd/sf.c | 12 ++++++++++++ drivers/mtd/spi/spi-nor-core.c | 26 +++++++++++++------------- include/linux/mtd/spi-nor.h | 6 +++--- 3 files changed, 28 insertions(+), 16 deletions(-) -- 2.34.1

2 4

[PATCH] net: e1000: Depend on CONFIG_PCI
by Sean Anderson 27 May '22

27 May '22

This driver depends on PCI. Update the Kconfig accordingly. Signed-off-by: Sean Anderson <sean.anderson(a)seco.com> --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 347fe8aa42..339ccdae15 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -231,6 +231,7 @@ config DWC_ETH_QOS_TEGRA186 config E1000 bool "Intel PRO/1000 Gigabit Ethernet support" + depends on PCI help This driver supports Intel(R) PRO/1000 gigabit ethernet family of adapters. For more information on how to identify your adapter, go -- 2.35.1.1320.gc452695387.dirty

5 4

imx8mm eLCDIF clock
by Tommaso Merciai 27 May '22

27 May '22

Hi, I'm working on drivers/clk/imx/clk-imx8mm.c to port and bring up eLCDIF clocks. After port all necessary clocks needed by eLCDIF I found that IMX8MM_VIDEO_PLL1 clock is not enabled and need the following code to enable it at the end of the clk-imx8mm probe: struct clk *clkp; clk_get_by_id(IMX8MM_VIDEO_PLL1, &clkp); clk_set_rate(clkp, 594000000UL); clk_enable(clkp); What do you think about this solution? There is a more standard way to do this? Thanks, Tommmaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai(a)amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info(a)amarulasolutions.com www.amarulasolutions.com

6 12