January 2021 - U-Boot

[PATCH v5] net: tftp: Add client support for RFC 7440
by Ramon Fried 17 Feb '21

17 Feb '21

Add support for RFC 7440: "TFTP Windowsize Option". This optional feature allows the client and server to negotiate a window size of consecutive blocks to send as an alternative for replacing the single-block lockstep schema. windowsize can be defined statically during compilation by setting CONFIG_TFTP_WINDOWSIZE, or defined in runtime by setting an environment variable: "tftpwindowsize" If not defined, the windowsize is set to 1, meaning that it behaves as it was never defined. Choosing the appropriate windowsize depends on the specific network topology, underlying NIC. You should test various windowsize scenarios and see which best work for you. Setting a windowsize too big can actually decreases performance. Signed-off-by: Ramon Fried <rfried.dev(a)gmail.com> Reviewed-by: Marek Vasut <marex(a)denx.de> --- v2: * Don't send windowsize option on tftpput, as it's not implemented yet. * Don't send NACK for every out of order block that arrives, one nack is enough. v3: * Add option CONFIG_TFTP_WINDOWSIZE to kconfig with default 1. * Fixed some spelling errors. * Took assignment out of a loop. * simplified variable increment. v4: * send ack for last packet, so the server can finish the tranfer gracefully and not in timeout. v5: * rebase the patch on top of latest tftp changes. * Fix wraparound issue in tftp_cur_block increment. * Change strcmp to strcasecmp README | 5 ++++ net/Kconfig | 9 ++++++ net/tftp.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++----- 3 files changed, 86 insertions(+), 7 deletions(-) diff --git a/README b/README index 2384966a39..2ebf664848 100644 --- a/README +++ b/README @@ -3473,6 +3473,11 @@ List of environment variables (most likely not complete): downloads succeed with high packet loss rates, or with unreliable TFTP servers or client hardware. + tftpwindowsize - if this is set, the value is used for TFTP's + window size as described by RFC 7440. + This means the count of blocks we can receive before + sending ack to server. + vlan - When set to a value < 4095 the traffic over Ethernet is encapsulated/received over 802.1q VLAN tagged frames. diff --git a/net/Kconfig b/net/Kconfig index ac6d0cf8a6..7916ae305f 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -49,4 +49,13 @@ config TFTP_BLOCKSIZE almost-MTU block sizes. You can also activate CONFIG_IP_DEFRAG to set a larger block. +config TFTP_WINDOWSIZE + int "TFTP window size" + default 1 + help + Default TFTP window size. + RFC7440 defines an optional window size of transmits, + before an ack response is required. + The default TFTP implementation implies a window size of 1. + endif # if NET diff --git a/net/tftp.c b/net/tftp.c index c05b7b5532..84e970bec1 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -5,7 +5,6 @@ * Copyright 2011 Comelit Group SpA, * Luca Ceresoli <luca.ceresoli(a)comelit.it> */ - #include <common.h> #include <command.h> #include <efi_loader.h> @@ -98,6 +97,12 @@ static int tftp_tsize; /* The number of hashes we printed */ static short tftp_tsize_num_hash; #endif +/* The window size negotiated */ +static ushort tftp_windowsize; +/* Next block to send ack to */ +static ushort tftp_next_ack; +/* Last nack block we send */ +static ushort tftp_last_nack; #ifdef CONFIG_CMD_TFTPPUT /* 1 if writing, else 0 */ static int tftp_put_active; @@ -138,8 +143,19 @@ static char tftp_filename[MAX_LEN]; * (but those using CONFIG_IP_DEFRAG may want to set a larger block in cfg file) */ +/* When windowsize is defined to 1, + * tftp behaves the same way as it was + * never declared + */ +#ifdef CONFIG_TFTP_WINDOWSIZE +#define TFTP_WINDOWSIZE CONFIG_TFTP_WINDOWSIZE +#else +#define TFTP_WINDOWSIZE 1 +#endif + static unsigned short tftp_block_size = TFTP_BLOCK_SIZE; static unsigned short tftp_block_size_option = CONFIG_TFTP_BLOCKSIZE; +static unsigned short tftp_window_size_option = TFTP_WINDOWSIZE; static inline int store_block(int block, uchar *src, unsigned int len) { @@ -356,6 +372,14 @@ static void tftp_send(void) /* try for more effic. blk size */ pkt += sprintf((char *)pkt, "blksize%c%d%c", 0, tftp_block_size_option, 0); + + /* try for more effic. window size. + * Implemented only for tftp get. + * Don't bother sending if it's 1 + */ + if (tftp_state == STATE_SEND_RRQ && tftp_window_size_option > 1) + pkt += sprintf((char *)pkt, "windowsize%c%d%c", + 0, tftp_window_size_option, 0); len = pkt - xp; break; @@ -550,7 +574,17 @@ static void tftp_handler(uchar *pkt, unsigned dest, struct in_addr sip, (char *)pkt + i + 6, tftp_tsize); } #endif + if (strcasecmp((char *)pkt + i, "windowsize") == 0) { + tftp_windowsize = + simple_strtoul((char *)pkt + i + 11, + NULL, 10); + debug("windowsize = %s, %d\n", + (char *)pkt + i + 11, tftp_windowsize); + } } + + tftp_next_ack = tftp_windowsize; + #ifdef CONFIG_CMD_TFTPPUT if (tftp_put_active && tftp_state == STATE_OACK) { /* Get ready to send the first block */ @@ -564,7 +598,28 @@ static void tftp_handler(uchar *pkt, unsigned dest, struct in_addr sip, if (len < 2) return; len -= 2; - tftp_cur_block = ntohs(*(__be16 *)pkt); + + if (ntohs(*(__be16 *)pkt) != (ushort)(tftp_cur_block + 1)) { + debug("Received unexpected block: %d, expected: %d\n", + ntohs(*(__be16 *)pkt), + (ushort)(tftp_cur_block + 1)); + /* + * If one packet is dropped most likely + * all other buffers in the window + * that will arrive will cause a sending NACK. + * This just overwellms the server, let's just send one. + */ + if (tftp_last_nack != tftp_cur_block) { + tftp_send(); + tftp_last_nack = tftp_cur_block; + tftp_next_ack = (ushort)(tftp_cur_block + + tftp_windowsize); + } + break; + } + + tftp_cur_block++; + tftp_cur_block %= TFTP_SEQUENCE_SIZE; if (tftp_state == STATE_SEND_RRQ) debug("Server did not acknowledge any options!\n"); @@ -606,10 +661,15 @@ static void tftp_handler(uchar *pkt, unsigned dest, struct in_addr sip, * Acknowledge the block just received, which will prompt * the remote for the next one. */ - tftp_send(); + if (tftp_cur_block == tftp_next_ack) { + tftp_send(); + tftp_next_ack += tftp_windowsize; + } - if (len < tftp_block_size) + if (len < tftp_block_size) { + tftp_send(); tftp_complete(); + } break; case TFTP_ERROR: @@ -683,6 +743,10 @@ void tftp_start(enum proto_t protocol) if (ep != NULL) tftp_block_size_option = simple_strtol(ep, NULL, 10); + ep = env_get("tftpwindowsize"); + if (ep != NULL) + tftp_window_size_option = simple_strtol(ep, NULL, 10); + ep = env_get("tftptimeout"); if (ep != NULL) timeout_ms = simple_strtol(ep, NULL, 10); @@ -704,8 +768,8 @@ void tftp_start(enum proto_t protocol) } #endif - debug("TFTP blocksize = %i, timeout = %ld ms\n", - tftp_block_size_option, timeout_ms); + debug("TFTP blocksize = %i, TFTP windowsize = %d timeout = %ld ms\n", + tftp_block_size_option, tftp_window_size_option, timeout_ms); tftp_remote_ip = net_server_ip; if (!net_parse_bootfile(&tftp_remote_ip, tftp_filename, MAX_LEN)) { @@ -801,7 +865,8 @@ void tftp_start(enum proto_t protocol) tftp_our_port = simple_strtol(ep, NULL, 10); #endif tftp_cur_block = 0; - + tftp_windowsize = 1; + tftp_last_nack = 0; /* zero out server ether in case the server ip has changed */ memset(net_server_ethaddr, 0, 6); /* Revert tftp_block_size to dflt */ -- 2.27.0

4 10

[PATCH v4 0/7] Introduce DSA Ethernet switch class and Felix driver
by Vladimir Oltean 16 Feb '21

16 Feb '21

From: Vladimir Oltean <vladimir.oltean(a)nxp.com> DSA stands for Distributed Switch Architecture and it is a subsystem introduced in the Linux kernel to support switches that: - have an Ethernet link up to the CPU - use some form of tagging to identify the source/destination port for Rx/Tx - may be cascaded in tree-like structures. DSA is described in depth here: https://www.kernel.org/doc/Documentation/networking/dsa/dsa.txt This patch set introduces a DSA class in U-Boot to support drivers of DSA switches. DSA drivers have to implement the following ops: - enable/disable of switch ports, - insert a tag in frames being transmitted, used by the switch to select the egress port, - parse a tag in frames being received, used for Rx traffic. DSA class code deals with presentation of switch ports as Ethernet interfaces, deals with the master Ethernet device for I/O and helps with parsing of the DT assuming the structure follows the DSA kernel binding. Support for switch cascading is not included yet. In the sandbox environment, the DSA sandbox driver, the switch ports and master eth interface look like this: => dm tree Class Index Probed Driver Name ----------------------------------------------------------- [...] eth 4 [ + ] eth_sandbox |-- dsa-test-eth dsa 0 [ + ] dsa_sandbox |-- dsa-test eth 5 [ + ] dsa-port | |-- lan0 eth 6 [ + ] dsa-port | `-- lan1 => setenv ethact lan1 => ping 1.2.3.5 Using lan1 device host 1.2.3.5 is alive => This patch set also introduces a driver for the Ethernet switch integrated into NXP LS1028A, called Felix. The switch has 4 front panel ports, I/O to/from it is done though an ENETC Ethernet interface and meta-data is carried between the switch and the driver though an additional header pre-pended to the original frame. Network commands like tftp can be used on these front panel ports. The ports are disabled unless used so they do not cause issues on network topologies that include loops. Felix as seen on LS1028A RDB: => dm tree Class Index Probed Driver Name ----------------------------------------------------------- [...] dsa 0 [ + ] felix-switch | |-- felix-switch eth 4 [ + ] dsa-port | | |-- swp0 eth 5 [ + ] dsa-port | | |-- swp1 eth 6 [ + ] dsa-port | | |-- swp2 eth 7 [ + ] dsa-port | | `-- swp3 => mdio list [...] 10 - Vitesse VSC8514 <--> swp0 11 - Vitesse VSC8514 <--> swp1 12 - Vitesse VSC8514 <--> swp2 13 - Vitesse VSC8514 <--> swp3 NOTE: This patchset is a major rework of the dsa-class code since the last submission from May 5th: https://patchwork.ozlabs.org/project/uboot/cover/1588700588-8587-1-git-send… The basic concepts and data path operation (tagging) in the DSA class code remain the same as in the initial patchset from Alex, however the external API has been changed significantly (simplified), the driver model integration has been improved to the point that the DSA class code no longer needs to allocate extra memory internally (via malloc), reduced memory footprint, internal state data moved from the external API and internalized, cleaner external API, internal code reworked, completely reworked DSA sandbox driver and unit tests for better coverage and to integrate better with the eth sandbox driver and tests, etc. v4: - Implemented the TODO for having a phy_device on the CPU port. - Enabled CONFIG_PHY_FIXED which is a new dependency of CONFIG_DM_DSA. v3: - Removed all infrastructure associated with dsa_foreach_port, which is no longer needed. - Only inherit the DSA master's MAC address if the environment does not already have a specific MAC address that should be used for the DSA port. - Be compatible with the new "ethernet-ports" container name which has been introduced in the Linux kernel as commit 85e05d263ed2 ("net: dsa: of: Allow ethernet-ports as encapsulating node") in v5.9. - Fixed the felix driver not getting its ports initialized, due to dsa_foreach_port() being actually unusable when called from the probe function of the DSA udevice - the eth port udevices are _not_ yet probed at that point. We are now initializing all ports from the .port_enable() callback of each eth udevice. - Deleted the unit tests associated with the infrastructure for dsa_foreach_port, since that function no longer exists. - Enabled the config options for the Kontron LS1028A board too. v2: Switch node structure defined in dtsi now consistent with the Linux switch node definition. Moved aliases from dtsi to the RDB dts to minimize impact on other boards (and for improved flexibility). Alex Marginean (3): drivers: net: Add Felix DSA switch driver arm: dts: ls1028a: Add Ethernet switch node and dependencies configs: ls1028a: Enable the Ethernet switch driver in defconfig Claudiu Manoil (2): net: Introduce DSA class for Ethernet switches sandbox: Add a DSA sandbox driver and unit test Vladimir Oltean (2): net: phy: fixed: support speeds of 2500 and 10000 net: phy: introduce fixed_phy_create for DSA CPU ports arch/Kconfig | 1 + arch/arm/dts/fsl-ls1028a-rdb.dts | 64 +++ arch/arm/dts/fsl-ls1028a.dtsi | 56 ++- arch/sandbox/dts/test.dts | 48 ++ configs/kontron_sl28_defconfig | 3 + configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 3 + configs/ls1028aqds_tfa_defconfig | 3 + configs/ls1028ardb_tfa_SECURE_BOOT_defconfig | 3 + configs/ls1028ardb_tfa_defconfig | 3 + drivers/net/Kconfig | 24 + drivers/net/Makefile | 1 + drivers/net/dsa_sandbox.c | 179 +++++++ drivers/net/fsl_enetc.h | 5 + drivers/net/mscc_eswitch/Kconfig | 8 + drivers/net/mscc_eswitch/Makefile | 1 + drivers/net/mscc_eswitch/felix_switch.c | 414 ++++++++++++++++ drivers/net/phy/fixed.c | 3 +- drivers/net/phy/phy.c | 31 ++ include/configs/sandbox.h | 2 + include/dm/uclass-id.h | 1 + include/net.h | 6 + include/net/dsa.h | 165 +++++++ include/phy.h | 21 + net/Makefile | 1 + net/dsa-uclass.c | 478 +++++++++++++++++++ test/dm/Makefile | 1 + test/dm/dsa.c | 82 ++++ test/dm/eth.c | 10 +- 28 files changed, 1610 insertions(+), 7 deletions(-) create mode 100644 drivers/net/dsa_sandbox.c create mode 100644 drivers/net/mscc_eswitch/felix_switch.c create mode 100644 include/net/dsa.h create mode 100644 net/dsa-uclass.c create mode 100644 test/dm/dsa.c -- 2.25.1

4 29

[PATCH v8 0/4] OP-TEE I2C trampoline and associated tests
by Igor Opaniuk 16 Feb '21

16 Feb '21

From: Igor Opaniuk <igor.opaniuk(a)foundries.io> This patchset allows OP-TEE to communicate with I2C devices; a typical use case would be servicing U-Boot requests that require underlying cryptographic operations implemented by an I2C chip. On a board fitted with the NXP SE050 I2C secure element, OP-TEE can route some of the cryptographic operations it needs to that device (ie RSA, ECC, CTR..). Before the REE executes, OP-TEE would use its own I2C drivers to communicate with the device on the bus; later on, once the REE is up, accesses to the I2C bus should be coordinated with the REE to avoid collisions. However instead of implementing such a synchronization mechanism, this trampoline service permits OP-TEE to route those I2C requests back to U-boot without then having to worry about collisions. Lets suppose that U-Boot executes the trusted application Android Verified Boot; when OP-TEE receives the request - and before executing the application - it uses RSA to verify it. So on the back of the TA function invocation, OP-TEE returns to U-boot with a sequence of RPC calls requesting I2C transfers (check carefully the implementation in do_call_with_arg(...) implemented in drivers/tee/optee/core.c and notice the while loop) When using sandbox testing, RPC is called directly to validate its actual implementation; however as succintly described above, these calls will always be originated in OP-TEE. Changes v8: * [Etienne Carriere] extended TA param description (missed one param) Changes v7: * [Etienne Carriere] extended TA param description, adding info about i2c xfer flags. Applied A-b and R-b tags * [Jens Wiklander] applied R-b tag Changes v6: * [Etienne Carriere] fixed func return code handling * [Etienne Carriere] tee_optee_ta_uuid passing a pointer instead of full struct * [Etienne Carriere] pass additionally i2c control flags in tests * Fixed mispelling in the comments Changes v5: * [Jens Wiklander] Addressed comment about optee_alloc_and_init_page_list(): drop inline, proper return value and comment Changes v4: * [Simon Glass] Reduced amount ifdefs warnings and move to if (IS_ENABLED(CONFIG_*)) where possible * Fixed pointer-sign warnings Changes v3: * [Simon Glass] Added RPC I2C test coverage Changes v2: * [Simon Glass] Adjusted the usage of DM internal api (dev_get_parent_platdata) * [Simon Glass] Added additional comments to functions * [Jens Wiklander] s/tmem/rmem/g Igor Opaniuk (3): test: py: add pygit2 and pyelftools to requirements.txt drivers: tee: sandbox: add rpc test ta emulation test: dm: tee: extend with RPC test Jorge Ramirez-Ortiz (1): drivers: tee: i2c trampoline driver drivers/tee/Makefile | 2 + drivers/tee/optee/Kconfig | 9 ++ drivers/tee/optee/Makefile | 1 + drivers/tee/optee/i2c.c | 90 ++++++++++++++ drivers/tee/optee/optee_msg.h | 21 ++++ drivers/tee/optee/optee_msg_supplicant.h | 5 + drivers/tee/optee/optee_private.h | 17 +++ drivers/tee/optee/supplicant.c | 3 + drivers/tee/sandbox.c | 142 ++++++++++++++++++++++- include/tee/optee_ta_rpc_test.h | 30 +++++ test/dm/tee.c | 116 ++++++++++++++++-- test/py/requirements.txt | 2 + 12 files changed, 427 insertions(+), 11 deletions(-) create mode 100644 drivers/tee/optee/i2c.c create mode 100644 include/tee/optee_ta_rpc_test.h -- 2.25.1

2 8

[PATCH v5] dm: core: Add of_match_node helper function
by Biju Das 15 Feb '21

15 Feb '21

Add of_match_node() helper function to iterate over the device tree and tell if a device_node has a matching of_match structure. Signed-off-by: Biju Das <biju.das.jz(a)bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj(a)bp.renesas.com> Reviewed-by: Simon Glass <sjg(a)chromium.org> --- v4->v5: * Rebased to latest master v3->v4: No change * Added Simon's Rb tag. v2->v3: * Added a test case for of_match_node helper function. (Ref: https://patchwork.ozlabs.org/project/uboot/patch/20201102150959.4793-2-biju…) v1->v2: * No Change v1: * New Patch --- drivers/core/device.c | 21 +++++++++++++++++++++ include/dm/device.h | 13 +++++++++++++ test/dm/core.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 65 insertions(+) diff --git a/drivers/core/device.c b/drivers/core/device.c index aeab3836ed..4ff708fd38 100644 --- a/drivers/core/device.c +++ b/drivers/core/device.c @@ -1022,6 +1022,27 @@ bool of_machine_is_compatible(const char *compat) return !fdt_node_check_compatible(fdt, 0, compat); } +static +const struct udevice_id *__of_match_node(const struct udevice_id *matches, + const ofnode node) +{ + if (!matches) + return NULL; + + for (; matches->compatible; matches++) { + if (ofnode_device_is_compatible(node, matches->compatible)) + return matches; + } + + return NULL; +} + +const struct udevice_id *of_match_node(const struct udevice_id *matches, + const ofnode node) +{ + return __of_match_node(matches, node); +} + int dev_disable_by_path(const char *path) { struct uclass *uc; diff --git a/include/dm/device.h b/include/dm/device.h index f5b4cd6876..950fc78184 100644 --- a/include/dm/device.h +++ b/include/dm/device.h @@ -802,6 +802,19 @@ bool device_is_compatible(const struct udevice *dev, const char *compat); */ bool of_machine_is_compatible(const char *compat); +/** + * of_match_node() - Tell if a device_node has a matching of_match structure + * + * + * Low level utility function used by device matching. + * + * @matches: array of of device match structures to search in + * @node: the of device structure to match against + * @return matching structure on success, NULL if the match is not found + */ +const struct udevice_id *of_match_node(const struct udevice_id *matches, + const ofnode node); + /** * dev_disable_by_path() - Disable a device given its device tree path * diff --git a/test/dm/core.c b/test/dm/core.c index 1f5ca570dc..aae4d8427d 100644 --- a/test/dm/core.c +++ b/test/dm/core.c @@ -11,6 +11,7 @@ #include <fdtdec.h> #include <log.h> #include <malloc.h> +#include <dm/device.h> #include <dm/device-internal.h> #include <dm/root.h> #include <dm/util.h> @@ -1067,6 +1068,36 @@ static int dm_test_inactive_child(struct unit_test_state *uts) } DM_TEST(dm_test_inactive_child, UT_TESTF_SCAN_PDATA); +static int dm_test_of_match_node(struct unit_test_state *uts) +{ + const ulong test_data_expected = 0x1234; + ofnode root_node = ofnode_path("/"); + const struct udevice_id *match; + unsigned long match_data; + + const struct udevice_id soc_device_ids[] = { + { .compatible = "sandbox", .data = test_data_expected, }, + { /* sentinel */ } + }; + + const struct udevice_id soc_device_nomatch_ids[] = { + { .compatible = "sandbox123", .data = test_data_expected, }, + { /* sentinel */ } + }; + + match = of_match_node(soc_device_ids, root_node); + ut_assert(match); + + match_data = match->data; + ut_asserteq(match_data, test_data_expected); + + match = of_match_node(soc_device_nomatch_ids, root_node); + ut_asserteq_ptr(match, NULL); + + return 0; +} +DM_TEST(dm_test_of_match_node, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); + /* Make sure all bound devices have a sequence number */ static int dm_test_all_have_seq(struct unit_test_state *uts) { -- 2.17.1

1 2

[PATCH 0/4] common: Drop remaining includes in common.h (part A)
by Simon Glass 15 Feb '21

15 Feb '21

2 6

[PATCH v4 0/9] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t
by tkuw584924＠gmail.com 15 Feb '21

15 Feb '21

From: Takahiro Kuwano <Takahiro.Kuwano(a)infineon.com> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. The datasheets can be found in the following links. https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die) https://www.cypress.com/file/499246/download (2Gb/4Gb, dual/quad die) Tested on Xilinx Zynq-7000 FPGA board. Takahiro Kuwano (9): mtd: spi-nor: Add Cypress manufacturer ID mtd: spi-nor-ids: Add Cypress s25hl-t/s25hs-t mtd: spi-nor-core: Add support for Read/Write Any Register mtd: spi-nor-core: Add support for volatile QE bit mtd: spi-nor-core: Add the ->ready() hook mtd: spi-nor-core: Add overlaid sector erase feature mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte mtd: spi-nor-core: Add fixups for Cypress s25hl-t/s25hs-t mtd: spi-nor-tiny: Add fixups for Cypress s25hl-t/s25hs-t drivers/mtd/spi/spi-nor-core.c | 267 +++++++++++++++++++++++++++++++++ drivers/mtd/spi/spi-nor-ids.c | 36 +++++ drivers/mtd/spi/spi-nor-tiny.c | 89 +++++++++++ include/linux/mtd/spi-nor.h | 9 +- 4 files changed, 400 insertions(+), 1 deletion(-) --- Changes since v4: - Added Read/Write Any Register support - Added the ->ready() hook to support multi-die package parts - Added S25HL02GT/S25HL04GT/S25HS02GT/S25HS04GT support Changes since v3: - Split into multiple patches Changes since v2: - Fixed typo in comment for spansion_overlaid_erase() - Fixed expressions for addr and len check in spansion_overlaid_erase() - Added device ID check to make the changes effective for S25 only - Added nor->setup() and fixup hooks based on the following patches https://patchwork.ozlabs.org/project/uboot/patch/20200904153500.3569-7-p.ya… https://patchwork.ozlabs.org/project/uboot/patch/20200904153500.3569-8-p.ya… https://patchwork.ozlabs.org/project/uboot/patch/20200904153500.3569-9-p.ya… -- 2.25.1

3 24

[RFC RESEND 0/2] Add ESRT and test ESRT creation
by Jose Marinho 15 Feb '21

15 Feb '21

The following 2 commits add the ESRT and provide some intial testing. The first commit adds the ESRT as defined in the UEFI 2.8 specification. The ESRT is created during the execution of the efi_init_obj_list(). The ESRT will, during initialization, look for FMP instances already present in the system and populate the corresponding FW image entries. When a new FMP is added, via efi_add_protocol(), the method esrt_add_from_fmp() is called to populate the corresponding ESRT entries. The second commit creates a fake FMP instance with the intent of testing the code populating the ESRT entries. CC: Heinrich Schuchardt <xypron.glpk(a)gmx.de> CC: Sughosh Ganu <sughosh.ganu(a)linaro.org> CC: AKASHI Takahiro <takahiro.akashi(a)linaro.org> CC: Andre Przywara <andre.przywara(a)arm.com> CC: Alexander Graf <agraf(a)csgraf.de> CC: nd(a)arm.com Jose Marinho (2): efi: Add ESRT to the EFI system table efi: Add fake FMP instance to test ESRT creation include/efi_api.h | 21 +++ include/efi_loader.h | 22 +++ lib/efi_loader/Makefile | 2 + lib/efi_loader/efi_boottime.c | 12 ++ lib/efi_loader/efi_esrt.c | 294 ++++++++++++++++++++++++++++++++++ lib/efi_loader/efi_fake_fmp.c | 172 ++++++++++++++++++++ lib/efi_loader/efi_setup.c | 4 + 7 files changed, 527 insertions(+) create mode 100644 lib/efi_loader/efi_esrt.c create mode 100644 lib/efi_loader/efi_fake_fmp.c -- 2.17.1

3 7

[PATCH 00/17] Various minor clean-ups and improvements
by Simon Glass 14 Feb '21

14 Feb '21

This series includes a collection of things noticed while bringing up verified boot on Coral. It includes support for relocating the bloblist. Simon Glass (17): doc: Correct documentation for uclass_root spl: Add functions for next and previous phase bloblist: Support relocating to a larger space bloblist: Add missing tag names x86: tsc_timer: Correct overflow in __udelay() video: Allow syncing the entire framebuffer to the copy net: Use CONFIG_IS_ENABLED() in eth_dev_get_mac_address() fdtdec: Update the missing-devicetree message fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup() display_options: Use USE_TINY_PRINTF for SPL check uuid: Add a comment for UUID_STR_LEN mmc: pci_mmc: Only generate ACPI code for the SD card x86: coral: Add a devicetree node for eMMC mmc: pci_mmc: Set the removable flag crc32: Exclude crc32 from TPL binman: Move selection of the binman node into a function binman: Allow reading entries from a subnode arch/x86/dts/chromebook_coral.dts | 6 +++ common/Kconfig | 10 +++++ common/bloblist.c | 17 +++++++++ common/board_f.c | 10 +++-- common/spl/spl.c | 2 +- drivers/mmc/pci_mmc.c | 19 +++++++++- drivers/timer/tsc_timer.c | 2 +- drivers/video/video-uclass.c | 10 +++++ include/asm-generic/global_data.h | 4 +- include/binman.h | 14 +++++++ include/bloblist.h | 10 +++++ include/spl.h | 53 +++++++++++++++++++++++++++ include/uuid.h | 1 + include/video.h | 14 +++++++ lib/Makefile | 2 + lib/binman.c | 61 ++++++++++++++++++++++++++----- lib/display_options.c | 9 ++--- lib/fdtdec.c | 5 ++- net/eth-uclass.c | 2 +- test/bloblist.c | 36 ++++++++++++++++++ 20 files changed, 260 insertions(+), 27 deletions(-) -- 2.30.0.284.gd98b1dd5eaa7-goog

6 44

Boot problems imx8mp_evk
by Peter Bergin 12 Feb '21

12 Feb '21

Hi, I'm following the README (https://gitlab.denx.de/u-boot/u-boot/-/tree/master/board/freescale/imx8mp_e…) to bring up u-boot on a imx8mp EVK board. My boot ends up in this on the console: U-Boot SPL 2020.10-rc5-00049-gd44d46e9fa (Sep 30 2020 - 11:46:20 +0200) Normal Boot WDT: Started with servicing (60s timeout) Trying to boot from BOOTROM image offset 0x8000, pagesize 0x200, ivt offset 0x0 Can't support legacy image SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### Any ideas what is going wrong? How to debug further? Thanks, /Peter

3 5

[PATCH v1] usb: kbd: destroy device after console is stopped
by Andy Shevchenko 11 Feb '21

11 Feb '21

In case of IOMUX enabled it assumes that console devices in the list are available to get them stopped properly via ->stop() callback. However, the USB keyboard driver violates this assumption and tries to play tricks so the device get destroyed while being listed as an active console. Swap the order of device deregistration and IOMUX update to avoid the use-after-free. Fixes: 3cbcb2892809 ("usb: Fix usb_kbd_deregister when console-muxing is used") Fixes: 8a8348703081 ("dm: usb: Add a remove() method for USB keyboards") Reported-by: Nicolas Saenz Julienne <nsaenzjulienne(a)suse.de> Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- v2: Nicolas, can you test this one instead of yours? common/usb_kbd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index b316807844b1..e09d9f7794c8 100644 --- a/common/usb_kbd.c +++ b/common/usb_kbd.c @@ -617,12 +617,12 @@ int usb_kbd_deregister(int force) if (dev) { usb_kbd_dev = (struct usb_device *)dev->priv; data = usb_kbd_dev->privptr; - if (stdio_deregister_dev(dev, force) != 0) - return 1; #if CONFIG_IS_ENABLED(CONSOLE_MUX) if (iomux_doenv(stdin, env_get("stdin")) != 0) return 1; #endif + if (stdio_deregister_dev(dev, force) != 0) + return 1; #ifdef CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE destroy_int_queue(usb_kbd_dev, data->intq); #endif @@ -660,16 +660,16 @@ static int usb_kbd_remove(struct udevice *dev) goto err; } data = udev->privptr; - if (stdio_deregister_dev(sdev, true)) { - ret = -EPERM; - goto err; - } #if CONFIG_IS_ENABLED(CONSOLE_MUX) if (iomux_doenv(stdin, env_get("stdin"))) { ret = -ENOLINK; goto err; } #endif + if (stdio_deregister_dev(sdev, true)) { + ret = -EPERM; + goto err; + } #ifdef CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE destroy_int_queue(udev, data->intq); #endif -- 2.29.2

4 14