June 2018 - U-Boot

[U-Boot] [PATCH] Makefile: drop mention of *.cfgtmp
by Baruch Siach 20 Jun '18

20 Jun '18

Since commit f916757300 (imx: Create distinct pre-processed mkimage config files), *.cfgtmp files are no longer generated. There is no need to remove them on the 'clean' target anymore. Remove also the .gitignore glob. Cc: Trent Piepho <tpiepho(a)impinj.com> Signed-off-by: Baruch Siach <baruch(a)tkos.co.il> --- .gitignore | 1 - Makefile | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 9110eda6468f..f97838a756a6 100644 --- a/.gitignore +++ b/.gitignore @@ -20,7 +20,6 @@ *.swp *.bin *.patch -*.cfgtmp *.tab.[ch] # host programs on Cygwin diff --git a/Makefile b/Makefile index 6a190e7a894b..61ef84576afa 100644 --- a/Makefile +++ b/Makefile @@ -1613,13 +1613,12 @@ PHONY += $(clean-dirs) clean archclean $(clean-dirs): $(Q)$(MAKE) $(clean)=$(patsubst _clean_%,%,$@) -# TODO: Do not use *.cfgtmp clean: $(clean-dirs) $(call cmd,rmdirs) $(call cmd,rmfiles) @find $(if $(KBUILD_EXTMOD), $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \ \( -name '*.[oas]' -o -name '*.ko' -o -name '.*.cmd' \ - -o -name '*.ko.*' -o -name '*.su' -o -name '*.cfgtmp' \ + -o -name '*.ko.*' -o -name '*.su' \ -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \ -o -name '*.lex.c' -o -name '*.tab.[ch]' \ -o -name '*.symtypes' -o -name 'modules.order' \ -- 2.17.1

2 2

[U-Boot] [PATCH v6 00/13] efi: Enable basic sandbox support for EFI loader
by Simon Glass 20 Jun '18

20 Jun '18

A limitation of the EFI loader at present is that it does not build with sandbox. This makes it hard to write tests, since sandbox is used for most testing in U-Boot. This series enables the EFI loader feature. It allows sandbox to build and run a trivial function which calls the EFI API to output a message. This series is at u-boot-dm/efi-working Changes in v6: - Warn about building sandbox EFI support on something other than __x86_64__ Changes in v5: - Add new patch to disallow CMD_BOOTEFI_SELFTEST on sandbox - Drop call to efi_init_obj_list() which is now done in do_bootefi() - Drop period after "elf" in comment - Introduce load_options_path to specifyc U-Boot env var for load_options_path - Rebase to master Changes in v4: - Move the fix to query_console_serial() - Rebase to master - Update SPDX tags Changes in v3: - Add new patch to init the 'rows' and 'cols' variables - Add new patch to rename bootefi_test_finish() to bootefi_run_finish() - Add new patch to split out test init/uninit into functions - Add patch to create a function to set up for running EFI code - Drop incorrect map_sysmem() in write_smbios_table() - Init the 'rows' and 'cols' vars to avoid a compiler error (gcc 4.8.4) - Rebase to master Changes in v2: - Rebase to master - Update to use mapmem instead of a cast Simon Glass (13): efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox efi: Init the 'rows' and 'cols' variables efi: sandbox: Adjust memory usage for sandbox sandbox: smbios: Update to support sandbox efi: sandbox: Add distroboot support efi: sandbox: Add relocation constants efi: Add a comment about duplicated ELF constants efi: sandbox: Enable EFI loader builder for sandbox efi: Split out test init/uninit into functions efi: sandbox: Add a simple 'bootefi test' command efi: Create a function to set up for running EFI code efi: Rename bootefi_test_finish() to bootefi_run_finish() Revert "buildman: Extract environment as part of each build" cmd/bootefi.c | 153 ++++++++++++++++++++++---------- include/config_distro_bootcmd.h | 13 +++ include/efi_loader.h | 3 + lib/efi_loader/Kconfig | 12 ++- lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_console.c | 5 +- lib/efi_loader/efi_memory.c | 31 ++++--- lib/efi_loader/efi_runtime.c | 16 ++++ lib/efi_loader/efi_test.c | 16 ++++ lib/efi_selftest/Kconfig | 2 +- lib/smbios.c | 32 +++++-- tools/buildman/builderthread.py | 10 --- tools/buildman/func_test.py | 5 -- 13 files changed, 213 insertions(+), 86 deletions(-) create mode 100644 lib/efi_loader/efi_test.c -- 2.18.0.rc1.244.gcf134e6275-goog

2 40

[U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
by Vasily Khoruzhick 20 Jun '18

20 Jun '18

eMMC seems to require new clocking mode and calibration on A64, otherwise it is pretty unstable on some boards (e.g. Pinebook) with some eMMCs. v2: - improve comment about calibration for eMMC on A64 - simplify ifdef-s around configuring delays v3: - fix fallout due to ifdef simplification in v2 v4: - really fix ifdefs this time v5: - add new option for SoCs without new mode switch in CCM Vasily Khoruzhick (3): sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option sunxi-mmc: use new mode on A64 mmc: sunxi: run calibration on A64 arch/arm/include/asm/arch-sunxi/mmc.h | 6 +++++- arch/arm/mach-sunxi/Kconfig | 2 ++ drivers/mmc/Kconfig | 4 ++++ drivers/mmc/sunxi_mmc.c | 13 +++++++++++++ 4 files changed, 24 insertions(+), 1 deletion(-) -- 2.17.1

3 12

[U-Boot] [PATCH] cmd: gpio: Remove dead code from do_gpio
by Michal Simek 20 Jun '18

20 Jun '18

gpio input/set/clear and toggle commands are already cover that's why there is no any other case which should be handled. Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- Reported by: Coverity (local) Not sure how to report this properly without CID --- cmd/gpio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/gpio.c b/cmd/gpio.c index ecdc453918f4..f59cb5837187 100644 --- a/cmd/gpio.c +++ b/cmd/gpio.c @@ -208,8 +208,6 @@ static int do_gpio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) if (!IS_ERR_VALUE(value)) value = !value; break; - default: - goto show_usage; } gpio_direction_output(gpio, value); } -- 1.9.1

2 2

[U-Boot] Make Menuconfig Error
by Duncan Hare 20 Jun '18

20 Jun '18

Karsten Thanks for your lasts response. My apologies, I forget my yahoo email does not quite understand RFC email standards. Here's when I'm at with this version of u-boot. root@debian:/home/duncan/archive/u-boot# make clean root@debian:/home/duncan/archive/u-boot# make menuconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/mconf.o YACC scripts/kconfig/zconf.tab.c scripts/kconfig/zconf.y:44 parser name defined to default :"parse" "scripts/kconfig/zconf.y", line 97: junk after `%%' in definition section Segmentation fault scripts/Makefile.lib:228: recipe for target 'scripts/kconfig/zconf.tab.c' failed make[1]: *** [scripts/kconfig/zconf.tab.c] Error 139 Makefile:491: recipe for target 'menuconfig' failed make: *** [menuconfig] Error 2 root@debian:/home/duncan/archive/u-boot# Duncan Hare 714 931 7952

1 0

[U-Boot] [ANN] U-Boot v2018.07-rc2 released
by Tom Rini 20 Jun '18

20 Jun '18

Hey all, It's a day after when I had planned to release v2018.07-rc2, but here we are. The group of patches I applied earlier in the day took a bit longer to sort out, and that means I have a few more things I had hoped to apply still left to look at. I still think at this point we should focus on Kconfig migrations, fixes and dropping code that has reached it's "update or delete" by date. Things look on track for -rc3 on the 2nd and then release on July 9th. Thanks all! -- Tom

1 0

[U-Boot] U-Boot TFTP protection
by Stefan Johansson 20 Jun '18

20 Jun '18

Hello, We have been looking at protecting U-Boot from (malicious) TFTP overwrites. We want to do this after our ARMv7 U-Boot has relocated. The memory map looks like this (I hope): --------------------------- Top of DRAM | U-Boot (Protected) | -------------------------- U_Boot_start | Heap (Protected) | -------------------------- Start_Heap = U_Boot_start - Heap_Size | Stack (Protected) | -------------------------- Start_Stack = Start_Heap - Stack_Size | Buffers (Protected) | -------------------------- ??? | Free DRAM (Not Protected) --------------------------- Start of DRAM I seem to get lost in the code trying to find possible buffers, can you please give a hint how I can find the address "???" Best Regards, Stefan

3 2

[U-Boot] [PATCH v2 00/13] x86: efi: Fixes and enhancements to application and payload support
by Bin Meng 20 Jun '18

20 Jun '18

Unfortunately the EFI x86 application and payload support have been broken for quite a while. This series addresses various bug fixes, plus several enhancements like toolchain compatibility (eg: kernel.org i386-linux-gcc), introduction of generic EFI payload which can run on any x86 board, and a EFI framebuffer driver for the payload. This series is available at u-boot-x86/efi-working for testing. Changes in v2: - update the x86 doc to reference also README.uefi - new patch to "change __kernel_size_t conditionals to use compiler provided defines" - update README.u-boot_on_efi to reflect directory changes - update README.u-boot_on_efi to mention generic EFI payload support - update QEMU MAINTAINERS file to remove defconfig files - update README.u-boot_on_efi to use efi-x86_app - drop patches that were already applied to u-boot-x86 Alexander Graf (1): efi.h: Do not use config options Bin Meng (12): x86: doc: Fix reference to EFI doc in U-Boot x86: Change __kernel_size_t conditionals to use compiler provided defines x86: efi: Refactor the directory of EFI app and payload support x86: efi: payload: Add arch_cpu_init() x86: Add generic EFI payload support x86: Drop QEMU-specific EFI payload support x86: baytrail: Drop EFI-specific test logics efi: stub: Pass EFI GOP information to U-Boot payload dm: video: Add an EFI framebuffer driver x86: efi: payload: Add EFI framebuffer driver support x86: Rename efi-x86 target to efi-x86_app x86: efi: app: Display correct CPU info during boot arch/x86/Kconfig | 3 +- arch/x86/cpu/Makefile | 2 +- arch/x86/cpu/baytrail/Kconfig | 6 +- arch/x86/cpu/baytrail/valleyview.c | 3 - arch/x86/{lib => cpu}/efi/Kconfig | 0 arch/x86/cpu/efi/Makefile | 9 +- arch/x86/cpu/efi/{efi.c => app.c} | 2 +- arch/x86/{lib => cpu}/efi/car.S | 0 arch/x86/{lib/efi/efi.c => cpu/efi/payload.c} | 11 +- arch/x86/cpu/intel_common/Makefile | 2 +- arch/x86/cpu/qemu/Makefile | 2 - arch/x86/cpu/qemu/qemu.c | 4 - arch/x86/dts/Makefile | 3 +- arch/x86/dts/{efi.dts => efi-x86_app.dts} | 4 +- arch/x86/dts/efi-x86_payload.dts | 40 ++++++ arch/x86/include/asm/posix_types.h | 2 +- arch/x86/lib/Makefile | 1 - arch/x86/lib/efi/Makefile | 7 - board/advantech/som-db5800-som-6867/Kconfig | 5 +- board/congatec/conga-qeval20-qa3-e3845/Kconfig | 5 +- board/dfi/dfi-bt700/Kconfig | 5 +- board/efi/Kconfig | 15 ++- board/efi/{efi-x86 => efi-x86_app}/Kconfig | 6 +- board/efi/{efi-x86 => efi-x86_app}/MAINTAINERS | 0 board/efi/{efi-x86 => efi-x86_app}/Makefile | 2 +- board/efi/{efi-x86/efi.c => efi-x86_app/app.c} | 0 board/efi/efi-x86_payload/Kconfig | 39 ++++++ board/efi/efi-x86_payload/MAINTAINERS | 7 + board/efi/efi-x86_payload/Makefile | 5 + board/efi/efi-x86_payload/start.S | 8 ++ board/emulation/qemu-x86/Kconfig | 6 +- board/emulation/qemu-x86/MAINTAINERS | 2 - board/intel/minnowmax/Kconfig | 5 +- .../{efi-x86_defconfig => efi-x86_app_defconfig} | 4 +- ...oad32_defconfig => efi-x86_payload32_defconfig} | 24 +--- ...oad64_defconfig => efi-x86_payload64_defconfig} | 24 +--- doc/README.u-boot_on_efi | 33 ++--- doc/README.x86 | 14 +- drivers/video/Kconfig | 9 ++ drivers/video/Makefile | 1 + drivers/video/efi.c | 146 +++++++++++++++++++++ include/configs/{efi-x86.h => efi-x86_app.h} | 0 include/configs/efi-x86_payload.h | 32 +++++ include/efi.h | 52 ++++++-- lib/efi/Makefile | 4 +- lib/efi/efi_stub.c | 15 +++ 46 files changed, 433 insertions(+), 136 deletions(-) rename arch/x86/{lib => cpu}/efi/Kconfig (100%) rename arch/x86/cpu/efi/{efi.c => app.c} (92%) rename arch/x86/{lib => cpu}/efi/car.S (100%) rename arch/x86/{lib/efi/efi.c => cpu/efi/payload.c} (97%) rename arch/x86/dts/{efi.dts => efi-x86_app.dts} (82%) create mode 100644 arch/x86/dts/efi-x86_payload.dts delete mode 100644 arch/x86/lib/efi/Makefile rename board/efi/{efi-x86 => efi-x86_app}/Kconfig (64%) rename board/efi/{efi-x86 => efi-x86_app}/MAINTAINERS (100%) rename board/efi/{efi-x86 => efi-x86_app}/Makefile (82%) rename board/efi/{efi-x86/efi.c => efi-x86_app/app.c} (100%) create mode 100644 board/efi/efi-x86_payload/Kconfig create mode 100644 board/efi/efi-x86_payload/MAINTAINERS create mode 100644 board/efi/efi-x86_payload/Makefile create mode 100644 board/efi/efi-x86_payload/start.S rename configs/{efi-x86_defconfig => efi-x86_app_defconfig} (92%) rename configs/{qemu-x86_efi_payload32_defconfig => efi-x86_payload32_defconfig} (61%) rename configs/{qemu-x86_efi_payload64_defconfig => efi-x86_payload64_defconfig} (62%) create mode 100644 drivers/video/efi.c rename include/configs/{efi-x86.h => efi-x86_app.h} (100%) create mode 100644 include/configs/efi-x86_payload.h -- 2.7.4

4 35

[U-Boot] [PATCH] serial: zynq: Use platdata for storing static data instead of priv
by Michal Simek 20 Jun '18

20 Jun '18

Explanation from Simon Glass "Private data is created when the device is probed and freed when the device is removed. Platform data is created when the device is bound, and survives probe/remove cycles. Strictly speaking, platform data should be used to hold the decoded device tree properties. Private data should be used for run-time things the device needs to keep track of." Based on description the driver needs to be switch to use platdata instead of priv. Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- Apply on the top of latest zynq serial changes (soon in mainline). --- drivers/serial/serial_zynq.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c index a191772ff040..f689015b4ae7 100644 --- a/drivers/serial/serial_zynq.c +++ b/drivers/serial/serial_zynq.c @@ -39,7 +39,7 @@ struct uart_zynq { u32 baud_rate_divider; /* 0x34 - Baud Rate Divider [7:0] */ }; -struct zynq_uart_priv { +struct zynq_uart_platdata { struct uart_zynq *regs; }; @@ -105,7 +105,7 @@ static int _uart_zynq_serial_putc(struct uart_zynq *regs, const char c) static int zynq_serial_setbrg(struct udevice *dev, int baudrate) { - struct zynq_uart_priv *priv = dev_get_priv(dev); + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); unsigned long clock; int ret; @@ -130,28 +130,28 @@ static int zynq_serial_setbrg(struct udevice *dev, int baudrate) return ret; } - _uart_zynq_serial_setbrg(priv->regs, clock, baudrate); + _uart_zynq_serial_setbrg(platdata->regs, clock, baudrate); return 0; } static int zynq_serial_probe(struct udevice *dev) { - struct zynq_uart_priv *priv = dev_get_priv(dev); + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); /* No need to reinitialize the UART after relocation */ if (gd->flags & GD_FLG_RELOC) return 0; - _uart_zynq_serial_init(priv->regs); + _uart_zynq_serial_init(platdata->regs); return 0; } static int zynq_serial_getc(struct udevice *dev) { - struct zynq_uart_priv *priv = dev_get_priv(dev); - struct uart_zynq *regs = priv->regs; + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); + struct uart_zynq *regs = platdata->regs; if (readl(&regs->channel_sts) & ZYNQ_UART_SR_RXEMPTY) return -EAGAIN; @@ -161,15 +161,15 @@ static int zynq_serial_getc(struct udevice *dev) static int zynq_serial_putc(struct udevice *dev, const char ch) { - struct zynq_uart_priv *priv = dev_get_priv(dev); + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); - return _uart_zynq_serial_putc(priv->regs, ch); + return _uart_zynq_serial_putc(platdata->regs, ch); } static int zynq_serial_pending(struct udevice *dev, bool input) { - struct zynq_uart_priv *priv = dev_get_priv(dev); - struct uart_zynq *regs = priv->regs; + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); + struct uart_zynq *regs = platdata->regs; if (input) return !(readl(&regs->channel_sts) & ZYNQ_UART_SR_RXEMPTY); @@ -179,11 +179,11 @@ static int zynq_serial_pending(struct udevice *dev, bool input) static int zynq_serial_ofdata_to_platdata(struct udevice *dev) { - struct zynq_uart_priv *priv = dev_get_priv(dev); + struct zynq_uart_platdata *platdata = dev_get_platdata(dev); - priv->regs = (struct uart_zynq *)dev_read_addr(dev); - if (IS_ERR(priv->regs)) - return PTR_ERR(priv->regs); + platdata->regs = (struct uart_zynq *)dev_read_addr(dev); + if (IS_ERR(platdata->regs)) + return PTR_ERR(platdata->regs); return 0; } @@ -207,7 +207,7 @@ U_BOOT_DRIVER(serial_zynq) = { .id = UCLASS_SERIAL, .of_match = zynq_serial_ids, .ofdata_to_platdata = zynq_serial_ofdata_to_platdata, - .priv_auto_alloc_size = sizeof(struct zynq_uart_priv), + .platdata_auto_alloc_size = sizeof(struct zynq_uart_platdata), .probe = zynq_serial_probe, .ops = &zynq_serial_ops, .flags = DM_FLAG_PRE_RELOC, -- 1.9.1

2 1

[U-Boot] [PATCH] test_avb: Add pymark.buildconfigspec information for the AVB tests
by Tom Rini 19 Jun '18

19 Jun '18

Signed-off-by: Tom Rini <trini(a)konsulko.com> --- test/py/tests/test_avb.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_avb.py index 770bdde4ad0c..7996e4845db3 100644 --- a/test/py/tests/test_avb.py +++ b/test/py/tests/test_avb.py @@ -23,6 +23,7 @@ mmc_dev = 1 temp_addr = 0x90000000 temp_addr2 = 0x90002000 +(a)pytest.mark.buildconfigspec('cmd_avb') def test_avb_verify(u_boot_console): """Run AVB 2.0 boot verification chain with avb subset of commands """ @@ -35,6 +36,7 @@ def test_avb_verify(u_boot_console): assert response.find(success_str) +(a)pytest.mark.buildconfigspec('cmd_avb') def test_avb_mmc_uuid(u_boot_console): """Check if 'avb get_uuid' works, compare results with 'part list mmc 1' output @@ -67,6 +69,7 @@ def test_avb_mmc_uuid(u_boot_console): assert guid == avb_guid_resp.split("UUID: ")[1] +(a)pytest.mark.buildconfigspec('cmd_avb') def test_avb_read_rb(u_boot_console): """Test reading rollback indexes """ @@ -77,6 +80,7 @@ def test_avb_read_rb(u_boot_console): response = u_boot_console.run_command('avb read_rb 1') +(a)pytest.mark.buildconfigspec('cmd_avb') def test_avb_is_unlocked(u_boot_console): """Test if device is in the unlocked state """ @@ -87,6 +91,7 @@ def test_avb_is_unlocked(u_boot_console): response = u_boot_console.run_command('avb is_unlocked') +(a)pytest.mark.buildconfigspec('cmd_avb') def test_avb_mmc_read(u_boot_console): """Test mmc read operation """ -- 2.7.4

1 1