November 2018 - U-Boot

[U-Boot] [PATCH 0/3] mtd: Fix partition handling code
by Boris Brezillon 10 Nov '18

10 Nov '18

Hello, Stefan recently reported a bug when using ubi part on a spi-nand device and proposed this fix[1]. While his solution while working I proposed a different approach to kill the CMD_UBI dependency on CMD_MTDPARTS. This is what patches 1 and 2 are doing. Patch 3 is just removing the duplicate Kconfig MTD_PARTITIONS entry. Jagan, can you queue those patches to one of your branch and send a fixes PR, unless Tom prefers to take them directly. Regards, Boris Boris Brezillon (3): mtd: Use default mtdparts/mtids when not defined in the environment cmd: ubi: Remove useless call to mtdparts_init() mtd: Drop duplicate MTD_PARTITIONS Kconfig option cmd/Kconfig | 1 - cmd/ubi.c | 5 ---- drivers/mtd/Kconfig | 6 ---- drivers/mtd/mtd_uboot.c | 62 +++++++++++++++++++++++++++++++++++++++-- 4 files changed, 60 insertions(+), 14 deletions(-) -- 2.17.1

3 9

[U-Boot] am33xx board with no external RTC crystal issue
by Belisko Marek 09 Nov '18

09 Nov '18

Hi, I'm working on custome am33xx based HW which have no external 32KHz crystal. Anyway I want to use bootcount feature. I was trying to use internal PRCM CLK_32KHZ clock as source for RTCSS but still when want to read RTC registers I get data abort. I adapted this method : static void rtc32k_enable(void) { struct davinci_rtc *rtc = (struct davinci_rtc *)RTC_BASE; /* * Unlock the RTC's registers. For more details please see the * RTC_SS section of the TRM. In order to unlock we need to @@ -287,9 +288,8 @@ static void rtc32k_enable(void) writel(RTC_KICK1R_WE, &rtc->kick1r); /* Enable the RTC 32K OSC by setting bits 3 and 6. */ - writel((1 << 3) | (1 << 6), &rtc->osc); + writel((1 << 6), &rtc->osc); } to not use external crystal 32KHz clock but internal. Anyway when doing that board just hangs and thats it. Any ideas or suggestions? It is even possible to have something like that? I just seen that include/configs/siemens-am33x-common.h (using also am335x cpu without external 32KHz crystal) storing bootcount to env. Thanks a lot for any pointers. BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com

2 3

[U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL
by Lars Povlsen 09 Nov '18

09 Nov '18

common/common_fit.c is including <spl.h>, but not actually using it. The inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE and not SPL. Signed-off-by: Lars Povlsen <lars.povlsen(a)microsemi.com> --- common/common_fit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/common_fit.c b/common/common_fit.c index 577b352..a35c7e9 100644 --- a/common/common_fit.c +++ b/common/common_fit.c @@ -8,7 +8,6 @@ #include <errno.h> #include <image.h> #include <linux/libfdt.h> -#include <spl.h> ulong fdt_getprop_u32(const void *fdt, int node, const char *prop) { -- 2.7.4

3 2

[U-Boot] [PATCH v1] dm: Fix typo - missed semicolon
by Andy Shevchenko 09 Nov '18

09 Nov '18

The commit 484fdf5ba058 ("dm: Add support for all targets which requires MANUAL_RELOC") introduces subtle typo, i.e. missed semicolon. Fixes: 484fdf5ba058 ("dm: Add support for all targets which requires MANUAL_RELOC") Cc: Michal Simek <michal.simek(a)xilinx.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- drivers/serial/serial-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index e50f0aa851..665cca85cb 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -423,7 +423,7 @@ static int serial_post_probe(struct udevice *dev) ops->setconfig += gd->reloc_off; #if CONFIG_POST & CONFIG_SYS_POST_UART if (ops->loop) - ops->loop += gd->reloc_off + ops->loop += gd->reloc_off; #endif #endif /* Set the baud rate */ -- 2.19.1

3 2

[U-Boot] [PATCH] spl: fix debug prints for tiny printf
by Simon Goldschmidt 09 Nov '18

09 Nov '18

Tiny printf does not support %.*s and %lX. Since tiny printf should be very common in SPL, replace these by %32s (for printing image name) and %lx. Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt(a)gmail.com> --- common/spl/spl.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 292e659c9a..12f9359c0a 100644 --- a/common/spl/spl.c +++ b/common/spl/spl.c @@ -185,9 +185,8 @@ static int spl_load_fit_image(struct spl_image_info *spl_image, spl_image->os = IH_OS_U_BOOT; spl_image->name = "U-Boot"; - debug("spl: payload image: %.*s load addr: 0x%lx size: %d\n", - (int)sizeof(spl_image->name), spl_image->name, - spl_image->load_addr, spl_image->size); + debug("spl: payload image: %32s load addr: 0x%lx size: %d\n", + spl_image->name, spl_image->load_addr, spl_image->size); #ifdef CONFIG_SPL_FIT_SIGNATURE images.verify = 1; @@ -256,9 +255,8 @@ int spl_parse_image_header(struct spl_image_info *spl_image, } spl_image->os = image_get_os(header); spl_image->name = image_get_name(header); - debug("spl: payload image: %.*s load addr: 0x%lx size: %d\n", - IH_NMLEN, spl_image->name, - spl_image->load_addr, spl_image->size); + debug("spl: payload image: %32s load addr: 0x%lx size: %d\n", + spl_image->name, spl_image->load_addr, spl_image->size); #else /* LEGACY image not supported */ debug("Legacy boot image support not enabled, proceeding to other boot methods\n"); @@ -314,7 +312,7 @@ __weak void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image) image_entry_noargs_t image_entry = (image_entry_noargs_t)spl_image->entry_point; - debug("image entry point: 0x%lX\n", spl_image->entry_point); + debug("image entry point: 0x%lx\n", spl_image->entry_point); image_entry(); } @@ -554,7 +552,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2) debug("Unsupported OS image.. Jumping nevertheless..\n"); } #if CONFIG_VAL(SYS_MALLOC_F_LEN) && !defined(CONFIG_SYS_SPL_MALLOC_SIZE) - debug("SPL malloc() used %#lx bytes (%ld KB)\n", gd->malloc_ptr, + debug("SPL malloc() used 0x%lx bytes (%ld KB)\n", gd->malloc_ptr, gd->malloc_ptr / 1024); #endif #ifdef CONFIG_BOOTSTAGE_STASH -- 2.17.1

3 2

[U-Boot] [PATCH] MAINTAINERS: Update stm32mp entry
by Patrick Delaunay 09 Nov '18

09 Nov '18

Add mailing list for stm32mp architecture and board. Signed-off-by: Patrick Delaunay <patrick.delaunay(a)st.com> --- MAINTAINERS | 1 + board/st/stm32mp1/MAINTAINERS | 1 + 2 files changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b39b6fc..abdb6dc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,6 +233,7 @@ ARM STM STM32MP M: Patrick Delaunay <patrick.delaunay(a)st.com> M: Christophe Kerello <christophe.kerello(a)st.com> M: Patrice Chotard <patrice.chotard(a)st.com> +L: uboot-stm32(a)st-md-mailman.stormreply.com (moderated for non-subscribers) S: Maintained F: arch/arm/mach-stm32mp F: drivers/clk/clk_stm32mp1.c diff --git a/board/st/stm32mp1/MAINTAINERS b/board/st/stm32mp1/MAINTAINERS index 65266bc..48d8fd2 100644 --- a/board/st/stm32mp1/MAINTAINERS +++ b/board/st/stm32mp1/MAINTAINERS @@ -1,5 +1,6 @@ STM32MP1 BOARD M: Patrick Delaunay <patrick.delaunay(a)st.com> +L: uboot-stm32(a)st-md-mailman.stormreply.com (moderated for non-subscribers) S: Maintained F: board/st/stm32mp1 F: include/configs/stm32mp1.h -- 2.7.4

2 1

[U-Boot] [PATCH] fit: Add missing CR in debug output in fit_find_config_node()
by Stefan Roese 09 Nov '18

09 Nov '18

Testing has shown that a line-break is missing in one debug line in fit_find_config_node(). Signed-off-by: Stefan Roese <sr(a)denx.de> --- common/common_fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/common_fit.c b/common/common_fit.c index c92d675a0b..3d90eef516 100644 --- a/common/common_fit.c +++ b/common/common_fit.c @@ -76,7 +76,7 @@ int fit_find_config_node(const void *fdt) } if (dflt_conf_node != -ENOENT) { - debug("Selecting default config '%s'", dflt_conf_desc); + debug("Selecting default config '%s'\n", dflt_conf_desc); return dflt_conf_node; } -- 2.19.1

2 1

[U-Boot] Pull request: u-boot-ubi/master
by Heiko Schocher 09 Nov '18

09 Nov '18

Hello Tom, please pull from u-boot-ubi-git master as it is a Bugfix, I think it should go into current release. The following changes since commit dd610e616cceda16a81dfa6f9a134877f783548c: Merge tag 'u-boot-imx-20181106' of git://git.denx.de/u-boot-imx (2018-11-06 11:12:00 -0500) are available in the Git repository at: git://git.denx.de/u-boot-ubi.git master for you to fetch changes up to e4aa10ba5770fc391bf8a4b00c131353901704e7: fs: ubifs: Fix UBIFS decompression on 64 bit (2018-11-07 08:49:27 +0100) ---------------------------------------------------------------- Paul Davey (1): fs: ubifs: Fix UBIFS decompression on 64 bit fs/ubifs/ubifs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) travis builds fine: https://travis-ci.org/hsdenx/u-boot-ubi/builds/451758575 bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs(a)denx.de

2 1

[U-Boot] [PATCH v2] sandbox: Use memcpy() to move overlapping regions
by Simon Glass 09 Nov '18

09 Nov '18

The use of strcpy() to remove characters at the start of a string is safe in U-Boot, since we know the implementation. But in os.c we are using the C library's strcpy() function, where this behaviour is not permitted. Update the code to use memcpy() instead. Reported-by: Coverity (CID: 173279) Signed-off-by: Simon Glass <sjg(a)chromium.org> --- Changes in v2: - Also remove the leading / from the "/spl" path - Correct the string calculation arch/sandbox/cpu/os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c index 07e46471fe5..04669bfc177 100644 --- a/arch/sandbox/cpu/os.c +++ b/arch/sandbox/cpu/os.c @@ -641,9 +641,10 @@ int os_find_u_boot(char *fname, int maxlen) } /* Look for 'u-boot' in the parent directory of spl/ */ - p = strstr(fname, "/spl/"); + p = strstr(fname, "spl/"); if (p) { - strcpy(p, p + 4); + /* Remove the "spl" characters */ + memmove(p, p + 4, strlen(p + 4) + 1); fd = os_open(fname, O_RDONLY); if (fd >= 0) { close(fd); -- 2.19.1.930.g4563a0d9d0-goog

2 1

[U-Boot] [PATCH v2 1/4] board: toradex: colibri_vf: efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION
by Marcel Ziswiler 09 Nov '18

09 Nov '18

From: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> Unset CONFIG_EFI_UNICODE_CAPITALIZATION on boards with tough size restrictions. This is analogous to commit a90bf07afc43 ("efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION"). Signed-off-by: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> Reviewed-by: Alexander Graf <agraf(a)suse.de> --- Changes in v2: None configs/colibri_vf_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig index 5854910f7b..38f450c8ed 100644 --- a/configs/colibri_vf_defconfig +++ b/configs/colibri_vf_defconfig @@ -72,3 +72,4 @@ CONFIG_VIDEO_FSL_DCU_FB=y CONFIG_VIDEO=y CONFIG_SYS_CONSOLE_FG_COL=0x00 CONFIG_OF_LIBFDT_OVERLAY=y +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set -- 2.14.5

1 3