November 2018 - U-Boot

[U-Boot] [PATCH 0/2] Read default speed and mode values from DT
by Patrick Delaunay 12 Nov '18

12 Nov '18

This serie generalize the commit 96907c0fe50a ("dm: spi: Read default speed and mode values from DT") In case of DT boot, don't read default speed and mode for SPI from CONFIG_*, instead read from DT node. This will make sure that boards with multiple SPI/QSPI controllers can be probed at different bus frequencies and SPI modes. Today it is only done in the command sf; this patch do the same for the other user of the spi_flash_probe(): spl and splash to avoid probe issue. Patrick Delaunay (2): spl_spi: Read default speed and mode values from DT splash: sf: Read default speed and mode values from DT common/spl/spl_spi.c | 9 ++++++++- common/splash_source.c | 8 ++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) -- 2.7.4

3 4

[U-Boot] [PATCH v1 1/2] board: toradex: colibri_vf: efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION
by Marcel Ziswiler 12 Nov '18

12 Nov '18

From: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> Unset CONFIG_EFI_UNICODE_CAPITALIZATION on boards with tough size restrictions. This is analogous to commit a90bf07afc43 ("efi_loader: unset CONFIG_EFI_UNICODE_CAPITALIZATION"). Signed-off-by: Marcel Ziswiler <marcel.ziswiler(a)toradex.com> --- configs/colibri_vf_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig index 5854910f7b..38f450c8ed 100644 --- a/configs/colibri_vf_defconfig +++ b/configs/colibri_vf_defconfig @@ -72,3 +72,4 @@ CONFIG_VIDEO_FSL_DCU_FB=y CONFIG_VIDEO=y CONFIG_SYS_CONSOLE_FG_COL=0x00 CONFIG_OF_LIBFDT_OVERLAY=y +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set -- 2.14.5

6 11

[U-Boot] [PATCH 1/2] dfu: nand: Add missing dependency on CMD_MTDPARTS
by Boris Brezillon 12 Nov '18

12 Nov '18

dfu_fill_entity_nand() uses find_dev_and_part() and mtdparts_init() which are provided by cmd/mtdparts.c. Add the dependency to avoid build failures when CMD_MTDPARTS is not selected. Reported-by: Jagan Teki <jagan(a)amarulasolutions.com> Fixes: 6828e602b722d ("dfu: Migrate to Kconfig") Signed-off-by: Boris Brezillon <boris.brezillon(a)bootlin.com> --- drivers/dfu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig index 51ab484c2a49..4692736c9d24 100644 --- a/drivers/dfu/Kconfig +++ b/drivers/dfu/Kconfig @@ -30,6 +30,7 @@ config DFU_MMC config DFU_NAND bool "NAND back end for DFU" + depends on CMD_MTDPARTS help This option enables using DFU to read and write to NAND based storage. -- 2.17.1

2 5

[U-Boot] 'load mmc' speed varies significantly
by Jan Kiszka 12 Nov '18

12 Nov '18

Hi all, I'm getting significant speed differences while loading kernel and initrd from an ext4 rootfs on an SD card via the 'load' command: ## Executing script at 80000000 54764 bytes read in 296 ms (180.7 KiB/s) 12359688 bytes read in 42982 ms (280.3 KiB/s) 4333462 bytes read in 441 ms (9.4 MiB/s) The script just does setenv bootargs root=/dev/mmcblk1p2 rw rootwait load ${devtype} ${devnum}:2 ${fdt_addr_r} /usr/lib/linux-image-4.14.67+/${fdtfile} load ${devtype} ${devnum}:${distro_bootpart} ${kernel_addr_r} /boot/vmlinuz-4.14.67+ load ${devtype} ${devnum}:${distro_bootpart} ${ramdisk_addr_r} /boot/initrd.img-4.14.67+ booti ${kernel_addr_r} ${ramdisk_addr_r}:${filesize} ${fdt_addr_r} So, the kernel takes an eternity while the initrd on the very same filesystem loads at full speed. Moreover, when I rewrite the kernel like this # cat /boot/vmlinuz-4.14.67+ > /boot/vmlinuz-4.14.67+.rewrite # mv /boot/vmlinuz-4.14.67+.rewrite /boot/vmlinuz-4.14.67+ the transfer speed is fine for it as well. I'm currently seeing this on an AM65xx (downstream U-boot, 2018.01- based), but I had the very same effect on other boards (e.g. Orange Pi Zero) with upstream U-boot as well in the past. We generate the filesystem and the SD card image via wic - possibly with some unfortunate parameters? Anyone any idea? Thanks, Jan

4 5

[U-Boot] [PATCH 1/1] efi_loader: do not use unsupported printf code
by Heinrich Schuchardt 12 Nov '18

12 Nov '18

Using %zu for efi_intn_t (ssize_t) creates a build warning. Anyway %zu is not supported by efi_st_error(). So let's convert to int. Our implementation of StriColl() only returns -1, 0, or 1. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_selftest/efi_selftest_unicode_collation.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_unicode_collation.c b/lib/efi_selftest/efi_selftest_unicode_collation.c index 9765bd3e44b..75294307d9f 100644 --- a/lib/efi_selftest/efi_selftest_unicode_collation.c +++ b/lib/efi_selftest/efi_selftest_unicode_collation.c @@ -52,7 +52,7 @@ static int test_stri_coll(void) c1, c2); if (ret) { efi_st_error( - "stri_coll(\"%ps\", \"%ps\") = %zu\n", c1, c2, ret); + "stri_coll(\"%ps\", \"%ps\") = %d\n", c1, c2, (int)ret); return EFI_ST_FAILURE; } @@ -60,7 +60,7 @@ static int test_stri_coll(void) c1, c3); if (ret >= 0) { efi_st_error( - "stri_coll(\"%ps\", \"%ps\") = %zu\n", c1, c3, ret); + "stri_coll(\"%ps\", \"%ps\") = %d\n", c1, c3, (int)ret); return EFI_ST_FAILURE; } @@ -68,7 +68,7 @@ static int test_stri_coll(void) c3, c1); if (ret <= 0) { efi_st_error( - "stri_coll(\"%ps\", \"%ps\") = %zu\n", c3, c1, ret); + "stri_coll(\"%ps\", \"%ps\") = %d\n", c3, c1, (int)ret); return EFI_ST_FAILURE; } -- 2.19.1

1 0

[U-Boot] [PATCH v3 0/8] dm: Various fixes in dm core/cpu/timer
by Bin Meng 11 Nov '18

11 Nov '18

This fixed several issues identified in dm core/cpu/timer codes. The issues were found during RISC-V cpu/timer driver development for QEMU RISC-V port. This series is available at u-boot-x86/dm-fixes for testing. Changes in v3: - rebase on u-boot/master so that patch [4/8] can be applied cleanly Changes in v2: - rebase on u-boot/master, and fix one build error Bin Meng (8): dm: cpu: Fix print_cpuinfo() output cpu: mpc83xx: Remove unnecessary characters in the description string dm: util: Add a livetree equivalent API of dm_fdt_pre_reloc() dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt() dm: Correct pre_reloc_only parameter description in several APIs' comments dm: core: Mirror the chosen node parse logic in the livetree scanning test: dm: core: Add a test case for driver marked with DM_FLAG_PRE_RELOC flag timer: Sort Kconfig driver entries arch/sandbox/dts/test.dts | 4 ++ common/board_f.c | 2 +- drivers/core/device.c | 2 +- drivers/core/lists.c | 9 +++- drivers/core/root.c | 20 +++++--- drivers/core/util.c | 25 ++++++++++ drivers/cpu/mpc83xx_cpu.c | 2 +- drivers/serial/serial-uclass.c | 2 +- drivers/timer/Kconfig | 110 ++++++++++++++++++++--------------------- drivers/timer/timer-uclass.c | 2 +- include/dm/device-internal.h | 4 +- include/dm/lists.h | 9 ++-- include/dm/root.h | 17 ++++--- include/dm/util.h | 27 +++++++++- test/dm/bus.c | 2 +- test/dm/test-fdt.c | 29 +++++++++-- 16 files changed, 180 insertions(+), 86 deletions(-) -- 2.7.4

3 18

[U-Boot] [PATCH 0/9] efi_loader: fix fdt handling
by Heinrich Schuchardt 10 Nov '18

10 Nov '18

This patch series fixes several errors in the handling of addresses on the sandbox when setting up the flattened device tree. The memory type used for the fdt is corrected. It is checked by a unit test. A macro is supplied to calculate the numbers of pages needed for a buffer. Heinrich Schuchardt (9): EDT_support: fdt reservations on the sandbox efi_loader: fix efi_find_free_memory() efi_loader: memory reservation for fdt efi_loader: carving out memory reservations efi_loader: correct efi_add_known_memory() efi_loader: macro efi_size_in_pages() efi_loader: fix memory mapping for sandbox efi_loader: do not use magic address for fdt efi_selftest: check fdt is marked as runtime data cmd/bootefi.c | 79 +++++++++++--------------- common/fdt_support.c | 6 +- include/efi_loader.h | 11 +++- lib/efi_loader/efi_memory.c | 29 +++++++--- lib/efi_selftest/efi_selftest_memory.c | 24 ++++++++ 5 files changed, 91 insertions(+), 58 deletions(-) -- 2.19.1

1 9

[U-Boot] [PATCH 1/1] configs: disable Unicode capitalization on VF610
by Heinrich Schuchardt 10 Nov '18

10 Nov '18

For colibri_vf_defconfig u-boot-nodtb.bin exceeds file size limit. Disable CONFIG_EFI_UNICODE_CAPITALIZATION for vf610-colibri_vf61 to save a few KiB. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- Cf. https://travis-ci.org/xypron2/u-boot/jobs/453298845 --- configs/colibri_vf_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/colibri_vf_defconfig b/configs/colibri_vf_defconfig index 5854910f7ba..38f450c8eda 100644 --- a/configs/colibri_vf_defconfig +++ b/configs/colibri_vf_defconfig @@ -72,3 +72,4 @@ CONFIG_VIDEO_FSL_DCU_FB=y CONFIG_VIDEO=y CONFIG_SYS_CONSOLE_FG_COL=0x00 CONFIG_OF_LIBFDT_OVERLAY=y +# CONFIG_EFI_UNICODE_CAPITALIZATION is not set -- 2.19.1

2 1

[U-Boot] [PATCH] mmc: dw_mmc: Add RCRC handling
by Marek Vasut 10 Nov '18

10 Nov '18

This patch adds check for command response CRC failure. The driver is currently ignoring CRC check failure on command resposes which have CRC atteched to it, which can be potentially dangerous. Even more grueling problem happens when the command response is followed by data transfer though, as in that case, the dwmci_data_transfer() function will spin until it reaches the 240s timeout. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Heiko Stuebner <heiko(a)sntech.de> Cc: Philipp Tomsich <philipp.tomsich(a)theobroma-systems.com> --- drivers/mmc/dw_mmc.c | 4 ++++ include/dwmmc.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 3c702b3ed8..7544b84ab6 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -317,6 +317,10 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, } else if (mask & DWMCI_INTMSK_RE) { debug("%s: Response Error.\n", __func__); return -EIO; + } else if ((cmd->resp_type & MMC_RSP_CRC) && + (mask & DWMCI_INTMSK_RCRC)) { + debug("%s: Response CRC Error.\n", __func__); + return -EIO; } diff --git a/include/dwmmc.h b/include/dwmmc.h index 0f9d51b557..4ceda5e43c 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -56,6 +56,7 @@ #define DWMCI_INTMSK_DTO (1 << 3) #define DWMCI_INTMSK_TXDR (1 << 4) #define DWMCI_INTMSK_RXDR (1 << 5) +#define DWMCI_INTMSK_RCRC (1 << 6) #define DWMCI_INTMSK_DCRC (1 << 7) #define DWMCI_INTMSK_RTO (1 << 8) #define DWMCI_INTMSK_DRTO (1 << 9) -- 2.18.0

2 1

[U-Boot] [PATCH] common: build ymodem only on need
by Jun Nie 10 Nov '18

10 Nov '18

Build ymodem only on need to shrink spl image size. Signed-off-by: Jun Nie <jun.nie(a)linaro.org> --- common/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/Makefile b/common/Makefile index c7bde23..0614348 100644 --- a/common/Makefile +++ b/common/Makefile @@ -133,4 +133,5 @@ obj-y += command.o obj-$(CONFIG_$(SPL_)LOG) += log.o obj-$(CONFIG_$(SPL_)LOG_CONSOLE) += log_console.o obj-y += s_record.o -obj-y += xyzModem.o +obj-$(CONFIG_CMD_LOADB) += xyzModem.o +obj-$(CONFIG_$(SPL_TPL_)YMODEM_SUPPORT) += xyzModem.o -- 1.9.1

2 1