April 2016 - U-Boot

[U-Boot] [PATCH] stm32: stm32_flash: add memory barrier during flash write
by Vikas Manocha 12 Apr '16

12 Apr '16

After writing data to flash space, next instruction is checking if flash controller is busy writing to the flash memory. Memory barrier is required here to avoid transaction re-ordering for data write and busy status check. Signed-off-by: Vikas Manocha <vikas.manocha(a)st.com> --- drivers/mtd/stm32_flash.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mtd/stm32_flash.c b/drivers/mtd/stm32_flash.c index 71f4854..e16b6cd 100644 --- a/drivers/mtd/stm32_flash.c +++ b/drivers/mtd/stm32_flash.c @@ -137,6 +137,10 @@ int write_buff(flash_info_t *info, uchar *src, ulong addr, ulong cnt) /* To make things simple use byte writes only */ for (i = 0; i < cnt; i++) { *(uchar *)(addr + i) = src[i]; + /* avoid re-ordering flash data write and busy status + * check as flash memory space attributes are generally Normal + */ + mb(); while (readl(&STM32_FLASH->sr) & STM32_FLASH_SR_BSY) ; } -- 1.9.1

2 1

[U-Boot] [PATCH v2] test/py: Add support for loading image via tftp to specified location
by Michal Simek 12 Apr '16

12 Apr '16

For example this setting: env__net_tftp_readable_file = { "fn": "ep108/image.ub", "addr": 0x10000000, "size": 25846296, "crc32": "b726f9de", } Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- Changes in v2: - Remove quotes from addr field - Remove int conversion - Update example at the top of file test/py/tests/test_net.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py index 07393eb1fdf8..4ab58b44248a 100644 --- a/test/py/tests/test_net.py +++ b/test/py/tests/test_net.py @@ -43,6 +43,7 @@ env__net_static_env_vars = [ # may be omitted or set to None if TFTP testing is not possible or desired. env__net_tftp_readable_file = { "fn": "ubtest-readable.bin", + "addr": 0x10000000, "size": 5058624, "crc32": "c2244b26", } @@ -135,7 +136,10 @@ def test_net_tftpboot(u_boot_console): if not f: pytest.skip('No TFTP readable file to read') - addr = u_boot_utils.find_ram_base(u_boot_console) + addr = f.get('addr', None) + if not addr: + addr = u_boot_utils.find_ram_base(u_boot_console) + fn = f['fn'] output = u_boot_console.run_command('tftpboot %x %s' % (addr, fn)) expected_text = 'Bytes transferred = ' -- 1.9.1

3 2

[U-Boot] [PATCH] spmi: Fix sandbox spmi driver memory corruption
by Mateusz Kulikowski 12 Apr '16

12 Apr '16

There is off-by-one error in sandbox_emul_gpio that causes segfault of certain tests. EMUL_GPIO_REG_END is the address of last valid (emulated) register. This patch fixed this (by adding one more element to emulated register array). Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski(a)gmail.com> --- drivers/spmi/spmi-sandbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spmi/spmi-sandbox.c b/drivers/spmi/spmi-sandbox.c index 2f0fea0..980aff2 100644 --- a/drivers/spmi/spmi-sandbox.c +++ b/drivers/spmi/spmi-sandbox.c @@ -35,7 +35,8 @@ struct sandbox_emul_fake_regs { }; struct sandbox_emul_gpio { - struct sandbox_emul_fake_regs r[EMUL_GPIO_REG_END]; /* Fake registers */ + /* Fake registers - need one more entry as REG_END is valid address. */ + struct sandbox_emul_fake_regs r[EMUL_GPIO_REG_END + 1]; }; struct sandbox_spmi_priv { -- 2.5.0

3 2

[U-Boot] [PATCH] test/py: pass -v option when executing sandbox
by Stephen Warren 12 Apr '16

12 Apr '16

From: Stephen Warren <swarren(a)nvidia.com> This shows more output, such as the internal output generated by the unit test ("ut") command, which makes it easier to debug issues. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- test/py/u_boot_console_sandbox.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/py/u_boot_console_sandbox.py b/test/py/u_boot_console_sandbox.py index 3de0fe4a3b6d..04654ae8c9fe 100644 --- a/test/py/u_boot_console_sandbox.py +++ b/test/py/u_boot_console_sandbox.py @@ -44,6 +44,7 @@ class ConsoleSandbox(ConsoleBase): cmd += ['gdbserver', self.config.gdbserver] cmd += [ self.config.build_dir + '/u-boot', + '-v', '-d', self.config.build_dir + '/arch/sandbox/dts/test.dtb' ] -- 2.8.1

3 3

[U-Boot] [PATCH] board: ti: am57xx: Prevent init_sata() from being called twice
by Roger Quadros 12 Apr '16

12 Apr '16

init_sata() is done as part of scsi_init() in arch/arm/cpu/armv7/omap-common/sata.c so no need to duplicate it here. This seems to fix SATA problems in the kernel when CONFIG_TI_PIPE3 is configured as loadable module. Cc: Cooper Jr., Franklin <fcooper(a)ti.com> Cc: Nishanth Menon <nm(a)ti.com> Signed-off-by: Roger Quadros <rogerq(a)ti.com> --- board/ti/am57xx/board.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c index 042f9ab..34c5161 100644 --- a/board/ti/am57xx/board.c +++ b/board/ti/am57xx/board.c @@ -264,7 +264,6 @@ int board_init(void) int board_late_init(void) { - init_sata(0); /* * DEV_CTRL.DEV_ON = 1 please - else palmas switches off in 8 seconds * This is the POWERHOLD-in-Low behavior. -- 2.5.0

2 1

[U-Boot] [PATCH] README: Specify the full path for README.video
by Fabio Estevam 12 Apr '16

12 Apr '16

From: Fabio Estevam <fabio.estevam(a)nxp.com> It is clearer to specify the full path to access the doc/README.video file. Signed-off-by: Fabio Estevam <fabio.estevam(a)nxp.com> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 4fec467..1dd7ab7 100644 --- a/README +++ b/README @@ -1802,7 +1802,7 @@ CBFS (Coreboot Filesystem) support The DIU driver will look for the 'video-mode' environment variable, and if defined, enable the DIU as a console during - boot. See the documentation file README.video for a + boot. See the documentation file doc/README.video for a description of this variable. - LCD Support: CONFIG_LCD -- 1.9.1

2 1

[U-Boot] [RFC V2 PATCH 0/3] Add cache for block devices
by Eric Nelson 12 Apr '16

12 Apr '16

Here's a more full-featured implementation of a cache for block devices that uses a small linked list of cache blocks. Experimentation loading a 4.5 MiB kernel from the root directory of a FAT filesystem shows that a single cache entry of a single block is the only Loading the same from the /boot directory of an ext4 filesystem shows a benefit with 4 cache entries, though the single biggest benefit is also with the first cache entry: => for n in 0 1 2 4 8 ; do > blkc 1 $n ; blkc c ; blkc i ; > load mmc 0:2 10008000 /boot/zImage ; > done changed to max of 0 entries of 1 blocks each 4955304 bytes read in 503 ms (9.4 MiB/s) changed to max of 1 entries of 1 blocks each 4955304 bytes read in 284 ms (16.6 MiB/s) changed to max of 2 entries of 1 blocks each 4955304 bytes read in 284 ms (16.6 MiB/s) changed to max of 4 entries of 1 blocks each 4955304 bytes read in 255 ms (18.5 MiB/s) changed to max of 8 entries of 1 blocks each 4955304 bytes read in 255 ms (18.5 MiB/s) As mentioned earlier in this thread, the modification to the mmc layer should probably be simpler and easier to apply to other block subsystems. Eric Nelson (3): drivers: block: add block device cache block: add Kconfig options for BLOCK_CACHE, CMD_BLOCK_CACHE mmc: add support for block device cache drivers/block/Kconfig | 19 ++++ drivers/block/Makefile | 1 + drivers/block/cache_block.c | 240 ++++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/mmc.c | 10 +- drivers/mmc/mmc_write.c | 7 ++ include/part.h | 69 +++++++++++++ 6 files changed, 345 insertions(+), 1 deletion(-) create mode 100644 drivers/block/cache_block.c -- 2.6.2

5 50

[U-Boot] [PATCH] ARM: rpi: add some missing Kconfig help text
by Stephen Warren 12 Apr '16

12 Apr '16

Add notes re: enabling the UART to the RPi 3 32-bit help text. Fully describe the RPi 3 64-bit board option. Signed-off-by: Stephen Warren <swarren(a)wwwdotorg.org> --- arch/arm/mach-bcm283x/Kconfig | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-bcm283x/Kconfig b/arch/arm/mach-bcm283x/Kconfig index a1ad1a4e0fa8..f4c9502b3f1f 100644 --- a/arch/arm/mach-bcm283x/Kconfig +++ b/arch/arm/mach-bcm283x/Kconfig @@ -63,7 +63,9 @@ config TARGET_RPI_3_32B This option assumes the VideoCore firmware is configured to use the mini UART (rather than PL011) for the serial console. This is the default on the RPi 3. To enable the UART console, the following non- - default option must be present in config.txt: enable_uart=1. + default option must be present in config.txt: enable_uart=1. This is + required for U-Boot to operate correctly, even if you only care + about the HDMI/usbkbd console. This option creates a build targetting the ARMv7/AArch32 ISA. select ARMV7_LPAE @@ -72,6 +74,30 @@ config TARGET_RPI_3_32B config TARGET_RPI_3 bool "Raspberry Pi 3 64-bit build" + help + Support for all BCM2837-based Raspberry Pi variants, such as + the RPi 3 model B, in AArch64 (64-bit) mode. + + This option assumes the VideoCore firmware is configured to use the + mini UART (rather than PL011) for the serial console. This is the + default on the RPi 3. To enable the UART console, the following non- + default option must be present in config.txt: enable_uart=1. This is + required for U-Boot to operate correctly, even if you only care + about the HDMI/usbkbd console. + + At the time of writing, the VC FW requires a non-default option in + config.txt to request the ARM CPU boot in 64-bit mode: + arm_control=0x200 + + The VC FW typically provides ARM "stub" code to set up the CPU and + quiesce secondary SMP CPUs. This is not currently true in 64-bit + mode. In order to boot U-Boot before the VC FW is enhanced, please + see the commit description for the commit which added RPi3 support + for a workaround. Since the instructions are temporary, they are not + duplicated here. The VC FW enhancement is tracked in + https://github.com/raspberrypi/firmware/issues/579. + + This option creates a build targetting the ARMv8/AArch64 ISA. select ARM64 select BCM2837 -- 2.7.4

2 2

[U-Boot] [PATCH 1/2] ARM: allow CONFIG_GICV* not to be defined
by Stephen Warren 12 Apr '16

12 Apr '16

There are ARM SoCs (such as the BCM2837) do not contain an ARM GIC. Fix the ARMv8 CPU startup code to compile in this case. Signed-off-by: Stephen Warren <swarren(a)wwwdotorg.org> --- arch/arm/cpu/armv8/start.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S index 67b166c7fd46..dceedd7100ae 100644 --- a/arch/arm/cpu/armv8/start.S +++ b/arch/arm/cpu/armv8/start.S @@ -202,14 +202,14 @@ WEAK(lowlevel_init) mov x29, lr /* Save LR */ #ifndef CONFIG_ARMV8_MULTIENTRY +#if defined(CONFIG_GICV2) || defined(CONFIG_GICV3) /* * For single-entry systems the lowlevel init is very simple. */ ldr x0, =GICD_BASE bl gic_init_secure - +#endif #else /* CONFIG_ARMV8_MULTIENTRY is set */ - #if defined(CONFIG_GICV2) || defined(CONFIG_GICV3) branch_if_slave x0, 1f ldr x0, =GICD_BASE -- 2.7.4

2 6

[U-Boot] [PATCH] arm: socfpga: sr1500: Remove USB_GADGET
by Semen Protsenko 12 Apr '16

12 Apr '16

From: Sam Protsenko <semen.protsenko(a)linaro.org> "buildman" tool revealed that USB_GADGET was enabled by mistake for this board in process of moving that option to Kconfig. Remove it to bring things back to correct state. Signed-off-by: Sam Protsenko <semen.protsenko(a)linaro.org> --- configs/socfpga_sr1500_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs/socfpga_sr1500_defconfig b/configs/socfpga_sr1500_defconfig index 2842fba..d499a14 100644 --- a/configs/socfpga_sr1500_defconfig +++ b/configs/socfpga_sr1500_defconfig @@ -21,5 +21,3 @@ CONFIG_DM_ETH=y CONFIG_ETH_DESIGNWARE=y CONFIG_SYS_NS16550=y CONFIG_CADENCE_QSPI=y -CONFIG_USB=y -CONFIG_USB_GADGET=y -- 2.8.0.rc3

6 6