November 2014 - U-Boot

[U-Boot] arch/arm/lib/board.c - uninitialized vars
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hi, I'm trying to clean up some warnings/errors detected when running "cppcheck" on the U-Boot source tree. For arch/arm/lib/board.c I get this: [arch/arm/lib/board.c:445]: (error) Uninitialized variable: id [arch/arm/lib/board.c:422]: (error) Uninitialized variable: addr_sp The problem is not usually detected by GCC depending on which macros are active, here especially CONFIG_SPL_BUILD The relevant code was last touched / introduced by commit f1d2b313: "ARM: add relocation support" some two years ago... I have some questions regarding the CONFIG_SPL_BUILD "else" case (i. e. when building with CONFIG_SPL_BUILD defined): 422 addr_sp += 128; /* leave 32 words for abort-stack */ Is this correct? The stack is growing downward, so should the '+' not be replaced by a '-', like we do a few lines above: 412 /* leave 3 words for abort-stack */ 413 addr_sp -= 12; Why do we need 128 words in the CONFIG_SPL_BUILD case, but only 3 otherwise? Should we not move the "alignment for ABI compliance" part outside the CONFIG_SPL_BUILD if/else case, i. e. should this not always be done? And of course, how should we correctly initialize the "id" and "addr_sp" variable in both cases? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de Der Dativ ist dem Genitiv sein Tod.

2 2

[U-Boot] [scripts/kconfig/nconf.gui.c:375]: (error) Common realloc mistake
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [scripts/kconfig/confdata.c:983]: (error) Resource leak: tristate [scripts/kconfig/nconf.gui.c:375]: (error) Common realloc mistake: 'result' nulled but not freed upon failure [scripts/kconfig/nconf.gui.c:481]: (error) Common realloc mistake: 'result' nulled but not freed upon failure [scripts/kconfig/symbol.c:904]: (error) Common realloc mistake: 'res' nulled but not freed upon failure [scripts/kconfig/zconf.lex.c:817]: (error) Common realloc mistake: 'text' nulled but not freed upon failure can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de How many seconds are there in a year? If I tell you there are 3.155 x 10^7, you won't even try to remember it. On the other hand, who could forget that, to within half a percent, pi seconds is a nanocentury. -- Tom Duff, Bell Labs

1 0

[U-Boot] [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [board/gdsys/405ep/iocon.c:372]: (error) Uninitialized variable: fpga_features can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de If you believe that feeling bad or worrying long enough will change a past or future event, then you are residing on another planet with a different reality system.

2 1

[U-Boot] [drivers/net/e1000.c:2251]: (error) Uninitialized variable: phy_data
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [drivers/net/e1000.c:2251]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2261]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2303]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2313]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2380]: (error) Uninitialized variable: phy_data [drivers/net/e1000.c:2428]: (error) Uninitialized variable: phy_data can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de "Never face facts; if you do, you'll never get up in the morning." - Marlo Thomas

1 0

[U-Boot] [drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de Dear Lord: I just want *one* one-armed manager so I never have to hear "On the other hand", again.

1 0

[U-Boot] [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [board/muas3001/muas3001.c:270]: (error) Uninitialized variable: psize can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de Faith may be defined briefly as an illogical belief in the occurence of the improbable. - H. L. Mencken

1 0

[U-Boot] [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable: psize
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable: psize can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de An expert is a person who avoids the small errors while sweeping on to the grand fallacy.

1 0

[U-Boot] [PATCH 0/6] Collect utility macros to include/linux/kernel.h synced with Linux
by Masahiro Yamada 06 Nov '14

06 Nov '14

We have imported useful macros from Linux scattering them to various places. In include/common.h are min, max, min3, max3, ARRAY_SIZE, ALIGN, container_of, DIV_ROUND_UP, roundup, etc. In include/linux/compat.h are min_t, max_t, round_up, round_down, etc. We also have duplicated defines of min_t in some *.c files. I'd like to create include/linux/kernel.h and arrange sprinkled Linux-originated macros in order. I believe this work will be helpful when we import more macros or sync include/linux/kenrel.h in the future. I confirmed clean output of buildman. No section: 'make-flags' boards.cfg is up to date. Nothing to do. Summary of 7 commits for 1175 boards (8 threads, 1 job per thread) 01: arm: interrupt_init: set sp in IRQ/FIQ modes nios2: + nios2-generic sh: + rsk7269 rsk7264 rsk7203 blackfin: + bf609-ezkit arm: + maxbcm smdkv310 snow smdk5250 smdk5420 origen odroid db-mv784mp-gp s5pc210_universal trats peach-pit arndale trats2 powerpc: + TQM834x 02: replace DIV_ROUND with DIV_ROUND_CLOSEST 03: include/common.h: remove DIV_ROUND definition 04: include: move various macros to include/linux/kernel.h 05: linux/kernel.h: import more macros 06: linux/kernel.h: add typechecking to roundup macro 07: linux/kernel.h: sync min, max, min3, max3 macros with Linux Masahiro Yamada (6): replace DIV_ROUND with DIV_ROUND_CLOSEST include/common.h: remove DIV_ROUND definition include: move various macros to include/linux/kernel.h linux/kernel.h: import more macros linux/kernel.h: add typechecking to roundup macro linux/kernel.h: sync min, max, min3, max3 macros with Linux arch/arm/cpu/arm1176/tnetv107x/clock.c | 5 +- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 3 +- arch/arm/cpu/armv7/bcm281xx/clk-core.h | 4 - arch/arm/cpu/armv7/exynos/clock.c | 4 +- arch/arm/cpu/armv7/omap-common/abb.c | 6 +- arch/arm/cpu/armv7/tegra20/display.c | 4 +- arch/avr32/cpu/at32ap700x/clk.c | 2 +- arch/blackfin/cpu/jtag-console.c | 2 +- arch/blackfin/lib/string.c | 2 +- arch/mips/cpu/mips32/au1x00/au1x00_usb_ohci.c | 2 - arch/powerpc/cpu/mpc5xxx/usb_ohci.c | 2 - arch/powerpc/cpu/mpc85xx/tlb.c | 2 +- arch/powerpc/cpu/ppc4xx/44x_spd_ddr2.c | 32 ++-- arch/powerpc/cpu/ppc4xx/usb_ohci.c | 2 - arch/powerpc/lib/bootm.c | 2 +- arch/sandbox/cpu/start.c | 2 +- arch/x86/cpu/coreboot/pci.c | 2 +- arch/x86/cpu/coreboot/sdram.c | 2 +- board/freescale/common/sys_eeprom.c | 6 +- board/gdsys/p1022/controlcenterd-id.c | 5 +- board/imgtec/malta/malta.c | 2 +- common/cmd_elf.c | 12 +- common/cmd_sf.c | 16 +- common/env_nand.c | 4 +- common/fdt_support.c | 3 +- common/lcd.c | 6 +- common/usb_hub.c | 3 +- drivers/block/ahci.c | 2 +- drivers/ddr/fsl/ctrl_regs.c | 22 +-- drivers/ddr/fsl/lc_common_dimm_params.c | 62 ++++--- drivers/ddr/fsl/main.c | 3 +- drivers/dfu/dfu.c | 2 +- drivers/i2c/fsl_i2c.c | 2 +- drivers/misc/cros_ec_spi.c | 2 +- drivers/misc/mxc_ocotp.c | 4 +- drivers/mmc/fsl_esdhc.c | 2 +- drivers/mmc/pxa_mmc_gen.c | 6 +- drivers/mtd/nand/denali_spl.c | 2 +- drivers/mtd/spi/sandbox.c | 2 +- drivers/mtd/spi/sf_ops.c | 5 +- drivers/net/netconsole.c | 2 +- drivers/pci/pci.c | 6 +- drivers/pci/pci_auto.c | 2 +- drivers/serial/usbtty.c | 2 +- drivers/spi/fsl_espi.c | 4 +- drivers/spi/mxc_spi.c | 2 +- drivers/spi/spi-uclass.c | 2 +- drivers/tpm/tpm_tis_lpc.c | 2 +- drivers/usb/gadget/composite.c | 4 +- drivers/usb/gadget/designware_udc.c | 4 +- drivers/usb/gadget/pxa27x_udc.c | 3 +- drivers/usb/gadget/s3c_udc_otg_xfer_dma.c | 4 +- drivers/usb/host/dwc2.c | 14 +- drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/isp116x-hcd.c | 6 - drivers/usb/host/ohci-hcd.c | 3 - drivers/usb/host/ohci-s3c24xx.c | 3 - drivers/usb/host/r8a66597-hcd.c | 3 - drivers/usb/host/xhci-ring.c | 2 +- drivers/usb/host/xhci.c | 2 +- drivers/usb/musb/musb_hcd.h | 3 - drivers/video/ati_radeon_fb.c | 5 - drivers/video/cfb_console.c | 18 +- fs/ext4/dev.c | 13 +- fs/fat/fat.c | 2 +- fs/ubifs/ubifs.h | 4 - include/common.h | 90 +--------- include/linux/compat.h | 42 ----- include/linux/kernel.h | 245 ++++++++++++++++++++++++++ lib/strmhz.c | 4 +- lib/vsprintf.c | 3 - 71 files changed, 431 insertions(+), 323 deletions(-) create mode 100644 include/linux/kernel.h -- 1.9.1

4 15

[U-Boot] MCF: uninitialized variables
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [arch/m68k/cpu/mcf5227x/speed.c:89]: (error) Uninitialized variable: bootmode [arch/m68k/cpu/mcf532x/speed.c:248]: (error) Uninitialized variable: fout [arch/m68k/cpu/mcf5445x/speed.c:194]: (error) Uninitialized variable: bootmode Could you please have a look how to fix this? Eventually this could be used as opportunity to clean up the code a bit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de It usually takes more than three weeks to prepare a good impromptu speech. - Mark Twain

1 0

[U-Boot] [PATCH V2 0/4] cm-fx6 updates
by Nikita Kiryanov 06 Nov '14

06 Nov '14

This patchset contains a bug fix for DRAM detection, support for Phison SSD, and a new preboot hook. Cc: Igor Grinberg <grinberg(a)compulab.co.il> Cc: Stefano Babic <sbabic(a)denx.de> Changes in V2: - Added board_preboot_os to bootm.h - Split "common: introduce board_preboot_os hook" into 2 patches Nikita Kiryanov (4): arm: mx6: cm_fx6: change issd gpio order arm: mx6: cm_fx6: detect 1GB DRAM correctly on solo common: introduce board_preboot_os hook arm: mx6: cm_fx6: power down sata on OS boot board/compulab/cm_fx6/cm_fx6.c | 8 +++++++- board/compulab/cm_fx6/spl.c | 7 ++++--- common/bootm_os.c | 7 +++++++ include/bootm.h | 1 + 4 files changed, 19 insertions(+), 4 deletions(-) -- 1.9.1

4 15