November 2014 - U-Boot

[U-Boot] [common/cmd_ini.c:137]: (error) Uninitialized variable: line
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [common/cmd_ini.c:137]: (error) Uninitialized variable: line can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de 365 Days of drinking Lo-Cal beer. = 1 Lite-year

2 3

[U-Boot] CONFIG_LCD_BMP_RLE8 and MCC200 dead code?
by Nikita Kiryanov 06 Nov '14

06 Nov '14

Hi all, I've been trying to do some cleanup in common/lcd.c, and noticed some unused code: One is the CONFIG_LCD_BMP_REL8 stuff. This code was added 2 years ago in patch 45d7f52511f43b71b623a502fdf31feb905f70a1, and so far it has no users (sandbox.h defines it, but only to fix a compilation error, see commit 0156444cf7e77e92fed7a61d6c6123b349f1d600). The other case is MCC200 specific #ifdefs. It handles 1bpp BMPs, which I don't think is likely to be used by current and future boards, and the board itself is old, and has no maintainer. Perhaps this board can be removed? -- Regards, Nikita Kiryanov

3 3

[U-Boot] Can i pass pass an environmental variable or argument from command line to build u-boot?
by harsha kiran 06 Nov '14

06 Nov '14

Hi ! For our project, we are trying to build the Bootloader with a Software partnumber. and i want it to be displayed on the first U-boot print.. U-Boot 2014.07 (Nov 05 2014 - 16:27:50) PN#12345678-001 I2C: ready DRAM: 256 MiB WARNING: Caches not enabled MMC: OMAP SD/MMC: 0, OMAP SD/MMC: 1 Using default environment I was able to do this by adding the following in the boards.cfg file.. Active arm armv7 am33xx ti am335x_abb_uboot am335x_abb_uboot_npa_dev am335x_abb_uboot:SERIAL4,CONS_INDEX=4,NPA_DEV,IDENT_STRING="PN#12345678-001" But i want to pass the IDENT_STRING from the command line to build the u-boot..the command i use is sudo make ARCH=arm CROSS_COMPILE=/abb/compilers/gcc-linaro-arm-linux-gnueabihf-4.7-2013.04-20130415_linux/bin/arm-linux-gnueabihf- -j8 -s am335x_abb_uboot_npa_dev_config is there a way i can pass this argument while building the u-boot? Thanks, Harsha -- View this message in context: http://u-boot.10912.n7.nabble.com/Can-i-pass-pass-an-environmental-variable… Sent from the U-Boot mailing list archive at Nabble.com.

3 4

[U-Boot] SPL (Secondary Program Loader) on iMX6SL
by John Tobias 06 Nov '14

06 Nov '14

Hi All, I ported the SPL features of u-boot into iMX6 SabreSD. I was able to load the SPL image and configure the DDR correctly. Then, I ported it again on iMX6SL-evk, unfortunately, I did not get any data on my serial port window. I played with some different values for CCM_CCGR0 - CCM_CCGR6 and still not getting data. I am not sure exactly what are the big difference between the ROM code of the two chips and why it didn't work. Does anyone could tell me what may be the possible problem?. Regards, John

2 4

[U-Boot] [U-boot] [Patch v2] net: phy: marvell: add errata w/a for 88E151* chips
by Ivan Khoronzhuk 06 Nov '14

06 Nov '14

From: Hao Zhang <hzhang(a)ti.com> As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512/88E1514 Rev A0, Errata Section 3.1 Marvell PHY has an errata which requires that certain registers get written in order to restart autonegotiation. Signed-off-by: Hao Zhang <hzhang(a)ti.com> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk(a)ti.com> --- v2..v1 use only for SGMII interface. drivers/net/phy/marvell.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index d2ecadc..9437c3b 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -276,6 +276,57 @@ static int m88e1111s_config(struct phy_device *phydev) return 0; } +/** + * m88e1518_phy_writebits - write bits to a register + */ +void m88e1518_phy_writebits(struct phy_device *phydev, + u8 reg_num, u16 offset, u16 len, u16 data) +{ + u16 reg, mask; + + if ((len + offset) >= 16) + mask = 0 - (1 << offset); + else + mask = (1 << (len + offset)) - (1 << offset); + + reg = phy_read(phydev, MDIO_DEVAD_NONE, reg_num); + + reg &= ~mask; + reg |= data << offset; + + phy_write(phydev, MDIO_DEVAD_NONE, reg_num, reg); +} + +static int m88e1518_config(struct phy_device *phydev) +{ + /* + * As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512 + * /88E1514 Rev A0, Errata Section 3.1 + */ + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0x00ff); /* page 0xff */ + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0x214B); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2144); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0x0C28); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2146); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0xB233); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x214D); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0xCC0C); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2159); + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0x0000); /* reg page 0 */ + phy_write(phydev, MDIO_DEVAD_NONE, 22, 18); /* reg page 18 */ + /* Write HWCFG_MODE = SGMII to Copper */ + m88e1518_phy_writebits(phydev, 20, 0, 3, 1); + + /* Phy reset */ + m88e1518_phy_writebits(phydev, 20, 15, 1, 1); + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0); /* reg page 18 */ + udelay(100); + } + + return m88e1111s_config(phydev); +} + /* Marvell 88E1118 */ static int m88e1118_config(struct phy_device *phydev) { @@ -493,7 +544,7 @@ static struct phy_driver M88E1518_driver = { .uid = 0x1410dd1, .mask = 0xffffff0, .features = PHY_GBIT_FEATURES, - .config = &m88e1111s_config, + .config = &m88e1518_config, .startup = &m88e1011s_startup, .shutdown = &genphy_shutdown, }; -- 1.8.3.2

3 2

[U-Boot] [U-boot] [Patch] net: phy: marvell: add errata w/a for 88E151* chips
by Ivan Khoronzhuk 06 Nov '14

06 Nov '14

From: Hao Zhang <hzhang(a)ti.com> As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512/88E1514 Rev A0, Errata Section 3.1 Marvell PHY has an errata which requires that certain registers get written in order to restart autonegotiation. Signed-off-by: Hao Zhang <hzhang(a)ti.com> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk(a)ti.com> --- drivers/net/phy/marvell.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index d2ecadc..425db94 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -276,6 +276,55 @@ static int m88e1111s_config(struct phy_device *phydev) return 0; } +/** + * m88e1518_phy_writebits - write bits to a register + */ +void m88e1518_phy_writebits(struct phy_device *phydev, + u8 reg_num, u16 offset, u16 len, u16 data) +{ + u16 reg, mask; + + if ((len + offset) >= 16) + mask = 0 - (1 << offset); + else + mask = (1 << (len + offset)) - (1 << offset); + + reg = phy_read(phydev, MDIO_DEVAD_NONE, reg_num); + + reg &= ~mask; + reg |= data << offset; + + phy_write(phydev, MDIO_DEVAD_NONE, reg_num, reg); +} + +static int m88e1518_config(struct phy_device *phydev) +{ + /* + * As per Marvell Release Notes - Alaska 88E1510/88E1518/88E1512/88E1514 + * Rev A0, Errata Section 3.1 + */ + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0x00ff); /* reg page 0xff */ + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0x214B); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2144); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0x0C28); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2146); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0xB233); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x214D); + phy_write(phydev, MDIO_DEVAD_NONE, 17, 0xCC0C); + phy_write(phydev, MDIO_DEVAD_NONE, 16, 0x2159); + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0x0000); /* reg page 0 */ + phy_write(phydev, MDIO_DEVAD_NONE, 22, 18); /* reg page 18 */ + /* Write HWCFG_MODE = SGMII to Copper */ + m88e1518_phy_writebits(phydev, 20, 0, 3, 1); + + /* Phy reset */ + m88e1518_phy_writebits(phydev, 20, 15, 1, 1); + phy_write(phydev, MDIO_DEVAD_NONE, 22, 0); /* reg page 18 */ + udelay(100); + + return m88e1111s_config(phydev); +} + /* Marvell 88E1118 */ static int m88e1118_config(struct phy_device *phydev) { @@ -493,7 +542,7 @@ static struct phy_driver M88E1518_driver = { .uid = 0x1410dd1, .mask = 0xffffff0, .features = PHY_GBIT_FEATURES, - .config = &m88e1111s_config, + .config = &m88e1518_config, .startup = &m88e1011s_startup, .shutdown = &genphy_shutdown, }; -- 1.8.3.2

3 5

[U-Boot] [PATCH] sunxi: move "select CPU_V7" to ARCH_SUNXI
by Masahiro Yamada 06 Nov '14

06 Nov '14

CPU_V7 is select'ed by all the MACH_SUN*I. While we are here, let's delete the redundant "string" typedef of SYS_CONFIG_NAME. Signed-off-by: Masahiro Yamada <yamada.m(a)jp.panasonic.com> --- arch/arm/Kconfig | 1 + board/sunxi/Kconfig | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 79ccc06..f9f52e5 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -668,6 +668,7 @@ config TARGET_SOCFPGA_CYCLONE5 config ARCH_SUNXI bool "Support sunxi (Allwinner) SoCs" + select CPU_V7 config TARGET_SNOWBALL bool "Support snowball" diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 5b2d091..9ac1205 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -5,31 +5,25 @@ choice config MACH_SUN4I bool "sun4i (Allwinner A10)" - select CPU_V7 select SUPPORT_SPL config MACH_SUN5I bool "sun5i (Allwinner A13)" - select CPU_V7 select SUPPORT_SPL config MACH_SUN6I bool "sun6i (Allwinner A31)" - select CPU_V7 config MACH_SUN7I bool "sun7i (Allwinner A20)" - select CPU_V7 select SUPPORT_SPL config MACH_SUN8I bool "sun8i (Allwinner A23)" - select CPU_V7 endchoice config SYS_CONFIG_NAME - string default "sun4i" if MACH_SUN4I default "sun5i" if MACH_SUN5I default "sun6i" if MACH_SUN6I -- 1.9.1

3 2

[U-Boot] [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [drivers/usb/musb-new/musb_core.c:2166]: (error) Uninitialized variable: musb [drivers/usb/musb-new/musb_host.c:1918]: (error) Uninitialized variable: idle can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de Be wiser than other people if you can, but do not tell them so. -- Philip Earl of Chesterfield

2 1

[U-Boot] [scripts/docproc.c:398]: (error) Common realloc mistake
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [scripts/docproc.c:398]: (error) Common realloc mistake: 'data' nulled but not freed upon failure [scripts/docproc.c:422]: (error) Common realloc mistake: 'all_list' nulled but not freed upon failure can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de F u cn rd ths u cnt spl wrth a dm!

2 1

[U-Boot] [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d
by Wolfgang Denk 06 Nov '14

06 Nov '14

Hello, cppcheck reports: [drivers/usb/gadget/f_dfu.c:687]: (error) Uninitialized variable: d can you please have a look? Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd(a)denx.de You could end up being oddly sad and full of a strange, diffuse com- passion which would lead you to believe that it might be a good idea to wipe out the whole human race and start again with amoebas. - Terry Pratchett, _Guards! Guards!_

2 2