September 2013 - U-Boot

[U-Boot] [PATCH 1/3] mx28evk: Propagate the error if cpu_eth_init() fails
by Fabio Estevam 27 Sep '13

27 Sep '13

From: Fabio Estevam <fabio.estevam(a)freescale.com> If cpu_eth_init() fails we should return the error immediately. Signed-off-by: Fabio Estevam <fabio.estevam(a)freescale.com> --- board/freescale/mx28evk/mx28evk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/freescale/mx28evk/mx28evk.c b/board/freescale/mx28evk/mx28evk.c index 3abf1fd..5005fe2 100644 --- a/board/freescale/mx28evk/mx28evk.c +++ b/board/freescale/mx28evk/mx28evk.c @@ -103,6 +103,8 @@ int board_eth_init(bd_t *bis) int ret; ret = cpu_eth_init(bis); + if (ret) + return ret; /* MX28EVK uses ENET_CLK PAD to drive FEC clock */ writel(CLKCTRL_ENET_TIME_SEL_RMII_CLK | CLKCTRL_ENET_CLK_OUT_EN, -- 1.8.1.2

3 7

[U-Boot] [PATCH] tools/imximage.c: Fix compiling warning
by York Sun 27 Sep '13

27 Sep '13

Convert set_hdr_func(struct imx_header *imxhdr) to set_hdr_func(void) to get rid of the warning warning: ‘imxhdr’ is used uninitialized in this function Signed-off-by: York Sun <yorksun(a)freescale.com> --- tools/imximage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/imximage.c b/tools/imximage.c index c87669b..32e4efe 100644 --- a/tools/imximage.c +++ b/tools/imximage.c @@ -259,7 +259,7 @@ static void set_imx_hdr_v2(struct imx_header *imxhdr, uint32_t dcd_len, csf_ptr = &fhdr_v2->csf; } -static void set_hdr_func(struct imx_header *imxhdr) +static void set_hdr_func(void) { switch (imximage_version) { case IMXIMAGE_V1: @@ -358,7 +358,7 @@ static void parse_cfg_cmd(struct imx_header *imxhdr, int32_t cmd, char *token, exit(EXIT_FAILURE); } cmd_ver_first = 1; - set_hdr_func(imxhdr); + set_hdr_func(); break; case CMD_BOOT_FROM: imximage_ivt_offset = get_table_entry_id(imximage_boot_offset, @@ -563,7 +563,7 @@ static void imximage_set_header(void *ptr, struct stat *sbuf, int ifd, /* Be able to detect if the cfg file has no BOOT_FROM tag */ imximage_ivt_offset = FLASH_OFFSET_UNDEFINED; imximage_csf_size = 0; - set_hdr_func(imxhdr); + set_hdr_func(); /* Parse dcd configuration file */ dcd_len = parse_cfg_file(imxhdr, params->imagename); @@ -631,7 +631,7 @@ static int imximage_generate(struct mkimage_params *params, /* Be able to detect if the cfg file has no BOOT_FROM tag */ imximage_ivt_offset = FLASH_OFFSET_UNDEFINED; imximage_csf_size = 0; - set_hdr_func(imxhdr); + set_hdr_func(); /* Parse dcd configuration file */ parse_cfg_file(&imximage_header, params->imagename); -- 1.7.9.5

2 2

[U-Boot] is it possible to map 2GB memory space to PCIe2 controller in u-boot for P1020 reference board
by jdwang＠qicetech.com 27 Sep '13

27 Sep '13

Hi all, We design a board similar as freescale P1020 reference board. The two PCIe controllers work fine with the default settings which allocate 512MB to each PCIe controller. Then we make some changes in u-boot to allocate 1.5GB to PCIe2 and 512MB to PCIe1 (P1_P2_RDB.h and tlb.c), the changes work fine. Finally, we want to allocate 2GB to PCIe2 and 512MB to PCIe1, but it failed. Does anyone know is it possible to map 2GB memory space to PCIe2 controller in P1020 reference board? Any clue is appreciated. 2013-09-27 Judd

1 0

[U-Boot] [PATCH 0/6] Second step towards Kbuild: Descend down like Kbuild
by Masahiro Yamada 27 Sep '13

27 Sep '13

I have been just wondering why the U-Boot top Makefile is so dirty. It is sprinkled with SoC-specific code as follows: ifneq ($(CONFIG_OMAP_COMMON),) LIBS-y += $(CPUDIR)/omap-common/libomap-common.o endif ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx31 mx35 mxs vf610)) LIBS-y += arch/$(ARCH)/imx-common/libimx-common.o endif ifeq ($(SOC),s5pc1xx) LIBS-y += $(CPUDIR)/s5p-common/libs5p-common.o endif ifeq ($(SOC),exynos) LIBS-y += $(CPUDIR)/s5p-common/libs5p-common.o endif ifneq ($(CONFIG_TEGRA),) LIBS-y += arch/$(ARCH)/cpu/$(SOC)-common/lib$(SOC)-common.o LIBS-y += arch/$(ARCH)/cpu/tegra-common/libcputegra-common.o LIBS-y += $(CPUDIR)/tegra-common/libtegra-common.o endif And it describes drivers not right under the top directory, which should be essentially cared by drivers/Makefile. LIBS-y += drivers/bios_emulator/libatibiosemu.o LIBS-y += drivers/block/libblock.o LIBS-$(CONFIG_BOOTCOUNT_LIMIT) += drivers/bootcount/libbootcount.o LIBS-y += drivers/crypto/libcrypto.o LIBS-y += drivers/dma/libdma.o ... This series adds the directory descending feature like Kbuild. 0001 tweaks scripts/Makefile.build to support 'obj-y += foo/' syntax. When the build system find 'foo/' (trailed by a slash), it visits foo directory. 0002-0006 demonstarate how we can refactor makefiles with this syntax. 0002: Move some drivers LIBS from top Makefile to drivers/Makefile 0003: Move some fs LIBS from top Makefile to fs/Makefile 0004: Move Tegra specific lines from top Makefile under arch/arm 0005: Move OMAP specific lines from top Makefile under arch/arm 0006: Move Samsung SoC specific lines from top Makefile under arch/arm Note: This series can be applies on v2013.10-rc2 + 'First step towards Kbuild: Use Kbuild-style makefiles' (19 patch files). Please apply 'First step towards Kbuild: Use Kbuild-style makefiles' first. I believe no boards are broken by this refactoring, but it is humans who can make a mistake. So, it is very important to do build check before patches are applied. I tested for ARM and sandbox: $ CROSS_COMPILE_ARM=arm-linux-gnueabi- ./MAKEALL -a arm -a sandbox and I got: --------------------- SUMMARY ---------------------------- Boards compiled: 336 ---------------------------------------------------------- But I can not test other architectures. I will be grateful for any custodians' help. Cc: Simon Glass <sjg(a)chromium.org> Cc: Tom Rini <trini(a)ti.com> Masahiro Yamada (6): Makefile: support descending down to subdirectories drivers: move some drivers to drivers/Makefile fs: move some file system to fs/Makefile ARM: tegra: delete Tegra specific code from toplevel Makefile ARM: omap: delete OMAP specific code from toplevel Makefile ARM: s5pc, exynos: delete Samsung ARM SoC specific code from toplevel Makefile Makefile | 42 +++--------------------------------------- arch/arm/cpu/Makefile | 2 ++ arch/arm/cpu/arm720t/Makefile | 2 ++ arch/arm/cpu/armv7/Makefile | 9 +++++++++ drivers/Makefile | 13 +++++++++++++ fs/Makefile | 11 +++++++++++ scripts/Makefile.build | 15 +++++++++++++++ spl/Makefile | 14 +------------- 8 files changed, 56 insertions(+), 52 deletions(-) create mode 100644 arch/arm/cpu/Makefile create mode 100644 drivers/Makefile -- 1.8.1.2

1 7

[U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value
by Rajeshwari S Shinde 27 Sep '13

27 Sep '13

This patch corrects the divider value written to CLKDIV register. Since SDCLKIN is divided inside controller by the DIVRATIO value set in the CLKSEL register, we need to use the same output clock value to calculate the CLKDIV value. as per user manual: cclk_in = SDCLKIN / (DIVRATIO + 1) Input parameter to mmc_clk is changed to dwmci_host, since we need the same to read DWMCI_CLKSEL register. This improves the read timing values for channel 0 on SMDK5250 from 0.288sec to 0.144sec Signed-off-by: Rajeshwari S Shinde <rajeshwari.s(a)samsung.com> --- arch/arm/include/asm/arch-exynos/dwmmc.h | 4 ++++ drivers/mmc/dw_mmc.c | 2 +- drivers/mmc/exynos_dw_mmc.c | 17 +++++++++++++++-- include/dwmmc.h | 2 +- 4 files changed, 21 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/arch-exynos/dwmmc.h b/arch/arm/include/asm/arch-exynos/dwmmc.h index b9eca76..f1c8d8a 100644 --- a/arch/arm/include/asm/arch-exynos/dwmmc.h +++ b/arch/arm/include/asm/arch-exynos/dwmmc.h @@ -14,6 +14,10 @@ #define DWMCI_SET_DRV_CLK(x) ((x) << 16) #define DWMCI_SET_DIV_RATIO(x) ((x) << 24) +/* CLKSEL Register */ +#define DWMCI_DIVRATIO_BIT 24 +#define DWMCI_DIVRATIO_MASK 0x7 + #ifdef CONFIG_OF_CONTROL int exynos_dwmmc_init(const void *blob); #endif diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index a82ee17..3406bdd 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -224,7 +224,7 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq) * host->bus_hz should be set from user. */ if (host->mmc_clk) - sclk = host->mmc_clk(host->dev_index); + sclk = host->mmc_clk(host); else if (host->bus_hz) sclk = host->bus_hz; else { diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c index 4ef9fec..1ed4afe 100644 --- a/drivers/mmc/exynos_dw_mmc.c +++ b/drivers/mmc/exynos_dw_mmc.c @@ -29,9 +29,22 @@ static void exynos_dwmci_clksel(struct dwmci_host *host) dwmci_writel(host, DWMCI_CLKSEL, host->clksel_val); } -unsigned int exynos_dwmci_get_clk(int dev_index) +unsigned int exynos_dwmci_get_clk(struct dwmci_host *host) { - return get_mmc_clk(dev_index); + unsigned long sclk; + int8_t clk_div; + + /* + * Since SDCLKIN is divided inside controller by the DIVRATIO + * value set in the CLKSEL register, we need to use the same output + * clock value to calculate the CLKDIV value. + * as per user manual:cclk_in = SDCLKIN / (DIVRATIO + 1) + */ + clk_div = ((dwmci_readl(host, DWMCI_CLKSEL) >> DWMCI_DIVRATIO_BIT) + & DWMCI_DIVRATIO_MASK) + 1; + sclk = get_mmc_clk(host->dev_index); + + return sclk / clk_div; } /* diff --git a/include/dwmmc.h b/include/dwmmc.h index 08ced0b..26b53af 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -138,7 +138,7 @@ struct dwmci_host { struct mmc *mmc; void (*clksel)(struct dwmci_host *host); - unsigned int (*mmc_clk)(int dev_index); + unsigned int (*mmc_clk)(struct dwmci_host *host); }; struct dwmci_idmac { -- 1.7.12.4

5 8

[U-Boot] [PATCH] i2c: Add support for Renesas rcar
by Nobuhiro Iwamatsu 27 Sep '13

27 Sep '13

This supports i2c controller for Renesas rcar. Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak(a)renesas.com> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> --- drivers/i2c/Makefile | 1 + drivers/i2c/rcar_i2c.c | 289 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 290 insertions(+) create mode 100644 drivers/i2c/rcar_i2c.c diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index 37ccbd1..f7cbd62 100644 --- a/drivers/i2c/Makefile +++ b/drivers/i2c/Makefile @@ -26,6 +26,7 @@ COBJS-$(CONFIG_TSI108_I2C) += tsi108_i2c.o COBJS-$(CONFIG_U8500_I2C) += u8500_i2c.o COBJS-$(CONFIG_SH_I2C) += sh_i2c.o COBJS-$(CONFIG_SH_SH7734_I2C) += sh_sh7734_i2c.o +COBJS-$(CONFIG_SYS_I2C_RCAR) += rcar_i2c.o COBJS-$(CONFIG_SYS_I2C) += i2c_core.o COBJS-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o COBJS-$(CONFIG_SYS_I2C_FTI2C010) += fti2c010.o diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c new file mode 100644 index 0000000..92f0700 --- /dev/null +++ b/drivers/i2c/rcar_i2c.c @@ -0,0 +1,289 @@ +/* + * drivers/i2c/rcar_i2c.c + * + * Copyright (C) 2013 Renesas Electronics Corporation + * Copyright (C) 2013 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> + * + * SPDX-License-Identifier: GPL-2.0 + */ + +#include <common.h> +#include <i2c.h> +#include <asm/io.h> + +DECLARE_GLOBAL_DATA_PTR; + +struct rcar_i2c { + u32 icscr; + u32 icmcr; + u32 icssr; + u32 icmsr; + u32 icsier; + u32 icmier; + u32 icccr; + u32 icsar; + u32 icmar; + u32 icrxdtxd; + u32 icccr2; + u32 icmpr; + u32 ichpr; + u32 iclpr; +}; + +#define MCR_MDBS 0x80 /* non-fifo mode switch */ +#define MCR_FSCL 0x40 /* override SCL pin */ +#define MCR_FSDA 0x20 /* override SDA pin */ +#define MCR_OBPC 0x10 /* override pins */ +#define MCR_MIE 0x08 /* master if enable */ +#define MCR_TSBE 0x04 +#define MCR_FSB 0x02 /* force stop bit */ +#define MCR_ESG 0x01 /* en startbit gen. */ + +#define MSR_MASK 0x7f +#define MSR_MNR 0x40 /* nack received */ +#define MSR_MAL 0x20 /* arbitration lost */ +#define MSR_MST 0x10 /* sent a stop */ +#define MSR_MDE 0x08 +#define MSR_MDT 0x04 +#define MSR_MDR 0x02 +#define MSR_MAT 0x01 /* slave addr xfer done */ + +static const struct rcar_i2c *i2c_dev[CONFIF_SYS_RCAR_I2C_NUM_CONTROLLERS] = { + (struct rcar_i2c *)CONFIG_SYS_RCAR_I2C0_BASE, + (struct rcar_i2c *)CONFIG_SYS_RCAR_I2C1_BASE, + (struct rcar_i2c *)CONFIG_SYS_RCAR_I2C2_BASE, + (struct rcar_i2c *)CONFIG_SYS_RCAR_I2C3_BASE, +}; + +static void rcar_i2c_raw_rw_common(struct rcar_i2c *dev, u8 chip, uint addr) +{ + /* set slave address */ + writel(chip << 1, &dev->icmar); + /* set register address */ + writel(addr, &dev->icrxdtxd); + /* clear status */ + writel(0, &dev->icmsr); + /* start master send */ + writel(MCR_MDBS | MCR_MIE | MCR_ESG, &dev->icmcr); + + while ((readl(&dev->icmsr) & (MSR_MAT | MSR_MDE)) + != (MSR_MAT | MSR_MDE)) + udelay(10); + + /* clear ESG */ + writel(MCR_MDBS | MCR_MIE, &dev->icmcr); + /* start SCLclk */ + writel(~(MSR_MAT | MSR_MDE), &dev->icmsr); + + while (!(readl(&dev->icmsr) & MSR_MDE)) + udelay(10); +} + +static void rcar_i2c_raw_rw_finish(struct rcar_i2c *dev) +{ + while (!(readl(&dev->icmsr) & MSR_MST)) + udelay(10); + + writel(0, &dev->icmcr); +} + +static int +rcar_i2c_raw_write(struct rcar_i2c *dev, u8 chip, uint addr, u8 *val, int size) +{ + rcar_i2c_raw_rw_common(dev, chip, addr); + + /* set send date */ + writel(*val, &dev->icrxdtxd); + /* start SCLclk */ + writel(~MSR_MDE, &dev->icmsr); + + while (!(readl(&dev->icmsr) & MSR_MDE)) + udelay(10); + + /* set stop condition */ + writel(MCR_MDBS | MCR_MIE | MCR_FSB, &dev->icmcr); + /* start SCLclk */ + writel(~MSR_MDE, &dev->icmsr); + + rcar_i2c_raw_rw_finish(dev); + + return 0; +} + +static u8 +rcar_i2c_raw_read(struct rcar_i2c *dev, u8 chip, uint addr) +{ + u8 ret; + + rcar_i2c_raw_rw_common(dev, chip, addr); + + /* set slave address, receive */ + writel((chip << 1) | 1, &dev->icmar); + /* start master receive */ + writel(MCR_MDBS | MCR_MIE | MCR_ESG, &dev->icmcr); + + while ((readl(&dev->icmsr) & (MSR_MAT | MSR_MDE)) + != (MSR_MAT | MSR_MDE)) + udelay(10); + + /* clear ESG */ + writel(MCR_MDBS | MCR_MIE, &dev->icmcr); + /* prepare stop condition */ + writel(MCR_MDBS | MCR_MIE | MCR_FSB, &dev->icmcr); + /* start SCLclk */ + writel(~(MSR_MAT | MSR_MDR), &dev->icmsr); + + while (!(readl(&dev->icmsr) & MSR_MDR)) + udelay(10); + + /* get receive data */ + ret = (u8)readl(&dev->icrxdtxd); + /* start SCLclk */ + writel(~MSR_MDR, &dev->icmsr); + + rcar_i2c_raw_rw_finish(dev); + + return ret; +} + + +/* + * SCL = iicck / (20 + SCGD * 8 + F[(ticf + tr + intd) * iicck]) + * iicck : I2C internal clock < 20 MHz + * ticf : I2C SCL falling time: 35 ns + * tr : I2C SCL rising time: 200 ns + * intd : LSI internal delay: I2C0: 50 ns I2C1-3: 5 + * F[n] : n rounded up to an integer + */ +static u32 rcar_clock_gen(int i2c_no, u32 bus_speed) +{ + u32 iicck, f, scl, scgd; + u32 intd = 5; + + int bit = 0, cdf_width = 3; + for (bit = 0; bit < (1 << cdf_width); bit++) { + iicck = CONFIG_HP_CLK_FREQ / (1 + bit); + if (iicck < 20000000) + break; + } + + if (bit > (1 << cdf_width)) { + puts("rcar-i2c: Can not get CDF\n"); + return 0; + } + + if (i2c_no == 0) + intd = 50; + + f = (35 + 200 + intd) * (iicck / 1000000000); + + for (scgd = 0; scgd < 0x40; scgd++) { + scl = iicck / (20 + (scgd * 8) + f); + if (scl <= bus_speed) + break; + } + + if (scgd > 0x40) { + puts("rcar-i2c: Can not get SDGB\n"); + return 0; + } + + debug("%s: scl: %d\n", __func__, scl); + debug("%s: bit %x\n", __func__, bit); + debug("%s: scgd %x\n", __func__, scgd); + debug("%s: iccr %x\n", __func__, (scgd << (cdf_width) | bit)); + + return scgd << (cdf_width) | bit; +} + +static void +rcar_i2c_init(struct i2c_adapter *adap, int speed, int slaveadd) +{ + struct rcar_i2c *dev = (struct rcar_i2c *)i2c_dev[adap->hwadapnr]; + u32 icccr = 0; + + /* No i2c support prior to relocation */ + if (!(gd->flags & GD_FLG_RELOC)) + return; + + /* + * reset slave mode. + * slave mode is not used on this driver + */ + writel(0, &dev->icsier); + writel(0, &dev->icsar); + writel(0, &dev->icscr); + writel(0, &dev->icssr); + + /* reset master mode */ + writel(0, &dev->icmier); + writel(0, &dev->icmcr); + writel(0, &dev->icmsr); + writel(0, &dev->icmar); + + icccr = rcar_clock_gen(adap->hwadapnr, adap->speed); + if (icccr == 0) + puts("I2C: Init failed\n"); + else + writel(icccr, &dev->icccr); +} + +static int rcar_i2c_read(struct i2c_adapter *adap, uint8_t chip, + uint addr, int alen, u8 *data, int len) +{ + struct rcar_i2c *dev = (struct rcar_i2c *)i2c_dev[adap->hwadapnr]; + int i; + + for (i = 0; i < len; i++) + data[i] = rcar_i2c_raw_read(dev, chip, addr + i); + + return 0; +} + +static int rcar_i2c_write(struct i2c_adapter *adap, uint8_t chip, uint addr, + int alen, u8 *data, int len) +{ + struct rcar_i2c *dev = (struct rcar_i2c *)i2c_dev[adap->hwadapnr]; + return rcar_i2c_raw_write(dev, chip, addr, data, len); +} + +static int +rcar_i2c_probe(struct i2c_adapter *adap, u8 dev) +{ + return rcar_i2c_read(adap, dev, 0, 0, NULL, 0); +} + +static unsigned int rcar_i2c_set_bus_speed(struct i2c_adapter *adap, + unsigned int speed) +{ + struct rcar_i2c *dev = (struct rcar_i2c *)i2c_dev[adap->hwadapnr]; + u32 icccr; + int ret = 0; + + rcar_i2c_raw_rw_finish(dev); + + icccr = rcar_clock_gen(adap->hwadapnr, speed); + if (icccr == 0) { + puts("I2C: Init failed\n"); + ret = -1; + } else { + writel(icccr, &dev->icccr); + } + return ret; +} + +/* + * Register RCAR i2c adapters + */ +U_BOOT_I2C_ADAP_COMPLETE(rcar_0, rcar_i2c_init, rcar_i2c_probe, rcar_i2c_read, + rcar_i2c_write, rcar_i2c_set_bus_speed, + CONFIG_SYS_RCAR_I2C0_SPEED, 0, 0) +U_BOOT_I2C_ADAP_COMPLETE(rcar_1, rcar_i2c_init, rcar_i2c_probe, rcar_i2c_read, + rcar_i2c_write, rcar_i2c_set_bus_speed, + CONFIG_SYS_RCAR_I2C1_SPEED, 0, 1) +U_BOOT_I2C_ADAP_COMPLETE(rcar_2, rcar_i2c_init, rcar_i2c_probe, rcar_i2c_read, + rcar_i2c_write, rcar_i2c_set_bus_speed, + CONFIG_SYS_RCAR_I2C2_SPEED, 0, 2) +U_BOOT_I2C_ADAP_COMPLETE(rcar_3, rcar_i2c_init, rcar_i2c_probe, rcar_i2c_read, + rcar_i2c_write, rcar_i2c_set_bus_speed, + CONFIG_SYS_RCAR_I2C3_SPEED, 0, 3) -- 1.8.4.rc3

2 2

Re: [U-Boot] [PATCH 1/1] am33xx: add CONFIG_SYS_NAND_DEVICE_WIDTH to determine NAND device bus-width
by Gupta, Pekon 27 Sep '13

27 Sep '13

> From: Scott Wood [mailto:scottwood@freescale.com] > > On Thu, 2013-09-26 at 13:14 +0000, Gupta, Pekon wrote: > > > > From: Gupta, Pekon <pekon(a)ti.com> > > > > > > > > NAND driver needs to know bus-width of the connected NAND device, > in > > > order to perform proper I/O and initialize itself. Currently there is no > CONFIG > > > option to provide this information to NAND driver. > > > > - SPL NAND driver does not have framework to parse ONFI parameter > > > page. > > > > > > Is this about SPL? It looks like a more general change. > > > > > Yes, actually I would have loved to see a generic SPL driver for all platforms, > > How could that possibly work? > NAND SPL (as in drivers/mtd/nand/am335x_spl_bch.c) had following limitation (a) depends on CONFIG_SYS_NAND_xx (for NAND device parameters like erasesize, pagesize, oobsize, etc). (b) can only do NAND read access. (c) calls nand_chip->ecc.hwctl() for doing controller specific configurations, which is populated while doing board_nand_init(). Above (a), (b), and (c) do not have any SoC specific dependency. And can be put into a generic framework which can be used for all SPL drivers. All SoC specific configurations are done in either: - board_nand_init(): initializations based on device. - nand_chip->ecc.hwctl(): configurations for ECC scheme. which is *shared* code between SPL & u-boot driver, and is present in u-boot driver file (like drivers/mtd/nand/omap_gpmc.c), not in SPL driver file. The missing piece was device bus-width detection which I addresses in this patch by adding CONFIG_SYS_NAND_DEVICE_WIDTH. > > because SPL is mostly statically configured, and it just does plain NAND read > > (it doesn’t even support NAND write, etc). > > But I do not know the hardware configurations tweaks of other SoC, > > So at-least have common CONFIG_SYS_NAND_xx which all SPL drivers can > use. > > Again, are you introducing this symbol for use only in SPL? Apart from SPL, CONFIG_SYS_NAND_DEVICE_WIDTH also be useful for (1) drivers which do not use CONFIG_SYS_NAND_ONFI_DETECTION, where code for reading on-chip ONFI parameters is not enabled in nand_base.c (2) non ONFI compatible NAND devices. > It looked > like you were removing the code that does dynamic detection, which would > also affect non-SPL. > > > - /* If we are 16 bit dev, our gpmc config tells us that */ > > - if ((readl(&gpmc_cfg->cs[cs].config1) & 0x3000) == 0x1000) omap_gpmc.c never had dynamic detection support. Above gpmc_config bit which is used to tell whether device is x16 or x8, gets actually hard-coded in gpmc_init(). Thus it was actually a mechanism to pass hard-coded bus-width information to nand driver. Refer: arch/arm/cpu/armv7/am33xx/mem.c : gpmc_init() So, instead of hacking the gpmc_init() everytime for different devices, this patch introduces a generic CONFIG which can be used everywhere. I have sent this patch separately to see the acceptance of new generic CONFIG_SYS_NAND_DEVICE_WIDTH. If this gets accepted, then I'll resend the patch-series which actually does dynamic detection.. http://lists.denx.de/pipermail/u-boot/2013-September/162295.html http://lists.denx.de/pipermail/u-boot/2013-September/162296.html (dropping others in CC list as u-boot maillist rejects the mail saying too many recipients. !! ) with regards, pekon

1 0

[U-Boot] [PATCH v4] sf: probe: Add support for S25FL* flash parts
by Jagannadha Sutradharudu Teki 27 Sep '13

27 Sep '13

Added S25FL* parts are which are avilable in spi_flash_probe_legacy.c. Updated the sector_size attributes as per the flash parts. Looks fine for with this sector_size for computing the size of flash. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v4: - Update the ext_jedec detection Changes for v3: - none Changes for v2: - Enable CONFIG_SPI_FLASH_SPANSION drivers/mtd/spi/spi_flash_probe.c | 31 +- dump | 1182 +++++++++++++++++++++++++++++++++++++ 2 files changed, 1207 insertions(+), 6 deletions(-) create mode 100644 dump diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index a8ce358..283e3ea 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -53,6 +53,19 @@ static const struct spi_flash_params spi_flash_params_table[] = { {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256}, #endif +#ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ + {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16}, + {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32}, + {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64}, + {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128}, + {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64}, + {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256}, + {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64}, + {"S25FL064P", 0x010216, 0x4d00, 64 * 1024, 128}, + {"S25FL128S_64K", 0x012018, 0x4d01, 64 * 1024, 256}, + {"S25FL256S_64K", 0x010219, 0x4d01, 64 * 1024, 512}, + {"S25FL512S_64K", 0x010220, 0x4d01, 64 * 1024, 1024}, +#endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */ {"M25P10", 0x202011, 0x0, 32 * 1024, 4}, {"M25P20", 0x202012, 0x0, 64 * 1024, 4}, @@ -98,6 +111,7 @@ static const struct spi_flash_params spi_flash_params_table[] = { /* * Note: * Below paired flash devices has similar spi_flash_params params. + * (S25FL129P_64K, S25FL128S_64K) * (W25Q80BL, W25Q80BV) * (W25Q16CL, W25Q16DV) * (W25Q32BV, W25Q32FV_SPI) @@ -111,7 +125,6 @@ static const struct spi_flash_params spi_flash_params_table[] = { * TODO: * ATMEL * RAMTRON - * SPANSION * SST */ }; @@ -122,19 +135,25 @@ struct spi_flash *spi_flash_validate_ids(struct spi_slave *spi, u8 *idcode) struct spi_flash *flash; int i; u16 jedec = idcode[1] << 8 | idcode[2]; + u16 ext_jedec = idcode[3] << 8 | idcode[4]; - /* Get the flash id (jedec = manuf_id + dev_id) */ + /* Get the flash id (jedec = manuf_id + dev_id, ext_jedec) */ for (i = 0; i < ARRAY_SIZE(spi_flash_params_table); i++) { params = &spi_flash_params_table[i]; if ((params->jedec >> 16) == idcode[0]) { - if ((params->jedec & 0xFFFF) == jedec) - break; + if ((params->jedec & 0xFFFF) == jedec) { + if (params->ext_jedec == 0) + break; + else if (params->ext_jedec == ext_jedec) + break; + } } } if (i == ARRAY_SIZE(spi_flash_params_table)) { - printf("SF: Unsupported flash ID: manuf %02x, jedec %04x\n", - idcode[0], jedec); + printf("SF: Unsupported flash IDs: "); + printf("manuf %02x, jedec %04x, ext_jedec %04x\n", + idcode[0], jedec, ext_jedec); return NULL; } diff --git a/dump b/dump new file mode 100644 index 0000000..fb4ac4f --- /dev/null +++ b/dump @@ -0,0 +1,1182 @@ +WARNING: line over 80 characters +#872: FILE: drivers/mtd/spi/spi_flash_ops.c:228: ++ debug("PP: 0x%p => cmd = { 0x%02x 0x%02x%02x%02x } chunk_len = %zu\n", + +total: 0 errors, 1 warnings, 0 checks, 1190 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0001-sf-Divide-spi_flash-into-multiple-parts.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +total: 0 errors, 0 warnings, 0 checks, 575 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0002-sf-probe-Add-new-spi_flash_probe-support.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 21 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0003-sf-probe-Add-support-for-M25P-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 17 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0004-sf-probe-Add-support-for-EN25Q-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 17 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0005-sf-probe-Add-support-for-GD25-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 22 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0006-sf-probe-Add-support-for-MX25L-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 45 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0007-sf-probe-Add-support-for-W25-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 62 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0008-sf-probe-Add-support-for-S25FL-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 25 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0009-sf-probe-Add-support-for-SST25-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 22 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0010-sf-probe-Add-support-for-AT45DB-flash-parts.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 174 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0011-sf-probe-Give-proper-spacing-on-flash-table-params.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 316 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0012-sf-probe-Add-support-for-SST_WP.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 23 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0013-sf-probe-Add-support-to-clear-flash-BP-bits.patch has no obvious style problems and is ready for submission. +WARNING: line over 80 characters +#56: FILE: drivers/mtd/spi/spi_flash_probe.c:42: ++ {"AT45DB011D", 0x1f2200, 0x0, 64 * 1024, 4, SECT_4K}, + +WARNING: line over 80 characters +#57: FILE: drivers/mtd/spi/spi_flash_probe.c:43: ++ {"AT45DB021D", 0x1f2300, 0x0, 64 * 1024, 8, SECT_4K}, + +WARNING: line over 80 characters +#58: FILE: drivers/mtd/spi/spi_flash_probe.c:44: ++ {"AT45DB041D", 0x1f2400, 0x0, 64 * 1024, 8, SECT_4K}, + +WARNING: line over 80 characters +#59: FILE: drivers/mtd/spi/spi_flash_probe.c:45: ++ {"AT45DB081D", 0x1f2500, 0x0, 64 * 1024, 16, SECT_4K}, + +WARNING: line over 80 characters +#60: FILE: drivers/mtd/spi/spi_flash_probe.c:46: ++ {"AT45DB161D", 0x1f2600, 0x0, 64 * 1024, 32, SECT_4K}, + +WARNING: line over 80 characters +#61: FILE: drivers/mtd/spi/spi_flash_probe.c:47: ++ {"AT45DB321D", 0x1f2700, 0x0, 64 * 1024, 64, SECT_4K}, + +WARNING: line over 80 characters +#62: FILE: drivers/mtd/spi/spi_flash_probe.c:48: ++ {"AT45DB641D", 0x1f2800, 0x0, 64 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#67: FILE: drivers/mtd/spi/spi_flash_probe.c:51: ++ {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#68: FILE: drivers/mtd/spi/spi_flash_probe.c:52: ++ {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, 0}, + +WARNING: line over 80 characters +#73: FILE: drivers/mtd/spi/spi_flash_probe.c:55: ++ {"GD25Q64B", 0xc84017, 0x0, 64 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#74: FILE: drivers/mtd/spi/spi_flash_probe.c:56: ++ {"GD25LQ32", 0xc86016, 0x0, 64 * 1024, 64, SECT_4K}, + +WARNING: line over 80 characters +#84: FILE: drivers/mtd/spi/spi_flash_probe.c:59: ++ {"MX25L4005", 0xc22013, 0x0, 64 * 1024, 8, 0}, + +WARNING: line over 80 characters +#85: FILE: drivers/mtd/spi/spi_flash_probe.c:60: ++ {"MX25L8005", 0xc22014, 0x0, 64 * 1024, 16, 0}, + +WARNING: line over 80 characters +#86: FILE: drivers/mtd/spi/spi_flash_probe.c:61: ++ {"MX25L1605D", 0xc22015, 0x0, 64 * 1024, 32, 0}, + +WARNING: line over 80 characters +#87: FILE: drivers/mtd/spi/spi_flash_probe.c:62: ++ {"MX25L3205D", 0xc22016, 0x0, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#88: FILE: drivers/mtd/spi/spi_flash_probe.c:63: ++ {"MX25L6405D", 0xc22017, 0x0, 64 * 1024, 128, 0}, + +WARNING: line over 80 characters +#89: FILE: drivers/mtd/spi/spi_flash_probe.c:64: ++ {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256, 0}, + +WARNING: line over 80 characters +#90: FILE: drivers/mtd/spi/spi_flash_probe.c:65: ++ {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, 0}, + +WARNING: line over 80 characters +#104: FILE: drivers/mtd/spi/spi_flash_probe.c:68: ++ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0}, + +WARNING: line over 80 characters +#105: FILE: drivers/mtd/spi/spi_flash_probe.c:69: ++ {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0}, + +WARNING: line over 80 characters +#106: FILE: drivers/mtd/spi/spi_flash_probe.c:70: ++ {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#107: FILE: drivers/mtd/spi/spi_flash_probe.c:71: ++ {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0}, + +WARNING: line over 80 characters +#108: FILE: drivers/mtd/spi/spi_flash_probe.c:72: ++ {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, 0}, + +WARNING: line over 80 characters +#109: FILE: drivers/mtd/spi/spi_flash_probe.c:73: ++ {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, 0}, + +WARNING: line over 80 characters +#110: FILE: drivers/mtd/spi/spi_flash_probe.c:74: ++ {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#111: FILE: drivers/mtd/spi/spi_flash_probe.c:75: ++ {"S25FL064P", 0x010216, 0x4d00, 64 * 1024, 128, 0}, + +WARNING: line over 80 characters +#112: FILE: drivers/mtd/spi/spi_flash_probe.c:76: ++ {"S25FL128S_64K", 0x012018, 0x4d01, 64 * 1024, 256, 0}, + +WARNING: line over 80 characters +#113: FILE: drivers/mtd/spi/spi_flash_probe.c:77: ++ {"S25FL256S_64K", 0x010219, 0x4d01, 64 * 1024, 512, 0}, + +WARNING: line over 80 characters +#114: FILE: drivers/mtd/spi/spi_flash_probe.c:78: ++ {"S25FL512S_64K", 0x010220, 0x4d01, 64 * 1024, 1024, 0}, + +WARNING: line over 80 characters +#137: FILE: drivers/mtd/spi/spi_flash_probe.c:81: ++ {"M25P10", 0x202011, 0x0, 32 * 1024, 4, 0}, + +WARNING: line over 80 characters +#138: FILE: drivers/mtd/spi/spi_flash_probe.c:82: ++ {"M25P20", 0x202012, 0x0, 64 * 1024, 4, 0}, + +WARNING: line over 80 characters +#139: FILE: drivers/mtd/spi/spi_flash_probe.c:83: ++ {"M25P40", 0x202013, 0x0, 64 * 1024, 8, 0}, + +WARNING: line over 80 characters +#140: FILE: drivers/mtd/spi/spi_flash_probe.c:84: ++ {"M25P80", 0x202014, 0x0, 64 * 1024, 16, 0}, + +WARNING: line over 80 characters +#141: FILE: drivers/mtd/spi/spi_flash_probe.c:85: ++ {"M25P16", 0x202015, 0x0, 64 * 1024, 32, 0}, + +WARNING: line over 80 characters +#142: FILE: drivers/mtd/spi/spi_flash_probe.c:86: ++ {"M25P32", 0x202016, 0x0, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#143: FILE: drivers/mtd/spi/spi_flash_probe.c:87: ++ {"M25P64", 0x202017, 0x0, 64 * 1024, 128, 0}, + +WARNING: line over 80 characters +#144: FILE: drivers/mtd/spi/spi_flash_probe.c:88: ++ {"M25P128", 0x202018, 0x0, 256 * 1024, 64, 0}, + +WARNING: line over 80 characters +#145: FILE: drivers/mtd/spi/spi_flash_probe.c:89: ++ {"N25Q32", 0x20ba16, 0x0, 64 * 1024, 64, SECT_4K}, + +WARNING: line over 80 characters +#146: FILE: drivers/mtd/spi/spi_flash_probe.c:90: ++ {"N25Q32A", 0x20bb16, 0x0, 64 * 1024, 64, SECT_4K}, + +WARNING: line over 80 characters +#147: FILE: drivers/mtd/spi/spi_flash_probe.c:91: ++ {"N25Q64", 0x20ba17, 0x0, 64 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#148: FILE: drivers/mtd/spi/spi_flash_probe.c:92: ++ {"N25Q64A", 0x20bb17, 0x0, 64 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#149: FILE: drivers/mtd/spi/spi_flash_probe.c:93: ++ {"N25Q128", 0x20ba18, 0x0, 64 * 1024, 256, SECT_4K}, + +WARNING: line over 80 characters +#150: FILE: drivers/mtd/spi/spi_flash_probe.c:94: ++ {"N25Q128A", 0x20bb18, 0x0, 64 * 1024, 256, SECT_4K}, + +WARNING: line over 80 characters +#151: FILE: drivers/mtd/spi/spi_flash_probe.c:95: ++ {"N25Q256", 0x20ba19, 0x0, 64 * 1024, 512, SECT_4K}, + +WARNING: line over 80 characters +#152: FILE: drivers/mtd/spi/spi_flash_probe.c:96: ++ {"N25Q256A", 0x20bb19, 0x0, 64 * 1024, 512, SECT_4K}, + +WARNING: line over 80 characters +#153: FILE: drivers/mtd/spi/spi_flash_probe.c:97: ++ {"N25Q512", 0x20ba20, 0x0, 64 * 1024, 1024, SECT_4K}, + +WARNING: line over 80 characters +#154: FILE: drivers/mtd/spi/spi_flash_probe.c:98: ++ {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, SECT_4K}, + +WARNING: line over 80 characters +#155: FILE: drivers/mtd/spi/spi_flash_probe.c:99: ++ {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, SECT_4K}, + +WARNING: line over 80 characters +#156: FILE: drivers/mtd/spi/spi_flash_probe.c:100: ++ {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, SECT_4K}, + +WARNING: line over 80 characters +#169: FILE: drivers/mtd/spi/spi_flash_probe.c:103: ++ {"SST25VF040B", 0xbf258d, 0x0, 64 * 1024, 8, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#170: FILE: drivers/mtd/spi/spi_flash_probe.c:104: ++ {"SST25VF080B", 0xbf258e, 0x0, 64 * 1024, 16, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#171: FILE: drivers/mtd/spi/spi_flash_probe.c:105: ++ {"SST25VF016B", 0xbf2541, 0x0, 64 * 1024, 32, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#172: FILE: drivers/mtd/spi/spi_flash_probe.c:106: ++ {"SST25VF032B", 0xbf254a, 0x0, 64 * 1024, 64, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#173: FILE: drivers/mtd/spi/spi_flash_probe.c:107: ++ {"SST25VF064C", 0xbf254b, 0x0, 64 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#174: FILE: drivers/mtd/spi/spi_flash_probe.c:108: ++ {"SST25WF512", 0xbf2501, 0x0, 64 * 1024, 1, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#175: FILE: drivers/mtd/spi/spi_flash_probe.c:109: ++ {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#176: FILE: drivers/mtd/spi/spi_flash_probe.c:110: ++ {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#177: FILE: drivers/mtd/spi/spi_flash_probe.c:111: ++ {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#178: FILE: drivers/mtd/spi/spi_flash_probe.c:112: ++ {"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#199: FILE: drivers/mtd/spi/spi_flash_probe.c:115: ++ {"W25P80", 0xef2014, 0x0, 64 * 1024, 16, 0}, + +WARNING: line over 80 characters +#200: FILE: drivers/mtd/spi/spi_flash_probe.c:116: ++ {"W25P16", 0xef2015, 0x0, 64 * 1024, 32, 0}, + +WARNING: line over 80 characters +#201: FILE: drivers/mtd/spi/spi_flash_probe.c:117: ++ {"W25P32", 0xef2016, 0x0, 64 * 1024, 64, 0}, + +WARNING: line over 80 characters +#202: FILE: drivers/mtd/spi/spi_flash_probe.c:118: ++ {"W25X40", 0xef3013, 0x0, 4 * 1024, 128, SECT_4K}, + +WARNING: line over 80 characters +#203: FILE: drivers/mtd/spi/spi_flash_probe.c:119: ++ {"W25X16", 0xef3015, 0x0, 4 * 1024, 512, SECT_4K}, + +WARNING: line over 80 characters +#204: FILE: drivers/mtd/spi/spi_flash_probe.c:120: ++ {"W25X32", 0xef3016, 0x0, 4 * 1024, 1024, SECT_4K}, + +WARNING: line over 80 characters +#205: FILE: drivers/mtd/spi/spi_flash_probe.c:121: ++ {"W25X64", 0xef3017, 0x0, 4 * 1024, 2048, SECT_4K}, + +WARNING: line over 80 characters +#206: FILE: drivers/mtd/spi/spi_flash_probe.c:122: ++ {"W25Q80BL", 0xef4014, 0x0, 4 * 1024, 256, SECT_4K}, + +WARNING: line over 80 characters +#207: FILE: drivers/mtd/spi/spi_flash_probe.c:123: ++ {"W25Q16CL", 0xef4015, 0x0, 4 * 1024, 512, SECT_4K}, + +WARNING: line over 80 characters +#208: FILE: drivers/mtd/spi/spi_flash_probe.c:124: ++ {"W25Q32BV", 0xef4016, 0x0, 4 * 1024, 1024, SECT_4K}, + +WARNING: line over 80 characters +#209: FILE: drivers/mtd/spi/spi_flash_probe.c:125: ++ {"W25Q64CV", 0xef4017, 0x0, 4 * 1024, 2048, SECT_4K}, + +WARNING: line over 80 characters +#210: FILE: drivers/mtd/spi/spi_flash_probe.c:126: ++ {"W25Q128BV", 0xef4018, 0x0, 4 * 1024, 4096, SECT_4K}, + +WARNING: line over 80 characters +#211: FILE: drivers/mtd/spi/spi_flash_probe.c:127: ++ {"W25Q256", 0xef4019, 0x0, 4 * 1024, 8192, SECT_4K}, + +WARNING: line over 80 characters +#212: FILE: drivers/mtd/spi/spi_flash_probe.c:128: ++ {"W25Q80BW", 0xef5014, 0x0, 4 * 1024, 256, SECT_4K}, + +WARNING: line over 80 characters +#213: FILE: drivers/mtd/spi/spi_flash_probe.c:129: ++ {"W25Q16DW", 0xef6015, 0x0, 4 * 1024, 512, SECT_4K}, + +WARNING: line over 80 characters +#214: FILE: drivers/mtd/spi/spi_flash_probe.c:130: ++ {"W25Q32DW", 0xef6016, 0x0, 4 * 1024, 1024, SECT_4K}, + +WARNING: line over 80 characters +#215: FILE: drivers/mtd/spi/spi_flash_probe.c:131: ++ {"W25Q64DW", 0xef6017, 0x0, 4 * 1024, 2048, SECT_4K}, + +WARNING: line over 80 characters +#216: FILE: drivers/mtd/spi/spi_flash_probe.c:132: ++ {"W25Q128FW", 0xef6018, 0x0, 4 * 1024, 4096, SECT_4K}, + +total: 0 errors, 77 warnings, 0 checks, 240 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0014-sf-probe-Add-support-for-erase-sector-selection-flag.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +WARNING: line over 80 characters +#28: FILE: drivers/mtd/spi/spi_flash_probe.c:97: ++ {"N25Q512", 0x20ba20, 0x0, 64 * 1024, 1024, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#29: FILE: drivers/mtd/spi/spi_flash_probe.c:98: ++ {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#30: FILE: drivers/mtd/spi/spi_flash_probe.c:99: ++ {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#31: FILE: drivers/mtd/spi/spi_flash_probe.c:100: ++ {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, E_FSR | SECT_4K}, + +total: 0 errors, 4 warnings, 0 checks, 39 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0015-sf-probe-Add-support-for-flag-status-polling.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +total: 0 errors, 0 warnings, 0 checks, 75 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0016-sf-probe-Move-BAR-config-to-spi_flash_validate_ids.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 74 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0017-sf-Add-proper-comment-style-on-spi_flash-structure.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 166 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0018-sf-ramtron-Add-support-for-separate-flash-driver.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 17 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0019-sf-Remove-unneeded-flash-drivers-files.patch has no obvious style problems and is ready for submission. +WARNING: line over 80 characters +#21: FILE: drivers/mtd/spi/spi_flash_probe.c:52: ++ {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, SECT_4K}, + +total: 0 errors, 1 warnings, 0 checks, 7 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0020-sf-probe-Add-support-for-EN25Q64.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +WARNING: line over 80 characters +#21: FILE: drivers/mtd/spi/spi_flash_probe.c:78: ++ {"S25FL256S_256K", 0x010219, 0x4d00, 64 * 1024, 512, 0}, + +total: 0 errors, 1 warnings, 0 checks, 15 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0021-sf-probe-Add-support-for-S25FL256S_256K.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +WARNING: line over 80 characters +#21: FILE: drivers/mtd/spi/spi_flash_probe.c:80: ++ {"S25FL512S_256K", 0x010220, 0x4d00, 64 * 1024, 1024, 0}, + +total: 0 errors, 1 warnings, 0 checks, 7 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0022-sf-probe-Add-support-for-S25FL512S_256K.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +total: 0 errors, 0 warnings, 0 checks, 8 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0023-sf-probe-Use-print_size-arg-as-page_size.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 9 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0024-sf-probe-Print-erase_size-while-printing-flash-detai.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 91 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0025-sf-probe-Simply-the-BAR-configuration-logic.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 19 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0026-sf-ops-Add-static-qualifier-to-spi_flash_cmd_bankadd.patch has no obvious style problems and is ready for submission. +WARNING: line over 80 characters +#21: FILE: drivers/mtd/spi/spi_flash_probe.c:66: ++ {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, 0}, + +total: 0 errors, 1 warnings, 0 checks, 7 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0027-sf-probe-Add-support-for-MX25L25635F.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +WARNING: line over 80 characters +#21: FILE: drivers/mtd/spi/spi_flash_probe.c:67: ++ {"MX25L51235F", 0xc2201A, 0x0, 64 * 1024, 1024, 0}, + +total: 0 errors, 1 warnings, 0 checks, 7 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0028-sf-probe-Add-support-for-MX25L51235F.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +total: 0 errors, 0 warnings, 0 checks, 44 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0029-sf-Remove-spi_flash_do_alloc-references.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 27 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0030-doc-SPI-Add-status.txt-for-tracking-SPI-subsys-statu.patch has no obvious style problems and is ready for submission. +WARNING: line over 80 characters +#97: FILE: drivers/mtd/spi/spi_flash_probe.c:51: ++ {"AT45DB011D", 0x1f2200, 0x0, 64 * 1024, 4, 0, SECT_4K}, + +WARNING: line over 80 characters +#98: FILE: drivers/mtd/spi/spi_flash_probe.c:52: ++ {"AT45DB021D", 0x1f2300, 0x0, 64 * 1024, 8, 0, SECT_4K}, + +WARNING: line over 80 characters +#99: FILE: drivers/mtd/spi/spi_flash_probe.c:53: ++ {"AT45DB041D", 0x1f2400, 0x0, 64 * 1024, 8, 0, SECT_4K}, + +WARNING: line over 80 characters +#100: FILE: drivers/mtd/spi/spi_flash_probe.c:54: ++ {"AT45DB081D", 0x1f2500, 0x0, 64 * 1024, 16, 0, SECT_4K}, + +WARNING: line over 80 characters +#101: FILE: drivers/mtd/spi/spi_flash_probe.c:55: ++ {"AT45DB161D", 0x1f2600, 0x0, 64 * 1024, 32, 0, SECT_4K}, + +WARNING: line over 80 characters +#102: FILE: drivers/mtd/spi/spi_flash_probe.c:56: ++ {"AT45DB321D", 0x1f2700, 0x0, 64 * 1024, 64, 0, SECT_4K}, + +WARNING: line over 80 characters +#103: FILE: drivers/mtd/spi/spi_flash_probe.c:57: ++ {"AT45DB641D", 0x1f2800, 0x0, 64 * 1024, 128, 0, SECT_4K}, + +WARNING: line over 80 characters +#109: FILE: drivers/mtd/spi/spi_flash_probe.c:60: ++ {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#110: FILE: drivers/mtd/spi/spi_flash_probe.c:61: ++ {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, 0, SECT_4K}, + +WARNING: line over 80 characters +#111: FILE: drivers/mtd/spi/spi_flash_probe.c:62: ++ {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, 0, 0}, + +WARNING: line over 80 characters +#116: FILE: drivers/mtd/spi/spi_flash_probe.c:65: ++ {"GD25Q64B", 0xc84017, 0x0, 64 * 1024, 128, 0, SECT_4K}, + +WARNING: line over 80 characters +#117: FILE: drivers/mtd/spi/spi_flash_probe.c:66: ++ {"GD25LQ32", 0xc86016, 0x0, 64 * 1024, 64, 0, SECT_4K}, + +WARNING: line over 80 characters +#129: FILE: drivers/mtd/spi/spi_flash_probe.c:69: ++ {"MX25L4005", 0xc22013, 0x0, 64 * 1024, 8, 0, 0}, + +WARNING: line over 80 characters +#130: FILE: drivers/mtd/spi/spi_flash_probe.c:70: ++ {"MX25L8005", 0xc22014, 0x0, 64 * 1024, 16, 0, 0}, + +WARNING: line over 80 characters +#131: FILE: drivers/mtd/spi/spi_flash_probe.c:71: ++ {"MX25L1605D", 0xc22015, 0x0, 64 * 1024, 32, 0, 0}, + +WARNING: line over 80 characters +#132: FILE: drivers/mtd/spi/spi_flash_probe.c:72: ++ {"MX25L3205D", 0xc22016, 0x0, 64 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#133: FILE: drivers/mtd/spi/spi_flash_probe.c:73: ++ {"MX25L6405D", 0xc22017, 0x0, 64 * 1024, 128, 0, 0}, + +WARNING: line over 80 characters +#134: FILE: drivers/mtd/spi/spi_flash_probe.c:74: ++ {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256, 0, 0}, + +WARNING: line over 80 characters +#135: FILE: drivers/mtd/spi/spi_flash_probe.c:75: ++ {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, 0, 0}, + +WARNING: line over 80 characters +#151: FILE: drivers/mtd/spi/spi_flash_probe.c:78: ++ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0, 0}, + +WARNING: line over 80 characters +#152: FILE: drivers/mtd/spi/spi_flash_probe.c:79: ++ {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0}, + +WARNING: line over 80 characters +#153: FILE: drivers/mtd/spi/spi_flash_probe.c:80: ++ {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#154: FILE: drivers/mtd/spi/spi_flash_probe.c:81: ++ {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, + +WARNING: line over 80 characters +#155: FILE: drivers/mtd/spi/spi_flash_probe.c:82: ++ {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#156: FILE: drivers/mtd/spi/spi_flash_probe.c:83: ++ {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#157: FILE: drivers/mtd/spi/spi_flash_probe.c:84: ++ {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#158: FILE: drivers/mtd/spi/spi_flash_probe.c:85: ++ {"S25FL064P", 0x010216, 0x4d00, 64 * 1024, 128, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#159: FILE: drivers/mtd/spi/spi_flash_probe.c:86: ++ {"S25FL128S_64K", 0x012018, 0x4d01, 64 * 1024, 256, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#160: FILE: drivers/mtd/spi/spi_flash_probe.c:87: ++ {"S25FL256S_64K", 0x010219, 0x4d01, 64 * 1024, 512, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#161: FILE: drivers/mtd/spi/spi_flash_probe.c:88: ++ {"S25FL512S_64K", 0x010220, 0x4d01, 64 * 1024, 1024, RD_CMD_FULL, 0}, + +WARNING: line over 80 characters +#184: FILE: drivers/mtd/spi/spi_flash_probe.c:91: ++ {"M25P10", 0x202011, 0x0, 32 * 1024, 4, 0, 0}, + +WARNING: line over 80 characters +#185: FILE: drivers/mtd/spi/spi_flash_probe.c:92: ++ {"M25P20", 0x202012, 0x0, 64 * 1024, 4, 0, 0}, + +WARNING: line over 80 characters +#186: FILE: drivers/mtd/spi/spi_flash_probe.c:93: ++ {"M25P40", 0x202013, 0x0, 64 * 1024, 8, 0, 0}, + +WARNING: line over 80 characters +#187: FILE: drivers/mtd/spi/spi_flash_probe.c:94: ++ {"M25P80", 0x202014, 0x0, 64 * 1024, 16, 0, 0}, + +WARNING: line over 80 characters +#188: FILE: drivers/mtd/spi/spi_flash_probe.c:95: ++ {"M25P16", 0x202015, 0x0, 64 * 1024, 32, 0, 0}, + +WARNING: line over 80 characters +#189: FILE: drivers/mtd/spi/spi_flash_probe.c:96: ++ {"M25P32", 0x202016, 0x0, 64 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#190: FILE: drivers/mtd/spi/spi_flash_probe.c:97: ++ {"M25P64", 0x202017, 0x0, 64 * 1024, 128, 0, 0}, + +WARNING: line over 80 characters +#191: FILE: drivers/mtd/spi/spi_flash_probe.c:98: ++ {"M25P128", 0x202018, 0x0, 256 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#192: FILE: drivers/mtd/spi/spi_flash_probe.c:99: ++ {"N25Q32", 0x20ba16, 0x0, 64 * 1024, 64, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#193: FILE: drivers/mtd/spi/spi_flash_probe.c:100: ++ {"N25Q32A", 0x20bb16, 0x0, 64 * 1024, 64, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#194: FILE: drivers/mtd/spi/spi_flash_probe.c:101: ++ {"N25Q64", 0x20ba17, 0x0, 64 * 1024, 128, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#195: FILE: drivers/mtd/spi/spi_flash_probe.c:102: ++ {"N25Q64A", 0x20bb17, 0x0, 64 * 1024, 128, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#196: FILE: drivers/mtd/spi/spi_flash_probe.c:103: ++ {"N25Q128", 0x20ba18, 0x0, 64 * 1024, 256, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#197: FILE: drivers/mtd/spi/spi_flash_probe.c:104: ++ {"N25Q128A", 0x20bb18, 0x0, 64 * 1024, 256, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#198: FILE: drivers/mtd/spi/spi_flash_probe.c:105: ++ {"N25Q256", 0x20ba19, 0x0, 64 * 1024, 512, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#199: FILE: drivers/mtd/spi/spi_flash_probe.c:106: ++ {"N25Q256A", 0x20bb19, 0x0, 64 * 1024, 512, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#200: FILE: drivers/mtd/spi/spi_flash_probe.c:107: ++ {"N25Q512", 0x20ba20, 0x0, 64 * 1024, 1024, RD_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#201: FILE: drivers/mtd/spi/spi_flash_probe.c:108: ++ {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#202: FILE: drivers/mtd/spi/spi_flash_probe.c:109: ++ {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#203: FILE: drivers/mtd/spi/spi_flash_probe.c:110: ++ {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#216: FILE: drivers/mtd/spi/spi_flash_probe.c:113: ++ {"SST25VF040B", 0xbf258d, 0x0, 64 * 1024, 8, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#217: FILE: drivers/mtd/spi/spi_flash_probe.c:114: ++ {"SST25VF080B", 0xbf258e, 0x0, 64 * 1024, 16, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#218: FILE: drivers/mtd/spi/spi_flash_probe.c:115: ++ {"SST25VF016B", 0xbf2541, 0x0, 64 * 1024, 32, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#219: FILE: drivers/mtd/spi/spi_flash_probe.c:116: ++ {"SST25VF032B", 0xbf254a, 0x0, 64 * 1024, 64, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#220: FILE: drivers/mtd/spi/spi_flash_probe.c:117: ++ {"SST25VF064C", 0xbf254b, 0x0, 64 * 1024, 128, 0 SECT_4K}, + +WARNING: line over 80 characters +#221: FILE: drivers/mtd/spi/spi_flash_probe.c:118: ++ {"SST25WF512", 0xbf2501, 0x0, 64 * 1024, 1, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#222: FILE: drivers/mtd/spi/spi_flash_probe.c:119: ++ {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#223: FILE: drivers/mtd/spi/spi_flash_probe.c:120: ++ {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#224: FILE: drivers/mtd/spi/spi_flash_probe.c:121: ++ {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#225: FILE: drivers/mtd/spi/spi_flash_probe.c:122: ++ {"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#246: FILE: drivers/mtd/spi/spi_flash_probe.c:125: ++ {"W25P80", 0xef2014, 0x0, 64 * 1024, 16, 0, 0}, + +WARNING: line over 80 characters +#247: FILE: drivers/mtd/spi/spi_flash_probe.c:126: ++ {"W25P16", 0xef2015, 0x0, 64 * 1024, 32, 0, 0}, + +WARNING: line over 80 characters +#248: FILE: drivers/mtd/spi/spi_flash_probe.c:127: ++ {"W25P32", 0xef2016, 0x0, 64 * 1024, 64, 0, 0}, + +WARNING: line over 80 characters +#249: FILE: drivers/mtd/spi/spi_flash_probe.c:128: ++ {"W25X40", 0xef3013, 0x0, 4 * 1024, 128, 0, SECT_4K}, + +WARNING: line over 80 characters +#250: FILE: drivers/mtd/spi/spi_flash_probe.c:129: ++ {"W25X16", 0xef3015, 0x0, 4 * 1024, 512, 0, SECT_4K}, + +WARNING: line over 80 characters +#251: FILE: drivers/mtd/spi/spi_flash_probe.c:130: ++ {"W25X32", 0xef3016, 0x0, 4 * 1024, 1024, 0, SECT_4K}, + +WARNING: line over 80 characters +#252: FILE: drivers/mtd/spi/spi_flash_probe.c:131: ++ {"W25X64", 0xef3017, 0x0, 4 * 1024, 2048, 0, SECT_4K}, + +WARNING: line over 80 characters +#253: FILE: drivers/mtd/spi/spi_flash_probe.c:132: ++ {"W25Q80BL", 0xef4014, 0x0, 4 * 1024, 256, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#254: FILE: drivers/mtd/spi/spi_flash_probe.c:133: ++ {"W25Q16CL", 0xef4015, 0x0, 4 * 1024, 512, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#255: FILE: drivers/mtd/spi/spi_flash_probe.c:134: ++ {"W25Q32BV", 0xef4016, 0x0, 4 * 1024, 1024, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#256: FILE: drivers/mtd/spi/spi_flash_probe.c:135: ++ {"W25Q64CV", 0xef4017, 0x0, 4 * 1024, 2048, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#257: FILE: drivers/mtd/spi/spi_flash_probe.c:136: ++ {"W25Q128BV", 0xef4018, 0x0, 4 * 1024, 4096, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#258: FILE: drivers/mtd/spi/spi_flash_probe.c:137: ++ {"W25Q256", 0xef4019, 0x0, 4 * 1024, 8192, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#259: FILE: drivers/mtd/spi/spi_flash_probe.c:138: ++ {"W25Q80BW", 0xef5014, 0x0, 4 * 1024, 256, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#260: FILE: drivers/mtd/spi/spi_flash_probe.c:139: ++ {"W25Q16DW", 0xef6015, 0x0, 4 * 1024, 512, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#261: FILE: drivers/mtd/spi/spi_flash_probe.c:140: ++ {"W25Q32DW", 0xef6016, 0x0, 4 * 1024, 1024, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#262: FILE: drivers/mtd/spi/spi_flash_probe.c:141: ++ {"W25Q64DW", 0xef6017, 0x0, 4 * 1024, 2048, RD_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#263: FILE: drivers/mtd/spi/spi_flash_probe.c:142: ++ {"W25Q128FW", 0xef6018, 0x0, 4 * 1024, 4096, RD_CMD_FULL, SECT_4K}, + +total: 0 errors, 78 warnings, 0 checks, 313 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0031-sf-Add-extended-read-commands-support.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +WARNING: line over 80 characters +#98: FILE: drivers/mtd/spi/spi_flash_probe.c:59: ++ {"AT45DB011D", 0x1f2200, 0x0, 64 * 1024, 4, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#99: FILE: drivers/mtd/spi/spi_flash_probe.c:60: ++ {"AT45DB021D", 0x1f2300, 0x0, 64 * 1024, 8, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#100: FILE: drivers/mtd/spi/spi_flash_probe.c:61: ++ {"AT45DB041D", 0x1f2400, 0x0, 64 * 1024, 8, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#101: FILE: drivers/mtd/spi/spi_flash_probe.c:62: ++ {"AT45DB081D", 0x1f2500, 0x0, 64 * 1024, 16, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#102: FILE: drivers/mtd/spi/spi_flash_probe.c:63: ++ {"AT45DB161D", 0x1f2600, 0x0, 64 * 1024, 32, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#103: FILE: drivers/mtd/spi/spi_flash_probe.c:64: ++ {"AT45DB321D", 0x1f2700, 0x0, 64 * 1024, 64, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#104: FILE: drivers/mtd/spi/spi_flash_probe.c:65: ++ {"AT45DB641D", 0x1f2800, 0x0, 64 * 1024, 128, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#110: FILE: drivers/mtd/spi/spi_flash_probe.c:68: ++ {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#111: FILE: drivers/mtd/spi/spi_flash_probe.c:69: ++ {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#112: FILE: drivers/mtd/spi/spi_flash_probe.c:70: ++ {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, 0, 0, 0}, + +WARNING: line over 80 characters +#117: FILE: drivers/mtd/spi/spi_flash_probe.c:73: ++ {"GD25Q64B", 0xc84017, 0x0, 64 * 1024, 128, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#118: FILE: drivers/mtd/spi/spi_flash_probe.c:74: ++ {"GD25LQ32", 0xc86016, 0x0, 64 * 1024, 64, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#128: FILE: drivers/mtd/spi/spi_flash_probe.c:77: ++ {"MX25L4005", 0xc22013, 0x0, 64 * 1024, 8, 0, 0, 0}, + +WARNING: line over 80 characters +#129: FILE: drivers/mtd/spi/spi_flash_probe.c:78: ++ {"MX25L8005", 0xc22014, 0x0, 64 * 1024, 16, 0, 0, 0}, + +WARNING: line over 80 characters +#130: FILE: drivers/mtd/spi/spi_flash_probe.c:79: ++ {"MX25L1605D", 0xc22015, 0x0, 64 * 1024, 32, 0, 0, 0}, + +WARNING: line over 80 characters +#131: FILE: drivers/mtd/spi/spi_flash_probe.c:80: ++ {"MX25L3205D", 0xc22016, 0x0, 64 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#132: FILE: drivers/mtd/spi/spi_flash_probe.c:81: ++ {"MX25L6405D", 0xc22017, 0x0, 64 * 1024, 128, 0, 0, 0}, + +WARNING: line over 80 characters +#133: FILE: drivers/mtd/spi/spi_flash_probe.c:82: ++ {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256, 0, 0, 0}, + +WARNING: line over 80 characters +#134: FILE: drivers/mtd/spi/spi_flash_probe.c:83: ++ {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, 0, 0, 0}, + +WARNING: line over 80 characters +#148: FILE: drivers/mtd/spi/spi_flash_probe.c:86: ++ {"S25FL008A", 0x010213, 0x0, 64 * 1024, 16, 0, 0, 0}, + +WARNING: line over 80 characters +#149: FILE: drivers/mtd/spi/spi_flash_probe.c:87: ++ {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0, 0}, + +WARNING: line over 80 characters +#150: FILE: drivers/mtd/spi/spi_flash_probe.c:88: ++ {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#151: FILE: drivers/mtd/spi/spi_flash_probe.c:89: ++ {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0, 0}, + +WARNING: line over 80 characters +#152: FILE: drivers/mtd/spi/spi_flash_probe.c:90: ++ {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#153: FILE: drivers/mtd/spi/spi_flash_probe.c:91: ++ {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#154: FILE: drivers/mtd/spi/spi_flash_probe.c:92: ++ {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#155: FILE: drivers/mtd/spi/spi_flash_probe.c:93: ++ {"S25FL064P", 0x010216, 0x4d00, 64 * 1024, 128, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#156: FILE: drivers/mtd/spi/spi_flash_probe.c:94: ++ {"S25FL128S_64K", 0x012018, 0x4d01, 64 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#157: FILE: drivers/mtd/spi/spi_flash_probe.c:95: ++ {"S25FL256S_64K", 0x010219, 0x4d01, 64 * 1024, 512, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#158: FILE: drivers/mtd/spi/spi_flash_probe.c:96: ++ {"S25FL512S_64K", 0x010220, 0x4d01, 64 * 1024, 1024, RD_CMD_FULL, WR_CMD_FULL, 0}, + +WARNING: line over 80 characters +#181: FILE: drivers/mtd/spi/spi_flash_probe.c:99: ++ {"M25P10", 0x202011, 0x0, 32 * 1024, 4, 0, 0, 0}, + +WARNING: line over 80 characters +#182: FILE: drivers/mtd/spi/spi_flash_probe.c:100: ++ {"M25P20", 0x202012, 0x0, 64 * 1024, 4, 0, 0, 0}, + +WARNING: line over 80 characters +#183: FILE: drivers/mtd/spi/spi_flash_probe.c:101: ++ {"M25P40", 0x202013, 0x0, 64 * 1024, 8, 0, 0, 0}, + +WARNING: line over 80 characters +#184: FILE: drivers/mtd/spi/spi_flash_probe.c:102: ++ {"M25P80", 0x202014, 0x0, 64 * 1024, 16, 0, 0, 0}, + +WARNING: line over 80 characters +#185: FILE: drivers/mtd/spi/spi_flash_probe.c:103: ++ {"M25P16", 0x202015, 0x0, 64 * 1024, 32, 0, 0, 0}, + +WARNING: line over 80 characters +#186: FILE: drivers/mtd/spi/spi_flash_probe.c:104: ++ {"M25P32", 0x202016, 0x0, 64 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#187: FILE: drivers/mtd/spi/spi_flash_probe.c:105: ++ {"M25P64", 0x202017, 0x0, 64 * 1024, 128, 0, 0, 0}, + +WARNING: line over 80 characters +#188: FILE: drivers/mtd/spi/spi_flash_probe.c:106: ++ {"M25P128", 0x202018, 0x0, 256 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#189: FILE: drivers/mtd/spi/spi_flash_probe.c:107: ++ {"N25Q32", 0x20ba16, 0x0, 64 * 1024, 64, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#190: FILE: drivers/mtd/spi/spi_flash_probe.c:108: ++ {"N25Q32A", 0x20bb16, 0x0, 64 * 1024, 64, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#191: FILE: drivers/mtd/spi/spi_flash_probe.c:109: ++ {"N25Q64", 0x20ba17, 0x0, 64 * 1024, 128, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#192: FILE: drivers/mtd/spi/spi_flash_probe.c:110: ++ {"N25Q64A", 0x20bb17, 0x0, 64 * 1024, 128, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#193: FILE: drivers/mtd/spi/spi_flash_probe.c:111: ++ {"N25Q128", 0x20ba18, 0x0, 64 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#194: FILE: drivers/mtd/spi/spi_flash_probe.c:112: ++ {"N25Q128A", 0x20bb18, 0x0, 64 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#195: FILE: drivers/mtd/spi/spi_flash_probe.c:113: ++ {"N25Q256", 0x20ba19, 0x0, 64 * 1024, 512, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#196: FILE: drivers/mtd/spi/spi_flash_probe.c:114: ++ {"N25Q256A", 0x20bb19, 0x0, 64 * 1024, 512, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#197: FILE: drivers/mtd/spi/spi_flash_probe.c:115: ++ {"N25Q512", 0x20ba20, 0x0, 64 * 1024, 1024, RD_CMD_FULL, WR_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#198: FILE: drivers/mtd/spi/spi_flash_probe.c:116: ++ {"N25Q512A", 0x20bb20, 0x0, 64 * 1024, 1024, RD_CMD_FULL, WR_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#199: FILE: drivers/mtd/spi/spi_flash_probe.c:117: ++ {"N25Q1024", 0x20ba21, 0x0, 64 * 1024, 2048, RD_CMD_FULL, WR_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#200: FILE: drivers/mtd/spi/spi_flash_probe.c:118: ++ {"N25Q1024A", 0x20bb21, 0x0, 64 * 1024, 2048, RD_CMD_FULL, WR_CMD_FULL, E_FSR | SECT_4K}, + +WARNING: line over 80 characters +#213: FILE: drivers/mtd/spi/spi_flash_probe.c:121: ++ {"SST25VF040B", 0xbf258d, 0x0, 64 * 1024, 8, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#214: FILE: drivers/mtd/spi/spi_flash_probe.c:122: ++ {"SST25VF080B", 0xbf258e, 0x0, 64 * 1024, 16, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#215: FILE: drivers/mtd/spi/spi_flash_probe.c:123: ++ {"SST25VF016B", 0xbf2541, 0x0, 64 * 1024, 32, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#216: FILE: drivers/mtd/spi/spi_flash_probe.c:124: ++ {"SST25VF032B", 0xbf254a, 0x0, 64 * 1024, 64, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#217: FILE: drivers/mtd/spi/spi_flash_probe.c:125: ++ {"SST25VF064C", 0xbf254b, 0x0, 64 * 1024, 128, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#218: FILE: drivers/mtd/spi/spi_flash_probe.c:126: ++ {"SST25WF512", 0xbf2501, 0x0, 64 * 1024, 1, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#219: FILE: drivers/mtd/spi/spi_flash_probe.c:127: ++ {"SST25WF010", 0xbf2502, 0x0, 64 * 1024, 2, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#220: FILE: drivers/mtd/spi/spi_flash_probe.c:128: ++ {"SST25WF020", 0xbf2503, 0x0, 64 * 1024, 4, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#221: FILE: drivers/mtd/spi/spi_flash_probe.c:129: ++ {"SST25WF040", 0xbf2504, 0x0, 64 * 1024, 8, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#222: FILE: drivers/mtd/spi/spi_flash_probe.c:130: ++ {"SST25WF080", 0xbf2505, 0x0, 64 * 1024, 16, 0, 0, SECT_4K | SST_WP}, + +WARNING: line over 80 characters +#243: FILE: drivers/mtd/spi/spi_flash_probe.c:133: ++ {"W25P80", 0xef2014, 0x0, 64 * 1024, 16, 0, 0, 0}, + +WARNING: line over 80 characters +#244: FILE: drivers/mtd/spi/spi_flash_probe.c:134: ++ {"W25P16", 0xef2015, 0x0, 64 * 1024, 32, 0, 0, 0}, + +WARNING: line over 80 characters +#245: FILE: drivers/mtd/spi/spi_flash_probe.c:135: ++ {"W25P32", 0xef2016, 0x0, 64 * 1024, 64, 0, 0, 0}, + +WARNING: line over 80 characters +#246: FILE: drivers/mtd/spi/spi_flash_probe.c:136: ++ {"W25X40", 0xef3013, 0x0, 4 * 1024, 128, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#247: FILE: drivers/mtd/spi/spi_flash_probe.c:137: ++ {"W25X16", 0xef3015, 0x0, 4 * 1024, 512, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#248: FILE: drivers/mtd/spi/spi_flash_probe.c:138: ++ {"W25X32", 0xef3016, 0x0, 4 * 1024, 1024, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#249: FILE: drivers/mtd/spi/spi_flash_probe.c:139: ++ {"W25X64", 0xef3017, 0x0, 4 * 1024, 2048, 0, 0, SECT_4K}, + +WARNING: line over 80 characters +#250: FILE: drivers/mtd/spi/spi_flash_probe.c:140: ++ {"W25Q80BL", 0xef4014, 0x0, 4 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#251: FILE: drivers/mtd/spi/spi_flash_probe.c:141: ++ {"W25Q16CL", 0xef4015, 0x0, 4 * 1024, 512, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#252: FILE: drivers/mtd/spi/spi_flash_probe.c:142: ++ {"W25Q32BV", 0xef4016, 0x0, 4 * 1024, 1024, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#253: FILE: drivers/mtd/spi/spi_flash_probe.c:143: ++ {"W25Q64CV", 0xef4017, 0x0, 4 * 1024, 2048, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#254: FILE: drivers/mtd/spi/spi_flash_probe.c:144: ++ {"W25Q128BV", 0xef4018, 0x0, 4 * 1024, 4096, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#255: FILE: drivers/mtd/spi/spi_flash_probe.c:145: ++ {"W25Q256", 0xef4019, 0x0, 4 * 1024, 8192, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#256: FILE: drivers/mtd/spi/spi_flash_probe.c:146: ++ {"W25Q80BW", 0xef5014, 0x0, 4 * 1024, 256, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#257: FILE: drivers/mtd/spi/spi_flash_probe.c:147: ++ {"W25Q16DW", 0xef6015, 0x0, 4 * 1024, 512, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#258: FILE: drivers/mtd/spi/spi_flash_probe.c:148: ++ {"W25Q32DW", 0xef6016, 0x0, 4 * 1024, 1024, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#259: FILE: drivers/mtd/spi/spi_flash_probe.c:149: ++ {"W25Q64DW", 0xef6017, 0x0, 4 * 1024, 2048, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +WARNING: line over 80 characters +#260: FILE: drivers/mtd/spi/spi_flash_probe.c:150: ++ {"W25Q128FW", 0xef6018, 0x0, 4 * 1024, 4096, RD_CMD_FULL, WR_CMD_FULL, SECT_4K}, + +total: 0 errors, 78 warnings, 0 checks, 311 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0032-sf-Add-quad-read-write-commands-support.patch has style problems, please review. + +If any of these errors are false positives, please report +them to the maintainer, see CHECKPATCH in MAINTAINERS. +total: 0 errors, 0 warnings, 0 checks, 30 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0033-sf-ops-Add-configuration-register-writing-support.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 68 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0034-sf-Set-quad-enable-bit-support.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 332 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0035-sf-spi_flash-cleanups.patch has no obvious style problems and is ready for submission. +total: 0 errors, 0 warnings, 0 checks, 212 lines checked + +NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE + +0036-spi-spi-cleanups.patch has no obvious style problems and is ready for submission. -- 1.8.3

2 1

[U-Boot] [PATCH v4 17/36] sf: Add proper comment style on spi_flash structure
by Jagannadha Sutradharudu Teki 27 Sep '13

27 Sep '13

Added proper comment style on spi_flash structure to make more readable. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v4: - none Changes for v3: - none Changes for v2: - none include/spi_flash.h | 63 +++++++++++++++++++++++++++++------------------------ 1 file changed, 35 insertions(+), 28 deletions(-) diff --git a/include/spi_flash.h b/include/spi_flash.h index 14e4ae2..34a167b 100644 --- a/include/spi_flash.h +++ b/include/spi_flash.h @@ -37,39 +37,46 @@ # define CMD_SST_AAI_WP 0xAD /* Auto Address Incr Word Program */ #endif +/** + * struct spi_flash - SPI flash structure + * + * @spi: SPI slave + * @name: Name of SPI flash + * @size: Total flash size + * @page_size: Write (page) size + * @sector_size: Sector size + * @erase_size: Erase size + * @bank_read_cmd: Bank read cmd + * @bank_write_cmd: Bank write cmd + * @bank_curr: Current flash bank + * @poll_cmd: Poll cmd - for flash erase/program + * @erase_cmd: Erase cmd 4K, 32K, 64K + * @memory_map: Address of read-only SPI flash access + * @read: Flash read ops + * @write: Flash write ops + * @erase: Flash erase ops + */ struct spi_flash { struct spi_slave *spi; + const char *name; - const char *name; - - /* Total flash size */ - u32 size; - /* Write (page) size */ - u32 page_size; - /* Sector size */ - u32 sector_size; - /* Erase size */ - u32 erase_size; + u32 size; + u32 page_size; + u32 sector_size; + u32 erase_size; #ifdef CONFIG_SPI_FLASH_BAR - /* Bank read cmd */ - u8 bank_read_cmd; - /* Bank write cmd */ - u8 bank_write_cmd; - /* Current flash bank */ - u8 bank_curr; + u8 bank_read_cmd; + u8 bank_write_cmd; + u8 bank_curr; #endif - /* Poll cmd - for flash erase/program */ - u8 poll_cmd; - /* Erase cmd 4K, 32K, 64K */ - u8 erase_cmd; - - void *memory_map; /* Address of read-only SPI flash access */ - int (*read)(struct spi_flash *flash, u32 offset, - size_t len, void *buf); - int (*write)(struct spi_flash *flash, u32 offset, - size_t len, const void *buf); - int (*erase)(struct spi_flash *flash, u32 offset, - size_t len); + u8 poll_cmd; + u8 erase_cmd; + + void *memory_map; + int (*read)(struct spi_flash *flash, u32 offset, size_t len, void *buf); + int (*write)(struct spi_flash *flash, u32 offset, size_t len, + const void *buf); + int (*erase)(struct spi_flash *flash, u32 offset, size_t len); }; /** -- 1.8.3

2 1

[U-Boot] [PATCH v4 34/36] sf: Set quad enable bit support
by Jagannadha Sutradharudu Teki 27 Sep '13

27 Sep '13

This patch provides support to set the quad enable bit on flash. quad enable bit needs to set before performing any quad IO operations on respective SPI flashes. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v4: - none Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_internal.h | 5 +++++ drivers/mtd/spi/spi_flash_ops.c | 24 ++++++++++++++++++++++++ drivers/mtd/spi/spi_flash_probe.c | 9 +++++++++ 3 files changed, 38 insertions(+) diff --git a/drivers/mtd/spi/spi_flash_internal.h b/drivers/mtd/spi/spi_flash_internal.h index 1f9f170..a346ae6 100644 --- a/drivers/mtd/spi/spi_flash_internal.h +++ b/drivers/mtd/spi/spi_flash_internal.h @@ -22,6 +22,7 @@ #define CMD_PAGE_PROGRAM 0x02 #define CMD_WRITE_DISABLE 0x04 #define CMD_READ_STATUS 0x05 +#define CMD_READ_CONFIG 0x35 #define CMD_FLAG_STATUS 0x70 #define CMD_WRITE_ENABLE 0x06 #define CMD_ERASE_4K 0x20 @@ -41,6 +42,7 @@ /* Common status */ #define STATUS_WIP 0x01 +#define STATUS_QEB 0x02 #define STATUS_PEC 0x80 /* Send a single-byte command to the device and read the response */ @@ -94,6 +96,9 @@ static inline int spi_flash_cmd_write_disable(struct spi_flash *flash) /* Program the status register. */ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr); +/* Set quad enbale bit */ +int spi_flash_set_qeb(struct spi_flash *flash); + /* * Same as spi_flash_cmd_read() except it also claims/releases the SPI * bus. Used as common part of the ->read() operation. diff --git a/drivers/mtd/spi/spi_flash_ops.c b/drivers/mtd/spi/spi_flash_ops.c index 2f87801..439490e 100644 --- a/drivers/mtd/spi/spi_flash_ops.c +++ b/drivers/mtd/spi/spi_flash_ops.c @@ -62,6 +62,30 @@ static int spi_flash_cmd_write_config(struct spi_flash *flash, u8 cr) return 0; } +int spi_flash_set_qeb(struct spi_flash *flash) +{ + u8 qeb_status; + u8 cmd; + int ret; + + cmd = CMD_READ_CONFIG; + ret = spi_flash_read_common(flash, &cmd, 1, &qeb_status, 1); + if (ret < 0) { + debug("SF: fail to read config register\n"); + return ret; + } + + if (qeb_status & STATUS_QEB) { + debug("SF: Quad enable bit is already set\n"); + } else { + ret = spi_flash_cmd_write_config(flash, STATUS_QEB); + if (ret < 0) + return ret; + } + + return ret; +} + #ifdef CONFIG_SPI_FLASH_BAR static int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel) { diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index 30ef85c..995af14 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -237,6 +237,15 @@ struct spi_flash *spi_flash_validate_ids(struct spi_slave *spi, u8 *idcode) flash->write_cmd = flash->spi->wr_cmd; } + /* Set the quad enable bit - only for quad commands */ + if ((flash->read_cmd == CMD_READ_QUAD_OUTPUT_FAST) || + (flash->write_cmd == CMD_QUAD_PAGE_PROGRAM)) { + if (spi_flash_set_qeb(flash)) { + debug("SF: Fail to set quad enable bit\n"); + return NULL; + } + } + /* Compute erase sector and command */ if (params->flags & SECT_4K) { flash->erase_cmd = CMD_ERASE_4K; -- 1.8.3

2 1