February 2013 - U-Boot

[U-Boot] [PATCH] dts/Makefile: Build the user specified dts
by Jagannadha Sutradharudu Teki 28 Feb '13

28 Feb '13

This patch provides a support to build the user specified dts. If the user is not specifying any dts, then it should build the dts from CONFIG_DEFAULT_DEVICE_TREE. $ make -> choose the default dts, defined as CONFIG_DEFAULT_DEVICE_TREE $ make DEVICE_TREE=<dts-file-name> -> choose the specified dts from the user Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- dts/Makefile | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dts/Makefile b/dts/Makefile index 922c78c..dd6c1fa 100644 --- a/dts/Makefile +++ b/dts/Makefile @@ -29,7 +29,9 @@ LIB = $(obj)libdts.o $(if $(CONFIG_DEFAULT_DEVICE_TREE),,\ $(error Please define CONFIG_DEFAULT_DEVICE_TREE in your board header file)) +ifneq ($(DEVICE_TREE),y) DEVICE_TREE = $(subst ",,$(CONFIG_DEFAULT_DEVICE_TREE)) +endif $(if $(CONFIG_ARCH_DEVICE_TREE),,\ $(error Your architecture does not have device tree support enabled. \ -- 1.7.4

2 2

[U-Boot] problem to boot i.MX28 custom platform
by Hector Palacios 28 Feb '13

28 Feb '13

Greetings, I'm porting a custom platform based on mx28evk to latest U-Boot. I modified the iomux.c for my platform (different DUART pins) and made some changes to mxs_adjust_memory_params() to accommodate to my DRAM chip. I built the u-boot.sb. The platform however does not boot either from USB or from MMC. When loaded through USB, sb_loader complains with the messages at [1]. I fear the CPU resets before even executing the SPL code, but how could I tell? Is there a way to check if the CPU reaches this code at all? I don't see any ROM error codes either and the CPU seems to reset (when the USB recovery mode fails, the target defaults to boot from flash my old v2009 U-Boot). Is there any other init stuff (linker scripts or something) I should take care of that's preventing sb_loader to fully load the image? Thank you. [1] sb_loader output 'Freescale,Inc.' 'ROM Recovery' device at USB path 0002:0034:00 Downloading 415504 bytes... hid_write report id 01 len 0x1f hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 . hid_write report id 02 len 0x400 ERROR: hid_write() returned -1 (error (null)) -- Héctor Palacios

3 3

[U-Boot] [PATCH] I2C: S3C24X0: Remove the dead code
by Rajeshwari Shinde 28 Feb '13

28 Feb '13

This revomes the code under #if 0 in the s3c24x0_i2c driver. Signed-off-by: Alim Akhtar <alim.akhtar(a)samsung.com> Signed-off-by: Rajeshwari Shinde <rajeshwari.s(a)samsung.com> --- drivers/i2c/s3c24x0_i2c.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index 769a2ba..00308b5 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -86,13 +86,6 @@ static int GetI2CSDA(void) #endif } -#if 0 -static void SetI2CSDA(int x) -{ - rGPEDAT = (rGPEDAT & ~0x8000) | (x & 1) << 15; -} -#endif - static void SetI2CSCL(int x) { struct s3c24x0_gpio *gpio = s3c24x0_get_base_gpio(); -- 1.7.4.4

2 1

[U-Boot] [RFC PATCH v2 0/15] Provide a mechanism to avoid using #ifdef everywhere
by Simon Glass 28 Feb '13

28 Feb '13

Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler. Multiple dependent #ifdefs are harder to do than with if..then..else. Variable declarations must be #idefed as well as the code that uses them, often much later in the file/function. #ifdef indents don't match code indents and have their own separate indent feature. Overall, excessive use of #idef hurts readability and makes the code harder to modify and refactor. For people coming newly into the code base, #ifdefs can be a big barrier. The use of #ifdef in U-Boot has possibly got a little out of hand. In an attempt to turn the tide, this series includes a patch which provides a way to make CONFIG macros available to C code without using the preprocessor. This makes it possible to use standard C conditional features such as if/then instead of #ifdef. A README update exhorts compliance. As an example of how to use this, this series replaces all but two #ifdefs from the main code body of common/main.c, which has the dubious distinction of having the most #ifdefs by at least one measure: $ for f in $(find . -name *.c); do echo $(grep -c "ifdef" $f) $f; done \ |sort -nr |head 57 ./common/main.c 57 ./arch/powerpc/cpu/mpc83xx/cpu_init.c 48 ./arch/powerpc/lib/board.c 46 ./drivers/video/cfb_console.c 40 ./drivers/mtd/cfi_flash.c 38 ./net/tftp.c 38 ./common/cmd_bootm.c 37 ./drivers/usb/host/ohci-hcd.c 36 ./drivers/fpga/ivm_core.c 35 ./drivers/usb/gadget/ether.c Code size for this patch seems to be roughly neutral (below numbers are average change in byte size for each region: x86: (3 boards) text -1.3 data +1.3 sandbox: (1 boards) bss +16.0 m68k: (50 boards) text -4.2 powerpc: (622 boards) text +9.1 data +0.0 bss +1.9 sh: (21 boards) bss +2.5 nios2: (3 boards) text +24.0 data -1.3 bss +1.3 arm: (285 boards) spl/u-boot-spl:text +0.4 text -2.3 bss +5.5 nds32: (3 boards) text -29.3 bss +10.7 Note that a config_drop.h file is added - this defines all the CONFIGs which are not used in any board config file. Without this, autoconf cannot define the macros for this CONFIGs. Compile time for main.c does not seem to be any different in my tests. The time to perform the 'dep' step (which now creates autoconf.h) increases, from about 2.8s to about 4.6s. This additional time is used to grep, sed and sort the contents of all the header file in U-Boot. The time for an incremental build is not affected. It would be much more efficient to maintain a list of all available CONFIG defines, but no such list exists at present. Changes in v2: - Split out changes to main.c into separate patches - Fix up a few errors and comments in the original RFC - Use autoconf_...() instead of config_...() - Use autoconf_has_...() instead of config_..._enabled() - Add a grep to the sed/sort pipe to speed up processing Simon Glass (15): Implement autoconf header file at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263 net: Add prototype for update_tftp, and use autoconf main: Separate out the two abortboot() functions main: Move boot_delay code into its own function main: Use autoconf for boot retry feature main: Remove CONFIG #ifdefs from the abortboot() code main: Use get/setenv_ulong() main: Use autoconf for boot_delay code main: Use autoconf for parser selection main: Use autoconf in command line reading main: Use autoconf in main_loop() main: Correct header order main: Add debug_parser() to avoid #ifdefs main: Add debug_bootkeys to avoid #ifdefs Makefile | 42 ++- README | 87 ++++- common/cmd_fitupd.c | 3 +- common/main.c | 809 ++++++++++++++++++------------------------ common/update.c | 24 +- include/command.h | 2 - include/common.h | 9 +- include/config_drop.h | 17 + include/configs/pm9263.h | 2 +- include/fdt_support.h | 4 +- include/hush.h | 2 - include/menu.h | 2 - include/net.h | 3 + tools/scripts/define2conf.sed | 37 ++ tools/scripts/define2list.sed | 31 ++ 15 files changed, 579 insertions(+), 495 deletions(-) create mode 100644 include/config_drop.h create mode 100644 tools/scripts/define2conf.sed create mode 100644 tools/scripts/define2list.sed -- 1.8.1.3

2 41

[U-Boot] [PATCH 1/2] README.scrapyard: add missing commit IDs
by Wolfgang Denk 28 Feb '13

28 Feb '13

Now that the patches have made it into mainline, we can also add the commit IDs. Signed-off-by: Wolfgang Denk <wd(a)denx.de> --- doc/README.scrapyard | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/README.scrapyard b/doc/README.scrapyard index 2b868e6..9ad9296 100644 --- a/doc/README.scrapyard +++ b/doc/README.scrapyard @@ -11,13 +11,13 @@ easily if here is something they might want to dig for... Board Arch CPU removed Commit last known maintainer/contact ============================================================================= -AMX860 powerpc mpc860 - - Wolfgang Denk <wd(a)denx.de> -c2mon powerpc mpc855 - - Wolfgang Denk <wd(a)denx.de> -ETX094 powerpc mpc850 - - Wolfgang Denk <wd(a)denx.de> -IAD210 powerpc mpc860 - - - -LANTEC powerpc mpc850 - - Wolfgang Denk <wd(a)denx.de> -SCM powerpc mpc8260 - - Wolfgang Grandegger <wg(a)denx.de> -SX1 arm arm925t - - +AMX860 powerpc mpc860 1b0757e 2012-10-28 Wolfgang Denk <wd(a)denx.de> +c2mon powerpc mpc855 1b0757e 2012-10-28 Wolfgang Denk <wd(a)denx.de> +ETX094 powerpc mpc850 1b0757e 2012-10-28 Wolfgang Denk <wd(a)denx.de> +IAD210 powerpc mpc860 1b0757e 2012-10-28 - +LANTEC powerpc mpc850 1b0757e 2012-10-28 Wolfgang Denk <wd(a)denx.de> +SCM powerpc mpc8260 1b0757e 2012-10-28 Wolfgang Grandegger <wg(a)denx.de> +SX1 arm arm925t 53c4154 2012-10-26 TQM85xx powerpc MPC85xx d923a5d5 2012-10-04 Stefan Roese <sr(a)denx.de> apollon arm omap24xx 535c74f 2012-09-18 Kyungmin Park <kyungmin.park(a)samsung.com> tb0229 mips mips32 3f3110d 2011-12-12 -- 1.7.11.7

3 8

Re: [U-Boot] [PATCH 6/9] Exynos: Add peripherial id for pwm
by Simon Glass 28 Feb '13

28 Feb '13

On Thu, Feb 28, 2013 at 2:54 AM, Akshay Saraswat <akshay.s(a)samsung.com>wrote: > Hi simon, > > > > >Hi Akshay, > > > > >On Wed, Feb 27, 2013 at 2:02 AM, Akshay Saraswat <akshay.s(a)samsung.com> > wrote: > >> Add peripherial id for pwm inorder to support > >> generic api to get the clk frequency > >> > >> TEST=sf probe 1:0; time sf read 40008000 0 1000 > > >> Try with different numbers of bytes and see that sane values are > obtained > >> Build and boot U-boot with this patch, backlight works properly. > >> > >> Signed-off-by: Padmavathi Venna <padma.v(a)samsung.com> > >> Signed-off-by: Akshay Saraswat <akshay.s(a)samsung.com> > >> --- > >> arch/arm/include/asm/arch-exynos/periph.h | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/arch/arm/include/asm/arch-exynos/periph.h > b/arch/arm/include/asm/arch-exynos/periph.h > >> index 89bcdfc..e5aed4b 100644 > >> --- a/arch/arm/include/asm/arch-exynos/periph.h > >> +++ b/arch/arm/include/asm/arch-exynos/periph.h > >> @@ -61,6 +61,11 @@ enum periph_id { > >> PERIPH_ID_SPI3, > >> PERIPH_ID_SPI4, > >> PERIPH_ID_SDMMC4, > >> + PERIPH_ID_PWM0, > >> + PERIPH_ID_PWM1, > >> + PERIPH_ID_PWM2, > >> + PERIPH_ID_PWM3, > >> + PERIPH_ID_PWM4, > > > >I don't believe this file is used now. > > We need this file because we are using it in the next patch of this patch > set and also for pinmux. > > Yes I understand. Thanks. Acked-by: Simon Glass <sjg(a)chromium.org> > > > > > >Regards, > >Simon > > > > >> > >> PERIPH_ID_COUNT, > >> PERIPH_ID_NONE = -1, > >> -- > >> 1.8.0 > >> > > > > Regards, > > Akshay Saraswat >

1 0

Re: [U-Boot] Problems around fatwrite command from uboot
by Jean Louis 28 Feb '13

28 Feb '13

Hi, I confirm that your patch correct my problem and the bug disappear. The question is : why (or when) the size equals zero ? Thank you Damien. ---- 2013/2/28 Damien HUANG 黄卫 <damienwei(a)hotmail.com> > Hi, > You received this email, because you had recently experienced fatwrite > issue with uboot. > > The symptom of the problem is at the time of calling fatwrite to write a > block of data to file, the below message would be shown, despite the > message saying "xxxx bytes written" at the end, however, there was not data > being actually stored. > > >* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear*>* mmc_send_cmd: timedout waiting on cmd inhibit to clear > *>* 42428 bytes written* > > > After investigation, I believe the problem can be fixed at function > "set_cluster" within file fat_write.c under directory /fs/fat (patch file > was attached). > > The reason of the issue is: If function "set_cluster" was called with size > equals ZERO, then the function would only issue the write instruction to > MMC driver without data, this caused the MMC to be in a wait state for data > and inhibiting further commands. As all subsequent commands to MMC would > first check whether MMC is in inhibit state before actual command being > issued, this check would always fail and time out occur, so the above > message being displayed. > > Cheers, > Damien > > ------------------------------ > From: 1978.jl(a)gmail.com > Date: Wed, 27 Feb 2013 09:02:42 +0100 > Subject: Re: [U-Boot] Problems around fatwrite command from uboot > To: damienwei(a)hotmail.com > > Hi Damien, > > I have only patched as I say on : > http://lists.denx.de/pipermail/u-boot/2013-February/147407.html > > I have no more changes for the moment. > > Bye. > > ---- > > 2013/2/27 Damien HUANG 黄卫 <damienwei(a)hotmail.com> > > Hi Jean, > I saw your post in regard to the issue of fatwrite command from uboot. As > I am also experienced with such an error, I am wonder if you got the > problem fixed? If so, please share your success. > Cheers, > Damien > >

1 0

[U-Boot] [PATCH] powerpc/b4860: Adding workaround errata A-005871
by Shengzhou Liu 28 Feb '13

28 Feb '13

Per the latest errata updated, B4860/B4420 Rev 1.0 has also errata A-005871, so adding define A-005871 for B4 SoCs. Signed-off-by: Shengzhou Liu <Shengzhou.Liu(a)freescale.com> --- arch/powerpc/include/asm/config_mpc85xx.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/include/asm/config_mpc85xx.h b/arch/powerpc/include/asm/config_mpc85xx.h index d57c178..8285ae1 100644 --- a/arch/powerpc/include/asm/config_mpc85xx.h +++ b/arch/powerpc/include/asm/config_mpc85xx.h @@ -560,6 +560,7 @@ #define CONFIG_SYS_FSL_PCIE_COMPAT "fsl,qoriq-pcie-v2.4" #define CONFIG_SYS_FSL_USB1_PHY_ENABLE #define CONFIG_SYS_FSL_ERRATUM_A_004934 +#define CONFIG_SYS_FSL_ERRATUM_A005871 #define CONFIG_SYS_CCSRBAR_DEFAULT 0xfe000000 #elif defined(CONFIG_PPC_B4860) @@ -585,6 +586,7 @@ #define CONFIG_SYS_FSL_SRIO_IB_WIN_NUM 5 #define CONFIG_SYS_FSL_USB1_PHY_ENABLE #define CONFIG_SYS_FSL_ERRATUM_A_004934 +#define CONFIG_SYS_FSL_ERRATUM_A005871 #define CONFIG_SYS_CCSRBAR_DEFAULT 0xfe000000 #else -- 1.6.4

1 0

[U-Boot] [PATCH 0/9] Fix and Re-organise PWM Timer
by Akshay Saraswat 28 Feb '13

28 Feb '13

This patch set tries to fix few bugs in timer and re-organises PWM clock code. Akshay Saraswat (9): Exynos: Change get_timer() to work correctly Exynos: Add timer_get_us function Exynos: pwm: Fix two bugs in the exynos pwm configuration code Exynos: Avoid a divide by zero by specifying a non-zero period for pwm 4 Exynos: Tidy up the pwm_config function in the exynos pwm driver Exynos: Add peripherial id for pwm Exynos: clock: Add generic api to get the clk freq Exynos: clock: Correct pwm source clk selection Exynos: pwm: Use generic api to get pwm clk freq arch/arm/cpu/armv7/exynos/clock.c | 127 ++++++++++++++++++++++++++++++ arch/arm/cpu/armv7/s5p-common/pwm.c | 45 +++++------ arch/arm/cpu/armv7/s5p-common/timer.c | 117 +++++++++++++-------------- arch/arm/include/asm/arch-exynos/clk.h | 27 +++++++ arch/arm/include/asm/arch-exynos/periph.h | 5 ++ board/samsung/smdk5250/setup.h | 2 +- 6 files changed, 237 insertions(+), 86 deletions(-) -- 1.8.0

3 18

[U-Boot] [PATCH 0/4] Add ACE HW support for SHA 256
by Akshay Saraswat 28 Feb '13

28 Feb '13

This patch set adds hardware acceleration for SHA 256 with the help of ACE. Akshay Saraswat (4): Exynos: Add hardware accelerated SHA 256 Exynos: config: Enable ACE HW for SHA 256 for Exynos gen: Add sha256 command Exynos: Flush memory region before starting SHA DMA operation arch/arm/cpu/armv7/exynos/Makefile | 4 + arch/arm/cpu/armv7/exynos/ace_sha.c | 123 ++++++++++++ arch/arm/include/asm/arch-exynos/ace_sfr.h | 310 +++++++++++++++++++++++++++++ arch/arm/include/asm/arch-exynos/ace_sha.h | 41 ++++ arch/arm/include/asm/arch-exynos/cpu.h | 4 + common/Makefile | 1 + common/cmd_sha256.c | 69 +++++++ include/configs/exynos5250-dt.h | 3 + 8 files changed, 555 insertions(+) create mode 100644 arch/arm/cpu/armv7/exynos/ace_sha.c create mode 100644 arch/arm/include/asm/arch-exynos/ace_sfr.h create mode 100644 arch/arm/include/asm/arch-exynos/ace_sha.h create mode 100644 common/cmd_sha256.c -- 1.8.0

3 9