September 2024 - U-Boot

[PATCH] spi: davinci: Drop the preload of TX buffer before read/writes operations
by Bastien Curutchet 10 Sep '24

10 Sep '24

A write to the TX buffer is performed before entering the loop to "avoid clock starvation". This sometimes results in subsequent writes in davinci_spi_xfer_data() to occur while the TXFULL bit is asserted, leading to write failures. Remove the preload of the TX buffer. Signed-off-by: Bastien Curutchet <bastien.curutchet(a)bootlin.com> --- Hi all, I've ran into write failures to flash on my platform based on the DAVINCI/OMAP L138. This patch fixes it. drivers/spi/davinci_spi.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 25f5e9fdeb..07c46b8b66 100644 --- a/drivers/spi/davinci_spi.c +++ b/drivers/spi/davinci_spi.c @@ -129,9 +129,6 @@ static int davinci_spi_read(struct davinci_spi_slave *ds, unsigned int len, while (readl(&ds->regs->buf) & SPIBUF_TXFULL_MASK) ; - /* preload the TX buffer to avoid clock starvation */ - writel(data1_reg_val, &ds->regs->dat1); - /* keep reading 1 byte until only 1 byte left */ while ((len--) > 1) *rxp++ = davinci_spi_xfer_data(ds, data1_reg_val); @@ -159,12 +156,6 @@ static int davinci_spi_write(struct davinci_spi_slave *ds, unsigned int len, while (readl(&ds->regs->buf) & SPIBUF_TXFULL_MASK) ; - /* preload the TX buffer to avoid clock starvation */ - if (len > 2) { - writel(data1_reg_val | *txp++, &ds->regs->dat1); - len--; - } - /* keep writing 1 byte until only 1 byte left */ while ((len--) > 1) davinci_spi_xfer_data(ds, data1_reg_val | *txp++); -- 2.46.0

1 0

[RFC PATCH 0/6] Add support for K3 BIST
by Neha Malcom Francis 10 Sep '24

10 Sep '24

This is an RFC series that aims to implement a driver for the BIST (Built-In Self Test) module for K3 devices. The BIST driver must ideally support triggering of BIST tests, both PBIST (Memory BIST) and LBIST (Logic BIST) on a core. Both tests are destructive in nature. Please see links [1] and [2] for further information regarding the two. At boot up, BIST is executed by hardware for the MCU domain automatically as part of HW POST. So BIST has been checked only for the MCU domain, and it makes sense to include our driver for BIST at the MCU R5 SPL stage. The driver can trigger BIST runs for the rest of the cores before loading and running any firmware on the cores. The general procedure for triggering BIST on a core is: 1. Power on the core under test 2. Trigger the BIST test 3. Reset the core under test This series, triggers PBIST tests on the MAIN_R5_2_x cores. This is marked as RFC for a couple of WIP reasons: - the core under test is confirmed to be accessible (powered on) before running the test, and unaccessible after running the test by connecting the debugger to the core, however the firmware calls that check if a core is running or not at A72 U-Boot stage responds as the core is still running. Due to this, before loading or running firmware, an explicit 'stop' needs to be issued by the remoteproc framework (which does not work at the earlier R5 stage as the DM firmware is not up yet). Please see the boot logs to understand. This is under debug. - the driver currently implements all three PBIST tests (PBIST, PBIST failure insertion and PBIST ROM); LBIST is WIP but will be more or less similar to how PBIST has been implemented Would appreciate reviews/comments on how this driver is modelled. Boot logs: https://gist.github.com/nehamalcom/63e94dbfc8a9b9fcaba6f45210e20cea [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/latest/… [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/latest/… Neha Malcom Francis (6): arm: mach-k3: j784s4: Add clk and power support for MAIN_R5_2_x PBIST arm: dts: k3-j784s4-main: Add PBIST_14 node arm: dts: k3-j784s4-main: Add clock and power domains for MAIN_R5_2_x drivers: misc: k3_bist: Add K3 BIST driver arm: mach-k3: j784s4_init: Trigger BIST configs: j784s4_evm_r5_defconfig: Enable BIST arch/arm/mach-k3/j784s4/j784s4_init.c | 11 + arch/arm/mach-k3/r5/j784s4/clk-data.c | 13 + arch/arm/mach-k3/r5/j784s4/dev-data.c | 7 + configs/j784s4_evm_r5_defconfig | 2 + drivers/misc/Kconfig | 8 + drivers/misc/Makefile | 1 + drivers/misc/k3_bist.c | 507 ++++++++++++++++ drivers/misc/k3_bist_static_data.h | 551 ++++++++++++++++++ dts/upstream/src/arm64/ti/k3-j784s4-main.dtsi | 19 + 9 files changed, 1119 insertions(+) create mode 100644 drivers/misc/k3_bist.c create mode 100644 drivers/misc/k3_bist_static_data.h -- 2.34.1

2 16

[PATCH] spl: ram: fix build warning when neither RAM_DEVICE nor DFU are enabled
by Jerome Forissier 10 Sep '24

10 Sep '24

Fixes the following warning: common/spl/spl_ram.c:19:14: warning: ‘spl_ram_load_read’ defined but not used [-Wunused-function] 19 | static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector, | ^~~~~~~~~~~~~~~~~ Signed-off-by: Jerome Forissier <jerome.forissier(a)linaro.org> --- common/spl/spl_ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c index 71b7a8374bb..1a5874c3949 100644 --- a/common/spl/spl_ram.c +++ b/common/spl/spl_ram.c @@ -16,6 +16,7 @@ #include <spl.h> #include <linux/libfdt.h> +#if CONFIG_IS_ENABLED(RAM_DEVICE) || CONFIG_IS_ENABLED(DFU) static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector, ulong count, void *buf) { @@ -96,6 +97,8 @@ static int spl_ram_load_image(struct spl_image_info *spl_image, return ret; } +#endif + #if CONFIG_IS_ENABLED(RAM_DEVICE) SPL_LOAD_IMAGE_METHOD("RAM", 0, BOOT_DEVICE_RAM, spl_ram_load_image); #endif -- 2.40.1

2 2

[PATCH 1/6] usb: gadget: Inline usb_add_gadget_udc_release
by Marek Vasut 10 Sep '24

10 Sep '24

The release parameter of usb_add_gadget_udc_release() is never used. The function is never called from anywhere except from a wrapper in udc-core.c . Inline the function into the wrapper. Signed-off-by: Marek Vasut <marek.vasut+renesas(a)mailbox.org> --- Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Lukasz Majewski <lukma(a)denx.de> Cc: Mattijs Korpershoek <mkorpershoek(a)baylibre.com> Cc: Miquel Raynal <miquel.raynal(a)bootlin.com> Cc: Neil Armstrong <neil.armstrong(a)linaro.org> Cc: Nishanth Menon <nm(a)ti.com> Cc: Zixun LI <admin(a)hifiphile.com> --- drivers/usb/gadget/udc/udc-core.c | 20 ++------------------ include/linux/usb/gadget.h | 2 -- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c index 6bb419ae2ab..37c0ee43c52 100644 --- a/drivers/usb/gadget/udc/udc-core.c +++ b/drivers/usb/gadget/udc/udc-core.c @@ -166,16 +166,14 @@ static void usb_udc_release(struct device *dev) } /** - * usb_add_gadget_udc_release - adds a new gadget to the udc class driver list + * usb_add_gadget_udc - adds a new gadget to the udc class driver list * @parent: the parent device to this udc. Usually the controller driver's * device. * @gadget: the gadget to be added to the list. - * @release: a gadget release function. * * Returns zero on success, negative errno otherwise. */ -int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget, - void (*release)(struct device *dev)) +int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) { struct usb_udc *udc; int ret = -ENOMEM; @@ -205,20 +203,6 @@ int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget, err1: return ret; } -EXPORT_SYMBOL_GPL(usb_add_gadget_udc_release); - -/** - * usb_add_gadget_udc - adds a new gadget to the udc class driver list - * @parent: the parent device to this udc. Usually the controller - * driver's device. - * @gadget: the gadget to be added to the list - * - * Returns zero on success, negative errno otherwise. - */ -int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) -{ - return usb_add_gadget_udc_release(parent, gadget, NULL); -} EXPORT_SYMBOL_GPL(usb_add_gadget_udc); static void usb_gadget_remove_driver(struct usb_udc *udc) diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index c7927df15aa..d62fba0ca02 100644 --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@ -890,8 +890,6 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver); */ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver); -int usb_add_gadget_udc_release(struct device *parent, - struct usb_gadget *gadget, void (*release)(struct device *dev)); int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget); void usb_del_gadget_udc(struct usb_gadget *gadget); /*-------------------------------------------------------------------------*/ -- 2.45.2

4 14

[PATCH 0/4] mtd: spi-nor: add generic flash driver
by tkuw584924＠gmail.com 10 Sep '24

10 Sep '24

From: Takahiro Kuwano <Takahiro.Kuwano(a)infineon.com> The goal of series is to port spi-nor-generic feature based on SFDP parsing. This feature will suppress the increase of spi_nor_ids{} size and reduce our effort to maintain it. We need to rework 4-byte address mode entry/exit functions and enhance SFDP parsing to select proper 4-byte address mode method. After that, add spi-nor-generic structure and fallback logic in spi_nor_read_id(). Most of the code in this series are from Linux commits with some modification to address gap between u-boot and Linux implementation. It may be better to sync whole SPI NOR framework with Linux. That will be done incrementally by separate series. Tested with CYRS17B512 SPI NOR Flash which supports SFDP but not listed in spi_nor_ids[]. https://www.infineon.com/dgdl/Infineon-CYRS17B512_512_MB_64_MB_SERIAL_NOR_F… Takahiro Kuwano (4): mtd: spi-nor: Rework set_4byte() mtd: spi-nor: Set the 4-Byte Address Mode method based on SFDP data mtd: spi-nor: Remove SPI_NOR_SKIP_SFDP flag mtd: spi-nor: add generic flash driver drivers/mtd/spi/sf_internal.h | 10 +- drivers/mtd/spi/spi-nor-core.c | 317 +++++++++++++++++++++++++-------- include/linux/mtd/spi-nor.h | 3 + 3 files changed, 252 insertions(+), 78 deletions(-) -- 2.34.1

2 8

[PATCH 1/1] cmd: mtd: simplify mtd_show_device()
by Heinrich Schuchardt 10 Sep '24

10 Sep '24

CONFIG_DM=y is always true. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- cmd/mtd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/mtd.c b/cmd/mtd.c index 795aaa2b37d..260b26076ed 100644 --- a/cmd/mtd.c +++ b/cmd/mtd.c @@ -121,13 +121,11 @@ static void mtd_show_device(struct mtd_info *mtd) { /* Device */ printf("* %s\n", mtd->name); -#if defined(CONFIG_DM) if (mtd->dev) { printf(" - device: %s\n", mtd->dev->name); printf(" - parent: %s\n", mtd->dev->parent->name); printf(" - driver: %s\n", mtd->dev->driver->name); } -#endif if (IS_ENABLED(CONFIG_OF_CONTROL) && mtd->dev) { char buf[256]; int res; -- 2.45.2

2 1

[PULL] u-boot-usb/next
by Marek Vasut 10 Sep '24

10 Sep '24

The following changes since commit d0f74bd417daf6492975ce346843ba0767caf51c: buildman: Support building within a Python venv (2024-09-06 12:45:54 -0600) are available in the Git repository at: git://source.denx.de/u-boot-usb.git next for you to fetch changes up to e72e683e36a83214dbb2547d88d553b5fd816dc8: phy: test: Implement sandbox PHY .set_mode and DM test (2024-09-09 17:18:04 +0200) ---------------------------------------------------------------- Marek Vasut (3): phy: Extend generic_setup_phy() with PHY mode and submode phy: rcar: Split init and set_mode operations phy: test: Implement sandbox PHY .set_mode and DM test drivers/phy/phy-rcar-gen3.c | 90 ++++++++++++++++++++++++++++++++++++++--- drivers/phy/phy-uclass.c | 13 +++++- drivers/phy/sandbox-phy.c | 13 ++++++ drivers/usb/host/ehci-generic.c | 2 +- drivers/usb/host/ehci-msm.c | 2 +- drivers/usb/host/ehci-mx6.c | 2 +- drivers/usb/host/ehci-pci.c | 2 +- drivers/usb/host/ohci-generic.c | 2 +- include/generic-phy.h | 8 +++- test/dm/phy.c | 15 +++++-- 10 files changed, 131 insertions(+), 18 deletions(-)

2 1

[RESEND PATCH v2 0/3] cmd/mtd: add missed featuries
by Mikhail Kshevetskiy 10 Sep '24

10 Sep '24

Some nand flashes (like spi-nand one) are registered with mtd subsystem only, thus nand command can't be used to work with such flashes. As result some functionality is missing. This patch series implements following subcommands: * markbad -- mark block as bad (copy of 'nand markbad') * torture -- destructive test of flash blocks (copy of 'nand torture') * nandtest -- non-destructive test of nand flashes v2 changes: * add cover letter Mikhail Kshevetskiy (3): cmd: mtd: add markbad command support cmd: mtd: add torture command support cmd: mtd: add nandtest command support cmd/Kconfig | 18 +++ cmd/mtd.c | 457 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 475 insertions(+) -- 2.45.2

2 5

[PATCH 0/8] riscv: Add AST2700 platform support
by Chia-Wei Wang 10 Sep '24

10 Sep '24

AST2700 is the 7th generation of Aspeed BMC SoCs. A 32-bits Ibex RISC-V core is integrated as the boot MCU to run the first stage bootloader, SPL, for the platform initialization. This patch series starts by revising RISC-V common code to relax certain restrictions for finer platform resource tuning. As this MCU adopts the "small" configuration provided by Ibex and has limited SRAM space. In addition to the RV common code revision, the other patches provides the basic AST2700 platform code and DRAM/Timer drivers to succuessfully boot SPL and U-Boot on this Ibex-based MCU. Chia-Wei Wang (8): riscv: Make A ISA extension selectable riscv: Make stack size shift configurable riscv: u-boot-spl.lds: Remove _image_binary_end alignment riscv: Add AST2700 SoC initial platform support timer: Add AST2700 IBEX timer support board: ibex_ast2700: Add FMC header support ram: ast2700: Add DRAM controller initialization configs: ibex-ast2700: Enable DRAM and timer driver arch/riscv/Kconfig | 12 +- arch/riscv/cpu/ast2700/Kconfig | 6 + arch/riscv/cpu/ast2700/Makefile | 1 + arch/riscv/cpu/ast2700/cpu.c | 23 + arch/riscv/cpu/u-boot-spl.lds | 2 - arch/riscv/dts/Makefile | 1 + arch/riscv/dts/ast2700-ibex.dts | 22 + arch/riscv/dts/ast2700-u-boot.dtsi | 40 + arch/riscv/dts/ast2700.dtsi | 76 + arch/riscv/include/asm/arch-ast2700/fmc_hdr.h | 52 + arch/riscv/include/asm/arch-ast2700/scu.h | 145 + arch/riscv/include/asm/arch-ast2700/sdram.h | 137 + arch/riscv/include/asm/arch-ast2700/sli.h | 82 + board/aspeed/ibex_ast2700/Kconfig | 21 + board/aspeed/ibex_ast2700/MAINTAINERS | 7 + board/aspeed/ibex_ast2700/Makefile | 3 + board/aspeed/ibex_ast2700/fmc_hdr.c | 64 + board/aspeed/ibex_ast2700/ibex_ast2700.c | 85 + board/aspeed/ibex_ast2700/sli.c | 72 + configs/ibex-ast2700_defconfig | 94 + drivers/ram/Makefile | 2 +- drivers/ram/aspeed/Kconfig | 27 +- drivers/ram/aspeed/Makefile | 1 + ..._ddrphy_phyinit_ddr4-3200-nodimm-train2D.c | 2700 +++++++ ..._ddrphy_phyinit_ddr5-3200-nodimm-train2D.c | 6930 +++++++++++++++++ drivers/ram/aspeed/sdram_ast2700.c | 1036 +++ drivers/timer/Kconfig | 6 + drivers/timer/Makefile | 1 + drivers/timer/ast_ibex_timer.c | 45 + include/configs/ibex_ast2700.h | 12 + 30 files changed, 11696 insertions(+), 9 deletions(-) create mode 100644 arch/riscv/cpu/ast2700/Kconfig create mode 100644 arch/riscv/cpu/ast2700/Makefile create mode 100644 arch/riscv/cpu/ast2700/cpu.c create mode 100644 arch/riscv/dts/ast2700-ibex.dts create mode 100644 arch/riscv/dts/ast2700-u-boot.dtsi create mode 100644 arch/riscv/dts/ast2700.dtsi create mode 100644 arch/riscv/include/asm/arch-ast2700/fmc_hdr.h create mode 100644 arch/riscv/include/asm/arch-ast2700/scu.h create mode 100644 arch/riscv/include/asm/arch-ast2700/sdram.h create mode 100644 arch/riscv/include/asm/arch-ast2700/sli.h create mode 100644 board/aspeed/ibex_ast2700/Kconfig create mode 100644 board/aspeed/ibex_ast2700/MAINTAINERS create mode 100644 board/aspeed/ibex_ast2700/Makefile create mode 100644 board/aspeed/ibex_ast2700/fmc_hdr.c create mode 100644 board/aspeed/ibex_ast2700/ibex_ast2700.c create mode 100644 board/aspeed/ibex_ast2700/sli.c create mode 100644 configs/ibex-ast2700_defconfig create mode 100644 drivers/ram/aspeed/dwc_ddrphy_phyinit_ddr4-3200-nodimm-train2D.c create mode 100644 drivers/ram/aspeed/dwc_ddrphy_phyinit_ddr5-3200-nodimm-train2D.c create mode 100644 drivers/ram/aspeed/sdram_ast2700.c create mode 100644 drivers/timer/ast_ibex_timer.c create mode 100644 include/configs/ibex_ast2700.h -- 2.25.1

3 17

[PATCH] imx8mq-u-boot: Pass FIT offset to fix boot regression
by Fabio Estevam 10 Sep '24

10 Sep '24

Since commit 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image generation to binman") the imx8mq-evk fails to boot: U-Boot SPL 2024.10-rc4 (Sep 09 2024 - 16:08:22 -0300) PMIC: PFUZE100 ID=0x10 SEC0: RNG instantiated Normal Boot Trying to boot from MMC2 Fix it by passing the offset property for the FIT image, just like it is done on i.MX8MM. Fixes: 37e50627efac ("ARM: dts: imx: Convert i.MX8M flash.bin image generation to binman") Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- arch/arm/dts/imx8mq-u-boot.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi index e1cd6f8996dc..9b895a63857a 100644 --- a/arch/arm/dts/imx8mq-u-boot.dtsi +++ b/arch/arm/dts/imx8mq-u-boot.dtsi @@ -111,6 +111,8 @@ #endif #address-cells = <1>; + offset = <0x57c00>; + images { uboot { arch = "arm64"; -- 2.34.1

3 3