September 2023 - U-Boot

[PATCH v1 2/2] doc: board: starfive: Add more info about supported driver
by Shengyu Qu 05 Sep '23

05 Sep '23

Since PLDA PCIE driver is added and VL805 support is enabled in defconfig for Starfive Visionfive 2, modify the document to keep consistent. Signed-off-by: Shengyu Qu <wiagn233(a)outlook.com> --- doc/board/starfive/visionfive2.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/board/starfive/visionfive2.rst b/doc/board/starfive/visionfive2.rst index 941899a0a4..460f23aec3 100644 --- a/doc/board/starfive/visionfive2.rst +++ b/doc/board/starfive/visionfive2.rst @@ -20,6 +20,8 @@ The support for following drivers are already enabled: 3. StarFive JH7110 reset Driver. 4. Cadence QSPI controller Driver. 5. MMC SPI Driver for MMC/SD support. +6. PLDA PCIE controller driver. +7. On-board VL805 PCIE-USB controller driver. Booting from MMC using U-Boot SPL --------------------------------- -- 2.42.0

4 3

[PATCH v1 1/2] configs: starfive: Enable PCIE auto enum and NVME/USB stuff for Starfive Visionfive 2
by Shengyu Qu 05 Sep '23

05 Sep '23

Although PCIE driver already exists, board defconfig isn't configured to enable PCIE enum on boot, thus USB storage device and NVME drive are not supported by default. So modify defconfig to enable PCIE auto enum, then start USB subsystem and scan nvme drive on boot. Signed-off-by: Shengyu Qu <wiagn233(a)outlook.com> --- configs/starfive_visionfive2_defconfig | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index e9b63e5b84..3002c96f0e 100644 --- a/configs/starfive_visionfive2_defconfig +++ b/configs/starfive_visionfive2_defconfig @@ -30,6 +30,7 @@ CONFIG_SPL_SPI=y CONFIG_SYS_LOAD_ADDR=0x82000000 CONFIG_SYS_PCI_64BIT=y CONFIG_PCI=y +CONFIG_PCI_INIT_R=y CONFIG_TARGET_STARFIVE_VISIONFIVE2=y CONFIG_SPL_OPENSBI_LOAD_ADDR=0x40000000 CONFIG_ARCH_RV64I=y @@ -43,7 +44,7 @@ CONFIG_SD_BOOT=y CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 debug rootwait earlycon=sbi" CONFIG_USE_PREBOOT=y -CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr};fdt addr ${fdtcontroladdr};" +CONFIG_PREBOOT="nvme scan; usb start; setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};" CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2.dtb" CONFIG_DISPLAY_CPUINFO=y CONFIG_DISPLAY_BOARDINFO=y @@ -124,4 +125,9 @@ CONFIG_TIMER_EARLY=y CONFIG_USB=y CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_PCI=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_PCI=y +CONFIG_USB_OHCI_HCD=y +CONFIG_USB_OHCI_PCI=y +CONFIG_USB_STORAGE=y CONFIG_USB_KEYBOARD=y -- 2.42.0

3 2

[PATCH v2 0/3] bootstage support for risc-v
by Chanho Park 05 Sep '23

05 Sep '23

This adds to support bootstage for risc-v. timer_get_boot_us function is required to record each boot stages with microsecond timestamp. Changes from v1: - Correct #ifdef guard for riscv_aclint_timer and riscv_timer Chanho Park (3): riscv: bootstage: correct bootstage_report guard riscv: timer: add timer_get_boot_us for BOOTSTAGE timer: riscv_aclint_timer: add timer_get_boot_us for BOOTSTAGE arch/riscv/lib/bootm.c | 2 +- drivers/timer/riscv_aclint_timer.c | 22 ++++++++++++++++++++++ drivers/timer/riscv_timer.c | 21 +++++++++++++++++++++ 3 files changed, 44 insertions(+), 1 deletion(-) -- 2.39.2

3 10

[PATCH v2 0/2] risc-v: implement DBCN based debug console
by Heinrich Schuchardt 05 Sep '23

05 Sep '23

Currently we only offer an SBI based debug UART for SBI v0.1. With OpenSBI 1.3 the Debug Console Extension (DBCN) has become available. This allows us to implement a debug UART in a device independent manor. v2: In the driver check that we are in S-mode. Heinrich Schuchardt (2): risc-v: implement DBCN write byte risc-v: implement DBCN based debug console arch/riscv/include/asm/sbi.h | 1 + arch/riscv/lib/sbi.c | 16 ++++++++++++++++ drivers/serial/Kconfig | 5 ++++- drivers/serial/serial_sbi.c | 20 ++++++++++++++++++++ 4 files changed, 41 insertions(+), 1 deletion(-) -- 2.40.1

3 4

[PATCH 0/2] Remove Pali Rohár from MAINTAINERS
by Tom Rini 05 Sep '23

05 Sep '23

Pali, Your actions on the mailing list the past several months speak for themselves. I do not feel the need to summarize them again at this point. You are a persona non grata to this community at this point and I am now removing you from the MAINTAINERS files because of this. The rx51 platform is being removed and if you know someone else who wishes to bring it up to modern standards they can submit a patch to bring the platform back. I do wish to thank you for the time you have spent over the years, but I do not know what changed more recently to bring us to this state. I believe this is best long term for both you and this project. -- Tom

1 4

[PATCH v3 00/20] Kconfig: Tidy up some options
by Simon Glass 04 Sep '23

04 Sep '23

The view from 'make menuconfig' is confusing in places. This series aims to improve the top-level menu and also the boot menu. It also groups FDT-fixup options tegether, at least the ones I could fine. Finally this series marks the distro scripts as deprecated, so people have a pointer to standard boot. Changes in v3: - Drop comment about an update/ directory - Drop extra newline and quote - Add new patch to drop CMD_MTDPARTS condition for FDT_FIXUP_PARTITIONS - Drop patch 'Move SYS_RX_ETH_BUFFER into the network menu' Changes in v2: - Add new patch to move bmp code to drivers/video - Just move these options to driver/video for later consideration - Fix FMU typo in the subject - Drop now-unnecessary depends on FWU_MULTI_BANK_UPDATE - Mention in the DISTRO_DEFAULTS option that it is script-based - Expand and rewrite the commit message - Use the word 'Mark' instead of 'Make' to improve the English Simon Glass (20): lib: rational: Move the Kconfigs into the correct place Kconfig: Move API into general setup video: Move bmp code to drivers/video video: Move the BMP options video: Move BMP options and code to video directory FWU: Avoid showing an unselectable menu option test: Move POST under a renamed Testing section boot: Move fdt_support to boot/ Move fdt_simplefb to boot/ boot: Move some other fdt-fixup options to the same menu boot: Rename Android-boot text Kconfig: Create a menu for FIT Kconfig: Move SPL_FIT under FIT spl: Tidy up load address in spl_ram boot: Make standard boot a menu Kconfig: Move TEXT_BASE et al under general setup Mark DISTRO_DEFAULTS as deprecated boot: Join FDT_FIXUP_PARTITIONS with related options boot: Drop CMD_MTDPARTS condition for FDT_FIXUP_PARTITIONS boot: Join ARCH_FIXUP_FDT_MEMORY with related options Kconfig | 67 ++++++++++- boot/Kconfig | 200 +++++++++++++------------------- boot/Makefile | 4 + {common => boot}/fdt_simplefb.c | 0 {common => boot}/fdt_support.c | 0 common/Kconfig | 20 ---- common/Makefile | 4 - common/spl/spl_ram.c | 19 ++- doc/develop/bootstd.rst | 23 ++++ drivers/video/Kconfig | 27 +++++ drivers/video/Makefile | 3 + {common => drivers/video}/bmp.c | 0 lib/Kconfig | 17 +-- lib/fwu_updates/Kconfig | 9 +- test/Kconfig | 12 +- 15 files changed, 227 insertions(+), 178 deletions(-) rename {common => boot}/fdt_simplefb.c (100%) rename {common => boot}/fdt_support.c (100%) rename {common => drivers/video}/bmp.c (100%) -- 2.42.0.283.g2d96d420d3-goog

2 21

[PATCH 00/19] Kconfig: Tidy up some options
by Simon Glass 04 Sep '23

04 Sep '23

The view from 'make menuconfig' is confusing in places. This series aims to improve the top-level menu and also the boot menu. It also groups FDT-fixup options tegether, at least the ones I could fine. Finally this series marks the distro scripts as deprecated, so people have a pointer to standard boot. Simon Glass (19): lib: rational: Move the Kconfigs into the correct place Kconfig: Move API into general setup video: Hide the BMP options video: Move BMP options and code to video directory net: Move SYS_RX_ETH_BUFFER into the network menu FMU: Avoid showing an unselectable menu option test: Move POST under a renamed Testing section boot: Move fdt_support to boot/ Move fdt_simplefb to boot/ boot: Move some other fdt-fixup options to the same menu boot: Rename Android-boot text Kconfig: Create a menu for FIT Kconfig: Move SPL_FIT under FIT spl: Tidy up load address in spl_ram boot: Make standard boot a menu Kconfig: Move TEXT_BASE et al under general setup Make DISTRO_DEFAULTS as deprecated boot: Join FDT_FIXUP_PARTITIONS with related options boot: Join ARCH_FIXUP_FDT_MEMORY with related options Kconfig | 67 ++++++++++- boot/Kconfig | 202 +++++++++++++------------------- boot/Makefile | 4 + {common => boot}/fdt_simplefb.c | 0 {common => boot}/fdt_support.c | 0 common/Kconfig | 20 ---- common/Makefile | 4 - common/spl/spl_ram.c | 19 ++- doc/develop/bootstd.rst | 23 ++++ drivers/video/Kconfig | 11 ++ drivers/video/Makefile | 2 + {common => drivers/video}/bmp.c | 0 include/net.h | 9 +- lib/Kconfig | 17 +-- lib/fwu_updates/Kconfig | 6 +- net/Kconfig | 4 +- test/Kconfig | 12 +- 17 files changed, 220 insertions(+), 180 deletions(-) rename {common => boot}/fdt_simplefb.c (100%) rename {common => boot}/fdt_support.c (100%) rename {common => drivers/video}/bmp.c (100%) -- 2.42.0.rc1.204.g551eb34607-goog

5 27

[PATCH] binman: Fix SyntaxWarning: invalid escape sequence '\('
by Rong Tao 04 Sep '23

04 Sep '23

From: Rong Tao <rongtao(a)cestc.cn> Reproduct warning: $ sudo git clean -dfx $ make CROSS_COMPILE="" qemu-x86_64_defconfig $ sudo make -j8 ... u-boot/tools/binman/etype/section.py:25: SyntaxWarning: invalid escape sequence '\(' """Entry that contains other entries Signed-off-by: Rong Tao <rongtao(a)cestc.cn> --- tools/binman/etype/section.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py index fb49e85a7634..30c1041c7e8d 100644 --- a/tools/binman/etype/section.py +++ b/tools/binman/etype/section.py @@ -40,7 +40,7 @@ class Entry_section(Entry): For example code, see etypes which subclass `Entry_section`, or `cbfs.py` for a more involved example:: - $ grep -l \(Entry_section tools/binman/etype/*.py + $ grep -l \\(Entry_section tools/binman/etype/*.py ReadNode() Call `super().ReadNode()`, then read any special properties for the -- 2.41.0

2 1

[PATCH v2] usb: check for companion controller in uclass
by Fabrice Gasnier 04 Sep '23

04 Sep '23

EHCI is usually used with companion controller (like OHCI) as companion controller. This information on the companion is missing currently in companion drivers. So, if the usb-uclass isn't aware, it may scan busses in any order: OHCI first, then EHCI. This is seen on STM32MP1 where DT probing makes the probe order to occur by increasing address (OHCI address < EHCI address). When a low speed or full-speed device is plugged in, it's not detected as EHCI should first detect it, and give ownership (handover) to OHCI. Current situation on STM32MP1 (with a low speed device plugged-in) STM32MP> usb start starting USB... Bus usb@5800c000: USB OHCI 1.0 Bus usb@5800d000: USB EHCI 1.00 scanning bus usb@5800c000 for devices... 1 USB Device(s) found scanning bus usb@5800d000 for devices... 1 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found The "companion" property in the device tree allow to retrieve companion controller information, from the EHCI node. This allow marking the companion driver as such. With this patch (same low speed device plugged in): STM32MP> usb start starting USB... Bus usb@5800c000: USB OHCI 1.0 Bus usb@5800d000: USB EHCI 1.00 scanning bus usb@5800d000 for devices... 1 USB Device(s) found scanning bus usb@5800c000 for devices... 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found STM32MP> usb tree USB device tree: 1 Hub (12 Mb/s, 0mA) | U-Boot Root Hub | +-2 Human Interface (1.5 Mb/s, 100mA) HP HP USB 1000dpi Laser Mouse 1 Hub (480 Mb/s, 0mA) u-boot EHCI Host Controller This also optimize bus scan when a High speed device is plugged in, as the usb-uclass skips OHCI in this case: STM32MP> usb reset resetting USB... Bus usb@5800c000: USB OHCI 1.0 Bus usb@5800d000: USB EHCI 1.00 scanning bus usb@5800d000 for devices... 2 USB Device(s) found scanning usb for storage devices... 1 Storage Device(s) found STM32MP> usb tree USB device tree: 1 Hub (480 Mb/s, 0mA) | u-boot EHCI Host Controller | +-2 Mass Storage (480 Mb/s, 200mA) SanDisk Cruzer Blade 03003432021922011407 Signed-off-by: Fabrice Gasnier <fabrice.gasnier(a)foss.st.com> --- Changes in v2: - move companion probing from generic ehci driver to usb-uclass, after Marek's questions on design choice. - rename commit title to follow this change --- drivers/usb/host/usb-uclass.c | 36 +++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c index 02c0138a2065..e238eee8c84d 100644 --- a/drivers/usb/host/usb-uclass.c +++ b/drivers/usb/host/usb-uclass.c @@ -249,6 +249,37 @@ static void remove_inactive_children(struct uclass *uc, struct udevice *bus) } } +static int usb_probe_companion(struct udevice *bus) +{ + struct udevice *companion_dev; + int ret; + + /* + * Enforce optional companion controller is marked as such in order to + * 1st scan the primary controller, before the companion controller + * (ownership is given to companion when low or full speed devices + * have been detected). + */ + ret = uclass_get_device_by_phandle(UCLASS_USB, bus, "companion", &companion_dev); + if (!ret) { + struct usb_bus_priv *companion_bus_priv; + + debug("%s is the companion of %s\n", companion_dev->name, bus->name); + companion_bus_priv = dev_get_uclass_priv(companion_dev); + companion_bus_priv->companion = true; + } else if (ret && ret != -ENOENT && ret != -ENODEV) { + /* + * Treat everything else than no companion or disabled + * companion as an error. (It may not be enabled on boards + * that have a High-Speed HUB to handle FS and LS traffic). + */ + printf("Failed to get companion (ret=%d)\n", ret); + return ret; + } + + return 0; +} + int usb_init(void) { int controllers_initialized = 0; @@ -299,6 +330,11 @@ int usb_init(void) printf("probe failed, error %d\n", ret); continue; } + + ret = usb_probe_companion(bus); + if (ret) + continue; + controllers_initialized++; usb_started = true; } -- 2.25.1

2 7

[PATCH] event.h: Documented some newly added portions better
by Tom Rini 04 Sep '23

04 Sep '23

After the merge of v2023.10-rc4 to next include/event.h needs to be fully documented in order for documentation builds to complete. Rewords two of the event_t descriptions to be docbook style and better match the rest of this enum. Fix two typos (flag->flags) in other comments. Signed-off-by: Tom Rini <trini(a)konsulko.com> --- include/event.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/event.h b/include/event.h index c37deae94527..311df878c4a5 100644 --- a/include/event.h +++ b/include/event.h @@ -94,18 +94,19 @@ enum event_t { */ EVT_MISC_INIT_F, - /* - * Emitted before relocation to set up Firmware Support Package - * + /** + * @EVT_FSP_INIT_F: + * This event is triggered before relocation to set up Firmware Support + * Package. * Where U-Boot relies on binary blobs to handle part of the system * init, this event can be used to set up the blobs. This is used on * some Intel platforms */ EVT_FSP_INIT_F, - /* - * Emitted just before jumping to the main loop - * + /** + * @EVT_LAST_STAGE_INIT: + * This event is triggered just before jumping to the main loop. * Some boards need to perform initialisation immediately before control * is passed to the command-line interpreter (e.g. for init that depend * on later phases in the init sequence). @@ -222,7 +223,7 @@ typedef int (*event_handler_simple_t)(void); * * @func: Function to call when the event is activated (must be first) * @type: Event type - * @flag: Flags for this spy + * @flags: Flags for this spy * @id: Event id string */ struct evspy_info { @@ -241,7 +242,7 @@ struct evspy_info { * * @func: Function to call when the event is activated (must be first) * @type: Event type - * @flag: Flags for this spy + * @flags: Flags for this spy * @id: Event id string */ struct evspy_info_simple { -- 2.34.1

1 1