July 2023 - U-Boot

[PATCH 0/4 v2] Reconnect controllers on failues
by Ilias Apalodimas 09 Jul '23

09 Jul '23

Hi, This is a resend of [0] trying to reconnect drivers gracefully in case of a protocol removal failure. Changes since v1: - Fix an existing memory leak when uninstalling a protocol. The opened protocol information was never released - Drop a patch that was incorrectly trying to free protocols on the handle that were not associated with the driver being released - Rewrite the sefltests and instead of installing a second driver handle on the controller handle, force the controller to return EFI_DEVICE_ERROR on the first removal. When that happens all the children, that are disconnected before the controller, must be reconnected - Reconnect all controllers on the handle if after disconnecting drivers and closing protocols opened by GET_PROTOCOL, TEST_PROTOCOL, HANDLE_PROTOCOL opened protocols are still present in the handle [0] https://lore.kernel.org/u-boot/20230615143941.416924-1-ilias.apalodimas@lin… Regards /Ilias Ilias Apalodimas (4): efi_loader: reconnect drivers on failure efi_loader: check the status of disconnected drivers efi_loader: fix the return codes of UninstallProtocol efi_selftests: add extra testcases on controller handling lib/efi_loader/efi_boottime.c | 43 ++++++++++++++++---- lib/efi_selftest/efi_selftest_controllers.c | 44 +++++++++++++++++++-- 2 files changed, 77 insertions(+), 10 deletions(-) -- 2.40.1

2 7

[PATCH] x86: Update docs link in bootparam header
by Paul Barker 09 Jul '23

09 Jul '23

After Linux commit ff61f0791ce9, x86 documentation was moved to arch/x86 and the link in bootparam.h was broken. Signed-off-by: Paul Barker <paul.barker.ct(a)bp.renesas.com> --- arch/x86/include/asm/bootparam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/bootparam.h b/arch/x86/include/asm/bootparam.h index ea816ca74698..1f8ca569b880 100644 --- a/arch/x86/include/asm/bootparam.h +++ b/arch/x86/include/asm/bootparam.h @@ -62,7 +62,7 @@ struct setup_indirect { /** * struct setup_header - Information needed by Linux to boot * - * See https://www.kernel.org/doc/html/latest/x86/boot.html + * See https://docs.kernel.org/arch/x86/boot.html */ struct setup_header { __u8 setup_sects; base-commit: 923de765ee1a5b26310f02cb42dcbad9e2b011c5 -- 2.34.1

3 3

[PATCH 1/1] doc: harmonize Linux kernel documentation links
by Heinrich Schuchardt 09 Jul '23

09 Jul '23

Linux internally uses https://www.kernel.org/doc/html/latest/ for documentation links. When referring to their documentation we should do the same. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- doc/develop/docstyle.rst | 2 +- doc/usage/blkmap.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/develop/docstyle.rst b/doc/develop/docstyle.rst index f9ba83a559..50506d6857 100644 --- a/doc/develop/docstyle.rst +++ b/doc/develop/docstyle.rst @@ -20,7 +20,7 @@ We apply the following rules: * For documentation we use reStructured text conforming to the requirements of `Sphinx <https://www.sphinx-doc.org>`_. * For documentation within code we follow the Linux kernel guide - `Writing kernel-doc comments <https://docs.kernel.org/doc-guide/kernel-doc.html>`_. + `Writing kernel-doc comments <https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html>`_. * We try to stick to 80 columns per line in documents. * For tables we prefer simple tables over grid tables. We avoid list tables as they make the reStructured text documents hard to read. diff --git a/doc/usage/blkmap.rst b/doc/usage/blkmap.rst index dbfa8e5aad..7337ea507a 100644 --- a/doc/usage/blkmap.rst +++ b/doc/usage/blkmap.rst @@ -19,7 +19,7 @@ wherever they might be located. The implementation is loosely modeled on Linux's "Device Mapper" subsystem, see `kernel documentation`_ for more information. -.. _kernel documentation: https://docs.kernel.org/admin-guide/device-mapper/index.html +.. _kernel documentation: https://www.kernel.org/doc/html/latest/admin-guide/device-mapper/index.html Example: Netbooting an Ext4 Image -- 2.40.1

1 0

[PATCH] cmd: efidebug: add missing efi_free_pool for dh subcommand
by Masahisa Kojima 09 Jul '23

09 Jul '23

This adds the missing efi_free_pool call for dh subcommand. Signed-off-by: Masahisa Kojima <masahisa.kojima(a)linaro.org> --- cmd/efidebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 9622430c47..0be3af3e76 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -486,6 +486,7 @@ static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag, if (guidcmp(guid[j], &efi_guid_device_path)) printf(" %pUs\n", guid[j]); } + efi_free_pool(guid); } efi_free_pool(handles); -- 2.34.1

3 2

[PATCH] sysreset: Change Kconfig GPIO dependency
by Michal Simek 08 Jul '23

08 Jul '23

DM_GPIO depends on GPIO to be enabled but select will cause that DM_GPIO is selected without GPIO which ends up in compilation error: undefined reference to `dm_gpio_set_value' undefined reference to `dm_gpio_get_value' undefined reference to `dm_gpio_free' undefined reference to `gpio_request_by_name' Signed-off-by: Michal Simek <michal.simek(a)amd.com> --- drivers/sysreset/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sysreset/Kconfig b/drivers/sysreset/Kconfig index 03f7fdd59785..bdbe2a95364d 100644 --- a/drivers/sysreset/Kconfig +++ b/drivers/sysreset/Kconfig @@ -61,14 +61,14 @@ endif config POWEROFF_GPIO bool "Enable support for GPIO poweroff driver" - select DM_GPIO + depends on DM_GPIO help Support for system poweroff using a GPIO pin. This can be used for systems having a single GPIO to trigger a system poweroff. config SYSRESET_GPIO bool "Enable support for GPIO reset driver" - select DM_GPIO + depends on DM_GPIO help Reset support via GPIO pin connected reset logic. This is used for example on Microblaze where reset logic can be controlled via GPIO -- 2.36.1

2 1

[PATCH] sql: Kconfig: TPL_BANNER_PRINT depends on DEBUG_UART && TPL_SERIAL
by sunying＠nj.iscas.ac.cn 08 Jul '23

08 Jul '23

From: Ying Sun <sunying(a)nj.iscas.ac.cn> As implemented in the arch/arm/mach-rockchip/tpl.c file, the CONFIG_TPL_BANNER_PRINT option will not work if either of these options is not enabled. Add dependency constraints to the CONFIG_TPL_BANNER_PRINT option definition to prevent configuration problems where option is enabled but do not take effect. Suggested-by: Yanjie Ren <renyanjie01(a)gmail.com> Signed-off-by: Ying Sun <sunying(a)nj.iscas.ac.cn> --- common/spl/Kconfig.tpl | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig.tpl b/common/spl/Kconfig.tpl index 1874f9db4f..3d6cf1e59f 100644 --- a/common/spl/Kconfig.tpl +++ b/common/spl/Kconfig.tpl @@ -43,6 +43,7 @@ config TPL_FRAMEWORK config TPL_BANNER_PRINT bool "Enable output of the TPL banner 'U-Boot TPL ...'" + depends on DEBUG_UART && TPL_SERIAL default y help If this option is enabled, TPL will print the banner with version -- 2.17.1

3 2

[PATCH] common: Kconfig: SYS_CONSOLE_ENV_OVERWRITE depends on SYS_CONSOLE_IS_IN_ENV
by sunying＠nj.iscas.ac.cn 08 Jul '23

08 Jul '23

From: Ying Sun <sunying(a)nj.iscas.ac.cn> CONFIG_SYS_CONSOLE_ENV_OVERWRITE is implemented in common/console.c when "#if CONFIG_IS_ENABLED(SYS_CONSOLE_IS_IN_ENV)" is met. It is recommended to add dependency constraints to its definition. Suggested-by: Yanjie Ren <renyanjie01(a)gmail.com> Signed-off-by: Ying Sun <sunying(a)nj.iscas.ac.cn> --- common/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/Kconfig b/common/Kconfig index bbabadb35e..42baca20a6 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -256,6 +256,7 @@ config SYS_CONSOLE_OVERWRITE_ROUTINE config SYS_CONSOLE_ENV_OVERWRITE bool "Update environment variables during console init" + depends on SYS_CONSOLE_IS_IN_ENV help The console environment variables (stdout, stdin, stderr) can be used to determine the correct console devices on start-up. This -- 2.17.1

2 1

[PATCH] cmd: CONFIG_CMD_SAVES depends on CONFIG_CMD_LOADS
by sunying＠nj.iscas.ac.cn 08 Jul '23

08 Jul '23

From: Ying Sun <sunying(a)nj.iscas.ac.cn> CONFIG_CMD_SAVES is used to enable support for the "saveenv" command and is only implemented in cmd/load.c when "#if defined(CONFIG_CMD_LOADS)" is met. It is recommended to add dependency constraints to its definition. Prevents "saveenv" command from not being supported when "CONFIG_CMD_SAVES=y CONFIG_CMD_LOADS=n". Suggested-by: Yanjie Ren <renyanjie01(a)gmail.com> Signed-off-by: Ying Sun <sunying(a)nj.iscas.ac.cn> --- cmd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 02e54f1e50..c1941849f9 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1228,6 +1228,7 @@ config LOADS_ECHO config CMD_SAVES bool "saves - Save a file over serial in S-Record format" + depends on CMD_LOADS help Provides a way to save a binary file using the Motorola S-Record format over the serial line. -- 2.17.1

3 2

[PATCH] efi_loader: Avoid underflow when calculating remaining var store size
by Alper Nebi Yasak 08 Jul '23

08 Jul '23

The efi_var_mem_free() function calculates the available size for a new EFI variable by subtracting the occupied buffer size and the overhead for a new variable from the maximum buffer size set in Kconfig. This is then returned as QueryVariableInfo()'s RemainingVariableStorageSize output. This can underflow as the calculation is done in and processed as unsigned integer types. Check for underflow before doing the subtraction and return zero if there's no space. Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> --- lib/efi_loader/efi_var_mem.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c index d6b65aed12ea..5fa7dcb8d3ed 100644 --- a/lib/efi_loader/efi_var_mem.c +++ b/lib/efi_loader/efi_var_mem.c @@ -177,6 +177,10 @@ efi_status_t __efi_runtime efi_var_mem_ins( u64 __efi_runtime efi_var_mem_free(void) { + if (efi_var_buf->length + sizeof(struct efi_var_entry) >= + EFI_VAR_BUF_SIZE) + return 0; + return EFI_VAR_BUF_SIZE - efi_var_buf->length - sizeof(struct efi_var_entry); } -- 2.40.1

1 0

[PATCH] doc: fix typo in README.usb
by Enguerrand de Ribaucourt 08 Jul '23

08 Jul '23

Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt(a)savoirfairelinux.com> --- doc/README.usb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/README.usb b/doc/README.usb index ef1d6ba36..b4c3ef522 100644 --- a/doc/README.usb +++ b/doc/README.usb @@ -63,7 +63,7 @@ Common USB Commands: Storage USB Commands: - usb scan: scans the USB for storage devices.The USB must be running for this command (usb start) -- usb device [dev]: show or set current USB staorage device +- usb device [dev]: show or set current USB storage device - usb part [dev]: print partition table of one or all USB storage devices - usb read addr blk# cnt: -- 2.34.1

2 1