December 2023 - U-Boot

[PATCH v6 0/5] Populate kaslr seed with RNG
by Sean Edmond 16 Dec '23

16 Dec '23

This patch series creates a common API (fdt_fixup_kaslr_seed()) for populating the kaslr seed in the DTB. Existing users (kaslrseed, and ARMv8 sec firmware) have been updated to use this common API. New functionality has been introduced to populate the kaslr using the RNG. This can be enabled with CONFIG_RNG_TPM_SEED. Changes in v6: - root_ofnode_from_fdt()->ofnode_root_from_fdt() - Enclose fdt_rng_kaslr_seed() in "#if defined(CONFIG_KASLR_RNG_SEED)" Changes in v5: - include dm/ofnode-decl.h instead of dm/ofnode.h - cast buffer to (u8 *) in kaslrseed.c - Always enable OFNODE_MULTI_TREE Changes in v4: - Fix compile issue when CONFIG_OF_CONTROL not set Changes in v3: - Use event spy to do the FDT fixup - Populate with RNG device instead of TPM device (this is a more generic solution) - fix compile error for sandbox for !OFNODE_MULTI_TREE Changes in v2: - fdt_fixup_kaslr_seed() uses the ofnode API - Add root_ofnode_from_fdt() to get the root node from an FDT and perform error checking on the oftree - add comments to exported functions - Add error checking in image_setup_libfdt() for return from fdt_tpm_kaslr_seed() - uclass_get_device() -> uclass_first_device_err() - Change default config for OFNODE_MULTI_TREE (y if !OF_LIVE) Dhananjay Phadke (2): fdt: common API to populate kaslr seed fdt: kaslr seed from RNG device Sean Edmond (3): cmd: kaslrseed: Use common API to fixup FDT dm: core: Modify default for OFNODE_MULTI_TREE fdt: Fix compile error for !OFNODE_MULTI_TREE arch/arm/cpu/armv8/sec_firmware.c | 39 ++++++++-------------- boot/fdt_support.c | 54 +++++++++++++++++++++++++++++++ cmd/kaslrseed.c | 20 ++++-------- configs/sandbox_defconfig | 2 +- drivers/core/Kconfig | 3 +- drivers/core/ofnode.c | 29 +++++++++++++---- include/dm/ofnode.h | 12 +++++++ include/fdt_support.h | 9 ++++++ lib/Kconfig | 7 ++++ 9 files changed, 129 insertions(+), 46 deletions(-) -- 2.42.0

2 7

Where to find those definition for particular boards? CFG_SYS_INIT_RAM_ADDR, CFG_SYS_INIT_RAM_SIZE, GENERATED_GBL_DATA_SIZE? etc.
by Pei Jia 16 Dec '23

16 Dec '23

Hi, all: I'm using a *BeagleV-Fire*, However, I failed to build *u-boot*, and now traced to this step. Where to find those *macro values* specifically for this board *BeagleV-Fire*? #ifdef CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR #define SYS_INIT_SP_ADDR CONFIG_CUSTOM_SYS_INIT_SP_ADDR #else #ifdef CONFIG_MIPS #define SYS_INIT_SP_ADDR (CFG_SYS_SDRAM_BASE + CFG_SYS_INIT_SP_OFFSET) #else #define SYS_INIT_SP_ADDR \ (CFG_SYS_INIT_RAM_ADDR + CFG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) #endif #endif Cheers -- Dr. Pei Jia Email: jiapei(a)longervision.com Cell: +1 778-863-5816 <tel:+17788635816> Website: https://www.longervision.ca

2 1

[PATCH] arm: Add OVERLAY command to BSS section
by Marek Vasut 16 Dec '23

16 Dec '23

Avoid allocating and loading the BSS section. $ aarch64-linux-gnu-objdump -Sh u-boot Before: 10 .bss_start 00000000 00000000000f21d8 00000000000f21d8 001021d8 2**0 CONTENTS, ALLOC, LOAD, DATA 11 .bss 000068f8 00000000000f2200 00000000000f2200 001021d8 2**6 ALLOC 12 .bss_end 00000000 00000000000f8af8 00000000000f8af8 00108af8 2**0 CONTENTS, ALLOC, LOAD, DATA After: 10 .bss_start 00000000 00000000000f21d8 00000000000f21d8 001021d8 2**0 CONTENTS 11 .bss 000068f8 00000000000f2200 00000000000f2200 00102200 2**6 CONTENTS 12 .bss_end 00000000 00000000000f21d8 00000000000f21d8 00108af8 2**0 CONTENTS Signed-off-by: Marek Vasut <marek.vasut+renesas(a)mailbox.org> --- Cc: Simon Glass <sjg(a)chromium.org> Cc: Tom Rini <trini(a)konsulko.com> --- arch/arm/cpu/armv8/u-boot.lds | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/cpu/armv8/u-boot.lds b/arch/arm/cpu/armv8/u-boot.lds index fb6a30c922f..25838b9892c 100644 --- a/arch/arm/cpu/armv8/u-boot.lds +++ b/arch/arm/cpu/armv8/u-boot.lds @@ -151,16 +151,16 @@ SECTIONS . = ALIGN(8); - .bss_start : { + .bss_start (OVERLAY) : { KEEP(*(.__bss_start)); } - .bss : { + .bss (OVERLAY) : { *(.bss*) . = ALIGN(8); } - .bss_end : { + .bss_end (OVERLAY) : { KEEP(*(.__bss_end)); } -- 2.43.0

3 2

Where is the u-boot for BeagleV-Fire?
by Pei Jia 16 Dec '23

16 Dec '23

Where can I find the u-boot defconfig file for BeagleV-Fire? I've got an issue posted at https://forum.beagleboard.org/t/error-illegal-operands-li-t1/36823 . Thank you... -- Dr. Pei Jia Email: jiapei(a)longervision.com Cell: +1 778-863-5816 <tel:+17788635816> Website: https://www.longervision.ca

2 1

[PATCH v2 0/4] cmd: acpi: correct handling of DSDT and FACS
by Heinrich Schuchardt 16 Dec '23

16 Dec '23

Fields X_FIRMWARE and X_DSDT in the FADT table must be 64bit. Fix the definition in our include. The 64bit fields X_FIRMWARE and X_DSDT take precedence over the respective 32bit fields. Consider this in the 'acpi list' and 'acpi dump' commands. The fields only exist for FADT table revision 3 and above. Don't fill unused fields FIRMWAE and DSDT. Write an error if the hardware reduce flag is not set for non-x86 systems. v2: check FADT table revision correct dumping DSDT and FACS Heinrich Schuchardt (4): acpi: fix FADT table cmd: acpi: fix listing DSDT and FACS cmd: acpi: check HW reduced flag in acpi list aci: fix acpi_find_table() for DSDT and FACS arch/x86/cpu/baytrail/acpi.c | 8 ++------ arch/x86/cpu/quark/acpi.c | 8 ++------ arch/x86/cpu/tangier/acpi.c | 8 ++------ arch/x86/lib/acpi_table.c | 9 ++------- cmd/acpi.c | 12 ++++++++++-- include/acpi/acpi_table.h | 6 ++---- lib/acpi/acpi.c | 29 ++++++++++++++++++++++++----- 7 files changed, 44 insertions(+), 36 deletions(-) -- 2.40.1

3 7

[PATCH] arm: dts: rockpro64: Add RockPro64 smbios
by Shantur Rathore 16 Dec '23

16 Dec '23

--- arch/arm/dts/rk3399-rockpro64.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399-rockpro64.dtsi index 6bff8db7d3..cf850a69e6 100644 --- a/arch/arm/dts/rk3399-rockpro64.dtsi +++ b/arch/arm/dts/rk3399-rockpro64.dtsi @@ -20,6 +20,26 @@ stdout-path = "serial2:1500000n8"; }; + smbios { + compatible = "u-boot,sysinfo-smbios"; + smbios { + system { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + baseboard { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + + chassis { + manufacturer = "PINE64"; + product = "RockPro64"; + }; + }; + }; + clkin_gmac: external-gmac-clock { compatible = "fixed-clock"; clock-frequency = <125000000>; -- 2.40.1

5 13

[PATCH v2 0/2] tools: Fix build without host OpenSSL
by Alexander Dahl 16 Dec '23

16 Dec '23

Hei hei, every now and then some user wants to build without having to install OpenSSL development libraries on the build host for different reasons. This is not possible for all boards supported by U-Boot and not for all configurations, but at least for some. And U-Boot has an option for that, which currently does not work. The topic was discussed multiple times and multiple patches were proposed to fix things, but to my knowledge none got applied. I'm aware of at least the discussions listed below. This series is based on the work done by Paul-Erwan Rio earlier this year, but replacing the first of two patches by a new patch based on two older approaches from 2021 and 2022 and the feedback they got. Because of that, I gave it the v2 right away. I added some notes to both patches for further explanations on my decisions. I tested this with and without libssl-dev installed on a Debian GNU/Linux 12 (bookworm) host (amd64 arch), with buildman and the following options: buildman -b master..mybranch -a '~CONFIG_TOOLS_KWBIMAGE' -a '~CONFIG_TOOLS_LIBCRYPTO' atmel And with libssl-dev installed this: buildman -b master..mybranch atmel buildman -b master..mybranch turris Building 'turris' without libssl-dev installed fails as expected. The series solves _my_ immediate problem (building a recent U-Boot for an at91 based board _without_ FIT images and/or signing, in a BSP from 2018 which we can not update, and which does not handle host openssl correctly), but I did not investigate other combinations, except those listed above. Test on real hardware was only on our at91 based boards. Please test and let me know what you think. I can imagine having CI testing builds with and without CONFIG_TOOLS_LIBCRYPTO set might be difficult, because building without won't work for every board. It can not, because some boards require it while others don't. Greets Alex Cc: Marek Vasut <marex(a)denx.de> Cc: Paul-Erwan Rio <paulerwan.rio(a)gmail.com> Cc: Simon Glass <sjg(a)chromium.org> Cc: Stefan Roese <sr(a)denx.de> Link: https://lore.kernel.org/u-boot/20211021093304.25399-1-pali@kernel.org/ Link: https://lore.kernel.org/u-boot/20220111153120.1276641-1-marex@denx.de/ Link: https://lore.kernel.org/u-boot/1884029.XjOfZupGQm@ada/ Link: https://lore.kernel.org/u-boot/20230121154743.667253-1-paulerwan.rio@gmail.… Link: https://lore.kernel.org/u-boot/AM6PR04MB61521B84F78571B282FE1D828FD5A@AM6PR… Alexander Dahl (1): tools: kwbimage: Allow disabling build on non-mvebu platforms Paul-Erwan Rio (1): tools: fix build without LIBCRYPTO support arch/arm/mach-mvebu/Kconfig | 1 + include/image.h | 2 +- tools/Kconfig | 6 ++++++ tools/Makefile | 5 ++++- tools/fit_image.c | 2 +- tools/image-host.c | 4 ++++ tools/mkimage.c | 5 +++-- 7 files changed, 20 insertions(+), 5 deletions(-) base-commit: 27089f1e4d11fd7e0619097b59258d0428cde2ac -- 2.39.2

3 4

[PATCH v1 0/8] Convert Tegra pinctrl to DM
by Svyatoslav Ryhel 16 Dec '23

16 Dec '23

Create a DM supported wrapper arround existing Tegra pinmux logic. This implementation is backwards compatible with all existing board setups and early stages of setup. All new boards must be device tree based. Linux dts pinmux nodes are fully compatible with this driver. As an example I have converted recently merged T30 boards to this layout (I have those devices and was able to test them properly) and Paz00 T20 board which was tested as well by owner. Svyatoslav Ryhel (8): ARM: mach-tegra: rearrange SPL configs drivers: pinctrl: create Tegra DM pinctrl driver drivers: pinctrl: tegra: incorporate existing code board: asus: grouper: switch to DM pinmux board: lg: x3-t30: switch to DM pinmux board: asus: transformer: switch to DM pinmux board: htc: endeavoru: switch to DM pinmux board: compal: paz00: clean up the board arch/arm/dts/tegra20-paz00.dts | 4 +- arch/arm/dts/tegra30-asus-grouper-common.dtsi | 712 ++++++++++ .../dts/tegra30-asus-nexus7-grouper-E1565.dts | 113 ++ .../dts/tegra30-asus-nexus7-grouper-PM269.dts | 113 ++ .../dts/tegra30-asus-nexus7-tilapia-E1565.dts | 149 +++ arch/arm/dts/tegra30-asus-p1801-t.dts | 982 ++++++++++++++ arch/arm/dts/tegra30-asus-tf201.dts | 45 + arch/arm/dts/tegra30-asus-tf300t.dts | 45 + arch/arm/dts/tegra30-asus-tf300tg.dts | 128 ++ arch/arm/dts/tegra30-asus-tf300tl.dts | 163 +++ arch/arm/dts/tegra30-asus-tf600t.dts | 889 +++++++++++++ arch/arm/dts/tegra30-asus-tf700t.dts | 53 + arch/arm/dts/tegra30-asus-transformer.dtsi | 984 ++++++++++++++ arch/arm/dts/tegra30-htc-endeavoru.dts | 1147 +++++++++++++++++ arch/arm/dts/tegra30-lg-p880.dts | 90 ++ arch/arm/dts/tegra30-lg-p895.dts | 93 ++ arch/arm/dts/tegra30-lg-x3.dtsi | 845 ++++++++++++ arch/arm/include/asm/arch-tegra114/pinmux.h | 303 +++++ arch/arm/include/asm/arch-tegra124/pinmux.h | 327 +++++ arch/arm/include/asm/arch-tegra20/pinmux.h | 291 +++++ arch/arm/include/asm/arch-tegra210/pinmux.h | 394 ++++++ arch/arm/include/asm/arch-tegra30/pinmux.h | 381 ++++++ arch/arm/mach-tegra/Kconfig | 16 +- arch/arm/mach-tegra/Makefile | 1 - arch/arm/mach-tegra/board.c | 6 +- arch/arm/mach-tegra/board2.c | 2 +- arch/arm/mach-tegra/tegra114/Makefile | 2 +- arch/arm/mach-tegra/tegra124/Makefile | 2 - arch/arm/mach-tegra/tegra20/Makefile | 2 +- arch/arm/mach-tegra/tegra210/Makefile | 1 - arch/arm/mach-tegra/tegra30/Makefile | 2 +- board/asus/grouper/grouper.c | 18 - board/asus/grouper/pinmux-config-grouper.h | 362 ------ .../pinmux-config-transformer.h | 365 ------ board/asus/transformer-t30/transformer-t30.c | 23 - board/compal/paz00/Makefile | 8 - board/compal/paz00/paz00.c | 53 - board/htc/endeavoru/endeavoru.c | 14 - board/htc/endeavoru/pinmux-config-endeavoru.h | 362 ------ board/lg/x3-t30/Kconfig | 12 - board/lg/x3-t30/configs/p880.config | 1 - board/lg/x3-t30/configs/p895.config | 1 - board/lg/x3-t30/pinmux-config-x3.h | 449 ------- board/lg/x3-t30/x3-t30.c | 23 - configs/paz00_defconfig | 3 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/tegra/Kconfig | 18 + drivers/pinctrl/tegra/Makefile | 16 + .../pinctrl/tegra/funcmux-tegra114.c | 0 .../pinctrl/tegra/funcmux-tegra124.c | 0 .../pinctrl/tegra/funcmux-tegra20.c | 0 .../pinctrl/tegra/funcmux-tegra210.c | 0 .../pinctrl/tegra/funcmux-tegra30.c | 0 drivers/pinctrl/tegra/pinctrl-tegra.c | 248 ++++ drivers/pinctrl/tegra/pinctrl-tegra20.c | 177 +++ .../pinctrl/tegra}/pinmux-common.c | 0 .../pinctrl/tegra/pinmux-tegra114.c | 0 .../pinctrl/tegra/pinmux-tegra124.c | 0 .../pinctrl/tegra/pinmux-tegra20.c | 0 drivers/pinctrl/tegra/pinmux-tegra210.c | 190 +++ .../pinctrl/tegra/pinmux-tegra30.c | 0 include/configs/x3-t30.h | 13 +- 63 files changed, 8920 insertions(+), 1723 deletions(-) delete mode 100644 board/asus/grouper/pinmux-config-grouper.h delete mode 100644 board/asus/transformer-t30/pinmux-config-transformer.h delete mode 100644 board/compal/paz00/Makefile delete mode 100644 board/compal/paz00/paz00.c delete mode 100644 board/htc/endeavoru/pinmux-config-endeavoru.h delete mode 100644 board/lg/x3-t30/pinmux-config-x3.h create mode 100644 drivers/pinctrl/tegra/Kconfig create mode 100644 drivers/pinctrl/tegra/Makefile rename arch/arm/mach-tegra/tegra114/funcmux.c => drivers/pinctrl/tegra/funcmux-tegra114.c (100%) rename arch/arm/mach-tegra/tegra124/funcmux.c => drivers/pinctrl/tegra/funcmux-tegra124.c (100%) rename arch/arm/mach-tegra/tegra20/funcmux.c => drivers/pinctrl/tegra/funcmux-tegra20.c (100%) rename arch/arm/mach-tegra/tegra210/funcmux.c => drivers/pinctrl/tegra/funcmux-tegra210.c (100%) rename arch/arm/mach-tegra/tegra30/funcmux.c => drivers/pinctrl/tegra/funcmux-tegra30.c (100%) create mode 100644 drivers/pinctrl/tegra/pinctrl-tegra.c create mode 100644 drivers/pinctrl/tegra/pinctrl-tegra20.c rename {arch/arm/mach-tegra => drivers/pinctrl/tegra}/pinmux-common.c (100%) rename arch/arm/mach-tegra/tegra114/pinmux.c => drivers/pinctrl/tegra/pinmux-tegra114.c (100%) rename arch/arm/mach-tegra/tegra124/pinmux.c => drivers/pinctrl/tegra/pinmux-tegra124.c (100%) rename arch/arm/mach-tegra/tegra20/pinmux.c => drivers/pinctrl/tegra/pinmux-tegra20.c (100%) create mode 100644 drivers/pinctrl/tegra/pinmux-tegra210.c rename arch/arm/mach-tegra/tegra30/pinmux.c => drivers/pinctrl/tegra/pinmux-tegra30.c (100%) -- 2.40.1

3 14

[PATCH v3 08/16] fastboot: Remove dependencies on CMDLINE
by Simon Glass 16 Dec '23

16 Dec '23

It is possible to boot a kernel without CMDLINE being enabled. Update the implementation to handle this, and drop the condition from the FASTBOOT config. Reviewed-by: Mattijs Korpershoek <mkorpershoek(a)baylibre.com> Signed-off-by: Simon Glass <sjg(a)chromium.org> --- Changes in v3: - Expand the fastboot help Changes in v2: - Avoid changing the logic when a command is not set drivers/fastboot/Kconfig | 5 ++++- drivers/fastboot/fb_common.c | 30 ++++++++++++++---------------- 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig index 11fc0fe1c800..449244ab6a8e 100644 --- a/drivers/fastboot/Kconfig +++ b/drivers/fastboot/Kconfig @@ -1,5 +1,4 @@ menu "Fastboot support" - depends on CMDLINE config FASTBOOT bool @@ -13,6 +12,10 @@ config FASTBOOT More information about the protocol and usecases: https://android.googlesource.com/platform/system/core/+/refs/heads/master/f… + Note that enabling CMDLINE is recommended since fastboot allows U-Boot + commands to be executed on request. The CMDLINE option is required + for anything other than simply booting the OS. + config USB_FUNCTION_FASTBOOT bool "Enable USB fastboot gadget" depends on USB_GADGET diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c index 07f5946d9ed1..595954542a6e 100644 --- a/drivers/fastboot/fb_common.c +++ b/drivers/fastboot/fb_common.c @@ -11,6 +11,7 @@ */ #include <bcb.h> +#include <bootm.h> #include <common.h> #include <command.h> #include <env.h> @@ -142,22 +143,19 @@ void (*fastboot_get_progress_callback(void))(const char *) */ void fastboot_boot(void) { - char *s; - - s = env_get("fastboot_bootcmd"); - if (s) { - run_command(s, CMD_FLAG_ENV); - } else if (IS_ENABLED(CONFIG_CMD_BOOTM)) { - static char boot_addr_start[20]; - static char *const bootm_args[] = { - "bootm", boot_addr_start, NULL - }; - - snprintf(boot_addr_start, sizeof(boot_addr_start) - 1, - "%lx", fastboot_buf_addr); - printf("Booting kernel at %s...\n\n\n", boot_addr_start); - - do_bootm(NULL, 0, 2, bootm_args); + char *s = NULL; + + if (IS_ENABLED(CONFIG_CMDLINE)) { + s = env_get("fastboot_bootcmd"); + if (s) + run_command(s, CMD_FLAG_ENV); + } + + if (!s && IS_ENABLED(CONFIG_BOOTM)) { + int ret; + + printf("Booting kernel at %lx...\n\n\n", fastboot_buf_addr); + ret = bootm_boot_start(fastboot_buf_addr, NULL); /* * This only happens if image is somehow faulty so we start -- 2.43.0.472.g3155946c3a-goog

2 1

[GIT PULL] clock changes for u-boot/next
by Sean Anderson 16 Dec '23

16 Dec '23

The following changes since commit fa3f19aa56c519d6345cc774187b7a8fdc053d71: Merge tag 'xilinx-for-v2024.04-rc1' of https://source.denx.de/u-boot/custodians/u-boot-microblaze into next (2023-12-14 13:27:11 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-clk.git tags/clk-2024.01-next for you to fetch changes up to 652d8d4561a34fc71d9bcb6ad2b0035d2c4189c1: clk: nuvoton: add read only feature for clk driver (2023-12-15 13:05:55 -0500) ---------------------------------------------------------------- clock patches for u-boot/next The main thing in here is Igor's conversion of soc_clk_dump to a clk_ops member. There's also a write-protect feature for nuvoton clocks. Signed-off-by: Sean Anderson <seanga2(a)gmail.com> ---------------------------------------------------------------- Igor Prusov (8): clk: zynq: Move soc_clk_dump to Zynq clock driver clk: ast2600: Move soc_clk_dump function clk: k210: Move soc_clk_dump function clk: amlogic: Move driver and ops structs clk: Add dump operation to clk_ops cmd: clk: Use dump function from clk_ops clk: treewide: switch to clock dump from clk_ops cmd: clk: Make soc_clk_dump static Jim Liu (1): clk: nuvoton: add read only feature for clk driver arch/arm/mach-zynq/clk.c | 57 --------------------------------------------------- arch/mips/mach-pic32/cpu.c | 23 --------------------- cmd/clk.c | 13 ++++++++++-- drivers/clk/aspeed/clk_ast2600.c | 83 +++++++++++++++++++++++++++++++++++++------------------------------------- drivers/clk/clk_k210.c | 104 +++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ drivers/clk/clk_pic32.c | 37 +++++++++++++++++++++++++++++++++ drivers/clk/clk_versal.c | 9 +++++--- drivers/clk/clk_zynq.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++ drivers/clk/clk_zynqmp.c | 22 ++++++++++---------- drivers/clk/imx/clk-imx8.c | 13 ++++-------- drivers/clk/meson/a1.c | 58 +++++++++++++++++++++------------------------------- drivers/clk/mvebu/armada-37xx-periph.c | 20 +++++++++++------- drivers/clk/nuvoton/clk_npcm.c | 15 +++++++++++--- drivers/clk/nuvoton/clk_npcm.h | 1 + drivers/clk/nuvoton/clk_npcm8xx.c | 12 +++++------ drivers/clk/stm32/clk-stm32mp1.c | 31 ++++++++-------------------- include/clk-uclass.h | 13 ++++++++++++ include/clk.h | 2 -- 18 files changed, 288 insertions(+), 277 deletions(-)

2 1