November 2023 - U-Boot

[PATCH] buildman: Include symbols in the read-only data section
by Simon Glass 02 Nov '23

02 Nov '23

When symbols switch between the inited data section and the read-only data section their visbility changes, at present, with the -B option. This is confusing, since adding 'const' to a variable declaration can make it look like a significant improvement in bloat. But in fact nothing has changed. Add 'r' to the list of symbols types that are recorded, to correct this problem. Add a constant to make it easier to find this code next time. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- tools/buildman/builder.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py index 5305477c5be6..3e42c987d1cd 100644 --- a/tools/buildman/builder.py +++ b/tools/buildman/builder.py @@ -35,6 +35,10 @@ from u_boot_pylib.terminal import tprint # which indicates that BREAK_ME has an empty default RE_NO_DEFAULT = re.compile(b'$(\w+)$ \[] $NEW$') +# Symbol types which appear in the bloat feature (-B). Others are silently +# dropped when reading in the 'nm' output +NM_SYMBOL_TYPES = 'tTdDbBr' + """ Theory of Operation @@ -693,7 +697,7 @@ class Builder: parts = line.split() if line and len(parts) == 3: size, type, name = line.split() - if type in 'tTdDbB': + if type in NM_SYMBOL_TYPES: # function names begin with '.' on 64-bit powerpc if '.' in name[1:]: name = 'static.' + name.split('.')[0] -- 2.42.0.655.g421f12c284-goog

2 2

[PATCH v4 0/2] Enable split mode in binman
by Neha Malcom Francis 02 Nov '23

02 Nov '23

This series extends the functionality of ti-secure-rom entry type in binman to support enabling of split mode vs. the default lockstep mode via changing the field in the x509 certificate. A DONOTMERGE patch is added to give an example of how this can be done via the binman.dtsi Changes in v4: - Simon: - correct function comments for setting bit for split and lockstep mode Changes in v3: - Simon: - added entries.rst change - updated function comments - removed inconsistency in setting bootcore_opts to 32 Changes in v2: - Udit: - included TRM link in commit message - added DONOTMERGE patch showing example Neha Malcom Francis (2): binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts DONOTMERGE: arm: dts: k3-j7200-binman: Enable split mode for MCU R5 arch/arm/dts/k3-j7200-binman.dtsi | 3 +++ tools/binman/btool/openssl.py | 6 ++++-- tools/binman/entries.rst | 1 + tools/binman/etype/ti_secure_rom.py | 11 +++++++++-- tools/binman/etype/x509_cert.py | 3 ++- tools/binman/test/297_ti_secure_rom.dts | 1 + 6 files changed, 20 insertions(+), 5 deletions(-) -- 2.34.1

2 5

[PATCH v3 1/1] sandbox: eliminate unused functions from binaries
by Heinrich Schuchardt 02 Nov '23

02 Nov '23

The sandbox should closely mimic other architectures. Place each function or data in a separate section and let the linker eliminate unused ones. This will reduce the binary size. In the linker script mark that u_boot_sandbox_getopt are to be kept. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- v3: avoid duplicate -Wl,--gc-sections only use KEEP for unreferenced symbols v2: mark _u_boot_sandbox_getopt sections as KEEP() --- arch/sandbox/config.mk | 4 ++-- arch/sandbox/cpu/u-boot.lds | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/sandbox/config.mk b/arch/sandbox/config.mk index 2d184c5f65..1d50991f8d 100644 --- a/arch/sandbox/config.mk +++ b/arch/sandbox/config.mk @@ -2,7 +2,7 @@ # Copyright (c) 2011 The Chromium OS Authors. PLATFORM_CPPFLAGS += -D__SANDBOX__ -U_FORTIFY_SOURCE -PLATFORM_CPPFLAGS += -fPIC +PLATFORM_CPPFLAGS += -fPIC -ffunction-sections -fdata-sections PLATFORM_LIBS += -lrt SDL_CONFIG ?= sdl2-config @@ -30,7 +30,7 @@ cmd_u-boot__ = $(CC) -o $@ -Wl,-T u-boot.lds $(u-boot-init) \ $(u-boot-main) \ $(u-boot-keep-syms-lto) \ -Wl,--no-whole-archive \ - $(PLATFORM_LIBS) -Wl,-Map -Wl,u-boot.map + $(PLATFORM_LIBS) -Wl,-Map -Wl,u-boot.map -Wl,--gc-sections cmd_u-boot-spl = (cd $(obj) && $(CC) -o $(SPL_BIN) -Wl,-T u-boot-spl.lds \ $(KBUILD_LDFLAGS:%=-Wl,%) \ diff --git a/arch/sandbox/cpu/u-boot.lds b/arch/sandbox/cpu/u-boot.lds index ba8dee50c7..52f13af374 100644 --- a/arch/sandbox/cpu/u-boot.lds +++ b/arch/sandbox/cpu/u-boot.lds @@ -15,7 +15,7 @@ SECTIONS _u_boot_sandbox_getopt : { *(_u_boot_sandbox_getopt_start) - *(_u_boot_sandbox_getopt) + KEEP(*(_u_boot_sandbox_getopt)) *(_u_boot_sandbox_getopt_end) } -- 2.40.1

3 3

[PATCH] u_boot_pylib: Ensure subprocess is closed down
by Simon Glass 02 Nov '23

02 Nov '23

It isn't clear why we need to have two different paths for closing down the pipe. Unify them and use the Python to avoid this warning: subprocess.py:1127: ResourceWarning: subprocess 83531 is still running Note that this code appears to originally have come from [1] and was committed into the ChromeOS chromiumos/platform/crosutils repo in the bin/cros_image_to_target.py file. The addition of the extra code path came later, so that is chosen for the fixes tag. [1] https://codereview.chromium.org/3391008 Signed-off-by: Simon Glass <sjg(a)chromium.org> Fixes: a10fd93cbc patman: Make command methods return a CommandResult --- tools/u_boot_pylib/command.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/u_boot_pylib/command.py b/tools/u_boot_pylib/command.py index 9bbfc5bdd83..bbe95d86122 100644 --- a/tools/u_boot_pylib/command.py +++ b/tools/u_boot_pylib/command.py @@ -105,9 +105,7 @@ def run_pipe(pipe_list, infile=None, outfile=None, last_pipe.communicate_filter(output_func)) if result.stdout and oneline: result.output = result.stdout.rstrip(b'\r\n') - result.return_code = last_pipe.wait() - else: - result.return_code = os.waitpid(last_pipe.pid, 0)[1] + result.return_code = last_pipe.wait() if raise_on_error and result.return_code: raise Exception("Error running '%s'" % user_pipestr) return result.to_output(binary) -- 2.42.0.820.g83a721a137-goog

1 1

[PATCH v2 0/2] Add dm_rng_read_default() helper
by Alexey Romanov 02 Nov '23

02 Nov '23

Hello! This patchset adds dm_rng_read_default() helper function, that selects the first rng device and uses it to obtain random bytes. V2: - Move platform_get_rng_device() to rng-uclass.c. - Re-implement it to get first successfully probed device. - Use it in dm_rng_read_default(). Alexey Romanov (2): rng: move platform_get_rng_device() to rng-uclass.c rng: add dm_rng_read_default() helper drivers/rng/rng-uclass.c | 34 ++++++++++++++++++++++++++++++++++ include/efi_rng.h | 2 -- include/rng.h | 21 +++++++++++++++++++++ lib/efi_loader/efi_rng.c | 27 --------------------------- 4 files changed, 55 insertions(+), 29 deletions(-) -- 2.30.1

3 5

[PATCH v3 0/5] Populate kaslr seed with RNG
by seanedmond＠linux.microsoft.com 02 Nov '23

02 Nov '23

From: Sean Edmond <seanedmond(a)microsoft.com> This patch series creates a common API (fdt_fixup_kaslr_seed()) for populating the kaslr seed in the DTB. Existing users (kaslrseed, and ARMv8 sec firmware) have been updated to use this common API. New functionality has been introduced to populate the kaslr using the RNG. This can be enabled with CONFIG_RNG_TPM_SEED. changes in v3: - Populate with RNG device instead of TPM device (this is a more generic solution) - Use event spy to do the FDT fixup - fix compile error for sandbox for !OFNODE_MULTI_TREE changes in v2: - fdt_fixup_kaslr_seed() uses the ofnode API - Add root_ofnode_from_fdt() to get the root node from an FDT and perform error checking on the oftree - add comments to exported functions - Add error checking in image_setup_libfdt() for return from fdt_tpm_kaslr_seed() - uclass_get_device() -> uclass_first_device_err() - Change default config for OFNODE_MULTI_TREE (y if !OF_LIVE) Dhananjay Phadke (2): fdt: common API to populate kaslr seed fdt: kaslr seed from RNG device Sean Edmond (3): cmd: kaslrseed: Use common API to fixup FDT dm: core: Modify default for OFNODE_MULTI_TREE fdt: Fix compile error for !OFNODE_MULTI_TREE arch/arm/cpu/armv8/sec_firmware.c | 39 ++++++++-------------- cmd/kaslrseed.c | 22 +++++-------- common/fdt_support.c | 55 +++++++++++++++++++++++++++++++ drivers/core/Kconfig | 2 +- drivers/core/ofnode.c | 29 ++++++++++++---- include/dm/ofnode.h | 12 +++++++ include/fdt_support.h | 9 +++++ lib/Kconfig | 7 ++++ 8 files changed, 129 insertions(+), 46 deletions(-) -- 2.40.0

4 13

[PATCH 0/2] Allow defconfigs defined from fragments
by Andrew Davis 02 Nov '23

02 Nov '23

Hello all, For context see thread ending here[0]. Thanks, Andrew Changes from RFC[1]: - Added Reviewed-by [0] https://marc.info/?l=u-boot&m=169333616210919&w=2 [1] https://lists.denx.de/pipermail/u-boot/2023-August/529084.html Andrew Davis (2): Makefile: Run defconfig files through the C preprocessor configs: Add am62x_beagleplay_* defconfigs configs/am62x_beagleplay_a53_defconfig | 3 +++ configs/am62x_beagleplay_r5_defconfig | 3 +++ scripts/kconfig/Makefile | 3 ++- 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 configs/am62x_beagleplay_a53_defconfig create mode 100644 configs/am62x_beagleplay_r5_defconfig -- 2.39.2

2 4

Please pull u-boot-i2c
by Heiko Schocher 02 Nov '23

02 Nov '23

Hello Tom, please pull from u-boot-i2c: The following changes since commit d9650a48234058c645d1a07951c3d2cf129427e6: Merge branch '2023-10-28-assorted-platform-updates' (2023-10-28 09:23:27 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-i2c.git tags/i2cfixes-for-v2024-01-rc2 for you to fetch changes up to 5b6ee512ceb8d990e010646c4fe7b8a3633fad68: bootcount: Add driver model I2C driver (2023-10-31 09:09:04 +0100) ---------------------------------------------------------------- i2c updates for v2024.01-rc2 - nuvoton: support standard/fast/fast plus mode - bootcount: remove legacy i2c driver and implement DM based version Bugfixes: - designware_i2c: adjust timing calculation SPL probing failed on the StarFive VisionFive 2 board Heinrich fixed this, by syncing timing calculation with linux implementation. ---------------------------------------------------------------- Heinrich Schuchardt (1): i2c: designware_i2c: adjust timing calculation Jim Liu (1): i2c: nuvoton: remove standard mode only Philip Richard Oberfichtner (3): bootcount: Remove legacy I2C driver i2c: Implement i2c_get_chip_by_phandle() bootcount: Add driver model I2C driver drivers/bootcount/Kconfig | 34 +++++++++++++--------------------- drivers/bootcount/Makefile | 2 +- drivers/bootcount/bootcount_dm_i2c.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/bootcount/bootcount_i2c.c | 43 ------------------------------------------- drivers/i2c/designware_i2c.c | 19 +++++++++++++++---- drivers/i2c/i2c-uclass.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/i2c/npcm_i2c.c | 5 ----- include/i2c.h | 12 ++++++++++++ 8 files changed, 218 insertions(+), 74 deletions(-) create mode 100644 drivers/bootcount/bootcount_dm_i2c.c delete mode 100644 drivers/bootcount/bootcount_i2c.c azure build is fine: https://dev.azure.com/hs0298/hs/_build/results?buildId=109&view=results Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs(a)denx.de

2 1

[GIT PULL] u-boot-riscv/master
by Leo Liang 02 Nov '23

02 Nov '23

Hi Tom, The following changes since commit a803f87202aa48974bdff4d8100464a8288931e4: Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-11-01 09:44:33 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git for you to fetch changes up to 9d22d4a7cef7f2fdaf5c060b71574e6f82ea5ff0: configs: visionfive2: Enable JH7110 RNG driver (2023-11-02 17:45:53 +0800) CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/18407 ---------------------------------------------------------------- + CI: Use OpenSBI 1.3.1 release for testing + riscv: Support resume after exception + rng: Support RNG provided by RISC-V Zkr ISA extension + board: starfive VF2: Support jtag + board: starfive VF2: Support TRNG driver + board: sifive unmatched: Move kernel load address ---------------------------------------------------------------- Chanho Park (7): riscv: cpu: jh7110: Add gpio helper macros board: starfive: spl: Support jtag for VisionFive2 board riscv: import read/write_relaxed functions clk: starfive: jh7110: Add security clocks rng: Add StarFive JH7110 RNG driver riscv: dts: jh7110: Add rng device tree node configs: visionfive2: Enable JH7110 RNG driver Heinrich Schuchardt (3): CI: use OpenSBI 1.3.1 for testing riscv: allow resume after exception rng: Provide a RNG based on the RISC-V Zkr ISA extension Samuel Holland (3): riscv: Sort target configs alphabetically riscv: Align the trap handler to 64 bytes riscv: Weakly define invalidate_icache_range() Yong-Xuan Wang (1): board: sifive: unmatched: move kernel load address to 0x80200000 .azure-pipelines.yml | 8 +- .gitlab-ci.yml | 8 +- arch/riscv/Kconfig | 18 +- arch/riscv/cpu/mtrap.S | 2 +- arch/riscv/dts/jh7110.dtsi | 10 ++ arch/riscv/include/asm/arch-jh7110/gpio.h | 85 +++++++++ arch/riscv/include/asm/io.h | 45 +++++ arch/riscv/lib/cache.c | 2 +- arch/riscv/lib/interrupts.c | 13 ++ board/starfive/visionfive2/spl.c | 23 +++ configs/starfive_visionfive2_defconfig | 2 + doc/api/index.rst | 1 + doc/api/interrupt.rst | 6 + drivers/clk/starfive/clk-jh7110.c | 10 ++ drivers/rng/Kconfig | 14 ++ drivers/rng/Makefile | 2 + drivers/rng/jh7110_rng.c | 274 ++++++++++++++++++++++++++++++ drivers/rng/riscv_zkr_rng.c | 116 +++++++++++++ include/configs/sifive-unmatched.h | 2 +- include/interrupt.h | 45 +++++ 20 files changed, 666 insertions(+), 20 deletions(-) create mode 100644 arch/riscv/include/asm/arch-jh7110/gpio.h create mode 100644 doc/api/interrupt.rst create mode 100644 drivers/rng/jh7110_rng.c create mode 100644 drivers/rng/riscv_zkr_rng.c create mode 100644 include/interrupt.h Best regards, Leo

2 1

[GIT PULL] CLock changes for 2024.01-rc2
by Sean Anderson 02 Nov '23

02 Nov '23

The following changes since commit fb428b61819444b9337075f49c72f326f5d12085: Merge branch '2023-10-24-assorted-general-fixes-and-updates' (2023-10-24 19:12:21 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-clk.git tags/clk-2024.01-rc2 for you to fetch changes up to c4b52fda6924e92c6745351f32c4cafc36034170: clk: also handle ENOENT in *_optional functions (2023-11-01 15:14:51 -0400) ---------------------------------------------------------------- Clock changes for 2024.01-rc2 This contains several fixes for the clock core. ---------------------------------------------------------------- Eugen Hristev (1): clk: fix count parameter type for clk_release_all Maksim Kiselev (1): clk: use private clk struct in CLK_CCF's enable/disable functions Nathan Barrett-Morrison (1): drivers: clk: Adjust temp var data type to properly match that of struct clk_ops Yang Xiwen (1): clk: also handle ENOENT in *_optional functions drivers/clk/clk-uclass.c | 13 +++++++------ include/clk.h | 12 +++++++----- 2 files changed, 14 insertions(+), 11 deletions(-)

2 1