November 2023 - U-Boot

Please pull u-boot-dm
by Simon Glass 03 Nov '23

03 Nov '23

Hi Tom, Just various bugfixes, apart from the TI one https://source.denx.de/u-boot/custodians/u-boot-dm/-/commit/3227baad05481e3… https://dev.azure.com/simon0972/u-boot/_build/results?buildId=54&view=resul… (not finished yet) The following changes since commit 07fe79c93c5caba181f37844ca95fbda4db3f613: Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c (2023-11-02 10:12:33 -0400) are available in the Git repository at: git://git.denx.de/u-boot-dm.git tags/dm-pull-2nov23 for you to fetch changes up to 3227baad05481e37d75aeae7c7c1467fd6903f7d: u_boot_pylib: Ensure subprocess is closed down (2023-11-02 09:38:54 -0600) ---------------------------------------------------------------- Heinrich Schuchardt (1): sandbox: eliminate unused functions from binaries Maxim Cournoyer (1): patman: Add a 'keep_change_id' setting Milan P. Stanić (1): cros_ec: spi: disable annoying key echo on console Neha Malcom Francis (1): binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts Simon Glass (9): binman: Reset missing bintools after testing binman: Don't add compression attribute for uncompressed files binman: Ensure attributes always come last in the metadata binman: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4 binman: Rename TYPE_STAGE to TYPE_LEGACY_STAGE binman: Move stage header into a CBFS attribute buildman: Include symbols in the read-only data section buildman: Support upstream branch name containing / u_boot_pylib: Ensure subprocess is closed down arch/sandbox/config.mk | 4 +- arch/sandbox/cpu/u-boot.lds | 2 +- cmd/cbfs.c | 2 +- drivers/misc/cros_ec_spi.c | 2 +- include/cbfs.h | 2 +- tools/binman/btool/openssl.py | 6 ++- tools/binman/cbfs_util.py | 125 +++++++++++++++++++++++++------------------- tools/binman/cbfs_util_test.py | 23 ++++---- tools/binman/control.py | 2 + tools/binman/entries.rst | 1 + tools/binman/etype/ti_secure_rom.py | 11 +++- tools/binman/etype/x509_cert.py | 3 +- tools/binman/ftest.py | 10 ++-- tools/binman/test/297_ti_secure_rom.dts | 1 + tools/buildman/builder.py | 6 ++- tools/patman/__main__.py | 2 + tools/patman/control.py | 12 +++-- tools/patman/gitutil.py | 5 +- tools/patman/patchstream.py | 17 ++++-- tools/patman/patman.rst | 11 ++-- tools/patman/test_checkpatch.py | 16 ++++++ tools/u_boot_pylib/command.py | 4 +- 22 files changed, 168 insertions(+), 99 deletions(-) Regards, Simon

2 1

[PATCH] MAINTAINERS: update Qualcomm maintainer
by Caleb Connolly 03 Nov '23

03 Nov '23

As Ramon has been inactive for some time now, add myself and Neil Armstrong to maintain Qualcomm efforts going forwards. Signed-off-by: Caleb Connolly <caleb.connolly(a)linaro.org> --- I greatly appreciate the work done by Ramon Fried in keeping Qualcomm support alive in U-Boot the last few years. However it's clear that he hasn't been very active for some time now. I am currently working on a large cleanup effort to modernise Qualcomm support and enable several new reference platforms. To better facilitate this and to handle Qualcomm support going forwards, make myself maintainer of ARM SNAPDRAGON as well as my colleague Neil Armstrong (Amlogic maintainer). I hope Ramon continues to participate in discussions and reviews going forward. --- base-commit: cbba1b7766bd93d74e28202c46e69095ac13760b // Caleb (they/them) --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cde778bc4d3d..be3666d14047 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -567,7 +567,8 @@ S: Supported F: arch/arm/dts/am335x-sancloud* ARM SNAPDRAGON -M: Ramon Fried <rfried.dev(a)gmail.com> +M: Caleb Connolly <caleb.connolly(a)linaro.org> +M: Neil Armstrong <neil.armstrong(a)linaro.org> S: Maintained F: arch/arm/mach-snapdragon/ F: drivers/gpio/msm_gpio.c

3 3

[PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device
by Slawomir Stepien 03 Nov '23

03 Nov '23

Mark the flash@0 as BROM_BOOTSOURCE_SPINAND. Fixes use of same-as-spl in u-boot,spl-boot-order prop on Orange Pi 5 Plus. Signed-off-by: Slawomir Stepien <sst(a)poczta.fm> --- arch/arm/mach-rockchip/rk3588/rk3588.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/rk3588/rk3588.c b/arch/arm/mach-rockchip/rk3588/rk3588.c index b1f535fad5..0c8f10a97c 100644 --- a/arch/arm/mach-rockchip/rk3588/rk3588.c +++ b/arch/arm/mach-rockchip/rk3588/rk3588.c @@ -42,6 +42,7 @@ const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = { [BROM_BOOTSOURCE_SPINOR] = "/spi@fe2b0000/flash@0", [BROM_BOOTSOURCE_SD] = "/mmc@fe2c0000", [BROM_BOOTSOURCE_SPINOR_RK3588] = "/spi@fe2b0000/flash@0", + [BROM_BOOTSOURCE_SPINAND] = "/spi@fe2b0000/flash@0", }; static struct mm_region rk3588_mem_map[] = { -- 2.42.0

3 9

[PATCH 0/6] arm: mach-snapdragon: Qualcomm pinctrl driver cleanup
by Caleb Connolly 03 Nov '23

03 Nov '23

This series moves the Qualcomm pinctrl drivers from mach-snapdragon and mach-ipq40xx to drivers/pinctrl/qcom. It then makes the necessary changes to enable compatibility with Linux DTs. The pinctrl hardware on most Qualcomm platforms is made up of "tiles", these are just banks of pins at different register addresses. The mapping between pin number and tile is totally arbitrary, this unfortunately means that it is necessary to have a map of pin to tile in order to support all pins. Up until now this driver has ignored tiles, meaning that the pin numbers and DT nodes are entirely different to the Linux DT and only a subset of pins are addressable. Patch 2 solves this by introducing the pin_offset map, initially supporting SDM845. This map is used for all pin register lookups for both the pinctrl and GPIO drivers. Similarly to the clock/reset drivers these are both associated with a single DT node, where the pinctrl driver is responsible for binding the GPIO drivers. Patch 3 introduces support for gpio-reserved-ranges, this property is used on some boards to mark pin ranges that shouldn't be touched (else firmware will trigger a fault and reset the board). This series loosely depends on the associated clock driver cleanup which can be found here (Makefile and perhaps DTS conflicts): https://lore.kernel.org/u-boot/20231024-b4-qcom-clk-v1-0-9d96359b9a82@linar… --- Caleb Connolly (6): pinctrl: qcom: move out of mach-snapdragon pinctrl: qcom: make compatible with linux DTs pinctrl: qcom: handle reserved ranges msm_qcom: use unsigned int pinctrl: qcom: move ipq4019 driver from mach-ipq40xx pinctrl: qcom: rename msm -> qcom arch/arm/Kconfig | 1 + arch/arm/dts/dragonboard845c-uboot.dtsi | 2 +- arch/arm/dts/sdm845.dtsi | 16 +- arch/arm/dts/starqltechn-uboot.dtsi | 5 +- arch/arm/dts/starqltechn.dts | 16 +- arch/arm/mach-ipq40xx/Makefile | 8 - arch/arm/mach-ipq40xx/pinctrl-snapdragon.c | 166 -------------- arch/arm/mach-snapdragon/Kconfig | 4 + arch/arm/mach-snapdragon/Makefile | 5 - arch/arm/mach-snapdragon/pinctrl-sdm845.c | 44 ---- arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 166 -------------- arch/arm/mach-snapdragon/pinctrl-snapdragon.h | 33 --- configs/dragonboard410c_defconfig | 2 +- configs/dragonboard845c_defconfig | 2 +- configs/qcs404evb_defconfig | 2 +- configs/starqltechn_defconfig | 2 +- drivers/gpio/Kconfig | 6 +- drivers/gpio/Makefile | 2 +- drivers/gpio/msm_gpio.c | 127 ----------- drivers/gpio/qcom_gpio.c | 148 +++++++++++++ drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/qcom/Kconfig | 46 ++++ drivers/pinctrl/qcom/Makefile | 10 + .../pinctrl/qcom}/pinctrl-apq8016.c | 33 ++- .../pinctrl/qcom}/pinctrl-apq8096.c | 33 ++- .../pinctrl/qcom}/pinctrl-ipq4019.c | 33 ++- drivers/pinctrl/qcom/pinctrl-qcom.c | 244 +++++++++++++++++++++ .../pinctrl/qcom/pinctrl-qcom.h | 17 +- .../pinctrl/qcom}/pinctrl-qcs404.c | 33 ++- drivers/pinctrl/qcom/pinctrl-sdm845.c | 99 +++++++++ include/qcom-gpio.h | 43 ++++ 32 files changed, 723 insertions(+), 627 deletions(-) --- base-commit: 34f2a2a3ec23b4d24b8020054aacfad1143bd430 // Caleb (they/them)

2 12

[PATCH V2 0/2] doc: board: ti: Cleanup ::prompt usage
by Nishanth Menon 03 Nov '23

03 Nov '23

Due to the sequence of merges, it looks like many of k3 documentation used code-blocks while the rest of the docs migrated to ::prompt. Sync all to a common style. based off: master 07fe79c93c5c Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c Changes since V1: * squashed up the gdb patch to patch#1 * fixedup patch #2 for whitespace indentation miss v1: https://lore.kernel.org/r/20231103000915.2413501-1-nm@ti.com Nishanth Menon (2): doc: board: ti: Use prompt prompt_style to simplify documentation doc: board: ti: k3 docs: Use ::prompt doc/board/ti/am335x_evm.rst | 39 ++++------- doc/board/ti/am62x_beagleplay.rst | 46 ++++++------- doc/board/ti/am62x_sk.rst | 18 +++--- doc/board/ti/am64x_evm.rst | 20 +++--- doc/board/ti/am65x_evm.rst | 104 +++++++++++++++--------------- doc/board/ti/dra7xx_evm.rst | 3 +- doc/board/ti/j7200_evm.rst | 20 +++--- doc/board/ti/j721e_evm.rst | 40 ++++++------ doc/board/ti/j721s2_evm.rst | 18 +++--- doc/board/ti/k3.rst | 44 ++++++------- doc/board/ti/ks2_evm.rst | 15 ++--- 11 files changed, 174 insertions(+), 193 deletions(-) -- 2.37.2

1 2

[PATCH 0/3] doc: board: ti: Cleanup ::prompt usage
by Nishanth Menon 03 Nov '23

03 Nov '23

Due to the sequence of merges, it looks like many of k3 documentation used code-blocks while the rest of the docs migrated to ::prompt. Sync all to a common style. based off: master 07fe79c93c5c Merge tag 'i2cfixes-for-v2024-01-rc2' of https://source.denx.de/u-boot/custodians/u-boot-i2c Nishanth Menon (3): doc: board: ti: Use prompt prompt_style to simplify documentation doc: board: ti: k3: Use ::prompt for gdb commands doc: board: ti: k3 docs: Use ::prompt doc/board/ti/am335x_evm.rst | 39 +++++--------- doc/board/ti/am62x_beagleplay.rst | 46 ++++++++--------- doc/board/ti/am62x_sk.rst | 18 +++---- doc/board/ti/am64x_evm.rst | 20 +++---- doc/board/ti/am65x_evm.rst | 86 +++++++++++++++---------------- doc/board/ti/dra7xx_evm.rst | 3 +- doc/board/ti/j7200_evm.rst | 20 +++---- doc/board/ti/j721e_evm.rst | 40 +++++++------- doc/board/ti/j721s2_evm.rst | 18 +++---- doc/board/ti/k3.rst | 16 +++--- doc/board/ti/ks2_evm.rst | 9 ++-- 11 files changed, 148 insertions(+), 167 deletions(-) -- 2.40.0

1 4

[PATCH] patman: Add a 'keep_change_id' setting
by Maxim Cournoyer 03 Nov '23

03 Nov '23

A Change-Id can be useful for traceability purposes, and some projects may wish to have them preserved. This change makes it configurable via a new 'keep_change_id' setting. Signed-off-by: Maxim Cournoyer <maxim.cournoyer(a)gmail.com> --- tools/patman/control.py | 9 +++++++-- tools/patman/patchstream.py | 17 ++++++++++++----- tools/patman/patman.rst | 11 ++++++----- tools/patman/test_checkpatch.py | 16 ++++++++++++++++ 4 files changed, 41 insertions(+), 12 deletions(-) diff --git a/tools/patman/control.py b/tools/patman/control.py index 916ddf8fcf..29383551ed 100644 --- a/tools/patman/control.py +++ b/tools/patman/control.py @@ -16,11 +16,14 @@ from patman import gitutil from patman import patchstream from u_boot_pylib import terminal + def setup(): """Do required setup before doing anything""" gitutil.setup() -def prepare_patches(col, branch, count, start, end, ignore_binary, signoff): + +def prepare_patches(col, branch, count, start, end, ignore_binary, signoff, + keep_change_id=False): """Figure out what patches to generate, then generate them The patch files are written to the current directory, e.g. 0001_xxx.patch @@ -35,6 +38,7 @@ def prepare_patches(col, branch, count, start, end, ignore_binary, signoff): end (int): End patch to use (0=last one in series, 1=one before that, etc.) ignore_binary (bool): Don't generate patches for binary files + keep_change_id (bool): Preserve the Change-Id tag. Returns: Tuple: @@ -59,11 +63,12 @@ def prepare_patches(col, branch, count, start, end, ignore_binary, signoff): branch, start, to_do, ignore_binary, series, signoff) # Fix up the patch files to our liking, and insert the cover letter - patchstream.fix_patches(series, patch_files) + patchstream.fix_patches(series, patch_files, keep_change_id) if cover_fname and series.get('cover'): patchstream.insert_cover_letter(cover_fname, series, to_do) return series, cover_fname, patch_files + def check_patches(series, patch_files, run_checkpatch, verbose, use_tree): """Run some checks on a set of patches diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index f91669a940..4188d0ed35 100644 --- a/tools/patman/patchstream.py +++ b/tools/patman/patchstream.py @@ -68,6 +68,7 @@ STATE_PATCH_SUBJECT = 1 # In patch subject (first line of log for a commit) STATE_PATCH_HEADER = 2 # In patch header (after the subject) STATE_DIFFS = 3 # In the diff part (past --- line) + class PatchStream: """Class for detecting/injecting tags in a patch or series of patches @@ -76,7 +77,7 @@ class PatchStream: unwanted tags or inject additional ones. These correspond to the two phases of processing. """ - def __init__(self, series, is_log=False): + def __init__(self, series, is_log=False, keep_change_id=False): self.skip_blank = False # True to skip a single blank line self.found_test = False # Found a TEST= line self.lines_after_test = 0 # Number of lines found after TEST= @@ -86,6 +87,7 @@ class PatchStream: self.section = [] # The current section...END section self.series = series # Info about the patch series self.is_log = is_log # True if indent like git log + self.keep_change_id = keep_change_id # True to keep Change-Id tags self.in_change = None # Name of the change list we are in self.change_version = 0 # Non-zero if we are in a change list self.change_lines = [] # Lines of the current change @@ -452,6 +454,8 @@ class PatchStream: # Detect Change-Id tags elif change_id_match: + if self.keep_change_id: + out = [line] value = change_id_match.group(1) if self.is_log: if self.commit.change_id: @@ -763,7 +767,7 @@ def get_metadata_for_test(text): pst.finalise() return series -def fix_patch(backup_dir, fname, series, cmt): +def fix_patch(backup_dir, fname, series, cmt, keep_change_id=False): """Fix up a patch file, by adding/removing as required. We remove our tags from the patch file, insert changes lists, etc. @@ -776,6 +780,7 @@ def fix_patch(backup_dir, fname, series, cmt): fname (str): Filename to patch file to process series (Series): Series information about this patch set cmt (Commit): Commit object for this patch file + keep_change_id (bool): Keep the Change-Id tag. Return: list: A list of errors, each str, or [] if all ok. @@ -783,7 +788,7 @@ def fix_patch(backup_dir, fname, series, cmt): handle, tmpname = tempfile.mkstemp() outfd = os.fdopen(handle, 'w', encoding='utf-8') infd = open(fname, 'r', encoding='utf-8') - pst = PatchStream(series) + pst = PatchStream(series, keep_change_id=keep_change_id) pst.commit = cmt pst.process_stream(infd, outfd) infd.close() @@ -795,7 +800,7 @@ def fix_patch(backup_dir, fname, series, cmt): shutil.move(tmpname, fname) return cmt.warn -def fix_patches(series, fnames): +def fix_patches(series, fnames, keep_change_id=False): """Fix up a list of patches identified by filenames The patch files are processed in place, and overwritten. @@ -803,6 +808,7 @@ def fix_patches(series, fnames): Args: series (Series): The Series object fnames (:type: list of str): List of patch files to process + keep_change_id (bool): Keep the Change-Id tag. """ # Current workflow creates patches, so we shouldn't need a backup backup_dir = None #tempfile.mkdtemp('clean-patch') @@ -811,7 +817,8 @@ def fix_patches(series, fnames): cmt = series.commits[count] cmt.patch = fname cmt.count = count - result = fix_patch(backup_dir, fname, series, cmt) + result = fix_patch(backup_dir, fname, series, cmt, + keep_change_id=False) if result: print('%d warning%s for %s:' % (len(result), 's' if len(result) > 1 else '', fname)) diff --git a/tools/patman/patman.rst b/tools/patman/patman.rst index 038b651ee8..a8b317eed6 100644 --- a/tools/patman/patman.rst +++ b/tools/patman/patman.rst @@ -371,11 +371,12 @@ Series-process-log: sort, uniq Separate each tag with a comma. Change-Id: - This tag is stripped out but is used to generate the Message-Id - of the emails that will be sent. When you keep the Change-Id the - same you are asserting that this is a slightly different version - (but logically the same patch) as other patches that have been - sent out with the same Change-Id. + This tag is used to generate the Message-Id of the emails that + will be sent. When you keep the Change-Id the same you are + asserting that this is a slightly different version (but logically + the same patch) as other patches that have been sent out with the + same Change-Id. The Change-Id tag line is removed from outgoing + patches, unless the `keep_change_id` settings is set to `True`. Various other tags are silently removed, like these Chrome OS and Gerrit tags:: diff --git a/tools/patman/test_checkpatch.py b/tools/patman/test_checkpatch.py index a8bb364e42..59a53ef8ca 100644 --- a/tools/patman/test_checkpatch.py +++ b/tools/patman/test_checkpatch.py @@ -160,6 +160,22 @@ Signed-off-by: Simon Glass <sjg(a)chromium.org> rc = os.system('diff -u %s %s' % (inname, expname)) self.assertEqual(rc, 0) + os.remove(inname) + + # Test whether the keep_change_id settings works. + inhandle, inname = tempfile.mkstemp() + infd = os.fdopen(inhandle, 'w', encoding='utf-8') + infd.write(data) + infd.close() + + patchstream.fix_patch(None, inname, series.Series(), com, + keep_change_id=True) + + with open(inname, 'r') as f: + content = f.read() + self.assertIn( + 'Change-Id: I80fe1d0c0b7dd10aa58ce5bb1d9290b6664d5413', + content) os.remove(inname) os.remove(expname) base-commit: f9a47ac8d97da2b3aaf463f268a9a872a8d921df -- 2.41.0

2 4

[PULL] u-boot-sh/master_common_h_cleanup
by Marek Vasut 03 Nov '23

03 Nov '23

The following changes since commit a803f87202aa48974bdff4d8100464a8288931e4: Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-11-01 09:44:33 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master_common_h_cleanup for you to fetch changes up to 7d824618d7eb5340e63892c919abc62d831e7482: board: rzg2l: Drop <common.h> (2023-11-02 11:30:19 +0100) ---------------------------------------------------------------- Paul Barker (8): arm: armv8: mmu: Prepare for common.h removal arm: mach-rmobile: Drop <common.h> serial: sh: Drop <common.h> pinctrl: rzg2l: Drop <common.h> mmc: renesas-sdhi: Drop <common.h> gpio: rzg2l: Drop <common.h> clk: rzg2l: Drop <common.h> board: rzg2l: Drop <common.h> arch/arm/include/asm/armv8/mmu.h | 2 ++ arch/arm/mach-rmobile/board.c | 2 +- arch/arm/mach-rmobile/cpu_info-r8a7740.c | 2 +- arch/arm/mach-rmobile/cpu_info-rcar.c | 2 +- arch/arm/mach-rmobile/cpu_info-rzg.c | 2 +- arch/arm/mach-rmobile/cpu_info-rzg2l.c | 1 - arch/arm/mach-rmobile/cpu_info.c | 2 +- arch/arm/mach-rmobile/emac.c | 1 - arch/arm/mach-rmobile/memmap-gen3.c | 4 ++-- arch/arm/mach-rmobile/memmap-rzg2l.c | 2 +- arch/arm/mach-rmobile/pfc-r8a7740.c | 2 +- arch/arm/mach-rmobile/psci-r8a779a0.c | 1 - board/renesas/rzg2l/rzg2l.c | 1 - drivers/clk/renesas/r9a07g044-cpg.c | 1 - drivers/clk/renesas/rzg2l-cpg.c | 1 - drivers/gpio/rzg2l-gpio.c | 1 - drivers/mmc/renesas-sdhi.c | 1 - drivers/pinctrl/renesas/rzg2l-pfc.c | 1 - drivers/serial/serial_sh.c | 1 - 19 files changed, 11 insertions(+), 19 deletions(-)

2 1

[PATCH 0/6] binman: Update CBFS implementation
by Simon Glass 02 Nov '23

02 Nov '23

There isn't really a solid spec for CBFS and it changes from time to time. This series updates binman to deal with four changes in the file format, with the earliest being in October 2020. No changes are made to the CBFS-filesystem implementation. This has fallen behind, but can still be used for simple files. This series also fixes a coverage bug, where tests for missing tools affect other tests, thus causing coverage to fall below 100%. This has showed up with the bootgen tool. Simon Glass (6): binman: Reset missing bintools after testing binman: Don't add compression attribute for uncompressed files binman: Ensure attributes always come last in the metadata binman: Replace FILENAME_ALIGN 16 with ATTRIBUTE_ALIGN 4 binman: Rename TYPE_STAGE to TYPE_LEGACY_STAGE binman: Move stage header into a CBFS attribute cmd/cbfs.c | 2 +- include/cbfs.h | 2 +- tools/binman/cbfs_util.py | 125 +++++++++++++++++++-------------- tools/binman/cbfs_util_test.py | 23 +++--- tools/binman/control.py | 2 + tools/binman/ftest.py | 10 +-- 6 files changed, 93 insertions(+), 71 deletions(-) -- 2.42.0.655.g421f12c284-goog

2 14

[PATCH v2] cros_ec: spi: disable annoying key echo on console
by Milan P. Stanić 02 Nov '23

02 Nov '23

on Peach-pi console every key press is echoed with message 'cros_ec_command: Returned status 1' this is not proper fix, just hack to disable this message Signed-off-by: Milan P. Stanić <mps(a)arvanta.net> Reviewed-by: Simon Glass <sjg(a)chromium.org> --- changed patch to use log_debug and added forgoten Signed-off-by and and Reviewed-by Simon response mail drivers/misc/cros_ec_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c index 001f0a85ca..591ff30df8 100644 --- a/drivers/misc/cros_ec_spi.c +++ b/drivers/misc/cros_ec_spi.c @@ -151,7 +151,7 @@ int cros_ec_spi_command(struct udevice *udev, uint8_t cmd, int cmd_version, /* Response code is first byte of message */ if (p[0] != EC_RES_SUCCESS) { - printf("%s: Returned status %d\n", __func__, p[0]); + log_debug("Returned status %d\n", p[0]); return -(int)(p[0]); } -- 2.42.0

2 1