August 2022 - U-Boot

EFI CI failure
by Simon Glass 04 Aug '22

04 Aug '22

Hi Heinrich, I am seeing this: https://source.denx.de/u-boot/custodians/u-boot-dm/-/jobs/477636 _________________________ test_efi_selftest_text_input _________________________ test/py/tests/test_efi_selftest.py:116: in test_efi_selftest_text_input u_boot_console.restart_uboot() test/py/u_boot_console_base.py:459: in restart_uboot self.ensure_spawned(expect_reset) test/py/u_boot_console_base.py:423: in ensure_spawned self.wait_for_boot_prompt(loop_num = loop_num) test/py/u_boot_console_base.py:180: in wait_for_boot_prompt m = self.p.expect([self.prompt_compiled, test/py/u_boot_spawn.py:193: in expect raise Timeout() E u_boot_spawn.Timeout ----------------------------- Captured stdout call ----------------------------- Do you have any ideas what causes it? Regards, Simon

2 3

[PATCH] tools: mkimage: don't use deprecated openssl funcs
by Michal Vasilek 04 Aug '22

04 Aug '22

RSA_get0_* functions are not available in LibreSSL and deprecated in OpenSSL. This fixes build with LibreSSL and removes deprecation warnings with OpenSSL 3 Signed-off-by: Michal Vasilek <michal.vasilek(a)nic.cz> --- tools/sunxi_toc0.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/sunxi_toc0.c b/tools/sunxi_toc0.c index bab5d17b7d..a6c4b59010 100644 --- a/tools/sunxi_toc0.c +++ b/tools/sunxi_toc0.c @@ -207,8 +207,8 @@ static int toc0_create_key_item(uint8_t *buf, uint32_t *len, int n_len, e_len; /* Store key 0. */ - n_len = BN_bn2bin(RSA_get0_n(root_key), key_item->key0); - e_len = BN_bn2bin(RSA_get0_e(root_key), key_item->key0 + n_len); + n_len = BN_bn2bin(root_key->n, key_item->key0); + e_len = BN_bn2bin(root_key->e, key_item->key0 + n_len); if (n_len + e_len > sizeof(key_item->key0)) { pr_err("Root key is too big for key item\n"); goto err; @@ -217,8 +217,8 @@ static int toc0_create_key_item(uint8_t *buf, uint32_t *len, key_item->key0_e_len = cpu_to_le32(e_len); /* Store key 1. */ - n_len = BN_bn2bin(RSA_get0_n(fw_key), key_item->key1); - e_len = BN_bn2bin(RSA_get0_e(fw_key), key_item->key1 + n_len); + n_len = BN_bn2bin(fw_key->n, key_item->key1); + e_len = BN_bn2bin(fw_key->e, key_item->key1 + n_len); if (n_len + e_len > sizeof(key_item->key1)) { pr_err("Firmware key is too big for key item\n"); goto err; @@ -281,8 +281,8 @@ static int toc0_verify_key_item(const uint8_t *buf, uint32_t len, goto err; /* If a root key was provided, compare it to key 0. */ - if (root_key && (BN_cmp(n, RSA_get0_n(root_key)) || - BN_cmp(e, RSA_get0_e(root_key)))) { + if (root_key && (BN_cmp(n, root_key->n) || + BN_cmp(e, root_key->e))) { pr_err("Wrong root key in key item\n"); goto err; } @@ -313,8 +313,8 @@ static int toc0_verify_key_item(const uint8_t *buf, uint32_t len, if (*fw_key) { /* If a FW key was provided, compare it to key 1. */ - if (BN_cmp(n, RSA_get0_n(*fw_key)) || - BN_cmp(e, RSA_get0_e(*fw_key))) { + if (BN_cmp(n, (*fw_key)->n) || + BN_cmp(e, (*fw_key)->e)) { pr_err("Wrong firmware key in key item\n"); goto err; } @@ -361,8 +361,8 @@ static int toc0_create_cert_item(uint8_t *buf, uint32_t *len, RSA *fw_key, */ totalSequence = &cert_item->totalSequence; publicKey = &totalSequence->mainSequence.subjectPublicKeyInfo.publicKey; - if (BN_bn2binpad(RSA_get0_n(fw_key), publicKey->n, sizeof(publicKey->n)) < 0 || - BN_bn2binpad(RSA_get0_e(fw_key), publicKey->e, sizeof(publicKey->e)) < 0) { + if (BN_bn2binpad(fw_key->n, publicKey->n, sizeof(publicKey->n)) < 0 || + BN_bn2binpad(fw_key->e, publicKey->e, sizeof(publicKey->e)) < 0) { pr_err("Firmware key is too big for certificate\n"); goto err; } @@ -430,8 +430,8 @@ static int toc0_verify_cert_item(const uint8_t *buf, uint32_t len, RSA *fw_key, goto err; /* If a key was provided, compare it to the embedded key. */ - if (fw_key && (BN_cmp(RSA_get0_n(key), RSA_get0_n(fw_key)) || - BN_cmp(RSA_get0_e(key), RSA_get0_e(fw_key)))) { + if (fw_key && (BN_cmp(key->n, fw_key->n) || + BN_cmp(key->e, fw_key->e))) { pr_err("Wrong firmware key in certificate\n"); goto err; } @@ -830,7 +830,7 @@ static void toc0_set_header(void *buf, struct stat *sbuf, int ifd, } /* When using an existing key item, the root key is optional. */ - if (!key_item && (!root_key || !RSA_get0_d(root_key))) { + if (!key_item && (!root_key || !root_key->d)) { pr_err("Failed to read private key from '%s'\n", root_key_file); pr_info("Try 'openssl genrsa -out root_key.pem'\n"); @@ -846,7 +846,7 @@ static void toc0_set_header(void *buf, struct stat *sbuf, int ifd, } if (!fw_key) { /* If the root key is a private key, it can be used instead. */ - if (root_key && RSA_get0_d(root_key)) { + if (root_key && root_key->d) { pr_info("Using root key as firmware key\n"); fw_key = root_key; } else { -- 2.37.1

4 7

[PATCH 1/1] cmd: remove deprecated LCD support
by Heinrich Schuchardt 04 Aug '22

04 Aug '22

No board uses lcd_clear() anymore. So we can remove support for it. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- cmd/cls.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/cmd/cls.c b/cmd/cls.c index 502d5ed697..ba36220d9e 100644 --- a/cmd/cls.c +++ b/cmd/cls.c @@ -8,7 +8,6 @@ #include <common.h> #include <command.h> #include <dm.h> -#include <lcd.h> #include <video.h> #define CSI "\x1b[" @@ -20,19 +19,12 @@ static int do_video_clear(struct cmd_tbl *cmdtp, int flag, int argc, /* Send clear screen and home */ printf(CSI "2J" CSI "1;1H"); -#if defined(CONFIG_DM_VIDEO) -#if !defined(CONFIG_VIDEO_ANSI) - if (uclass_first_device_err(UCLASS_VIDEO, &dev)) - return CMD_RET_FAILURE; - - if (video_clear(dev)) - return CMD_RET_FAILURE; -#endif -#elif defined(CONFIG_LCD) - lcd_clear(); -#else - return CMD_RET_FAILURE; -#endif + if (CONFIG_IS_ENABLED(DM_VIDEO) && !CONFIG_IS_ENABLED(VIDEO_ANSI)) { + if (uclass_first_device_err(UCLASS_VIDEO, &dev)) + return CMD_RET_FAILURE; + if (video_clear(dev)) + return CMD_RET_FAILURE; + } return CMD_RET_SUCCESS; } -- 2.36.1

2 1

[PATCH 0/4] fix missed migration from SPL_<OPTION>_SUPPORT to SPL_<OPTION>
by Quentin Schulz 04 Aug '22

04 Aug '22

From: Quentin Schulz <quentin.schulz(a)theobroma-systems.com> I guess this is the result of an unfortunate race in the merging of commits using the "old" name and their renaming. Only the first commit has been tested (I'll need it in some upcoming patches). Owners/maintainers of mx7ulp_com or imx8mp_rsb3720a1 should test those changes as I'm unable to do so. Cheers, Quentin Quentin Schulz (4): gpio: fix incorrect depends on for SPL_GPIO_HOG mx7ulp_com: fix incorrect select for SPL options imx: imx8mp_rsb3720a1: fix incorrect ifdef check on SPL_MMC vpl: fix reference in comment to non-existing SPL_SERIAL_SUPPORT arch/arm/mach-imx/mx7ulp/Kconfig | 6 +++--- board/advantech/imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 4 ++-- common/spl/Kconfig | 3 +-- drivers/gpio/Kconfig | 2 +- 4 files changed, 7 insertions(+), 8 deletions(-) -- 2.36.1

3 10

[PATCH 1/1] cmd: undefined return value of do_extension_apply()
by Heinrich Schuchardt 04 Aug '22

04 Aug '22

If 'extension apply all' is executed and no extension is found, the return value of do_extension_apply() is undefined. Return CMD_RET_FAILURE in this case. Fixes: 2f84e9cf06d3 ("cmd: add support for a new "extension" command") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- cmd/extension_board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/extension_board.c b/cmd/extension_board.c index bbb4812ff8..f94abd612d 100644 --- a/cmd/extension_board.c +++ b/cmd/extension_board.c @@ -111,6 +111,7 @@ static int do_extension_apply(struct cmd_tbl *cmdtp, int flag, return CMD_RET_USAGE; if (strcmp(argv[1], "all") == 0) { + ret = CMD_RET_FAILURE; list_for_each_entry(extension, &extension_list, list) { ret = extension_apply(extension); if (ret != CMD_RET_SUCCESS) -- 2.36.1

3 2

[PATCH v2] spl: mmc: Use correct MMC device when loading image
by Harald Seiler 04 Aug '22

04 Aug '22

When attempting to load images from multiple MMC devices in sequence, spl_mmc_load() chooses the wrong device from the second attempt onwards. The reason is that MMC initialization is only done on its first call and spl_mmc_load() will then continue using this same device for all future calls. Fix this by checking the devnum of the "cached" device struct against the one which is requested. If they match, use the cached one but if they do not match, initialize the new device. This fixes specifying multiple MMC devices in the SPL's boot order to fall back when U-Boot Proper is corrupted or missing on the first attempted MMC device. Fixes: e1eb6ada4e38 ("spl: Make image loader infrastructure more universal") Signed-off-by: Harald Seiler <hws(a)denx.de> --- Notes: Changes in v2: - Make it work with CONFIG_SPL_BLK as well common/spl/spl_mmc.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index e1a7d25bd0..1c12f69d96 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -361,6 +361,17 @@ int __weak spl_mmc_emmc_boot_partition(struct mmc *mmc) return default_spl_mmc_emmc_boot_partition(mmc); } +static int spl_mmc_get_mmc_devnum(struct mmc *mmc) +{ + struct blk_desc *block_dev; +#if !CONFIG_IS_ENABLED(BLK) + block_dev = &mmc->block_dev; +#else + block_dev = dev_get_uclass_plat(mmc->dev); +#endif + return block_dev->devnum; +} + int spl_mmc_load(struct spl_image_info *spl_image, struct spl_boot_device *bootdev, const char *filename, @@ -371,9 +382,11 @@ int spl_mmc_load(struct spl_image_info *spl_image, u32 boot_mode; int err = 0; __maybe_unused int part = 0; + int mmc_dev; - /* Perform peripheral init only once */ - if (!mmc) { + /* Perform peripheral init only once for an mmc device */ + mmc_dev = spl_mmc_get_device_index(bootdev->boot_device); + if (!mmc || spl_mmc_get_mmc_devnum(mmc) != mmc_dev) { err = spl_mmc_find_device(&mmc, bootdev->boot_device); if (err) return err; -- 2.36.1

2 1

[PATCH] cmd: fix do_adc_single()
by Vyacheslav Bocharov 04 Aug '22

04 Aug '22

The source code contains an error: - argv[2] contains <channel> arg, variable for env_set is in argv[3] - number of args is 4 Revert 54d24d72601321f4470c4edf31c6b29adae424a7 cmd: simplify do_adc_single() Fixes 9de612ae4ded53f742f5f99929c06d0839471ced cmd: adc: Add support for storing ADC result in env variable --- cmd/adc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/cmd/adc.c b/cmd/adc.c index 195efa8661..1c5d3e10a3 100644 --- a/cmd/adc.c +++ b/cmd/adc.c @@ -71,6 +71,7 @@ static int do_adc_info(struct cmd_tbl *cmdtp, int flag, int argc, static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) { + char *varname = NULL; struct udevice *dev; unsigned int data; int ret, uV, val; @@ -78,6 +79,9 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc, if (argc < 3) return CMD_RET_USAGE; + if (argc >= 4) + varname = argv[3]; + ret = adc_channel_single_shot(argv[1], simple_strtol(argv[2], NULL, 0), &data); if (ret) { @@ -95,7 +99,8 @@ static int do_adc_single(struct cmd_tbl *cmdtp, int flag, int argc, printf("%u\n", data); } - env_set_ulong(argv[2], val); + if (varname) + env_set_ulong(varname, val); return CMD_RET_SUCCESS; } @@ -160,5 +165,5 @@ static char adc_help_text[] = U_BOOT_CMD_WITH_SUBCMDS(adc, "ADC sub-system", adc_help_text, U_BOOT_SUBCMD_MKENT(list, 1, 1, do_adc_list), U_BOOT_SUBCMD_MKENT(info, 2, 1, do_adc_info), - U_BOOT_SUBCMD_MKENT(single, 3, 1, do_adc_single), + U_BOOT_SUBCMD_MKENT(single, 4, 1, do_adc_single), U_BOOT_SUBCMD_MKENT(scan, 3, 1, do_adc_scan)); -- 2.30.2

3 2

[PATCH 1/4] arm: mach-k3: Add support for device type detection
by Andrew Davis 04 Aug '22

04 Aug '22

K3 SoCs are available in a number of device types such as GP, HS-FS, EMU, etc. Like OMAP SoCs we can detect this at runtime and should print this out as part of the SoC information line. We add this as part of the common.c file as it will be used to also modify our security state early in the device boot. Signed-off-by: Andrew Davis <afd(a)ti.com> --- arch/arm/mach-k3/common.c | 51 +++++++++++++++++++++++- arch/arm/mach-k3/common.h | 10 +++++ arch/arm/mach-k3/include/mach/hardware.h | 10 +++++ 3 files changed, 70 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c index 70f6444e79..ac14975694 100644 --- a/arch/arm/mach-k3/common.c +++ b/arch/arm/mach-k3/common.c @@ -396,7 +396,54 @@ void reset_cpu(void) } #endif +enum k3_device_type get_device_type(void) +{ + u32 sys_status = readl(K3_SEC_MGR_SYS_STATUS); + + u32 sys_dev_type = (sys_status & SYS_STATUS_DEV_TYPE_MASK) >> + SYS_STATUS_DEV_TYPE_SHIFT; + + u32 sys_sub_type = (sys_status & SYS_STATUS_SUB_TYPE_MASK) >> + SYS_STATUS_SUB_TYPE_SHIFT; + + switch (sys_dev_type) { + case SYS_STATUS_DEV_TYPE_GP: + return K3_DEVICE_TYPE_GP; + case SYS_STATUS_DEV_TYPE_TEST: + return K3_DEVICE_TYPE_TEST; + case SYS_STATUS_DEV_TYPE_EMU: + return K3_DEVICE_TYPE_EMU; + case SYS_STATUS_DEV_TYPE_HS: + if (sys_sub_type == SYS_STATUS_SUB_TYPE_VAL_FS) + return K3_DEVICE_TYPE_HS_FS; + else + return K3_DEVICE_TYPE_HS_SE; + default: + return K3_DEVICE_TYPE_BAD; + } +} + #if defined(CONFIG_DISPLAY_CPUINFO) +static const char *get_device_type_name(void) +{ + enum k3_device_type type = get_device_type(); + + switch (type) { + case K3_DEVICE_TYPE_GP: + return "GP"; + case K3_DEVICE_TYPE_TEST: + return "TEST"; + case K3_DEVICE_TYPE_EMU: + return "EMU"; + case K3_DEVICE_TYPE_HS_FS: + return "HS-FS"; + case K3_DEVICE_TYPE_HS_SE: + return "HS-SE"; + default: + return "BAD"; + } +} + int print_cpuinfo(void) { struct udevice *soc; @@ -418,9 +465,11 @@ int print_cpuinfo(void) ret = soc_get_revision(soc, name, 64); if (!ret) { - printf("%s\n", name); + printf("%s ", name); } + printf("%s\n", get_device_type_name()); + return 0; } #endif diff --git a/arch/arm/mach-k3/common.h b/arch/arm/mach-k3/common.h index e81b70d7c3..8f38fcef7f 100644 --- a/arch/arm/mach-k3/common.h +++ b/arch/arm/mach-k3/common.h @@ -18,6 +18,15 @@ struct fwl_data { u16 regions; }; +enum k3_device_type { + K3_DEVICE_TYPE_BAD, + K3_DEVICE_TYPE_GP, + K3_DEVICE_TYPE_TEST, + K3_DEVICE_TYPE_EMU, + K3_DEVICE_TYPE_HS_FS, + K3_DEVICE_TYPE_HS_SE, +}; + void setup_k3_mpu_regions(void); int early_console_init(void); void disable_linefill_optimization(void); @@ -27,4 +36,5 @@ void k3_sysfw_print_ver(void); void spl_enable_dcache(void); void mmr_unlock(phys_addr_t base, u32 partition); bool is_rom_loaded_sysfw(struct rom_extended_boot_data *data); +enum k3_device_type get_device_type(void); void ti_secure_image_post_process(void **p_image, size_t *p_size); diff --git a/arch/arm/mach-k3/include/mach/hardware.h b/arch/arm/mach-k3/include/mach/hardware.h index 7c6928d5da..73dc2d2d98 100644 --- a/arch/arm/mach-k3/include/mach/hardware.h +++ b/arch/arm/mach-k3/include/mach/hardware.h @@ -32,6 +32,16 @@ #define JTAG_ID_VARIANT_MASK (0xf << 28) #define JTAG_ID_PARTNO_SHIFT 12 #define JTAG_ID_PARTNO_MASK (0xffff << 12) +#define K3_SEC_MGR_SYS_STATUS 0x44234100 +#define SYS_STATUS_DEV_TYPE_SHIFT 0 +#define SYS_STATUS_DEV_TYPE_MASK (0xf) +#define SYS_STATUS_DEV_TYPE_GP 0x3 +#define SYS_STATUS_DEV_TYPE_TEST 0x5 +#define SYS_STATUS_DEV_TYPE_EMU 0x9 +#define SYS_STATUS_DEV_TYPE_HS 0xa +#define SYS_STATUS_SUB_TYPE_SHIFT 8 +#define SYS_STATUS_SUB_TYPE_MASK (0xf << 8) +#define SYS_STATUS_SUB_TYPE_VAL_FS 0xa #define K3_ROM_BOOT_HEADER_MAGIC "EXTBOOT" -- 2.36.1

2 11

[PATCH] drivers: xen: events: fix build issues with disabled Xen HVC
by Dmytro Firsov 04 Aug '22

04 Aug '22

Some setups do not use Xen hypervisor console for logging, e.g. they use emulated PL011 hardware or shared peripherals (real UART). In such cases Xen HVC will be disabled on a build time and will cause issues in current driver implementation. This commit fixes build issues in Xen event channel driver, caused by absense of console event channel, that is not available when console config is disabled. Now console related code will be removed when Xen HVC is turned off. Signed-off-by: Dmytro Firsov <dmytro_firsov(a)epam.com> --- drivers/xen/events.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 5e90a65846..532216fece 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -23,7 +23,9 @@ #include <xen/events.h> #include <xen/hvm.h> +#if CONFIG_IS_ENABLED(XEN_SERIAL) extern u32 console_evtchn; +#endif /* CONFIG_IS_ENABLED(XEN_SERIAL) */ #define NR_EVS 1024 @@ -51,8 +53,11 @@ void unbind_all_ports(void) struct vcpu_info *vcpu_info = &s->vcpu_info[cpu]; for (i = 0; i < NR_EVS; i++) { +#if CONFIG_IS_ENABLED(XEN_SERIAL) if (i == console_evtchn) continue; +#endif /* CONFIG_IS_ENABLED(XEN_SERIAL) */ + if (test_and_clear_bit(i, bound_ports)) { printf("port %d still bound!\n", i); unbind_evtchn(i); -- 2.25.1

3 7

[PATCH] pwm: aspeed: Select SYSCON to get parent detail.
by Billy Tsai 04 Aug '22

04 Aug '22

To work correctly, this driver depends on SYSCON to get the base address from the parent dts node. Signed-off-by: Billy Tsai <billy_tsai(a)aspeedtech.com> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index cb54e67fae..cf66293eeb 100644 --- a/drivers/pwm/Kconfig +++ b/drivers/pwm/Kconfig @@ -12,6 +12,7 @@ config DM_PWM config PWM_ASPEED bool "Enable support for the Aspeed PWM" depends on DM_PWM + select SYSCON help This PWM is found on Ast2600 SoCs. It supports a programmable period and duty cycle. It provides 16 channels which can be independently -- 2.25.1

3 2