July 2022 - U-Boot

[ANN] U-Boot v2022.10-rc1 released
by Tom Rini 26 Jul '22

26 Jul '22

Hey all, It's release day and so here's v2022.10-rc1. There's a lot in here, and there's a few more things yet to come, hopefully this week, in terms of pull requests, and also pulling things out of my own queue. One thing I want to call out specifically is the VBE series will be coming in soon, so general commentary is welcome and appreciated. Also, we've moved more of our process documentation from the wiki to rst and being in-tree. Patches to clean that up a bit more, or try and clarify points about how things work are much appreciated. In terms of a changelog, git log --merges v2022.04..v2022.07-rc1 contains what I've pulled but as always, better PR messages and tags will provide better results here. So we're now looking at regular releases every other Monday, and with final release on October 3rd, 2022. Thanks all! -- Tom

2 1

MVEBU A38x Regulator
by Tony Dinh 26 Jul '22

26 Jul '22

Hi Pali/Marek, I'm writing u-boot for the Synology DS116 (Armada 385, dual core, 1.8 Ghz). I could not seem to get the DM Regulator to power up the SATA port on this board. I'm using Stefan ./board/Marvell/db-88f6820-gp as the starting point, and using the latest DTS https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/armada-385-… I noticed that the Linux kernel boot log (booted with stock Marvell u-boot) shows "supply ahci not found" error. But I can power up the SATA drive in stock u-boot by poking GPIO 15 (SATA power enable). And it works fine with this combination: stock u-boot, kernel 5.18.6. [ 2.861061] usb_phy_generic usb3_0_phy: dummy supplies not allowed for exclusive requests [ 2.870173] usb_phy_generic usb3_1_phy: dummy supplies not allowed for exclusive requests [ 2.879296] ahci-mvebu f10a8000.sata: supply ahci not found, using dummy regulator [ 2.887704] ahci-mvebu f10a8000.sata: supply phy not found, using dummy regulator [ 2.896101] ahci-mvebu f10a8000.sata: masking port_map 0x3 -> 0x1 [ 2.902951] ahci-mvebu f10a8000.sata: AHCI 0001.0000 32 slots 2 ports 6 Gbps 0x1 impl platform mode [ 2.912750] ahci-mvebu f10a8000.sata: flags: 64bit ncq sntf led only pmp fbs pio slum part sxs [ 2.923184] scsi host0: ahci-mvebu [ 2.927693] scsi host1: ahci-mvebu [ 2.931935] ata1: SATA max UDMA/133 mmio [mem 0xf10a8000-0xf10a9fff] port 0x100 irq 50 [ 2.940610] ata2: DUMMY My questions: does DM regulator + DM GPIO work for Armada 38x u-boot? and is the error "ahci-mvebu f10a8000.sata: supply ahci, using dummy regulator" a real error? I've googled this and came across some past related posts from you (Pali and Marek), but it is not apparent what was the solution. If you are interested in seeing more info while I'm at my new u-boot prompt (kwboot with the SPL kwb), I can post that followup. Thanks, Tony

2 7

[PATCH 0/2] Xilinx AXI qspi driver enhancements
by Ashok Reddy Soma 26 Jul '22

26 Jul '22

In this patch series below support is added - Added mem_ops structure to support exec_op function - Added support_ops function to check controller bus width capabilities. T Karthik Reddy (2): spi: xilinx_spi: Add support for spi memory operations spi: xilinx_spi: Add support ops to axi qspi driver drivers/spi/xilinx_spi.c | 236 ++++++++++++++++++++++++++------------- 1 file changed, 159 insertions(+), 77 deletions(-) -- 2.17.1

2 3

[PATCH 0/4] Xilinx zynq_qspi updates
by Ashok Reddy Soma 26 Jul '22

26 Jul '22

This patch series does below things - Add child preprobe function - Use dummy buswidth in dummy byte calculation - Add support for zynq_qspi_mem_exec_op - Fix qspi speed issue Ashok Reddy Soma (2): spi: zynq_qspi: Add support for zynq_qspi_mem_exec_op spi: zynq_qspi: Fix programming qspi speed Siva Durga Prasad Paladugu (1): spi: zynq_qspi: Add child pre probe function T Karthik Reddy (1): spi: zynq_qspi: Use dummy buswidth in dummy byte calculation drivers/spi/zynq_qspi.c | 73 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 65 insertions(+), 8 deletions(-) -- 2.17.1

2 5

[PATCH v12 00/13] fpga: zynqmp: Adding support of loading authenticated images
by Oleksandr Suvorov 26 Jul '22

26 Jul '22

This patchset introduces support for the authenticated and encrypted FPGA images on ZynqMP boards, besides that introducing common way to pass the compatible property to any fpga driver. It bases on the initial work by Jorge Ramirez-Ortiz <jorge(a)foundries.io> https://patchwork.ozlabs.org/project/uboot/patch/20211015091506.2602-1-jorg… https://patchwork.ozlabs.org/project/uboot/patch/20211005111324.19749-3-jor… Changes in v12: - define the function only if FPGA_LOAD_SECURE enabled; - convert "compatible" to flags only if FPGA_LOAD_SECURE enabled; - fix a commit message - remove obsolete debug() message - exclude all secure-related code if FPGA_LOAD_SECURE is disabled - reduce the size of SPL if FPGA_LOAD_SECURE disabled. Changes in v11: - Fix treating an incoming FPGA image with empty flags parameter as legacy. - add Tested-by records. Changes in v10: - move FPGA flags to macros; - initialize xilinx_desc structs directly, removing *_DESC macros; - initialize flags for mach-zynq; - fix mixed types of return value; - made the message about ignoring legacy compatibe option as debug; - fix grammar - Support DDR images only if FPGA_LOAD_SECURE enabled. - Support ENC images only if FPGA_LOAD_SECURE enabled. Changes in v9: - remove an alien commit from a patchset :) Changes in v8: - Michal Simek's suggestions addressed: -- introduce the compatible flags in xilinx_desc; -- pass a binary compatible flag instead of "compatible" property to an FPGA driver. - Optimize a zynqmp_load() function. Changes in v7: - apply Michal Simek's suggestions As I applied changes on Oleksandr's patches, I indicated it by specifying myself as co-author in the commits logs. I am not sure if that is the convention of marking it. Changes in v6: - add support for the encrypted bitfiles. Changes in v5: - replace ifdef with if() where it's possible. Changes in v4: - change interface to xilinx_desc->operations->open() callback. - fix a bug from previous version of the patchset in dereferencing of a parent fpga_desc structure. Changes in v3: - remove the patch which introduced CMD_SPL_FPGA_LOAD_SECURE. - fix mixing definitions/declarations. - replace strcmp() calls with more secure strncmp(). - document the "u-boot,zynqmp-fpga-ddrauth" compatible string. - fix code style by check-patch recommendations. Changes in v2: - add function fit_fpga_load() to simplify calls of fpga_load() from contexts without a compatible attribute. - move all ZynqMP-specific logic to drivers/fpga/zynqmppl.c - prepare for passing a "compatible" FDT property to any fpga driver. Adrian Fiergolski (1): fpga: zynqmp: support loading encrypted bitfiles Oleksandr Suvorov (12): fpga: add option for loading FPGA secure bitstreams fpga: xilinx: add missed identifier names fpga: xilinx: add bitstream flags to driver desc fpga: zynqmp: add str2flags call fpga: xilinx: pass compatible flags to xilinx_load() fpga: pass compatible flags to fpga_load() fpga: add fpga_compatible2flag spl: fit: pass real compatible flags to fpga_load() fpga: xilinx: pass compatible flags to load() callback fpga: zynqmp: reduce zynqmppl_load() code fpga: zynqmp: add bitstream compatible checking fpga: zynqmp: support loading authenticated images arch/arm/mach-zynq/cpu.c | 1 + board/xilinx/versal/board.c | 5 +- board/xilinx/zynqmp/zynqmp.c | 5 +- boot/Kconfig | 4 +- boot/image-board.c | 4 +- cmd/Kconfig | 3 +- cmd/fpga.c | 8 +-- common/spl/spl_fit.c | 17 +++-- doc/uImage.FIT/source_file_format.txt | 7 +- drivers/fpga/Kconfig | 14 ++++ drivers/fpga/fpga.c | 33 ++++++++- drivers/fpga/spartan2.c | 2 +- drivers/fpga/spartan3.c | 2 +- drivers/fpga/versalpl.c | 2 +- drivers/fpga/virtex2.c | 2 +- drivers/fpga/xilinx.c | 8 +-- drivers/fpga/zynqmppl.c | 99 ++++++++++++++++++++++----- drivers/fpga/zynqpl.c | 2 +- include/fpga.h | 4 +- include/versalpl.h | 3 - include/xilinx.h | 21 ++++-- include/zynqmppl.h | 9 ++- 22 files changed, 199 insertions(+), 56 deletions(-) -- 2.36.1

2 15

[PATCH v3 0/2] fpga: Convert some options to Kconfig
by Alexander Dahl 26 Jul '22

26 Jul '22

Hei hei, tried to work on the feedback I got the best I could. Greets Alex v2 -> v3: - reworded commit messages - added kconfig help text for SYS_FPGA_CHECK_CTRLC - removed hardcoded def/undef from drivers (implicit) v1 -> v2: - dropped patch 3, same kconfig symbol addressed with commit 60d45642fe0673514aced37e6cc95d4f0fe02a19 ("fpga: Remove CONFIG_FPGA_COUNT") Cc: Wolfgang Wegner <w.wegner(a)astro-kom.de> Cc: Michal Simek <michal.simek(a)amd.com> Cc: Tom Rini <trini(a)konsulko.com> Alexander Dahl (2): fpga: Convert SYS_FPGA_CHECK_CTRLC to Kconfig fpga: Convert SYS_FPGA_PROG_FEEDBACK to Kconfig README | 7 ------- configs/astro_mcf5373l_defconfig | 1 + drivers/fpga/Kconfig | 13 +++++++++++++ drivers/fpga/spartan2.c | 1 - drivers/fpga/virtex2.c | 11 ----------- include/configs/astro_mcf5373l.h | 1 - scripts/config_whitelist.txt | 1 - 7 files changed, 14 insertions(+), 21 deletions(-) base-commit: 88d931a71052fc8fb7b48126ae09aa875745d5ec -- 2.30.2

2 3

[PATCH v2 0/5] Enable power domain driver in ZynqMP and Versal
by Ashok Reddy Soma 26 Jul '22

26 Jul '22

This patch series enables power domain driver in ZynqMP and Versal platforms and its dependencies. - Add a preliminary check by loading overlay for APU0 and see if the pmufw accepts the config objects, based on that continue to load further objects or not. - This is needed to dynamically request for node of the IP's based on DT. - Load pmufw config object dynamically based on DT. Changes in v2: - Move static variable to inside zynqmp_pmufw_node and change name to skip_config from config_enabled - Use zynqmp_pmufw_node() in zynqmp_power_probe() to check for APU_0 config loading instead of calling zynqmp_pmufw_load_config_object() Ashok Reddy Soma (5): firmware: zynqmp: Change prototype of zynqmp_pmufw_load_config_object() firmware: zynqmp: Load config overlay for core0 to pmufw arm64: zynqmp: Enable power domain driver mailbox: zynqmp: Move struct zynqmp_ipi_msg from sys_proto.h arm64: versal: Enable power domain driver and its dependencies arch/arm/mach-zynqmp/include/mach/sys_proto.h | 5 ---- configs/xilinx_versal_virt_defconfig | 4 ++++ configs/xilinx_zynqmp_virt_defconfig | 2 ++ drivers/firmware/firmware-zynqmp.c | 24 +++++++++++++++---- drivers/mailbox/Kconfig | 2 +- drivers/mailbox/zynqmp-ipi.c | 2 +- include/zynqmp_firmware.h | 7 +++++- 7 files changed, 33 insertions(+), 13 deletions(-) -- 2.17.1

2 6

[PATCH 0/3] Add reset driver support for ZynqMP and Versal
by Ashok Reddy Soma 26 Jul '22

26 Jul '22

This patch series does following things - Add reset driver support for Versal platform - Enable reset driver support for ZynqMP and Versal platforms Ashok Reddy Soma (1): arm64: zynqmp: Enable reset driver Michal Simek (1): arm64: versal: Enable reset driver for versal T Karthik Reddy (1): reset: zynqmp: Add reset driver support for versal configs/xilinx_versal_virt_defconfig | 2 ++ configs/xilinx_zynqmp_virt_defconfig | 2 ++ drivers/reset/Kconfig | 6 +++--- drivers/reset/reset-zynqmp.c | 10 +++++++--- 4 files changed, 14 insertions(+), 6 deletions(-) -- 2.17.1

2 4

[PATCH 1/2] xilinx: Wire uuid reading from FRU
by Michal Simek 26 Jul '22

26 Jul '22

UUID is already recorded when FRU is parsed but it is not copied to local structures and exported to variable that's why simply add it. Data is saved in binary format but there must be conversion to string for exporting it to variable and string should be in uuid format too. One way how to use it directly is to setup pxeuuid based on it. For example via preboot with "setenv pxeuuid ${board_uuid}" Signed-off-by: Michal Simek <michal.simek(a)amd.com> --- Happy to hear if there is more elagant way how to generate uuid string. --- board/xilinx/common/board.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 5f2afb9def4e..b0c11aaa4256 100644 --- a/board/xilinx/common/board.c +++ b/board/xilinx/common/board.c @@ -23,6 +23,7 @@ #include <soc.h> #include <linux/ctype.h> #include <linux/kernel.h> +#include <uuid.h> #include "fru.h" @@ -86,6 +87,7 @@ int zynq_board_read_rom_ethaddr(unsigned char *ethaddr) #define EEPROM_HDR_SERIAL_LEN 20 #define EEPROM_HDR_NO_OF_MAC_ADDR 4 #define EEPROM_HDR_ETH_ALEN ETH_ALEN +#define EEPROM_HDR_UUID_LEN 16 struct xilinx_board_description { u32 header; @@ -94,6 +96,7 @@ struct xilinx_board_description { char revision[EEPROM_HDR_REV_LEN + 1]; char serial[EEPROM_HDR_SERIAL_LEN + 1]; u8 mac_addr[EEPROM_HDR_NO_OF_MAC_ADDR][EEPROM_HDR_ETH_ALEN + 1]; + char uuid[EEPROM_HDR_UUID_LEN + 1]; }; static int highest_id = -1; @@ -237,6 +240,8 @@ static int xilinx_read_eeprom_fru(struct udevice *dev, char *name, /* It is clear that FRU was captured and structures were filled */ strncpy(desc->manufacturer, (char *)fru_data.brd.manufacturer_name, sizeof(desc->manufacturer)); + strncpy(desc->uuid, (char *)fru_data.brd.uuid, + sizeof(desc->uuid)); strncpy(desc->name, (char *)fru_data.brd.product_name, sizeof(desc->name)); for (i = 0; i < sizeof(desc->name); i++) { @@ -452,6 +457,19 @@ int board_late_init_xilinx(void) ret |= env_set_by_index("serial", id, desc->serial); + if (desc->uuid[0]) { + char uuid[UUID_STR_LEN + 1]; + char *t = desc->uuid; + + memset(uuid, 0, UUID_STR_LEN + 1); + + sprintf(uuid, "%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x", + t[0], t[1], t[2], t[3], t[4], t[5], + t[6], t[7], t[8], t[9], t[10], t[11], + t[12], t[13], t[14], t[15]); + ret |= env_set_by_index("uuid", id, uuid); + } + if (!CONFIG_IS_ENABLED(NET)) continue; -- 2.36.1

1 2

[PATCH 1/1] efi_loader: fix efi_convert_device_path_to_text()
by Heinrich Schuchardt 26 Jul '22

26 Jul '22

Ensure that the string we convert to UTF-16 is NUL terminated even if the device path only contains end nodes. Fixes: bd3d75bb0c58 ("efi_loader: multi part device paths to text") Addresses-Coverity: 350434 ("Uninitialized scalar variable") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- lib/efi_loader/efi_device_path_to_text.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 4d73954ef8..6c428ee061 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -432,6 +432,7 @@ static uint16_t EFIAPI *efi_convert_device_path_to_text( *(u8 **)&device_path += device_path->length; } + *str = 0; text = efi_str_to_u16(buffer); out: -- 2.36.1

1 0