January 2022 - U-Boot

[PATCH] vexpress64: semi_defconfig: disable CRC32 support
by Andre Przywara 24 Jan '22

24 Jan '22

Commit 270f8710f92f ("crc32: Add crc32 implementation using __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A cores support the instructions, and they are mandatory starting with architecture revision v8.1, so realistically every known hardware implementation should support them. The Arm Fastmodel however defaults to the bare minimum ARMv8 feature set by default, which means v8.0 without the CRC instructions, so U-Boot hangs very early at the moment, without any output (the boot-wrapper or TF-A printing the last visible lines). Support for those instructions can be enabled on the model command line by either: -C cluster0.cpu0.enable_crc32=1 (for each core) or by using a higher architecture revision by default: -C cluster0.has_arm_v8-1=1 (for each cluster) Of course any arch revision higher than v8.1 would work as well. But for the sake of a smooth out-of-the-box experience, let's just disable the usage of those instructions in the defconfig, to avoid random hangs without any clues. Reported-by: Ross Burton <ross.burton(a)arm.com> Signed-off-by: Andre Przywara <andre.przywara(a)arm.com> --- configs/vexpress_aemv8a_semi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/vexpress_aemv8a_semi_defconfig b/configs/vexpress_aemv8a_semi_defconfig index f9abf29b26..8e6a87c99f 100644 --- a/configs/vexpress_aemv8a_semi_defconfig +++ b/configs/vexpress_aemv8a_semi_defconfig @@ -11,6 +11,7 @@ CONFIG_ENV_SECT_SIZE=0x40000 CONFIG_IDENT_STRING=" vexpress_aemv8a" CONFIG_DISTRO_DEFAULTS=y CONFIG_SYS_LOAD_ADDR=0x90000000 +# CONFIG_ARM64_CRC32 is not set CONFIG_ANDROID_BOOT_IMAGE=y CONFIG_BOOTDELAY=1 CONFIG_USE_BOOTARGS=y -- 2.25.1

3 2

[PATCH] MAINTAINERS: Update e-mail in Xen maintainership
by Anastasiia Lukianenko 24 Jan '22

24 Jan '22

Changing e-mail because of leaving EPAM. Signed-off-by: Anastasiia Lukianenko <vicooodin(a)gmail.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 64648c2921..9c2d6fe063 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1307,7 +1307,7 @@ F: arch/x86/ F: cmd/x86/ XEN -M: Anastasiia Lukianenko <anastasiia_lukianenko(a)epam.com> +M: Anastasiia Lukianenko <vicooodin(a)gmail.com> M: Oleksandr Andrushchenko <oleksandr_andrushchenko(a)epam.com> S: Maintained F: arch/arm/cpu/armv8/xen/ -- 2.27.0

3 2

[PATCH v2] cmd: Add Kconfig option for multiprocessor cmds
by Michal Simek 24 Jan '22

24 Jan '22

From: Ashok Reddy Soma <ashok.reddy.soma(a)xilinx.com> Add Kconfig option(CONFIG_CMD_MP) to enable or disable multiprocessor commands. Compile cmd/mp.c based on CONFIG_CMD_MP. Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma(a)xilinx.com> Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- Changes in v2: - Move config MP to Kconfig (General setup menu) - Fix description and s/support/Support/ to be consistent with other entries which also start with upper letter. - all reported by trini Kconfig | 6 ++++++ cmd/Kconfig | 11 ++++++----- cmd/Makefile | 2 +- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/Kconfig b/Kconfig index c46f4fce8625..b0e45cd236f0 100644 --- a/Kconfig +++ b/Kconfig @@ -454,6 +454,12 @@ config SYS_SRAM_SIZE default 0x10000 if TARGET_TRICORDER default 0x0 +config MP + bool "Support for multiprocessor" + help + This provides an option to bringup different processors + in multiprocessor cases. + config EXAMPLES bool "Compile API examples" depends on !SANDBOX diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e438f..5f2668a5b173 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1820,12 +1820,13 @@ config CMD_SLEEP help Delay execution for some time -config MP - bool "support for multiprocessor" +config CMD_MP + bool "support for multiprocessor commands" + depends on MP + default y help - This provides an option to brinup - different processors in multiprocessor - cases. + This enables commands to bringup different processors + in multiprocessor cases. config CMD_TIMER bool "timer" diff --git a/cmd/Makefile b/cmd/Makefile index 891819ae0f6b..9e8074bb7e49 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -101,7 +101,7 @@ obj-$(CONFIG_CMD_MDIO) += mdio.o obj-$(CONFIG_CMD_SLEEP) += sleep.o obj-$(CONFIG_CMD_MMC) += mmc.o obj-$(CONFIG_CMD_OPTEE_RPMB) += optee_rpmb.o -obj-$(CONFIG_MP) += mp.o +obj-$(CONFIG_CMD_MP) += mp.o obj-$(CONFIG_CMD_MTD) += mtd.o obj-$(CONFIG_CMD_MTDPARTS) += mtdparts.o obj-$(CONFIG_CMD_CLONE) += clone.o -- 2.34.1

2 1

[PATCH] misc: mark write buffer const
by John Keeping 24 Jan '22

24 Jan '22

The write operation in misc_ops already takes a "const void *" buffer, but misc_write() takes a mutable "void *". There's no reason for this, so make misc_write() consistent with the standard write() prototype. Signed-off-by: John Keeping <john(a)metanate.com> --- drivers/misc/misc-uclass.c | 2 +- include/misc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/misc-uclass.c b/drivers/misc/misc-uclass.c index cbfacc3801..cfe9d562fa 100644 --- a/drivers/misc/misc-uclass.c +++ b/drivers/misc/misc-uclass.c @@ -26,7 +26,7 @@ int misc_read(struct udevice *dev, int offset, void *buf, int size) return ops->read(dev, offset, buf, size); } -int misc_write(struct udevice *dev, int offset, void *buf, int size) +int misc_write(struct udevice *dev, int offset, const void *buf, int size) { const struct misc_ops *ops = device_get_ops(dev); diff --git a/include/misc.h b/include/misc.h index 82ec2ce793..6f042625c9 100644 --- a/include/misc.h +++ b/include/misc.h @@ -28,7 +28,7 @@ int misc_read(struct udevice *dev, int offset, void *buf, int size); * * Return: number of bytes written if OK (may be < @size), -ve on error */ -int misc_write(struct udevice *dev, int offset, void *buf, int size); +int misc_write(struct udevice *dev, int offset, const void *buf, int size); /** * misc_ioctl() - Assert command to the device, optional. -- 2.34.1

3 2

[PATCH 1/1] mkimage: struct stat.st_size may not be long
by Heinrich Schuchardt 24 Jan '22

24 Jan '22

The component st_size of struct stat is of type off_t. Depending on the system printing it it with %ld leads to a warning: tools/mkimage.c:438:54: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'off_t' {aka 'long long int'} [-Wformat=] 438 | "%s: Bad size: \"%s\" is not valid image: size %ld < %u\n", | ~~^ | | | long int | %lld When comparing an off_t value to a 32bit integer we should not convert to uint32_t but to off_t which may be wider. Reported-by: Milan P. Stanić <mps(a)arvanta.net> Fixes: 331f0800f1a3 ("mkimage: allow -l to work on block devices on Linux") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- tools/mkimage.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/mkimage.c b/tools/mkimage.c index fbe883ce36..79042be828 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -433,11 +433,12 @@ int main(int argc, char **argv) params.cmdname, params.imagefile); exit (EXIT_FAILURE); #endif - } else if ((unsigned)sbuf.st_size < tparams->header_size) { + } else if (sbuf.st_size < (off_t)tparams->header_size) { fprintf (stderr, - "%s: Bad size: \"%s\" is not valid image: size %ld < %u\n", + "%s: Bad size: \"%s\" is not valid image: size %llu < %u\n", params.cmdname, params.imagefile, - sbuf.st_size, tparams->header_size); + (unsigned long long) sbuf.st_size, + tparams->header_size); exit (EXIT_FAILURE); } else { size = sbuf.st_size; -- 2.33.1

4 3

[resent][PATCH 0/3] mkimage: allow to specify signing algorithm
by Jan Kiszka 24 Jan '22

24 Jan '22

[resent as requested by Simon] Another step to decouple the FIT image specification from the actual signing: With these changes, the signature nodes can leave out an algo property, mkimage will initialize that as well while signing. This way, in-tree FIT source files can be prepared for gaining signatures without defining the key type or size upfront, forcing users to patch the code to change that. Patch 1 is preparatory for this, patch 2 a drive-by cleanup. A better solution would actually be if the algorithm was derived from the provided key. But the underlying crypto layer seems to be rather unprepared for that. Jan Jan Kiszka (3): image-fit: Make string of algo parameter constant mkimage: Drop unused OPT_STRING constant mkimage: Allow to specify the signature algorithm on the command line boot/image-fit-sig.c | 2 +- boot/image-fit.c | 8 +++---- doc/mkimage.1 | 5 +++++ include/image.h | 5 +++-- tools/fit_image.c | 3 ++- tools/image-host.c | 50 +++++++++++++++++++++++++------------------- tools/imagetool.h | 1 + tools/mkimage.c | 6 ++++-- 8 files changed, 49 insertions(+), 31 deletions(-) -- 2.31.1

3 9

[PATCH 0/2] fix dumpimage for fit images
by Stefan Eichenberger 24 Jan '22

24 Jan '22

dumpimage does not work properly when an image includes "@" because signing would fail. However, this should be supported because it is enabled by default (even when signing is disabled). This patch series tries to fix this by just printing a warning instead of failing completely. Stefan Eichenberger (2): tools/fitimage: remove redundant format check tools/fitimage: make sure dumpimage still works when "@" are detected tools/fit_common.c | 12 ++++++++++-- tools/fit_image.c | 5 ----- 2 files changed, 10 insertions(+), 7 deletions(-) -- 2.32.0

3 6

[PULL] Pull request for u-boot/master v2024.01 = u-boot-stm32-20220124
by Patrice CHOTARD 24 Jan '22

24 Jan '22

Hi Tom Please pull the STM32 related patches for u-boot/master, v2022.04: u-boot-stm32-20220124 CI status: https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/10748 Thanks Patrice The following changes since commit d323242b62920be08e3a2efb1a61bd9bdf9ed583: Merge https://source.denx.de/u-boot/custodians/u-boot-sh (2022-01-23 09:54:49 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-stm.git tags/u-boot-stm32-20220124 for you to fetch changes up to 22c0815ecaa538de51a5204caceec850d5965126: configs: stm32mp15: Enable OF_BOARD flag (2022-01-24 11:03:21 +0100) ---------------------------------------------------------------- - stm32mp15: sync DT with kernel v5.16 - stm32mp15: Enable OF_BOARD config flag - DHCOM: sync DT with kernel 5.15.12 - stm32mp: Fix USB boot device - stm32mp: Remove bootcount activation - stm32mp: Fix board_get_alt_info_mmc() - board: stm32mp1: solve compilation issue when ENV_IS_IN_MMC is deactivated - stm32prog: add partition name in treat_partition_list error messages ---------------------------------------------------------------- Heinrich Schuchardt (1): stm32mp: fix board_get_alt_info_mmc() Marek Vasut (4): arm: stm32mp: Fix USB boot device report ARM: dts: stm32: Add DFU support for DHCOR recovery ARM: dts: stm32: Synchronize DHCOR DTs with Linux 5.15.12 ARM: dts: stm32: Synchronize DHCOM DTs with Linux 5.15.12 Patrice Chotard (1): configs: stm32mp15: Enable OF_BOARD flag Patrick Delaunay (5): stm32mp: remove the bootcount activation stm32mp: correct the dependency for bootcount configs arm: dts: stm32mp15: alignment with v5.16 board: stm32mp1: solve compilation issue when ENV_IS_IN_MMC is deactivated stm32prog: add partition name in treat_partition_list error messages arch/arm/dts/Makefile | 1 - arch/arm/dts/stm32mp15-pinctrl.dtsi | 8 +- arch/arm/dts/stm32mp151.dtsi | 19 +- arch/arm/dts/stm32mp157a-avenger96.dts | 8 - arch/arm/dts/stm32mp157a-dhcor-avenger96.dts | 38 ++ arch/arm/dts/stm32mp15xx-dhcom-drc02.dts | 162 +------- arch/arm/dts/stm32mp15xx-dhcom-drc02.dtsi | 165 ++++++++ arch/arm/dts/stm32mp15xx-dhcom-pdk2-u-boot.dtsi | 4 + arch/arm/dts/stm32mp15xx-dhcom-pdk2.dts | 14 +- arch/arm/dts/stm32mp15xx-dhcom-pdk2.dtsi | 325 ++++++++++++++++ arch/arm/dts/stm32mp15xx-dhcom-picoitx-u-boot.dtsi | 6 +- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dts | 88 +---- arch/arm/dts/stm32mp15xx-dhcom-picoitx.dtsi | 147 +++++++ ...p15xx-dhcom.dtsi => stm32mp15xx-dhcom-som.dtsi} | 387 ++++++++++-------- arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 43 +- .../dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 2 + arch/arm/dts/stm32mp15xx-dhcor-avenger96.dts | 202 +--------- arch/arm/dts/stm32mp15xx-dhcor-avenger96.dtsi | 431 +++++++++++++++++++++ arch/arm/dts/stm32mp15xx-dhcor-io1v8.dtsi | 7 +- ...dhcor-io3v3.dtsi => stm32mp15xx-dhcor-som.dtsi} | 30 +- arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 50 +++ arch/arm/dts/stm32mp15xx-dkx.dtsi | 2 +- arch/arm/mach-stm32mp/Kconfig | 11 +- arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 12 +- arch/arm/mach-stm32mp/spl.c | 2 +- board/st/common/stm32mp_dfu.c | 2 +- board/st/stm32mp1/stm32mp1.c | 6 +- configs/stm32mp15_dhcor_basic_defconfig | 14 +- include/configs/stm32mp15_common.h | 1 - include/configs/stm32mp15_dh_dhsom.h | 7 + 30 files changed, 1510 insertions(+), 684 deletions(-) delete mode 100644 arch/arm/dts/stm32mp157a-avenger96.dts create mode 100644 arch/arm/dts/stm32mp157a-dhcor-avenger96.dts create mode 100644 arch/arm/dts/stm32mp15xx-dhcom-drc02.dtsi create mode 100644 arch/arm/dts/stm32mp15xx-dhcom-pdk2.dtsi create mode 100644 arch/arm/dts/stm32mp15xx-dhcom-picoitx.dtsi rename arch/arm/dts/{stm32mp15xx-dhcom.dtsi => stm32mp15xx-dhcom-som.dtsi} (56%) create mode 100644 arch/arm/dts/stm32mp15xx-dhcor-avenger96.dtsi rename arch/arm/dts/{stm32mp15xx-dhcor-io3v3.dtsi => stm32mp15xx-dhcor-som.dtsi} (91%)

2 1

[PATCH] configs: stm32mp15: Enable OF_BOARD flag
by Patrice Chotard 24 Jan '22

24 Jan '22

Since commit 985503439762 ("fdt: Don't call board_fdt_blob_setup() without OF_BOARD") board_fdt_blob_setup() is no more called on STM32MP platforms in trusted boot which hangs during boot process. Enable OF_BOARD flag to fix this issue. Signed-off-by: Patrice Chotard <patrice.chotard(a)foss.st.com> --- arch/arm/mach-stm32mp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig index a6c7fc5bfd..1ef426c0e0 100644 --- a/arch/arm/mach-stm32mp/Kconfig +++ b/arch/arm/mach-stm32mp/Kconfig @@ -40,6 +40,7 @@ config STM32MP15x select CPU_V7A select CPU_V7_HAS_NONSEC select CPU_V7_HAS_VIRT + select OF_BOARD if TFABOOT select OF_BOARD_SETUP select PINCTRL_STM32 select STM32_RCC -- 2.17.1

3 2

[PATCH] stm32prog: add partition name in treat_partition_list error messages
by Patrick Delaunay 24 Jan '22

24 Jan '22

Add the partition name and remove the line number in error messages of treat_partition_list() to provide correct information to user of STM32CubeProgrammer. The "line number" value was confusing because it is incorrect here; the index in part_array[] is not aligned with the line number in the parsed Layout file, because the empty lines and the lines beginning by '#' are skipped during the first parsing in parse_flash_layout(). Signed-off-by: Patrick Delaunay <patrick.delaunay(a)foss.st.com> --- arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c index 3b6ca4e773..61cba157fd 100644 --- a/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c @@ -835,8 +835,8 @@ static int treat_partition_list(struct stm32prog_data *data) /* skip partition with IP="none" */ if (part->target == STM32PROG_NONE) { if (IS_SELECT(part)) { - stm32prog_err("Layout: selected none phase = 0x%x", - part->id); + stm32prog_err("Layout: selected none phase = 0x%x for part %s", + part->id, part->name); return -EINVAL; } continue; @@ -844,14 +844,14 @@ static int treat_partition_list(struct stm32prog_data *data) if (part->id == PHASE_FLASHLAYOUT || part->id > PHASE_LAST_USER) { - stm32prog_err("Layout: invalid phase = 0x%x", - part->id); + stm32prog_err("Layout: invalid phase = 0x%x for part %s", + part->id, part->name); return -EINVAL; } for (j = i + 1; j < data->part_nb; j++) { if (part->id == data->part_array[j].id) { - stm32prog_err("Layout: duplicated phase 0x%x at line %d and %d", - part->id, i, j); + stm32prog_err("Layout: duplicated phase 0x%x for part %s and %s", + part->id, part->name, data->part_array[j].name); return -EINVAL; } } -- 2.25.1

2 2