January 2022 - U-Boot

[PATCH u-boot-pci] pci: iproc: Set all 24 bits of PCI class code
by Pali Rohár 25 Jan '22

25 Jan '22

Register 0x43c in its low 24 bits contains PCI class code. Update code to set all 24 bits of PCI class code and not only upper 16 bits of PCI class code. Use standard U-Boot macro (PCI_CLASS_BRIDGE_PCI << 8) for constructing all 24-bits of PCI class for PCI bridge Normal decode. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- Roman helped me with this change and confirmed that class code is stored really in bits [23:0] of custom register 0x43c (normally class code is stored in bits [31:8] of pci register 0x08). --- drivers/pci/pcie_iproc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pcie_iproc.c b/drivers/pci/pcie_iproc.c index be03dcbd97c0..fe68e417ae80 100644 --- a/drivers/pci/pcie_iproc.c +++ b/drivers/pci/pcie_iproc.c @@ -1127,15 +1127,14 @@ static int iproc_pcie_check_link(struct iproc_pcie *pcie) u32 link_status, class; pcie->link_is_active = false; - /* force class to PCI_CLASS_BRIDGE_PCI (0x0604) */ + /* force class to PCI bridge Normal decode (0x060400) */ #define PCI_BRIDGE_CTRL_REG_OFFSET 0x43c -#define PCI_CLASS_BRIDGE_MASK 0xffff00 -#define PCI_CLASS_BRIDGE_SHIFT 8 +#define PCI_BRIDGE_CTRL_REG_CLASS_MASK 0xffffff iproc_pci_raw_config_read32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET, 4, &class); - class &= ~PCI_CLASS_BRIDGE_MASK; - class |= (PCI_CLASS_BRIDGE_PCI << PCI_CLASS_BRIDGE_SHIFT); + class &= ~PCI_BRIDGE_CTRL_REG_CLASS_MASK; + class |= (PCI_CLASS_BRIDGE_PCI << 8); iproc_pci_raw_config_write32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET, 4, class); -- 2.20.1

3 2

[PATCH 0/6] moveconfig: Improve the pylist score a little
by Simon Glass 25 Jan '22

25 Jan '22

There are about 240 warnings in this file. This series refactors file reading and writing, which fixes about 40. It also includes a patch to make a start on the rest, reducing the count to about 160. It also tidies up quoting. There are still about 160 warnings left. Simon Glass (6): moveconfig: Use single quotes moveconfig: Convert to ArgumentParser moveconfig: Drop check for old Python moveconfig: Use a function to write files moveconfig: Use a function to read files moveconfig: Fix some pylint errors tools/moveconfig.py | 645 +++++++++++++++++++++++--------------------- 1 file changed, 336 insertions(+), 309 deletions(-) -- 2.34.1.173.g76aa8bc2d0-goog

3 17

[PATCH 1/5] moveconfig: Correct operation of the 'imply' feature
by Simon Glass 25 Jan '22

25 Jan '22

This doesn't work anymore, since the Kconfig update. The script has no tests so we did not notice. Fix it. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- tools/moveconfig.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 373b395fda4..8d059be039d 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -1263,7 +1263,7 @@ def find_kconfig_rules(kconf, config, imply_config): sym = kconf.syms.get(imply_config) if sym: for sel, cond in (sym.selects + sym.implies): - if sel == config: + if sel.name == config: return sym return None @@ -1291,7 +1291,8 @@ def check_imply_rule(kconf, config, imply_config): nodes = sym.nodes if len(nodes) != 1: return '%d locations' % len(nodes) - fname, linenum = nodes[0].filename, nodes[0].linern + node = nodes[0] + fname, linenum = node.filename, node.linenr cwd = os.getcwd() if cwd and fname.startswith(cwd): fname = fname[len(cwd) + 1:] @@ -1382,7 +1383,7 @@ def do_imply_config(config_list, add_imply, imply_flags, skip_added, """ kconf = KconfigScanner().conf if check_kconfig else None if add_imply and add_imply != 'all': - add_imply = add_imply.split() + add_imply = add_imply.split(',') # key is defconfig name, value is dict of (CONFIG_xxx, value) config_db = {} @@ -1414,7 +1415,7 @@ def do_imply_config(config_list, add_imply, imply_flags, skip_added, else: # New defconfig defconfig = line - # Work through each target config option in tern, independently + # Work through each target config option in turn, independently for config in config_list: defconfigs = defconfig_db.get(config) if not defconfigs: -- 2.34.1.173.g76aa8bc2d0-goog

2 9

[PATCH 1/1] test: fix pylint warnings in test_env.py
by Heinrich Schuchardt 25 Jan '22

25 Jan '22

* assert does not need parentheses * add module docstring * fix misspelled constant True * limit lines to 100 characters Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- test/py/tests/test_env.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py index 9bed2f48d7..39fad4194b 100644 --- a/test/py/tests/test_env.py +++ b/test/py/tests/test_env.py @@ -2,11 +2,13 @@ # Copyright (c) 2015 Stephen Warren # Copyright (c) 2015-2016, NVIDIA CORPORATION. All rights reserved. -# Test operation of shell commands relating to environment variables. +""" +Test operation of shell commands relating to environment variables. +""" import os import os.path -from subprocess import call, check_call, CalledProcessError +from subprocess import call, CalledProcessError import pytest import u_boot_utils @@ -191,7 +193,7 @@ def test_env_printenv_non_existent(state_test_env): c = state_test_env.u_boot_console with c.disable_check('error_notification'): response = c.run_command('printenv %s' % var) - assert(response == '## Error: "%s" not defined' % var) + assert response == '## Error: "%s" not defined' % var @pytest.mark.buildconfigspec('cmd_echo') def test_env_unset_non_existent(state_test_env): @@ -256,7 +258,7 @@ def test_env_import_checksum_no_size(state_test_env): with c.disable_check('error_notification'): response = c.run_command('env import -c %s -' % addr) - assert(response == '## Error: external checksum format must pass size') + assert response == '## Error: external checksum format must pass size' @pytest.mark.buildconfigspec('cmd_importenv') def test_env_import_whitelist_checksum_no_size(state_test_env): @@ -269,7 +271,7 @@ def test_env_import_whitelist_checksum_no_size(state_test_env): with c.disable_check('error_notification'): response = c.run_command('env import -c %s - foo1 foo2 foo4' % addr) - assert(response == '## Error: external checksum format must pass size') + assert response == '## Error: external checksum format must pass size' @pytest.mark.buildconfigspec('cmd_exportenv') @pytest.mark.buildconfigspec('cmd_importenv') @@ -358,12 +360,14 @@ def test_env_info(state_test_env): assert '= true' in l or '= false' in l nb_line += 1 else: - assert true + assert True assert nb_line == 3 response = c.run_command('env info -p -d') - assert 'Default environment is used' in response or "Environment was loaded from persistent storage" in response - assert 'Environment can be persisted' in response or "Environment cannot be persisted" in response + assert 'Default environment is used' in response or \ + "Environment was loaded from persistent storage" in response + assert 'Environment can be persisted' in response or \ + "Environment cannot be persisted" in response response = c.run_command('env info -p -d -q') assert response == "" -- 2.32.0

2 1

[PATCH 0/6] Add a pylint check
by Simon Glass 25 Jan '22

25 Jan '22

U-Boot has about 60k lines of Python code. This is quite small relative to the total code size, but it is still important to keep the code style consistent. This series allows pylint to be run on Python files within U-Boot to detect any changes that reduce the current pylint ‘score’ of any modules. It works by comparing the current state against a base state kept in a file. The check is invoked with: make pylint This should gradually help to improve the code. The series also tidies up a few minor nits to produce better pylint output. Simon Glass (6): .gitignore: Ignore any html coverage directory dtoc: Fix up a code comment that confuses pylint patman: Update the list of modules tools: Add init files for Python tools Makefile: Add a pylint checker to the build Azure/GitLab CI: Add the pylint checker .azure-pipelines.yml | 17 +++ .gitignore | 7 ++ .gitlab-ci.yml | 12 +++ Makefile | 45 +++++++- doc/develop/index.rst | 8 ++ doc/develop/python_cq.rst | 80 ++++++++++++++ scripts/pylint.base | 211 +++++++++++++++++++++++++++++++++++++ tools/binman/__init__.py | 0 tools/buildman/__init__.py | 0 tools/dtoc/__init__.py | 0 tools/dtoc/dtb_platdata.py | 2 +- tools/patman/__init__.py | 9 +- 12 files changed, 386 insertions(+), 5 deletions(-) create mode 100644 doc/develop/python_cq.rst create mode 100644 scripts/pylint.base create mode 100644 tools/binman/__init__.py create mode 100644 tools/buildman/__init__.py create mode 100644 tools/dtoc/__init__.py -- 2.34.0.rc2.393.gf8c9666880-goog

3 17

[PATCH v3 00/20] J721S2: Add initial support
by Aswath Govindraju 25 Jan '22

25 Jan '22

The J721S2 SoC belongs to the K3 Multicore SoC architecture platform, providing advanced system integration in automotive ADAS applications and industrial applications requiring AI at the network edge. This SoC extends the Jacinto 7 family of SoCs with focus on lowering system costs and power while providing interfaces, memory architecture and compute performance for single and multi-sensor applications. Some highlights of this SoC are: * Dual Cortex-A72s in a single cluster, three clusters of lockstep capable dual Cortex-R5F MCUs, Deep-learning Matrix Multiply Accelerator(MMA), C7x floating point Vector DSP. * 3D GPU: Automotive grade IMG BXS-4-64 * Vision Processing Accelerator (VPAC) with image signal processor and Depth and Motion Processing Accelerator (DMPAC) * Two CSI2.0 4L RX plus one eDP/DP, two DSI Tx, and one DPI interface. * Two Ethernet ports with RGMII support. * Single 4 lane PCIe-GEN3 controllers, USB3.0 Dual-role device subsystems, * Up to 20 MCANs, 5 McASP, eMMC and SD, OSPI/HyperBus memory controller, QSPI, I3C and I2C, eCAP/eQEP, eHRPWM, MLB among other peripherals. * Hardware accelerator blocks containing AES/DES/SHA/MD5 called SA2UL management. * Chips and Media Wave521CL H.264/H.265 encode/decode engine See J721S2 Technical Reference Manual (SPRUJ28 – NOVEMBER 2021) for further details: http://www.ti.com/lit/pdf/spruj28 bootlog: - https://pastebin.ubuntu.com/p/8FfVJjVVSC/ Notes: - Patches 12, 13, 14, 15 and 16 are synced from upstream kernel v5.17-rc1 tag Changes since v2: - Removed the redundant config K3_J721S2_DDRSS and instead used K3_J721E_DDRSS - Formatted the Kconfig files to remove extra lines - Added dts files in the MAINTAINERS baord folder Changes since v1: - Removed unused serial aliases - Assigned serial2 alias for main uart8 instance - Moved aliases to respective board files Aswath Govindraju (10): ram: k3-ddrss: lpddr4_structs_if.h: Add a pointer to ddr instance ram: k3-ddrss: Add support for multiple instances of DDR subsystems ram: k3-ddrss: Add support for configuring MSMC subsystem in case of Multiple DDR subsystems dt-bindings: ti-serdes-mux: Add defines for J721S2 SoC dt-bindings: pinctrl: k3: Introduce pinmux definitions for J721S2 arm: dts: Add initial support for J721S2 SoC arm: dts: Add initial support for J721S2 System on Module arm: dts: Add support for A72 specific J721S2 Common Processor Board arm: dts: k3-j721s2: Add r5 specific dt support arm: dts: k3-j721s2-ddr: Add DDR support David Huang (9): arm: K3: Add basic support for J721S2 SoC definition drivers: dma: Add support for J721S2 clk: clk-k3: Add support for J721S2 SoC power: domain: ti: Add support for J721S2 SoC ram: k3-ddrss: Add support for J721S2 SoC soc: ti: k3-socinfo: Add entry for J721S2 SoC board: ti: j721s2: Add board support for J721S2 configs: j721s2_evm_r5_defconfig: Add R5 SPL specific defconfig configs: j721s2_evm_a72_defconfig: Add A72 specific defconfig Nishanth Menon (1): remoteproc: k3_system_controller: Support optional boot_notification channel arch/arm/dts/Makefile | 2 + .../k3-j721s2-common-proc-board-u-boot.dtsi | 149 + arch/arm/dts/k3-j721s2-common-proc-board.dts | 430 ++ arch/arm/dts/k3-j721s2-ddr-evm-lp4-4266.dtsi | 4387 ++++++++++++++++ arch/arm/dts/k3-j721s2-ddr.dtsi | 4440 +++++++++++++++++ arch/arm/dts/k3-j721s2-main.dtsi | 937 ++++ arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi | 302 ++ .../dts/k3-j721s2-r5-common-proc-board.dts | 198 + arch/arm/dts/k3-j721s2-som-p0.dtsi | 173 + arch/arm/dts/k3-j721s2.dtsi | 167 + arch/arm/mach-k3/Kconfig | 15 +- arch/arm/mach-k3/Makefile | 1 + arch/arm/mach-k3/arm64-mmu.c | 53 + arch/arm/mach-k3/include/mach/hardware.h | 4 + .../mach-k3/include/mach/j721s2_hardware.h | 60 + arch/arm/mach-k3/include/mach/j721s2_spl.h | 46 + arch/arm/mach-k3/include/mach/spl.h | 4 + arch/arm/mach-k3/j721s2/Makefile | 5 + arch/arm/mach-k3/j721s2/clk-data.c | 403 ++ arch/arm/mach-k3/j721s2/dev-data.c | 85 + arch/arm/mach-k3/j721s2_init.c | 312 ++ board/ti/j721s2/Kconfig | 63 + board/ti/j721s2/MAINTAINERS | 16 + board/ti/j721s2/Makefile | 8 + board/ti/j721s2/evm.c | 180 + configs/j721s2_evm_a72_defconfig | 207 + configs/j721s2_evm_r5_defconfig | 171 + .../remoteproc/k3-system-controller.txt | 3 + drivers/clk/ti/clk-k3.c | 5 + drivers/dma/ti/Makefile | 1 + drivers/dma/ti/k3-psil-j721s2.c | 167 + drivers/dma/ti/k3-psil-priv.h | 1 + drivers/dma/ti/k3-psil.c | 2 + drivers/firmware/ti_sci_static_data.h | 40 +- drivers/power/domain/ti-power-domain.c | 5 + drivers/ram/Kconfig | 2 +- drivers/ram/k3-ddrss/k3-ddrss.c | 296 +- drivers/ram/k3-ddrss/lpddr4_structs_if.h | 1 + drivers/remoteproc/k3_system_controller.c | 20 +- drivers/soc/soc_ti_k3.c | 4 + include/configs/j721s2_evm.h | 191 + include/dt-bindings/mux/ti-serdes.h | 22 + include/dt-bindings/pinctrl/k3.h | 3 + include/k3-clk.h | 1 + include/k3-dev.h | 1 + 45 files changed, 13522 insertions(+), 61 deletions(-) create mode 100644 arch/arm/dts/k3-j721s2-common-proc-board-u-boot.dtsi create mode 100644 arch/arm/dts/k3-j721s2-common-proc-board.dts create mode 100644 arch/arm/dts/k3-j721s2-ddr-evm-lp4-4266.dtsi create mode 100644 arch/arm/dts/k3-j721s2-ddr.dtsi create mode 100644 arch/arm/dts/k3-j721s2-main.dtsi create mode 100644 arch/arm/dts/k3-j721s2-mcu-wakeup.dtsi create mode 100644 arch/arm/dts/k3-j721s2-r5-common-proc-board.dts create mode 100644 arch/arm/dts/k3-j721s2-som-p0.dtsi create mode 100644 arch/arm/dts/k3-j721s2.dtsi create mode 100644 arch/arm/mach-k3/include/mach/j721s2_hardware.h create mode 100644 arch/arm/mach-k3/include/mach/j721s2_spl.h create mode 100644 arch/arm/mach-k3/j721s2/Makefile create mode 100644 arch/arm/mach-k3/j721s2/clk-data.c create mode 100644 arch/arm/mach-k3/j721s2/dev-data.c create mode 100644 arch/arm/mach-k3/j721s2_init.c create mode 100644 board/ti/j721s2/Kconfig create mode 100644 board/ti/j721s2/MAINTAINERS create mode 100644 board/ti/j721s2/Makefile create mode 100644 board/ti/j721s2/evm.c create mode 100644 configs/j721s2_evm_a72_defconfig create mode 100644 configs/j721s2_evm_r5_defconfig create mode 100644 drivers/dma/ti/k3-psil-j721s2.c create mode 100644 include/configs/j721s2_evm.h -- 2.17.1

2 22

[PATCH 0/3] QEMU spike machine support for U-Boot
by Anup Patel 25 Jan '22

25 Jan '22

We can use same U-Boot binary compiled using qemu-riscv64_smode_defconfig on QEMU virt machine and QEMU spike machine. To achieve this, we need HTIF console support for U-Boot QEMU RISC-V board hence this series. To test this series with latest OpenSBI, we can use the following command: qemu-system-riscv64 -M spike -m 256M -display none -serial stdio \ -bios opensbi/build/platform/generic/firmware/fw_jump.bin -kernel \ ./u-boot/u-boot.bin These patch can be found in qemu_riscv_htif_v1 branch at: https://github.com/avpatel/u-boot.git Anup Patel (3): serial: Add RISC-V HTIF console driver riscv: qemu: Enable HTIF console support riscv: qemu: Implement is_flash_available() for MTD NOR board/emulation/qemu-riscv/Kconfig | 1 + board/emulation/qemu-riscv/qemu-riscv.c | 17 +++ drivers/serial/Kconfig | 8 ++ drivers/serial/Makefile | 1 + drivers/serial/serial_htif.c | 178 ++++++++++++++++++++++++ 5 files changed, 205 insertions(+) create mode 100644 drivers/serial/serial_htif.c -- 2.25.1

3 15

[RESEND PATCH] arm: kirkwood: Pogoplug V4 : Use Marvell network PHY driver
by Tony Dinh 25 Jan '22

25 Jan '22

The Pogoplug V4 board has the network chip Marvell 88E1116R. So to properly configure the network, enable CONFIG_PHY_MARVELL to activate the compatible driver M88E1118R. - This patch depends on the series: https://patchwork.ozlabs.org/project/uboot/patch/20220124061712.28316-2-mib… Signed-off-by: Tony Dinh <mibodhi(a)gmail.com> --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig index 5490067b9e..1cf409c834 100644 --- a/configs/pogo_v4_defconfig +++ b/configs/pogo_v4_defconfig @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y CONFIG_MVEBU_MMC=y CONFIG_MTD=y CONFIG_MTD_RAW_NAND=y +CONFIG_PHY_MARVELL=y CONFIG_DM_ETH=y CONFIG_MVGBE=y CONFIG_MII=y -- 2.30.2

1 0

Re: [PATCH 1/1] i2c: mvtwsi: Add compatible string for allwinner, sun4i-a10-i2c
by Jose Torres 25 Jan '22

25 Jan '22

I faced the boot failure issue when attempting to bring mainline 2022.01 to our Kettlepop device which is a derivative of Next Thing's C.H.I.P. Pro. Kettlepop has eMMC memory rather than NAND flash as used in C.H.I.P. Pro. This device has a GR8 SiP which contains an R8/A13 die. Without this patch, U-Boot will halt after DRAM detection. Applying this patch will allow it to boot normally. Kettlepop has a defconfig identical to mainline C.H.I.P. Pro defconfig with MMC configuration instead of the NAND MTD stuff. Below is a log of a failed boot: ``` U-Boot SPL 2022.01 (Jan 24 2022 - 19:48:00 +0800) DRAM: 256 MiB CPU: 1008000000Hz, AXI/AHB/APB: 3/2/2 Trying to boot from FEL U-Boot 2022.01 (Jan 24 2022 - 19:48:00 +0800) Popcorn Computer CPU: Allwinner A13 (SUN5I) Model: Source Parts Kettlepop DRAM: 256 MiB ```

1 0

[PATCH v2 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration
by Patrick Wildt 25 Jan '22

25 Jan '22

The i.MX8MM boards have been converted for some longer time compared to i.MX8MQ. During that time the i.MX8MM binman configuration has already gotten some cleanup. This brings the i.MX8MQ binman config in line with the i.MX8MM one, and also fixes node names in the i.MX8MM config. Changes since v1: - Underscores in node names replaced with dashes. Patrick Wildt (4): arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename arm64: dts: imx8mm-u-boot.dtsi: use dash for node names arm64: dts: imx8mq-u-boot.dtsi: improve odd blob-ext naming arch/arm/dts/imx8mm-u-boot.dtsi | 12 +++---- arch/arm/dts/imx8mq-u-boot.dtsi | 59 +++++++++++++++++++-------------- 2 files changed, 40 insertions(+), 31 deletions(-) -- 2.34.1

3 9