December 2021 - U-Boot

[PATCH] LED BOOT support added for Cubieboard2.
by Javad Rahimi 07 Dec '21

07 Dec '21

PH20 and PH21 are two LED on the board which users can select to be turn on at boot time. Signed-off-by: Javad Rahimi <javad321javad(a)gmail.com> --- board/sunxi/board.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 4f5747c34a..ff80283702 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -1002,3 +1002,45 @@ int board_fit_config_name_match(const char *name) return ret; } #endif + +#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT) && defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) + +#define CUBIE2_LED_BOOT_GPIO "PH20" +static int gpio_boot_led; + +void __led_init (led_id_t mask, int state) +{ + int ret; + + if (CONFIG_LED_STATUS_BOOT != mask) + return; + + ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, &gpio_boot_led); + + if (ret) + debug("[gpio_lookup_name]LED Err: %d", ret); + return; + + gpio_request(gpio_boot_led, "boot_led"); + gpio_direction_output(gpio_boot_led, 1); + __led_set(mask, state); +} + +void __led_set(led_id_t mask, int state) +{ + if (CONFIG_LED_STATUS_BOOT != mask) + return; + + debug("[__led_set]LED Mask:%ld, STATE:%d\n", mask, state); + gpio_set_value(gpio_boot_led, state); +} + +void __led_toggle(led_id_t mask) +{ + if (CONFIG_LED_STATUS_BOOT != mask) + return; + + gpio_set_value(gpio_boot_led, ~gpio_get_value(gpio_boot_led)); +} + +#endif -- 2.25.1

1 0

[PATCH] sunxi: Remove misleading USB-OTG charger message
by Andre Przywara 07 Dec '21

07 Dec '21

The sunxi MUSB glue driver has some code to check for external VBUS presence when it's going to use the MUSB host mode, and it warns if there is VBUS provided through the cable (in sunxi_musb_enable()). This code was apparently copied to the USB gadget detection code (g_dnl_board_usb_cable_connected()), but here we actually *expect* external VBUS power, so a warning is wrong and confusing. So far this message rarely triggered, but a recent patch (6fa41cdd19b9) changed this: =========================== => ums 0 mmc 2 UMS: LUN 0, dev mmc 2, hwpart 0, sector 0x0, count 0xe90000 A charger is plugged into the OTG /A charger is plugged into the OTG \A charger is plugged into the OTG |A charger is plugged into the OTG -A charger is plugged into the OTG .... =========================== Remove the message for the gadget cable detection call, and just return the status of the VBUS detection, as this is what the callers are after. Signed-off-by: Andre Przywara <andre.przywara(a)arm.com> --- board/sunxi/board.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 4f5747c34a9..fdbcd402693 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -698,13 +698,7 @@ int g_dnl_board_usb_cable_connected(void) return ret; } - ret = sun4i_usb_phy_vbus_detect(&phy); - if (ret == 1) { - pr_err("A charger is plugged into the OTG\n"); - return -ENODEV; - } - - return ret; + return sun4i_usb_phy_vbus_detect(&phy); } #endif -- 2.17.6

2 1

[PATCH v2 1/3] phy-sun4i-usb: Fix sun8i_r40_cfg
by qianfanguijin＠163.com 07 Dec '21

07 Dec '21

From: qianfan Zhao <qianfanguijin(a)163.com> the r40 has the same configurations with a33, disable enable_pmu_unk1 and phy0_dual_route feature. Signed-off-by: qianfan Zhao <qianfanguijin(a)163.com> --- drivers/phy/allwinner/phy-sun4i-usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c index 5723c98032..5ea05a207d 100644 --- a/drivers/phy/allwinner/phy-sun4i-usb.c +++ b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -589,8 +589,6 @@ static const struct sun4i_usb_phy_cfg sun8i_r40_cfg = { .disc_thresh = 3, .phyctl_offset = REG_PHYCTL_A33, .dedicated_clocks = true, - .enable_pmu_unk1 = true, - .phy0_dual_route = true, }; static const struct sun4i_usb_phy_cfg sun8i_v3s_cfg = { -- 2.17.1

2 4

[PATCH v2 3/6] clk: sunxi: v3s: fix tabs / spaces
by Andreas Rehn 07 Dec '21

07 Dec '21

align CLK_USB_PHY0 with tabs Signed-off-by: Andreas Rehn <rehn.andreas86(a)gmail.com> --- drivers/clk/sunxi/clk_v3s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk_v3s.c b/drivers/clk/sunxi/clk_v3s.c index 55fc597043..bc6b7b4870 100644 --- a/drivers/clk/sunxi/clk_v3s.c +++ b/drivers/clk/sunxi/clk_v3s.c @@ -29,7 +29,7 @@ static struct ccu_clk_gate v3s_gates[] = { [CLK_SPI0] = GATE(0x0a0, BIT(31)), - [CLK_USB_PHY0] = GATE(0x0cc, BIT(8)), + [CLK_USB_PHY0] = GATE(0x0cc, BIT(8)), }; static struct ccu_reset v3s_resets[] = { -- 2.25.1

2 3

[PATCH 0/3] fix TCG2 error handling
by Masahisa Kojima 07 Dec '21

07 Dec '21

This series fix the efi_tcg2.c error handling. Masahisa Kojima (3): efi_loader: efi_tcg2_register returns appropriate error efi_loader: check tcg2 protocol installation outside the TCG protocol efi_loader: correctly handle tcg2_measure_pe_image() error include/efi_loader.h | 2 + lib/efi_loader/Kconfig | 2 + lib/efi_loader/efi_image_loader.c | 11 +++- lib/efi_loader/efi_setup.c | 2 + lib/efi_loader/efi_tcg2.c | 85 ++++++++++++++++++++++++------- 5 files changed, 81 insertions(+), 21 deletions(-) -- 2.17.1

2 7

Raspberry Pi Boot 1b / Uboot boot failure with large initramfs
by Frederik Lotter 06 Dec '21

06 Dec '21

Hi, I am facing intermittend boot failures resulting in a data abort. Boot log and environment attached below. The uboot is built with rpi_defconfig with OF_BOARD to get uboot to pass through the FDT. Note: (1) If I boot this image directly using the RPI bootloader, the kernel (with initramfs embedded) boots fine consistently. (2) However, I get inconsistent failures with uboot. My gut tells me memory is getting corrupted. (3) Sometimes just adding one option to the bootargs breaks the next boot. (4) It seems the FDT address changes slightly (see failed vs OK). Not sure if this is expected from start.elf (I assume the FDT address is supplied to u-boot). (5) Is the size of the image overwriting anything in u-boot? I am not that familiar with the u-boot memory map. I boot using the following environment changes: bootargs=bootslot=a console=ttyAMA0,115200 root=/dev/null bootcmd=fatload mmc 0:1 ${kernel_addr_r} kernel.a.img ; bootz ${kernel_addr_r} - ${fdtcontroladdr} Any ideas? Regards, Fred BOOT: DRAM: 448 MiB RPI Model B rev2 (0xe) MMC: mmc@7e202000: 0 Loading Environment from FAT... OK In: serial Out: vidconsole Err: vidconsole Net: No ethernet found. starting USB... Bus usb@7e980000: usb dr_mode not found USB DWC2 scanning bus usb@7e980000 for devices... 3 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found Hit any key to stop autoboot: 0 70746744 bytes read in 2940 ms (22.9 MiB/s) Kernel image @ 0x080000 [ 0x000000 - 0x4378278 ] ## Flattened Device Tree blob at 1bb500e0 Booting using the fdt blob at 0x1bb500e0 Using Device Tree in place at 1bb500e0, end 1bb59ebe data abort pc : [<1bf5c4ec>] lr : [<1bf5c7c4>] reloc pc : [<000094ec>] lr : [<000097c4>] sp : 1bb4fdb8 ip : 0000000c fp : 00000003 r10: 00000000 r9 : 1bb56ec0 r8 : 1bb6bad4 r7 : 00000000 r6 : 00080000 r5 : 1bfc5874 r4 : 00000400 r3 : 0074616d r2 : 1bb6bad4 r1 : 00000400 r0 : 1bfc5874 Flags: nzcv IRQs off FIQs off Mode SVC_32 Code: e12fff1e e92d4073 e5993000 e5906060 (e5933038) Resetting CPU ... resetting ... ENV: arch=arm baudrate=115200 board=rpi board_name=Model B rev2 board_rev=0xE board_rev_scheme=0 board_revision=0xE boot_a_script=load ${devtype} ${devnum}:${distro_bootpart} ${scriptaddr} ${prefix}${script}; source ${scriptaddr} boot_efi_binary=load ${devtype} ${devnum}:${distro_bootpart} ${kernel_addr_r} efi/boot/bootarm.efi; if fdt addr ${fdt_addr_r}; then bootefi ${kernel_addr_r} ${fdt_addr_r};else bootefi ${kernel_addr_r} ${fdtcontroladdr};fi boot_efi_bootmgr=if fdt addr ${fdt_addr_r}; then bootefi bootmgr ${fdt_addr_r};else bootefi bootmgr;fi boot_extlinux=sysboot ${devtype} ${devnum}:${distro_bootpart} any ${scriptaddr} ${prefix}${boot_syslinux_conf} boot_net_usb_start=usb start boot_prefixes=/ /boot/ boot_script_dhcp=boot.scr.uimg boot_scripts=boot.scr.uimg boot.scr boot_syslinux_conf=extlinux/extlinux.conf boot_targets=mmc0 mmc1 usb0 pxe dhcp bootargs=bootslot=a console=ttyAMA0,115200 root=/dev/null bootcmd=fatload mmc 0:1 ${kernel_addr_r} kernel.a.img ; bootz ${kernel_addr_r} - ${fdtcontroladdr} bootcmd_dhcp=devtype=dhcp; run boot_net_usb_start; if dhcp ${scriptaddr} ${boot_script_dhcp}; then source ${scriptaddr}; fi;setenv efi_fdtfile ${fdtfile}; if test -z "${fdtfile}" -a -n "${soc}"; then setenv efi_fdtfile ${soc}-${board}${boardver}.dtb; fi; setenv efi_old_vci ${bootp_vci};setenv efi_old_arch ${bootp_arch};setenv bootp_vci PXEClient:Arch:00010:UNDI:003000;setenv bootp_arch 0xa;if dhcp ${kernel_addr_r}; then tftpboot ${fdt_addr_r} dtb/${efi_fdtfile};if fdt addr ${fdt_addr_r}; then bootefi ${kernel_addr_r} ${fdt_addr_r}; else bootefi ${kernel_addr_r} ${fdtcontroladdr};fi;fi;setenv bootp_vci ${efi_old_vci};setenv bootp_arch ${efi_old_arch};setenv efi_fdtfile;setenv efi_old_arch;setenv efi_old_vci; bootcmd_mmc0=devnum=0; run mmc_boot bootcmd_mmc1=devnum=1; run mmc_boot bootcmd_pxe=run boot_net_usb_start; dhcp; if pxe get; then pxe boot; fi bootcmd_usb0=devnum=0; run usb_boot bootdelay=2 cpu=arm1176 dhcpuboot=usb start; dhcp u-boot.uimg; bootm distro_bootcmd=for target in ${boot_targets}; do run bootcmd_${target}; done efi_dtb_prefixes=/ /dtb/ /dtb/current/ ethaddr=b8:27:eb:46:ba:40 fdt_addr=1bfe9200 fdt_addr_r=0x02600000 fdt_high=ffffffff fdtcontroladdr=1bb500e0 fdtfile=bcm2835-rpi-b-rev2.dtb initrd_high=ffffffff kernel_addr_r=0x00080000 load_efi_dtb=load ${devtype} ${devnum}:${distro_bootpart} ${fdt_addr_r} ${prefix}${efi_fdtfile} loadaddr=0x00200000 mmc_boot=if mmc dev ${devnum}; then devtype=mmc; run scan_dev_for_boot_part; fi preboot=usb start pxefile_addr_r=0x02500000 ramdisk_addr_r=0x02700000 scan_dev_for_boot=echo Scanning ${devtype} ${devnum}:${distro_bootpart}...; for prefix in ${boot_prefixes}; do run scan_dev_for_extlinux; run scan_dev_for_scripts; done;run scan_dev_for_efi; scan_dev_for_boot_part=part list ${devtype} ${devnum} -bootable devplist; env exists devplist || setenv devplist 1; for distro_bootpart in ${devplist}; do if fstype ${devtype} ${devnum}:${distro_bootpart} bootfstype; then run scan_dev_for_boot; fi; done; setenv devplist scan_dev_for_efi=setenv efi_fdtfile ${fdtfile}; if test -z "${fdtfile}" -a -n "${soc}"; then setenv efi_fdtfile ${soc}-${board}${boardver}.dtb; fi; for prefix in ${efi_dtb_prefixes}; do if test -e ${devtype} ${devnum}:${distro_bootpart} ${prefix}${efi_fdtfile}; then run load_efi_dtb; fi;done;run boot_efi_bootmgr;if test -e ${devtype} ${devnum}:${distro_bootpart} efi/boot/bootarm.efi; then echo Found EFI removable media binary efi/boot/bootarm.efi; run boot_efi_binary; echo EFI LOAD FAILED: continuing...; fi; setenv efi_fdtfile scan_dev_for_extlinux=if test -e ${devtype} ${devnum}:${distro_bootpart} ${prefix}${boot_syslinux_conf}; then echo Found ${prefix}${boot_syslinux_conf}; run boot_extlinux; echo SCRIPT FAILED: continuing...; fi scan_dev_for_scripts=for script in ${boot_scripts}; do if test -e ${devtype} ${devnum}:${distro_bootpart} ${prefix}${script}; then echo Found U-Boot script ${prefix}${script}; run boot_a_script; echo SCRIPT FAILED: continuing...; fi; done scriptaddr=0x02400000 serial#=00000000ec46ba40 soc=bcm283x stderr=serial,vidconsole stdin=serial,usbkbd stdout=serial,vidconsole usb_boot=usb start; if usb dev ${devnum}; then devtype=usb; run scan_dev_for_boot_part; fi usbethaddr=b8:27:eb:46:ba:40 vendor=raspberrypi GOOD UBOOT BOOT: U-Boot> boot 70746744 bytes read in 2942 ms (22.9 MiB/s) Kernel image @ 0x080000 [ 0x000000 - 0x4378278 ] ## Flattened Device Tree blob at 1bb500c0 Booting using the fdt blob at 0x1bb500c0 Using Device Tree in place at 1bb500c0, end 1bb59eaa Starting kernel ... [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 5.10.82-rpiv6-kernos (root@flotter-pc) (armv6-rpi-linux-musleabihf-gcc (crosstool-NG UNKNOWN) 11.2.0, GNU ld (crosstool-NG UNKNOWN) 2.37) #2 Mon Dec 6 00:09:19 SAST 2021 [ 0.000000] CPU: ARMv6-compatible processor [410fb767] revision 7 (ARMv7), cr=00c5387d [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT nonaliasing instruction cache [ 0.000000] OF: fdt: Machine model: Raspberry Pi Model B Rev 2 [ 0.000000] random: fast init done [ 0.000000] Memory policy: Data cache writeback [ 0.000000] Reserved memory: created CMA memory pool at 0x17800000, size 64 MiB [ 0.000000] OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool [ 0.000000] Zone ranges: [ 0.000000] Normal [mem 0x0000000000000000-0x000000001bffffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000000000-0x000000001bffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x000000001bffffff] [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 113680 [ 0.000000] Kernel command line: bootslot=a console=ttyAMA0,115200 root=/dev/null [ 0.000000] Dentry cache hash table entries: 65536 (order: 6, 262144 bytes, linear) [ 0.000000] Inode-cache hash table entries: 32768 (order: 5, 131072 bytes, linear) [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] Memory: 310640K/458752K available (8867K kernel code, 1325K rwdata, 2792K rodata, 64024K init, 836K bss, 82576K reserved, 65536K cma-reserved) [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] ftrace: allocating 29813 entries in 88 pages [ 0.000000] ftrace: allocated 88 pages with 3 groups [ 0.000000] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16 [ 0.000000] random: get_random_bytes called from start_kernel+0x32c/0x57c with crng_init=1 [ 0.000027] sched_clock: 32 bits at 1000kHz, resolution 1000ns, wraps every 2147483647500ns [ 0.000104] clocksource: timer: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 1911260446275 ns [ 0.000199] bcm2835: system timer (irq = 27) [ 0.000890] Console: colour dummy device 80x30 [ 0.000997] Calibrating delay loop... 697.95 BogoMIPS (lpj=3489792) [ 0.060356] pid_max: default: 32768 minimum: 301 [ 0.060665] LSM: Security Framework initializing [ 0.061003] Mount-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.061050] Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.063391] cgroup: Disabling memory control group subsystem [ 0.063847] CPU: Testing write buffer coherency: ok [ 0.066086] Setting up static identity map for 0x8240 - 0x8278 [ 0.067555] devtmpfs: initialized [ 0.079529] VFP support v0.3: implementor 41 architecture 1 part 20 variant b rev 5 [ 0.079971] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 19112604462750000 ns [ 0.080032] futex hash table entries: 256 (order: -1, 3072 bytes, linear) [ 0.089374] pinctrl core: initialized pinctrl subsystem [ 0.091692] NET: Registered protocol family 16 [ 0.095545] DMA: preallocated 256 KiB pool for atomic coherent allocations [ 0.102090] audit: initializing netlink subsys (disabled) [ 0.103799] thermal_sys: Registered thermal governor 'step_wise' [ 0.104272] hw-breakpoint: found 6 breakpoint and 1 watchpoint registers. [ 0.104322] hw-breakpoint: maximum watchpoint size is 4 bytes. [ 0.104631] Serial: AMBA PL011 UART driver [ 0.110828] audit: type=2000 audit(0.100:1): state=initialized audit_enabled=0 res=1 [ 0.127927] bcm2835-mbox 2000b880.mailbox: mailbox enabled [ 0.140861] raspberrypi-firmware soc:firmware: Attached to firmware from 2021-12-01T11:48:03, variant start [ 0.150873] raspberrypi-firmware soc:firmware: Firmware hash is be18b6271a0f99f896fc81249da5da6658422558 [ 0.204413] Kprobes globally optimized [ 0.215320] bcm2835-dma 20007000.dma: DMA legacy API manager, dmachans=0x1 [ 0.218694] SCSI subsystem initialized [ 0.219212] usbcore: registered new interface driver usbfs [ 0.219352] usbcore: registered new interface driver hub [ 0.219487] usbcore: registered new device driver usb [ 0.222073] clocksource: Switched to clocksource timer

2 2

Add BOOT LED support for Cubieboard2
by Javad Rahimi 06 Dec '21

06 Dec '21

Hello, I added LED boot support for my SUN7I based Cubieboard2. I want to send a patch for the changes. It is my first contribution and as It has been mentioned in the `Patches` pages, I'm asking you before for confirmation sending the patch. Best regards Javad

2 2

Bootargs received by a uImage but not by a FIT
by Richard Thanki 06 Dec '21

06 Dec '21

Hi all, I’m reaching out on this list as my problem spans U-Boot and Openwrt. In essence the very same kernel (5.4 and 5.10 - built using latest Openwrt), packaged in a FIT, is not receiving bootlogs from latest U-Boot and it’s also not being informed of the presence of the location and existence of an external initramfs. I suspect the issue is with my packaging, or Openwrt, but I wondered if there were any subtleties of how bootargs might be being passed differently between both types of image container? Why might this happen from a U-Boot perspective? Rich PS. The details of my issue are set out below in my post to the OpenWrt forum. I'm seeing a very odd difference between a single build, deployed on an ath79 device in two different ways. In short, when deployed as an OpenWrt built sysupgrade-squashfs the kernel picks up the command line arguments provided by the bootloader. However, when packaged as a FIT image the kernel does not pick up the bootargs. I think this is why my FIT packed kernel image cannot find the packaged external initramfs. My device is a very standard ath79 qca9531 board from ZBT - works great on mainline OpenWrt + mainline U-Boot with minimal DTS. I've tried adding my target to both ath79-generic and ath79-tiny targets and the results are the same. It's also the same with kernel 5.4 and 5.10. In each case I'm using mainline U-Boot (which with a few changes works well on QCA9531!). ## Steps I've taken The main patches I've made to OpenWrt are all configuration: enabling lzma for the external initramfs: ``` diff --git a/target/linux/ath79/config-5.4 b/target/linux/ath79/config-5.4 index 60f57692e2..8d521e4193 100644 --- a/target/linux/ath79/config-5.4 +++ b/target/linux/ath79/config-5.4 @@ -52,6 +52,7 @@ CONFIG_CPU_SUPPORTS_HIGHMEM=y CONFIG_CPU_SUPPORTS_MSA=y CONFIG_CRYPTO_RNG2=y CONFIG_CSRC_R4K=y +CONFIG_DECOMPRESS_LZMA=y CONFIG_DMA_NONCOHERENT=y CONFIG_DMA_NONCOHERENT_CACHE_SYNC=y CONFIG_DTC=y @@ -211,6 +212,7 @@ CONFIG_PHYLIB=y # CONFIG_PHY_ATH79_USB is not set CONFIG_PINCTRL=y CONFIG_RATIONAL=y +CONFIG_RD_LZMA=y CONFIG_REGMAP=y CONFIG_REGMAP_MMIO=y CONFIG_RESET_ATH79=y -- 2.24.3 (Apple Git-128) ``` enabling mips kernel to extend the dtb bootargs with those from the bootloader: ``` diff --git a/target/linux/ath79/config-5.4 b/target/linux/ath79/config-5.4 index 8d521e4193..4898190a02 100644 --- a/target/linux/ath79/config-5.4 +++ b/target/linux/ath79/config-5.4 @@ -158,9 +158,9 @@ CONFIG_MIPS_ASID_BITS=8 CONFIG_MIPS_ASID_SHIFT=0 CONFIG_MIPS_CLOCK_VSYSCALL=y # CONFIG_MIPS_CMDLINE_BUILTIN_EXTEND is not set -# CONFIG_MIPS_CMDLINE_DTB_EXTEND is not set +CONFIG_MIPS_CMDLINE_DTB_EXTEND=y # CONFIG_MIPS_CMDLINE_FROM_BOOTLOADER is not set -CONFIG_MIPS_CMDLINE_FROM_DTB=y +# CONFIG_MIPS_CMDLINE_FROM_DTB is not set # CONFIG_MIPS_ELF_APPENDED_DTB is not set CONFIG_MIPS_L1_CACHE_SHIFT=5 # CONFIG_MIPS_NO_APPENDED_DTB is not set -- 2.24.3 (Apple Git-128) ``` I've even tried backporting this patch http://lkml.iu.edu/hypermail/linux/kernel/2003.2/01736.html to 5.4 and made no difference: the squashfs image picked up the args no problem (even when launched from $loadaddr/0x8100000) and the FIT packaging which doesn't Here's my u-boot environment: ``` Environment size: 342/8187 bytes baudrate=115200 bootargs=foo=bar bootcmd=sf probe;mtdparts default;bootm 0x9f050000 bootcount=1 bootdelay=3 bootlimit=3 fdtcontroladdr=87f6caa0 ipaddr=192.168.0.234 loadaddr=0x81000000 serverip=192.168.0.6 stderr=uart@18020000 stdin=uart@18020000 stdout=uart@18020000 ``` Here's the bootlog from the squashfs image which picks up the bootargs (ignore the error at the end, image was running from memory): ``` getbox # bootm 0x81000000 ## Booting kernel from Legacy Image at 81000000 ... Image Name: MIPS OpenWrt Linux-5.4.158 Image Type: MIPS Linux Kernel Image (lzma compressed) Data Size: 1538183 Bytes = 1.5 MiB Load Address: 80060000 Entry Point: 80060000 Verifying Checksum ... OK Uncompressing Kernel Image [ 0.000000] Linux version 5.4.158 (vscode@d0b09531f99b) (gcc version 8.4.0 (OpenWrt GCC 8.4.0 r0+16397-266890bb12)) #0 Fri Dec 3 10:13:01 2021 [ 0.000000] printk: bootconsole [early0] enabled [ 0.000000] CPU0 revision is: 00019374 (MIPS 24Kc) [ 0.000000] MIPS: machine is Jangala Get Box (Tiny) [ 0.000000] SoC: Qualcomm Atheros QCA9533 ver 2 rev 0 [ 0.000000] Initrd not found or empty - disabling initrd [ 0.000000] Primary instruction cache 64kB, VIPT, 4-way, linesize 32 bytes. [ 0.000000] Primary data cache 32kB, 4-way, VIPT, cache aliases, linesize 32 bytes [ 0.000000] Zone ranges: [ 0.000000] Normal [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 32512 [ 0.000000] Kernel command line: console=ttyS0,115200n8, foo=bar rootfstype=squashfs,jffs2 [ 0.000000] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes, linear) [ 0.000000] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes, linear) [ 0.000000] Writing ErrCtl register=0003e1f4 [ 0.000000] Readback ErrCtl register=0003e1f4 [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] Memory: 123932K/131072K available (3857K kernel code, 136K rwdata, 576K rodata, 1184K init, 186K bss, 7140K reserved, 0K cma-reserved) [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] NR_IRQS: 51 [ 0.000000] random: get_random_bytes called from 0x804d8a3c with crng_init=0 [ 0.000000] CPU clock: 660.937 MHz [ 0.000000] clocksource: MIPS: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 5783483148 ns [ 0.000010] sched_clock: 32 bits at 330MHz, resolution 3ns, wraps every 6498295806ns [ 0.008969] Calibrating delay loop... 438.78 BogoMIPS (lpj=877568) [ 0.047945] pid_max: default: 32768 minimum: 301 [ 0.053352] Mount-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.061766] Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.075468] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [ 0.086627] futex hash table entries: 256 (order: -1, 3072 bytes, linear) [ 0.094441] pinctrl core: initialized pinctrl subsystem [ 0.101873] NET: Registered protocol family 16 [ 0.140688] workqueue: max_active 576 requested for napi_workq is out of range, clamping between 1 and 512 [ 0.156374] clocksource: Switched to clocksource MIPS [ 0.163650] NET: Registered protocol family 2 [ 0.168941] IP idents hash table entries: 2048 (order: 2, 16384 bytes, linear) [ 0.178064] tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 4096 bytes, linear) [ 0.187618] TCP established hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.196420] TCP bind hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.204387] TCP: Hash tables configured (established 1024 bind 1024) [ 0.211926] UDP hash table entries: 256 (order: 0, 4096 bytes, linear) [ 0.219388] UDP-Lite hash table entries: 256 (order: 0, 4096 bytes, linear) [ 0.227769] NET: Registered protocol family 1 [ 0.232853] PCI: CLS 0 bytes, default 32 [ 0.242929] workingset: timestamp_bits=30 max_order=15 bucket_order=0 [ 0.257879] squashfs: version 4.0 (2009/01/31) Phillip Lougher [ 0.264612] jffs2: version 2.2 (NAND) (SUMMARY) (LZMA) (RTIME) (CMODE_PRIORITY) (c) 2001-2006 Red Hat, Inc. [ 0.293902] pinctrl-single 1804002c.pinmux: 576 pins, size 72 [ 0.301879] Serial: 8250/16550 driver, 1 ports, IRQ sharing disabled [ 0.310236] printk: console [ttyS0] disabled [ 0.315191] 18020000.uart: ttyS0 at MMIO 0x18020000 (irq = 9, base_baud = 1562500) is a 16550A [ 0.325127] printk: console [ttyS0] enabled [ 0.325127] printk: console [ttyS0] enabled [ 0.334129] printk: bootconsole [early0] disabled [ 0.334129] printk: bootconsole [early0] disabled [ 0.363863] spi-nor spi0.0: w25q128 (16384 Kbytes) [ 0.368872] 6 fixed-partitions partitions found on MTD device spi0.0 [ 0.375449] Creating 6 MTD partitions on "spi0.0": [ 0.380494] 0x000000000000-0x000000058000 : "u-boot" [ 0.386916] 0x000000058000-0x00000005a000 : "u-boot-env-a" [ 0.393892] 0x00000005a000-0x00000005c000 : "u-boot-env-b" [ 0.401089] 0x00000005c000-0x000000f70000 : "firmware" [ 0.561029] 0x000000f70000-0x000000ff0000 : "data" [ 0.567392] 0x000000ff0000-0x000001000000 : "art" [ 0.574781] libphy: Fixed MDIO Bus: probed [ 0.901494] ag71xx 19000000.eth: Could not connect to PHY device. Deferring probe. [ 1.152370] random: fast init done [ 1.540856] libphy: ag71xx_mdio: probed [ 1.546569] libphy: ar8xxx-mdio: probed [ 1.560510] switch0: Atheros AR8229 rev. 1 switch registered on mdio.0 [ 1.608508] ag71xx 1a000000.eth: connected to PHY at fixed-0:00 [uid=00000000, driver=Generic PHY] [ 1.618740] eth0: Atheros AG71xx at 0xba000000, irq 5, mode: gmii [ 1.625644] ath79-wdt 18060008.wdt: unable to register misc device, err=-16 [ 1.632917] ath79-wdt: probe of 18060008.wdt failed with error -16 [ 1.642629] NET: Registered protocol family 10 [ 1.654503] Segment Routing with IPv6 [ 1.658589] NET: Registered protocol family 17 [ 1.663658] 8021q: 802.1Q VLAN Support v1.8 [ 1.669437] PCI host bridge /ahb/pcie-controller@180c0000 ranges: [ 1.675943] MEM 0x0000000010000000..0x0000000013ffffff [ 1.681362] IO 0x0000000000000000..0x0000000000000000 [ 1.786512] ar724x-pci 180c0000.pcie-controller: PCIe link is down [ 1.793201] PCI host bridge to bus 0000:00 [ 1.797445] pci_bus 0000:00: root bus resource [mem 0x10000000-0x13ffffff] [ 1.804597] pci_bus 0000:00: root bus resource [io 0x0000] [ 1.810426] pci_bus 0000:00: root bus resource [??? 0x00000000 flags 0x0] [ 1.817387] pci_bus 0000:00: No busn resource found for root bus, will use [bus 00-ff] [ 1.826685] pci_bus 0000:00: busn_res: [bus 00-ff] end is updated to 00 [ 2.150544] ag71xx 19000000.eth: connected to PHY at mdio.0:1f:04 [uid=004dd042, driver=Generic PHY] [ 2.161280] eth1: Atheros AG71xx at 0xb9000000, irq 4, mode: mii [ 2.170278] /dev/root: Can't open blockdev [ 2.174591] VFS: Cannot open root device "(null)" or unknown-block(0,0): error -6 [ 2.182408] Please append a correct "root=" boot option; here are the available partitions: [ 2.191029] 1f00 352 mtdblock0 [ 2.191033] (driver?) [ 2.197810] 1f01 8 mtdblock1 [ 2.197813] (driver?) [ 2.204667] 1f02 8 mtdblock2 [ 2.204670] (driver?) [ 2.211365] 1f03 15440 mtdblock3 [ 2.211367] (driver?) [ 2.218187] 1f04 512 mtdblock4 [ 2.218190] (driver?) [ 2.225007] 1f05 64 mtdblock5 [ 2.225010] (driver?) [ 2.231711] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 2.240341] Rebooting in 1 seconds.. ``` Here's the full log from the FIT image, note that the bootargs variable `foo=bar` isn't reflected in the kernel as it is above: ``` getbox # bootm $loadaddr ## Loading kernel from FIT Image at 81000000 ... Using 'base' configuration Verifying Hash Integrity ... sha384,rsa4096:fit+ OK Trying 'kernel' kernel subimage Description: Linux Kernel Type: Kernel Image Compression: lzma compressed Data Start: 0x810000d0 Data Size: 1538370 Bytes = 1.5 MiB Architecture: MIPS OS: Linux Load Address: 0x80060000 Entry Point: 0x80060000 Hash algo: sha384 Hash value: 19e9[...]6ee34 Verifying Hash Integrity ... sha384+ OK ## Loading ramdisk from FIT Image at 81000000 ... Using 'base' configuration Verifying Hash Integrity ... sha384,rsa4096:fit+ OK Trying 'ramdisk' ramdisk subimage Description: RAMdisk Type: RAMDisk Image Compression: uncompressed Data Start: 0x81177b14 Data Size: 6315702 Bytes = 6 MiB Architecture: MIPS OS: Linux Load Address: unavailable Entry Point: unavailable Hash algo: sha384 Hash value: 9621df[...]67af4dd Verifying Hash Integrity ... sha384+ OK ## Loading fdt from FIT Image at 81000000 ... Using 'base' configuration Verifying Hash Integrity ... sha384,rsa4096:fit+ OK Trying 'fdt' fdt subimage Description: Flattened Device Tree blob Type: Flat Device Tree Compression: lzma compressed Data Start: 0x8177dabc Data Size: 2166 Bytes = 2.1 KiB Architecture: MIPS Load Address: 0x80f00000 Hash algo: sha384 Hash value: c35[...]9272af Verifying Hash Integrity ... sha384+ OK Loading fdt from 0x8177dabc to 0x80f00000 Uncompressing Flat Device Tree Booting using the fdt blob at 0x80f00000 Uncompressing Kernel Image Loading Ramdisk to 87964000, end 87f69eb6 ... OK [ 0.000000] Linux version 5.4.158 (vscode@d0b09531f99b) (gcc version 8.4.0 (OpenWrt GCC 8.4.0 r0+16397-266890bb12)) #0 Fri Dec 3 10:13:01 2021 [ 0.000000] printk: bootconsole [early0] enabled [ 0.000000] CPU0 revision is: 00019374 (MIPS 24Kc) [ 0.000000] MIPS: machine is Jangala Get Box (Tiny) [ 0.000000] SoC: Qualcomm Atheros QCA9533 ver 2 rev 0 [ 0.000000] Initrd not found or empty - disabling initrd [ 0.000000] Primary instruction cache 64kB, VIPT, 4-way, linesize 32 bytes. [ 0.000000] Primary data cache 32kB, 4-way, VIPT, cache aliases, linesize 32 bytes [ 0.000000] Zone ranges: [ 0.000000] Normal [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x0000000007ffffff] [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 32512 [ 0.000000] Kernel command line: console=ttyS0,115200n8 rootfstype=squashfs,jffs2 [ 0.000000] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes, linear) [ 0.000000] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes, linear) [ 0.000000] Writing ErrCtl register=0003a1f4 [ 0.000000] Readback ErrCtl register=0003a1f4 [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] Memory: 123932K/131072K available (3857K kernel code, 136K rwdata, 576K rodata, 1184K init, 186K bss, 7140K reserved, 0K cma-reserved) [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] NR_IRQS: 51 [ 0.000000] random: get_random_bytes called from 0x804d8a3c with crng_init=0 [ 0.000000] CPU clock: 656.250 MHz [ 0.000000] clocksource: MIPS: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 5824793742 ns [ 0.000010] sched_clock: 32 bits at 328MHz, resolution 3ns, wraps every 6544711678ns [ 0.009059] Calibrating delay loop... 436.22 BogoMIPS (lpj=872448) [ 0.048172] pid_max: default: 32768 minimum: 301 [ 0.053603] Mount-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.062053] Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.075864] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [ 0.087157] futex hash table entries: 256 (order: -1, 3072 bytes, linear) [ 0.094976] pinctrl core: initialized pinctrl subsystem [ 0.102485] NET: Registered protocol family 16 [ 0.141550] workqueue: max_active 576 requested for napi_workq is out of range, clamping between 1 and 512 [ 0.157252] clocksource: Switched to clocksource MIPS [ 0.164619] NET: Registered protocol family 2 [ 0.169903] IP idents hash table entries: 2048 (order: 2, 16384 bytes, linear) [ 0.179116] tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 4096 bytes, linear) [ 0.188716] TCP established hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.197604] TCP bind hash table entries: 1024 (order: 0, 4096 bytes, linear) [ 0.205622] TCP: Hash tables configured (established 1024 bind 1024) [ 0.213192] UDP hash table entries: 256 (order: 0, 4096 bytes, linear) [ 0.220759] UDP-Lite hash table entries: 256 (order: 0, 4096 bytes, linear) [ 0.229130] NET: Registered protocol family 1 [ 0.234290] PCI: CLS 0 bytes, default 32 [ 0.244384] workingset: timestamp_bits=30 max_order=15 bucket_order=0 [ 0.259475] squashfs: version 4.0 (2009/01/31) Phillip Lougher [ 0.266209] jffs2: version 2.2 (NAND) (SUMMARY) (LZMA) (RTIME) (CMODE_PRIORITY) (c) 2001-2006 Red Hat, Inc. [ 0.295772] pinctrl-single 1804002c.pinmux: 576 pins, size 72 [ 0.303785] Serial: 8250/16550 driver, 1 ports, IRQ sharing disabled [ 0.312240] printk: console [ttyS0] disabled [ 0.317232] 18020000.uart: ttyS0 at MMIO 0x18020000 (irq = 9, base_baud = 1562500) is a 16550A [ 0.327212] printk: console [ttyS0] enabled [ 0.327212] printk: console [ttyS0] enabled [ 0.336314] printk: bootconsole [early0] disabled [ 0.336314] printk: bootconsole [early0] disabled [ 0.365451] spi-nor spi0.0: w25q128 (16384 Kbytes) [ 0.370557] 6 fixed-partitions partitions found on MTD device spi0.0 [ 0.377121] Creating 6 MTD partitions on "spi0.0": [ 0.382191] 0x000000000000-0x000000058000 : "u-boot" [ 0.388723] 0x000000058000-0x00000005a000 : "u-boot-env-a" [ 0.395725] 0x00000005a000-0x00000005c000 : "u-boot-env-b" [ 0.402860] 0x00000005c000-0x000000f70000 : "firmware" [ 0.564110] 0x000000f70000-0x000000ff0000 : "data" [ 0.570490] 0x000000ff0000-0x000001000000 : "art" [ 0.578088] libphy: Fixed MDIO Bus: probed [ 0.902372] ag71xx 19000000.eth: Could not connect to PHY device. Deferring probe. [ 1.149248] random: fast init done [ 1.541733] libphy: ag71xx_mdio: probed [ 1.547374] libphy: ar8xxx-mdio: probed [ 1.561500] switch0: Atheros AR8229 rev. 1 switch registered on mdio.0 [ 1.609424] ag71xx 1a000000.eth: connected to PHY at fixed-0:00 [uid=00000000, driver=Generic PHY] [ 1.619754] eth0: Atheros AG71xx at 0xba000000, irq 5, mode: gmii [ 1.626650] ath79-wdt 18060008.wdt: unable to register misc device, err=-16 [ 1.634103] ath79-wdt: probe of 18060008.wdt failed with error -16 [ 1.643735] NET: Registered protocol family 10 [ 1.655790] Segment Routing with IPv6 [ 1.659809] NET: Registered protocol family 17 [ 1.664920] 8021q: 802.1Q VLAN Support v1.8 [ 1.670765] PCI host bridge /ahb/pcie-controller@180c0000 ranges: [ 1.677224] MEM 0x0000000010000000..0x0000000013ffffff [ 1.682638] IO 0x0000000000000000..0x0000000000000000 [ 1.788077] ar724x-pci 180c0000.pcie-controller: PCIe link is down [ 1.794718] PCI host bridge to bus 0000:00 [ 1.799069] pci_bus 0000:00: root bus resource [mem 0x10000000-0x13ffffff] [ 1.806319] pci_bus 0000:00: root bus resource [io 0x0000] [ 1.812075] pci_bus 0000:00: root bus resource [??? 0x00000000 flags 0x0] [ 1.819179] pci_bus 0000:00: No busn resource found for root bus, will use [bus 00-ff] [ 1.828511] pci_bus 0000:00: busn_res: [bus 00-ff] end is updated to 00 [ 2.155422] ag71xx 19000000.eth: connected to PHY at mdio.0:1f:04 [uid=004dd042, driver=Generic PHY] [ 2.166336] eth1: Atheros AG71xx at 0xb9000000, irq 4, mode: mii [ 2.175257] /dev/root: Can't open blockdev [ 2.179688] VFS: Cannot open root device "(null)" or unknown-block(0,0): error -6 [ 2.187516] Please append a correct "root=" boot option; here are the available partitions: [ 2.196198] 1f00 352 mtdblock0 [ 2.196202] (driver?) [ 2.203117] 1f01 8 mtdblock1 [ 2.203119] (driver?) [ 2.209879] 1f02 8 mtdblock2 [ 2.209882] (driver?) [ 2.216733] 1f03 15440 mtdblock3 [ 2.216736] (driver?) [ 2.223610] 1f04 512 mtdblock4 [ 2.223613] (driver?) [ 2.230370] 1f05 64 mtdblock5 [ 2.230372] (driver?) [ 2.237266] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 2.245850] Rebooting in 1 seconds.. ``` my its file is: ``` /dts-v1/; / { description = "U-Boot fitImage for Jangala Get Box"; #address-cells = <2>; images { kernel { description = "Linux Kernel"; data = /incbin/("getbox-v1-kernel.bin"); type = "kernel"; arch = "mips"; os = "linux"; compression = "lzma"; load = <0x80060000>; entry = <0x80060000>; hash-1 { algo = "sha384"; }; }; ramdisk { description = "RAMdisk"; data = /incbin/("getbox-v1-initramfs.cpio.lzma"); type = "ramdisk"; arch = "mips"; os = "linux"; compression = "none"; hash-1 { algo = "sha384"; }; }; fdt { description = "Flattened Device Tree blob"; data = /incbin/("getbox-v1-dtb.bin.lzma"); type = "flat_dt"; arch = "mips"; compression = "lzma"; load = <0x80f00000>; hash-1 { algo = "sha384"; }; }; }; configurations { default = "base"; base { description = "Boot Linux kernel with initramfs, fdt"; kernel = "kernel"; ramdisk = "ramdisk"; fdt = "fdt"; signature-1 { algo = "sha384,rsa4096"; key-name-hint = "fit"; sign-images = "kernel", "fdt", "ramdisk"; }; }; }; }; ``` At first I thought this was related to the measures OpenWrt takes to cope with malformed bootloaders but the DTB_EXTEND kernel option works when packaged as squashfs but not when as a ft image. I'm really stuck and would appreciate some hints!

1 0

Re: [PATCH v6 24/25] fdt: Drop remaining preprocessor macros in fdtdec_setup()
by Ilias Apalodimas 06 Dec '21

06 Dec '21

Hi Simon, On Thu, 2 Dec 2021 at 18:00, Simon Glass <sjg(a)chromium.org> wrote: > > We only have two choices for obtaining the devicetree. Simplify the code > to make that clear. > > Signed-off-by: Simon Glass <sjg(a)chromium.org> > --- > > (no changes since v1) > > lib/fdtdec.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/lib/fdtdec.c b/lib/fdtdec.c > index 5b31064cee2..a7f62123a94 100644 > --- a/lib/fdtdec.c > +++ b/lib/fdtdec.c > @@ -1624,15 +1624,17 @@ static void setup_multi_dtb_fit(void) > int fdtdec_setup(void) > { > int ret; > -#ifdef CONFIG_OF_EMBED > - /* Get a pointer to the FDT */ > - gd->fdt_blob = dtb_dt_embedded(); > -#elif defined(CONFIG_OF_BOARD) || defined(CONFIG_OF_SEPARATE) > - /* Allow the board to override the fdt address. */ > - gd->fdt_blob = board_fdt_blob_setup(&ret); > - if (ret) > - return ret; > -#endif > + > + /* The devicetree is typically appended to U-Boot */ > + if (IS_ENABLED(CONFIG_OF_SEPARATE) || IS_ENABLED(CONFIG_OF_BOARD)) { > + /* Allow the board to override the fdt address. */ > + gd->fdt_blob = board_fdt_blob_setup(&ret); > + if (ret) > + return ret; > + } else { /* embed dtb in ELF file for testing / development */ > + gd->fdt_blob = dtb_dt_embedded(); > + } > + > if (!IS_ENABLED(CONFIG_SPL_BUILD)) { > /* Allow the early environment to override the fdt address */ > gd->fdt_blob = map_sysmem(env_get_ulong("fdtcontroladdr", 16, > -- > 2.34.0.rc2.393.gf8c9666880-goog > In case you need to resend this can you change the commit message a bit? This doesn't really simplify the logic, just replaces ifdefs with IS_ENABLED Other than that Reviewed-by: Ilias Apalodimas <ilias.apalodimas(a)linaro.org>

1 0

Issue building flash.bin for imx8mq_evk
by Angus Ainslie 06 Dec '21

06 Dec '21

Hi, I've tested v2021.10 and "make flash.bin" still works there for imx8mq_evk_defconfig. With the latest master that doesn't build any more ./"arch/arm/mach-imx/mkimage_fit_atf.sh" \ arch/arm/dts/imx8mq-evk.dtb > u-boot.its /bin/sh: 1: ./arch/arm/mach-imx/mkimage_fit_atf.sh: not found make: *** [Makefile:1350: u-boot.its] Error 127 This was the commit that broke it. 68de913c12c4d091f51009ad6f179fab825d3d82 Are there binman updates for the imx8mq_evk ? Thanks Angus

2 2