December 2021 - U-Boot

[RFC PATCH 00/10] FWU: Add support for FWU Multi Bank Update feature
by Sughosh Ganu 09 Dec '21

09 Dec '21

The FWU multi bank update feature is used for supporting multiple sets(also called banks) of firmware images, allowing the platform to boot from a different bank, in case it fails to boot from the active bank. This functionality is supported by keeping the relevant information in a structure called metadata, which provides information on the images. Among other parameters, the metadata structure contains information on the currect active bank that is being used to boot images. Functionality is being added to work with the UEFI capsule driver in u-boot. The metadata is read to gather information on the update bank, which is the bank to which the firmware images would be flashed to. On a successful completion of the update of all components, the active bank field in the metadata is updated, to reflect the bank from which the platform will boot on the subsequent boots. This also requires changes in the previous stage of bootloader, which parses the metadata and selects the bank to boot the images from. Currently, the feature is being enabled on the STM32MP157C-DK2 board which boots a FIP image from a uSD card partitioned with the GPT partioning scheme. Support is being added in tf-a(BL2 stage) for the STM32MP157C-DK2 board to boot the active bank images. These changes are under review currently[3]. The following config's need to be selected for enabling the feature CONFIG_FWU_MULTI_BANK_UPDATE CONFIG_EFI_CAPSULE_ON_DISK CONFIG_EFI_CAPSULE_FIRMWARE_MANAGEMENT CONFIG_EFI_CAPSULE_FIRMWARE CONFIG_EFI_CAPSULE_FIRMWARE_RAW CONFIG_EFI_CAPSULE_FMP_HEADER -- if capsule is being generated using EDKII GenerateCapsule script CONFIG_CMD_FWU_METADATA Todo's ------ 1) Add a test(selftest) for the metadata access. 2) Add a tool for generation of the metadata. Not sure if this needs to be part of the u-boot repository though. 3) Add a tool for generation of the firmware accept/reject dummy capsule. Need to check if this can be added to the mkeficapsule tool in u-boot. [1] - https://developer.arm.com/documentation/den0118/a [2] - https://staging-git.codelinaro.org/linaro/firmware-dual-banked-updates/test [3] - https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/12566 Sughosh Ganu (10): GPT: Add function to get gpt header and partition entries stm32mp: dfu: Move the ram partitions to the end of the dfu_alt_info variable FWU: Add metadata structure and functions for accessing metadata FWU: Add metadata access functions for GPT partitioned block devices FWU: stm32mp1: Add helper functions for accessing metadata FWU: STM32MP1: Add support to read boot index from backup register EFI: FMP: Add provision to update image's ImageTypeId in image descriptor FWU: Add boot time checks as highlighted by the FWU specification FWU: Add support for FWU Multi Bank Update feature FWU: cmd: Add a command to read metadata arch/arm/mach-stm32mp/include/mach/stm32.h | 1 + board/st/common/stm32mp_dfu.c | 11 +- board/st/stm32mp1/stm32mp1.c | 70 ++ cmd/Kconfig | 6 + cmd/Makefile | 1 + cmd/fwu_metadata.c | 65 ++ common/board_r.c | 6 + disk/part_efi.c | 10 + include/fwu_metadata.h | 140 ++++ include/part.h | 14 + lib/Kconfig | 32 + lib/Makefile | 1 + lib/efi_loader/efi_capsule.c | 190 +++++- lib/efi_loader/efi_firmware.c | 76 ++- lib/fwu_updates/Makefile | 11 + lib/fwu_updates/fwu.c | 170 +++++ lib/fwu_updates/fwu_metadata.c | 275 ++++++++ lib/fwu_updates/fwu_metadata_gpt_blk.c | 716 +++++++++++++++++++++ 18 files changed, 1784 insertions(+), 11 deletions(-) create mode 100644 cmd/fwu_metadata.c create mode 100644 include/fwu_metadata.h create mode 100644 lib/fwu_updates/Makefile create mode 100644 lib/fwu_updates/fwu.c create mode 100644 lib/fwu_updates/fwu_metadata.c create mode 100644 lib/fwu_updates/fwu_metadata_gpt_blk.c -- 2.17.1

6 28

[PATCH v1 0/1] support rsa3072
by Jamin Lin 09 Dec '21

09 Dec '21

support rsa3072 Jamin Lin (1): support rsa3072 common/image-sig.c | 7 +++++++ include/u-boot/rsa.h | 1 + 2 files changed, 8 insertions(+) -- 2.17.1

2 3

[PATCH] dm: fix an 'undefined' error in some macros
by AKASHI Takahiro 09 Dec '21

09 Dec '21

Due to a non-existing parameter name in macro's, use of those macro's will cause a compiler error of "undefined reference". Unfortunately, dm test doesn't fail because a wrong name ("&dev", hence it is accidentally a valid name in the context of a caller site) is passed on. Signed-off-by: AKASHI Takahiro <takahiro.akashi(a)linaro.org> Fixes: f262d4ca4b2b ("dm: core: Add a way to read platdata for all child devices") Fixes: 903e83ee8464 ("dm: core: Add a way to iterate through children, probing each") --- include/dm/device.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/dm/device.h b/include/dm/device.h index 3028d002ab0d..f7900417066d 100644 --- a/include/dm/device.h +++ b/include/dm/device.h @@ -959,8 +959,8 @@ static inline bool device_is_on_pci_bus(const struct udevice *dev) * @parent: parent device to scan */ #define device_foreach_child_of_to_plat(pos, parent) \ - for (int _ret = device_first_child_ofdata_err(parent, &dev); !_ret; \ - _ret = device_next_child_ofdata_err(&dev)) + for (int _ret = device_first_child_ofdata_err(parent, &pos); !_ret; \ + _ret = device_next_child_ofdata_err(&pos)) /** * device_foreach_child_probe() - iterate through children, probing them @@ -976,8 +976,8 @@ static inline bool device_is_on_pci_bus(const struct udevice *dev) * @parent: parent device to scan */ #define device_foreach_child_probe(pos, parent) \ - for (int _ret = device_first_child_err(parent, &dev); !_ret; \ - _ret = device_next_child_err(&dev)) + for (int _ret = device_first_child_err(parent, &pos); !_ret; \ + _ret = device_next_child_err(&pos)) /** * dm_scan_fdt_dev() - Bind child device in the device tree -- 2.33.0

1 0

[PATCH 0/5] Resync Devices trees with Linux 5.16-rc3 and fix breakages
by Adam Ford 09 Dec '21

09 Dec '21

The device trees for the RZ/G2[MNH] boards at kernel.org have undergone some changes over time. Some of these changes are MMC aliases and others are AVB refernece clocks. This series attempts to re-sync the device trees with Kernel.org then address some minor driver, defconfig, and config.h breakages caused by the resync. This series also consolidates the rz/g2[mnh] -u-boot.dtsi files into one common file to eliminate some duplicate code and make future maintenance easier. Adam Ford (5): net: ravb: Support multiple clocks arm: dts: beacon-rzg2: Resync device trees with Linux 5.16-rc3 arm: dts: Create common rz-g2-beacon-u-boot file ARM: rmobile: Fix rzg2_beacon_defconfig to address new aliases configs: beacon-rzg2m: Config to address new aliases arch/arm/dts/beacon-renesom-baseboard.dtsi | 16 +++- arch/arm/dts/beacon-renesom-som.dtsi | 45 +++-------- .../dts/r8a774a1-beacon-rzg2m-kit-u-boot.dtsi | 32 +------- arch/arm/dts/r8a774a1-beacon-rzg2m-kit.dts | 3 + .../dts/r8a774b1-beacon-rzg2n-kit-u-boot.dtsi | 32 +------- arch/arm/dts/r8a774b1-beacon-rzg2n-kit.dts | 3 + .../dts/r8a774e1-beacon-rzg2h-kit-u-boot.dtsi | 42 +---------- arch/arm/dts/r8a774e1-beacon-rzg2h-kit.dts | 3 + arch/arm/dts/rz-g2-beacon-u-boot.dtsi | 75 +++++++++++++++++++ board/beacon/beacon-rzg2m/MAINTAINERS | 10 +++ configs/rzg2_beacon_defconfig | 1 - drivers/net/ravb.c | 10 +-- include/configs/beacon-rzg2m.h | 2 +- 13 files changed, 129 insertions(+), 145 deletions(-) create mode 100644 arch/arm/dts/rz-g2-beacon-u-boot.dtsi -- 2.32.0

2 6

[PATCH] sunxi: dts: Fix typoed eMMC check
by Andre Przywara 08 Dec '21

08 Dec '21

Commit 03510bf62149 ("sunxi: only include alias for eMMC when mmc2 used") protected the eMMC alias in U-Boot's DT stub the with the associated Kconfig symbol, but was actually using the wrong name. Fix the name of the symbol to match what's defined in Kconfig and what the defconfig files actually use. Fixes: 03510bf62149 ("sunxi: only include alias for eMMC when mmc2 used") Signed-off-by: Andre Przywara <andre.przywara(a)arm.com> Reported-by: 5kft(a)5kft.org --- arch/arm/dts/sunxi-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/sunxi-u-boot.dtsi index b7244c1112a..f2d7361b84f 100644 --- a/arch/arm/dts/sunxi-u-boot.dtsi +++ b/arch/arm/dts/sunxi-u-boot.dtsi @@ -13,7 +13,7 @@ / { aliases { mmc0 = &mmc0; -#if CONFIG_MMC_SUNXI_EXTRA_SLOT == 2 +#if CONFIG_MMC_SUNXI_SLOT_EXTRA == 2 mmc1 = &mmc2; #endif }; -- 2.17.6

2 1

[PATCH v2] Cubieboard2:SUN7I:Add LED BOOT support
by Javad Rahimi 08 Dec '21

08 Dec '21

This feature makes it possible to assign one of LED1(PH20) and LED2(PH21) to BOOT process LED. User should activates the "Enable status LED API" in "Device Drivers -> LED Support" Signed-off-by: Javad Rahimi <javad321javad(a)gmail.com> --- This is my first contributation in open source world. I'm sorry if I have mistakes in my commits and versioning. I do my best to learn fast. Changes in v2: - Missed braces added - Unnecessary debug removed - Some typo fixed board/sunxi/board.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 4f5747c34a..5e2f6ae902 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -1002,3 +1002,52 @@ int board_fit_config_name_match(const char *name) return ret; } #endif + +#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT) && defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) + +#define CUBIE2_LED_BOOT_GPIO "PH20" +static int gpio_boot_led; + +void __led_init(led_id_t mask, int state) +{ + int ret; + + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, &gpio_boot_led); + + if (ret) + return; + + ret = gpio_request(gpio_boot_led, "boot_led"); + if (ret == -1) { + debug("[gpio_request] Error:%d\n", ret); + return; + } + + ret = gpio_direction_output(gpio_boot_led, 1); + if (ret == -1) { + debug("[gpio_direction_output] Error:%d\n", ret); + return; + } + __led_set(mask, state); +} + +void __led_set(led_id_t mask, int state) +{ + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + gpio_set_value(gpio_boot_led, state); +} + +void __led_toggle(led_id_t mask) +{ + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + gpio_set_value(gpio_boot_led, !gpio_get_value(gpio_boot_led)); +} + +#endif -- 2.25.1

3 3

[PATCH v3] Cubieboard2:SUN7I:Add LED BOOT support
by Javad Rahimi 08 Dec '21

08 Dec '21

This feature makes it possible to assign one of LED1(PH20) and LED2(PH21) to BOOT process LED. User should activates the "Enable status LED API" in "Device Drivers -> LED Support" Signed-off-by: Javad Rahimi <javad321javad(a)gmail.com> --- This is my first contributation in open source world. I'm sorry if I have mistakes in my commits and versioning. I do my best to learn fast. Changes in v3: - Maintainers email added Changes in v2: - Missed braces added - Unnecessary debug removed - Some typo fixed board/sunxi/board.c | 49 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 4f5747c34a..5e2f6ae902 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -1002,3 +1002,52 @@ int board_fit_config_name_match(const char *name) return ret; } #endif + +#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT) && defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) + +#define CUBIE2_LED_BOOT_GPIO "PH20" +static int gpio_boot_led; + +void __led_init(led_id_t mask, int state) +{ + int ret; + + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, &gpio_boot_led); + + if (ret) + return; + + ret = gpio_request(gpio_boot_led, "boot_led"); + if (ret == -1) { + debug("[gpio_request] Error:%d\n", ret); + return; + } + + ret = gpio_direction_output(gpio_boot_led, 1); + if (ret == -1) { + debug("[gpio_direction_output] Error:%d\n", ret); + return; + } + __led_set(mask, state); +} + +void __led_set(led_id_t mask, int state) +{ + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + gpio_set_value(gpio_boot_led, state); +} + +void __led_toggle(led_id_t mask) +{ + if (mask != CONFIG_LED_STATUS_BOOT) + return; + + gpio_set_value(gpio_boot_led, !gpio_get_value(gpio_boot_led)); +} + +#endif -- 2.25.1

1 0

debugging crash for arm64
by Frank Wunderlich 08 Dec '21

08 Dec '21

Hi, i got a crash on uboot while running reset-command in rk3568 board (bananapi-r2 pro, currently not in upstream). maybe a callback is missing (e.g. reset_cpu())?? i tried to analyse it using the documentation: https://u-boot.readthedocs.io/en/latest/develop/crash_dumps.html Resetting CPU ... resetting ... "Synchronous Abort" handler, esr 0x96000045 elr: 0000000000a25f78 lr : 0000000000a25f48 (reloc) elr: 000000007ff94f78 lr : 000000007ff94f48 x0 : 00000000fdd20000 x1 : 0000000014000001 x2 : 000000000000fdb9 x3 : 000000007df5cd48 x4 : 000000007df4fe88 x5 : 000000007df5c710 x6 : 000000000000001a x7 : 000000007df459f0 x8 : 0000000000000001 x9 : 000000000000000c x10: 00000000000186a0 x11: 00000000ffffffd0 x12: 0000000000000010 x13: 000000000001869f x14: 000000007ff70158 x15: 0000000000000021 x16: 000000007ff94f2c x17: 0000000000000000 x18: 000000007df4fdd0 x19: 0000000000000000 x20: 0000000000000001 x21: 0000000000000000 x22: 000000007df5ddd0 x23: 0000000000000001 x24: 000000007ffe8800 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 000000007df5e980 x29: 000000007df45990 Code: d65f03c0 d5033fbf b9400661 529d9502 (b8206822) $ echo 'Code: d65f03c0 d5033fbf b9400661 529d9502 (b8206822)' | CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 scripts/decodecode Code: d65f03c0 d5033fbf b9400661 529d9502 (b8206822) All code ======== 0: d65f03c0 ret 4: d5033fbf dmb sy 8: b9400661 ldr w1, [x19, #4] c: 529d9502 mov w2, #0xeca8 // #60584 10:* b8206822 str w2, [x1, x0] <-- trapping instruction Code starting with the faulting instruction =========================================== 0: b8206822 str w2, [x1, x0] now i'm here "Now lets use the locations provided by the elr and lr registers after subtracting the relocation offset to find out where in the code the crash occurred and from where it was invoked." does that means that i have to subtract values of first 2 lines of trace? 0x7ff94f78 - 0x00a25f78 = 0x7F56F000 "File u-boot.map contains the memory layout of the U-Boot binary. Here we find these lines:" this is not clear enough for me too...i did not found 0x7F56F000 in the file. i expect to do anything with the address in the disassembled code (0xb8206822), but i do not know what :p i've uploaded the matching u-boot.map and u-boot.dbg (output of objdump) here: https://drive.google.com/drive/folders/10rJbjWNdkYTA_pjnfXEADIZO-7yo4ZhC?us… regards Frank

2 2

[PATCH v1 0/1] support rsa3072
by Jamin Lin 08 Dec '21

08 Dec '21

This patch set supports rsa3072. Jamin Lin (1): support rsa3072 include/u-boot/rsa.h | 1 + lib/rsa/rsa-verify.c | 6 ++++++ tools/image-sig-host.c | 7 +++++++ 3 files changed, 14 insertions(+) -- 2.17.1

1 1

[PATCH] Braces added to the if
by Javad Rahimi 08 Dec '21

08 Dec '21

Signed-off-by: Javad Rahimi <javad321javad(a)gmail.com> --- board/sunxi/board.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index ff80283702..62d32b6329 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -1017,9 +1017,10 @@ void __led_init (led_id_t mask, int state) ret = gpio_lookup_name(CUBIE2_LED_BOOT_GPIO, NULL, NULL, &gpio_boot_led); - if (ret) + if (ret) { debug("[gpio_lookup_name]LED Err: %d", ret); return; + } gpio_request(gpio_boot_led, "boot_led"); gpio_direction_output(gpio_boot_led, 1); -- 2.25.1

2 1