September 2020 - U-Boot

[PATCH] include: phy: fix NULL pointer check in phy_write()
by Thirupathaiah Annapureddy 17 Sep '20

17 Sep '20

phy_write() uses bus->write() instead of bus->read(). This means NULL pointer pre-check needs to happen on bus->write instead of bus->read. Signed-off-by: Thirupathaiah Annapureddy <thiruan(a)linux.microsoft.com> --- include/phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/phy.h b/include/phy.h index 1dbbf65111..cbdb10d6fc 100644 --- a/include/phy.h +++ b/include/phy.h @@ -205,7 +205,7 @@ static inline int phy_write(struct phy_device *phydev, int devad, int regnum, { struct mii_dev *bus = phydev->bus; - if (!bus || !bus->read) { + if (!bus || !bus->write) { debug("%s: No bus configured\n", __func__); return -1; } -- 2.25.2

4 4

[PATCH v2 0/7] riscv: Correctly handle IPIs already pending upon boot
by Sean Anderson 17 Sep '20

17 Sep '20

On the K210, the prior stage bootloader does not clear IPIs. This presents a problem, because U-Boot up until this point assumes (with one exception) that IPIs are cleared when it starts. This series attempts to fix this in a robust manner, and fix several concurrency bugs I noticed while fixing these other areas. Heinrich previously submitted a patch addressing part of this problem in [1]. [1] https://patchwork.ozlabs.org/project/uboot/patch/20200811035648.3284-1-xypr… Changes in v2: - Use a valid bit instead of addr to validate IPIs - Make riscv_ipi_init_secondary_hart static - Remove fences after amoswaps - Set gp early with XIP - Clarify comments regarding tp Sean Anderson (7): Revert "riscv: Clear pending interrupts before enabling IPIs" riscv: Match memory barriers between send_ipi_many and handle_ipi riscv: Use a valid bit to ignore already-pending IPIs riscv: Clear pending IPIs on initialization riscv: Consolidate fences into AMOs for available_harts_lock riscv: Ensure gp is NULL or points to valid data riscv: Add some comments to start.S arch/riscv/cpu/cpu.c | 18 ++++++++++++ arch/riscv/cpu/start.S | 56 +++++++++++++++++++++++++++--------- arch/riscv/include/asm/smp.h | 7 +++++ arch/riscv/lib/interrupts.c | 3 +- arch/riscv/lib/smp.c | 16 ++++++++++- 5 files changed, 85 insertions(+), 15 deletions(-) -- 2.28.0

4 22

[PATCH v2 0/2] Enable OPTEE and "optee_rpmb" command
by Gaurav Jain 17 Sep '20

17 Sep '20

Enable support to compile OPTEE driver, access AVB TA and RPMB API's access via RPC from OPTEE for lx2160. Enable "optee_rpmb" command to write/read named persistent values created on MMC RPMB. v1 can be referred here https://patchwork.ozlabs.org/project/uboot/patch/20200916100058.9092-1-gaur… changes w.r.t v1: 1/2:configs: lx2160a: Enable OPTEE support - new commit 2/2:cmd: optee_rpmb command for read/write of rpmb from optee - Modified cmd_tbl_t to struct cmd_tbl as per include/command.h Ruchika Gupta (2): configs: lx2160a: Enable OPTEE support cmd: optee_rpmb command for read/write of rpmb from optee cmd/Kconfig | 8 + cmd/Makefile | 1 + cmd/optee_rpmb.c | 272 +++++++++++++++++++++++++++++++ configs/lx2160ardb_tfa_defconfig | 5 + 4 files changed, 286 insertions(+) create mode 100644 cmd/optee_rpmb.c -- 2.17.1

1 2

U-Boot FIT Signature Verification
by Andrii Voloshyn 17 Sep '20

17 Sep '20

Hi there, Does U-boot take into account certificate expiration date when verifying signed images in FIT? In other words, is date stored along with the public key in DTB file? Cheers, Andy

7 12

[PATCH 0/4] dm: Print device name in dev_xxx() like Linux
by Sean Anderson 17 Sep '20

17 Sep '20

This series adds some additional information to dev_dbg. With this series, and the following options applied in addition to sandbox_defconfig CONFIG_LOGLEVEL=8 CONFIG_LOG=n CONFIG_CMD_LOG=n CONFIG_CMD_TPM=n the output of U-Boot is U-Boot 2020.10-rc4-00006-g19b641dddd-dirty (Sep 12 2020 - 18:15:00 -0400) Model: sandbox DRAM: 128 MiB pinctrl-gpio sandbox_pinctrl_gpio: set_state_simple op missing leds gpio_led: set_state_simple op missing default_on gpio_led: set_state_simple op missing base-gpios sandbox_gpio: set_state_simple op missing default_off gpio_led: set_state_simple op missing wdt@0 wdt_sandbox: set_state_simple op missing WDT: Started with servicing (60s timeout) MMC: mmc0 mmc_sandbox: set_state_simple op missing mmc1 mmc_sandbox: set_state_simple op missing mmc2 mmc_sandbox: set_state_simple op missing mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD) lcd sandbox_lcd_sdl: set_state_simple op missing In: serial Out: vidconsole Err: vidconsole Model: sandbox hog_input_active_low gpio_hog: set_state_simple op missing hog_input_active_high gpio_hog: set_state_simple op missing hog_output_low gpio_hog: set_state_simple op missing hog_output_high gpio_hog: set_state_simple op missing cros-ec google_cros_ec_sandbox: set_state_simple op missing SCSI: pci_ep pci_ep_sandbox: set_state_simple op missing Net: eth@10002000 eth_sandbox: set_state_simple op missing eth0: eth@10002000eth@10003000 eth_sandbox: set_state_simple op missing , eth5: eth@10003000sbe5 eth_sandbox: set_state_simple op missing , eth3: sbe5eth@10004000 eth_sandbox: set_state_simple op missing , eth6: eth@10004000 bootcount@0 bootcount-rtc: set_state_simple op missing i2c@0 i2c_sandbox: set_state_simple op missing rtc@61 rtc-sandbox: set_state_simple op missing emul i2c_emul_parent_drv: set_state_simple op missing emull sandbox_i2c_rtc_emul: set_state_simple op missing Hit any key to stop autoboot: When using CONFIG_LOG the output of U-Boot is too verbose to fit in this email. Note that there is a soft dependency on [1] if you would like to test this patch with CONFIG_LOG and a higher LOG_LEVEL than LOGL_INFO. [1] https://patchwork.ozlabs.org/project/uboot/list/?series=201343 Sean Anderson (4): remoteproc: Remove unused function rproc_elf_sanity_check net: mdio: Supply appropriate devices for dev_dgb calls dm: Use symbolic constants for log levels in dev_xxx() dm: Print device name in dev_xxx() like Linux drivers/remoteproc/rproc-elf-loader.c | 16 ------ include/dm/device_compat.h | 75 +++++++++++++-------------- include/remoteproc.h | 13 ----- net/mdio-uclass.c | 4 +- 4 files changed, 39 insertions(+), 69 deletions(-) -- 2.28.0

2 10

Pull request: u-boot-rockchip-20200916
by Kever Yang 16 Sep '20

16 Sep '20

Hi Tom, Please pull the rockchip fixes: - Fix rv1108 grf access issue - make_fit_atf: ignore empty PT_LOAD segment Gitlab ci: https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip/pipelines/4685 Thanks, - Kever The following changes since commit 4dcced116976937f6f7dd9a0e39cde8120250c16: Merge tag 'mmc-2020-9-15' of https://gitlab.denx.de/u-boot/custodians/u-boot-mmc (2020-09-15 08:59:32 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20200916 for you to fetch changes up to 5b861eea7927da63f016b75265e454a19ab19d0b: rockchip: make_fit_atf: ignore empty PT_LOAD segment (2020-09-16 16:41:30 +0800) ---------------------------------------------------------------- Heinrich Schuchardt (1): rockchip: make_fit_atf: ignore empty PT_LOAD segment Kever Yang (3): rockchip: rv1108: use correct API for board callback rockchip: rv1108: Enable grf as pre-reloc node rockchip: rv1108: enable board early init arch/arm/dts/rv1108-u-boot.dtsi | 4 ++++ arch/arm/mach-rockchip/make_fit_atf.py | 5 +++-- board/elgin/elgin_rv1108/elgin_rv1108.c | 2 +- board/rockchip/evb_rv1108/evb_rv1108.c | 2 +- configs/elgin-rv1108_defconfig | 1 + configs/evb-rv1108_defconfig | 1 + 6 files changed, 11 insertions(+), 4 deletions(-)

2 1

Pull request for UEFI sub-system for efi-2020-10-rc5
by Heinrich Schuchardt 16 Sep '20

16 Sep '20

Dear Tom, The following changes since commit 00e5fda0063eaa20e9c3f6844ac88c64eb875f23: Merge branch '2020-09-12-assorted-bugfixes' (2020-09-14 15:39:46 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-10-rc5 for you to fetch changes up to 5bf12a78599d4a311265c174496233aa15ed4252: efi_selftest: restore gd before do_reset() (2020-09-14 23:28:52 +0200) ---------------------------------------------------------------- Pull request for UEFI sub-system for efi-2020-10-rc5 The following bugs are fixed: * unaligned access in br_i32_decode() * missing restore of global data pointer in UEFI selftest * missing restore of global data pointer on RISC-V in UEfI subsystem * efi_var_mem_notify_exit_boot_services() should not be __efi_runtime ---------------------------------------------------------------- Heinrich Schuchardt (4): efi_loader: efi_var_mem_notify_exit_boot_services riscv: define function set_gd() efi_loader: save global data pointer on RISC-V efi_selftest: restore gd before do_reset() Robert Reither (1): rsa: crash in br_i32_decode() called from rsa_gen_key_prop() arch/riscv/include/asm/global_data.h | 9 +++++++++ lib/efi_loader/efi_boottime.c | 18 +++++++++--------- lib/efi_loader/efi_var_mem.c | 2 +- lib/efi_selftest/efi_selftest.c | 6 ++++-- lib/rsa/rsa-keyprop.c | 6 +++--- 5 files changed, 26 insertions(+), 15 deletions(-)

2 2

Boot Over Ehternet- Linux Server to Raspberry Pis- Using U-boot
by Ahsan Zia (TAU) 16 Sep '20

16 Sep '20

Hi All, I need some ideas regarding Boot Over Ehternet. I have been following the u boot document as well. I am attempting BoE from a Linux Server to a cluster of Raspberry Pis. i.e we have a Ubuntu (linux) Server with Raspbian image, the desired result is to somehow ''Mount'' the image, so that the Cluster of RPis can be booted-up using Ethernet? The image can be booted-up automatically when a new RPI is introduced into the system? The RPIs are Power over Ethernet, PoE hats and have Raspbian lite pre-installed. The image can be booted-up automatically when a new RPI is introduced into the system? Please post some ideas. Best Regards, Ahsan Zia Project Researcher, Computing Sciences, Information Technology and Communication Sciences, Tampere University.

3 2

[PATCH 1/2] x86: acpi: Fix calculation of DSDT length
by Wolfgang Wallner 16 Sep '20

16 Sep '20

Currently, the calculation for the length of the DSDT table includes any bytes that are added for alignment, but those bytes are not initialized. This is because the DSDT length is calculated after a call to acpi_inc_align(). Split this up into the following sequence: * acpi_inc() * Calculate DSDT length * acpi_align() Signed-off-by: Wolfgang Wallner <wolfgang.wallner(a)br-automation.com> --- arch/x86/lib/acpi_table.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c index 3a93fedfc3..6b827bfa3f 100644 --- a/arch/x86/lib/acpi_table.c +++ b/arch/x86/lib/acpi_table.c @@ -427,7 +427,7 @@ ulong write_acpi_tables(ulong start_addr) (char *)&AmlCode + sizeof(struct acpi_table_header), dsdt->length - sizeof(struct acpi_table_header)); - acpi_inc_align(ctx, dsdt->length - sizeof(struct acpi_table_header)); + acpi_inc(ctx, dsdt->length - sizeof(struct acpi_table_header)); /* Pack GNVS into the ACPI table area */ for (i = 0; i < dsdt->length; i++) { @@ -450,6 +450,8 @@ ulong write_acpi_tables(ulong start_addr) dsdt->checksum = 0; dsdt->checksum = table_compute_checksum((void *)dsdt, dsdt->length); + acpi_align(ctx); + /* * Fill in platform-specific global NVS variables. If this fails we * cannot return the error but this should only happen while debugging. -- 2.28.0

3 8

Re: U-Boot FIT Signature Verification
by REITHER Robert - Contractor 16 Sep '20

16 Sep '20

Hi there I don't think it would make sense to check for expiration (even in case we would have full certificates like PKCS#7 verifiy) At our point of the boot process we normally do not have access to a trusted time/date, so any check could be simply spoofed or even worse fails, because wall clock is not initialized properly. I think even the EFI boot-process (or shim) does not check expiration date of their certificates! What could make sense is a check for an expired certificate/key at signing time (including intermed certs), but not sure if this would be a too hard restriction (at least for developing/testing). I think a hint for the signer should be enough! Regards Robert On Wed, Sep 16, 2020 at 01:19:03AM +0200, Heinrich Schuchardt wrote: > On 9/11/20 7:26 PM, Andrii Voloshyn wrote: > > Hi there, > > > > Does U-boot take into account certificate expiration date when verifying signed images in FIT? In other words, is date stored along with the public key in DTB file? > > > > Cheers, > > Andy > > > > Hello Philippe, > > looking at padding_pkcs_15_verify() in lib/rsa/rsa-verify.c I cannot > find a comparison of the date on which an image was signed with the > expiry date of the certificate. Shouldn't there be a check? Or did I > simply look into the wrong function? I think Simon is the right person to answer this question, but as far as I know, we don't have any device tree property for the expiration date of a public key. See doc/uImage.FIT/signature.txt. -Takahiro Akashi > Best regards > > Heinrich

1 0