June 2020 - U-Boot

[PATCH 1/6] bootstage: Fix 'stacked' typo
by Simon Glass 18 Jun '20

18 Jun '20

This should be 'stashed'. Fix it. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- include/bootstage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/bootstage.h b/include/bootstage.h index f507271375..00c85fb86a 100644 --- a/include/bootstage.h +++ b/include/bootstage.h @@ -338,7 +338,7 @@ int bootstage_stash(void *base, int size); * @param base Base address of memory buffer * @param size Size of memory buffer (-1 if unknown) * @return 0 if unstashed ok, -ENOENT if bootstage info not found, -ENOSPC if - * there is not space for read the stacked data, or other error if + * there is not space for read the stashed data, or other error if * something else went wrong */ int bootstage_unstash(const void *base, int size); -- 2.27.0.rc0.183.gde8f92d652-goog

4 9

[PATCH 1/2] ARM: dts: sama5d4: fix gadget endpoint address warning
by Eugen Hristev 18 Jun '20

18 Jun '20

arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@10: graph node unit address error, expected "a" arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@11: graph node unit address error, expected "b" arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@12: graph node unit address error, expected "c" arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@13: graph node unit address error, expected "d" arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@14: graph node unit address error, expected "e" arch/arm/dts/at91-sama5d4ek.dtb: Warning (graph_endpoint): /ahb/gadget@00400000/endpoint@15: graph node unit address error, expected "f" Fixed by changing address in node name to hex. Signed-off-by: Eugen Hristev <eugen.hristev(a)microchip.com> --- arch/arm/dts/sama5d4.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/dts/sama5d4.dtsi b/arch/arm/dts/sama5d4.dtsi index 8875d7ba76..e1df24cdbe 100644 --- a/arch/arm/dts/sama5d4.dtsi +++ b/arch/arm/dts/sama5d4.dtsi @@ -212,42 +212,42 @@ atmel,can-isoc; }; - ep10: endpoint@10 { + ep10: endpoint@a { reg = <10>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; atmel,can-isoc; }; - ep11: endpoint@11 { + ep11: endpoint@b { reg = <11>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; atmel,can-isoc; }; - ep12: endpoint@12 { + ep12: endpoint@c { reg = <12>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; atmel,can-isoc; }; - ep13: endpoint@13 { + ep13: endpoint@d { reg = <13>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; atmel,can-isoc; }; - ep14: endpoint@14 { + ep14: endpoint@e { reg = <14>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; atmel,can-isoc; }; - ep15: endpoint@15 { + ep15: endpoint@f { reg = <15>; atmel,fifo-size = <1024>; atmel,nb-banks = <2>; -- 2.25.1

2 2

[PATCH v2 0/2] ARM: at91: Allow running SPL with DTB append
by Gregory CLEMENT 18 Jun '20

18 Jun '20

Hello, a few months ago I submitted a small series allowing to run SPL with DTB append. Indeed according to the linker BSS section was all the time separated for SPL but the symbol SPL_SEPARATE_BSS was only enabled on some boards. In this v2 the changes are: - add reviewed-by Stefan Roese <sr(a)denx.de> - modify a new defconfig sama5d3_xplained_nandflash_defconfig Thanks, Gregory Gregory CLEMENT (2): ARM: at91: Enable SPL_SEPARATE_BSS by default configs: atmel: cleanup CONFIG_SPL_SEPARATE_BSS arch/arm/Kconfig | 1 + configs/gardena-smart-gateway-at91sam_defconfig | 1 - configs/sama5d27_som1_ek_mmc1_defconfig | 1 - configs/sama5d27_som1_ek_mmc_defconfig | 1 - configs/sama5d27_som1_ek_qspiflash_defconfig | 1 - configs/sama5d27_wlsom1_ek_mmc_defconfig | 1 - configs/sama5d27_wlsom1_ek_qspiflash_defconfig | 1 - configs/sama5d2_icp_mmc_defconfig | 1 - configs/sama5d2_xplained_emmc_defconfig | 1 - configs/sama5d2_xplained_mmc_defconfig | 1 - configs/sama5d2_xplained_qspiflash_defconfig | 1 - configs/sama5d3_xplained_mmc_defconfig | 1 - configs/sama5d3xek_mmc_defconfig | 1 - configs/sama5d4_xplained_mmc_defconfig | 1 - configs/sama5d4ek_mmc_defconfig | 1 - 15 files changed, 1 insertion(+), 14 deletions(-) -- 2.26.2

2 3

[PATCH v4 0/4] cmd: env: add option for quiet output on env info
by Patrick Delaunay 18 Jun '20

18 Jun '20

Hi, It is a V4 for [1] serie. I add the -q option for 'env info' command and I also add pytest for this command. Test for ENV_IS_IN_DEVICE is included in separate serie [2] (I will activate ENV_IS_IN_EXT4 support in sandbox) To avoid compilation warning, I add prototype for env_get_location for the patch 3/7 "cmd: env: check real location for env info command" as it is done in [3]. [1] http://patchwork.ozlabs.org/project/uboot/list/?series=158105 [2] http://patchwork.ozlabs.org/project/uboot/list/?series=158160 [3] http://patchwork.ozlabs.org/patch/1230200/ Changes in v4: - rebase on master branch - move 5/7 stm32mp1: configs: activate CMD_ERASEENV in a new serie 183380 - move 2/7 and 4/7 in a new serie 183387 Changes in v3: - update commit message (sub-commandi) - rename test_env_info_test to test_env_info_quiet Changes in v2: - update prototype in env_internal.h as done in "env: add prototypes for weak function" - remove comment change in env.c (implementation information) - move env_location declaration - activate env info command in sandbox (new) - add pytest test_env_info and test_env_info_test (new) Patrick Delaunay (4): cmd: env: add option for quiet output on env info cmd: env: check real location for env info command configs: sandbox: Enable sub command 'env info' test: env: add test for env info sub-command cmd/Kconfig | 1 + cmd/nvedit.c | 37 +++++++++++++++++++------ configs/sandbox64_defconfig | 1 + configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + configs/sandbox_spl_defconfig | 1 + include/env_internal.h | 11 ++++++++ test/py/tests/test_env.py | 44 ++++++++++++++++++++++++++++++ 8 files changed, 89 insertions(+), 8 deletions(-) -- 2.17.1

3 8

USB patch for rpi4
by Stuart Yoder 18 Jun '20

18 Jun '20

Hi Sylwester, I am trying to test v4 of your patch series for USB support on rpi4: https://patchwork.ozlabs.org/project/uboot/list/?series=179078 I am building u-boot 64-bit. Testing on a rpi4 B 1.2 board. But, USB is not working for me and wanted to see if you had any ideas. Are there other dependencies other than just applying your patch series? I've pasted the u-boot console output below. >From what I can tell this board does not need the VL805 firmware loading patch. But, I did try those patches and it did not make any difference. Thanks, Stuart --------------------------------------------------------------------- U-Boot 2020.07-rc1-00009-geca0ff12a6 (Jun 10 2020 - 16:02:20 -0500) DRAM: 3.9 GiB RPI 4 Model B (0xc03112) MMC: emmc2@7e340000: 0, mmcnr@7e300000: 1 Loading Environment from FAT... *** Warning - bad CRC, using default environment In: serial Out: vidconsole Err: vidconsole Net: eth0: genet@7d580000 starting USB... No working controllers found Hit any key to stop autoboot: 0

4 7

mx6sabresd: Trying to use qca,clk-out-frequency
by Fabio Estevam 17 Jun '20

17 Jun '20

Hi, Now that mx6sabresd board has Ethernet working again with this fix: https://lists.denx.de/pipermail/u-boot/2020-June/416623.html ,I would like to remove the ar8031_phy_fixup() from board/freescale/mx6sabresd/mx6sabresd.c. Here is what I tested so far: https://pastebin.com/raw/cQW5RmXW However, I see that in drivers/net/phy/atheros.c the if (!ofnode_read_u32(node, "qca,clk-out-frequency", &freq)) { condition is never executed, so qca,clk-out-frequency configuration does not take effect. Any ideas why this happens? Thanks

4 8

[PATCH] regulator: fix: enable gpio when requested
by Mark Kettenis 17 Jun '20

17 Jun '20

The fix in commit b7adcdd073c0 has the side-effect that the regulator will be disabled when requesting the relevant gpio in regulator_common_ofdata_to_platdata() and enabled in regulator_pre_probe() when the regulator was already enabled. This leads to a short interruption in the 3.3V power to the PCIe slot on the firefly-rk3399 which makes an ADATA SX8000NP NVMe SSD unhappy. Fix this by setting the GPIOD_IS_OUT_ACTIVE flag again when the 'regulator-boot-on' property is set, but check for this property explicitly instead of relying on the "boot_on" member of the uclass platdata. Signed-off-by: Mark Kettenis <kettenis(a)openbsd.org> --- drivers/power/regulator/regulator-uclass.c | 3 --- drivers/power/regulator/regulator_common.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c index c9d26344d7..90961de95c 100644 --- a/drivers/power/regulator/regulator-uclass.c +++ b/drivers/power/regulator/regulator-uclass.c @@ -464,9 +464,6 @@ static int regulator_pre_probe(struct udevice *dev) (uc_pdata->min_uA == uc_pdata->max_uA)) uc_pdata->flags |= REGULATOR_FLAG_AUTOSET_UA; - if (uc_pdata->boot_on) - regulator_set_enable(dev, uc_pdata->boot_on); - return 0; } diff --git a/drivers/power/regulator/regulator_common.c b/drivers/power/regulator/regulator_common.c index 33b73b7c2f..bc13b88476 100644 --- a/drivers/power/regulator/regulator_common.c +++ b/drivers/power/regulator/regulator_common.c @@ -17,6 +17,8 @@ int regulator_common_ofdata_to_platdata(struct udevice *dev, if (!dev_read_bool(dev, "enable-active-high")) flags |= GPIOD_ACTIVE_LOW; + if (dev_read_bool(dev, "regulator-boot-on")) + flags |= GPIOD_IS_OUT_ACTIVE; /* Get optional enable GPIO desc */ gpio = &dev_pdata->gpio; -- 2.26.2

6 8

[PATCH u-boot v2 0/4] r8152: support more chips
by Hayes Wang 17 Jun '20

17 Jun '20

v2: For patch #1, replace u32 with u8 for rtl_reset_bmu(). For patch #3, use USB_BP(n) to replace USB_BP_0 ~ USB_BP_7. Write the registers in bulk for rtl_clear_bp(). For patch #4, add a macro for the magic value. Remove type casts. Write the register in bulk, if it is possible. Reduce indent. v1: The first two patched are some improvements. And the last two patches are used to support RTL8153B and RTL8154B. Hayes Wang (4): eth/r8152: reset bmu after disabling Tx/Rx eth/r8152: reset PHY after setting it eth/r8152: modify rtl_clear_bp function eth/r8152: support RTL8153B/RTL8154B drivers/usb/eth/r8152.c | 223 +++++++++++++++++++++++++++++++++- drivers/usb/eth/r8152.h | 71 +++++++++-- drivers/usb/eth/r8152_fw.c | 239 +++++++++++++++++++++++++++++++++---- 3 files changed, 493 insertions(+), 40 deletions(-) -- 2.21.1

2 5

[PATCH] arm64: issue ISB after updating system registers
by Volodymyr Babchuk 17 Jun '20

17 Jun '20

ARM Architecture reference manual clearly states that PE pipeline should be flushed after any change to system registers. Failing to do so can lead to spurious errors, like synchronous exception when accessing FPU registers. This is very prominent on CPUs with long instruction pipeline, like Cortex A72. This change fixes the following U-Boot panic: "Synchronous Abort" handler, esr 0x1fe00000 elr: 00000000800948cc lr : 0000000080091e04 x0 : 00000000801ffdc8 x1 : 00000000000000c8 x2 : 00000000800979d4 x3 : 00000000801ffc60 x4 : 00000000801ffd40 x5 : ffffff80ffffffd8 x6 : 00000000801ffd70 x7 : 00000000801ffd70 x8 : 000000000000000a x9 : 0000000000000000 x10: 0000000000000044 x11: 0000000000000000 x12: 0000000000000000 x13: 0000000000000000 x14: 0000000000000000 x15: 0000000000000000 x16: 000000008008b2e0 x17: 0000000000000000 x18: 00000000801ffec0 x19: 00000000800957b0 x20: 00000000000000c8 x21: 00000000801ffdc8 x22: 000000008009909e x23: 0000000000000000 x24: 0000000000000000 x25: 0000000000000000 x26: 0000000000000000 x27: 0000000000000000 x28: 0000000000000000 x29: 00000000801ffc50 Code: a94417e4 a90217e4 a9051fe6 a90617e4 (3d801fe0) While executing instruction str q0, [sp, #112] in vsnprintf() prologue. This panic was observed on Cortex A72 so far. Also, this probably the right fix for the issue workarounded in the commit 45f41c13 ("ARM: uniphier: add weird workaround code for LD20") Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk(a)epam.com> CC: Tom Rini <trini(a)konsulko.com> CC: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- arch/arm/cpu/armv8/start.S | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S index 99d126660d..eb1290ad29 100644 --- a/arch/arm/cpu/armv8/start.S +++ b/arch/arm/cpu/armv8/start.S @@ -120,6 +120,7 @@ pie_fixup_done: mov x0, #3 << 20 msr cpacr_el1, x0 /* Enable FP/SIMD */ 0: + isb /* * Enable SMPEN bit for coherency. -- 2.26.2

1 0

[PATCH 1/1] doc: random number generation
by Heinrich Schuchardt 17 Jun '20

17 Jun '20

Add random number generation APIs to the HTML documentation. Fix style issues. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- MAINTAINERS | 1 + doc/api/index.rst | 1 + doc/api/rng.rst | 17 +++++++++++++++++ include/rand.h | 6 +++--- include/rng.h | 26 ++++++++++++++++++-------- 5 files changed, 40 insertions(+), 11 deletions(-) create mode 100644 doc/api/rng.rst diff --git a/MAINTAINERS b/MAINTAINERS index 1fd975c72f..00985c0e8e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -877,6 +877,7 @@ M: Sughosh Ganu <sughosh.ganu(a)linaro.org> R: Heinrich Schuchardt <xypron.glpk(a)gmx.de> S: Maintained F: cmd/rng.c +F: doc/api/rng.rst F: drivers/rng/ F: drivers/virtio/virtio_rng.c F: include/rng.h diff --git a/doc/api/index.rst b/doc/api/index.rst index fd3b5bdc82..b7eb5725f2 100644 --- a/doc/api/index.rst +++ b/doc/api/index.rst @@ -9,5 +9,6 @@ U-Boot API documentation dfu efi linker_lists + rng serial unicode diff --git a/doc/api/rng.rst b/doc/api/rng.rst new file mode 100644 index 0000000000..b826d4fd4a --- /dev/null +++ b/doc/api/rng.rst @@ -0,0 +1,17 @@ +.. SPDX-License-Identifier: GPL-2.0+ +.. Copyright (c) 2018 Heinrich Schuchardt + +Random number generation +======================== + +Hardware random number generation +--------------------------------- + +.. kernel-doc:: include/rng.h + :internal: + +Pseudo random number generation +------------------------------- + +.. kernel-doc:: include/rand.h + :internal: diff --git a/include/rand.h b/include/rand.h index c9d15f50a1..4c54fbbd10 100644 --- a/include/rand.h +++ b/include/rand.h @@ -22,7 +22,7 @@ void srand(unsigned int seed); /** * rand() - Get a 32-bit pseudo-random number * - * @returns next random number in the sequence + * Return: next random number in the sequence */ unsigned int rand(void); @@ -32,8 +32,8 @@ unsigned int rand(void); * This version of the function allows multiple sequences to be used at the * same time, since it requires the caller to store the seed value. * - * @seed value to use, updated on exit - * @returns next random number in the sequence + * @seedp: seed value to use, updated on exit + * Return: next random number in the sequence */ unsigned int rand_r(unsigned int *seedp); diff --git a/include/rng.h b/include/rng.h index d2c0f9af62..37af554363 100644 --- a/include/rng.h +++ b/include/rng.h @@ -10,22 +10,32 @@ struct udevice; /** * dm_rng_read() - read a random number seed from the rng device - * @buffer: input buffer to put the read random seed into - * @size: number of bytes of random seed read * - * Return: 0 if OK, -ve on error + * The function blocks until the requested number of bytes is read. + * + * @dev: random number generator device + * @buffer: input buffer to put the read random seed into + * @size: number of random bytes to read + * Return: 0 if OK, -ve on error */ int dm_rng_read(struct udevice *dev, void *buffer, size_t size); -/* struct dm_rng_ops - Operations for the hwrng uclass */ +/** + * struct dm_rng_ops - operations for the hwrng uclass + * + * This structures contains the function implemented by a hardware random + * number generation device. + */ struct dm_rng_ops { /** - * @read() - read a random number seed + * @read: read a random bytes * - * @data: input buffer to read the random seed - * @max: total number of bytes to read + * The function blocks until the requested number of bytes is read. * - * Return: 0 if OK, -ve on error + * @read.dev: random number generator device + * @read.data: input buffer to read the random seed into + * @read.max: number of random bytes to read + * @read.Return: 0 if OK, -ve on error */ int (*read)(struct udevice *dev, void *data, size_t max); }; -- 2.27.0

2 2