May 2020 - U-Boot

sd-card is not working on espressobin
by Moritz Berghof 04 May '20

04 May '20

Hi Community, Hi Marek, Hi Stefan, we are still working on the u-boot master of the espressobin platform. Do you have any ideas why mmc cannot find any sd-card? The mmc devices can be list and I changed the armada-3720-espressobin.dts<https://pxccs-gitlab.dev.de.innominate.com/pxccs-components/u-boot-mainline…> with: vcc_sd_reg0: regulator@0 { ... }; &sdhci0 { pinctrl-names = "default"; pinctrl-0 = <&sdio_pins>; bus-width = <4>; vqmmc-supply = <&vcc_sd_reg0>; status = "okay"; }; MMC ist activated on mvebu_espressobin-88f3720_defconfig<https://pxccs-gitlab.dev.de.innominate.com/pxccs-components/u-boot-mainline…>. Greetings, -- Moritz Berghof Software Engineer mberghof(a)phoenixcontact.com<mailto:mberghof@phoenixcontact.com> www.phoenixcontact.com<http://www.phoenixcontact.com/> PHOENIX CONTACT Cyber Security GmbH Richard-Willstätter-Straße 6<x-apple-data-detectors://1/1> D-12489 Berlin<x-apple-data-detectors://1/1> Register Court: AG Charlottenburg, HR B 202908 Geschäftsführer/General Manager: Kilian Golm ....................................................................................... PHOENIX CONTACT Cyber Security GmbH Richard-Willstätter-Straße 6 D-12489 Berlin Register Court: AG Charlottenburg, HR B 202908 Geschäftsführer/General Manager: Kilian Golm

2 2

[PATCH V3 1/9] uclass: cpu: Add new API to get udevice for current CPU
by Peng Fan 04 May '20

04 May '20

When running on SoC with multiple clusters, the boot CPU may not be fixed, saying booting from cluster A or cluster B. Add a API that can return the udevice for current boot CPU. Cpu driver needs to implement is_current_cpu interface for this feature, otherwise the API only returns the first udevice in cpu uclass. Reviewed-by: Simon Glass <sjg(a)chromium.org> Signed-off-by: Peng Fan <peng.fan(a)nxp.com> Signed-off-by: Ye Li <ye.li(a)nxp.com> --- V3: Drop ops check. Add R-b V2: Per Simon's comment, - Add cpu_is_current - use uclass_foreach_dev_probe - Update code comment drivers/cpu/cpu-uclass.c | 34 ++++++++++++++++++++++++++++++++++ include/cpu.h | 23 +++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/drivers/cpu/cpu-uclass.c b/drivers/cpu/cpu-uclass.c index 457f77b7c8..8352e2eb0b 100644 --- a/drivers/cpu/cpu-uclass.c +++ b/drivers/cpu/cpu-uclass.c @@ -10,6 +10,7 @@ #include <errno.h> #include <dm/lists.h> #include <dm/root.h> +#include <linux/err.h> int cpu_probe_all(void) { @@ -34,6 +35,39 @@ int cpu_probe_all(void) return 0; } +int cpu_is_current(struct udevice *cpu) +{ + struct cpu_ops *ops = cpu_get_ops(cpu); + + if (ops->is_current) { + if (ops->is_current(cpu)) + return 1; + } + + return -ENOSYS; +} + +struct udevice *cpu_get_current_dev(void) +{ + struct udevice *cpu; + int ret; + + uclass_foreach_dev_probe(UCLASS_CPU, cpu) { + if (cpu_is_current(cpu) > 0) + return cpu; + } + + /* If can't find current cpu device, use the first dev instead */ + ret = uclass_first_device_err(UCLASS_CPU, &cpu); + if (ret) { + debug("%s: Could not get CPU device (err = %d)\n", + __func__, ret); + return NULL; + } + + return cpu; +} + int cpu_get_desc(struct udevice *dev, char *buf, int size) { struct cpu_ops *ops = cpu_get_ops(dev); diff --git a/include/cpu.h b/include/cpu.h index 6b1b6b37b3..2f283fe244 100644 --- a/include/cpu.h +++ b/include/cpu.h @@ -89,6 +89,15 @@ struct cpu_ops { * @return 0 if OK, -ENOSPC if buffer is too small, other -ve on error */ int (*get_vendor)(struct udevice *dev, char *buf, int size); + + /** + * is_current() - Check if the CPU that U-Boot is currently running from + * + * @dev: Device to check (UCLASS_CPU) + * @return 1 if the CPU that U-Boot is currently running from, 0 + * if not. + */ + int (*is_current)(struct udevice *dev); }; #define cpu_get_ops(dev) ((struct cpu_ops *)(dev)->driver->ops) @@ -137,4 +146,18 @@ int cpu_get_vendor(struct udevice *dev, char *buf, int size); */ int cpu_probe_all(void); +/** + * cpu_is_current() - Check if the CPU that U-Boot is currently running from + * + * Return: 1 if yes, - 0 if not + */ +int cpu_is_current(struct udevice *cpu); + +/** + * cpu_get_current_dev() - Get CPU udevice for current CPU + * + * Return: udevice if OK, - NULL on error + */ +struct udevice *cpu_get_current_dev(void); + #endif -- 2.16.4

2 17

[PATCH 1/5] spl: sdp: call board_usb_init at spl_sdp_load_image
by Peng Fan 04 May '20

04 May '20

From: Frank Li <Frank.Li(a)nxp.com> Need initialize UDC before run sdp download Signed-off-by: Frank Li <Frank.Li(a)nxp.com> Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- common/spl/spl_sdp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index 806bf1327e..a54c7479d0 100644 --- a/common/spl/spl_sdp.c +++ b/common/spl/spl_sdp.c @@ -16,6 +16,8 @@ static int spl_sdp_load_image(struct spl_image_info *spl_image, int ret; const int controller_index = 0; + board_usb_init(0, USB_INIT_DEVICE); + g_dnl_clear_detach(); ret = g_dnl_register("usb_dnl_sdp"); if (ret) { -- 2.16.4

2 9

[PATCH v5 0/1] x86: efi: Add a 64-bit coreboot payload
by Simon Glass 04 May '20

04 May '20

This series creates a new 64-bit 'coreboot64' build which can be launched from coreboot. It uses SPL to effect the jump to 64-bit mode. This was done in an attempt to get the Ubuntu FirmwareTestSuite[1] working. Unfortunately the latest version shows a splash screen and hangs, perhaps due to some missing EFI support. [1] https://wiki.ubuntu.com/FirmwareTestSuite Changes in v5: - Rewrite commit message to explain what coreboot is Simon Glass (1): x86: Add a 64-bit 'coreboot64' build board/coreboot/coreboot/MAINTAINERS | 7 +++++ configs/coreboot64_defconfig | 48 +++++++++++++++++++++++++++++ doc/board/coreboot/coreboot.rst | 10 ++++++ 3 files changed, 65 insertions(+) create mode 100644 configs/coreboot64_defconfig -- 2.26.2.526.g744177e7f7-goog

3 7

[PATCH 2/2] arm64: armada-37xx: espressobin: enable SD card and network
by Peter Vollmer 04 May '20

04 May '20

activate MMC_BROKEN_CD because drivers/mmc/mvebu_mmc.c does not yet follow the driver model, so the card detection GPIO is not polled. activate network switch, tested with bootp and random MAC generation Signed-off-by: Peter Vollmer <peter.vollmer(a)gmail.com> --- configs/mvebu_espressobin-88f3720_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig index 01b6120149..71ff2cee99 100644 --- a/configs/mvebu_espressobin-88f3720_defconfig +++ b/configs/mvebu_espressobin-88f3720_defconfig @@ -48,14 +48,16 @@ CONFIG_DM_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_SDMA=y CONFIG_MMC_SDHCI_XENON=y +CONFIG_MMC_BROKEN_CD=y CONFIG_MTD=y CONFIG_SF_DEFAULT_MODE=0 CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y +CONFIG_MVNETA=y +CONFIG_NET_RANDOM_ETHADDR=y CONFIG_PHYLIB=y -CONFIG_PHY_MARVELL=y CONFIG_PHY_GIGE=y CONFIG_E1000=y CONFIG_PCI=y -- 2.20.1

1 0

[PATCH 1/2] arm64: armada-37xx: dts: sync armada-3720-espressobin.dts with u-boot-marvell
by Peter Vollmer 04 May '20

04 May '20

from https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/blob/u-boot-201… fix comphy mode settings for USB3 (working) fix comphy mode setting for network (working) fix comphy mode setting for SATA (not yet working) add config for SD card (working) add voltage regulator for SDHC/SDXC SD cards (not yet tested) add config for EMMC flash (working) Signed-off-by: Peter Vollmer <peter.vollmer(a)gmail.com> --- arch/arm/dts/armada-3720-espressobin.dts | 49 +++++++++++++++++++++--- 1 file changed, 44 insertions(+), 5 deletions(-) diff --git a/arch/arm/dts/armada-3720-espressobin.dts b/arch/arm/dts/armada-3720-espressobin.dts index 84e2c2adba..393feb0c23 100644 --- a/arch/arm/dts/armada-3720-espressobin.dts +++ b/arch/arm/dts/armada-3720-espressobin.dts @@ -67,23 +67,34 @@ device_type = "memory"; reg = <0x00000000 0x00000000 0x00000000 0x20000000>; }; + + vcc_sd_reg0: regulator@0 { + compatible = "regulator-gpio"; + regulator-name = "vcc_sd0"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-type = "voltage"; + states = <1800000 0x1 + 3300000 0x0>; + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>; + }; }; &comphy { max-lanes = <3>; phy0 { - phy-type = <PHY_TYPE_PEX0>; - phy-speed = <PHY_SPEED_2_5G>; + phy-type = <PHY_TYPE_USB3_HOST0>; + phy-speed = <PHY_SPEED_5G>; }; phy1 { - phy-type = <PHY_TYPE_USB3_HOST0>; - phy-speed = <PHY_SPEED_5G>; + phy-type = <PHY_TYPE_PEX0>; + phy-speed = <PHY_SPEED_2_5G>; }; phy2 { phy-type = <PHY_TYPE_SATA0>; - phy-speed = <PHY_SPEED_5G>; + phy-speed = <PHY_SPEED_6G>; }; }; @@ -110,6 +121,34 @@ status = "okay"; }; +/* SD card */ +&sdhci0 { + pinctrl-names = "default"; + pinctrl-0 = <&sdio_pins>; + bus-width = <4>; + vqmmc-supply = <&vcc_sd_reg0>; + status = "okay"; +}; + +/* enable if EMMC present on board */ +&sdhci1 { + non-removable; + bus-width = <8>; + mmc-ddr-1_8v; + mmc-hs400-1_8v; + marvell,pad-type = "fixed-1-8v"; + pinctrl-names = "default"; + pinctrl-0 = <&mmc_pins>; + status = "okay"; + + #address-cells = <1>; + #size-cells = <0>; + mmccard: mmccard@0 { + compatible = "mmc-card"; + reg = <0>; + }; +}; + &spi0 { status = "okay"; pinctrl-names = "default"; -- 2.20.1

1 0

[PATCH 0/2] fixes for basic espressobin support
by Peter Vollmer 04 May '20

04 May '20

With current u-boot mainline espressobin is not working: - SATA causes synchronous abort on startup - USB3, SD card, EMMC flash and ethernet are not working out of the box This patch series fixes above (with SATA not yet working) and makes espressobin usable again with mainline u-boot, based on the devicetree differences with the Marvell-hosted u-boot-marvell git repository at https://github.com/MarvellEmbeddedProcessors/u-boot-marvell Also tested on top of current u-boot-marvell custodian. Peter Vollmer (2): arm64: armada-37xx: dts: sync armada-3720-espressobin.dts with u-boot-marvell arm64: armada-37xx: espressobin: enable SD card and network arch/arm/dts/armada-3720-espressobin.dts | 49 ++++++++++++++++++--- configs/mvebu_espressobin-88f3720_defconfig | 4 +- 2 files changed, 47 insertions(+), 6 deletions(-) -- 2.20.1

1 0

[PATCH v3] cmd: mvebu: bubt: fix quoted string split across lines
by Joel Johnson 04 May '20

04 May '20

Update quoted string alignment to address checkpatch.pl warning originally introduced in commit f60a66ef5d7d ("cmd: mvebu: bubt: show image boot device"). Signed-off-by: Joel Johnson <mrjoel(a)lixil.net> --- I am sort of inferring that this is the desired fix, preferring line length infractions over split quoted strings. As such, I've combined the static part of the string for grepping and left the dynamic parts on the next line. v2 change: - syntax fix v3 change: - actually add syntax fix... --- cmd/mvebu/bubt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index dc0ce01c35..ef53153c46 100644 --- a/cmd/mvebu/bubt.c +++ b/cmd/mvebu/bubt.c @@ -730,8 +730,8 @@ static int bubt_check_boot_mode(const struct bubt_dev *dst) for (int i = 0; i < ARRAY_SIZE(a38x_boot_modes); i++) { if (a38x_boot_modes[i].id == hdr->blockid) { - printf("Error: A38x image meant to be " - "booted from \"%s\", not \"%s\"!\n", + printf("Error: A38x image meant to be booted from " + "\"%s\", not \"%s\"!\n", a38x_boot_modes[i].name, dst->name); return -ENOEXEC; } -- 2.26.2

3 3

[PATCH 1/5] imx8: power: Add PD device lookup interface to power domain uclass
by Peng Fan 04 May '20

04 May '20

Add power_domain_lookup_name interface to power domain uclass to find a power domain device by its DTB node name, not using its associated client device. Through this interface, we can operate the power domain devices directly. This is needed for non-DM drivers. Modified from Ye's NXP downstream patch only for legacy imx8 power domain driver, since we have not migrated to use new power domain driver. Signed-off-by: Ye Li <ye.li(a)nxp.com> Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- arch/arm/include/asm/arch-imx8/sys_proto.h | 7 +++++++ drivers/power/domain/imx8-power-domain-legacy.c | 28 +++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/arch/arm/include/asm/arch-imx8/sys_proto.h b/arch/arm/include/asm/arch-imx8/sys_proto.h index 0e981ae950..fc33e6ed18 100644 --- a/arch/arm/include/asm/arch-imx8/sys_proto.h +++ b/arch/arm/include/asm/arch-imx8/sys_proto.h @@ -5,6 +5,11 @@ #include <asm/arch/sci/sci.h> #include <asm/mach-imx/sys_proto.h> +#include <asm/arch/power-domain.h> +#include <dm/platdata.h> +#include <dm/device-internal.h> +#include <dm/device.h> +#include <power-domain.h> #include <linux/types.h> struct pass_over_info_t { @@ -21,3 +26,5 @@ void build_info(void); enum boot_device get_boot_device(void); int print_bootinfo(void); int sc_pm_setup_uart(sc_rsrc_t uart_rsrc, sc_pm_clock_rate_t clk_rate); +int imx8_power_domain_lookup_name(const char *name, + struct power_domain *power_domain); diff --git a/drivers/power/domain/imx8-power-domain-legacy.c b/drivers/power/domain/imx8-power-domain-legacy.c index 6f01a60b34..2c479744d3 100644 --- a/drivers/power/domain/imx8-power-domain-legacy.c +++ b/drivers/power/domain/imx8-power-domain-legacy.c @@ -19,6 +19,34 @@ struct imx8_power_domain_priv { bool state_on; }; +int imx8_power_domain_lookup_name(const char *name, + struct power_domain *power_domain) +{ + struct udevice *dev; + struct power_domain_ops *ops; + int ret; + + debug("%s(power_domain=%p name=%s)\n", __func__, power_domain, name); + + ret = uclass_get_device_by_name(UCLASS_POWER_DOMAIN, name, &dev); + if (ret) { + printf("%s fail: %s, ret = %d\n", __func__, name, ret); + return ret; + } + + ops = (struct power_domain_ops *)dev->driver->ops; + power_domain->dev = dev; + ret = ops->request(power_domain); + if (ret) { + debug("ops->request() failed: %d\n", ret); + return ret; + } + + debug("%s ok: %s\n", __func__, dev->name); + + return 0; +} + static int imx8_power_domain_request(struct power_domain *power_domain) { debug("%s(power_domain=%p)\n", __func__, power_domain); -- 2.16.4

2 6

[PATCH 2/2] arm: mvebu: ds414: define CONFIG_SYS_U_BOOT_OFFS
by Ezra Buehler 03 May '20

03 May '20

Without CONFIG_SYS_U_BOOT_OFFS set to CONFIG_SYS_SPI_U_BOOT_OFFS, U-Boot will be located at address 0x16000. SPL will load its payload from 0x24000 causing the boot to hang. Signed-off-by: Ezra Buehler <ezra(a)easyb.ch> --- include/configs/ds414.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/configs/ds414.h b/include/configs/ds414.h index e3693767b6..b179b99468 100644 --- a/include/configs/ds414.h +++ b/include/configs/ds414.h @@ -87,7 +87,10 @@ #define CONFIG_SPL_STACK (0x40000000 + ((192 - 16) << 10)) #define CONFIG_SPL_BOOTROM_SAVE (CONFIG_SPL_STACK + 4) +#if defined(CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI) /* SPL related SPI defines */ +#define CONFIG_SYS_U_BOOT_OFFS CONFIG_SYS_SPI_U_BOOT_OFFS +#endif /* DS414 bus width is 32bits */ #define CONFIG_DDR_32BIT -- 2.26.2

1 0