June 2019 - U-Boot

[U-Boot] [PATCH 0/4] efi_loader: correct image services
by Heinrich Schuchardt 11 Jun '19

11 Jun '19

This series corrects return codes in image services. Heinrich Schuchardt (4): efi_loader: LoadImage w/o SourceBuffer and DevicePath efi_loader: LoadImage must return EFI_NOT_FOUND efi_loader: loaded images cannot be started twice efi_loader: correct ExitBootServices() lib/efi_loader/efi_boottime.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) -- 2.20.1

1 4

[U-Boot] [PATCH v2 1/3] arm64: zynqmp: xil_io.h: declare functions as static
by Luca Ceresoli 11 Jun '19

11 Jun '19

Fixes sparse warnings when building zynqmp defconfigs: ./board/xilinx/zynqmp/xil_io.h:12:6: warning: symbol 'Xil_Out32' was not declared. Should it be static? ./board/xilinx/zynqmp/xil_io.h:17:5: warning: symbol 'Xil_In32' was not declared. Should it be static? ./board/xilinx/zynqmp/xil_io.h:22:6: warning: symbol 'usleep' was not declared. Should it be static? Also add __maybe_unused to usleep() since it is not used by minimized psu_init_gpl.c files, so it would warn as "defined but not used". Signed-off-by: Luca Ceresoli <luca(a)lucaceresoli.net> --- Chages v1 -> v2: - fix commit text (Michal) --- board/xilinx/zynqmp/xil_io.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/xilinx/zynqmp/xil_io.h b/board/xilinx/zynqmp/xil_io.h index c476c902ebcb..1c1bf32adaae 100644 --- a/board/xilinx/zynqmp/xil_io.h +++ b/board/xilinx/zynqmp/xil_io.h @@ -9,17 +9,17 @@ #define xil_printf(...) -void Xil_Out32(unsigned long addr, unsigned long val) +static void Xil_Out32(unsigned long addr, unsigned long val) { writel(val, addr); } -int Xil_In32(unsigned long addr) +static int Xil_In32(unsigned long addr) { return readl(addr); } -void usleep(u32 sleep) +static void __maybe_unused usleep(u32 sleep) { udelay(sleep); } -- 2.21.0

2 6

[U-Boot] [PATCH] ARM: bcm2835: (Raspberry Pi) Fix issue on SD Host driver, where wait_transfer_complete was not waiting long enough
by Raul Benet 11 Jun '19

11 Jun '19

Function bcm_2835_wait_transfer_complete() on driver/mmc/bcm2835_sdhost.c (used on Raspberry Pi platform), was not waiting long enough for transfer to complete. The previous code was claiming to wait for ~1 seconds, but my measurements on a RPi 3B+ indicated a maximum wait of 12 ms. Measured using get_tiimer() function. Some, but not all, of the cards we use, sometimes required wait times of ~56 ms to perform the command 'saveenv' on an EXT4 partition. (the exact operation being a CMD25 write of the superblock of EXT4). Re-implemented the loop exit condition to use get_timer() which allows to specify the wait time in more reliable manner. Set the maximum wait time to the originally intended 1 second. Signed-off by: Raul Benet <raul.benet_at_kaptivo.com> --- drivers/mmc/bcm2835_sdhost.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/bcm2835_sdhost.c b/drivers/mmc/bcm2835_sdhost.c index 1ce019a..96e06b8 100644 --- a/drivers/mmc/bcm2835_sdhost.c +++ b/drivers/mmc/bcm2835_sdhost.c @@ -234,7 +234,7 @@ static void bcm2835_reset_internal(struct bcm2835_host *host) static int bcm2835_wait_transfer_complete(struct bcm2835_host *host) { - int timediff = 0; + ulong tstart_ms = get_timer(0); while (1) { u32 edm, fsm; @@ -254,11 +254,12 @@ static int bcm2835_wait_transfer_complete(struct bcm2835_host *host) break; } - /* Error out after 100000 register reads (~1s) */ - if (timediff++ == 100000) { + /* Error out after ~1s */ + ulong tlapse_ms = get_timer(tstart_ms); + if ( tlapse_ms > 1000 /* ms */ ) { dev_err(host->dev, - "wait_transfer_complete - still waiting after %d retries\n", - timediff); + "wait_transfer_complete - still waiting after %lu ms\n", + tlapse_ms); bcm2835_dumpregs(host); return -ETIMEDOUT; } -- 2.7.4

1 0

[U-Boot] ARMv8 switching CPUs into EL1
by Mels van Broekhoven 11 Jun '19

11 Jun '19

L.S.! On a Xilinx ZynqMP-based platform with u-boot running in Aarch64 mode in EL2, after booting a Linux kernel in EL1 using CONFIG_ARMV8_SWITCH_TO_EL1, Linux throws a warning that the CPUs have started in inconsistent modes ("CPU: CPUs started in inconsistent modes"). Indeed, only the first core on which U-boot was running is switched to EL1 at this point. Is this a bug or a not completely supported feature in U-boot or can this warning actually be safely ignored under certain circumstances? Kind regards, Mels

4 3

[U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
by Heinrich Schuchardt 11 Jun '19

11 Jun '19

The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded. CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it. Suggested-by: David Wu <david.wu(a)rock-chips.com> Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails. The patch [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB https://lists.denx.de/pipermail/u-boot/2019-February/358883.html makes the problem visibe. --- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig index 68adf7635bf..03a7f81d63d 100644 --- a/configs/tinker-rk3288_defconfig +++ b/configs/tinker-rk3288_defconfig @@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y -- 2.20.1

5 5

[U-Boot] [PATCH 0/3] i.mx6 (sabre auto) fixes for 2019.07
by Sjoerd Simons 11 Jun '19

11 Jun '19

To make things easier i've split the `Enable usage of SDP for i.MX6 Sabre Auto Boards` patchset i sent yesterday up so it'll be hopefully easier to merge. The first two are the same as yesterday (Thanks Peng for the review). The last one is new and fixes regressions in usb gadget usage of various mx6 board that were converted to DM_USB. Sjoerd Simons (3): mx6sabreauto: Select pinctrl driver mx6sabreauto: set SYS_MALLOC_F for video arm: dts: imx6qdl-u-boot: Alias usb0 to usbotg arch/arm/dts/imx6qdl-u-boot.dtsi | 4 ++++ configs/mx6sabreauto_defconfig | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) -- 2.20.1

2 6

[U-Boot] [PATCH 1/2] imx: drop imx-regs.h
by sbabic＠denx.de 11 Jun '19

11 Jun '19

> imx-regs.h under arch-imx has no user, drop it. > Signed-off-by: Peng Fan <peng.fan(a)nxp.com> > Reviewed-by: Fabio Estevam <festevam(a)gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic(a)denx.de =====================================================================

1 0

[U-Boot] [PATCH] net: fec_mxc: not access reserved register on i.MX8
by sbabic＠denx.de 11 Jun '19

11 Jun '19

> We should not access reserved register on i.MX8, otherwise met SERROR > Signed-off-by: Peng Fan <peng.fan(a)nxp.com> > Acked-by: Joe Hershberger <joe.hershberger(a)ni.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic(a)denx.de =====================================================================

1 0

[U-Boot] [PATCH 2/2] imx: define ARCH_MXC for i.MX8/8M/7ULP
by sbabic＠denx.de 11 Jun '19

11 Jun '19

> Without this definition, fsl_esdhc will access reserved registers > on i.MX chips, so define ARCH_MXC to fix it. > Signed-off-by: Peng Fan <peng.fan(a)nxp.com> > Reviewed-by: Fabio Estevam <festevam(a)gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic(a)denx.de =====================================================================

1 0

[U-Boot] [PATCH] imx8mq_evk: Staticize when appropriate
by Fabio Estevam 11 Jun '19

11 Jun '19

Staticize 'spl_dram_init' and 'i2c_pad_info1' to fix the following sparse warnings: board/freescale/imx8mq_evk/spl.c:30:6: warning: symbol 'spl_dram_init' was not declared. Should it be static? board/freescale/imx8mq_evk/spl.c:41:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static? Signed-off-by: Fabio Estevam <festevam(a)gmail.com> --- board/freescale/imx8mq_evk/spl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/board/freescale/imx8mq_evk/spl.c b/board/freescale/imx8mq_evk/spl.c index e6cbc34b0d..3c0ff0bb1b 100644 --- a/board/freescale/imx8mq_evk/spl.c +++ b/board/freescale/imx8mq_evk/spl.c @@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR; extern struct dram_timing_info dram_timing_b0; -void spl_dram_init(void) +static void spl_dram_init(void) { /* ddr init */ if ((get_cpu_rev() & 0xfff) == CHIP_REV_2_1) @@ -38,7 +38,7 @@ void spl_dram_init(void) #define I2C_PAD_CTRL (PAD_CTL_DSE6 | PAD_CTL_HYS | PAD_CTL_PUE) #define PC MUX_PAD_CTRL(I2C_PAD_CTRL) -struct i2c_pads_info i2c_pad_info1 = { +static struct i2c_pads_info i2c_pad_info1 = { .scl = { .i2c_mode = IMX8MQ_PAD_I2C1_SCL__I2C1_SCL | PC, .gpio_mode = IMX8MQ_PAD_I2C1_SCL__GPIO5_IO14 | PC, -- 2.17.1

3 2