March 2019 - U-Boot

[U-Boot] [PATCH v2 1/1] efi_loader: memory leak in efi_dump_single_var()
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

A misplaced return statement lead to a memory leak in efi_dump_single_var(). Reported-by: Coverity (CID 185829) Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 change commit message to show Reported-by: Coverity --- cmd/nvedit_efi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/nvedit_efi.c b/cmd/nvedit_efi.c index ca32566a615..e65b38dbf39 100644 --- a/cmd/nvedit_efi.c +++ b/cmd/nvedit_efi.c @@ -80,7 +80,6 @@ static void efi_dump_single_var(u16 *name, efi_guid_t *guid) printf(", DataSize = 0x%zx\n", size); print_hex_dump(" ", DUMP_PREFIX_OFFSET, 16, 1, data, size, true); - return; out: free(data); } -- 2.20.1

1 0

[U-Boot] [PATCH v2 1/1] efi_loader: endless loop in add_strings_package()
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

Avoid an endless loop in add_strings_package(). Suggested-by: Takahiro Akashi <takahiro.akashi(a)linaro.org> Reported-by: Coverity (CID 185833) Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 change commit message to show Reported-by: Coverity --- lib/efi_loader/efi_hii.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c index 3a966fa4dff..61b71dec621 100644 --- a/lib/efi_loader/efi_hii.c +++ b/lib/efi_loader/efi_hii.c @@ -227,9 +227,8 @@ out: error: if (stbl) { free(stbl->language); - if (idx > 0) - while (--idx >= 0) - free(stbl->strings[idx].string); + while (idx > 0) + free(stbl->strings[--idx].string); free(stbl->strings); } free(stbl); -- 2.20.1

1 0

[U-Boot] [PATCH] p2371-2180: Build position independent binary
by Thierry Reding 20 Mar '19

20 Mar '19

From: Thierry Reding <treding(a)nvidia.com> In order to support chainloading of U-Boot by an earlier bootloader, make sure the binary is position independent, so that the earlier boot- loader can relocate it if necessary. Signed-off-by: Thierry Reding <treding(a)nvidia.com> --- configs/p2371-2180_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/p2371-2180_defconfig b/configs/p2371-2180_defconfig index b66459e379ac..8d7cf3fb5346 100644 --- a/configs/p2371-2180_defconfig +++ b/configs/p2371-2180_defconfig @@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TEGRA=y CONFIG_SYS_TEXT_BASE=0x80110000 +CONFIG_POSITION_INDEPENDENT=y CONFIG_TEGRA210=y CONFIG_TARGET_P2371_2180=y CONFIG_NR_DRAM_BANKS=2 -- 2.20.1

2 5

[U-Boot] Secure Boot nand on IMX6DL
by Michael Nazzareno Trimarchi 20 Mar '19

20 Mar '19

Hi all I'm trying to enable secure boot on nand but seems that SPL does not start at all. Any help? I'm using latest uboot Michael -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com |

1 0

[U-Boot] Please pull u-boot-marvell/master
by Stefan Roese 20 Mar '19

20 Mar '19

Hi Tom, please pull the following Marvell related patches, mostly fixes which should go into the upcoming release: ---------------------------------------------------------------- - Enable network interface on clearfog_gt_8k (Baruch) - Fix dreamplug boot by adding an spi0 alias to the DT (Chris) - Fix / enhance Marvell ddr3 setup / parameters (Chris) - Change CONFIG_SYS_MALLOC_F_LEN to 0x2000 on db-88f6820-amc (Chris) - Enable SPL_FLASH_BAR on db-88f6820-amc (Chris) - Use correct pcie controller name in Armada-38x dts files (Chris) - Disable d-cache on Kirkwood platforms as currently needed (Chris) - Add a more descriptive comment to pci_mvebu.c (Stefan) - Update Marvell maintainers entry (Stefan) ---------------------------------------------------------------- Thanks, Stefan The following changes since commit 374bf7af033aa326a9585c5ff878d206e90c0c1c: Prepare v2019.04-rc4 (2019-03-18 21:14:02 -0400) are available in the Git repository at: git://www.denx.de/git/u-boot-marvell.git for you to fetch changes up to 599f7aa541bb5a658cbfd2af73bd9d2f6e828d43: ARM: kirkwood: disable dcache for Kirkwood boards (2019-03-19 09:22:05 +0100) ---------------------------------------------------------------- Baruch Siach (1): configs/clearfog_gt_8k: add network interface support Chris Packham (7): ARM: kirkwood: add spi0 alias for dreamplug mv_ddr: ddr3: fix tRAS timimg parameter mv_ddr: ddr3: only use active chip-selects when tuning ODT ARM: mvebu: set CONFIG_SYS_MALLOC_F_LEN to 0x2000 ARM: mvebu: db-88f6820-amc: enable SPI_FLASH_BAR ARM: mvebu: use correct name for pcie controller ARM: kirkwood: disable dcache for Kirkwood boards Stefan Roese (2): pci: pci_mvebu: Add comment about missing of_n_addr_cells() call MAINTAINERS: Update u-boot-marvell entry MAINTAINERS | 11 +++++++---- arch/arm/dts/armada-385-amc.dts | 2 +- arch/arm/dts/armada-385-turris-omnia.dts | 2 +- arch/arm/dts/armada-388-clearfog.dts | 2 +- arch/arm/dts/armada-388-gp.dts | 2 +- arch/arm/dts/armada-38x-controlcenterdc.dts | 2 +- arch/arm/dts/kirkwood-dreamplug.dts | 4 ++++ arch/arm/mach-kirkwood/include/mach/config.h | 6 ++++++ configs/clearfog_gt_8k_defconfig | 4 +++- configs/db-88f6820-amc_defconfig | 2 ++ drivers/ddr/marvell/a38x/ddr3_training_db.c | 8 ++++---- drivers/ddr/marvell/a38x/ddr3_training_hw_algo.c | 3 ++- drivers/pci/pci_mvebu.c | 6 ++++++ 13 files changed, 39 insertions(+), 15 deletions(-)

2 1

[U-Boot] Sunxi H5 and CONFIG_ENV_IS_IN_MMC problem
by g4＠novadsp.com 20 Mar '19

20 Mar '19

Greetings Our board has an AllWinner H5 with SPI flash and eMMC. Since SPI flash support for 'saveenv' is not currently mainline, I thought I'd simply use one of the eMMC boot blocks to persist the environment. However I keep running into image size problems [1] Not being a U-Boot ninja, the defconfig [2] is about as minimal as I believe I can make it. (Network support is required for TFTP/NFS operations) Does the panel have any suggestions for getting the desired configuration built? MTIA. Jerry. --------------------------------snip---------------------------------------- -- [1] MKSUNXI spl/sunxi-spl.bin MKIMAGE u-boot.img MKIMAGE u-boot-dtb.img /home/moi/src/u-boot/denx/"board/sunxi/mksunxi_fit_atf.sh" \ arch/arm/dts/anemos-sc5.dtb > u-boot.its MKIMAGE u-boot.itb u-boot.itb exceeds file size limit: limit: 516096 bytes actual: 519448 bytes excess: 3352 bytes /home/moi/src/u-boot/denx/Makefile:1204: recipe for target 'u-boot.itb' failed ----------------------------snip------------------------------------------ [2] CONFIG_ARM=y CONFIG_ARCH_SUNXI=y CONFIG_SPL=y CONFIG_MACH_SUN50I_H5=y CONFIG_DRAM_CLK=504 CONFIG_DRAM_ZQ=3881977 CONFIG_DRAM_ODT_EN=y CONFIG_MACPWR="PD6" CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_SPL_SPI_SUNXI=y CONFIG_SPL_SPI_FLASH_SUPPORT=y CONFIG_SPL_SPI_FLASH_TINY=y CONFIG_DEFAULT_DEVICE_TREE="anemos-sc5" CONFIG_ENV_IS_IN_MMC=y CONFIG_NET_RANDOM_ETHADDR=y CONFIG_MTD=y CONFIG_MTD_DEVICE=y CONFIG_SUN8I_EMAC=y CONFIG_USB_EHCI_HCD=y CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y

2 2

[U-Boot] [PATCH 1/1] efi_loader: correct parameter size in efi_allocate_pool
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

efi_allocate_pages() expects a (uint64_t *) pointer to pass the address of the assigned memory. If we pass the address of a pointer here, an illegal memory access occurs on 32bit systems. Fixes: 282a06cbcae8 ("efi_loader: Expose U-Boot addresses in memory map for sandbox") Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_loader/efi_memory.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index ebd2b36c03..55622d2fb4 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -440,6 +440,7 @@ efi_status_t efi_free_pages(uint64_t memory, efi_uintn_t pages) efi_status_t efi_allocate_pool(int pool_type, efi_uintn_t size, void **buffer) { efi_status_t r; + u64 addr; struct efi_pool_allocation *alloc; u64 num_pages = efi_size_in_pages(size + sizeof(struct efi_pool_allocation)); @@ -453,9 +454,9 @@ efi_status_t efi_allocate_pool(int pool_type, efi_uintn_t size, void **buffer) } r = efi_allocate_pages(EFI_ALLOCATE_ANY_PAGES, pool_type, num_pages, - (uint64_t *)&alloc); - + &addr); if (r == EFI_SUCCESS) { + alloc = (struct efi_pool_allocation *)(uintptr_t)addr; alloc->num_pages = num_pages; *buffer = alloc->data; } -- 2.20.1

2 4

[U-Boot] [PATCH v3 0/3] Add Ethernet support for Poplar board
by Shawn Guo 20 Mar '19

20 Mar '19

The series adds Ethernet support for Poplar board. It firstly creates a reset driver for HiSilicon platform, then introduces higmacv300 Ethernet driver, and finally enables Ethernet support for Poplar board. Changes for v3: - Add polarity support into reset driver, so that we can drop the hacking on gmac reset sequence from higmacv300 driver. Changes for v2: - Rename driver symbol to HIGMACV300_ETH. - Remove the use of temp variable 'addr' in higmac_recv(). - Simplify the return of function higmac_ofdata_to_platdata() and higmac_probe(). - Combine delaration and initialization for phyintf in function higmac_ofdata_to_platdata(). - Eliminate the MDIO read/write macros. - Use wait_for_bit_le32() for MDIO command completion polling. - Set up RX packet buffers in RX_FQ descriptor at initialization time, so that we do not need to allocate/free packet buffers repeatedly. - Inform GMAC that the RX descriptor is no longer in use in function higmac_free_pkt(). - Define BITS_DESC_ENA instead of using magic number 0xf. Shawn Guo (3): reset: add reset driver for HiSilicon platform net: add higmacv300 Ethernet driver for HiSilicon platform poplar: enable Ethernet driver support arch/arm/dts/hi3798cv200-u-boot.dtsi | 14 + configs/poplar_defconfig | 3 + drivers/net/Kconfig | 9 + drivers/net/Makefile | 1 + drivers/net/higmacv300.c | 597 +++++++++++++++++++++++++++ drivers/reset/Kconfig | 6 + drivers/reset/Makefile | 1 + drivers/reset/reset-hisilicon.c | 111 +++++ 8 files changed, 742 insertions(+) create mode 100644 drivers/net/higmacv300.c create mode 100644 drivers/reset/reset-hisilicon.c -- 2.18.0

2 9

[U-Boot] [PULL] u-boot-socfpga/master
by Marek Vasut 19 Mar '19

19 Mar '19

The following changes since commit 9659eb46af6249b6e4b3712e60a1eb2e87fc48a1: Merge branch 'master' of git://git.denx.de/u-boot-samsung (2019-03-14 11:37:11 -0400) are available in the Git repository at: git://git.denx.de/u-boot-socfpga.git master for you to fetch changes up to 92a47459bb85ba3e835b11ddbdcdfb571280614f: arm: socfpga: make SPL_TEXT_BASE overridable (2019-03-16 13:30:09 +0100) ---------------------------------------------------------------- Ley Foon Tan (1): ARM: dts: socfpga: Add missing altr,sysmgr-syscon for EMAC Simon Goldschmidt (1): arm: socfpga: make SPL_TEXT_BASE overridable arch/arm/dts/socfpga_stratix10.dtsi | 3 +++ include/configs/socfpga_common.h | 2 ++ 2 files changed, 5 insertions(+)

2 1

[U-Boot] [PULL] u-boot-usb/master
by Marek Vasut 19 Mar '19

19 Mar '19

The following changes since commit 9659eb46af6249b6e4b3712e60a1eb2e87fc48a1: Merge branch 'master' of git://git.denx.de/u-boot-samsung (2019-03-14 11:37:11 -0400) are available in the Git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to f402d268e8e17e9d6d1d9bf8a8b1f6e0b07718ef: fastboot: common: fix default fastboot_boot on 64-bit (2019-03-16 13:29:43 +0100) ---------------------------------------------------------------- Jean-Jacques Hiblot (1): usb: udc-uclass: Fixed problem when no alias is defined in DT Neil Armstrong (1): fastboot: common: fix default fastboot_boot on 64-bit Sean Nyekjaer (1): cmd: fastboot: handle watchdog while waiting for fastboot commands. cmd/fastboot.c | 2 ++ drivers/fastboot/fb_common.c | 2 +- drivers/usb/gadget/udc/udc-uclass.c | 7 +++++-- 3 files changed, 8 insertions(+), 3 deletions(-)

2 1