March 2019 - U-Boot

[U-Boot] [PATCH] i2c: i2c_cdns: Fix below warnings with checker tool
by Michal Simek 21 Mar '19

21 Mar '19

From: Siva Durga Prasad Paladugu <siva.durga.paladugu(a)xilinx.com> This patch fixes below warnings found with checker tool. The variable len in i2c_msg struct is of unsigned type and it is received as recv_count which is unsigned type but it is checked with < 0 which is always false, hence removed it. The local variable curr_recv_count is declared as signed type and compared aginst unsigned recv_count which is incorrect. This is fixed by declaring it as unsigned type. drivers/i2c/i2c-cdns.c: In function ‘cdns_i2c_read_data’: drivers/i2c/i2c-cdns.c:317:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if ((recv_count < 0)) ^ drivers/i2c/i2c-cdns.c:340:24: warning: comparison of integer expressions of different signedness: ‘u32’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare] updatetx = recv_count > curr_recv_count; ^ drivers/i2c/i2c-cdns.c:361:39: warning: comparison of integer expressions of different signedness: ‘u32’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare] while (readl(&regs->transfer_size) != Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.paladugu(a)xilinx.com> Signed-off-by: Michal Simek <michal.simek(a)xilinx.com> --- drivers/i2c/i2c-cdns.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-cdns.c b/drivers/i2c/i2c-cdns.c index 1af94d176145..2c0301ad083a 100644 --- a/drivers/i2c/i2c-cdns.c +++ b/drivers/i2c/i2c-cdns.c @@ -308,14 +308,10 @@ static int cdns_i2c_read_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data, { u8 *cur_data = data; struct cdns_i2c_regs *regs = i2c_bus->regs; - int curr_recv_count; + u32 curr_recv_count; int updatetx, hold_quirk; u32 ret; - /* Check the hardware can handle the requested bytes */ - if ((recv_count < 0)) - return -EINVAL; - curr_recv_count = recv_count; /* Check for the message size against the FIFO depth */ -- 1.9.1

2 2

[U-Boot] Update git on git.denx.de
by Heinrich Schuchardt 21 Mar '19

21 Mar '19

Hello Wolfgang, when fetching from git.denx.de I got: $ git remote add efi ssh://gu-efi@git.denx.de/u-boot-efi.git $ git fetch efi Enter passphrase for key '/home/user/.ssh/id_rsa.denx': fatal: protocol error: expected old/new/ref, got 'want d0bd87612f410a723d5ddb3001e805485e3efb4f side-band-64k ofs-delta agent=git/2.20.1' Could you, please, consider upgrading the git server to a current version. The version installed on git.denx.de dates from March 17th, 2016:   Current version is 2.21.0. Best regards Heinrich

1 0

[U-Boot] [PATCH 00/10] Update Stratix 10 SDRAM driver
by Ley Foon Tan 21 Mar '19

21 Mar '19

This patchset update Stratix 10 SDRAM driver to support: - Multi-banks memory (Patch [1-8]) - Stratix 10 support up to 2 memory banks: Bank 0: Address 0, size 2GB Bank 1: Address 0x100000000, size 124GB - Add warm reset boot checking function, to use in patch [10] (Patch[9]) - Add ECC memory scrubbing support (Patch [10]) - Use cache enabled + "DC ZVA" instruction to clear memory to zeros Ley Foon Tan (10): ddr: altera: stratix10: Move SDRAM size check to SDRAM driver arm: socfpga: Add sdram_s10.h to sdram.h ddr: altera: s10: Add multiple memory banks support arm: socfpga: Update dram_init_banksize() for Stratix10 board: altera: Stratix10: Add board_get_usable_ram_top() board: altera: Stratix10: Add ft_board_setup() arm: socfpga: Enable OF_BOARD_SETUP for Stratix 10 configs: stratix10: Change CONFIG_NR_DRAM_BANKS to 2 arm: socfpga: stratix10: Add cpu_has_been_warmreset() ddr: altera: Stratix10: Add ECC memory scrubbing arch/arm/mach-socfpga/Kconfig | 1 + arch/arm/mach-socfpga/board.c | 16 +- .../include/mach/reset_manager_s10.h | 3 + arch/arm/mach-socfpga/include/mach/sdram.h | 2 + .../arm/mach-socfpga/include/mach/sdram_s10.h | 10 + arch/arm/mach-socfpga/reset_manager_s10.c | 9 + arch/arm/mach-socfpga/spl_s10.c | 11 -- board/altera/stratix10-socdk/socfpga.c | 37 ++++ configs/socfpga_stratix10_defconfig | 2 +- drivers/ddr/altera/sdram_s10.c | 178 ++++++++++++++++++ 10 files changed, 256 insertions(+), 13 deletions(-) -- 2.19.0

5 38

[U-Boot] [PATCH v4] usb: host: Print device name when scanning
by Ismael Luceno Cortes 21 Mar '19

21 Mar '19

Drop the counter, it has no meaning other than being the order in which the interface is found; the name assigned to the USB host controller interface is a better indicator. Example of the original output: > USB0: USB EHCI 1.10 > scanning bus 0 for devices... 2 USB Device(s) found > scanning usb for storage devices... 1 Storage Device(s) found Patched output: > Bus usb@ee080100: USB EHCI 1.10 > scanning bus usb@ee080100 for devices... 2 USB Device(s) found > scanning usb for storage devices... 1 Storage Device(s) found Signed-off-by: Ismael Luceno <ismael.luceno(a)silicon-gears.com> --- Notes: Changes since v3: - Replaced dev->seq with dev->name in usb_scan_bus Changes since v2: - Dropped counter altogether. Changes since v1: - Improved commit message. drivers/usb/host/usb-uclass.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c index 611ea97a72..6e118b5a8f 100644 --- a/drivers/usb/host/usb-uclass.c +++ b/drivers/usb/host/usb-uclass.c @@ -210,7 +210,7 @@ static void usb_scan_bus(struct udevice *bus, bool recurse) assert(recurse); /* TODO: Support non-recusive */ - printf("scanning bus %d for devices... ", bus->seq); + printf("scanning bus %s for devices... ", bus->name); debug("\n"); ret = usb_scan_device(bus, 0, USB_SPEED_FULL, &dev); if (ret) @@ -242,7 +242,6 @@ int usb_init(void) struct usb_bus_priv *priv; struct udevice *bus; struct uclass *uc; - int count = 0; int ret; asynch_allowed = 1; @@ -255,8 +254,7 @@ int usb_init(void) uclass_foreach_dev(bus, uc) { /* init low_level USB */ - printf("USB%d: ", count); - count++; + printf("Bus %s: ", bus->name); #ifdef CONFIG_SANDBOX /* @@ -327,10 +325,8 @@ int usb_init(void) remove_inactive_children(uc, bus); /* if we were not able to find at least one working bus, bail out */ - if (!count) - printf("No controllers found\n"); - else if (controllers_initialized == 0) - printf("USB error: all controllers failed lowlevel init\n"); + if (controllers_initialized == 0) + printf("No working controllers found\n"); return usb_started ? 0 : -1; } base-commit: 9ba5e5bc261a16f51662490da0cf620dc7f29013 prerequisite-patch-id: 8ebbc14087da985e5db35ef02335fbfdb4add60a -- 2.19.1

2 1

[U-Boot] [PATCH v2] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
by Dalon Westergreen 21 Mar '19

21 Mar '19

From: Dalon Westergreen <dalon.westergreen(a)intel.com> The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10 devices. The file should only be built for these devices. Signed-off-by: Dalon Westergreen <dalon.westergreen(a)intel.com> --- Changes from v1: -> Remove duplicate entries for GEN5 and ARRIA10 --- Kconfig | 3 ++- scripts/Makefile.spl | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Kconfig b/Kconfig index 512c7beb89..305b265ed7 100644 --- a/Kconfig +++ b/Kconfig @@ -226,7 +226,8 @@ config BUILD_ROM config BUILD_TARGET string "Build target special images" - default "u-boot-with-spl.sfp" if ARCH_SOCFPGA + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10 + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5 default "u-boot-spl.kwb" if ARCH_MVEBU && SPL default "u-boot-elf.srec" if RCAR_GEN3 default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 9d5921606e..54b160d72b 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -212,7 +212,7 @@ ifdef CONFIG_SAMSUNG ALL-y += $(obj)/$(BOARD)-spl.bin endif -ifdef CONFIG_ARCH_SOCFPGA +ifneq ($(CONFIG_TARGET_SOCFPGA_GEN5)$(CONFIG_TARGET_SOCFPGA_ARRIA10),) ALL-y += $(obj)/$(SPL_BIN).sfp endif -- 2.20.1

2 1

[U-Boot] [PATCH] ARM: socfpga: Build sfp image only for Gen5 and Arria10 devices
by Dalon Westergreen 20 Mar '19

20 Mar '19

From: Dalon Westergreen <dalon.westergreen(a)intel.com> The sfp file is only valid for Gen5 (Cyclone5 & Arria5) and Arria10 devices. The file should only be built for these devices. Signed-off-by: Dalon Westergreen <dalon.westergreen(a)intel.com> --- Kconfig | 3 ++- scripts/Makefile.spl | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Kconfig b/Kconfig index 512c7beb89..305b265ed7 100644 --- a/Kconfig +++ b/Kconfig @@ -226,7 +226,8 @@ config BUILD_ROM config BUILD_TARGET string "Build target special images" - default "u-boot-with-spl.sfp" if ARCH_SOCFPGA + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_ARRIA10 + default "u-boot-with-spl.sfp" if TARGET_SOCFPGA_GEN5 default "u-boot-spl.kwb" if ARCH_MVEBU && SPL default "u-boot-elf.srec" if RCAR_GEN3 default "u-boot.itb" if SPL_LOAD_FIT && ARCH_SUNXI diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 9d5921606e..592c5dfe57 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -212,7 +212,11 @@ ifdef CONFIG_SAMSUNG ALL-y += $(obj)/$(BOARD)-spl.bin endif -ifdef CONFIG_ARCH_SOCFPGA +ifdef CONFIG_TARGET_SOCFPGA_ARRIA10 +ALL-y += $(obj)/$(SPL_BIN).sfp +endif + +ifdef CONFIG_TARGET_SOCFPGA_GEN5 ALL-y += $(obj)/$(SPL_BIN).sfp endif -- 2.20.1

3 2

[U-Boot] [PATCH 1/1] MAINTAINERS: adjust git repository for EFI PAYLOAD
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

The EFI PAYLOAD will use git://git.denx.de/u-boot-efi.git in future. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8a4c5d4eabd..3166ec74f0c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -454,7 +454,7 @@ EFI PAYLOAD M: Heinrich Schuchardt <xypron.glpk(a)gmx.de> R: Alexander Graf <agraf(a)csgraf.de> S: Maintained -T: git git://github.com/agraf/u-boot.git +T: git git://git.denx.de/u-boot-efi.git F: doc/README.uefi F: doc/README.iscsi F: Documentation/efi.rst -- 2.20.1

1 0

[U-Boot] [PATCH 1/3] mx7: Do not call lcdif_power_down() in the SPL case
by Otavio Salvador 20 Mar '19

20 Mar '19

From: Fabio Estevam <festevam(a)gmail.com> Like it was done on imx6 in commit 9236269de57d ("imx: mx6: Fix implementantion reset_misc") Do not call lcdif_power_down() in the SPL case to fix the following build error: LD spl/u-boot-spl MKIMAGE u-boot.img arch/arm/mach-imx/built-in.o: In function `reset_misc': /home/fabio/ossystems/u-boot/arch/arm/mach-imx/mx7/soc.c:372: undefined reference to `lcdif_power_down' scripts/Makefile.spl:375: recipe for target 'spl/u-boot-spl' failed Signed-off-by: Fabio Estevam <festevam(a)gmail.com> Signed-off-by: Otavio Salvador <otavio(a)ossystems.com.br> --- arch/arm/mach-imx/mx7/soc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-imx/mx7/soc.c b/arch/arm/mach-imx/mx7/soc.c index 3f74f8a3ed..7cfdff0981 100644 --- a/arch/arm/mach-imx/mx7/soc.c +++ b/arch/arm/mach-imx/mx7/soc.c @@ -368,8 +368,10 @@ void s_init(void) void reset_misc(void) { +#ifndef CONFIG_SPL_BUILD #ifdef CONFIG_VIDEO_MXS lcdif_power_down(); #endif +#endif } -- 2.20.0

4 7

[U-Boot] [PATCH v2 1/1] efi_loader: remove superfluous check in efi_setup_loaded_image()
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

It does not make any sense to check if a pointer is NULL if we have dereferenced it before. Reported-by: Coverity (CID 185827) Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 change commit message to show Reported-by: Coverity --- lib/efi_loader/efi_boottime.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index bd8b8a17ae7..4fc550d9f37 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -1581,10 +1581,8 @@ efi_status_t efi_setup_loaded_image(struct efi_device_path *device_path, goto failure; #endif - if (info_ptr) - *info_ptr = info; - if (handle_ptr) - *handle_ptr = obj; + *info_ptr = info; + *handle_ptr = obj; return ret; failure: -- 2.20.1

1 0

[U-Boot] [PATCH v2 1/1] efi_loader: missing return in efi_get_next_variable_name()
by Heinrich Schuchardt 20 Mar '19

20 Mar '19

Add a missing return statement in efi_get_next_variable_name(). Reported-by: Coverity (CID 185834) Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- v2 change commit message to show Reported-by: Coverity --- lib/efi_loader/efi_variable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c index e0d7f5736db..699f4184d93 100644 --- a/lib/efi_loader/efi_variable.c +++ b/lib/efi_loader/efi_variable.c @@ -335,7 +335,7 @@ efi_status_t EFIAPI efi_get_next_variable_name(efi_uintn_t *variable_name_size, EFI_ENTRY("%p \"%ls\" %pUl", variable_name_size, variable_name, vendor); if (!variable_name_size || !variable_name || !vendor) - EFI_EXIT(EFI_INVALID_PARAMETER); + return EFI_EXIT(EFI_INVALID_PARAMETER); if (variable_name[0]) { /* check null-terminated string */ -- 2.20.1

1 0