November 2019 - U-Boot

[U-Boot] [PATCH v3 0/5] Add support for MediaTek MT8518 Soc
by mingming lee 04 Dec '19

04 Dec '19

This patch series adds basic boot support on eMMC for the MediaTek MT8518 SoC based boards. This series add the clock, pinctrl drivers and the SoC initializaton code. --- Changes for v3: - Fix top clock register definition which cause unused warning. - Change hs400 to hs200 since the dts is hs200 - Fixed all build warnings using gcc version 740 Changes for v2: - Fixed issues in v1: drop unused 'devices',delete no need code and print debug log using debug() - Delete unnecessary configs in defconfig - Adjust the mmc tuning flow to support HS400 mingming lee (5): ARM: MediaTek: Add support for MediaTek MT8518 SoC clk: mediatek: add driver for MT8518 mmc: mtk-sd: Adjust the mmc tuning flow pinctrl: add driver for MT8518 ARM: MediaTek: add basic support for MT8518 boards arch/arm/dts/Makefile | 3 +- arch/arm/dts/mt8518-ap1-emmc.dts | 104 ++ arch/arm/dts/mt8518.dtsi | 98 ++ arch/arm/mach-mediatek/Kconfig | 10 + arch/arm/mach-mediatek/Makefile | 1 + arch/arm/mach-mediatek/mt8518/Makefile | 4 + arch/arm/mach-mediatek/mt8518/init.c | 71 + arch/arm/mach-mediatek/mt8518/lowlevel_init.S | 32 + board/mediatek/mt8518/Kconfig | 14 + board/mediatek/mt8518/MAINTAINERS | 6 + board/mediatek/mt8518/Makefile | 3 + board/mediatek/mt8518/mt8518_ap1.c | 18 + configs/mt8518_ap1_emmc_defconfig | 41 + drivers/clk/mediatek/Makefile | 1 + drivers/clk/mediatek/clk-mt8518.c | 1558 +++++++++++++++++ drivers/mmc/mtk-sd.c | 209 ++- drivers/pinctrl/mediatek/Kconfig | 4 + drivers/pinctrl/mediatek/Makefile | 1 + drivers/pinctrl/mediatek/pinctrl-mt8518.c | 411 +++++ include/configs/mt8518.h | 68 + include/dt-bindings/clock/mt8518-clk.h | 249 +++ 21 files changed, 2889 insertions(+), 17 deletions(-) create mode 100644 arch/arm/dts/mt8518-ap1-emmc.dts create mode 100644 arch/arm/dts/mt8518.dtsi create mode 100644 arch/arm/mach-mediatek/mt8518/Makefile create mode 100644 arch/arm/mach-mediatek/mt8518/init.c create mode 100644 arch/arm/mach-mediatek/mt8518/lowlevel_init.S create mode 100644 board/mediatek/mt8518/Kconfig create mode 100644 board/mediatek/mt8518/MAINTAINERS create mode 100644 board/mediatek/mt8518/Makefile create mode 100644 board/mediatek/mt8518/mt8518_ap1.c create mode 100644 configs/mt8518_ap1_emmc_defconfig create mode 100644 drivers/clk/mediatek/clk-mt8518.c create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8518.c create mode 100644 include/configs/mt8518.h create mode 100644 include/dt-bindings/clock/mt8518-clk.h -- 2.23.0

2 10

[U-Boot] Raspberry Pi Compute Module 1 mini-UART
by edrose 03 Dec '19

03 Dec '19

Hi, I'm working on a project that uses the Raspberry Pi Compute Module 1. Much like the CM 3, the CM 1 has two UART interfaces - the main UART at ttyAMA0, and a second "mini-UART" at ttyS0. The project uses the main UART since it works better at high speeds, so the console has been bumped over to the mini-UART. This works fine for kernel messages and as a TTY console for logging in and interacting with the device, however I've been unable to get u-boot to present it's console over the mini-UART. I've worked deep enough into this to know that u-boot doesn't use the device tree that is set-up in config.txt, so the parameters that I've put in there to activate and remap the mini-UART (UART1 in dts files) to pins 40/41 doesn't apply to u-boot. I'm using the bcm2835-rpi-b dts file currently since it's the best fit for the hardware, but it leaves the mini-UART port disabled. I've tried playing around with the dts files to enable/remap the mini-UART port however I've been unsuccessful. Can anyone give me any pointers as to how I modify the dts files to enable and map the second UART for u-boot to be able to use it? Kindest regards, Ed -- Sent from: http://u-boot.10912.n7.nabble.com/

2 4

[U-Boot] [PATCH] tools/imximage: fix reported DCD information for MX7ULP
by Jorge Ramirez-Ortiz 03 Dec '19

03 Dec '19

On the MX7ULP, OCRAM for DCD is at 0x2f010000 Signed-off-by: Jorge Ramirez-Ortiz <jorge(a)foundries.io> --- tools/imximage.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/imximage.c b/tools/imximage.c index d7c0b6e883..762a06d468 100644 --- a/tools/imximage.c +++ b/tools/imximage.c @@ -11,6 +11,7 @@ #include "imagetool.h" #include <image.h> #include "imximage.h" +#include <generated/autoconf.h> #define UNDEFINED 0xFFFFFFFF @@ -524,8 +525,13 @@ static void print_hdr_v2(struct imx_header *imx_hdr) printf("HAB Blocks: 0x%08x 0x%08x 0x%08x\n", (uint32_t)fhdr_v2->self, 0, (uint32_t)(fhdr_v2->csf - fhdr_v2->self)); +#ifndef CONFIG_MX7ULP printf("DCD Blocks: 0x00910000 0x%08x 0x%08x\n", offs, be16_to_cpu(dcdlen)); +#else + printf("DCD Blocks: 0x2f010000 0x%08x 0x%08x\n", + offs, be16_to_cpu(dcdlen)); +#endif } } else { imx_header_v2_t *next_hdr_v2; -- 2.17.1

4 4

[U-Boot] [PATCH v3 0/2] imx6ull: Fix missing initial output from UART
by Igor Opaniuk 03 Dec '19

03 Dec '19

For Colibri iMX6ULL we have to set pinmux for uart configuration ASAP (ideally before relocation) to get serial console working. Without this we miss almost the half of output (U-boot version, CPU defails, Reset cause, DRAM details etc.). To achieve this we need to force pinctrl-mx6 to get probed before relocation (is already applied) and add u-boot,dm-pre-reloc properties to uart pinmux configuration nodes. Setting pinmux configuration for UART before was done in board_early_init_f(). Igor Opaniuk (2): ARM: dts: imx6ull-colibri: change hierarchy of DTS files ARM: dts: imx6ull-colibri: pre-reloc for uart pinmux modes v3: - Applied R-b tags [Fabio Estevam], [Oleksandr Suvorov]. - Rebased on the latest u-boot-imx/master. - Excluded from patch series c115cd154c("pinctrl: nxp: DM_FLAG_PRE_RELOC by default") as it was already applied by Stefano (https://patchwork.ozlabs.org/patch/1136382/). v2: - Addressed comments [Fabio Estevam]. arch/arm/dts/imx6ull-colibri-u-boot.dtsi | 12 + arch/arm/dts/imx6ull-colibri.dts | 628 +-------------------- arch/arm/dts/imx6ull-colibri.dtsi | 633 ++++++++++++++++++++++ board/toradex/colibri-imx6ull/MAINTAINERS | 2 + 4 files changed, 649 insertions(+), 626 deletions(-) create mode 100644 arch/arm/dts/imx6ull-colibri-u-boot.dtsi create mode 100644 arch/arm/dts/imx6ull-colibri.dtsi -- 2.17.1

4 11

[U-Boot] [PATCH v2 0/4] mtd: spi: spi-nor-core: Add SST vendor specific SFDP parser
by Tudor.Ambarus＠microchip.com 03 Dec '19

03 Dec '19

From: Tudor Ambarus <tudor.ambarus(a)microchip.com> Parse manufacturer specific SFDP table. The SST SFDP table contains pre-programmed globally unique MAC addresses. Retrieve the MAC address from the SPI NOR flash and set it in ethaddr in env. v2: - s/SFDP_MICROCHIP_ID/SFDP_SST_ID - don't drop all information we extracted from BFPT if optional table parsers fail. In case of failing, each optional SFDP parser is responsible to roll back to the previously known spi_nor data. Tudor Ambarus (4): mtd: spi: spi-nor-core: Add SST vendor specific SFDP parser board: atmel: sama5d27_wlsom1_ek: Set ethaddr from spi-nor flash configs: sama5d27_wlsom1_ek: qspiflash: Enable SPI NOR ethaddr retrieval configs: sama5d27_wlsom1_ek: mmc: Enable SPI NOR ethaddr retrieval arch/arm/mach-at91/include/mach/at91_common.h | 1 + board/atmel/common/Makefile | 1 + board/atmel/common/mac-spi-nor.c | 127 +++++++++++++++++++++ .../atmel/sama5d27_wlsom1_ek/sama5d27_wlsom1_ek.c | 3 + configs/sama5d27_wlsom1_ek_mmc_defconfig | 5 + configs/sama5d27_wlsom1_ek_qspiflash_defconfig | 1 + drivers/mtd/spi/spi-nor-core.c | 46 +++++++- include/linux/mtd/spi-nor.h | 2 + 8 files changed, 184 insertions(+), 2 deletions(-) create mode 100644 board/atmel/common/mac-spi-nor.c -- 2.9.5

3 6

[U-Boot] [PATCH v4 00/42] common: Further reduce common.h
by Simon Glass 03 Dec '19

03 Dec '19

4 59

[U-Boot] [PULL] u-boot-mips
by Daniel Schwierzeck 03 Dec '19

03 Dec '19

Hi Tom, please pull the removal of the MIPS Micronas VCT boards for 2020.01. Gitlab: https://gitlab.denx.de/u-boot/custodians/u-boot-mips/pipelines/1454 Travis CI: https://travis-ci.org/danielschwierzeck/u-boot/builds/618647984 The following changes since commit 4b19b89ca4a866b7baa642533e6dbd67cd832d27: Merge tag 'rpi-next-2020.01' of https://github.com/mbgg/u-boot (2019-11-25 12:56:27 -0500) are available in the Git repository at: git://git.denx.de/u-boot-mips.git master for you to fetch changes up to 2a250ae9b6f1437f13dba272b690b24341b8e1d7: MIPS: remove Micronas VCT boards (2019-11-29 16:18:35 +0100) ---------------------------------------------------------------- Daniel Schwierzeck (1): MIPS: remove Micronas VCT boards arch/mips/Kconfig | 1 - board/micronas/vct/Kconfig | 52 -- board/micronas/vct/MAINTAINERS | 17 - board/micronas/vct/Makefile | 12 - board/micronas/vct/bcu.h | 156 ------ board/micronas/vct/dcgu.c | 244 --------- board/micronas/vct/dcgu.h | 165 ------ board/micronas/vct/ebi.c | 34 -- board/micronas/vct/ebi.h | 81 --- board/micronas/vct/ebi_nor_flash.c | 117 ----- board/micronas/vct/ebi_onenand.c | 185 ------- board/micronas/vct/ebi_smc911x.c | 94 ---- board/micronas/vct/ehci.c | 96 ---- board/micronas/vct/gpio.c | 74 --- board/micronas/vct/scc.c | 657 ------------------------ board/micronas/vct/scc.h | 191 ------- board/micronas/vct/smc_eeprom.c | 394 -------------- board/micronas/vct/top.c | 275 ---------- board/micronas/vct/vct.c | 119 ----- board/micronas/vct/vct.h | 92 ---- board/micronas/vct/vcth/reg_dcgu.h | 22 - board/micronas/vct/vcth/reg_ebi.h | 228 -------- board/micronas/vct/vcth/reg_fwsram.h | 59 --- board/micronas/vct/vcth/reg_gpio.h | 18 - board/micronas/vct/vcth/reg_scc.h | 88 ---- board/micronas/vct/vcth/reg_usbh.h | 19 - board/micronas/vct/vcth/reg_wdt.h | 10 - board/micronas/vct/vcth2/reg_ebi.h | 276 ---------- board/micronas/vct/vctv/reg_dcgu.h | 11 - board/micronas/vct/vctv/reg_ebi.h | 276 ---------- board/micronas/vct/vctv/reg_gpio.h | 18 - board/micronas/vct/vctv/reg_wdt.h | 10 - configs/vct_platinum_defconfig | 32 -- configs/vct_platinum_onenand_defconfig | 35 -- configs/vct_platinum_onenand_small_defconfig | 35 -- configs/vct_platinum_small_defconfig | 32 -- configs/vct_platinumavc_defconfig | 24 - configs/vct_platinumavc_onenand_defconfig | 27 - configs/vct_platinumavc_onenand_small_defconfig | 35 -- configs/vct_platinumavc_small_defconfig | 32 -- configs/vct_premium_defconfig | 32 -- configs/vct_premium_onenand_defconfig | 35 -- configs/vct_premium_onenand_small_defconfig | 35 -- configs/vct_premium_small_defconfig | 32 -- include/configs/vct.h | 194 ------- 45 files changed, 4671 deletions(-) delete mode 100644 board/micronas/vct/Kconfig delete mode 100644 board/micronas/vct/MAINTAINERS delete mode 100644 board/micronas/vct/Makefile delete mode 100644 board/micronas/vct/bcu.h delete mode 100644 board/micronas/vct/dcgu.c delete mode 100644 board/micronas/vct/dcgu.h delete mode 100644 board/micronas/vct/ebi.c delete mode 100644 board/micronas/vct/ebi.h delete mode 100644 board/micronas/vct/ebi_nor_flash.c delete mode 100644 board/micronas/vct/ebi_onenand.c delete mode 100644 board/micronas/vct/ebi_smc911x.c delete mode 100644 board/micronas/vct/ehci.c delete mode 100644 board/micronas/vct/gpio.c delete mode 100644 board/micronas/vct/scc.c delete mode 100644 board/micronas/vct/scc.h delete mode 100644 board/micronas/vct/smc_eeprom.c delete mode 100644 board/micronas/vct/top.c delete mode 100644 board/micronas/vct/vct.c delete mode 100644 board/micronas/vct/vct.h delete mode 100644 board/micronas/vct/vcth/reg_dcgu.h delete mode 100644 board/micronas/vct/vcth/reg_ebi.h delete mode 100644 board/micronas/vct/vcth/reg_fwsram.h delete mode 100644 board/micronas/vct/vcth/reg_gpio.h delete mode 100644 board/micronas/vct/vcth/reg_scc.h delete mode 100644 board/micronas/vct/vcth/reg_usbh.h delete mode 100644 board/micronas/vct/vcth/reg_wdt.h delete mode 100644 board/micronas/vct/vcth2/reg_ebi.h delete mode 100644 board/micronas/vct/vctv/reg_dcgu.h delete mode 100644 board/micronas/vct/vctv/reg_ebi.h delete mode 100644 board/micronas/vct/vctv/reg_gpio.h delete mode 100644 board/micronas/vct/vctv/reg_wdt.h delete mode 100644 configs/vct_platinum_defconfig delete mode 100644 configs/vct_platinum_onenand_defconfig delete mode 100644 configs/vct_platinum_onenand_small_defconfig delete mode 100644 configs/vct_platinum_small_defconfig delete mode 100644 configs/vct_platinumavc_defconfig delete mode 100644 configs/vct_platinumavc_onenand_defconfig delete mode 100644 configs/vct_platinumavc_onenand_small_defconfig delete mode 100644 configs/vct_platinumavc_small_defconfig delete mode 100644 configs/vct_premium_defconfig delete mode 100644 configs/vct_premium_onenand_defconfig delete mode 100644 configs/vct_premium_onenand_small_defconfig delete mode 100644 configs/vct_premium_small_defconfig delete mode 100644 include/configs/vct.h

2 1

[U-Boot] [PATCH v4 1/2] disk: update to use SPL_PARTITIONS for SPL
by Kever Yang 03 Dec '19

03 Dec '19

The SPL disk driver can not depends on SPL_FRAMEWORK & PARTITIONS, which will enable the disk driver when we actually not need it. Use a separate Kconfig to control the partition driver in SPL and fix the issue caused by: Fixes: 91ff686562 ("blk: Rework guard around part_init call") Signed-off-by: Kever Yang <kever.yang(a)rock-chips.com> Reviewed-by: Simon Glass <sjg(a)chromium.org> --- Changes in v4: - format the commit message to ~75 columns. Changes in v3: - update code in blk-uclass.c Changes in v2: - add this patch common/spl/Kconfig | 2 +- disk/Kconfig | 20 ++++++++++++-------- disk/Makefile | 2 +- drivers/block/blk-uclass.c | 2 +- scripts/Makefile.spl | 2 +- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 5978fb2934..094680e54d 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -544,7 +544,7 @@ config SPL_LIBCOMMON_SUPPORT config SPL_LIBDISK_SUPPORT bool "Support disk partitions" - select PARTITIONS + select SPL_PARTITIONS help Enable support for disk partitions within SPL. 'Disk' is something of a misnomer as it includes non-spinning media such as flash (as diff --git a/disk/Kconfig b/disk/Kconfig index 28fb81c2ee..43e76cb49d 100644 --- a/disk/Kconfig +++ b/disk/Kconfig @@ -4,9 +4,7 @@ menu "Partition Types" config PARTITIONS bool "Enable Partition Labels (disklabels) support" default y - select SPL_SPRINTF if SPL select TPL_SPRINTF if TPL - select SPL_STRTO if SPL select TPL_STRTO if TPL help Partition Labels (disklabels) Supported: @@ -23,6 +21,12 @@ config PARTITIONS you must configure support for at least one non-MTD partition type as well. +config SPL_PARTITIONS + select SPL_SPRINTF + select SPL_STRTO + bool "Enable Partition Labels (disklabels) support for SPL" + depends on SPL + config MAC_PARTITION bool "Enable Apple's MacOS partition table" depends on PARTITIONS @@ -32,7 +36,7 @@ config MAC_PARTITION config SPL_MAC_PARTITION bool "Enable Apple's MacOS partition table for SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS default y if MAC_PARTITION config DOS_PARTITION @@ -45,7 +49,7 @@ config DOS_PARTITION config SPL_DOS_PARTITION bool "Enable MS Dos partition table for SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS default y if DOS_PARTITION config ISO_PARTITION @@ -56,7 +60,7 @@ config ISO_PARTITION config SPL_ISO_PARTITION bool "Enable ISO partition table for SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS config AMIGA_PARTITION bool "Enable AMIGA partition table" @@ -67,7 +71,7 @@ config AMIGA_PARTITION config SPL_AMIGA_PARTITION bool "Enable AMIGA partition table for SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS default y if AMIGA_PARTITION config EFI_PARTITION @@ -111,7 +115,7 @@ config EFI_PARTITION_ENTRIES_OFF config SPL_EFI_PARTITION bool "Enable EFI GPT partition table for SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS default y if EFI_PARTITION config PARTITION_UUIDS @@ -125,7 +129,7 @@ config PARTITION_UUIDS config SPL_PARTITION_UUIDS bool "Enable support of UUID for partition in SPL" - depends on SPL && PARTITIONS + depends on SPL_PARTITIONS default y if SPL_EFI_PARTITION config PARTITION_TYPE_GUID diff --git a/disk/Makefile b/disk/Makefile index ccd0335959..92fcc2b4ac 100644 --- a/disk/Makefile +++ b/disk/Makefile @@ -5,7 +5,7 @@ #ccflags-y += -DET_DEBUG -DDEBUG -obj-$(CONFIG_PARTITIONS) += part.o +obj-$(CONFIG_$(SPL_)PARTITIONS) += part.o obj-$(CONFIG_$(SPL_)MAC_PARTITION) += part_mac.o obj-$(CONFIG_$(SPL_)DOS_PARTITION) += part_dos.o obj-$(CONFIG_$(SPL_)ISO_PARTITION) += part_iso.o diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c index c23b6682a6..425ec3259f 100644 --- a/drivers/block/blk-uclass.c +++ b/drivers/block/blk-uclass.c @@ -649,7 +649,7 @@ int blk_unbind_all(int if_type) static int blk_post_probe(struct udevice *dev) { -#if defined(CONFIG_PARTITIONS) && defined(CONFIG_HAVE_BLOCK_DEVICE) +#if CONFIG_IS_ENABLED(PARTITIONS) && defined(CONFIG_HAVE_BLOCK_DEVICE) struct blk_desc *desc = dev_get_uclass_platdata(dev); part_init(desc); diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 7af6b120b6..3535978634 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -82,7 +82,7 @@ else libs-$(CONFIG_SPL_LIBCOMMON_SUPPORT) += common/ cmd/ env/ libs-$(CONFIG_SPL_LIBGENERIC_SUPPORT) += lib/ ifdef CONFIG_SPL_FRAMEWORK -libs-$(CONFIG_PARTITIONS) += disk/ +libs-$(CONFIG_SPL_PARTITIONS) += disk/ endif endif -- 2.17.1

2 5

[U-Boot] [RESEND PATCH v2] dm: serial: Handle "stdout-path" with ":options" correctly
by Bin Meng 03 Dec '19

03 Dec '19

With commit f0921f5098d8 ("fdt: Sync up to the latest libfdt"), SiFive Unleashed board does not boot any more. This was due to the U-Boot local changes commit 77d7fff8cec2 ("fdt: Fix handling of paths with options in them") to libfdt/fdt_ro.c was dropped during the libfdt upgrade. >From the history [1] it was mentioned that the U-Boot changes commit 77d7fff8cec2 ("fdt: Fix handling of paths with options in them") was rejected by libfdt upstream, hence we need find another way to fix the things. This commit uses another method, by updating serial_check_stdout() directly to handle the situation of "stdout-path" with ":options". A simpler way is to change the logic in fdtdec_get_chosen_node() to do similar thing, but I feel that not every property in chosen node may have the option in them, hence it would make more sense to do the special handling in serial_check_stdout() directly. [1]: http://patchwork.ozlabs.org/patch/462756/ Signed-off-by: Bin Meng <bmeng.cn(a)gmail.com> Reviewed-by: Simon Glass <sjg(a)chromium.org> --- Changes in v2: - initialize node with -1 at the beginning of serial_check_stdout() for better readability drivers/serial/serial-uclass.c | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index dcdaede..0f5f1fa 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -29,29 +29,31 @@ static const unsigned long baudrate_table[] = CONFIG_SYS_BAUDRATE_TABLE; #if CONFIG_IS_ENABLED(SERIAL_PRESENT) static int serial_check_stdout(const void *blob, struct udevice **devp) { - int node; + int node = -1; + const char *str, *p, *name; + int namelen; /* Check for a chosen console */ - node = fdtdec_get_chosen_node(blob, "stdout-path"); - if (node < 0) { - const char *str, *p, *name; - - /* - * Deal with things like - * stdout-path = "serial0:115200n8"; - * - * We need to look up the alias and then follow it to the - * correct node. - */ - str = fdtdec_get_chosen_prop(blob, "stdout-path"); - if (str) { - p = strchr(str, ':'); - name = fdt_get_alias_namelen(blob, str, - p ? p - str : strlen(str)); + str = fdtdec_get_chosen_prop(blob, "stdout-path"); + if (str) { + p = strchr(str, ':'); + namelen = p ? p - str : strlen(str); + node = fdt_path_offset_namelen(blob, str, namelen); + + if (node < 0) { + /* + * Deal with things like + * stdout-path = "serial0:115200n8"; + * + * We need to look up the alias and then follow it to + * the correct node. + */ + name = fdt_get_alias_namelen(blob, str, namelen); if (name) node = fdt_path_offset(blob, name); } } + if (node < 0) node = fdt_path_offset(blob, "console"); if (!uclass_get_device_by_of_offset(UCLASS_SERIAL, node, devp)) -- 2.7.4

2 3

[U-Boot] [PATCH] spi: cadence_qspi_apb: fix QSPI write issues
by Ooi, Joyce 02 Dec '19

02 Dec '19

From: Chee Hong Ang <chee.hong.ang(a)intel.com> QSPI driver perform chip select on every flash read/write access. The driver need to disable/enable the QSPI controller while performing chip select. This may cause some data lost especially the QSPI controller is configured to run at slower speed as it may take longer time to access the flash device. This patch prevent the driver from disable/enable the QSPI controller too soon and inadvertently halting any ongoing flash read/write access by ensuring the QSPI controller is always in idle mode after each read/write access. Signed-off-by: Chee Hong Ang <chee.hong.ang(a)intel.com> Signed-off-by: Ooi, Joyce <joyce.ooi(a)intel.com> --- drivers/spi/cadence_qspi_apb.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c index 55a7501..ab14a5f 100644 --- a/drivers/spi/cadence_qspi_apb.c +++ b/drivers/spi/cadence_qspi_apb.c @@ -676,6 +676,10 @@ int cadence_qspi_apb_indirect_read_execute(struct cadence_spi_platdata *plat, writel(CQSPI_REG_INDIRECTRD_DONE, plat->regbase + CQSPI_REG_INDIRECTRD); + /* Wait til QSPI is idle */ + if (!cadence_qspi_wait_idle(plat->regbase)) + return -EIO; + return 0; failrd: @@ -782,6 +786,11 @@ int cadence_qspi_apb_indirect_write_execute(struct cadence_spi_platdata *plat, plat->regbase + CQSPI_REG_INDIRECTWR); if (bounce_buf) free(bounce_buf); + + /* Wait til QSPI is idle */ + if (!cadence_qspi_wait_idle(plat->regbase)) + return -EIO; + return 0; failwr: -- 1.9.1

3 2