January 2019 - U-Boot

[U-Boot] [PATCH v5 0/7] cmd: add efidebug for efi environment
by AKASHI Takahiro 24 Jan '19

24 Jan '19

This patch set is a collection of patches to enhance efi user interfaces /commands. It will help improve user experience on efi boot and make it more usable *without* edk2's shell utility. Let's see how it works: => efidebug boot add 1 SHELL mmc 0:1 /Shell.efi "" => efidebug boot add 2 HELLO mmc 0:1 /hello.efi "" => efidebug boot dump Boot0001: attributes: A-- (0x00000001) label: SHELL file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\Shell.efi data: Boot0002: attributes: A-- (0x00000001) label: HELLO file_path: /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/SD(0)/SD(0)/HD(1,MBR,0x086246ba,0x800,0x40000)/\\hello.efi data: => efidebug boot order 1 2 => efidebug boot order 1: Boot0001: SHELL 2: Boot0002: HELLO => run -e Boot0002 (or bootefi bootmgr - 2) ; '-' means no dtb specified WARNING: booting without device tree Booting: HELLO ## Starting EFI application at 000000007db8b040 ... Hello, world! ## Application terminated, r = 0 => env set -e PlatformLang en ; important! (or you can do "efidebug setvar PlatformLang en") => env print -e Boot0001: {boot,run}(blob) 00000000: 01 00 00 00 68 00 53 00 ....h.S. 00000010: 48 00 45 00 4c 00 4c 00 H.E.L.L. 00000020: 00 00 01 04 14 00 b9 73 .......s 00000030: 1d e6 84 a3 cc 4a ae ab .....J.. 00000040: 82 e8 28 f3 62 8b 03 1a ..(.b... 00000050: 05 00 00 03 1a 05 00 00 ........ 00000060: 04 01 2a 00 01 00 00 00 ..*..... 00000070: 00 08 00 00 00 00 00 00 ........ 00000080: 00 00 04 00 00 00 00 00 ........ 00000090: ba 46 62 08 00 00 00 00 .Fb..... 000000a0: 00 00 00 00 00 00 00 00 ........ 000000b0: 01 01 04 04 1c 00 5c 00 ......\. 000000c0: 5c 00 53 00 68 00 65 00 \.S.h.e. 000000d0: 6c 00 6c 00 2e 00 65 00 l.l...e. 000000e0: 66 00 69 00 00 00 7f ff f.i.... 000000f0: 04 00 00 ... Boot0002: {boot,run}(blob) 00000000: 01 00 00 00 68 00 48 00 ....h.H. 00000010: 45 00 4c 00 4c 00 4f 00 E.L.L.O. 00000020: 00 00 01 04 14 00 b9 73 .......s 00000030: 1d e6 84 a3 cc 4a ae ab .....J.. 00000040: 82 e8 28 f3 62 8b 03 1a ..(.b... 00000050: 05 00 00 03 1a 05 00 00 ........ 00000060: 04 01 2a 00 01 00 00 00 ..*..... 00000070: 00 08 00 00 00 00 00 00 ........ 00000080: 00 00 04 00 00 00 00 00 ........ 00000090: ba 46 62 08 00 00 00 00 .Fb..... 000000a0: 00 00 00 00 00 00 00 00 ........ 000000b0: 01 01 04 04 1c 00 5c 00 ......\. 000000c0: 5c 00 68 00 65 00 6c 00 \.h.e.l. 000000d0: 6c 00 6f 00 2e 00 65 00 l.o...e. 000000e0: 66 00 69 00 00 00 7f ff f.i.... 000000f0: 04 00 00 ... BootOrder: {boot,run}(blob) 00000000: 01 00 02 00 .... OsIndicationsSupported: {ro,boot}(blob) 00000000: 00 00 00 00 00 00 00 00 ........ PlatformLang: {boot,run}(blob) 00000000: 65 6e en => run -e Boot0001 or bootefi bootmgr (UEFI shell ...) "setvar" command now supports efi shell-like syntax: => env set -e foo =S\"akashi\" =0x012345 =Habcdef => env print -e foo foo: {boot,run}(blob) 00000000: 61 6b 61 73 68 69 45 23 akashiE# 00000010: 01 00 ab cd ef ..... Other useful sub commands are: => efidebug devices ; print uefi devices => efidebug drivers ; print uefi drivers => efidebug dh ; print uefi handles => efidebug images ; print loaded images => efidebug memmap ; dump uefi memory map Enjoy! -Takahiro Akashi Changes in v5 (Jan 21, 2019) * rename the command name from efitool to efidebug again * add it to MAINTAINERS * follow a standard way of adding sub commands * allow "env -e" syntax without enabling CONFIG_CMD_EFIDEBUG (merging v4's patch#8 into patch#1) * change "_"-prefixed function names * change some internal variables' names * not print an efi driver's name at "efidebug drivers", yet showing a device path * change protocol name strings from char to u16 at "efidebug dh" * add a helper function to print efi memory attributes at "efidebug memmap" Changes in v4 (Jan 15, 2019) * rename the command name from efishell to efitool * use efi_uintn_t for "size" if appropriate * correct a help text for "boot add" sub-command * "boot" sub-command always takes a hexadecimal number * use systab.boottime directly instead of a local variable, bs * fix a bug in "setvar" sub-command * fix a bug in "devices" and "dh" sub-command * fix a bug in "memmap" sub-command * add "boot next" sub-command to set BootNext variable * "drivers" sub-command prints more useful info, including a driver's name which originates from a corresponding u-boot efi driver * "dh" sub-commands prints more useful info, including a list of protocols which are bound to a given handle Changes in v3 (Dec 18, 2018) * split v2 into two separate patch series * add CONFIG_CMD_EFISHELL to enable/disable efishell command * add missing free() at several places in efishell command Changes in v2 (Nov 5, 2018) * modify efi_dp_from_name() for use in efishell * rename efi_marshal_load_option() to efi_serialize_load_option(), taking a "struct efi_load_option" as an argument * improve a format in dumping uefi variables * enhance a setvar syntax as efi's shell does * change a syntax from "bootefi bootmgr -2" to "bootefi bootmgr - 2" * add -e option to run command * add -e option to env command * add more sub-commands AKASHI Takahiro (7): cmd: add efidebug command cmd: efidebug: add devices command cmd: efidebug: add drivers command cmd: efidebug: add dh command cmd: efidebug: add images command cmd: efidebug: add memmap command cmd: env: add "-e" option for handling UEFI variables MAINTAINERS | 1 + cmd/Kconfig | 10 + cmd/Makefile | 1 + cmd/efidebug.c | 1155 +++++++++++++++++++++++++++++++++++++++++++++ cmd/nvedit.c | 59 ++- include/command.h | 6 + 6 files changed, 1231 insertions(+), 1 deletion(-) create mode 100644 cmd/efidebug.c -- 2.19.1

2 21

[U-Boot] [BUG] efi_loader: GetNextVariableName() fails on qemu-x86_64
by Heinrich Schuchardt 23 Jan '19

23 Jan '19

Hello Simon, hello Bin, on qemu-x86_64 (and not any other architecture) we received an error in a unit test. Once I undefined __HAVE_ARCH_MEMMOVE the error disappeared. Same happens if I use my own memmove() code in lib/slre.c. The memmove() that fails is in function relocate() in lib/slre.c. Should I remove x86 memmove() or can you fix it? We definitively need a unit test for memmove(). The result of the bug is as follows: On qemu-x86_64 srle_compile() produces (using slre_dump() for printing) when testing efi_get_next_variable_name() via bootefi selftest. 0 OPEN 0 2 EXACT "efi_" 5 STAR 7 7 EXACT "-" 10 STAR 12 12 EXACT "-" 15 STAR 17 17 EXACT "-" 20 STAR 22 22 EXACT "-" 25 STAR 27 27 EXACT "_" 30 STAR 32 32 CLOSE 0 34 END On qemu_arm64 it produces 0 OPEN 0 2 EXACT "efi_" 5 STAR 9 7 ANY 8 END 9 EXACT "-" 12 STAR 16 14 ANY 15 END 16 EXACT "-" 19 STAR 23 21 ANY 22 END 23 EXACT "-" 26 STAR 30 28 ANY 29 END 30 EXACT "-" 33 STAR 37 35 ANY 36 END 37 EXACT "_" 40 STAR 44 42 ANY 43 END 44 CLOSE 0 46 END Best regards Heinrich

2 1

[U-Boot] [PATCH 1/1] efi_loader: debug output for HII protocols
by Heinrich Schuchardt 23 Jan '19

23 Jan '19

For correct indention use EFI_PRINT() instead of debug(). For printing efi_uintn_t or size_t use the %zu or %zx format code. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_loader/efi_hii.c | 50 ++++++++++++++++----------------- lib/efi_loader/efi_hii_config.c | 2 +- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c index 89e1a6c236..d63d2d8418 100644 --- a/lib/efi_loader/efi_hii.c +++ b/lib/efi_loader/efi_hii.c @@ -132,13 +132,13 @@ add_strings_package(struct efi_hii_packagelist *hii, struct efi_string_table *stbl = NULL; efi_status_t ret; - debug("header_size: %08x\n", - get_unaligned_le32(&strings_package->header_size)); - debug("string_info_offset: %08x\n", - get_unaligned_le32(&strings_package->string_info_offset)); - debug("language_name: %u\n", - get_unaligned_le16(&strings_package->language_name)); - debug("language: %s\n", strings_package->language); + EFI_PRINT("header_size: %08x\n", + get_unaligned_le32(&strings_package->header_size)); + EFI_PRINT("string_info_offset: %08x\n", + get_unaligned_le32(&strings_package->string_info_offset)); + EFI_PRINT("language_name: %u\n", + get_unaligned_le16(&strings_package->language_name)); + EFI_PRINT("language: %s\n", strings_package->language); /* count # of string entries: */ end = ((void *)strings_package) @@ -160,8 +160,8 @@ add_strings_package(struct efi_hii_packagelist *hii, block = end; break; default: - debug("unknown HII string block type: %02x\n", - block->block_type); + EFI_PRINT("unknown HII string block type: %02x\n", + block->block_type); return EFI_INVALID_PARAMETER; } } @@ -195,7 +195,7 @@ add_strings_package(struct efi_hii_packagelist *hii, struct efi_hii_sibt_string_ucs2_block *ucs2; ucs2 = (void *)block; - debug("%4u: \"%ls\"\n", idx + 1, ucs2->string_text); + EFI_PRINT("%4u: \"%ls\"\n", idx + 1, ucs2->string_text); stbl->strings[idx].string = u16_strdup(ucs2->string_text); if (!stbl->strings[idx].string) { @@ -210,8 +210,8 @@ add_strings_package(struct efi_hii_packagelist *hii, case EFI_HII_SIBT_END: goto out; default: - debug("unknown HII string block type: %02x\n", - block->block_type); + EFI_PRINT("unknown HII string block type: %02x\n", + block->block_type); ret = EFI_INVALID_PARAMETER; goto error; } @@ -372,14 +372,14 @@ add_packages(struct efi_hii_packagelist *hii, end = ((void *)package_list) + get_unaligned_le32(&package_list->package_length); - debug("package_list: %pUl (%u)\n", &package_list->package_list_guid, - get_unaligned_le32(&package_list->package_length)); + EFI_PRINT("package_list: %pUl (%u)\n", &package_list->package_list_guid, + get_unaligned_le32(&package_list->package_length)); package = ((void *)package_list) + sizeof(*package_list); while ((void *)package < end) { - debug("package=%p, package type=%x, length=%u\n", package, - efi_hii_package_type(package), - efi_hii_package_len(package)); + EFI_PRINT("package=%p, package type=%x, length=%u\n", package, + efi_hii_package_type(package), + efi_hii_package_len(package)); switch (efi_hii_package_type(package)) { case EFI_HII_PACKAGE_TYPE_GUID: @@ -505,17 +505,17 @@ update_package_list(const struct efi_hii_database_protocol *this, if (!package_list) return EFI_EXIT(EFI_INVALID_PARAMETER); - debug("package_list: %pUl (%u)\n", &package_list->package_list_guid, - get_unaligned_le32(&package_list->package_length)); + EFI_PRINT("package_list: %pUl (%u)\n", &package_list->package_list_guid, + get_unaligned_le32(&package_list->package_length)); package = ((void *)package_list) + sizeof(*package_list); end = ((void *)package_list) + get_unaligned_le32(&package_list->package_length); while ((void *)package < end) { - debug("package=%p, package type=%x, length=%u\n", package, - efi_hii_package_type(package), - efi_hii_package_len(package)); + EFI_PRINT("package=%p, package type=%x, length=%u\n", package, + efi_hii_package_type(package), + efi_hii_package_len(package)); switch (efi_hii_package_type(package)) { case EFI_HII_PACKAGE_TYPE_GUID: @@ -595,8 +595,8 @@ list_package_lists(const struct efi_hii_database_protocol *this, (package_type == EFI_HII_PACKAGE_TYPE_GUID && !package_guid)) return EFI_EXIT(EFI_INVALID_PARAMETER); - debug("package type=%x, guid=%pUl, length=%lu\n", (int)package_type, - package_guid, *handle_buffer_length); + EFI_PRINT("package type=%x, guid=%pUl, length=%zu\n", (int)package_type, + package_guid, *handle_buffer_length); package_cnt = 0; package_max = *handle_buffer_length / sizeof(*handle); @@ -1041,7 +1041,7 @@ get_languages(const struct efi_hii_string_protocol *this, } *p = '\0'; - debug("languages: %s\n", languages); + EFI_PRINT("languages: %s\n", languages); return EFI_EXIT(EFI_SUCCESS); } diff --git a/lib/efi_loader/efi_hii_config.c b/lib/efi_loader/efi_hii_config.c index f4b1f026c1..26ea4b9bc0 100644 --- a/lib/efi_loader/efi_hii_config.c +++ b/lib/efi_loader/efi_hii_config.c @@ -124,7 +124,7 @@ form_callback(const struct efi_hii_config_access_protocol *this, union efi_ifr_type_value *value, efi_browser_action_request_t *action_request) { - EFI_ENTRY("%p, 0x%lx, 0x%x, 0x%x, %p, %p", this, action, + EFI_ENTRY("%p, 0x%zx, 0x%x, 0x%x, %p, %p", this, action, question_id, type, value, action_request); return EFI_EXIT(EFI_DEVICE_ERROR); -- 2.20.1

1 0

[U-Boot] Test failures in u-boot/master on NVIDIA HW with recent push
by Stephen Warren 23 Jan '19

23 Jan '19

Tom, The recent set of patches pushed to u-boot/master cause DFU failures on both Jetson TK1 and Jetson TX1 (i.e. all platforms where I run the DFU test) with the following in the log: host: dfu-util -a 0 -U /var/lib/jenkins/workspace/u-boot-denx_uboot-master-test-py/U_BOOT_BOARD/jetson-tk1/build/u-boot/jetson-tk1/dfu_readback.bin -p 3-2.3 target: ** Reading file would overwrite reserved memory ** dfu: Read error! dfu_read: Failed to fill buffer Tegra124 (Jetson TK1) # I noticed some lmb fixes in the list, so I guess it's due to that.

3 8

[U-Boot] [PATCH 0/5] MSCC: Add Serval SoC family.
by Horatiu Vultur 23 Jan '19

23 Jan '19

This patch series adds support for MSCC Serval SoC family. In this family there are the following boards: pcb105 and pcb106. This is based off the patch series[1]. [1] https://lists.denx.de/pipermail/u-boot/2019-January/355031.html Horatiu Vultur (5): pinctrl: mscc: Add gpio and pinctrl for Serval SoC family. MSCC: Add support for Serval SoC family. MSCC: add device tree for Serval pcb105 board MSCC: Add device tree for Serval pcb106 board MSCC: Add board support for Serval SoC family. arch/mips/dts/Makefile | 1 + arch/mips/dts/mscc,serval.dtsi | 149 ++++++++++ arch/mips/dts/serval_pcb105.dts | 56 ++++ arch/mips/dts/serval_pcb106.dts | 56 ++++ arch/mips/mach-mscc/Kconfig | 9 + arch/mips/mach-mscc/Makefile | 1 + arch/mips/mach-mscc/cpu.c | 2 +- arch/mips/mach-mscc/dram.c | 2 +- arch/mips/mach-mscc/include/mach/common.h | 5 + arch/mips/mach-mscc/include/mach/ddr.h | 20 +- arch/mips/mach-mscc/include/mach/serval/serval.h | 24 ++ .../include/mach/serval/serval_devcpu_gcb.h | 21 ++ .../mach/serval/serval_devcpu_gcb_miim_regs.h | 25 ++ .../include/mach/serval/serval_icpu_cfg.h | 314 +++++++++++++++++++++ arch/mips/mach-mscc/reset.c | 25 +- board/mscc/serval/Kconfig | 14 + board/mscc/serval/Makefile | 3 + board/mscc/serval/serval.c | 74 +++++ configs/mscc_serval_defconfig | 62 ++++ drivers/pinctrl/mscc/Kconfig | 10 + drivers/pinctrl/mscc/Makefile | 1 + drivers/pinctrl/mscc/pinctrl-serval.c | 233 +++++++++++++++ include/configs/vcoreiii.h | 5 +- 23 files changed, 1098 insertions(+), 14 deletions(-) create mode 100644 arch/mips/dts/mscc,serval.dtsi create mode 100644 arch/mips/dts/serval_pcb105.dts create mode 100644 arch/mips/dts/serval_pcb106.dts create mode 100644 arch/mips/mach-mscc/include/mach/serval/serval.h create mode 100644 arch/mips/mach-mscc/include/mach/serval/serval_devcpu_gcb.h create mode 100644 arch/mips/mach-mscc/include/mach/serval/serval_devcpu_gcb_miim_regs.h create mode 100644 arch/mips/mach-mscc/include/mach/serval/serval_icpu_cfg.h create mode 100644 board/mscc/serval/Kconfig create mode 100644 board/mscc/serval/Makefile create mode 100644 board/mscc/serval/serval.c create mode 100644 configs/mscc_serval_defconfig create mode 100644 drivers/pinctrl/mscc/pinctrl-serval.c -- 2.7.4

2 12

[U-Boot] [PATCH v2 0/3] MSCC: Add Servalt SoC family
by Horatiu Vultur 23 Jan '19

23 Jan '19

This patch series adds support for MSCC Servalt SoC family. In this family there is only one board: Servalt(pcb116). This is based off the u-boot-mips/next repository v2-changes: - rename label for gpio in dts. Horatiu Vultur (3): pinctrl: mscc: Add gpio and pinctrl for Servalt SoC family. MSCC: Add support for Servalt SoC family. MSCC: Add board support for Servalt SoC family arch/mips/dts/Makefile | 1 + arch/mips/dts/mscc,servalt.dtsi | 149 ++++++++++ arch/mips/dts/servalt_pcb116.dts | 56 ++++ arch/mips/mach-mscc/Kconfig | 8 + arch/mips/mach-mscc/cpu.c | 2 +- arch/mips/mach-mscc/dram.c | 3 +- arch/mips/mach-mscc/include/mach/common.h | 5 + arch/mips/mach-mscc/include/mach/ddr.h | 22 +- arch/mips/mach-mscc/include/mach/servalt/servalt.h | 24 ++ .../include/mach/servalt/servalt_devcpu_gcb.h | 20 ++ .../mach/servalt/servalt_devcpu_gcb_miim_regs.h | 25 ++ .../include/mach/servalt/servalt_icpu_cfg.h | 319 +++++++++++++++++++++ arch/mips/mach-mscc/reset.c | 2 +- board/mscc/servalt/Kconfig | 14 + board/mscc/servalt/Makefile | 3 + board/mscc/servalt/servalt.c | 52 ++++ configs/mscc_servalt_defconfig | 60 ++++ drivers/pinctrl/mscc/Kconfig | 9 + drivers/pinctrl/mscc/Makefile | 1 + drivers/pinctrl/mscc/pinctrl-servalt.c | 269 +++++++++++++++++ 20 files changed, 1033 insertions(+), 11 deletions(-) create mode 100644 arch/mips/dts/mscc,servalt.dtsi create mode 100644 arch/mips/dts/servalt_pcb116.dts create mode 100644 arch/mips/mach-mscc/include/mach/servalt/servalt.h create mode 100644 arch/mips/mach-mscc/include/mach/servalt/servalt_devcpu_gcb.h create mode 100644 arch/mips/mach-mscc/include/mach/servalt/servalt_devcpu_gcb_miim_regs.h create mode 100644 arch/mips/mach-mscc/include/mach/servalt/servalt_icpu_cfg.h create mode 100644 board/mscc/servalt/Kconfig create mode 100644 board/mscc/servalt/Makefile create mode 100644 board/mscc/servalt/servalt.c create mode 100644 configs/mscc_servalt_defconfig create mode 100644 drivers/pinctrl/mscc/pinctrl-servalt.c -- 2.7.4

2 4

[U-Boot] [PATCH v3 0/4] Add network support for Ocelots SoCs
by Gregory CLEMENT 23 Jan '19

23 Jan '19

Hello, this the third version of a series allowing to use the switch component of the Ocelots SoC as a network interface. The binding used is exactly the same of the one already used by Linux. There is also a patch adding a workaround needed on the Ocelot based boards: indeed the pin connected to the DDR reset is part of the switch subsystem. So we need ensure that the DDR is not reset during the switch reset. Gregory Changelog: v2 -> v3: - Use wait_for_bit_le32() whenever it is possible instead of timer_get_us() (Suggested by Daniel Schwierzeck) - Remove ocelot_ofdata_to_platdata() and get the resources directly from the probe function (Suggested by Daniel Schwierzeck) - Use dev_remap_addr_name() to simplify the address mapping (Suggested by Daniel Schwierzeck) - Simplify the mdio initialization by only manage the internal PHY for now v1 -> v2: - Use wait_for_bit_le32() (suggested by Stefan Roese) - Use debug() instead of printf() for the debug messages in mscc_switch_reset. Gregory CLEMENT (4): MIPS: mscc: ocelot: Add ethernet nodes for Ocelot net: add MSCC Ocelot switch support MIPS: mscc: ocelot: add switch reset support configs: mscc_ocelot: add network support MAINTAINERS | 1 + arch/mips/dts/mscc,ocelot.dtsi | 97 ++++ arch/mips/dts/ocelot_pcb123.dts | 20 + board/mscc/ocelot/ocelot.c | 24 + configs/mscc_ocelot_defconfig | 1 + drivers/net/Kconfig | 7 + drivers/net/Makefile | 1 + drivers/net/ocelot_switch.c | 765 ++++++++++++++++++++++++++++++++ 8 files changed, 916 insertions(+) create mode 100644 drivers/net/ocelot_switch.c -- 2.20.1

2 6

[U-Boot] [PATCH 1/1] efi_selftest: fix HII tests
by Heinrich Schuchardt 23 Jan '19

23 Jan '19

efi_st_printf() does not support format code %ld. Anyway the format code for size_t would be %zu which isn't supported either. We do not want any divisions to avoid invalid references to integer arithmetic routines, cf. https://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html. As a simple remedy remove the noisy messages from the output. They are not relevant for automated testing. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- lib/efi_selftest/efi_selftest_hii.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/efi_selftest/efi_selftest_hii.c b/lib/efi_selftest/efi_selftest_hii.c index 16d7b60829..e38af7dbf8 100644 --- a/lib/efi_selftest/efi_selftest_hii.c +++ b/lib/efi_selftest/efi_selftest_hii.c @@ -205,8 +205,6 @@ static int test_hii_database_list_package_lists(void) (unsigned int)ret); goto out; } - efi_st_printf("list_package_lists returned %ld handles\n", - handles_size / sizeof(*handles)); free(handles); /* STRINGS */ @@ -236,8 +234,6 @@ static int test_hii_database_list_package_lists(void) ret = EFI_ST_FAILURE; goto out; } - efi_st_printf("list_package_lists returned %ld strings handles\n", - handles_size / sizeof(*handles)); free(handles); /* GUID */ @@ -267,8 +263,6 @@ static int test_hii_database_list_package_lists(void) ret = EFI_ST_FAILURE; goto out; } - efi_st_printf("list_package_lists returned %ld guid handles\n", - handles_size / sizeof(*handles)); free(handles); /* KEYBOARD_LAYOUT */ @@ -298,8 +292,6 @@ static int test_hii_database_list_package_lists(void) ret = EFI_ST_FAILURE; goto out; } - efi_st_printf("list_package_lists returned %ld keyboard layout handles\n", - handles_size / sizeof(*handles)); free(handles); result = EFI_ST_SUCCESS; @@ -420,9 +412,6 @@ static int test_hii_database_find_keyboard_layouts(void) } free(guids); - efi_st_printf("find_keyboard_layouts returned %ld guids\n", - guids_size / sizeof(*guids)); - result = EFI_ST_SUCCESS; out: -- 2.20.1

1 0

[U-Boot] [PATCH] net: phy: realtek: Introduce quirk to mark RXC not stoppable
by Carlo Caione 23 Jan '19

23 Jan '19

When EEE is supported by the PHY and the driver allows it, libphy in the kernel is configuring the PHY to stop receiving the xMII clock while it is signaling LPI. While this (usually) works fine in the kernel this is causing issues in U-Boot when rebooting from the linux kernel with this bit set (without having the possibility to reset the PHY) where the PHY suddenly stops working. A new quirk is introduced to unconditionally reset this bit. If the quirk is not enabled using the proper configuration symbol, the PHY state is not changed. Signed-off-by: Carlo Caione <ccaione(a)baylibre.com> --- Hi Joe, just an heads up that this patch depends on the MMD helpers patch I submitted earlier. --- drivers/net/phy/Kconfig | 19 +++++++++++++++++++ drivers/net/phy/realtek.c | 19 +++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 3dc0822d9c..d0dab3014e 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -202,6 +202,25 @@ config RTL8211X_PHY_FORCE_MASTER If unsure, say N. +config RTL8211F_PHY_FORCE_EEE_RXC_ON + bool "Ethernet PHY RTL8211F: do not stop receiving the xMII clock during LPI" + depends on PHY_REALTEK + default n + help + The IEEE 802.3az-2010 (EEE) standar provides a protocol to coordinate + transitions to/from a lower power consumption level (Low Power Idle + mode) based on link utilization. When no packets are being + transmitted, the system goes to Low Power Idle mode to save power. + + Under particular circumstances this setting can cause issues where + the PHY is unable to transmit or receive any packet when in LPI mode. + The problem is caused when the PHY is configured to stop receiving + the xMII clock while it is signaling LPI. When not stated otherwise + this bit is set by libphy in the linux kernel. + + Default n, which means that the PHY state is not changed. To work + around the issues, change this setting to y. + config PHY_SMSC bool "Microchip(SMSC) Ethernet PHYs support" diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index b3e6578df9..fa11696fe2 100644 --- a/drivers/net/phy/realtek.c +++ b/drivers/net/phy/realtek.c @@ -12,6 +12,7 @@ #define PHY_RTL8211x_FORCE_MASTER BIT(1) #define PHY_RTL8211E_PINE64_GIGABIT_FIX BIT(2) +#define PHY_RTL8211F_FORCE_EEE_RXC_ON BIT(3) #define PHY_AUTONEGOTIATE_TIMEOUT 5000 @@ -75,6 +76,15 @@ static int rtl8211e_probe(struct phy_device *phydev) return 0; } +static int rtl8211f_probe(struct phy_device *phydev) +{ +#ifdef CONFIG_RTL8211F_PHY_FORCE_EEE_RXC_ON + phydev->flags |= PHY_RTL8211F_FORCE_EEE_RXC_ON; +#endif + + return 0; +} + /* RealTek RTL8211x */ static int rtl8211x_config(struct phy_device *phydev) { @@ -124,6 +134,14 @@ static int rtl8211f_config(struct phy_device *phydev) { u16 reg; + if (phydev->flags & PHY_RTL8211F_FORCE_EEE_RXC_ON) { + unsigned int reg; + + reg = phy_read_mmd(phydev, MDIO_MMD_PCS, MDIO_CTRL1); + reg &= ~MDIO_PCS_CTRL1_CLKSTOP_EN; + phy_write_mmd(phydev, MDIO_MMD_PCS, MDIO_CTRL1, reg); + } + phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR, BMCR_RESET); phy_write(phydev, MDIO_DEVAD_NONE, @@ -333,6 +351,7 @@ static struct phy_driver RTL8211F_driver = { .uid = 0x1cc916, .mask = 0xffffff, .features = PHY_GBIT_FEATURES, + .probe = &rtl8211f_probe, .config = &rtl8211f_config, .startup = &rtl8211f_startup, .shutdown = &genphy_shutdown, -- 2.19.1

2 3

[U-Boot] [PATCH v3 0/3] Add MMD PHY helpers
by Carlo Caione 23 Jan '19

23 Jan '19

Introduce phy_(read|write)_mmd() generic 802.3 clause 45 register accessors for Clause 22 PHYs, using the indirect method. Allow this behaviour to be overriden by PHY drivers where necessary. Carlo Caione (3): net: phy: Add support for accessing MMD PHY registers net: phy: ti: use generic helpers to access MMD registers cmd: mdio: Add new parameter to access MMD PHY registers cmd/mdio.c | 51 ++++++++++++----- drivers/net/phy/phy.c | 4 ++ drivers/net/phy/ti.c | 130 ++++++++---------------------------------- include/phy.h | 52 +++++++++++++++++ 4 files changed, 117 insertions(+), 120 deletions(-) -- 2.19.1

2 9