July 2017 - U-Boot

[U-Boot] [PATCH] serial: ns16550: Add RX interrupt buffer support
by Stefan Roese 14 Jul '17

14 Jul '17

Pasting longer lines into the U-Boot console prompt sometimes leads to characters missing. One problem here is the small 16-byte FIFO of the legacy NS16550 UART, e.g. on x86 platforms. This patch now introduces a Kconfig option to enable RX interrupt buffer support for NS16550 style UARTs. With this option enabled, I was able paste really long lines into the U-Boot console, without any characters missing. Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: Bin Meng <bmeng.cn(a)gmail.com> --- drivers/serial/Kconfig | 10 +++++ drivers/serial/ns16550.c | 106 ++++++++++++++++++++++++++++++++++++++++++++--- include/ns16550.h | 6 +++ 3 files changed, 117 insertions(+), 5 deletions(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index b7dd2ac103..8284febae3 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -64,6 +64,16 @@ config DM_SERIAL implements serial_putc() etc. The uclass interface is defined in include/serial.h. +config SERIAL_IRQ_BUFFER + bool "Enable RX interrupt buffer for serial input" + depends on DM_SERIAL + default n + help + Enable RX interrupt buffer support for the serial driver. + This enables pasting longer strings, even when the RX FIFO + of the UART is not big enough (e.g. 16 bytes on the normal + NS16550). + config SPL_DM_SERIAL bool "Enable Driver Model for serial drivers in SPL" depends on DM_SERIAL diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index e0e70244ce..686c088e1d 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -315,6 +315,80 @@ DEBUG_UART_FUNCS #endif #ifdef CONFIG_DM_SERIAL + +#if CONFIG_IS_ENABLED(SERIAL_IRQ_BUFFER) + +#define BUF_COUNT 256 + +static void rx_fifo_to_buf(struct udevice *dev) +{ + struct NS16550 *const com_port = dev_get_priv(dev); + struct ns16550_platdata *plat = dev->platdata; + + /* Read all available chars into buffer */ + while ((serial_in(&com_port->lsr) & UART_LSR_DR)) { + plat->buf[plat->wr_ptr++] = serial_in(&com_port->rbr); + plat->wr_ptr %= BUF_COUNT; + } +} + +static int rx_pending(struct udevice *dev) +{ + struct ns16550_platdata *plat = dev->platdata; + + /* + * At startup it may happen, that some already received chars are + * "stuck" in the RX FIFO, even with the interrupt enabled. This + * RX FIFO flushing makes sure, that these chars are read out and + * the RX interrupts works as expected. + */ + rx_fifo_to_buf(dev); + + return plat->rd_ptr != plat->wr_ptr ? 1 : 0; +} + +static int rx_get(struct udevice *dev) +{ + struct ns16550_platdata *plat = dev->platdata; + char val; + + val = plat->buf[plat->rd_ptr++]; + plat->rd_ptr %= BUF_COUNT; + + return val; +} + +void ns16550_handle_irq(void *data) +{ + struct udevice *dev = (struct udevice *)data; + struct NS16550 *const com_port = dev_get_priv(dev); + + /* Check if interrupt is pending */ + if (serial_in(&com_port->iir) & UART_IIR_NO_INT) + return; + + /* Flush all available characters from the RX FIFO into the RX buffer */ + rx_fifo_to_buf(dev); +} + +#else /* CONFIG_SERIAL_IRQ_BUFFER */ + +static int rx_pending(struct udevice *dev) +{ + struct NS16550 *const com_port = dev_get_priv(dev); + + return serial_in(&com_port->lsr) & UART_LSR_DR ? 1 : 0; +} + +static int rx_get(struct udevice *dev) +{ + struct NS16550 *const com_port = dev_get_priv(dev); + + return serial_in(&com_port->rbr); +} + +#endif /* CONFIG_SERIAL_IRQ_BUFFER */ + static int ns16550_serial_putc(struct udevice *dev, const char ch) { struct NS16550 *const com_port = dev_get_priv(dev); @@ -340,19 +414,17 @@ static int ns16550_serial_pending(struct udevice *dev, bool input) struct NS16550 *const com_port = dev_get_priv(dev); if (input) - return serial_in(&com_port->lsr) & UART_LSR_DR ? 1 : 0; + return rx_pending(dev); else return serial_in(&com_port->lsr) & UART_LSR_THRE ? 0 : 1; } static int ns16550_serial_getc(struct udevice *dev) { - struct NS16550 *const com_port = dev_get_priv(dev); - - if (!(serial_in(&com_port->lsr) & UART_LSR_DR)) + if (!ns16550_serial_pending(dev, true)) return -EAGAIN; - return serial_in(&com_port->rbr); + return rx_get(dev); } static int ns16550_serial_setbrg(struct udevice *dev, int baudrate) @@ -375,6 +447,21 @@ int ns16550_serial_probe(struct udevice *dev) com_port->plat = dev_get_platdata(dev); NS16550_init(com_port, -1); +#if CONFIG_IS_ENABLED(SERIAL_IRQ_BUFFER) + if (gd->flags & GD_FLG_RELOC) { + struct ns16550_platdata *plat = dev->platdata; + + /* Allocate the RX buffer */ + plat->buf = malloc(BUF_COUNT); + + /* Install the interrupt handler */ + irq_install_handler(plat->irq, ns16550_handle_irq, dev); + + /* Enable RX interrupts */ + serial_out(UART_IER_RDI, &com_port->ier); + } +#endif + return 0; } @@ -459,6 +546,15 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev) if (port_type == PORT_JZ4780) plat->fcr |= UART_FCR_UME; +#if CONFIG_IS_ENABLED(SERIAL_IRQ_BUFFER) + plat->irq = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev), + "interrupts", 0); + if (!plat->irq) { + debug("ns16550 interrupt not provided\n"); + return -EINVAL; + } +#endif + return 0; } #endif diff --git a/include/ns16550.h b/include/ns16550.h index 5fcbcd2e74..70d1ec8e6a 100644 --- a/include/ns16550.h +++ b/include/ns16550.h @@ -58,6 +58,12 @@ struct ns16550_platdata { int clock; int reg_offset; u32 fcr; + + int irq; + + char *buf; + int rd_ptr; + int wr_ptr; }; struct udevice; -- 2.13.3

2 2

[U-Boot] [PATCH 1/1] efi_loader: provide meaningful status code
by Heinrich Schuchardt 14 Jul '17

14 Jul '17

Currenty any EFI status other than EFI_SUCCESS is reported as Application terminated, r = -22 With the patch the status code and its mnemonic is printed. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- cmd/bootefi.c | 17 ++++----- include/efi.h | 47 +++++++++++++++++------- include/efi_loader.h | 3 ++ lib/efi_loader/efi_image_loader.c | 76 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 122 insertions(+), 21 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index fcb223e999..51353b1217 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -247,8 +247,7 @@ static unsigned long do_bootefi_exec(void *efi, void *fdt) debug("%s:%d Jumping to 0x%lx\n", __func__, __LINE__, (long)entry); if (setjmp(&loaded_image_info.exit_jmp)) { - efi_status_t status = loaded_image_info.exit_status; - return status == EFI_SUCCESS ? 0 : -EINVAL; + return loaded_image_info.exit_status; } loaded_image_info.entry = entry; @@ -277,7 +276,7 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { char *saddr, *sfdt; unsigned long addr, fdt_addr = 0; - int r = 0; + unsigned long r; if (argc < 2) return CMD_RET_USAGE; @@ -302,12 +301,14 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) printf("## Starting EFI application at %08lx ...\n", addr); r = do_bootefi_exec((void *)addr, (void*)fdt_addr); - printf("## Application terminated, r = %d\n", r); + printf("## Application terminated with status code\n" + " %lu, %s\n", + r & ~(1UL << (EFI_BITS_PER_LONG - 1)), efi_status_to_str(r)); - if (r != 0) - r = 1; - - return r; + if (r != EFI_SUCCESS) + return 1; + else + return 0; } #ifdef CONFIG_SYS_LONGHELP diff --git a/include/efi.h b/include/efi.h index 3d587807e8..242da3c3be 100644 --- a/include/efi.h +++ b/include/efi.h @@ -39,19 +39,40 @@ struct efi_device_path; #define EFI_BITS_PER_LONG 64 #endif -#define EFI_SUCCESS 0 -#define EFI_LOAD_ERROR (1 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_INVALID_PARAMETER (2 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_UNSUPPORTED (3 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_BAD_BUFFER_SIZE (4 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_BUFFER_TOO_SMALL (5 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_NOT_READY (6 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_DEVICE_ERROR (7 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_WRITE_PROTECTED (8 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_OUT_OF_RESOURCES (9 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_NOT_FOUND (14 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_ACCESS_DENIED (15 | (1UL << (EFI_BITS_PER_LONG - 1))) -#define EFI_SECURITY_VIOLATION (26 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_SUCCESS 0 +#define EFI_LOAD_ERROR (1 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_INVALID_PARAMETER (2 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_UNSUPPORTED (3 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_BAD_BUFFER_SIZE (4 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_BUFFER_TOO_SMALL (5 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NOT_READY (6 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_DEVICE_ERROR (7 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_WRITE_PROTECTED (8 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_OUT_OF_RESOURCES (9 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_VOLUME_CORRUPTED (10 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_VOLUME_FULL (11 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NO_MEDIA (12 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_MEDIA_CHANGED (13 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NOT_FOUND (14 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_ACCESS_DENIED (15 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NO_RESPONSE (16 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NO_MAPPING (17 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_TIMEOUT (18 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_NOT_STARTED (19 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_ALREADY_STARTED (20 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_ABORTED (21 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_ICMP_ERROR (22 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_TFTP_ERROR (23 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_PROTOCOL_ERROR (24 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_INCOMPATIBLE_VERSION (25 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_SECURITY_VIOLATION (26 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_CRC_ERROR (27 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_END_OF_MEDIA (28 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_END_OF_FILE (31 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_INVALID_LANGUAGE (32 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_COMPROMISED_DATA (33 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_IP_ADDRESS_CONFLICT (34 | (1UL << (EFI_BITS_PER_LONG - 1))) +#define EFI_HTTP_ERROR (35 | (1UL << (EFI_BITS_PER_LONG - 1))) typedef unsigned long efi_status_t; typedef u64 efi_physical_addr_t; diff --git a/include/efi_loader.h b/include/efi_loader.h index 99619f53a9..47245049ab 100644 --- a/include/efi_loader.h +++ b/include/efi_loader.h @@ -145,6 +145,9 @@ extern void *efi_bounce_buffer; #define EFI_LOADER_BOUNCE_BUFFER_SIZE (64 * 1024 * 1024) #endif +/* Convert EFI status code to string */ +const char *efi_status_to_str(efi_status_t r); + /* Convert strings from normal C strings to uEFI strings */ static inline void ascii2unicode(u16 *unicode, const char *ascii) { diff --git a/lib/efi_loader/efi_image_loader.c b/lib/efi_loader/efi_image_loader.c index bc8e04d6d9..c1d09c8806 100644 --- a/lib/efi_loader/efi_image_loader.c +++ b/lib/efi_loader/efi_image_loader.c @@ -18,6 +18,82 @@ DECLARE_GLOBAL_DATA_PTR; const efi_guid_t efi_guid_device_path = DEVICE_PATH_GUID; const efi_guid_t efi_guid_loaded_image = LOADED_IMAGE_GUID; +const char *efi_status_to_str(efi_status_t r) +{ + switch (r) { + case EFI_SUCCESS: + return "EFI_SUCCESS"; + case EFI_LOAD_ERROR: + return "EFI_LOAD_ERROR"; + case EFI_INVALID_PARAMETER: + return "EFI_INVALID_PARAMETER"; + case EFI_UNSUPPORTED: + return "EFI_UNSUPPORTED"; + case EFI_BAD_BUFFER_SIZE: + return "EFI_BAD_BUFFER_SIZE"; + case EFI_BUFFER_TOO_SMALL: + return "EFI_BUFFER_TOO_SMALL"; + case EFI_NOT_READY: + return "EFI_NOT_READY"; + case EFI_DEVICE_ERROR: + return "EFI_DEVICE_ERROR"; + case EFI_WRITE_PROTECTED: + return "EFI_WRITE_PROTECTED"; + case EFI_OUT_OF_RESOURCES: + return "EFI_OUT_OF_RESOURCES"; + case EFI_VOLUME_CORRUPTED: + return "EFI_VOLUME_CORRUPTED"; + case EFI_VOLUME_FULL: + return "EFI_VOLUME_FULL"; + case EFI_NO_MEDIA: + return "EFI_NO_MEDIA"; + case EFI_MEDIA_CHANGED: + return "EFI_MEDIA_CHANGED"; + case EFI_NOT_FOUND: + return "EFI_NOT_FOUND"; + case EFI_ACCESS_DENIED: + return "EFI_ACCESS_DENIED"; + case EFI_NO_RESPONSE: + return "EFI_NO_RESPONSE"; + case EFI_NO_MAPPING: + return "EFI_NO_MAPPING"; + case EFI_TIMEOUT: + return "EFI_TIMEOUT"; + case EFI_NOT_STARTED: + return "EFI_NOT_STARTED"; + case EFI_ALREADY_STARTED: + return "EFI_ALREADY_STARTED"; + case EFI_ABORTED: + return "EFI_ABORTED"; + case EFI_ICMP_ERROR: + return "EFI_ICMP_ERROR"; + case EFI_TFTP_ERROR: + return "EFI_TFTP_ERROR"; + case EFI_PROTOCOL_ERROR: + return "EFI_PROTOCOL_ERROR"; + case EFI_INCOMPATIBLE_VERSION: + return "EFI_INCOMPATIBLE_VERSION"; + case EFI_SECURITY_VIOLATION: + return "EFI_SECURITY_VIOLATION"; + case EFI_CRC_ERROR: + return "EFI_CRC_ERROR"; + case EFI_END_OF_MEDIA: + return "EFI_END_OF_MEDIA"; + case EFI_END_OF_FILE: + return "EFI_END_OF_FILE"; + case EFI_INVALID_LANGUAGE: + return "EFI_INVALID_LANGUAGE"; + case EFI_COMPROMISED_DATA: + return "EFI_COMPROMISED_DATA"; + case EFI_IP_ADDRESS_CONFLICT: + return "EFI_IP_ADDRESS_CONFLICT"; + case EFI_HTTP_ERROR: + return "EFI_HTTP_ERROR"; + default: + return "Unknown EFI status code"; + } +} + efi_status_t EFIAPI efi_return_handle(void *handle, efi_guid_t *protocol, void **protocol_interface, void *agent_handle, void *controller_handle, uint32_t attributes) -- 2.11.0

3 4

[U-Boot] [PATCH 0/3] power: Add a driver to handle the PBIAS cell of the TI SOCs
by Jean-Jacques Hiblot 14 Jul '17

14 Jul '17

In the TI SOCs a PBIAS cell exists to provide a bias voltage to the MMC1 IO cells. Without this bias voltage these I/O cells can not function properly. This bias voltage is either 1.8v or 3.0v. The first patch implements the support for this PBIAS cell as a regulator driver. The sencond patch enables it in the default config for am57x and dra7x. The last patch is here to allow the binding of the driver. In the DTS of the dra7x and am57x platforms, the pbias entry is a child of a syscon. Jean-Jacques Hiblot (3): regulator: pbias: Add PBIAS regulator for proper voltage switching on MMC1 configs: dra7xx_evm: am57xx_evm: Enable DM_REGULATOR_PBIAS dm: syscon: scan sub-nodes of the syscon node configs/am57xx_evm_defconfig | 3 + configs/dra7xx_evm_defconfig | 1 + drivers/core/syscon-uclass.c | 1 + drivers/power/regulator/Kconfig | 10 + drivers/power/regulator/Makefile | 1 + drivers/power/regulator/pbias_regulator.c | 305 ++++++++++++++++++++++++++++++ 6 files changed, 321 insertions(+) create mode 100644 drivers/power/regulator/pbias_regulator.c -- 1.9.1

5 13

[U-Boot] [PATCH v2 00/15] usb: hub: Support USB 3.0 hubs
by Bin Meng 14 Jul '17

14 Jul '17

This series is a follow-up series to previous series [1] that adds support for USB 3.0 hubs. USB 3.0 hubs have slightly different hub descriptor format, as well as different port status bit positions. These needs to be properly handled by U-Boot USB core stack codes. xHCI driver has also been updated to correctly set up context structures that are required for devices behind a 3.0 hub to work. Besides USB 3.0 hubs support, this series also adds support for low speed/full speed devices connected behind a high speed hub with the xHC controller. It turns out the 'Transaction Translator' part in the xHC data structure is missing. Note there is one error during testing USB keyboard when CONFIG_USB_KEYBOARD is on. "Failed to get keyboard state from device 413c:2105" The enumeration process did pass and the error was thrown in the USB keyboard driver. This was due to the interrupt transfer is still not supported by xHCI driver, as of today. This series is available at u-boot-x86/xhci-working2 for testing. [1] https://lists.denx.de/pipermail/u-boot/2017-June/296166.html Changes in v2: - update the xhci-pci driver Kconfig to make it depend on DM_USB - nuke xhci_pci_remove() altogether - trim down the ifdefs by adding usb_get_hub_device() and limit ifdefs only in that function - new patch to "remove hub_port_reset()" - squash the xchi is_root_port() changes into previous commit - change to use 'packets' in the comments - handle port number is greater than 15 in route string - fix several nits in the commit message - add a comment for 666 in TT think time Bin Meng (15): usb: xhci-pci: Drop non-DM version of xhci-pci driver usb: xhci-pci: Clean up the driver a little bit usb: hub: Use 'struct usb_hub_device' as hub device's uclass_priv usb: hub: Remove hub_port_reset() usb: hub: Add a new API to test if a hub device is root hub usb: hub: Translate USB 3.0 hub port status into old version usb: hub: Support 'set hub depth' request for USB 3.0 hubs usb: xhci: Change xhci_setup_addressable_virt_dev() signature usb: xhci: Program 'route string' in the input slot context usb: hub: Parse and save TT details from device descriptor dm: usb: Add a new USB controller operation 'update_hub_device' usb: hub: Call usb_update_hub_device() after hub descriptor is fetched usb: xhci: Implement update_hub_device() operation usb: xhci: Correct TT_SLOT and TT_PORT macros usb: xhci: Enable TT to support LS/FS devices behind a HS hub common/usb_hub.c | 208 ++++++++++++++++++++++++++++++++++++++---- drivers/usb/host/Kconfig | 1 + drivers/usb/host/usb-uclass.c | 13 ++- drivers/usb/host/xhci-mem.c | 50 +++++++++- drivers/usb/host/xhci-pci.c | 73 +-------------- drivers/usb/host/xhci.c | 86 ++++++++++++----- drivers/usb/host/xhci.h | 8 +- include/usb.h | 64 +++++++++---- include/usb_defs.h | 15 +++ 9 files changed, 377 insertions(+), 141 deletions(-) -- 2.9.2

2 19

[U-Boot] [PATCH] dm: video: fix abuse of enum
by Lothar Waßmann 14 Jul '17

14 Jul '17

LCD_MAX_WIDTH, LCD_MAX_HEIGHT and LCD_MAX_LSBPP are not alternative values for one specific variable, but unrelated entities with distinct purposes. There is no use defining them as values of an 'enum'. The 'enum' construct would fail miserably for an LCD controller that has a square max. frame size (e.g. 4096x4096). Signed-off-by: Lothar Waßmann <LW(a)KARO-electronics.de> --- drivers/video/atmel_hlcdfb.c | 8 +++----- drivers/video/atmel_lcdfb.c | 10 ++++------ drivers/video/sandbox_sdl.c | 8 +++----- drivers/video/tegra.c | 12 +++++------- drivers/video/tegra124/display.c | 11 +++++------ 5 files changed, 20 insertions(+), 29 deletions(-) diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c index 59b9c45..7426abb 100644 --- a/drivers/video/atmel_hlcdfb.c +++ b/drivers/video/atmel_hlcdfb.c @@ -244,11 +244,9 @@ void lcd_ctrl_init(void *lcdbase) #else -enum { - LCD_MAX_WIDTH = 1024, - LCD_MAX_HEIGHT = 768, - LCD_MAX_LOG2_BPP = VIDEO_BPP16, -}; +#define LCD_MAX_WIDTH 1024 +#define LCD_MAX_HEIGHT 768 +#define LCD_MAX_LOG2_BPP VIDEO_BPP16 struct atmel_hlcdc_priv { struct atmel_hlcd_regs *regs; diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index ed2bd30..c4f6251 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -21,12 +21,10 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef CONFIG_DM_VIDEO -enum { - /* Maximum LCD size we support */ - LCD_MAX_WIDTH = 1366, - LCD_MAX_HEIGHT = 768, - LCD_MAX_LOG2_BPP = VIDEO_BPP16, -}; +/* Maximum LCD size we support */ +#define LCD_MAX_WIDTH 1366 +#define LCD_MAX_HEIGHT 768 +#define LCD_MAX_LOG2_BPP VIDEO_BPP16 #endif struct atmel_fb_priv { diff --git a/drivers/video/sandbox_sdl.c b/drivers/video/sandbox_sdl.c index 18afe2f..e1b6a85 100644 --- a/drivers/video/sandbox_sdl.c +++ b/drivers/video/sandbox_sdl.c @@ -14,11 +14,9 @@ DECLARE_GLOBAL_DATA_PTR; -enum { - /* Default LCD size we support */ - LCD_MAX_WIDTH = 1366, - LCD_MAX_HEIGHT = 768, -}; +/* Default LCD size we support */ +#define LCD_MAX_WIDTH 1366 +#define LCD_MAX_HEIGHT 768 static int sandbox_sdl_probe(struct udevice *dev) { diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c index 0ba3f2c..87db07a 100644 --- a/drivers/video/tegra.c +++ b/drivers/video/tegra.c @@ -1,4 +1,4 @@ -/* +s/* * Copyright (c) 2011 The Chromium OS Authors. * SPDX-License-Identifier: GPL-2.0+ */ @@ -34,12 +34,10 @@ struct tegra_lcd_priv { unsigned pixel_clock; /* Pixel clock in Hz */ }; -enum { - /* Maximum LCD size we support */ - LCD_MAX_WIDTH = 1366, - LCD_MAX_HEIGHT = 768, - LCD_MAX_LOG2_BPP = VIDEO_BPP16, -}; +/* Maximum LCD size we support */ +#define LCD_MAX_WIDTH 1366 +#define LCD_MAX_HEIGHT 768 +#define LCD_MAX_LOG2_BPP VIDEO_BPP16 static void update_window(struct dc_ctlr *dc, struct disp_ctl_win *win) { diff --git a/drivers/video/tegra124/display.c b/drivers/video/tegra124/display.c index bbbca13..1c641a4 100644 --- a/drivers/video/tegra124/display.c +++ b/drivers/video/tegra124/display.c @@ -420,12 +420,11 @@ static int display_init(struct udevice *dev, void *lcdbase, return 0; } -enum { - /* Maximum LCD size we support */ - LCD_MAX_WIDTH = 1920, - LCD_MAX_HEIGHT = 1200, - LCD_MAX_LOG2_BPP = 4, /* 2^4 = 16 bpp */ -}; + +/* Maximum LCD size we support */ +#define LCD_MAX_WIDTH 1920 +#define LCD_MAX_HEIGHT 1200 +#define LCD_MAX_LOG2_BPP VIDEO_BPP16 static int tegra124_lcd_init(struct udevice *dev, void *lcdbase, enum video_log2_bpp l2bpp) -- 2.1.4

3 8

[U-Boot] [PATCH] sandbox: Enable more drivers for more build coverage
by Tom Rini 14 Jul '17

14 Jul '17

Enable more drivers that build currently. This will extend our build time test coverage Cc: Simon Glass <sjg(a)chromium.org> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- configs/sandbox_defconfig | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 36bee4088ebf..699bb1ef1f6a 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -77,9 +77,11 @@ CONFIG_CMD_FS_UUID=y CONFIG_CMD_DIAG=y CONFIG_MAC_PARTITION=y CONFIG_AMIGA_PARTITION=y +CONFIG_PARTITION_TYPE_GUID=y CONFIG_OF_CONTROL=y CONFIG_OF_LIVE=y CONFIG_OF_HOSTFILE=y +CONFIG_NET_RANDOM_ETHADDR=y CONFIG_NETCONSOLE=y CONFIG_REGMAP=y CONFIG_SPL_REGMAP=y @@ -94,8 +96,15 @@ CONFIG_CPU=y CONFIG_DM_DEMO=y CONFIG_DM_DEMO_SIMPLE=y CONFIG_DM_DEMO_SHAPE=y +CONFIG_FPGA_ALTERA=y +CONFIG_FPGA_CYCLON2=y +CONFIG_FPGA_XILINX=y CONFIG_PM8916_GPIO=y +CONFIG_PCF8575_GPIO=y CONFIG_SANDBOX_GPIO=y +CONFIG_TEGRA186_GPIO=y +CONFIG_DM_74X164=y +CONFIG_DM_PCA953X=y CONFIG_DM_I2C_COMPAT=y CONFIG_I2C_CROS_EC_TUNNEL=y CONFIG_I2C_CROS_EC_LDO=y @@ -112,15 +121,23 @@ CONFIG_LED_GPIO=y CONFIG_DM_MAILBOX=y CONFIG_SANDBOX_MBOX=y CONFIG_MISC=y +CONFIG_ALTERA_SYSID=y CONFIG_CROS_EC=y CONFIG_CROS_EC_I2C=y CONFIG_CROS_EC_LPC=y CONFIG_CROS_EC_SANDBOX=y CONFIG_CROS_EC_SPI=y +CONFIG_DS4510=y CONFIG_PWRSEQ=y CONFIG_SPL_PWRSEQ=y CONFIG_I2C_EEPROM=y CONFIG_MMC_SANDBOX=y +CONFIG_MMC_SDHCI=y +CONFIG_MMC_SDHCI_SDMA=y +CONFIG_MMC_SDHCI_CADENCE=y +CONFIG_MMC_SDHCI_MSM=y +CONFIG_MMC_SDHCI_XENON=y +CONFIG_MMC_SDHCI_TANGIER=y CONFIG_SPI_FLASH_SANDBOX=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_ATMEL=y @@ -141,8 +158,14 @@ CONFIG_PHY_SANDBOX=y CONFIG_PINCTRL=y CONFIG_PINCONF=y CONFIG_PINCTRL_ROCKCHIP_RK3036=y +CONFIG_PINCTRL_ROCKCHIP_RK3188=y CONFIG_PINCTRL_ROCKCHIP_RK3288=y +CONFIG_PINCTRL_ROCKCHIP_RK3328=y +CONFIG_PINCTRL_ROCKCHIP_RK3368=y +CONFIG_PINCTRL_ROCKCHIP_RK3399=y +CONFIG_PINCTRL_ROCKCHIP_RV1108=y CONFIG_PINCTRL_SANDBOX=y +CONFIG_PINCTRL_SINGLE=y CONFIG_POWER_DOMAIN=y CONFIG_SANDBOX_POWER_DOMAIN=y CONFIG_DM_PMIC=y -- 1.9.1

2 1

[U-Boot] [PATCH] sandbox: Update defconfig for more build coverage
by Tom Rini 14 Jul '17

14 Jul '17

Enable all of the currently Kconfig'd cmd's that will build in sandbox right now. This will extend our build time test coverage. Cc: Simon Glass <sjg(a)chromium.org> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- configs/sandbox_defconfig | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 6a6e7741d8f6..36bee4088ebf 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -17,6 +17,7 @@ CONFIG_SILENT_CONSOLE=y CONFIG_CMD_CPU=y CONFIG_CMD_LICENSE=y CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTMENU=y # CONFIG_CMD_ELF is not set # CONFIG_CMD_IMLS is not set CONFIG_CMD_ASKENV=y @@ -24,17 +25,28 @@ CONFIG_CMD_GREPENV=y CONFIG_CMD_ENV_CALLBACK=y CONFIG_CMD_ENV_FLAGS=y CONFIG_CMD_MD5SUM=y +CONFIG_MD5SUM_VERIFY=y +CONFIG_CMD_SHA1SUM=y +CONFIG_SHA1SUM_VERIFY=y CONFIG_LOOPW=y CONFIG_CMD_MEMTEST=y CONFIG_CMD_MX_CYCLIC=y CONFIG_CMD_MEMINFO=y +CONFIG_CMD_UNZIP=y +CONFIG_CMD_ZIP=y +CONFIG_CMD_CLK=y CONFIG_CMD_DEMO=y CONFIG_CMD_IDE=y CONFIG_CMD_GPT=y +CONFIG_CMD_MMC=y CONFIG_CMD_SF=y CONFIG_CMD_SPI=y CONFIG_CMD_I2C=y CONFIG_CMD_USB=y +CONFIG_CMD_FPGA_LOADBP=y +CONFIG_CMD_FPGA_LOADFS=y +CONFIG_CMD_FPGA_LOADMK=y +CONFIG_CMD_FPGA_LOADP=y CONFIG_CMD_REMOTEPROC=y CONFIG_CMD_GPIO=y CONFIG_CMD_TFTPPUT=y @@ -46,6 +58,8 @@ CONFIG_CMD_DNS=y CONFIG_CMD_LINK_LOCAL=y CONFIG_CMD_ETHSW=y CONFIG_CMD_BMP=y +CONFIG_CMD_BSP=y +CONFIG_CMD_BKOPS_ENABLE=y CONFIG_CMD_TIME=y CONFIG_CMD_TIMER=y CONFIG_CMD_SOUND=y @@ -53,11 +67,14 @@ CONFIG_CMD_QFW=y CONFIG_CMD_BOOTSTAGE=y CONFIG_CMD_PMIC=y CONFIG_CMD_REGULATOR=y +CONFIG_CMD_AES=y CONFIG_CMD_TPM=y CONFIG_CMD_TPM_TEST=y CONFIG_CMD_CBFS=y CONFIG_CMD_CRAMFS=y CONFIG_CMD_EXT4_WRITE=y +CONFIG_CMD_FS_UUID=y +CONFIG_CMD_DIAG=y CONFIG_MAC_PARTITION=y CONFIG_AMIGA_PARTITION=y CONFIG_OF_CONTROL=y -- 1.9.1

2 1

[U-Boot] [PATCH 0/3] arm: omap: Enable SPL_DM very early
by Lokesh Vutla 14 Jul '17

14 Jul '17

This series enables SPL_DM very early so that i2c, gpio can be used. Lokesh Vutla (3): arm: omap: Detect boot mode very early arm: omap4+: Enable spl_early_init() ARM: dts: OMAP5+: Enable gpio in SPL arch/arm/dts/omap5-u-boot.dtsi | 8 ++++++++ arch/arm/mach-omap2/am33xx/board.c | 8 ++++++++ arch/arm/mach-omap2/boot-common.c | 7 ------- arch/arm/mach-omap2/hwinit-common.c | 9 +++++++++ 4 files changed, 25 insertions(+), 7 deletions(-) -- 2.13.0

3 12

[U-Boot] [PATCH] tools/fw_env: use fsync to ensure that data is physically stored
by Vincent Prince 14 Jul '17

14 Jul '17

Hi all, We had the same issue on our custom board, and this patch fixed it. We use fw_setenv for updating our BSP, and before the patch, 100 boards over 170 didn't work, and after, 170/170 did get the update. This patches worked well for us, Thanks Michael

1 1

[U-Boot] [PATCH v2 00/13] usb: xhci: Add interrupt transfer support and full speed device support
by Bin Meng 14 Jul '17

14 Jul '17

This series is the final series of the xHCI driver update. This adds the missing interrupt transfer support to xHCI driver, so that devices like USB keyboard that uses interrupt transfer when CONFIG_SYS_USB_EVENT_POLL is defined can work. This also adds full speed device support. Unlike low/high/super speed devices, full speed device may report its endpoint 0 max packet size as 8/16/32/64. xHCI driver guesses 64 for the first attempt to get the initial 8 bytes device descriptor, and later adjusts the context for endpoint 0. This series also made several updates to xHCI driver to conform with the spec. Previous two series: [1]: usb: xhci: Fix USB xHCI support on Intel platform https://lists.denx.de/pipermail/u-boot/2017-June/296166.html [2]: usb: hub: Support USB 3.0 hubs https://lists.denx.de/pipermail/u-boot/2017-June/296284.html This series is available at u-boot-x86/xhci-working3 for testing. Bin Meng (13): usb: xhci: Add interrupt transfer support usb: configs: Clean up CONFIG_SYS_USB_EVENT_POLL_(xxx) in board configs usb: kbd: kconfig: Set a default polling mechanism for USB keyboard usb: Only get 64 bytes device descriptor for full speed devices usb: Read device descriptor after device is addressed for xHCI usb: xhci: Fix max packet size for full speed device endpoint 0 usb: hub: Clear port reset before usb_hub_port_connect_change() usb: hub: Clear BH reset status change for a 3.0 hub usb: Handle audio extension endpoint descriptor in usb_parse_config() usb: xhci: Honor endpoint's interval usb: xhci: Program max burst size for endpoint usb: xhci: Set 'Error Count' to 0 for isoch endpoints usb: xhci: Set 'Average TRB Length' to 8 for control endpoints common/usb.c | 45 +++-- common/usb_hub.c | 16 +- configs/A10-OLinuXino-Lime_defconfig | 1 + configs/A10s-OLinuXino-M_defconfig | 1 + configs/A13-OLinuXinoM_defconfig | 1 + configs/A13-OLinuXino_defconfig | 1 + configs/A20-OLinuXino-Lime2_defconfig | 1 + configs/A20-OLinuXino-Lime_defconfig | 1 + configs/A20-OLinuXino_MICRO_defconfig | 1 + configs/A20-Olimex-SOM-EVB_defconfig | 1 + configs/A33-OLinuXino_defconfig | 1 + configs/Ainol_AW1_defconfig | 1 + configs/Ampe_A76_defconfig | 1 + configs/Auxtek-T003_defconfig | 1 + configs/Auxtek-T004_defconfig | 1 + configs/Bananapi_M2_Ultra_defconfig | 1 + configs/Bananapi_defconfig | 1 + configs/Bananapro_defconfig | 1 + configs/CHIP_defconfig | 1 + configs/CHIP_pro_defconfig | 1 + configs/CSQ_CS908_defconfig | 1 + configs/Chuwi_V7_CW0825_defconfig | 1 + configs/Colombus_defconfig | 1 + configs/Cubieboard2_defconfig | 1 + configs/Cubieboard4_defconfig | 1 + configs/Cubieboard_defconfig | 1 + configs/Cubietruck_defconfig | 1 + configs/Cubietruck_plus_defconfig | 1 + configs/Empire_electronix_d709_defconfig | 1 + configs/Empire_electronix_m712_defconfig | 1 + configs/Hummingbird_A31_defconfig | 1 + configs/Hyundai_A7HD_defconfig | 1 + configs/Itead_Ibox_A20_defconfig | 1 + configs/Lamobo_R1_defconfig | 1 + configs/LicheePi_Zero_defconfig | 1 + configs/Linksprite_pcDuino3_Nano_defconfig | 1 + configs/Linksprite_pcDuino3_defconfig | 1 + configs/Linksprite_pcDuino_defconfig | 1 + configs/MK808C_defconfig | 1 + configs/MSI_Primo73_defconfig | 1 + configs/MSI_Primo81_defconfig | 1 + configs/Marsboard_A10_defconfig | 1 + configs/Mele_A1000G_quad_defconfig | 1 + configs/Mele_A1000_defconfig | 1 + configs/Mele_I7_defconfig | 1 + configs/Mele_M3_defconfig | 1 + configs/Mele_M5_defconfig | 1 + configs/Mele_M9_defconfig | 1 + configs/Merrii_A80_Optimus_defconfig | 1 + configs/Mini-X_defconfig | 1 + configs/Nintendo_NES_Classic_Edition_defconfig | 1 + configs/Orangepi_defconfig | 1 + configs/Orangepi_mini_defconfig | 1 + configs/Sinlinx_SinA31s_defconfig | 1 + configs/Sinlinx_SinA33_defconfig | 1 + configs/Sinovoip_BPI_M2_Plus_defconfig | 1 + configs/Sinovoip_BPI_M2_defconfig | 1 + configs/Sinovoip_BPI_M3_defconfig | 1 + configs/Sunchip_CX-A99_defconfig | 1 + configs/UTOO_P66_defconfig | 1 + configs/Wexler_TAB7200_defconfig | 1 + configs/Wits_Pro_A20_DKT_defconfig | 1 + configs/Wobo_i5_defconfig | 1 + configs/Yones_Toptech_BD1078_defconfig | 1 + configs/Yones_Toptech_BS1078_V2_defconfig | 1 + configs/ba10_tv_box_defconfig | 1 + configs/bananapi_m64_defconfig | 1 + configs/cgtqmx6eval_defconfig | 1 + configs/colorfly_e708_q1_defconfig | 1 + configs/difrnce_dit4350_defconfig | 1 + configs/dms-ba16-1g_defconfig | 1 + configs/dms-ba16_defconfig | 1 + configs/dserve_dsrv9703c_defconfig | 1 + configs/ga10h_v1_1_defconfig | 1 + configs/gt90h_v4_defconfig | 1 + configs/gwventana_emmc_defconfig | 1 + configs/gwventana_gw5904_defconfig | 1 + configs/gwventana_nand_defconfig | 1 + configs/h8_homlet_v2_defconfig | 1 + configs/i12-tvbox_defconfig | 1 + configs/iNet_3F_defconfig | 1 + configs/iNet_3W_defconfig | 1 + configs/iNet_86VS_defconfig | 1 + configs/iNet_D978_rev2_defconfig | 1 + configs/icnova-a20-swac_defconfig | 1 + configs/inet1_defconfig | 1 + configs/inet86dz_defconfig | 1 + configs/inet97fv2_defconfig | 1 + configs/inet98v_rev2_defconfig | 1 + configs/inet9f_rev03_defconfig | 1 + configs/inet_q972_defconfig | 1 + configs/jesurun_q5_defconfig | 1 + configs/mixtile_loftq_defconfig | 1 + configs/mk802_a10s_defconfig | 1 + configs/mk802_defconfig | 1 + configs/mk802ii_defconfig | 1 + configs/mx6qsabrelite_defconfig | 1 + configs/nanopi_m1_defconfig | 1 + configs/nanopi_m1_plus_defconfig | 1 + configs/nanopi_neo2_defconfig | 1 + configs/nanopi_neo_air_defconfig | 1 + configs/nanopi_neo_defconfig | 1 + configs/nitrogen6dl2g_defconfig | 1 + configs/nitrogen6dl_defconfig | 1 + configs/nitrogen6q2g_defconfig | 1 + configs/nitrogen6q_defconfig | 1 + configs/nitrogen6s1g_defconfig | 1 + configs/nitrogen6s_defconfig | 1 + configs/novena_defconfig | 1 + configs/orangepi_2_defconfig | 1 + configs/orangepi_lite_defconfig | 1 + configs/orangepi_one_defconfig | 1 + configs/orangepi_pc2_defconfig | 1 + configs/orangepi_pc_defconfig | 1 + configs/orangepi_pc_plus_defconfig | 1 + configs/orangepi_plus2e_defconfig | 1 + configs/orangepi_plus_defconfig | 1 + configs/orangepi_prime_defconfig | 1 + configs/orangepi_win_defconfig | 1 + configs/orangepi_zero_defconfig | 1 + configs/orangepi_zero_plus2_defconfig | 1 + configs/parrot_r16_defconfig | 1 + configs/pine64_plus_defconfig | 1 + configs/polaroid_mid2407pxe03_defconfig | 1 + configs/polaroid_mid2809pxe04_defconfig | 1 + configs/pov_protab2_ips9_defconfig | 1 + configs/q8_a13_tablet_defconfig | 1 + configs/q8_a23_tablet_800x480_defconfig | 1 + configs/q8_a33_tablet_1024x600_defconfig | 1 + configs/q8_a33_tablet_800x480_defconfig | 1 + configs/r7-tv-dongle_defconfig | 1 + configs/sandbox_defconfig | 1 - configs/sandbox_flattree_defconfig | 1 - configs/sandbox_noblk_defconfig | 1 - configs/sandbox_spl_defconfig | 1 - configs/sopine_baseboard_defconfig | 1 + configs/sun8i_a23_evb_defconfig | 1 + configs/sunxi_Gemei_G9_defconfig | 1 + configs/tbs2910_defconfig | 1 + drivers/usb/Kconfig | 2 +- drivers/usb/host/xhci-mem.c | 6 + drivers/usb/host/xhci.c | 264 ++++++++++++++++++++++++- drivers/usb/host/xhci.h | 5 +- include/configs/MPC8610HPCD.h | 1 - include/configs/MPC8641HPCN.h | 1 - include/configs/advantech_dms-ba16.h | 1 - include/configs/am3517_crane.h | 1 - include/configs/am3517_evm.h | 1 - include/configs/apalis_imx6.h | 3 - include/configs/cgtqmx6eval.h | 1 - include/configs/colibri_imx6.h | 3 - include/configs/cyrus.h | 1 - include/configs/ge_bx50v3.h | 1 - include/configs/gw_ventana.h | 1 - include/configs/mx6cuboxi.h | 1 - include/configs/nitrogen6x.h | 1 - include/configs/novena.h | 1 - include/configs/omap3_evm.h | 1 - include/configs/rpi.h | 1 - include/configs/sunxi-common.h | 1 - include/configs/tbs2910.h | 1 - include/configs/tegra-common-post.h | 1 - include/configs/x86-common.h | 1 - include/linux/usb/ch9.h | 20 ++ 164 files changed, 457 insertions(+), 62 deletions(-) -- 2.9.2

1 13