July 2017 - U-Boot

[U-Boot] [PATCH v2 0/9] make SPL and normal u-boot stage use independent SYS_MALLOC_F_LEN
by Andy Yan 18 Jul '17

18 Jul '17

Some platforms like RK3036 has very small sram to run spl code, so it has no enough sapce for so much malloc pool before relocation in spl stage as the normal u-boot stake. As the long discussion in [1] [2], I make this series out, try to make spl and normal u-boot stage use independent SYS_MALLOC_F_LEN. [1]https://lists.denx.de/pipermail/u-boot/2017-July/297370.html [2]https://lists.denx.de/pipermail/u-boot/2017-July/297504.html Changes in v2: - introduce a new control CONFIG_SPL_SYS_MALLOC_F_LEN, adviced by Simon - set spl pre relocation malloc pool by CONFIG_SPL_SYS_MALLOC_F_LEN Andy Yan (9): make SPL and normal u-boot stage use independent SYS_MALLOC_F_LEN mips: spl and normal u-boot stage set SYS_MALLOC_F indepently powerpc: spl and normal u-boot stage set SYS_MALLOC_F indepently microblaze: spl and normal u-boot stage set SYS_MALLOC_F indepently rockchip: set malloc pool size to 0 before relocation in spl state on rk3036 based board rockchip: disable SPL_ARCH_MEMCPY/MEMSET for rk3036 rockchip: enable SPL_LIBGENERIC for rk3036 based boards rockchip: use debug() instead of printf when back to bootrom rockchip: add u-boot specific dts for rk3036 sdk Kconfig | 10 ++++++++++ arch/arm/dts/rk3036-sdk-u-boot.dtsi | 11 +++++++++++ arch/arm/mach-rockchip/bootrom.c | 2 +- arch/arm/mach-rockchip/rk3036-board-spl.c | 6 ------ arch/microblaze/cpu/start.S | 11 ++++++++--- arch/mips/cpu/start.S | 8 ++++++-- arch/powerpc/cpu/mpc83xx/start.S | 13 +++++++++---- arch/powerpc/cpu/mpc85xx/start.S | 16 ++++++++++------ arch/sandbox/cpu/start.c | 2 +- cmd/bdinfo.c | 2 +- common/Makefile | 2 +- common/board_f.c | 4 ++-- common/board_r.c | 2 +- common/dlmalloc.c | 12 ++++++------ common/init/board_init.c | 4 ++-- common/spl/spl.c | 6 +++--- configs/evb-rk3036_defconfig | 5 +++++ configs/kylin-rk3036_defconfig | 6 +++++- drivers/core/Kconfig | 8 ++++---- drivers/serial/serial-uclass.c | 4 ++-- include/asm-generic/global_data.h | 2 +- include/common.h | 11 +++++++++++ lib/asm-offsets.c | 2 +- lib/efi/efi_app.c | 2 +- 24 files changed, 102 insertions(+), 49 deletions(-) create mode 100644 arch/arm/dts/rk3036-sdk-u-boot.dtsi -- 2.7.4

4 16

[U-Boot] i.MX6DL USB OTG Gadget ether with DM_USB and DM_ETH?
by Bernhard Messerklinger 18 Jul '17

18 Jul '17

Hi, I am trying to use the usb otg port of our custom board as usb_ether interface. Everything works fine without device model enabled. But since everything new should be done with DM I tried to use usb_ether with CONFIG_DM_ETH and CONFIG_DM_USB. The usb_ether driver searches for an UCLASS_USB_DEV_GENERIC, but the only way to get such a device is to init usb. whenever I init the usb OTG port gets detected as hub. I looked at the u-boot usb stack code and did not think its possible to use usb gadget driver with DM enabled at this time. Can somebody who is more familiar with the u-boot usb stack confirm this? Or is it just my fault? Devicetree entry: &usbotg { disable-over-current; dr_mode = "peripheral"; status = "okay"; }; Defconfig: CONFIG_DM_ETH=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_EHCI=y CONFIG_USB_STORAGE=y CONFIG_USB_GADGET=y CONFIG_CI_UDC=y CONFIG_USB_GADGET_DUALSPEED=y Config Include: /* USB Configs */ #define CONFIG_USB_EHCI_MX6 #define CONFIG_USB_MAX_CONTROLLER_COUNT 2 #define CONFIG_EHCI_HCD_INIT_AFTER_RESET /* For OTG port */ #define CONFIG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW) #define CONFIG_MXC_USB_FLAGS 0 /* USB Ethernet Configs */ #define CONFIG_USBD_HS #define CONFIG_USB_ETHER #define CONFIG_USB_ETH_CDC #define CONFIG_USBNET_DEV_ADDR "de:ad:be:ef:00:01" #define CONFIG_USBNET_HOST_ADDR "de:ad:be:ef:00:02" Thanks! Bernhard Messerklinger

1 0

[U-Boot] [PATCH v2 00/18] usb: xhci: Fix USB xHCI support on Intel platform
by Bin Meng 18 Jul '17

18 Jul '17

Currently U-Boot xHCI driver does not work on Intel BayTrail SoC based boards that have USB 3.0 ports. Trying to do a 'usb start' simply hangs the board. This series fixes a bunch of xHCI driver issues to make it work on Intel's platform. Issues identified in the U-Boot xHCI driver are really spec violations, but apparently other xHCI IPs found on ARM SoCs (mainly Synopsis IP?) are quite tolerant with these spec violations, or IOW those IPs don't respect the xHCI spec. While it comes to Intel platform, it just breaks. Note xHCI interrupt transfer is still not supported in this series, as it has been there since the original commit of xHCI support for years. Tested on Intel MinnowMax board with the following USB devices: - Dell USB 1.1 keyboard - Dell USB 2.0 mouse - Netac USB 2.0 flash disk - JetFlash USB 3.0 flash disk - GenesysLogic 4-port USB 3.0 hub, with an integrated Realtek USB ethernet chipset connected to one of its downstream port Testing were performed on both ports (2.0 port and 3.0 port), and both ports are connected to xHCI (configure MinnowMax to enable xHCI). Testing results: - DELL USB 1.1 keyboard and 2.0 mouse can be enumerated on both ports - USB 2.0 and 3.0 flash disks work fine (enumerated, read/write) on both ports - GenesysLogic USB 3.0 hub can be enumerated on 2.0 port as a 2.0 hub, and the integrated Realtek USB ethernet chipset enumerated as well. USB 2.0 and 3.0 flash disks connected via the hub can be enumerated, but DELL USB 1.1 keyboard and 2.0 mouse cannot. - GenesysLogic USB 3.0 hub can be enumerated on 3.0 port as a 3.0 hub, but the integrated Realtek USB ethernet chipset cannot be enumerated. None of devices connected via the hub can be enumerated. U-Boot xHCI driver just throws BUG_ON() on the event TRB handling. This indicates that USB 3.0 hub support in U-Boot is seriously broken. So far this series tries to fix some of the issues identified, but the USB 3.0 hub is still not working. This will be left as future work. The USB 3.0 hub work includes: port status translation, USB 3.0 newly added "Set Hub Depth" request support, xHCI codes update to fill in hub description fields in the input slot context when issuing commands to xHC, etc. This series is available at u-boot-x86/xhci-working for testing. Changes in v2: - Change to use uint and also 'normal' variable name packet_size. - Update description to use "PCI-based" - Remove CONFIG_USB_XHCI_PCI from config_whitelist.txt - Drop two x86 patches that were already applied to u-boot-x86 Bin Meng (18): usb: xhci: Remove incorrect comments for struct xhci_container_ctx usb: xhci: Correct command TRB 4th dword initialization usb: xhci: Initialize scratchpad buffer array and scratchpad buffers usb: xhci: Add input slot context in xhci_set_configuration() usb: hub: Update handling connect status/change in usb_scan_port() usb: hub: Send correct wValue to get hub descriptor of a USB 3.0 hub usb: hub: Revise wLength for 'get port status' request usb: hub: Change USB hub descriptor to match USB 3.0 hubs usb: hub: Add 3.0 hub port status mask of 2.0 hub usb: xhci: Change MAX_HC_PORTS to 255 usb: xhci: Get rid of CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS configs: Remove CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS in all boards usb: ehci: Get rid of CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS configs: Remove CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in all boards usb: cmd: Print actual packet size for super speed devices usb: xhci: Convert CONFIG_USB_XHCI_PCI to Kconfig x86: minnowmax: Add a environment variable for USB power-on delay x86: minnowmax: Enable USB xHCI support arch/arm/include/asm/ehci-omap.h | 4 -- arch/x86/dts/minnowmax.dts | 3 ++ cmd/usb.c | 7 ++- common/usb_hub.c | 41 +++++++++++------ configs/minnowmax_defconfig | 1 + drivers/usb/emul/sandbox_hub.c | 7 ++- drivers/usb/host/Kconfig | 6 +++ drivers/usb/host/ehci-hcd.c | 14 +++--- drivers/usb/host/ehci.h | 7 ++- drivers/usb/host/xhci-mem.c | 87 ++++++++++++++++++++++++++++++++++++ drivers/usb/host/xhci-ring.c | 11 ++++- drivers/usb/host/xhci.c | 17 ++++--- drivers/usb/host/xhci.h | 23 +++++----- include/configs/MPC8572DS.h | 1 - include/configs/am43xx_evm.h | 1 - include/configs/am57xx_evm.h | 1 - include/configs/cl-som-am57x.h | 1 - include/configs/cm_t43.h | 1 - include/configs/cm_t54.h | 1 - include/configs/corvus.h | 3 -- include/configs/dra7xx_evm.h | 1 - include/configs/ds414.h | 1 - include/configs/duovero.h | 2 - include/configs/exynos5-common.h | 3 -- include/configs/ls1012afrdm.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021aiot.h | 1 - include/configs/ls1021aqds.h | 1 - include/configs/ls1021atwr.h | 1 - include/configs/ls1043aqds.h | 1 - include/configs/ls1043ardb.h | 1 - include/configs/ls1046aqds.h | 1 - include/configs/ls1046ardb.h | 1 - include/configs/ls2080aqds.h | 1 - include/configs/ls2080ardb.h | 1 - include/configs/ma5d4evk.h | 1 - include/configs/mcx.h | 1 - include/configs/minnowmax.h | 3 +- include/configs/mvebu_armada-37xx.h | 9 +--- include/configs/mvebu_armada-8k.h | 9 +--- include/configs/mx35pdk.h | 1 - include/configs/odroid.h | 1 - include/configs/omap3_beagle.h | 1 - include/configs/omap3_overo.h | 1 - include/configs/omap4_panda.h | 2 - include/configs/omap5_uevm.h | 1 - include/configs/picosam9g45.h | 3 -- include/configs/rk3328_common.h | 2 - include/configs/rk3399_common.h | 3 -- include/configs/sama5d2_ptc.h | 4 -- include/configs/snapper9g45.h | 3 -- include/configs/sunxi-common.h | 1 - include/configs/tam3517-common.h | 1 - include/configs/tao3530.h | 1 - include/configs/tegra114-common.h | 1 - include/configs/tegra124-common.h | 1 - include/configs/tegra20-common.h | 1 - include/configs/tegra210-common.h | 1 - include/configs/tegra30-common.h | 1 - include/configs/ti_armv7_keystone2.h | 1 - include/configs/uniphier.h | 3 -- include/configs/vinco.h | 6 --- include/configs/x86-common.h | 1 - include/configs/xilinx_zynqmp.h | 2 - include/usb.h | 18 ++++++-- include/usb_defs.h | 8 +++- scripts/config_whitelist.txt | 3 -- 68 files changed, 205 insertions(+), 146 deletions(-) -- 2.9.2

3 23

[U-Boot] [RESEND PATCH v10 00/10] usb: Extend ehci and ohci generic driver
by patrice.chotard＠st.com 18 Jul '17

18 Jul '17

From: Patrice Chotard <patrice.chotard(a)st.com> This series improves generic ehci and ohci drivers by addition of : _ error path during probe (clocks, resets and phy release) _ .remove callback _ add generic PHY framework for both generic ehci and ohci drivers _ add RESET and CLOCK framework for generic ohci driver To implement these features, some new methods are needed in reset, clock and in dm/core framework: _ add reset_request() and reset_assert_all() methods in RESET framework _ add clk_count() and clk_disable_all() methods in CLOCK framework _ add ofnode_count_phandle_with_args() and dev_count_phandle_with_args() in dm/core v10: __ add dev_count_phandle_with_args() requested by Simon Glass _ fix some mirno remarks v9: _ rename reset_assert_all() in reset_release_all() as this function not only assert all resets but also free all of them _ rename clk_disable_all() in clk_release_all() as this function not only disable all clocks but also free all of them _ add a check in reset_release_all()/clk_disable_all() to verify if reset/clock has been previously requested before asserting/disabling and freeing it. v8: _ rework error path by propagating the initial error code until the end of probe() _ replace devm_kmalloc() with devm_kcalloc() _ fix cosmetics remarks v7: _ replace clk_count() and reset_count() methods by ofnode_count_phandle_with_args() in patches 3, 4 and 5 v6: _ replace clk_get_by_index() by dev_read_phandle_with_args() in clk_count() in patch 4 _ add Reviewed-by Simon Glass for patch 2 and 5 v5: _ rebase on top of dm/master requested by Simon Glass in order to use livetree update _ replace fdtdec_parse_phandle_with_args() by dev_read_phandle_with_args() in patch 2 v4: _ add clk_disable_all() and reset_assert_all() methods into CLOCK and RESET framework as suggested by Simon Glass and Marek Vasut _ add reset_count() and clk_count() methods which returns respectively the number of resets and clocks declared into "resets" and "clocks" DT properties. This allows to allocate the right amount of memory to keep resets and clocks reference _ update the memory allocation for deasserted resets and enabled clocks reference list. Replace lists by arrays. v3: _ keep enabled clocks and deasserted resets reference in list in order to disable clock or assert resets in error path or in .remove callback _ add missing commit message _ use struct generic_ehci * instead of struct udevice * as parameter for ehci_release_resets() and ehci_release_clocks() _ test return value on generic_phy_get_by_index() and generic_phy_init() _ split previous patch 5 in 3 independant patch for CLOCK, RESET and PHY support v2: _ add needed reset_request() in RESET framework _ add error path in ehci/ohci-generic to disable clocks and to assert resets _ add .remove callback with clocks, resets and phy release _ split the replacement of printf() by error() in an independant patch Patrice Chotard (10): reset: add reset_request() reset: add reset_release_all() clk: add clk_release_all() dm: core: add ofnode_count_phandle_with_args() usb: host: ehci-generic: replace printf() by error() usb: host: ehci-generic: add error path and .remove callback usb: host: ehci-generic: add generic PHY support usb: host: ohci-generic: add CLOCK support usb: host: ohci-generic: add RESET support usb: host: ohci-generic: add generic PHY support drivers/clk/clk-uclass.c | 26 +++++++ drivers/core/of_access.c | 7 ++ drivers/core/ofnode.c | 12 ++++ drivers/reset/reset-uclass.c | 34 ++++++++++ drivers/usb/host/ehci-generic.c | 147 +++++++++++++++++++++++++++++++++------- drivers/usb/host/ohci-generic.c | 122 ++++++++++++++++++++++++++++++++- include/clk.h | 14 ++++ include/dm/of_access.h | 18 +++++ include/dm/ofnode.h | 17 +++++ include/dm/read.h | 25 +++++++ include/reset.h | 27 ++++++++ 11 files changed, 424 insertions(+), 25 deletions(-) -- 1.9.1

2 11

[U-Boot] Question about uclass_add function
by Gan, Yau Wai 18 Jul '17

18 Jul '17

For Nios II arch_cpu_init_dm, the uclass_first_device_err is called to find the UCLASS_CPU. This happened right after initf_dm during board_init_f. No SPL is involved here. Tracing through uclass_first_device_err function, I notice that it tries to find the uclass (via uclass_get) but not success. The code is then continue by adding the uclass (via uclass_add). Inside uclass_add, the code is able to locate memory address for u_boot_list_2_uclass_2_cpu ( which I believe it is doing the job right). However, it then try to init the uclass's dev_head by pointing the next and prev of the doubly linked list to itself. Upon returning to its caller, it then checks for dev_head is list_empty. This is true and the function return without error code, and a NULL pointer for the devp. This subsequently failed the Nios CPU dm init. May I consult if the above behavior is expected? What fix is needed if otherwise? Thank you.

1 0

[U-Boot] [PATCH v6 0/5] Extend xhci-dwc3
by patrice.chotard＠st.com 18 Jul '17

18 Jul '17

From: Patrice Chotard <patrice.chotard(a)st.com> This series extend xhci-dwc3.c drivers by : _ converting it to DM model, _ adding dual role mode support from DT _ adding new generic_phy_valid() method in PHY framework _ adding support of generic PHY framework v6: _ remove useless struct xhci_dwc3 in patch 1 v5: _ rebase on top of dm/master in order to use the last livetree update _ replace dev_get_addr() by devfdt_get_addr() in patch 1 v4: _ set phy->dev to NULL in case of generic_phy_get_by_index() v3: _ introduce generic_phy_valid() method _ add Reviewed-by v2: _ use dev_get_addr() in PATCH 1 and removed useless piece of code Patrice Chotard (5): usb: host: xhci-dwc3: Convert driver to DM usb: host: xhci-dwc3: Add dual role mode support from DT drivers: phy: Set phy->dev to NULL when generic_phy_get_by_index() fails drivers: phy: add generic_phy_valid() method usb: host: xhci-dwc3: Add generic PHY support drivers/phy/phy-uclass.c | 6 +++ drivers/usb/host/xhci-dwc3.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ include/generic-phy.h | 8 ++++ 3 files changed, 101 insertions(+) -- 1.9.1

5 12

[U-Boot] Adding Debug Symbol To U-Boot
by yyurtcan 18 Jul '17

18 Jul '17

Hi, I have p4080ds and lauterbach(T32) hardware debugger. As known, u-boot has written both assembly and C language. I can debug all u-boot code in assembly language(C code also converted to assembly). However, it is hard to follow. How can I debug u-boot C code in C language(not assembly)? What I mean is that at the beginning there is assembly part after that whole code is C language. I want to debug C code in C language not assembly language. Here is my script that is enable debugging u-boot in assembly language.(I have already load u-boot to Nor Flash). If it is not possible, I want to add debug symbols to assembly code for linking C code. To do that what are the requirement to rebuild uboot? --------Script Start ------------------- SYStem.Reset SYStem.CPU P4080 CORE.ASSIGN 1 MAP.BOnchip 0xFFFFF000--0xFFFFFFFF SYStem.UP Data.dump 0xFFFFF000--0xFFFFFFFF --------Script End------------------- Best regards. -- View this message in context: http://u-boot.10912.n7.nabble.com/Adding-Debug-Symbol-To-U-Boot-tp298352.ht… Sent from the U-Boot mailing list archive at Nabble.com.

2 2

[U-Boot] [PATCH 01/12] x86: theadorable-x86-dfi-bt700: Add Micron SPI support and move VIDEO blob
by Stefan Roese 18 Jul '17

18 Jul '17

To support the Micron SPI NOR flashes, this patch enables the support in defconfig. This increases the U-Boot binary too much so that it does not fit into its area in the ROM. So also move the VIDEO BIOS blob a bit to make some space here. Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: Bin Meng <bmeng.cn(a)gmail.com> --- configs/theadorable-x86-dfi-bt700_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/theadorable-x86-dfi-bt700_defconfig b/configs/theadorable-x86-dfi-bt700_defconfig index 1703cee841..30a40e3b16 100644 --- a/configs/theadorable-x86-dfi-bt700_defconfig +++ b/configs/theadorable-x86-dfi-bt700_defconfig @@ -6,6 +6,7 @@ CONFIG_HAVE_INTEL_ME=y CONFIG_ENABLE_MRC_CACHE=y CONFIG_SMP=y CONFIG_HAVE_VGA_BIOS=y +CONFIG_VGA_BIOS_ADDR=0xfffa0000 CONFIG_GENERATE_PIRQ_TABLE=y CONFIG_GENERATE_MP_TABLE=y CONFIG_GENERATE_ACPI_TABLE=y @@ -53,6 +54,7 @@ CONFIG_MMC_SDHCI_SDMA=y CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_SPI_FLASH_MACRONIX=y +CONFIG_SPI_FLASH_SPANSION=y CONFIG_SPI_FLASH_STMICRO=y CONFIG_SPI_FLASH_WINBOND=y CONFIG_DM_ETH=y -- 2.13.3

2 24

[U-Boot] Fwd: [PATCH 1/1] gpio: pca953x: Fix support chips with 24 GPIOs
by Максим Паймушкин 18 Jul '17

18 Jul '17

---------- Переадресованное сообщение ---------- От: "Maxim Paymushkin" <maxim.paymushkin(a)gmail.com> Дата: 15 июл. 2017 г. 19:12 Тема: [PATCH 1/1] gpio: pca953x: Fix support chips with 24 GPIOs Кому: <u-boot-patches(a)bugs.denx.de> Копия: "Maxim Paymushkin" <maxim.paymushkin(a)gmail.com> A bug in the pca953x driver prevents correct detection the chips with 24 GPIOs. Generalized function of reading register for all implemented chips. This patch fixes the reading behaviour. --- drivers/gpio/pca953x_gpio.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/pca953x_gpio.c b/drivers/gpio/pca953x_gpio.c index 4962f25..7122774 100644 --- a/drivers/gpio/pca953x_gpio.c +++ b/drivers/gpio/pca953x_gpio.c @@ -35,6 +35,8 @@ #define PCA953X_INVERT 2 #define PCA953X_DIRECTION 3 +#define REG_ADDR_AI 0x80 + #define PCA_GPIO_MASK 0x00FF #define PCA_INT 0x0100 #define PCA953X_TYPE 0x1000 @@ -115,19 +117,15 @@ static int pca953x_read_single(struct udevice *dev, int reg, u8 *val, static int pca953x_read_regs(struct udevice *dev, int reg, u8 *val) { struct pca953x_info *info = dev_get_platdata(dev); + int bank_shift = fls((info->gpio_count - 1) / BANK_SZ); int ret = 0; - if (info->gpio_count <= 8) { - ret = dm_i2c_read(dev, reg, val, 1); - } else if (info->gpio_count <= 16) { - ret = dm_i2c_read(dev, reg << 1, val, info->bank_count); - } else if (info->gpio_count == 40) { - /* Auto increment */ - ret = dm_i2c_read(dev, (reg << 3) | 0x80, val, info->bank_count); - } else { - dev_err(dev, "Unsupported now\n"); - return -EINVAL; - } + reg <<= bank_shift; + + if (info->gpio_count >= BANK_SZ * 3) + reg |= REG_ADDR_AI; + + ret = dm_i2c_read(dev, reg, val, info->bank_count); return ret; } -- 2.7.4

1 0

[U-Boot] Atmel mci patch 4.2->4.41
by Erik Frederiksen 17 Jul '17

17 Jul '17

Hi I am trying to patch an old u-boot to work with a new eMMC chip. The old chip is 4.2 the new is 4.41. The system is equipped with a AT91SAM9261 and is using the old atmel_mci.c driver (< 2011). Most of this actually works, but 2 problems remain: 1. Power off less than 60 secs. gives a RTOE (response timeout) at OCR polling/writing. 2. Read single block gives an OVRE (overrun error) while waiting for data. My guess is that it has something to do with bus speed/timing - but does anyone have any clues how to debug this. There is not much in the MCI manual/Jedec standards concerning overrun errors. Thanks in advance Erik Frederiksen

1 0