June 2017 - U-Boot

[U-Boot] [PATCH] serial: make serial_stub_* to static functions
by Masahiro Yamada 07 Jul '17

07 Jul '17

Add missing static to serial_stub_puts(). Unexport serial_stub_{getc,tstc} because they are used locally. Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- drivers/serial/serial-uclass.c | 11 +++++++---- drivers/serial/serial.c | 4 ++-- include/common.h | 5 ----- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c index a9c4f89e1a09..200f4b9fd720 100644 --- a/drivers/serial/serial-uclass.c +++ b/drivers/serial/serial-uclass.c @@ -212,27 +212,30 @@ void serial_stdio_init(void) { } -#if defined(CONFIG_DM_STDIO) && CONFIG_IS_ENABLED(SERIAL_PRESENT) +#if defined(CONFIG_DM_STDIO) + +#if CONFIG_IS_ENABLED(SERIAL_PRESENT) static void serial_stub_putc(struct stdio_dev *sdev, const char ch) { _serial_putc(sdev->priv, ch); } #endif -void serial_stub_puts(struct stdio_dev *sdev, const char *str) +static void serial_stub_puts(struct stdio_dev *sdev, const char *str) { _serial_puts(sdev->priv, str); } -int serial_stub_getc(struct stdio_dev *sdev) +static int serial_stub_getc(struct stdio_dev *sdev) { return _serial_getc(sdev->priv); } -int serial_stub_tstc(struct stdio_dev *sdev) +static int serial_stub_tstc(struct stdio_dev *sdev) { return _serial_tstc(sdev->priv); } +#endif /** * on_baudrate() - Update the actual baudrate when the env var changes diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c index f2bd0e404c73..87542f92dfd9 100644 --- a/drivers/serial/serial.c +++ b/drivers/serial/serial.c @@ -273,14 +273,14 @@ static void serial_stub_puts(struct stdio_dev *sdev, const char *str) dev->puts(str); } -int serial_stub_getc(struct stdio_dev *sdev) +static int serial_stub_getc(struct stdio_dev *sdev) { struct serial_device *dev = sdev->priv; return dev->getc(); } -int serial_stub_tstc(struct stdio_dev *sdev) +static int serial_stub_tstc(struct stdio_dev *sdev) { struct serial_device *dev = sdev->priv; diff --git a/include/common.h b/include/common.h index 638c45b954d2..1a98512ab618 100644 --- a/include/common.h +++ b/include/common.h @@ -490,11 +490,6 @@ void serial_puts (const char *); int serial_getc (void); int serial_tstc (void); -/* These versions take a stdio_dev pointer */ -struct stdio_dev; -int serial_stub_getc(struct stdio_dev *sdev); -int serial_stub_tstc(struct stdio_dev *sdev); - /* $(CPU)/speed.c */ int get_clocks (void); ulong get_bus_freq (ulong); -- 2.7.4

4 3

[U-Boot] [PATCH V4 1/4] mmc: fsl_esdhc: correct type of wp_enable
by Peng Fan 07 Jul '17

07 Jul '17

The type should be int, not u8. cfg->wp_enable will finally be assigned to priv->wp_enable whose type is int. Signed-off-by: Peng Fan <peng.fan(a)nxp.com> --- V4: new include/fsl_esdhc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fsl_esdhc.h b/include/fsl_esdhc.h index e15d3ae..5550e00 100644 --- a/include/fsl_esdhc.h +++ b/include/fsl_esdhc.h @@ -177,7 +177,7 @@ struct fsl_esdhc_cfg { phys_addr_t esdhc_base; u32 sdhc_clk; u8 max_bus_width; - u8 wp_enable; + int wp_enable; struct mmc_config cfg; }; -- 2.6.2

3 5

[U-Boot] Targets with xHCI but without DM_USB
by Stefan Roese 07 Jul '17

07 Jul '17

Hi, as you might have noticed, Bin Meng is currently greatly improving the U-Boot xHCI support. While doing this, he noticed that some additions are more complex and especially ugly to add, since some users of the xHCI support have not enabled CONFIG_DM_USB. This adds ugly #ifdef's, which we really would like to avoid. Because of this we checked, which boards exactly are using xHCI without DM_USB enabled. Here a complete list of all the boards: ls1012ardb_qspi_SECURE_BOOT ls1021atwr_nor_SECURE_BOOT am43xx_hs_evm am57xx_hs_evm ls1021aqds_nand ls1021atwr_nor ls1021atwr_qspi cm_t43 ls1021atwr_nor_lpuart ls1021aqds_sdcard_qspi k2hk_hs_evm am43xx_evm ls1021aqds_qspi am57xx_evm_nodt k2g_hs_evm ls1021atwr_sdcard_qspi am43xx_evm_ethboot ls1021aqds_sdcard_ifc k2l_evm am43xx_evm_usbhost_boot am43xx_evm_qspiboot k2g_evm am57xx_evm ls1021atwr_sdcard_ifc cl-som-am57x k2hk_evm k2e_evm ls1021atwr_sdcard_ifc_SECURE_BOOT ls1021aqds_nor_SECURE_BOOT k2e_hs_evm So I'm sending this mail to you, the maintainers of the boards above and would like you to check, if you can enable DM_USB for these boards. This would be great, as it would bring the xHCI support into a much better state, with only DM_USB enabled. Thanks for your feedback in advance. Thanks, Stefan

4 5

[U-Boot] [RFC/PATCH 0/2] Support for NI Ettus Research Project Sulfur
by Moritz Fischer 07 Jul '17

07 Jul '17

Hi Michal, this series adds (basic) support for the NI Ettus Research Project Sulfur SDR. I have a bunch of follow up patches that still need cleanup, so maybe we can start with this. I'm not entirely happy with duplicating a large amount of code from the board/xilinx/zynq/board.c file so suggestions are welcome. My reasoning was that future modifications might be easier if I don't have to mess with the common file via #if defined() for stuff that is NI/Ettus specific in the board/xilinx/zynq directory. Thanks, Moritz Moritz Fischer (2): ni: zynq: Add support for NI Ettus Research Project Sulfur Rev2 SDR ni: zynq: Add support for NI Ettus Research Project Sulfur Rev3 SDR arch/arm/dts/Makefile | 2 + arch/arm/dts/zynq-ni-sulfur-rev2-uboot.dtsi | 16 ++ arch/arm/dts/zynq-ni-sulfur-rev2.dts | 275 +++++++++++++++++++ arch/arm/dts/zynq-ni-sulfur-rev3-uboot.dtsi | 26 ++ arch/arm/dts/zynq-ni-sulfur-rev3.dts | 325 +++++++++++++++++++++++ board/ni/zynq/MAINTAINERS | 6 + board/ni/zynq/Makefile | 10 + board/ni/zynq/board.c | 242 +++++++++++++++++ board/ni/zynq/ps7_init_common.c | 119 +++++++++ board/ni/zynq/ps7_init_gpl.h | 34 +++ board/ni/zynq/sulfur-eeprom.h | 66 +++++ board/ni/zynq/zynq-ni-sulfur-rev2/ps7_init_gpl.c | 313 ++++++++++++++++++++++ board/ni/zynq/zynq-ni-sulfur-rev3/ps7_init_gpl.c | 307 +++++++++++++++++++++ configs/ni_sulfur_rev2_defconfig | 74 ++++++ configs/ni_sulfur_rev3_defconfig | 69 +++++ include/configs/ni_sulfur_rev2.h | 65 +++++ include/configs/ni_sulfur_rev3.h | 42 +++ 17 files changed, 1991 insertions(+) create mode 100644 arch/arm/dts/zynq-ni-sulfur-rev2-uboot.dtsi create mode 100644 arch/arm/dts/zynq-ni-sulfur-rev2.dts create mode 100644 arch/arm/dts/zynq-ni-sulfur-rev3-uboot.dtsi create mode 100644 arch/arm/dts/zynq-ni-sulfur-rev3.dts create mode 100644 board/ni/zynq/MAINTAINERS create mode 100644 board/ni/zynq/Makefile create mode 100644 board/ni/zynq/board.c create mode 100644 board/ni/zynq/ps7_init_common.c create mode 100644 board/ni/zynq/ps7_init_gpl.h create mode 100644 board/ni/zynq/sulfur-eeprom.h create mode 100644 board/ni/zynq/zynq-ni-sulfur-rev2/ps7_init_gpl.c create mode 100644 board/ni/zynq/zynq-ni-sulfur-rev3/ps7_init_gpl.c create mode 100644 configs/ni_sulfur_rev2_defconfig create mode 100644 configs/ni_sulfur_rev3_defconfig create mode 100644 include/configs/ni_sulfur_rev2.h create mode 100644 include/configs/ni_sulfur_rev3.h -- 2.7.4

3 6

[U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe
by Masahiro Yamada 07 Jul '17

07 Jul '17

These are only used in drivers/mis/i2c_eeprom.c Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- drivers/misc/i2c_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c index da6e2b05f730..a14e83225bcc 100644 --- a/drivers/misc/i2c_eeprom.c +++ b/drivers/misc/i2c_eeprom.c @@ -42,7 +42,7 @@ static int i2c_eeprom_std_write(struct udevice *dev, int offset, return -ENODEV; } -struct i2c_eeprom_ops i2c_eeprom_std_ops = { +static const struct i2c_eeprom_ops i2c_eeprom_std_ops = { .read = i2c_eeprom_std_read, .write = i2c_eeprom_std_write, }; @@ -59,7 +59,7 @@ static int i2c_eeprom_std_ofdata_to_platdata(struct udevice *dev) return 0; } -int i2c_eeprom_std_probe(struct udevice *dev) +static int i2c_eeprom_std_probe(struct udevice *dev) { return 0; } -- 2.7.4

4 3

[U-Boot] [PATCH 0/3] GPIO support for Meson GXBB and Odroid-C2
by Beniamino Galvani 07 Jul '17

07 Jul '17

Hi, this series adds a GPIO driver for Meson GXBB and enables it on Odroid-C2. Beniamino Galvani (3): arm: dts: meson: import dts files from Linux 4.12-rc6 pinctrl: meson: add GPIO support odroid-c2: enable GPIO arch/arm/dts/meson-gx.dtsi | 97 +++++++++++++-- arch/arm/dts/meson-gxbb-odroidc2.dts | 82 ++++++++++++- arch/arm/dts/meson-gxbb.dtsi | 187 ++++++++++++++++++++++++----- configs/odroid-c2_defconfig | 2 + drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 21 ++++ drivers/pinctrl/meson/pinctrl-meson.c | 167 +++++++++++++++++++++++++- drivers/pinctrl/meson/pinctrl-meson.h | 63 ++++++++++ include/dt-bindings/clock/gxbb-clkc.h | 14 ++- 8 files changed, 586 insertions(+), 47 deletions(-) -- 2.9.3

4 8

[U-Boot] [PATCH 00/16] usb: hub: Support USB 3.0 hubs
by Bin Meng 07 Jul '17

07 Jul '17

This series is a follow-up series to previous series [1] that adds support for USB 3.0 hubs. USB 3.0 hubs have slightly different hub descriptor format, as well as different port status bit positions. These needs to be properly handled by U-Boot USB core stack codes. xHCI driver has also been updated to correctly set up context structures that are required for devices behind a 3.0 hub to work. Besides USB 3.0 hubs support, this series also adds support for low speed/full speed devices connected behind a high speed hub with the xHC controller. It turns out the 'Transaction Translator' part in the xHC data structure is missing. Note there is one error during testing USB keyboard when CONFIG_USB_KEYBOARD is on. "Failed to get keyboard state from device 413c:2105" The enumeration process did pass and the error was thrown in the USB keyboard driver. This was due to the interrupt transfer is still not supported by xHCI driver, as of today. This series is available at u-boot-x86/xhci-working2 for testing. [1] https://lists.denx.de/pipermail/u-boot/2017-June/296166.html Bin Meng (16): usb: xhci-pci: Drop non-DM version of xhci-pci driver usb: xhci-pci: Clean up the driver a little bit usb: Remove unnecessary work in usb_setup_descriptor() usb: hub: Use 'struct usb_hub_device' as hub device's uclass_priv usb: hub: Add a new API to test if a hub device is root hub usb: xhci: Change to use usb_hub_is_root_hub() API usb: hub: Translate USB 3.0 hub port status into old version usb: hub: Support 'set hub depth' request for USB 3.0 hubs usb: xhci: Change xhci_setup_addressable_virt_dev() signature usb: xhci: Program 'route string' in the input slot context usb: hub: Parse and save TT details from device descriptor dm: usb: Add a new USB controller operation 'update_hub_device' usb: hub: Call usb_update_hub_device() after hub descriptor is fetched usb: xhci: Implement update_hub_device() operation usb: xhci: Correct TT_SLOT and TT_PORT macros usb: xhci: Enable TT to support LS/FS devices behind a HS hub common/usb.c | 40 +++++----- common/usb_hub.c | 166 +++++++++++++++++++++++++++++++++++++++++- drivers/usb/host/usb-uclass.c | 13 +++- drivers/usb/host/xhci-mem.c | 40 +++++++++- drivers/usb/host/xhci-pci.c | 68 +---------------- drivers/usb/host/xhci.c | 85 +++++++++++++++------ drivers/usb/host/xhci.h | 8 +- include/usb.h | 46 +++++++++++- include/usb_defs.h | 15 ++++ 9 files changed, 357 insertions(+), 124 deletions(-) -- 2.9.2

6 65

[U-Boot] [PATCH] dm: include <dm/util.h> from drivers/core/util.c
by Masahiro Yamada 07 Jul '17

07 Jul '17

Fix sparse warnings "... was not declared. Should it be static?" Also, fix redefinition of dm_warn/dm_dbg. Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- drivers/core/util.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/core/util.c b/drivers/core/util.c index 5ceac8bbb15b..2e232d57a14f 100644 --- a/drivers/core/util.c +++ b/drivers/core/util.c @@ -5,9 +5,11 @@ */ #include <common.h> +#include <dm/util.h> #include <libfdt.h> #include <vsprintf.h> +#ifdef CONFIG_DM_WARN void dm_warn(const char *fmt, ...) { va_list args; @@ -16,7 +18,9 @@ void dm_warn(const char *fmt, ...) vprintf(fmt, args); va_end(args); } +#endif +#ifdef DEBUG void dm_dbg(const char *fmt, ...) { va_list args; @@ -25,6 +29,7 @@ void dm_dbg(const char *fmt, ...) vprintf(fmt, args); va_end(args); } +#endif int list_count_items(struct list_head *head) { -- 2.7.4

4 5

[U-Boot] [PATCH] fdt: Check for NULL return from fdt_getprop in 'fdt set'
by Tom Rini 06 Jul '17

06 Jul '17

While the previous pass through fixed one place where we knew that fdt_getprop would be given a positive len, in the case of 'fdt set' we do not, so check that we did no get NULL from fdt_getprop(). Cc: Simon Glass <sjg(a)chromium.org> Reported-by: Coverity (CID: 163249) Fixes 72c98ed1ab48 ("fdt: Add a check to do_fdt() for coverity") Signed-off-by: Tom Rini <trini(a)konsulko.com> --- cmd/fdt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmd/fdt.c b/cmd/fdt.c index 31a536198c8e..05e19f8a72bf 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -284,6 +284,10 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) len = 0; } else { ptmp = fdt_getprop(working_fdt, nodeoffset, prop, &len); + if (!ptmp) { + printf("prop (%s) not found!\n", prop); + return 1; + } if (len > SCRATCHPAD) { printf("prop (%d) doesn't fit in scratchpad!\n", len); -- 1.9.1

3 2

[U-Boot] [PATCH] dm: include <dm/util.h> from driver/core/dump.c
by Masahiro Yamada 06 Jul '17

06 Jul '17

Include <dm/util.h> to fix sparse warnings: symbol 'dm_dump_all' was not declared. Should it be static? symbol 'dm_dump_uclass' was not declared. Should it be static? Signed-off-by: Masahiro Yamada <yamada.masahiro(a)socionext.com> --- drivers/core/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/core/dump.c b/drivers/core/dump.c index fd4596ee68b7..c3e109e7ed11 100644 --- a/drivers/core/dump.c +++ b/drivers/core/dump.c @@ -8,6 +8,7 @@ #include <dm.h> #include <mapmem.h> #include <dm/root.h> +#include <dm/util.h> static void show_devices(struct udevice *dev, int depth, int last_flag) { -- 2.7.4

4 4