June 2017 - U-Boot

[U-Boot] [RFC 1/1] meson-gx: reserved memory regions
by Heinrich＠lists.denx.de 25 Jul '17

25 Jul '17

From: Heinrich Schuchardt <xypron.glpk(a)gmx.de> The Odroid C2 has two GiB of memory with two reserved regions. reg = <0x0 0x0 0x0 0x1000000>; reg = <0x0 0x10000000 0x0 0x200000>; The description has been created with the following patches: Patch bfcef28ae4cf (arm: add initial support for Amlogic Meson and ODROID-C2) defined the available memory in arch/arm/dts/meson-gxbb-odroidc2.dts as reg = <0x0 0x0 0x0 0x80000000> and the number of RAM banks as #define CONFIG_NR_DRAM_BANKS 1. Patch 4b3ab59d21ef (configs: gxbb: Introduce a common config header file) moved the number of RAM banks to include/configs/meson-gxbb-common.h. Patch a3b02a1d4926 (arm: dts: update Meson GXBB / Odroid-C2 DT with recent) defined two reserved memory regions in arch/arm/dts/meson-gx.dtsi. U-Boot does not support the concept of reserved memory regions. Amongst other mishaps this leads to a wrong memory configuration when calling bootefi which may cause a memory violation. The easiest way to correct this is to define multiple memory banks. In the long run fdt support for reserved-memory might be implemented. Signed-off-by: Heinrich Schuchardt <xypron.glpk(a)gmx.de> --- arch/arm/dts/meson-gxbb-odroidc2.dts | 7 ++++++- include/configs/meson-gxbb-common.h | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts index c737183a29..35b8300e23 100644 --- a/arch/arm/dts/meson-gxbb-odroidc2.dts +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts @@ -61,7 +61,12 @@ memory@0 { device_type = "memory"; - reg = <0x0 0x0 0x0 0x80000000>; + reg =<0x0 0x1000000 0x0 0xf000000>; + }; + + memory@1 { + device_type = "memory"; + reg = <0x0 0x10200000 0x0 0x6fe00000>; }; usb_otg_pwr: regulator-usb-pwrs { diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h index 89e3807a14..ed55f441a4 100644 --- a/include/configs/meson-gxbb-common.h +++ b/include/configs/meson-gxbb-common.h @@ -10,7 +10,7 @@ #define CONFIG_CPU_ARMV8 #define CONFIG_REMAKE_ELF -#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_NR_DRAM_BANKS 2 #define CONFIG_ENV_IS_NOWHERE 1 #define CONFIG_ENV_SIZE 0x2000 #define CONFIG_SYS_MAXARGS 32 -- 2.11.0

4 4

[U-Boot] [PATCH 0/3] env: Add support for environments on arbitrary filesystems
by Fiach Antaw 25 Jul '17

25 Jul '17

This patch series consolidates the redundancy implementations used by env_nand, env_mmc and env_ubi, and adds support for a generic env_fs (also using the same redundancy implementation) that supports all filesystems supported by the filesystem code. env_fs should be able to replace env_fat and env_ext4 in all cases, since it implements the same functionality. Unfortunately, I am unable to verify the changes to env_nand, env_mmc and env_ubi on real hardware, though I have verified that they do compile. Fiach Antaw (3): env: Add generic redundant environment implementation env: Switch env_nand, env_mmc and env_ubi to env_import_redund env: Add support for FS environment README | 22 ++++++++ cmd/nvedit.c | 1 + common/Makefile | 1 + common/env_common.c | 51 ++++++++++++++++++ common/env_fs.c | 126 +++++++++++++++++++++++++++++++++++++++++++ common/env_mmc.c | 42 +++------------ common/env_nand.c | 45 +++------------- common/env_ubi.c | 39 +------------- include/environment.h | 21 ++++++++ scripts/config_whitelist.txt | 5 ++ 10 files changed, 243 insertions(+), 110 deletions(-) create mode 100644 common/env_fs.c -- 2.7.4

2 8

[U-Boot] [PATCH] tests: test_dfu.py: Add example udev rule for host_usb_dev_node
by Tom Rini 25 Jul '17

25 Jul '17

If one does not already have a rule to create a custom device node when a given device enumerates it can be useful to have udev create a bus path based node to the entry in /dev/bus/usb that was just enumerated. Given that DFU itself does not require a /dev entry it is a good idea to provide a rule that will generate one. Signed-off-by: Tom Rini <trini(a)konsulko.com> --- test/py/tests/test_dfu.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/py/tests/test_dfu.py b/test/py/tests/test_dfu.py index 585e6b29d7f8..fba67d585b9f 100644 --- a/test/py/tests/test_dfu.py +++ b/test/py/tests/test_dfu.py @@ -80,6 +80,13 @@ ACTION=="add", SUBSYSTEM=="block", SUBSYSTEMS=="usb", KERNELS=="3-13", MODE:="66 (You may wish to change the group ID instead of setting the permissions wide open. All that matters is that the user ID running the test can access the device.) + +c) An optional udev rule to give you a persistent value to use in +host_usb_dev_node. For example: + +IMPORT{builtin}="path_id" +ENV{ID_PATH}=="?*", ENV{.ID_PORT}=="", SYMLINK+="bus/usb/by-path/$env{ID_PATH}" +ENV{ID_PATH}=="?*", ENV{.ID_PORT}=="?*", SYMLINK+="bus/usb/by-path/$env{ID_PATH}-port$env{.ID_PORT}" """ # The set of file sizes to test. These values trigger various edge-cases such -- 1.9.1

1 1

[U-Boot] [PATCH] tools/fw_env: use fsync to ensure that data is physically stored
by Michael Heimpold 25 Jul '17

25 Jul '17

Closing a file descriptor does not guarantee that the data has been successfully saved to disk, as the kernel might defer the write. Signed-off-by: Michael Heimpold <mhei(a)heimpold.de> --- tools/env/fw_env.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c index 428e374..0420495 100644 --- a/tools/env/fw_env.c +++ b/tools/env/fw_env.c @@ -1033,7 +1033,19 @@ static int flash_io (int mode) rc = flash_write (fd_current, fd_target, dev_target); + if (fsync (fd_current)) { + fprintf (stderr, + "fsync failed on %s: %s\n", + DEVNAME (dev_current), strerror (errno)); + } + if (HaveRedundEnv) { + if (fsync (fd_target)) { + fprintf (stderr, + "fsync failed on %s: %s\n", + DEVNAME (dev_current), strerror (errno)); + } + if (close (fd_target)) { fprintf (stderr, "I/O error on %s: %s\n", -- 1.7.10.4

5 6

[U-Boot] am335x uboot TFTP via SPL over usb is failing
by Ravi Kumar Prasad 24 Jul '17

24 Jul '17

Hi, I'm developing a node.js usb bootloader server for the am335x (BeagleBone) platform which can boot it into USB mass storage mode. The server TFTPs SPL over usb and then TFTPs uboot (configured for ums) via SPL. The SPL binary gets transferred successfully, but SPL can't TFTP the uboot binary with the uboot build from latest sources. The previous versions of u-boot succeed in doing so. The known working u-boot version was v2014.07 ( https://github.com/u-boot/u-boot/commit/524123a70761110c5cf3ccc5f52f6d4da07… ). So, we did a git bisect on uboot to track when it stopped failing to TFTP. Here's the bisect log https://pastebin.com/hwXJUf3K Here's outputs of all u-boot https://pastebin.com/t2WNLQsQ So, first bad commit turns out to be this https://github.com/u-boot/u-boot/commit/98d2d5e8c473232dc718763dbec284b7349… Config used for u-boot build : am335x_evm_usbspl_defconfig Patch for uboot ums : https://pastebin.com/rZ3R3zRs Here's code for the server https://github.com/ravikp7/node-beagle-boot , it currently works only on Linux. I need help in fixing this. Thanks Ravi Kumar

3 4

[U-Boot] [PATCH 0/5] db410c: updates for grub + gfxterm
by Rob Clark 21 Jul '17

21 Jul '17

In particular, support for display setup by lk. This introduces a simplefb display driver that uses the framebuffer fdt node populated by the firmware[1] for u-boot display support (and, at least for what I am working on, more interestingly, EFI GOP support). In general, most snapdragon devices have a lk firmware which can light up the display. And mdp5 is a rather complex display controller block (not to mention different mdp4 block for older generations, and hdmi vs dsi blocks). So rather than duplicate all of that in u-boot, add a video driver similar to linux's simplefb, which simply takes over a display setup by an earlier boot stage. The simplefb video driver is so far only used on snapdragon, but the implementation is totally generic so probably useful on other devices in the future. A few related patches so that on db410c we actually use the fdt passed by lk (and so that dm/core is clever enough to notice fdt nodes under "chosen"), config updates, and related fixes. [1] https://github.com/robclark/lk/commits/db410c-display Rob Clark (5): board/db410c: use fdt passed from lk dm: core: also parse chosen node video: simplefb efi_loader: gop: fixes for CONFIG_DM_VIDEO without CONFIG_LCD configs: db410c: config updates arch/arm/Kconfig | 2 +- board/qualcomm/dragonboard410c/dragonboard410c.c | 16 ++++++ cmd/bootefi.c | 2 +- configs/dragonboard410c_defconfig | 7 +++ drivers/core/root.c | 22 +++++++- drivers/video/Kconfig | 10 ++++ drivers/video/Makefile | 2 +- drivers/video/simplefb.c | 68 ++++++++++++++++++++++++ lib/efi_loader/Makefile | 1 + lib/efi_loader/efi_gop.c | 7 ++- 10 files changed, 132 insertions(+), 5 deletions(-) create mode 100644 drivers/video/simplefb.c -- 2.9.4

6 21

[U-Boot] a question about the source of uboot(for armv8).
by 水中有泪 21 Jul '17

21 Jul '17

Hi Haikun Wang, I have a question about the source of uboot. http://lists.denx.de/pipermail/u-boot/2015-June/217446.html >u32 __iomem *dcfg_ccsr = (u32 __iomem *)DCFG_BASE; >val = in_le32(dcfg_ccsr + DCFG_RCWSR13 / 4); The question is this, why does DCFG_RCWSR13 device by 4. (1)dcfg_ccsr is the base address of Dcfg_ccsr (2)DCFG_RCWSR13 is the offset of Dcfg_rcwsr13 So I think the next is right >val = in_le32(dcfg_ccsr + DCFG_RCWSR13); Pardon me my clumsiness.

2 1

[U-Boot] [PATCH] bch: Fix build on FreeBSD host
by Emmanuel Vadot 19 Jul '17

19 Jul '17

endian.h on FreeBSD system exist in sys/ subdirectory. FreeBSD already have a fls function defined in strings.h which is included in string.h if __BSD_VISIBLE is defined, as a check for this. Signed-off-by: Emmanuel Vadot <manu(a)bidouilliste.com> --- lib/bch.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/bch.c b/lib/bch.c index ec53483774..7a2d9d3b86 100644 --- a/lib/bch.c +++ b/lib/bch.c @@ -61,7 +61,11 @@ #include <linux/bitops.h> #else #include <errno.h> +#if defined(__FreeBSD__) +#include <sys/endian.h> +#else #include <endian.h> +#endif #include <stdint.h> #include <stdlib.h> #include <string.h> @@ -113,6 +117,7 @@ struct gf_poly_deg1 { }; #ifdef USE_HOSTCC +#ifndef __BSD_VISIBLE static int fls(int x) { int r = 32; @@ -142,6 +147,7 @@ static int fls(int x) return r; } #endif +#endif /* * same as encode_bch(), but process input data one byte at a time -- 2.13.1

3 3

[U-Boot] [PATCH v2 00/18] usb: xhci: Fix USB xHCI support on Intel platform
by Bin Meng 18 Jul '17

18 Jul '17

Currently U-Boot xHCI driver does not work on Intel BayTrail SoC based boards that have USB 3.0 ports. Trying to do a 'usb start' simply hangs the board. This series fixes a bunch of xHCI driver issues to make it work on Intel's platform. Issues identified in the U-Boot xHCI driver are really spec violations, but apparently other xHCI IPs found on ARM SoCs (mainly Synopsis IP?) are quite tolerant with these spec violations, or IOW those IPs don't respect the xHCI spec. While it comes to Intel platform, it just breaks. Note xHCI interrupt transfer is still not supported in this series, as it has been there since the original commit of xHCI support for years. Tested on Intel MinnowMax board with the following USB devices: - Dell USB 1.1 keyboard - Dell USB 2.0 mouse - Netac USB 2.0 flash disk - JetFlash USB 3.0 flash disk - GenesysLogic 4-port USB 3.0 hub, with an integrated Realtek USB ethernet chipset connected to one of its downstream port Testing were performed on both ports (2.0 port and 3.0 port), and both ports are connected to xHCI (configure MinnowMax to enable xHCI). Testing results: - DELL USB 1.1 keyboard and 2.0 mouse can be enumerated on both ports - USB 2.0 and 3.0 flash disks work fine (enumerated, read/write) on both ports - GenesysLogic USB 3.0 hub can be enumerated on 2.0 port as a 2.0 hub, and the integrated Realtek USB ethernet chipset enumerated as well. USB 2.0 and 3.0 flash disks connected via the hub can be enumerated, but DELL USB 1.1 keyboard and 2.0 mouse cannot. - GenesysLogic USB 3.0 hub can be enumerated on 3.0 port as a 3.0 hub, but the integrated Realtek USB ethernet chipset cannot be enumerated. None of devices connected via the hub can be enumerated. U-Boot xHCI driver just throws BUG_ON() on the event TRB handling. This indicates that USB 3.0 hub support in U-Boot is seriously broken. So far this series tries to fix some of the issues identified, but the USB 3.0 hub is still not working. This will be left as future work. The USB 3.0 hub work includes: port status translation, USB 3.0 newly added "Set Hub Depth" request support, xHCI codes update to fill in hub description fields in the input slot context when issuing commands to xHC, etc. This series is available at u-boot-x86/xhci-working for testing. Changes in v2: - Change to use uint and also 'normal' variable name packet_size. - Update description to use "PCI-based" - Remove CONFIG_USB_XHCI_PCI from config_whitelist.txt - Drop two x86 patches that were already applied to u-boot-x86 Bin Meng (18): usb: xhci: Remove incorrect comments for struct xhci_container_ctx usb: xhci: Correct command TRB 4th dword initialization usb: xhci: Initialize scratchpad buffer array and scratchpad buffers usb: xhci: Add input slot context in xhci_set_configuration() usb: hub: Update handling connect status/change in usb_scan_port() usb: hub: Send correct wValue to get hub descriptor of a USB 3.0 hub usb: hub: Revise wLength for 'get port status' request usb: hub: Change USB hub descriptor to match USB 3.0 hubs usb: hub: Add 3.0 hub port status mask of 2.0 hub usb: xhci: Change MAX_HC_PORTS to 255 usb: xhci: Get rid of CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS configs: Remove CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS in all boards usb: ehci: Get rid of CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS configs: Remove CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in all boards usb: cmd: Print actual packet size for super speed devices usb: xhci: Convert CONFIG_USB_XHCI_PCI to Kconfig x86: minnowmax: Add a environment variable for USB power-on delay x86: minnowmax: Enable USB xHCI support arch/arm/include/asm/ehci-omap.h | 4 -- arch/x86/dts/minnowmax.dts | 3 ++ cmd/usb.c | 7 ++- common/usb_hub.c | 41 +++++++++++------ configs/minnowmax_defconfig | 1 + drivers/usb/emul/sandbox_hub.c | 7 ++- drivers/usb/host/Kconfig | 6 +++ drivers/usb/host/ehci-hcd.c | 14 +++--- drivers/usb/host/ehci.h | 7 ++- drivers/usb/host/xhci-mem.c | 87 ++++++++++++++++++++++++++++++++++++ drivers/usb/host/xhci-ring.c | 11 ++++- drivers/usb/host/xhci.c | 17 ++++--- drivers/usb/host/xhci.h | 23 +++++----- include/configs/MPC8572DS.h | 1 - include/configs/am43xx_evm.h | 1 - include/configs/am57xx_evm.h | 1 - include/configs/cl-som-am57x.h | 1 - include/configs/cm_t43.h | 1 - include/configs/cm_t54.h | 1 - include/configs/corvus.h | 3 -- include/configs/dra7xx_evm.h | 1 - include/configs/ds414.h | 1 - include/configs/duovero.h | 2 - include/configs/exynos5-common.h | 3 -- include/configs/ls1012afrdm.h | 1 - include/configs/ls1012aqds.h | 1 - include/configs/ls1012ardb.h | 1 - include/configs/ls1021aiot.h | 1 - include/configs/ls1021aqds.h | 1 - include/configs/ls1021atwr.h | 1 - include/configs/ls1043aqds.h | 1 - include/configs/ls1043ardb.h | 1 - include/configs/ls1046aqds.h | 1 - include/configs/ls1046ardb.h | 1 - include/configs/ls2080aqds.h | 1 - include/configs/ls2080ardb.h | 1 - include/configs/ma5d4evk.h | 1 - include/configs/mcx.h | 1 - include/configs/minnowmax.h | 3 +- include/configs/mvebu_armada-37xx.h | 9 +--- include/configs/mvebu_armada-8k.h | 9 +--- include/configs/mx35pdk.h | 1 - include/configs/odroid.h | 1 - include/configs/omap3_beagle.h | 1 - include/configs/omap3_overo.h | 1 - include/configs/omap4_panda.h | 2 - include/configs/omap5_uevm.h | 1 - include/configs/picosam9g45.h | 3 -- include/configs/rk3328_common.h | 2 - include/configs/rk3399_common.h | 3 -- include/configs/sama5d2_ptc.h | 4 -- include/configs/snapper9g45.h | 3 -- include/configs/sunxi-common.h | 1 - include/configs/tam3517-common.h | 1 - include/configs/tao3530.h | 1 - include/configs/tegra114-common.h | 1 - include/configs/tegra124-common.h | 1 - include/configs/tegra20-common.h | 1 - include/configs/tegra210-common.h | 1 - include/configs/tegra30-common.h | 1 - include/configs/ti_armv7_keystone2.h | 1 - include/configs/uniphier.h | 3 -- include/configs/vinco.h | 6 --- include/configs/x86-common.h | 1 - include/configs/xilinx_zynqmp.h | 2 - include/usb.h | 18 ++++++-- include/usb_defs.h | 8 +++- scripts/config_whitelist.txt | 3 -- 68 files changed, 205 insertions(+), 146 deletions(-) -- 2.9.2

3 23

[U-Boot] [PATCH] mmc: pic32_sdhci: Complete the transition to driver model
by Alan Ott 17 Jul '17

17 Jul '17

Previously this driver appeared to have been half-way converted to the new driver model and did not work at all. Complete the transition to the driver model, adding the necessary connections. Signed-off-by: Alan Ott <alan(a)softiron.com> --- configs/pic32mzdask_defconfig | 1 - drivers/mmc/Kconfig | 2 +- drivers/mmc/pic32_sdhci.c | 31 ++++++++++++++++++++++++++----- 3 files changed, 27 insertions(+), 7 deletions(-) diff --git a/configs/pic32mzdask_defconfig b/configs/pic32mzdask_defconfig index 688b989..afb1bdb 100644 --- a/configs/pic32mzdask_defconfig +++ b/configs/pic32mzdask_defconfig @@ -25,7 +25,6 @@ CONFIG_CMD_EXT4_WRITE=y # CONFIG_EFI_PARTITION is not set CONFIG_OF_EMBED=y CONFIG_NET_RANDOM_ETHADDR=y -# CONFIG_BLK is not set CONFIG_CLK=y CONFIG_DM_GPIO=y CONFIG_MMC=y diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 0dd4443..b70775d 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -274,7 +274,7 @@ config MMC_SDHCI_MV config MMC_SDHCI_PIC32 bool "Microchip PIC32 on-chip SDHCI support" - depends on DM_MMC && MACH_PIC32 + depends on DM_MMC && BLK && DM_MMC_OPS && MACH_PIC32 depends on MMC_SDHCI help Support for Microchip PIC32 SDHCI controller. diff --git a/drivers/mmc/pic32_sdhci.c b/drivers/mmc/pic32_sdhci.c index 212e22e..fc6d7f3 100644 --- a/drivers/mmc/pic32_sdhci.c +++ b/drivers/mmc/pic32_sdhci.c @@ -15,6 +15,11 @@ DECLARE_GLOBAL_DATA_PTR; +struct pic32_sdhci_plat { + struct mmc_config cfg; + struct mmc mmc; +}; + static int pic32_sdhci_get_cd(struct sdhci_host *host) { /* PIC32 SDHCI CD errata: @@ -31,6 +36,8 @@ static const struct sdhci_ops pic32_sdhci_ops = { static int pic32_sdhci_probe(struct udevice *dev) { + struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev); + struct pic32_sdhci_plat *plat = dev_get_platdata(dev); struct sdhci_host *host = dev_get_priv(dev); const void *fdt = gd->fdt_blob; u32 f_min_max[2]; @@ -56,14 +63,25 @@ static int pic32_sdhci_probe(struct udevice *dev) return ret; } - host->max_clk = f_min_max[1]; - - ret = add_sdhci(host, 0, f_min_max[0]); - if (ret) + ret = sdhci_setup_cfg(&plat->cfg, host, /*max*/0, /*min*/f_min_max[0]); + if (ret) { + printf("pic32_sdhci: sdhci_setup_cfg() failed\n"); return ret; + } + + host->mmc = &plat->mmc; host->mmc->dev = dev; + host->mmc->priv = host; + upriv->mmc = host->mmc; - return 0; + return sdhci_probe(dev); +} + +static int pic32_sdhci_bind(struct udevice *dev) +{ + struct pic32_sdhci_plat *plat = dev_get_platdata(dev); + + return sdhci_bind(dev, &plat->mmc, &plat->cfg); } static const struct udevice_id pic32_sdhci_ids[] = { @@ -75,6 +93,9 @@ U_BOOT_DRIVER(pic32_sdhci_drv) = { .name = "pic32_sdhci", .id = UCLASS_MMC, .of_match = pic32_sdhci_ids, + .ops = &sdhci_ops, + .bind = pic32_sdhci_bind, .probe = pic32_sdhci_probe, .priv_auto_alloc_size = sizeof(struct sdhci_host), + .platdata_auto_alloc_size = sizeof(struct pic32_sdhci_plat), }; -- 2.9.3

4 7