September 2016 - U-Boot

[U-Boot] [PATCH v1 0/4] board: sama5d2_xplained: Convert to use device tree and drivers with DM
by Wenyou Yang 06 Sep '16

06 Sep '16

Convert to use the drivers which support the driver model and use the device tree. And add the support to enable an early debug UART for debugging. It is based on the following patches: - [PATCH v1] i2c: at91_i2c: Fix the wrong include file http://lists.denx.de/pipermail/u-boot/2016-August/265265.html - [PATCH v1 0/2] clk: at91: Fix the wrong used class ID http://lists.denx.de/pipermail/u-boot/2016-August/265266.html - [PATCH v1] mmc: mmc-uclass: Add mmc_init() in mmc preinit phrase http://lists.denx.de/pipermail/u-boot/2016-August/265269.html - [PATCH v1 0/2] serial: atmel_usart: Support to enable an early debug UART http://lists.denx.de/pipermail/u-boot/2016-August/265270.html - [PATCH v8] dm: at91: Add driver model support for the spi driver http://lists.denx.de/pipermail/u-boot/2016-August/264484.html - [PATCH] sf: fix sf probe http://lists.denx.de/pipermail/u-boot/2016-August/264104.html Wenyou Yang (4): board: sama5d2_xplained: Move config options to defconfigs board: sama5d2_xplained: Clean up code board: sama5d2_xplained: Set 'ethaddr' got from AT24MAC board: sama5d2_xplained: Enable an early debug UART board/atmel/sama5d2_xplained/sama5d2_xplained.c | 167 +++++++++--------------- configs/sama5d2_xplained_mmc_defconfig | 37 +++++- configs/sama5d2_xplained_spiflash_defconfig | 38 +++++- include/configs/sama5d2_xplained.h | 32 +---- 4 files changed, 145 insertions(+), 129 deletions(-) -- 2.7.4

2 6

[U-Boot] [PATCH v1 0/2] serial: atmel_usart: Support to enable an early debug UART
by Wenyou Yang 06 Sep '16

06 Sep '16

The patch set is to add support to enable an early debug UART for debugging. And add ATMEL_USART option to enable the Atmel usartdriver from Kconfig. Wenyou Yang (2): serial: Kconfig: Add ATMEL_USART option serial: atmel_usart: Support enable an early debug UART drivers/serial/Kconfig | 14 ++++++++++++++ drivers/serial/atmel_usart.c | 22 ++++++++++++++++++++++ 2 files changed, 36 insertions(+) -- 2.7.4

2 3

[U-Boot] [PATCH] rockchip: rk3288-firefly: enable boot from eMMC
by Jacob Chen 06 Sep '16

06 Sep '16

Add eMMC dt node and define fallback boot devices. Signed-off-by: Jacob Chen <jacob2.chen(a)rock-chips.com> --- arch/arm/dts/rk3288-firefly.dts | 5 +++++ board/firefly/firefly-rk3288/firefly-rk3288.c | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/arch/arm/dts/rk3288-firefly.dts b/arch/arm/dts/rk3288-firefly.dts index 3176d50..27f348e 100644 --- a/arch/arm/dts/rk3288-firefly.dts +++ b/arch/arm/dts/rk3288-firefly.dts @@ -67,6 +67,11 @@ u-boot,dm-pre-reloc; }; +&emmc { + u-boot,dm-pre-reloc; +}; + + &gpio3 { u-boot,dm-pre-reloc; }; diff --git a/board/firefly/firefly-rk3288/firefly-rk3288.c b/board/firefly/firefly-rk3288/firefly-rk3288.c index 5119e95..3e89389 100644 --- a/board/firefly/firefly-rk3288/firefly-rk3288.c +++ b/board/firefly/firefly-rk3288/firefly-rk3288.c @@ -5,3 +5,11 @@ */ #include <common.h> +#include <spl.h> + +void board_boot_order(u32 *spl_boot_list) +{ + /* eMMC prior to sdcard. */ + spl_boot_list[0] = BOOT_DEVICE_MMC2; + spl_boot_list[1] = BOOT_DEVICE_MMC1; +} -- 1.9.1

3 5

[U-Boot] [PATCH 0/5] mmc: uniphier: migrate to CONFIG_DM_MMC_OPS and CONFIG_BLK
by Masahiro Yamada 06 Sep '16

06 Sep '16

Masahiro Yamada (5): mmc: uniphier-sd: migrate to CONFIG_DM_MMC_OPS mmc: uniphier-sd: move uniphier_sd_init() below mmc: uniphier-sd: return error code if unsupported width is given mmc: uniphier-sd: just return if already set to desired clock rate mmc: uniphier-sd: migrate to CONFIG_BLK arch/arm/Kconfig | 1 + drivers/mmc/Kconfig | 2 + drivers/mmc/uniphier-sd.c | 186 ++++++++++++++++++++++++---------------------- 3 files changed, 99 insertions(+), 90 deletions(-) -- 1.9.1

2 8

[U-Boot] [PATCH 0/3] rockchip: i2c: fix >32 byte writes
by John Keeping 06 Sep '16

06 Sep '16

The first two patches are just cleanup that I noticed while in the area, the point of the series is the final patch which fixes an error when trying to write more than 32 bytes via the Rockchip I2C driver. John Keeping (3): rockchip: i2c: use named constant when appropriate rockchip: i2c: move register write out of inner loop rockchip: i2c: fix >32 byte writes drivers/i2c/rk_i2c.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.9.3.728.g30b24b4.dirty

2 6

Re: [U-Boot] [PATCH v3 13/13] ext4: initialize full inode for inodes bigger than 128 bytes
by Stefan Bruens 06 Sep '16

06 Sep '16

On Sonntag, 28. August 2016 22:42:38 CEST you wrote: > Make sure the the extra_isize field (offset 128) is initialized to 0 to > mark any extra data as invalid. > > Signed-off-by: Stefan Brüns <stefan.bruens(a)rwth-aachen.de> > --- > fs/ext4/ext4_write.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > v3: Patch added to series > > diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c > index 81a750b..38fbf68 100644 > --- a/fs/ext4/ext4_write.c > +++ b/fs/ext4/ext4_write.c > @@ -454,7 +454,7 @@ static int ext4fs_delete_file(int inodeno) > node_inode->data = ext4fs_root; > node_inode->ino = inodeno; > node_inode->inode_read = 0; > - memcpy(&(node_inode->inode), &inode, sizeof(struct ext2_inode)); > + memcpy(&(node_inode->inode), &inode, fs->inodesz); This line is actually broken, node_inode->inode is sizeof(struct ext2_inode), i.e 128 bytes. It is responsible for the crash Thomas reported. Kind regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424

1 0

[U-Boot] [RFC PATCH] rockchip: rk3288: skip lowlevel_init process
by Ziyuan Xu 06 Sep '16

06 Sep '16

lowlevel_init() is never needed for rk3288, so drop it. Signed-off-by: Ziyuan Xu <xzy.xu(a)rock-chips.com> --- arch/arm/mach-rockchip/board.c | 4 ---- arch/arm/mach-rockchip/rk3288-board-spl.c | 4 ---- include/configs/rk3288_common.h | 1 + 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index bec756d..6c36bf9 100644 --- a/arch/arm/mach-rockchip/board.c +++ b/arch/arm/mach-rockchip/board.c @@ -81,10 +81,6 @@ void enable_caches(void) } #endif -void lowlevel_init(void) -{ -} - #if defined(CONFIG_USB_GADGET) && defined(CONFIG_USB_GADGET_DWC2_OTG) #include <usb.h> #include <usb/dwc2_udc.h> diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c b/arch/arm/mach-rockchip/rk3288-board-spl.c index e0d92a6..ae509ff 100644 --- a/arch/arm/mach-rockchip/rk3288-board-spl.c +++ b/arch/arm/mach-rockchip/rk3288-board-spl.c @@ -280,7 +280,3 @@ err: /* No way to report error here */ hang(); } - -void lowlevel_init(void) -{ -} diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h index d3d4c68..e909ef9 100644 --- a/include/configs/rk3288_common.h +++ b/include/configs/rk3288_common.h @@ -11,6 +11,7 @@ #include <asm/arch/hardware.h> +#define CONFIG_SKIP_LOWLEVEL_INIT_ONLY #define CONFIG_SYS_NO_FLASH #define CONFIG_NR_DRAM_BANKS 1 #define CONFIG_ENV_SIZE 0x2000 -- 2.9.2

2 2

[U-Boot] [PATCH v3 0/7] rk3399: enable host controllers
by Kever Yang 06 Sep '16

06 Sep '16

rk3399 evb has two typec port(dwc3 controller) which support dual role device with separate GPIO for vbus control and two USB 2.0 host port (generic EHCI controller) with one GPIO for vbus control. This patch set enable all these host controllers and have test with usb disk and usb ethernet devices on rk3399 evb. Note: type-C port only support usb 2.0 currently because the PD driver and USB 3.0 phy driver not enabled. Changes in v3: - using fdtdec_get_bool and fdtdec_get_int instead of fdt_get_property - other update by follow comments from Marek and Simon - add Acked-by tag from Simon Changes in v2: - update for comments from Marek - use regulator_get_by_platname instead of uclass_get_device_by_name - add Acked-by Tag from Simon Kever Yang (3): dts: rk3399-evb: add regulator-fixed for usb host vbus board: evb-rk3399: enable usb 2.0 host vbus power on board_init config: evb-rk3399: enable fixed regulator MengDongyang (4): usb: xhci-rockchip: add rockchip dwc3 controller driver rockchip: select DM_USB for rockchip SoC config: rk3399: add usb related configs dts: rk3399: add dwc3_typec node for rk3399 arch/arm/Kconfig | 1 + arch/arm/dts/rk3399-evb.dts | 14 +++ arch/arm/dts/rk3399.dtsi | 45 +++++++ board/rockchip/evb_rk3399/evb-rk3399.c | 15 ++- configs/evb-rk3399_defconfig | 9 ++ drivers/usb/host/Makefile | 1 + drivers/usb/host/xhci-rockchip.c | 211 +++++++++++++++++++++++++++++++++ include/configs/rk3399_common.h | 13 ++ include/linux/usb/dwc3.h | 14 +++ 9 files changed, 322 insertions(+), 1 deletion(-) create mode 100644 drivers/usb/host/xhci-rockchip.c -- 1.9.1

3 17

Re: [U-Boot] ext4 delete file fails when ext4 extents enabled in filesystem
by Brüns, Stefan 05 Sep '16

05 Sep '16

On Donnerstag, 1. September 2016 19:25:30 CEST you wrote: > On Donnerstag, 1. September 2016 16:08:51 CEST you wrote: > > Hi Stefan, > > > > applying patch [U-Boot,v4,06/13]ext4 and Michael Walles patch > > [U-Boot,v4,3/4]ext4, I'm now able to write into directories on ext4 fs > > from > > u-boot. However, when deleting a given file (i.e. when writing to an > > existing filename), u-boot crashes when ext4 extents are enabled. > > > > Some debugging showd that blknr from 'read_allocated_block' function > > returns negative value. I can only guess, maybe its due to 64 bit values > > calculated from ee_start_hi and ee_start_lo entries in the ext4_extent > > structure. > > > > When disabling extents in the ext4 fs, deleting a given file is working. > > Hi Thomas, > > U-boots ext4 implementation currently does not support 64bit or even 48bit > block numbers, so this may be the cause. > > Can you provide some information about your test setup? > > You can use the debugsfs ext tool to gather some information about the > problematic file. Just access the filesystem with: > > /sbin/debugfs /dev/sda1 ; (or whatever your partion name is) > > or > > /sbin/debugfs /path/to/imagefile > > debugfs supports commands like cd, stat, ls. stat gives you the block number > list. > > Kind regards, > > Stefan Hi Thomas, short followup: read_allocated_blocks returns either 0 or -1 in case of an error. Unfortunately, the return value is only checked for 0 equality in most/all? cases, and seemingly my patch series introduced some more occasions. Now, what *should* read_allocated_blocks return in case of an error? Either: - 0: a file block can never be allocated as block 0, as that is always in use by the superblock and/or the bootsector block. - <0: Extents allow 48 bit block numbers. "Limiting" the return value to the positive half of int64_t for valid block numbers and and reserving negative values for error codes is fine. I would go for negative error codes, as these are more expressive. Comments/ opinions welcome! I will update the patch series for correct checking of read_allocated_blocks return values and fix all the other block number checks. Anyway, it would be good to know why *exactly* read_allocated_blocks returns an error code in your case. Do you remember the exact negative value returned (there are -EINVAL and -ENOMEN, and many several unspecific uses of 0 and -1). Can you provide a disk image of the failing file system? Kind regards, Stefan

2 2

[U-Boot] usb start on a specific instance
by Nicolas le bayon 05 Sep '16

05 Sep '16

Hi, Would it be possible to execute an "usb start" on one single instance in order to save boot time. Indeed, regarding the different USB ports on my platform, it takes a long time to scan all the instances. Because my boot system will always be on a specific instance, would it be possible to scan only this instance? Thanks in advance for your answers. Best Regards Nicolas

1 0