March 2016 - U-Boot

[U-Boot] [PATCH] mips: Report reloc information in bdinfo
by tim.chick 10 Apr '16

10 Apr '16

Signed-off-by: tim.chick <tim.chick(a)mediatek.com> --- cmd/bdinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 8eda68b..1c4bed9 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -341,6 +341,8 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) print_eth(0); printf("ip_addr = %s\n", getenv("ipaddr")); printf("baudrate = %u bps\n", gd->baudrate); + print_num("relocaddr", gd->relocaddr); + print_num("reloc off", gd->reloc_off); return 0; } -- 2.1.4

2 1

[U-Boot] ext4 and caching
by Eric Nelson 10 Apr '16

10 Apr '16

Hi all, I've been seeing the same sort of issues repoted by Ionut and as addressed by this patch: http://lists.denx.de/pipermail/u-boot/2014-January/171459.html That patch was added in commit fc0fc50 and reverted in commit 715b56f. It no longer applies cleanly, and when I tried to resurrect it, I saw errors traversing directories and perhaps something went wrong with my merge. Ionut, do you have a current version of this patch? When I looked a little further, I found that a read of a ~150 MiB was around 30x slower than typical, and that the **same** 8 blocks accounted for the majority of the reads. In fact, these same blocks were read back-to-back. The following is a quick picture of the output from a simple printf in mmc_bread of the block number and count during a load of the problem file. ~$ uniq -c < mmc_bread.log | sort -n 1 mmc_bread: 0/1 1 mmc_bread: 2293760/1 1 mmc_bread: 2293762/2 1 mmc_bread: 2293768/1 1 mmc_bread: 2293768/1 1 mmc_bread: 2293768/1 1 mmc_bread: 2293768/1 1 mmc_bread: 2295264/1 1 mmc_bread: 2295270/1 1 mmc_bread: 2295290/1 1 mmc_bread: 2295645/1 1 mmc_bread: 7536640/131072 1 mmc_bread: 7667712/32768 1 mmc_bread: 7700480/16384 1 mmc_bread: 7729152/65536 1 mmc_bread: 7798784/130722 1 mmc_bread: 7929506/1 1 mmc_init: 0, time 129 2 mmc_bread: 0/1 6 mmc_bread: 2359120/1 10 mmc_bread: 2358752/1 34 mmc_bread: 2358808/1 2048 mmc_bread: 2557936/8 4096 mmc_bread: 2557936/8 8193 mmc_bread: 2557936/8 16340 mmc_bread: 2557936/8 16384 mmc_bread: 2557936/8 ~$ sort < mmc_bread.log | uniq -c | sort -n | tail -n 1 47061 mmc_bread: 2557936/8 In English, the 8 blocks starting at 2557936 are read 47061 times, and back to back in large (2k/4k/16k) bunches, so a very simple **single** block cache of the last read will fix the speed issue and I hacked something up to verify that. Is anybody else working on things in this area? I think this is something that's probably easier to fix at the block device level rather than within the ext4 filesystem code. That said, the 2k/4k/16k bunches above may also indicate a simpler fix in the ext4 code. Please chime in with your thoughts. Regards, Eric Nelson

5 19

[U-Boot] [PATCH] dm: i2c: mxc_i2c: implement i2c_idle_bus
by Peng Fan 09 Apr '16

09 Apr '16

Implement i2c_idle_bus in driver, then setup_i2c can be dropped for boards which enable DM_I2C/DM_GPIO/PINCTRL. The i2c_idle_bus force bus idle flow follows setup_i2c in arch/arm/imx-common/i2c-mxv7.c This patch is an implementation following linux kernel patch: " commit 1c4b6c3bcf30d0804db0d0647d8ebeb862c6f7e5 Author: Gao Pan <b54642(a)freescale.com> Date: Fri Oct 23 20:28:54 2015 +0800 i2c: imx: implement bus recovery Implement bus recovery methods for i2c-imx so we can recover from situations where SCL/SDA are stuck low. Once i2c bus SCL/SDA are stuck low during transfer, config the i2c pinctrl to gpio mode by calling pinctrl sleep set function, and then use GPIO to emulate the i2c protocol to send nine dummy clock to recover i2c device. After recovery, set i2c pinctrl to default group setting. " See Documentation/devicetree/bindings/i2c/i2c-imx.txt for detailed description. 1. Introuduce scl_gpio/sda_gpio/bus in mxc_i2c_bus. 2. Discard the __weak attribute for i2c_idle_bus and implement it, since we have pinctrl driver/driver model gpio driver. We can use device tree, but not let board code to do this. 3. gpio state for mxc_i2c is not a must, but it is recommended. If there is no gpio state, driver will give tips, but not fail. 4. The i2c controller was first probed, default pinctrl state will be used, so when need to use gpio function, need to do "pinctrl_select_state(dev, "gpio")" and after force bus idle, need to switch back "pinctrl_select_state(dev, "default")". This is example about how to use the gpio force bus idle function: " &i2c1 { clock-frequency = <100000>; pinctrl-names = "default", "gpio"; pinctrl-0 = <&pinctrl_i2c1>; pinctrl-1 = <&pinctrl_i2c1_gpio>; scl-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; sda-gpios = <&gpio1 29 GPIO_ACTIVE_HIGH>; status = "okay"; [....] }; [.....] pinctrl_i2c1_gpio: i2c1grp_gpio { fsl,pins = < MX6UL_PAD_UART4_TX_DATA__GPIO1_IO28 0x1b8b0 MX6UL_PAD_UART4_RX_DATA__GPIO1_IO29 0x1b8b0 >; }; " Signed-off-by: Peng Fan <van.freenix(a)gmail.com> Cc: Albert Aribaud <albert.u.boot(a)aribaud.net> Cc: Stefano Babic <sbabic(a)denx.de> Cc: Heiko Schocher <hs(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> Cc: York Sun <york.sun(a)nxp.com> --- arch/arm/include/asm/imx-common/mxc_i2c.h | 10 +++ drivers/i2c/mxc_i2c.c | 101 +++++++++++++++++++++++++++--- 2 files changed, 102 insertions(+), 9 deletions(-) diff --git a/arch/arm/include/asm/imx-common/mxc_i2c.h b/arch/arm/include/asm/imx-common/mxc_i2c.h index 355b25e..b0b6d61 100644 --- a/arch/arm/include/asm/imx-common/mxc_i2c.h +++ b/arch/arm/include/asm/imx-common/mxc_i2c.h @@ -5,6 +5,7 @@ */ #ifndef __ASM_ARCH_MXC_MXC_I2C_H__ #define __ASM_ARCH_MXC_MXC_I2C_H__ +#include <asm-generic/gpio.h> #include <asm/imx-common/iomux-v3.h> struct i2c_pin_ctrl { @@ -30,6 +31,10 @@ struct i2c_pads_info { * The following two is only to be compatible with non-DM part. * @idle_bus_fn: function to force bus idle * @idle_bus_data: parameter for idle_bus_fun + * For DM: + * bus: The device structure for i2c bus controller + * scl-gpio: specify the gpio related to SCL pin + * sda-gpio: specify the gpio related to SDA pin */ struct mxc_i2c_bus { /* @@ -46,6 +51,11 @@ struct mxc_i2c_bus { #ifndef CONFIG_DM_I2C int (*idle_bus_fn)(void *p); void *idle_bus_data; +#else + struct udevice *bus; + /* Use gpio to force bus idle when bus state is abnormal */ + struct gpio_desc scl_gpio; + struct gpio_desc sda_gpio; #endif }; diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index b2d15c9..445fa21 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -23,6 +23,7 @@ #include <i2c.h> #include <watchdog.h> #include <dm.h> +#include <dm/pinctrl.h> #include <fdtdec.h> DECLARE_GLOBAL_DATA_PTR; @@ -334,17 +335,74 @@ int i2c_idle_bus(struct mxc_i2c_bus *i2c_bus) } #else /* - * Since pinmux is not supported, implement a weak function here. - * You can implement your i2c_bus_idle in board file. When pinctrl - * is supported, this can be removed. + * See Linux Documentation/devicetree/bindings/i2c/i2c-imx.txt + * " + * scl-gpios: specify the gpio related to SCL pin + * sda-gpios: specify the gpio related to SDA pin + * add pinctrl to configure i2c pins to gpio function for i2c + * bus recovery, call it "gpio" state + * " + * + * The i2c_idle_bus is an implementation following Linux Kernel. */ -int __i2c_idle_bus(struct mxc_i2c_bus *i2c_bus) +int i2c_idle_bus(struct mxc_i2c_bus *i2c_bus) { - return 0; -} + struct udevice *bus = i2c_bus->bus; + struct gpio_desc *scl_gpio = &i2c_bus->scl_gpio; + struct gpio_desc *sda_gpio = &i2c_bus->sda_gpio; + int sda, scl; + int i, ret = 0; + ulong elapsed, start_time; -int i2c_idle_bus(struct mxc_i2c_bus *i2c_bus) - __attribute__((weak, alias("__i2c_idle_bus"))); + if (pinctrl_select_state(bus, "gpio")) { + dev_dbg(bus, "Can not to switch to use gpio pinmux\n"); + /* + * GPIO pinctrl for i2c force idle is not a must, + * but it is strongly recommended to be used. + * Because it can help you to recover from bad + * i2c bus state. Do not return failure, because + * it is not a must. + */ + return 0; + } + + dm_gpio_set_dir_flags(scl_gpio, GPIOD_IS_IN); + dm_gpio_set_dir_flags(sda_gpio, GPIOD_IS_IN); + scl = dm_gpio_get_value(scl_gpio); + sda = dm_gpio_get_value(sda_gpio); + + if ((sda & scl) == 1) + goto exit; /* Bus is idle already */ + + /* Send high and low on the SCL line */ + for (i = 0; i < 9; i++) { + dm_gpio_set_dir_flags(scl_gpio, GPIOD_IS_OUT); + dm_gpio_set_value(scl_gpio, 0); + udelay(50); + dm_gpio_set_dir_flags(scl_gpio, GPIOD_IS_IN); + udelay(50); + } + start_time = get_timer(0); + for (;;) { + dm_gpio_set_dir_flags(scl_gpio, GPIOD_IS_IN); + dm_gpio_set_dir_flags(sda_gpio, GPIOD_IS_IN); + scl = dm_gpio_get_value(scl_gpio); + sda = dm_gpio_get_value(sda_gpio); + if ((sda & scl) == 1) + break; + WATCHDOG_RESET(); + elapsed = get_timer(start_time); + if (elapsed > (CONFIG_SYS_HZ / 5)) { /* .2 seconds */ + ret = -EBUSY; + printf("%s: failed to clear bus, sda=%d scl=%d\n", __func__, sda, scl); + break; + } + } + +exit: + pinctrl_select_state(bus, "default"); + return ret; +} #endif static int i2c_init_transfer(struct mxc_i2c_bus *i2c_bus, u8 chip, @@ -664,8 +722,10 @@ static int mxc_i2c_set_bus_speed(struct udevice *bus, unsigned int speed) static int mxc_i2c_probe(struct udevice *bus) { struct mxc_i2c_bus *i2c_bus = dev_get_priv(bus); + const void *fdt = gd->fdt_blob; + int node = bus->of_offset; fdt_addr_t addr; - int ret; + int ret, ret2; i2c_bus->driver_data = dev_get_driver_data(bus); @@ -675,12 +735,35 @@ static int mxc_i2c_probe(struct udevice *bus) i2c_bus->base = addr; i2c_bus->index = bus->seq; + i2c_bus->bus = bus; /* Enable clk */ ret = enable_i2c_clk(1, bus->seq); if (ret < 0) return ret; + /* + * See Documentation/devicetree/bindings/i2c/i2c-imx.txt + * Use gpio to force bus idle when necessary. + */ + ret = fdt_find_string(fdt, node, "pinctrl-names", "gpio"); + if (ret < 0) { + dev_info(dev, "i2c bus %d at %lu, no gpio pinctrl state.\n", bus->seq, i2c_bus->base); + } else { + ret = gpio_request_by_name_nodev(fdt, node, "scl-gpios", + 0, &i2c_bus->scl_gpio, + GPIOD_IS_OUT); + ret2 = gpio_request_by_name_nodev(fdt, node, "sda-gpios", + 0, &i2c_bus->sda_gpio, + GPIOD_IS_OUT); + if (!dm_gpio_is_valid(&i2c_bus->sda_gpio) | + !dm_gpio_is_valid(&i2c_bus->scl_gpio) | + ret | ret2) { + dev_err(dev, "i2c bus %d at %lu, fail to request scl/sda gpio\n", bus->seq, i2c_bus->base); + return -ENODEV; + } + } + ret = i2c_idle_bus(i2c_bus); if (ret < 0) { /* Disable clk */ -- 2.6.2

3 4

[U-Boot] mtd; spi-nor: Probing dual uclass drivers from cmd
by Jagan Teki 09 Apr '16

09 Apr '16

Hi Simon and All, SPI-NOR with MTD uclass framework, we need to probe the two different uclass drivers from command like UCLASS_SPI and UCLASS_MTD UCLASS_SPI: will detect the spi drivers from drivers/spi and probe the m25p80 flash UCLASS_MTD: will detect the spi-nor drivers from drivers/mtd/spi-nor and probe the flash. like this: spi0 = &spi1; mtd1 = &qspi; I have written a sample routine to move the respective frameworks like spi and spi-nor, so based on the command bus number the respective driver need to probe. Issue here is if I use 'sf probe 1' it's probing the MTD uclass but the UCLASS_SPI error message is showing as "Invalid bus 0" Did you ever handling this kind of dual probe? I couldn't find it on the source? any suggestions? sample code: -------------------- int spi_flash_probe_bus_cs(unsigned int busnum, unsigned int cs, unsigned int max_hz, unsigned int spi_mode, struct udevice **devp) { struct spi_slave *slave; struct dm_mtd_ops *ops; struct udevice *bus; char name[30], *str; int ret; printf("Probe for SPI\n"); snprintf(name, sizeof(name), "spi-nor@%d:%d", busnum, cs); str = strdup(name); ret = spi_get_bus_and_cs(busnum, cs, max_hz, spi_mode, "m25p80", str, &bus, &slave); if (!ret) { *devp = slave->dev; return 0; } printf("Probe for MTD\n"); ret = uclass_get_device_by_seq(UCLASS_MTD, busnum, &bus); if (ret) { printf("Invalid bus %d (err=%d)\n", busnum, ret); return ret; } ops = mtd_get_ops(bus); ret = ops->probe_dev(bus); if (ret) return ret; *devp = bus; return 0; } -- Jagan.

2 1

[U-Boot] [PATCH v8 5/9] drivers: pinctrl: Add simple pinctrl driver for QCA/Athores qca953x.
by Wills Wang 09 Apr '16

09 Apr '16

This is a simple pinctrl driver, it just support uart and spi pin-mux now. Signed-off-by: Wills Wang <wills.wang(a)live.com> --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/pinctrl/Kconfig | 9 ++ drivers/pinctrl/ath79/Makefile | 1 + drivers/pinctrl/ath79/pinctrl_qca953x.c | 156 ++++++++++++++++++++++++++++++++ 3 files changed, 166 insertions(+) create mode 100644 drivers/pinctrl/ath79/pinctrl_qca953x.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 854d5a5..567b766 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -114,6 +114,15 @@ config AR933X_PINCTRL both the GPIO definitions and pin control functions for each available multiplex function. +config QCA953X_PINCTRL + bool "QCA/Athores qca953x pin control driver" + depends on DM && SOC_QCA953X + help + Support pin multiplexing control on QCA/Athores qca953x SoCs. + The driver is controlled by a device tree node which contains + both the GPIO definitions and pin control functions for each + available multiplex function. + config ROCKCHIP_PINCTRL bool "Rockchip pin control driver" depends on DM diff --git a/drivers/pinctrl/ath79/Makefile b/drivers/pinctrl/ath79/Makefile index 3fdcf6c..dcea10a 100644 --- a/drivers/pinctrl/ath79/Makefile +++ b/drivers/pinctrl/ath79/Makefile @@ -3,3 +3,4 @@ # obj-$(CONFIG_AR933X_PINCTRL) += pinctrl_ar933x.o +obj-$(CONFIG_QCA953x_PINCTRL) += pinctrl_qca953x.o diff --git a/drivers/pinctrl/ath79/pinctrl_qca953x.c b/drivers/pinctrl/ath79/pinctrl_qca953x.c new file mode 100644 index 0000000..d02597e --- /dev/null +++ b/drivers/pinctrl/ath79/pinctrl_qca953x.c @@ -0,0 +1,156 @@ +/* + * Copyright (C) 2015-2016 Wills Wang <wills.wang(a)live.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include <common.h> +#include <dm.h> +#include <errno.h> +#include <asm/io.h> +#include <dm/pinctrl.h> +#include <mach/ar71xx_regs.h> + +DECLARE_GLOBAL_DATA_PTR; + +enum periph_id { + PERIPH_ID_UART0, + PERIPH_ID_SPI0, + PERIPH_ID_NONE = -1, +}; + +struct qca953x_pinctrl_priv { + void __iomem *regs; +}; + +static void pinctrl_qca953x_spi_config(struct qca953x_pinctrl_priv *priv, int cs) +{ + switch (cs) { + case 0: + clrsetbits_be32(priv->regs + AR71XX_GPIO_REG_OE, + QCA953X_GPIO(5) | QCA953X_GPIO(6) | + QCA953X_GPIO(7), QCA953X_GPIO(8)); + + clrsetbits_be32(priv->regs + QCA953X_GPIO_REG_OUT_FUNC1, + QCA953X_GPIO_MUX_MASK(8) | + QCA953X_GPIO_MUX_MASK(16) | + QCA953X_GPIO_MUX_MASK(24), + (QCA953X_GPIO_OUT_MUX_SPI_CS0 << 8) | + (QCA953X_GPIO_OUT_MUX_SPI_CLK << 16) | + (QCA953X_GPIO_OUT_MUX_SPI_MOSI << 24)); + + clrsetbits_be32(priv->regs + QCA953X_GPIO_REG_IN_ENABLE0, + QCA953X_GPIO_MUX_MASK(0), + QCA953X_GPIO_IN_MUX_SPI_DATA_IN); + + setbits_be32(priv->regs + AR71XX_GPIO_REG_OUT, + QCA953X_GPIO(8)); + break; + } +} + +static void pinctrl_qca953x_uart_config(struct qca953x_pinctrl_priv *priv, int uart_id) +{ + switch (uart_id) { + case PERIPH_ID_UART0: + clrsetbits_be32(priv->regs + AR71XX_GPIO_REG_OE, + QCA953X_GPIO(9), QCA953X_GPIO(10)); + + clrsetbits_be32(priv->regs + QCA953X_GPIO_REG_OUT_FUNC2, + QCA953X_GPIO_MUX_MASK(16), + QCA953X_GPIO_OUT_MUX_UART0_SOUT << 16); + + clrsetbits_be32(priv->regs + QCA953X_GPIO_REG_IN_ENABLE0, + QCA953X_GPIO_MUX_MASK(8), + QCA953X_GPIO_IN_MUX_UART0_SIN << 8); + + setbits_be32(priv->regs + AR71XX_GPIO_REG_OUT, + QCA953X_GPIO(10)); + break; + } +} + +static int qca953x_pinctrl_request(struct udevice *dev, int func, int flags) +{ + struct qca953x_pinctrl_priv *priv = dev_get_priv(dev); + + debug("%s: func=%x, flags=%x\n", __func__, func, flags); + switch (func) { + case PERIPH_ID_SPI0: + pinctrl_qca953x_spi_config(priv, flags); + break; + case PERIPH_ID_UART0: + pinctrl_qca953x_uart_config(priv, func); + break; + default: + return -EINVAL; + } + + return 0; +} + +static int qca953x_pinctrl_get_periph_id(struct udevice *dev, + struct udevice *periph) +{ + u32 cell[2]; + int ret; + + ret = fdtdec_get_int_array(gd->fdt_blob, periph->of_offset, + "interrupts", cell, ARRAY_SIZE(cell)); + if (ret < 0) + return -EINVAL; + + switch (cell[0]) { + case 128: + return PERIPH_ID_UART0; + case 129: + return PERIPH_ID_SPI0; + } + return -ENOENT; +} + +static int qca953x_pinctrl_set_state_simple(struct udevice *dev, + struct udevice *periph) +{ + int func; + + func = qca953x_pinctrl_get_periph_id(dev, periph); + if (func < 0) + return func; + return qca953x_pinctrl_request(dev, func, 0); +} + +static struct pinctrl_ops qca953x_pinctrl_ops = { + .set_state_simple = qca953x_pinctrl_set_state_simple, + .request = qca953x_pinctrl_request, + .get_periph_id = qca953x_pinctrl_get_periph_id, +}; + +static int qca953x_pinctrl_probe(struct udevice *dev) +{ + struct qca953x_pinctrl_priv *priv = dev_get_priv(dev); + fdt_addr_t addr; + + addr = dev_get_addr(dev); + if (addr == FDT_ADDR_T_NONE) + return -EINVAL; + + priv->regs = map_physmem(addr, + AR71XX_GPIO_SIZE, + MAP_NOCACHE); + return 0; +} + +static const struct udevice_id qca953x_pinctrl_ids[] = { + { .compatible = "qca,qca953x-pinctrl" }, + { } +}; + +U_BOOT_DRIVER(pinctrl_qca953x) = { + .name = "pinctrl_qca953x", + .id = UCLASS_PINCTRL, + .of_match = qca953x_pinctrl_ids, + .priv_auto_alloc_size = sizeof(struct qca953x_pinctrl_priv), + .ops = &qca953x_pinctrl_ops, + .probe = qca953x_pinctrl_probe, +}; -- 1.9.1

2 1

[U-Boot] [PATCH v8 4/9] drivers: pinctrl: Add simple pinctrl driver for QCA/Athores ar933x.
by Wills Wang 09 Apr '16

09 Apr '16

This is a simple pinctrl driver, it just support uart and spi pin-mux now. Signed-off-by: Wills Wang <wills.wang(a)live.com> --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/pinctrl/Kconfig | 9 +++ drivers/pinctrl/Makefile | 1 + drivers/pinctrl/ath79/Makefile | 5 ++ drivers/pinctrl/ath79/pinctrl_ar933x.c | 136 +++++++++++++++++++++++++++++++++ 4 files changed, 151 insertions(+) create mode 100644 drivers/pinctrl/ath79/Makefile create mode 100644 drivers/pinctrl/ath79/pinctrl_ar933x.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 2a69bab..854d5a5 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -105,6 +105,15 @@ config SPL_PINCONF if PINCTRL || SPL_PINCTRL +config AR933X_PINCTRL + bool "QCA/Athores ar933x pin control driver" + depends on DM && SOC_AR933X + help + Support pin multiplexing control on QCA/Athores ar933x SoCs. + The driver is controlled by a device tree node which contains + both the GPIO definitions and pin control functions for each + available multiplex function. + config ROCKCHIP_PINCTRL bool "Rockchip pin control driver" depends on DM diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 37dc904..b99ed2f 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -6,6 +6,7 @@ obj-y += pinctrl-uclass.o obj-$(CONFIG_$(SPL_)PINCTRL_GENERIC) += pinctrl-generic.o obj-y += nxp/ +obj-$(CONFIG_ARCH_ATH79) += ath79/ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/ obj-$(CONFIG_PINCTRL_SANDBOX) += pinctrl-sandbox.o diff --git a/drivers/pinctrl/ath79/Makefile b/drivers/pinctrl/ath79/Makefile new file mode 100644 index 0000000..3fdcf6c --- /dev/null +++ b/drivers/pinctrl/ath79/Makefile @@ -0,0 +1,5 @@ +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-$(CONFIG_AR933X_PINCTRL) += pinctrl_ar933x.o diff --git a/drivers/pinctrl/ath79/pinctrl_ar933x.c b/drivers/pinctrl/ath79/pinctrl_ar933x.c new file mode 100644 index 0000000..e3f64b6 --- /dev/null +++ b/drivers/pinctrl/ath79/pinctrl_ar933x.c @@ -0,0 +1,136 @@ +/* + * Copyright (C) 2015-2016 Wills Wang <wills.wang(a)live.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include <common.h> +#include <dm.h> +#include <errno.h> +#include <asm/io.h> +#include <dm/pinctrl.h> +#include <mach/ar71xx_regs.h> + +DECLARE_GLOBAL_DATA_PTR; + +enum periph_id { + PERIPH_ID_UART0, + PERIPH_ID_SPI0, + PERIPH_ID_NONE = -1, +}; + +struct ar933x_pinctrl_priv { + void __iomem *regs; +}; + +static void pinctrl_ar933x_spi_config(struct ar933x_pinctrl_priv *priv, int cs) +{ + switch (cs) { + case 0: + clrsetbits_be32(priv->regs + AR71XX_GPIO_REG_OE, + AR933X_GPIO(4), AR933X_GPIO(3) | + AR933X_GPIO(5) | AR933X_GPIO(2)); + setbits_be32(priv->regs + AR71XX_GPIO_REG_FUNC, + AR933X_GPIO_FUNC_SPI_EN | + AR933X_GPIO_FUNC_RES_TRUE); + break; + } +} + +static void pinctrl_ar933x_uart_config(struct ar933x_pinctrl_priv *priv, int uart_id) +{ + switch (uart_id) { + case PERIPH_ID_UART0: + clrsetbits_be32(priv->regs + AR71XX_GPIO_REG_OE, + AR933X_GPIO(9), AR933X_GPIO(10)); + setbits_be32(priv->regs + AR71XX_GPIO_REG_FUNC, + AR933X_GPIO_FUNC_UART_EN | + AR933X_GPIO_FUNC_RES_TRUE); + break; + } +} + +static int ar933x_pinctrl_request(struct udevice *dev, int func, int flags) +{ + struct ar933x_pinctrl_priv *priv = dev_get_priv(dev); + + debug("%s: func=%x, flags=%x\n", __func__, func, flags); + switch (func) { + case PERIPH_ID_SPI0: + pinctrl_ar933x_spi_config(priv, flags); + break; + case PERIPH_ID_UART0: + pinctrl_ar933x_uart_config(priv, func); + break; + default: + return -EINVAL; + } + + return 0; +} + +static int ar933x_pinctrl_get_periph_id(struct udevice *dev, + struct udevice *periph) +{ + u32 cell[2]; + int ret; + + ret = fdtdec_get_int_array(gd->fdt_blob, periph->of_offset, + "interrupts", cell, ARRAY_SIZE(cell)); + if (ret < 0) + return -EINVAL; + + switch (cell[0]) { + case 128: + return PERIPH_ID_UART0; + case 129: + return PERIPH_ID_SPI0; + } + return -ENOENT; +} + +static int ar933x_pinctrl_set_state_simple(struct udevice *dev, + struct udevice *periph) +{ + int func; + + func = ar933x_pinctrl_get_periph_id(dev, periph); + if (func < 0) + return func; + return ar933x_pinctrl_request(dev, func, 0); +} + +static struct pinctrl_ops ar933x_pinctrl_ops = { + .set_state_simple = ar933x_pinctrl_set_state_simple, + .request = ar933x_pinctrl_request, + .get_periph_id = ar933x_pinctrl_get_periph_id, +}; + +static int ar933x_pinctrl_probe(struct udevice *dev) +{ + struct ar933x_pinctrl_priv *priv = dev_get_priv(dev); + fdt_addr_t addr; + + addr = dev_get_addr(dev); + if (addr == FDT_ADDR_T_NONE) + return -EINVAL; + + priv->regs = map_physmem(addr, + AR71XX_GPIO_SIZE, + MAP_NOCACHE); + return 0; +} + +static const struct udevice_id ar933x_pinctrl_ids[] = { + { .compatible = "qca,ar933x-pinctrl" }, + { } +}; + +U_BOOT_DRIVER(pinctrl_ar933x) = { + .name = "pinctrl_ar933x", + .id = UCLASS_PINCTRL, + .of_match = ar933x_pinctrl_ids, + .priv_auto_alloc_size = sizeof(struct ar933x_pinctrl_priv), + .ops = &ar933x_pinctrl_ops, + .probe = ar933x_pinctrl_probe, +}; -- 1.9.1

2 1

[U-Boot] [PATCH] test/dm/core.c: Make pre-reloc test use pre-reloc struct
by Tom Rini 09 Apr '16

09 Apr '16

LLVM 3.5 noted: test/dm/core.c:41:35: warning: unused variable 'test_pdata_pre_reloc' [-Wunused-const-variable] static const struct dm_test_pdata test_pdata_pre_reloc = { And the correct fix here is that the driver_info_pre_reloc test should use the test_pdata_pre_reloc not test_pdata_manual variable Cc: Simon Glass <sjg(a)chromium.org> Signed-off-by: Tom Rini <trini(a)konsulko.com> --- test/dm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dm/core.c b/test/dm/core.c index 9fbc70d..70bf4d0 100644 --- a/test/dm/core.c +++ b/test/dm/core.c @@ -64,7 +64,7 @@ static struct driver_info driver_info_manual = { static struct driver_info driver_info_pre_reloc = { .name = "test_pre_reloc_drv", - .platdata = &test_pdata_manual, + .platdata = &test_pdata_pre_reloc, }; void dm_leak_check_start(struct unit_test_state *uts) -- 1.7.9.5

2 2

[U-Boot] [PATCH v2 1/2] doc: driver-model: Update dm tests run using test.py
by Jagan Teki 09 Apr '16

09 Apr '16

Since all the tests are implemented in pytest infrastructure, So update the dm tests with the same instead of ./test/dm/test-dm.sh Cc: Tom Rini <trini(a)konsulko.com> Cc: Simon Glass <sjg(a)chromium.org> Acked-by: Stephen Warren <swarren(a)nvidia.com> Signed-off-by: Jagan Teki <jteki(a)openedev.com> --- doc/driver-model/README.txt | 229 +++++++++++++++++++++++++------------------- 1 file changed, 128 insertions(+), 101 deletions(-) diff --git a/doc/driver-model/README.txt b/doc/driver-model/README.txt index b891e84..7a24552 100644 --- a/doc/driver-model/README.txt +++ b/doc/driver-model/README.txt @@ -90,110 +90,137 @@ The intent with driver model is that the core portion has 100% test coverage in sandbox, and every uclass has its own test. As a move towards this, tests are provided in test/dm. To run them, try: - ./test/dm/test-dm.sh + ./test/py/test.py --bd sandbox --build -k ut_dm -v You should see something like this: - <...U-Boot banner...> - Running 53 driver model tests - Test: dm_test_autobind - Test: dm_test_autoprobe - Test: dm_test_bus_child_post_bind - Test: dm_test_bus_child_post_bind_uclass - Test: dm_test_bus_child_pre_probe_uclass - Test: dm_test_bus_children - Device 'c-test@0': seq 0 is in use by 'd-test' - Device 'c-test@1': seq 1 is in use by 'f-test' - Test: dm_test_bus_children_funcs - Test: dm_test_bus_children_iterators - Test: dm_test_bus_parent_data - Test: dm_test_bus_parent_data_uclass - Test: dm_test_bus_parent_ops - Test: dm_test_bus_parent_platdata - Test: dm_test_bus_parent_platdata_uclass - Test: dm_test_children - Test: dm_test_device_get_uclass_id - Test: dm_test_eth - Using eth@10002000 device - Using eth@10003000 device - Using eth@10004000 device - Test: dm_test_eth_alias - Using eth@10002000 device - Using eth@10004000 device - Using eth@10002000 device - Using eth@10003000 device - Test: dm_test_eth_prime - Using eth@10003000 device - Using eth@10002000 device - Test: dm_test_eth_rotate - - Error: eth@10004000 address not set. - - Error: eth@10004000 address not set. - Using eth@10002000 device - - Error: eth@10004000 address not set. - - Error: eth@10004000 address not set. - Using eth@10004000 device - Test: dm_test_fdt - Test: dm_test_fdt_offset - Test: dm_test_fdt_pre_reloc - Test: dm_test_fdt_uclass_seq - Test: dm_test_gpio - extra-gpios: get_value: error: gpio b5 not reserved - Test: dm_test_gpio_anon - Test: dm_test_gpio_copy - Test: dm_test_gpio_leak - extra-gpios: get_value: error: gpio b5 not reserved - Test: dm_test_gpio_phandles - Test: dm_test_gpio_requestf - Test: dm_test_i2c_bytewise - Test: dm_test_i2c_find - Test: dm_test_i2c_offset - Test: dm_test_i2c_offset_len - Test: dm_test_i2c_probe_empty - Test: dm_test_i2c_read_write - Test: dm_test_i2c_speed - Test: dm_test_leak - Test: dm_test_lifecycle - Test: dm_test_net_retry - Using eth@10004000 device - Using eth@10002000 device - Using eth@10004000 device - Test: dm_test_operations - Test: dm_test_ordering - Test: dm_test_pci_base - Test: dm_test_pci_swapcase - Test: dm_test_platdata - Test: dm_test_pre_reloc - Test: dm_test_remove - Test: dm_test_spi_find - Invalid chip select 0:0 (err=-19) - SF: Failed to get idcodes - SF: Detected M25P16 with page size 256 Bytes, erase size 64 KiB, total 2 MiB - Test: dm_test_spi_flash - 2097152 bytes written in 0 ms - SF: Detected M25P16 with page size 256 Bytes, erase size 64 KiB, total 2 MiB - SPI flash test: - 0 erase: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 1 check: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 2 write: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 3 read: 0 ticks, 65536000 KiB/s 524288.000 Mbps - Test passed - 0 erase: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 1 check: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 2 write: 0 ticks, 65536000 KiB/s 524288.000 Mbps - 3 read: 0 ticks, 65536000 KiB/s 524288.000 Mbps - Test: dm_test_spi_xfer - SF: Detected M25P16 with page size 256 Bytes, erase size 64 KiB, total 2 MiB - Test: dm_test_uclass - Test: dm_test_uclass_before_ready - Test: dm_test_usb_base - Test: dm_test_usb_flash - USB-1: scanning bus 1 for devices... 2 USB Device(s) found - Failures: 0 - +(venv)$ ./test/py/test.py --bd sandbox --build -k ut_dm -v ++make O=/root/u-boot/build-sandbox -s sandbox_defconfig ++make O=/root/u-boot/build-sandbox -s -j8 +============================= test session starts ============================== +platform linux2 -- Python 2.7.5, pytest-2.9.0, py-1.4.31, pluggy-0.3.1 -- /root/u-boot/venv/bin/python +cachedir: .cache +rootdir: /root/u-boot, inifile: +collected 199 items + +test/py/tests/test_ut.py::test_ut_dm_init PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_bind] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_multi_channel_conversion] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_multi_channel_shot] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_single_channel_conversion] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_single_channel_shot] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_supply] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_adc_wrong_channel_selection] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_autobind] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_autobind_uclass_pdata_alloc] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_autobind_uclass_pdata_valid] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_autoprobe] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_child_post_bind] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_child_post_bind_uclass] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_child_pre_probe_uclass] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_children] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_children_funcs] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_children_iterators] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_parent_data] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_parent_data_uclass] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_parent_ops] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_parent_platdata] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_bus_parent_platdata_uclass] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_children] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_clk_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_clk_periph] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_device_get_uclass_id] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_eth] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_eth_act] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_eth_alias] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_eth_prime] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_eth_rotate] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_fdt] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_fdt_offset] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_fdt_pre_reloc] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_fdt_uclass_seq] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio_anon] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio_copy] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio_leak] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio_phandles] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_gpio_requestf] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_bytewise] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_find] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_offset] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_offset_len] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_probe_empty] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_read_write] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_i2c_speed] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_leak] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_led_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_led_gpio] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_led_label] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_lifecycle] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_mmc_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_net_retry] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_operations] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_ordering] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_pci_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_pci_busnum] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_pci_swapcase] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_platdata] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_pmic_get] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_pmic_io] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_autoset] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_autoset_list] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_get] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_set_get_current] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_set_get_enable] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_set_get_mode] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_power_regulator_set_get_voltage] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_pre_reloc] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_ram_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_regmap_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_regmap_syscon] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_remoteproc_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_remove] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_reset_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_reset_walk] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_rtc_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_rtc_dual] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_rtc_reset] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_rtc_set_get] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_spi_find] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_spi_flash] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_spi_xfer] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_syscon_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_syscon_by_driver_data] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_timer_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass_before_ready] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass_devices_find] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass_devices_find_by_name] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass_devices_get] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_uclass_devices_get_by_name] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_flash] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_keyb] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_multi] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_remove] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_tree] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_tree_remove] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_usb_tree_reorder] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_base] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_bmp] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_bmp_comp] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_chars] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_context] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_rotation1] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_rotation2] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_rotation3] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_text] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_truetype] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_truetype_bs] PASSED +test/py/tests/test_ut.py::test_ut[ut_dm_video_truetype_scroll] PASSED + +======================= 84 tests deselected by '-kut_dm' ======================= +================== 115 passed, 84 deselected in 3.77 seconds =================== What is going on? ----------------- -- 1.9.1

3 7

[U-Boot] [PATCH] dm: device.c: Minor coding-style fix
by Stefan Roese 09 Apr '16

09 Apr '16

Fix multi-line comment indentation in device_bind() Signed-off-by: Stefan Roese <sr(a)denx.de> Cc: Simon Glass <sjg(a)chromium.org> --- drivers/core/device.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/core/device.c b/drivers/core/device.c index cb24a61..766c717 100644 --- a/drivers/core/device.c +++ b/drivers/core/device.c @@ -66,12 +66,12 @@ int device_bind(struct udevice *parent, const struct driver *drv, dev->req_seq = -1; if (CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(DM_SEQ_ALIAS)) { /* - * Some devices, such as a SPI bus, I2C bus and serial ports - * are numbered using aliases. - * - * This is just a 'requested' sequence, and will be - * resolved (and ->seq updated) when the device is probed. - */ + * Some devices, such as a SPI bus, I2C bus and serial ports + * are numbered using aliases. + * + * This is just a 'requested' sequence, and will be + * resolved (and ->seq updated) when the device is probed. + */ if (uc->uc_drv->flags & DM_UC_FLAG_SEQ_ALIAS) { if (uc->uc_drv->name && of_offset != -1) { fdtdec_get_alias_seq(gd->fdt_blob, -- 2.7.3

3 2

[U-Boot] [PATCH] dm: part: fix missing driver name in debug print
by Nishanth Menon 09 Apr '16

09 Apr '16

Fixes the following warning with PART_DEBUG enabled: disk/part.c: In function ‘get_partition_info’: disk/part.c:372:3: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat] Signed-off-by: Nishanth Menon <nm(a)ti.com> --- disk/part.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disk/part.c b/disk/part.c index 2a460503922c..0caf760f5257 100644 --- a/disk/part.c +++ b/disk/part.c @@ -369,7 +369,8 @@ int part_get_info(struct blk_desc *dev_desc, int part, return -EPROTONOSUPPORT; } if (!drv->get_info) { - PRINTF("## Driver %s does not have the get_info() method\n"); + PRINTF("## Driver %s does not have the get_info() method\n", + drv->name); return -ENOSYS; } if (drv->get_info(dev_desc, part, info) == 0) { -- 1.7.9.5

2 2