September 2015 - U-Boot

[U-Boot] [PATCH 1/2] dm: core: Don't use pinctrl for the root device
by Simon Glass 12 Sep '15

12 Sep '15

Currently when driver model starts up it finds the root uclass and the pinctrl uclass. This is because even the root node handles pinctrl processing. But this is not useful. The root node is not a real hardware device so cannot require any particular pinmux settings. Also it means that the memory leak tests fails, since they end up freeing more memory than they allocate: the marker it set after the root device and pinctrl uclass are allocated, and later once the pinctrl uclass is freed the memory used by driver model is less than when the marker was set. If a platform needs 'core' pin mulitplex settings it can do this with a driver that is probed on start-up. It would be an abuse of the root node to use this for pinctrl. To avoid this problem, only process pinctrl settings for non-root nodes. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- drivers/core/device.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/core/device.c b/drivers/core/device.c index 0ccd443..e44abeb 100644 --- a/drivers/core/device.c +++ b/drivers/core/device.c @@ -289,8 +289,12 @@ int device_probe_child(struct udevice *dev, void *parent_priv) dev->flags |= DM_FLAG_ACTIVATED; - /* continue regardless of the result of pinctrl */ - pinctrl_select_state(dev, "default"); + /* + * Process pinctrl for everything except the root device, and + * continue regardless of the result of pinctrl. + */ + if (dev->parent) + pinctrl_select_state(dev, "default"); ret = uclass_pre_probe_device(dev); if (ret) -- 2.6.0.rc0.131.gf624c3d

1 1

[U-Boot] [PATCH v2 1/3] ARM: cache: add an empty stub function for invalidate/flush dcache
by Josh Wu 12 Sep '15

12 Sep '15

Since some driver like ohci, lcd used dcache functions. But some ARM cpu don't implement the invalidate_dcache_range()/flush_dcache_range() functions. To avoid compiling errors this patch adds an weak empty stub function for all ARM cpu. And each cpu can implement its own implementation. If not implemented by default it will use an empty function. Signed-off-by: Josh Wu <josh.wu(a)atmel.com> --- Changes in v2: new added arch/arm/lib/cache.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c index 74cfde6..bc48f53 100644 --- a/arch/arm/lib/cache.c +++ b/arch/arm/lib/cache.c @@ -53,6 +53,15 @@ __weak void enable_caches(void) puts("WARNING: Caches not enabled\n"); } +__weak void invalidate_dcache_range(unsigned long start, unsigned long stop) +{ + /* An empty stub, real implementation should be in platform code */ +} +__weak void flush_dcache_range(unsigned long start, unsigned long stop) +{ + /* An empty stub, real implementation should be in platform code */ +} + #ifdef CONFIG_SYS_NONCACHED_MEMORY /* * Reserve one MMU section worth of address space below the malloc() area that -- 1.9.1

5 20

[U-Boot] [PATCH v2 1/1] gpio: lpc32xx: fix issues with port3 gpio
by slemieux.tyco＠gmail.com 12 Sep '15

12 Sep '15

From: Sylvain Lemieux <slemieux(a)tycoint.com> The current simplify lpc32xx gpio driver implementation assume a maximum of 32 GPIO per port; there are a total of 22 GPI, 24 GPO and 6 GPIO to managed on port 3. Update the driver to fix the following: 1) When requesting GPI_xx and GPO_xx on port 3 (xx is the same number) the second call to "gpio_request" will return -EBUSY. 2) The status of GPO_xx pin report the status of the corresponding GPI_xx pin when using the "gpio status" command. 3) The gpio driver may setup the direction register for the wrong gpio when calling "gpio_direction_input" (GPI_xx) or "gpio_direction_output" (GPO_xx) on port 3; the call to the direction is require to use the "gpio status" command. The following change were done in the driver: 1) port3 GPI are cache in a separate 32 bits in the array. 2) port3 direction register written only for GPIO pins. 3) port3 GPO & GPIO (as output) are read using "p3_outp_state". 4) LPC32XX_GPI_P3_GRP updated to match the change. Signed-off-by: Sylvain Lemieux <slemieux(a)tycoint.com> --- To reproduce the issues, the following test can be execute: 1) Add to source code: int ret1 = gpio_request(LPC32XX_GPIO(LPC32XX_GPO_P3_GRP, 19), "GPO_19"); int ret2 = gpio_request(LPC32XX_GPIO(LPC32XX_GPI_P3_GRP, 19), "GPI_19"); The second call return "-EBUSY". 2) Setup a logical 0 on GPI_19 pin --> gpio set 115 gpio: pin 115 (gpio 115) value is 1 --> gpio status 115: output: 0 [x] GPO_19 Setup a logic 1 on GPI_19 pin --> gpio clear115 gpio: pin 115 (gpio 115) value is 0 --> gpio status 115: output: 1 [x] GPO_19 3) Add to source code: (void)gpio_request(LPC32XX_GPIO(LPC32XX_GPI_P3_GRP, 25), "GPI_25"); --> gpio status 121: unknown Add to source code: (void)gpio_request(LPC32XX_GPIO(LPC32XX_GPI_P3_GRP, 25), "GPI_25"); (void)gpio_direction_input(LPC32XX_GPIO(LPC32XX_GPI_P3_GRP, 25)); --> gpio status 121: input: 0 [x] GPI_25 The direction register is written and GPIO_0 is configured as input. Changes from v1 to v2: * Regenarate the patch; the patch did not apply. Note: I am sending the patch using <slemieux.tyco(a)gmail.com>, until I can submit patch using my regular e-mail <slemieux(a)tycoint.com>. arch/arm/include/asm/arch-lpc32xx/gpio_grp.h | 4 +-- drivers/gpio/lpc32xx_gpio.c | 41 ++++++++++++++++++++++++---- 2 files changed, 37 insertions(+), 8 deletions(-) diff --git a/arch/arm/include/asm/arch-lpc32xx/gpio_grp.h b/arch/arm/include/asm/arch-lpc32xx/gpio_grp.h index c9cf9df..64acf15 100644 --- a/arch/arm/include/asm/arch-lpc32xx/gpio_grp.h +++ b/arch/arm/include/asm/arch-lpc32xx/gpio_grp.h @@ -12,7 +12,7 @@ /* * Macro to map the pin for the lpc32xx_gpio driver. - * Note: - GPIOS are considered here as homogeneous and linear, from 0 to 127; + * Note: - GPIOS are considered here as homogeneous and linear from 0 to 159; * mapping is done per register, as group of 32. * (see drivers/gpio/lpc32xx_gpio.c for details). * - macros can be use with the following pins: @@ -26,9 +26,9 @@ #define LPC32XX_GPIO_P0_GRP 0 #define LPC32XX_GPIO_P1_GRP 32 #define LPC32XX_GPIO_P2_GRP 64 -#define LPC32XX_GPI_P3_GRP 96 #define LPC32XX_GPO_P3_GRP 96 #define LPC32XX_GPIO_P3_GRP (LPC32XX_GPO_P3_GRP + 25) +#define LPC32XX_GPI_P3_GRP 128 /* * A specific GPIO can be selected with this macro diff --git a/drivers/gpio/lpc32xx_gpio.c b/drivers/gpio/lpc32xx_gpio.c index 8a9826e..9674ee7 100644 --- a/drivers/gpio/lpc32xx_gpio.c +++ b/drivers/gpio/lpc32xx_gpio.c @@ -22,7 +22,7 @@ * read on another one. * * In order to keep this code simple, GPIOS are considered here as - * homogeneous and linear, from 0 to 127. + * homogeneous and linear, from 0 to 159. * * ** WARNING #1 ** * @@ -35,7 +35,7 @@ * Please read NOTE in description of lpc32xx_gpio_get_function(). */ -#define LPC32XX_GPIOS 128 +#define LPC32XX_GPIOS 160 struct lpc32xx_gpio_priv { struct gpio_regs *regs; @@ -45,11 +45,18 @@ struct lpc32xx_gpio_priv { /** * We have 4 GPIO ports of 32 bits each + * + * Port mapping offset (32 bits each): + * - Port 0: 0 + * - Port 1: 32 + * - Port 2: 64 + * - Port 3: GPO / GPIO (output): 96 + * - Port 3: GPI: 128 */ -#define MAX_GPIO 128 +#define MAX_GPIO 160 -#define GPIO_TO_PORT(gpio) ((gpio / 32) & 3) +#define GPIO_TO_PORT(gpio) ((gpio / 32) & 7) #define GPIO_TO_RANK(gpio) (gpio % 32) #define GPIO_TO_MASK(gpio) (1 << (gpio % 32)) @@ -75,9 +82,16 @@ static int lpc32xx_gpio_direction_input(struct udevice *dev, unsigned offset) break; case 2: /* ports 2 and 3 share a common direction */ - case 3: writel(mask, &regs->p2_p3_dir_clr); break; + case 3: + /* Setup direction only for GPIO_xx. */ + if ((mask >= 25) && (mask <= 30)) + writel(mask, &regs->p2_p3_dir_clr); + break; + case 4: + /* GPI_xx; nothing to do. */ + break; default: return -1; } @@ -111,6 +125,11 @@ static int lpc32xx_gpio_get_value(struct udevice *dev, unsigned offset) value = readl(&regs->p2_inp_state); break; case 3: + /* Read GPO_xx and GPIO_xx (as output) using p3_outp_state. */ + value = readl(&regs->p3_outp_state); + break; + case 4: + /* Read GPI_xx and GPIO_xx (as input) using p3_inp_state. */ value = readl(&regs->p3_inp_state); break; default: @@ -149,6 +168,8 @@ static int gpio_set(struct udevice *dev, unsigned gpio) case 3: writel(mask, &regs->p3_outp_set); break; + case 4: + /* GPI_xx; invalid. */ default: return -1; } @@ -181,6 +202,8 @@ static int gpio_clr(struct udevice *dev, unsigned gpio) case 3: writel(mask, &regs->p3_outp_clr); break; + case 4: + /* GPI_xx; invalid. */ default: return -1; } @@ -223,9 +246,15 @@ static int lpc32xx_gpio_direction_output(struct udevice *dev, unsigned offset, break; case 2: /* ports 2 and 3 share a common direction */ - case 3: writel(mask, &regs->p2_p3_dir_set); break; + case 3: + /* Setup direction only for GPIO_xx. */ + if ((mask >= 25) && (mask <= 30)) + writel(mask, &regs->p2_p3_dir_set); + break; + case 4: + /* GPI_xx; invalid. */ default: return -1; } -- 1.8.3.1

2 1

[U-Boot] [PATCH] omap3: cm-t3517: define CONFIG_MACH_TYPE
by Dmitry Lifshitz 12 Sep '15

12 Sep '15

Define CONFIG_MACH_TYPE to allow non DT Linux boot. Signed-off-by: Dmitry Lifshitz <lifshitz(a)compulab.co.il> --- include/configs/cm_t3517.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/cm_t3517.h b/include/configs/cm_t3517.h index fbc10dd..27c023c 100644 --- a/include/configs/cm_t3517.h +++ b/include/configs/cm_t3517.h @@ -36,6 +36,8 @@ #include <asm/arch/cpu.h> /* get chip and board defs */ #include <asm/arch/omap.h> +#define CONFIG_MACH_TYPE MACH_TYPE_CM_T3517 + /* * Display CPU and Board information */ -- 1.7.5.4

3 2

[U-Boot] [PATCH 0/3] omap3: cm-t3517: series of non critical fixes
by Dmitry Lifshitz 12 Sep '15

12 Sep '15

These patches fix non critical issues, required to sync CM-T3517 mainline U-Boot with the that, shipped with the boards. Dmitry Lifshitz (3): omap3: cm-t3517: enable 'netretry' and setup timeout omap3: cm-t3517: fix MMC1 pinmux omap3: cm-t3517: change environment size board/compulab/cm_t3517/mux.c | 12 ++++++------ include/configs/cm_t3517.h | 7 +++++-- 2 files changed, 11 insertions(+), 8 deletions(-) -- 1.7.5.4

3 11

[U-Boot] [PATCH v4 0/4] add dfu support for at91 sam9260 based boards
by Heiko Schocher 12 Sep '15

12 Sep '15

add dfu supprt for at91 sam9260 based boards. The USB gadget driver is ported from linux: c94e289f195e: usb: gadget: remove incorrect __init/__exit annotations it drops a lot of checkpatch warnings/errors: checkpatch.pl found 12 error(s), 28 warning(s), 38 checks(s) but for further updates I did not fix them. The errors are all from this sort: error: drivers/usb/gadget/at91_udc.c,87: space prohibited before open square bracket '[' a lot of "line over 80 characters" warnings ... Changes in v4: - rebase after taurus board changes Changes in v3: - new in v3 - add comments from Alexandre Belloni get rid of cpu_is_at91*, use newer linux version as base for the port to U-Boot. - adapt changes for U-Boot, as newer linux version is used. Changes in v2: - add comments from Lukasz Majewski - seperate usb gadget driver port from linux into 2 commits - first patch original from linux (with complete commit message) - second adds U-Boot changes without "#ifdef __UBOOT__" - new in version 2, contains U-Boot changes - rebase to bd48c0617b5c7212e5bf22169e716da878842da4 - fix changes introduced through commit: 01acd6abbdd5: usb: USB download gadget and functions config options coherent naming - add comments from Lukasz Majewski <l.majewski(a)samsung.com> - use SZ_X defines Heiko Schocher (4): bitops: introduce BIT() definition usb: gadget: at91_udc: port linux driver at91_udc usb: gadget: at91_udc: add at91_udc into U-Boot at91, taurus, smartweb: add dfu support board/siemens/smartweb/smartweb.c | 29 + board/siemens/taurus/taurus.c | 27 + drivers/usb/gadget/Makefile | 1 + drivers/usb/gadget/at91_udc.c | 1625 +++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/at91_udc.h | 171 ++++ include/configs/smartweb.h | 53 +- include/configs/taurus.h | 30 +- include/linux/bitops.h | 2 + include/linux/usb/at91_udc.h | 20 + 9 files changed, 1943 insertions(+), 15 deletions(-) create mode 100644 drivers/usb/gadget/at91_udc.c create mode 100644 drivers/usb/gadget/at91_udc.h create mode 100644 include/linux/usb/at91_udc.h -- 2.1.0

14 26

[U-Boot] [PATCH] fs: ext4: fix symlink read function
by Gary Bisson 12 Sep '15

12 Sep '15

Since last API changes for files >2GB, the read of symlink is broken as ext4fs_read_file now returns 0 instead of the length of the actual read. Signed-off-by: Gary Bisson <gary.bisson(a)boundarydevices.com> --- Hi all, Switching from an old v2014.07 to v2015.07 we've noticed that we couldn't read symlinks any more. This is due to the API changes made to ext4fs_read_file (commit 9f12cd0). This patch makes the read symlink check both for errors (status < 0) and actual read length. Regards, Gary --- fs/ext4/ext4_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c index cab5465..e2ab145 100644 --- a/fs/ext4/ext4_common.c +++ b/fs/ext4/ext4_common.c @@ -2040,7 +2040,7 @@ static char *ext4fs_read_symlink(struct ext2fs_node *node) status = ext4fs_read_file(diro, 0, __le32_to_cpu(diro->inode.size), symlink, &actread); - if (status == 0) { + if ((status < 0) || (actread == 0)) { free(symlink); return 0; } -- 2.5.1

3 4

[U-Boot] [PATCH 0/2] igep00x0: standardize boot commmands
by Enric Balletbo i Serra 12 Sep '15

12 Sep '15

Hi, Please consider adding these two patches. I saw that I missed some emails because my MAINTAINERS address was obsolete, so the first patch only updates my email. The second one switches igep00x0 to use generic distro configuration and environment instead of custom boot commands to be more generic. Best regards, Enric Balletbo i Serra (2): igep00xx: MAINTAINERS: update eballetbo's email address. igep00x0: Switch to use the generic distro configuration and environment. board/isee/igep0033/MAINTAINERS | 2 +- board/isee/igep00x0/MAINTAINERS | 2 +- board/isee/igep00x0/igep00x0.c | 4 +- include/configs/omap3_igep00x0.h | 95 ++++++++++++---------------------------- 4 files changed, 32 insertions(+), 71 deletions(-) -- 2.1.0

2 4

[U-Boot] [PATCHv4 0/1] Add Toby-Churchill SL50 board support
by Enric Balletbo i Serra 12 Sep '15

12 Sep '15

This patch series adds support for SL50 board based on TI AM335x SoC. Changes since v3: - Rebase with current mainline. - Fix warning about CONFIG_SYS_MALLOC_F_LEN redefinition. Changes since v2: - Rebased with current mainline. - Keep the TI copyright header on some files. - Add SPDX tags instead the full verbage. - Set default fdtfile to am335x-sl50.dtb (instead uses am33xx-sl50.dtb) Changes since v1: - Rebased with current mainline. - Fix implicit declaration of function 'is_valid_ether_addr' (and the resulting link failure). Best regards, Enric Balletbo i Serra (1): board: Add Toby-Churchill SL50 board support. arch/arm/Kconfig | 8 + board/tcl/sl50/Kconfig | 31 ++++ board/tcl/sl50/MAINTAINERS | 6 + board/tcl/sl50/Makefile | 13 ++ board/tcl/sl50/board.c | 386 ++++++++++++++++++++++++++++++++++++++++++ board/tcl/sl50/board.h | 22 +++ board/tcl/sl50/mux.c | 154 +++++++++++++++++ configs/am335x_sl50_defconfig | 10 ++ include/configs/am335x_sl50.h | 138 +++++++++++++++ 9 files changed, 768 insertions(+) create mode 100644 board/tcl/sl50/Kconfig create mode 100644 board/tcl/sl50/MAINTAINERS create mode 100644 board/tcl/sl50/Makefile create mode 100644 board/tcl/sl50/board.c create mode 100644 board/tcl/sl50/board.h create mode 100644 board/tcl/sl50/mux.c create mode 100644 configs/am335x_sl50_defconfig create mode 100644 include/configs/am335x_sl50.h -- 2.1.0

2 2

[U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding
by Stephen Warren 12 Sep '15

12 Sep '15

From: Stephen Warren <swarren(a)nvidia.com> By the time g_dnl_unbind() is run, cdev->config has been set to NULL, so the free() there does nothing, and the config struct is leaked. Equally, struct usb_gadget contains a linked list of config structs, so the code should iterate over them all and free each one, rather than freeing one particular config struct. composite_unbind() already iterates over the list of config structs, and unlinks each from the linked list. Fix this loop to free() each struct as it's unlinked and otherwise forgotten. Signed-off-by: Stephen Warren <swarren(a)nvidia.com> --- drivers/usb/gadget/composite.c | 1 + drivers/usb/gadget/g_dnl.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index d96296cd73b1..a13b21d0a0f2 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -948,6 +948,7 @@ static void composite_unbind(struct usb_gadget *gadget) debug("unbind config '%s'/%p\n", c->label, c); c->unbind(c); } + free(c); } if (composite->unbind) composite->unbind(cdev); diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c index ad89a0d2e670..2fa6da4091e1 100644 --- a/drivers/usb/gadget/g_dnl.c +++ b/drivers/usb/gadget/g_dnl.c @@ -93,8 +93,6 @@ static int g_dnl_unbind(struct usb_composite_dev *cdev) { struct usb_gadget *gadget = cdev->gadget; - free(cdev->config); - cdev->config = NULL; debug("%s: calling usb_gadget_disconnect for " "controller '%s'\n", __func__, gadget->name); usb_gadget_disconnect(gadget); -- 1.9.1

5 33