June 2014 - U-Boot

Re: [U-Boot] [PATCH 2/2] ARM: atmel: sama5d3xek: enable NOR flash support
by Bo Shen 30 Jun '14

30 Jun '14

Hi Andy, On 06/30/2014 05:55 PM, Andy Pont wrote: > Hi Bo, > >> -/* No NOR flash */ >> +/* NOR flash */ >> +#define CONFIG_CMD_FLASH >> + >> +#ifdef CONFIG_CMD_FLASH >> +#define CONFIG_SYS_FLASH_CFI >> +#define CONFIG_FLASH_CFI_DRIVER >> +#define CONFIG_SYS_FLASH_BASE 0x10000000 >> +#define CONFIG_SYS_MAX_FLASH_SECT 0x20000 >> +#define CONFIG_SYS_MAX_FLASH_BANKS 1 >> +#else >> #define CONFIG_SYS_NO_FLASH >> +#endif > > The NOR flash device on the SAMA5D3x CPU modules supports hardware sector > protection and according to the flash datasheet: "All blocks power-up in a > locked state to protect array data from being altered during power > transitions". In order to make your patch set work: > > #define CONFIG_SYS_FLASH_PROTECTION > > needs adding into the include/configs/sama5d3xek.h file. Thanks for your information. I will add it into next version. Thanks again. > Andy. > Best Regards, Bo Shen

2 1

[U-Boot] [PATCH 0/2] ARM: atmel: sama5d3xek: enable NOR flash support
by Bo Shen 30 Jun '14

30 Jun '14

Add NOR flash support on sama5d3xek board. Then, we can use NOR flash related command to access it. Bo Shen (2): ARM: atmel: sama5d3xek: add nor flash init function ARM: atmel: sama5d3xek: enable NOR flash support board/atmel/sama5d3xek/sama5d3xek.c | 58 +++++++++++++++++++++++++++++++++++++ include/configs/sama5d3xek.h | 12 +++++++- 2 files changed, 69 insertions(+), 1 deletion(-) -- 1.8.5.2

2 3

[U-Boot] Issues configuring Samsung K4B2G1646Q DDR3 on am3352
by Egli, Samuel 30 Jun '14

30 Jun '14

Hi Tom, I observed some issues on our Siemens CPU boards with am3352 configuring 2Gbit DDR3 from Samsung (K4B2G1646Q). Before we used a 1 Gbit DDR3 memory from Samsung as well and other manufacturers that worked fine. With 2 Gbit I noticed, after some trial and error (and adapting tRFC parameters to the new size), that for Samsung I need to wait some extra time (around 200us) after calling the configuration function config_ddr(...) before proceeding. This is necessary when a soft reset happens but not when the device makes a power cycle. And this is only an issue for Samsung K4B2G1646Q. We also have some hardware with 2Gbit DDR3 from ISSI that don't see this issue. From a datasheet perspective there shouldn't be any significant differences but of course I cannot vouch for it. So my question is now if you know somebody that observed similar issues with K4B2G1646Q DDR3 and if there is a better solution than adding a udelay(200) after the configuration call? I don't understand the issue completely, so I guess there might be a better solution out there. Kind regards Sam Siemens Schweiz AG, Building Technologies Division, International Headquarters Infrastructure & Cities Sector Building Technologies Division Control Products & Systems IC BT CPS R&D ZG FW CCP Gubelstrasse 22 6300 Zug, Schweiz Tel: +41 41 724-3024 mailto:samuel.egli@siemens.com

1 0

[U-Boot] [PATCH] i2c, omap24xx: add i2c deblock sequenz
by Heiko Schocher 30 Jun '14

30 Jun '14

If a bus busy is detected when intializing the driver, toggle 9 times the scl pin. Therefore enable the test mode of the controller, in which the scl, sda pins can be controlled manually. Tested on the siemens boards pxm2, rut and dxr2. Signed-off-by: Heiko Schocher <hs(a)denx.de> Cc: Tom Rini <trini(a)ti.com> Cc: Hannes Petermaier <oe5hpm(a)oevsv.at> Cc: Lubomir Popov <lpopov(a)mm-sol.com> Cc: Steve Sakoman <steve(a)sakoman.com> Cc: Sandeep Paulraj <s-paulraj(a)ti.com> Cc: Vincent Stehlé <v-stehle(a)ti.com> Cc: Samuel Egli <samuel.egli(a)siemens.com> --- drivers/i2c/omap24xx_i2c.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c index a39b591..0f1e35c 100644 --- a/drivers/i2c/omap24xx_i2c.c +++ b/drivers/i2c/omap24xx_i2c.c @@ -153,11 +153,60 @@ static uint omap24_i2c_setspeed(struct i2c_adapter *adap, uint speed) return 0; } + +static void omap24_i2c_deblock(struct i2c_adapter *adap) +{ + struct i2c *i2c_base = omap24_get_base(adap); + int i; + u16 systest; + u16 orgsystest; + + /* set test mode ST_EN = 1 */ + orgsystest = readw(&i2c_base->systest); + systest = orgsystest; + /* enable testmode */ + systest |= I2C_SYSTEST_ST_EN; + writew(systest, &i2c_base->systest); + systest &= ~I2C_SYSTEST_TMODE_MASK; + systest |= 3 << I2C_SYSTEST_TMODE_SHIFT; + writew(systest, &i2c_base->systest); + + /* set SCL, SDA = 1 */ + systest |= I2C_SYSTEST_SCL_O | I2C_SYSTEST_SDA_O; + writew(systest, &i2c_base->systest); + udelay(10); + + /* toggle scl 9 clocks */ + for (i = 0; i < 9; i++) { + /* SCL = 0 */ + systest &= ~I2C_SYSTEST_SCL_O; + writew(systest, &i2c_base->systest); + udelay(10); + /* SCL = 1 */ + systest |= I2C_SYSTEST_SCL_O; + writew(systest, &i2c_base->systest); + udelay(10); + } + + /* send stop */ + systest &= ~I2C_SYSTEST_SDA_O; + writew(systest, &i2c_base->systest); + udelay(10); + systest |= I2C_SYSTEST_SCL_O | I2C_SYSTEST_SDA_O; + writew(systest, &i2c_base->systest); + udelay(10); + + /* restore original mode */ + writew(orgsystest, &i2c_base->systest); +} + static void omap24_i2c_init(struct i2c_adapter *adap, int speed, int slaveadd) { struct i2c *i2c_base = omap24_get_base(adap); int timeout = I2C_TIMEOUT; + int deblock = 1; +retry: if (readw(&i2c_base->con) & I2C_CON_EN) { writew(0, &i2c_base->con); udelay(50000); @@ -194,6 +243,14 @@ static void omap24_i2c_init(struct i2c_adapter *adap, int speed, int slaveadd) udelay(1000); flush_fifo(adap); writew(0xFFFF, &i2c_base->stat); + + /* Handle possible failed I2C state */ + if (wait_for_bb(adap)) + if (deblock == 1) { + omap24_i2c_deblock(adap); + deblock = 0; + goto retry; + } } static void flush_fifo(struct i2c_adapter *adap) -- 1.8.3.1

1 0

[U-Boot] [PATCH] Samsung: Goni: change maintainer to Robert Baldyga
by Przemyslaw Marczak 30 Jun '14

30 Jun '14

Robert Baldyga will now take care of this board. Signed-off-by: Przemyslaw Marczak <p.marczak(a)samsung.com> Cc: Robert Baldyga <r.baldyga(a)samsung.com> Cc: Minkyu Kang <mk7.kang(a)samsung.com> --- boards.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boards.cfg b/boards.cfg index 1527ebe..673e599 100644 --- a/boards.cfg +++ b/boards.cfg @@ -379,7 +379,7 @@ Active arm armv7 rmobile renesas koelsch Active arm armv7 rmobile renesas koelsch koelsch_nor koelsch:NORFLASH Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> Active arm armv7 rmobile renesas lager lager - Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> Active arm armv7 rmobile renesas lager lager_nor lager:NORFLASH Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com> -Active arm armv7 s5pc1xx samsung goni s5p_goni - Przemyslaw Marczak <p.marczak(a)samsung.com> +Active arm armv7 s5pc1xx samsung goni s5p_goni - Robert Baldyga <r.baldyga(a)samsung.com> Active arm armv7 s5pc1xx samsung smdkc100 smdkc100 - Minkyu Kang <mk7.kang(a)samsung.com> Active arm armv7 socfpga altera socfpga socfpga_cyclone5 - - Active arm armv7 sunxi - sunxi Cubietruck sun7i:CUBIETRUCK,SPL,SUNXI_GMAC,RGMII - -- 1.9.1

3 2

[U-Boot] __weak usage
by Jeroen Hofstee 28 Jun '14

28 Jun '14

Hi, Perhaps this is trivial for you all, but it is something I had not realized before looking into the warnings u-boot generates with W=1 / clang. The below "program" will compile fine with MAKEALL (even with pedantic warnings). Since the compiler never sees the different definition and the linker does not care, there is no warning at all. If a weak prototype ever changes, running MAKEALL gives no guarantee boards don't crash at runtime. Hence I would propose that when adding a new __weak, both the weak and non weak definition actually see the common prototype. And please use __weak to reduce the noise when compiling with W=1. Regards, Jeroen :::::::::::::: a.c :::::::::::::: #define __weak __attribute__((weak)) __weak void some_function(void) { } void go(void) { some_function(); } :::::::::::::: b.c :::::::::::::: #include <stdio.h> extern void go(void); void some_function(int *arg) { printf("lets crash %d", *arg); } int main() { go(); return 0; } jeroen@yellow:~/weak$ gcc -Wall -Wpedantic a.c b.c jeroen@yellow:~/weak$ ./a.out Segmentation fault

2 1

[U-Boot] [RFC] kbuild.h: workaround for llvm IAS
by Jeroen Hofstee 28 Jun '14

28 Jun '14

KBuild (ab)uses the asm statement to write to a file and llvm integrated as chokes about these invalid asm statements. Workaround it by making it look like valid asm code. Signed-off-by: Jeroen Hofstee <jeroen(a)myspectrum.nl> --- Kbuild | 3 ++- include/linux/kbuild.h | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) Does someone have a better solution? Is this valid for all archs? diff --git a/Kbuild b/Kbuild index 6e1698c..ef97787 100644 --- a/Kbuild +++ b/Kbuild @@ -53,7 +53,8 @@ targets += arch/$(ARCH)/lib/asm-offsets.s # Default sed regexp - multiline due to syntax constraints define sed-y - "/^->/{s:->#$.*$:/* \1 */:; \ + "s:[[:space:]]*\.ascii[[:space:]]*\"$.*$\":\1:; \ + /^->/{s:->#$.*$:/* \1 */:; \ s:^->$[^ ]*$ [\$$#]*$[-0-9]*$ $.*$:#define \1 \2 /* \3 */:; \ s:^->$[^ ]*$ [\$$#]*$[^ ]*$ $.*$:#define \1 \2 /* \3 */:; \ s:->::; p;}" diff --git a/include/linux/kbuild.h b/include/linux/kbuild.h index ab7805a..8a9f645 100644 --- a/include/linux/kbuild.h +++ b/include/linux/kbuild.h @@ -7,14 +7,14 @@ #define __LINUX_KBUILD_H #define DEFINE(sym, val) \ - asm volatile("\n->" #sym " %0 " #val : : "i" (val)) + asm volatile("\n.ascii \"->" #sym " %0 " #val "\"" : : "i" (val)) -#define BLANK() asm volatile("\n->" : : ) +#define BLANK() asm volatile("\n.ascii \"->\"" : : ) #define OFFSET(sym, str, mem) \ DEFINE(sym, offsetof(struct str, mem)) #define COMMENT(x) \ - asm volatile("\n->#" x) + asm volatile("\n.ascii \"->#" x "\"") #endif -- 1.8.3.2

2 4

Re: [U-Boot] U-Boot Digest, Vol 73, Issue 48
by luca.luminari＠spesonline.com 28 Jun '14

28 Jun '14

Grazie per il tuo messaggio. Sono fuori azienda con accesso limitato alle mail fino al 3 Luglio. Thank you for your message I am out of office and will be back on Thursday the third of July.

1 0

[U-Boot] Question about dynamic gpmc timings
by Chase Lambert 28 Jun '14

28 Jun '14

Hello! I'm working on a product that has two different NAND devices, each with different timings. I'd like to have the products with the faster NAND keep the faster timings, while still supporting the slower NAND. I'm currently using x-loader instead of U-Boot's spl, so omap3/spl_id_nand.c is not being included. The solutions I've come up with to solve this sound messy. Here's the best of them; can someone think of a better way, or is this reasonable? Take out the "ifdef CONFIG_SPL_BUILD" in the omap3/Makefile for spl_id_nand.c. Modify omap3/mem.c, to use identify_nand_chip from spl_id_nand.c, check if it's the faster chip, and set the gpmc registers to faster config timings if it's the faster chip. The messy part here is that the file has "spl" in the name, and this is not being used for spl functionality. I'd like to change the code as little as possible to stay close to U-Boot's main fork. Thanks for the help! Chase

1 0

[U-Boot] Return value of run command
by Enric Balletbo Serra 27 Jun '14

27 Jun '14

Hi all, Should the command 'run something"' return the value that returns "something" or just return "true" if can execute something and "false" if it can't ? I'll explain. Imagine you have a variable that loads a file from the mmc but this files doesn't exist. loadfile=load mmc ${mmcdev} ${loadaddr} my-file In the case you do the following script if run loadfile; then echo "true"; else echo "false"; fi the result is always "true", either the file doesn't exist OTOH, if you do : if ${loadfile}; then echo "true"; else echo "false"; fi Then the result is "true" if file exist and "false" if file doesn't exist. For me looks like the "run something" command should return the result of the command but this is not the behaviour. With current behaviour something like CONFIG_EXTRA_ENV_SETTINGS from include/configs/am335x_evm.h file, 129 "echo SD/MMC found on device ${mmcdev};" \ 130 "if run loadbootenv; then " \ 131 "echo Loaded environment from ${bootenv};" \ 132 "run importbootenv;" \ 133 "fi;" \ Either uEnv.txt file exist or not, the "run loadbootenv" always returns true, so always tries to run "run importbootenv". I supose this is not the expected behaviour. The question is. It's a problem with run command or with the definition of CONFIG_EXTRA_ENV_SETTING, that should be something like that: - 130 "if run loadbootenv; then " \ + 130 "if ${loadbootenv}; then " \ Best regards, Enric

2 2