September 2013 - U-Boot

[U-Boot] "make distclean" doesn't remove CHANGELOG
by Robert P. J. Day 16 Sep '13

16 Sep '13

just noticed that while you can manually generate the CHANGELOG file, "make distclean" doesn't remove it. i'll leave it up to someone higher up the food chain to determine where that removal should go. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================

1 0

Re: [U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS
by Albert ARIBAUD 16 Sep '13

16 Sep '13

Hi Roger, On Thu, 12 Sep 2013 13:18:20 +0000, "Meier, Roger" <r.meier(a)siemens.com> wrote: > Hi Albert > > -----Original Message----- > > From: u-boot-bounces(a)lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On > > Behalf Of Albert ARIBAUD > > Sent: Mittwoch, 11. September 2013 15:53 > > To: u-boot(a)lists.denx.de > > Subject: [U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS > > > > Put all informations about targets, including state (active or > > orphan) and maintainers, in boards.cfg; remove MAINTAINERS; > > adjust the build system accordingly. > > > > Signed-off-by: Albert ARIBAUD <albert.u.boot(a)aribaud.net> > > --- > > V2: > > - updated with latest boards.cfg/MAINTAINER info > > - fixed wrong maintainer(s) for orphan boards > > - fixed wrong maintainer(s) for base:options case > > - fixed lingering misuses of boards.cfg and MAINTAINERS > > V1: > > - initial submission from squashed RFC patch series > > > > MAINTAINERS | 1412 ---------------------------- > > MAKEALL | 51 +- > > Makefile | 2 +- > > README | 6 +- > > boards.cfg | 2345 ++++++++++++++++++++++++---------------------- > > - > > mkconfig | 31 +- > > tools/buildman/board.py | 2 +- > > tools/reformat.py | 132 +++ > > 8 files changed, 1350 insertions(+), 2631 deletions(-) > > delete mode 100644 MAINTAINERS > > create mode 100755 tools/reformat.py > > > > I really like that simplification! > > tools/checkpatch.pl detected these errors: > ---SNIP--- > ERROR: trailing whitespace > #4055: FILE: tools/reformat.py:32: > +# ^I$ > > ERROR: trailing whitespace > #4125: FILE: tools/reformat.py:102: > +^I^I# any missing field is set to default if it exists $ > ---SNIP--- > > and I recognized that tools/checkpatch.pl needs the patch below. > > Regards, > Roger > > diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl > index 896e2bc..88c5bc7 100755 > --- a/tools/checkpatch.pl > +++ b/tools/checkpatch.pl > @@ -398,7 +398,7 @@ sub top_of_kernel_tree { > my ($root) = @_; > > my @tree_check = ( > - "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", > + "COPYING", "CREDITS", "Kbuild", "Makefile", > "README", "Documentation", "arch", "include", "drivers", > "fs", "init", "ipc", "kernel", "lib", "scripts", > ); > @@ -3701,7 +3701,7 @@ sub process { > $vname has style problems, please review. > > If any of these errors are false positives, please report > -them to the maintainer, see CHECKPATCH in MAINTAINERS. > +them to the maintainer, see boards.cfg. > EOM > } Thanks! I thought I'd done a grep -i MAINTAINERS before posting, obviously I hadn't. Could you send thoses two fixes as as a proper, standalone git patch rather than a reply to another patch, so that they can be properly attributed to you? Amicalement, -- Albert.

2 1

[U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue
by Oliver Metz 15 Sep '13

15 Sep '13

Dear Fabio, >Hi Robert and Hector, > >On Fri, Sep 13, 2013 at 2:46 PM, Wolfgang Denk <[hidden email]> wrote: > >> That's ALLOC_CACHE_ALIGN_BUFFER. Thanks. > >Could you please let us know wthether the change below fix the problem? > >Thanks, > >Fabio Estevam > >--- a/drivers/net/fec_mxc.c >+++ b/drivers/net/fec_mxc.c >@@ -794,7 +794,7 @@ static int fec_recv(struct eth_device *dev) > uint16_t bd_status; > uint32_t addr, size, end; > int i; >- uchar buff[FEC_MAX_PKT_SIZE] __aligned(ARCH_DMA_MINALIGN); >+ ALLOC_CACHE_ALIGN_BUFFER(uchar, buff, FEC_MAX_PKT_SIZE); > > /* > * Check if any critical events have happened I can confirm that this patch fixes the issue for me on the mx28 board. Before the patch transmitting a linux kernel archive failed many times. With the patch applied the file was transfered successfully with the first try. Used gcc version: gcc version 4.5.4 20110808 (prerelease) (Linaro GCC 4.5-2011.08) Regards Oliver

2 1

[U-Boot] [PATCH v3 28/28] sf: probe: Add support for MX25L51235F
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Add support for Macronix MX25L51235F SPI flash. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_probe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index afe8068..ed2890b 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -64,6 +64,7 @@ static const struct spi_flash_params spi_flash_params_table[] = { {"MX25L6405D", 0xc22017, 0x0, 64 * 1024, 128, 0}, {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256, 0}, {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, 0}, + {"MX25L51235F", 0xc2201A, 0x0, 64 * 1024, 1024, 0}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, 0}, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ -- 1.8.3

1 0

[U-Boot] [PATCH v3 27/28] sf: probe: Add support for MX25L25635F
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Add support for Macronix MX25L25635F SPI flash. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_probe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index b6b4cb2..afe8068 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -63,6 +63,7 @@ static const struct spi_flash_params spi_flash_params_table[] = { {"MX25L3205D", 0xc22016, 0x0, 64 * 1024, 64, 0}, {"MX25L6405D", 0xc22017, 0x0, 64 * 1024, 128, 0}, {"MX25L12805", 0xc22018, 0x0, 64 * 1024, 256, 0}, + {"MX25L25635F", 0xc22019, 0x0, 64 * 1024, 512, 0}, {"MX25L12855E", 0xc22618, 0x0, 64 * 1024, 256, 0}, #endif #ifdef CONFIG_SPI_FLASH_SPANSION /* SPANSION */ -- 1.8.3

1 0

[U-Boot] [PATCH v3 26/28] sf: ops: Add static qualifier to spi_flash_cmd_bankaddr_write
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_internal.h | 5 ----- drivers/mtd/spi/spi_flash_ops.c | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/mtd/spi/spi_flash_internal.h b/drivers/mtd/spi/spi_flash_internal.h index 86966f6..1f9f170 100644 --- a/drivers/mtd/spi/spi_flash_internal.h +++ b/drivers/mtd/spi/spi_flash_internal.h @@ -94,11 +94,6 @@ static inline int spi_flash_cmd_write_disable(struct spi_flash *flash) /* Program the status register. */ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr); -#ifdef CONFIG_SPI_FLASH_BAR -/* Program the bank address register */ -int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel); -#endif - /* * Same as spi_flash_cmd_read() except it also claims/releases the SPI * bus. Used as common part of the ->read() operation. diff --git a/drivers/mtd/spi/spi_flash_ops.c b/drivers/mtd/spi/spi_flash_ops.c index c408e27..b4e1c40 100644 --- a/drivers/mtd/spi/spi_flash_ops.c +++ b/drivers/mtd/spi/spi_flash_ops.c @@ -39,7 +39,7 @@ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr) } #ifdef CONFIG_SPI_FLASH_BAR -int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel) +static int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel) { u8 cmd; int ret; -- 1.8.3

1 0

[U-Boot] [PATCH v3 25/28] sf: probe: Simply the BAR configuration logic
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_internal.h | 3 -- drivers/mtd/spi/spi_flash_probe.c | 56 +++++++++++------------------------- include/spi_flash.h | 3 -- 3 files changed, 16 insertions(+), 46 deletions(-) diff --git a/drivers/mtd/spi/spi_flash_internal.h b/drivers/mtd/spi/spi_flash_internal.h index 286082a..86966f6 100644 --- a/drivers/mtd/spi/spi_flash_internal.h +++ b/drivers/mtd/spi/spi_flash_internal.h @@ -97,9 +97,6 @@ int spi_flash_cmd_write_status(struct spi_flash *flash, u8 sr); #ifdef CONFIG_SPI_FLASH_BAR /* Program the bank address register */ int spi_flash_cmd_bankaddr_write(struct spi_flash *flash, u8 bank_sel); - -/* Configure the BAR - discover the bank cmds */ -int spi_flash_bank_config(struct spi_flash *flash, u8 idcode0); #endif /* diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index 3bf336d..b6b4cb2 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -220,56 +220,32 @@ struct spi_flash *spi_flash_validate_ids(struct spi_slave *spi, u8 *idcode) #ifdef CONFIG_SPI_FLASH_BAR /* Configure the BAR - discover bank cmds and read current bank */ - if (spi_flash_bank_config(flash, idcode[0]) < 0) - return NULL; -#endif - - /* Flash powers up read-only, so clear BP# bits */ - if (((params->jedec >> 16) == SPI_FLASH_CFI_MFR_ATMEL) || - ((params->jedec >> 16) == SPI_FLASH_CFI_MFR_MACRONIX) || - ((params->jedec >> 16) == SPI_FLASH_CFI_MFR_SST)) - spi_flash_cmd_write_status(flash, 0); - - return flash; -} - -#ifdef CONFIG_SPI_FLASH_BAR -int spi_flash_bank_config(struct spi_flash *flash, u8 idcode0) -{ - u8 cmd; u8 curr_bank = 0; - - /* discover bank cmds */ - switch (idcode0) { - case SPI_FLASH_CFI_MFR_SPANSION: - flash->bank_read_cmd = CMD_BANKADDR_BRRD; - flash->bank_write_cmd = CMD_BANKADDR_BRWR; - break; - case SPI_FLASH_CFI_MFR_STMICRO: - case SPI_FLASH_CFI_MFR_WINBOND: - flash->bank_read_cmd = CMD_EXTNADDR_RDEAR; - flash->bank_write_cmd = CMD_EXTNADDR_WREAR; - break; - default: - printf("SF: Unsupported bank commands %02x\n", idcode0); - return -1; - } - - /* read the bank reg - on which bank the flash is in currently */ - cmd = flash->bank_read_cmd; if (flash->size > SPI_FLASH_16MB_BOUN) { - if (spi_flash_read_common(flash, &cmd, 1, &curr_bank, 1)) { + flash->bank_read_cmd = (idcode[0] == 0x01) ? + CMD_BANKADDR_BRRD : CMD_EXTNADDR_RDEAR; + flash->bank_write_cmd = (idcode[0] == 0x01) ? + CMD_BANKADDR_BRWR : CMD_EXTNADDR_WREAR; + + if (spi_flash_read_common(flash, &flash->bank_read_cmd, 1, + &curr_bank, 1)) { debug("SF: fail to read bank addr register\n"); - return -1; + return NULL; } flash->bank_curr = curr_bank; } else { flash->bank_curr = curr_bank; } +#endif - return 0; + /* Flash powers up read-only, so clear BP# bits */ + if (((params->jedec >> 16) == SPI_FLASH_CFI_MFR_ATMEL) || + ((params->jedec >> 16) == SPI_FLASH_CFI_MFR_MACRONIX) || + ((params->jedec >> 16) == SPI_FLASH_CFI_MFR_SST)) + spi_flash_cmd_write_status(flash, 0); + + return flash; } -#endif #ifdef CONFIG_OF_CONTROL int spi_flash_decode_fdt(const void *blob, struct spi_flash *flash) diff --git a/include/spi_flash.h b/include/spi_flash.h index 34a167b..939da05 100644 --- a/include/spi_flash.h +++ b/include/spi_flash.h @@ -20,10 +20,7 @@ /* SPI flash CFI Manufacture ID's */ #define SPI_FLASH_CFI_MFR_ATMEL 0x1f #define SPI_FLASH_CFI_MFR_MACRONIX 0xc2 -#define SPI_FLASH_CFI_MFR_SPANSION 0x01 #define SPI_FLASH_CFI_MFR_SST 0xbf -#define SPI_FLASH_CFI_MFR_STMICRO 0x20 -#define SPI_FLASH_CFI_MFR_WINBOND 0xef /* SECT flags */ #define SECT_4K (1 << 0) -- 1.8.3

1 0

[U-Boot] [PATCH v3 24/28] sf: probe: Print erase_size while printing flash details
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Included erase_size while printing probed flash details. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index 4cd9992..3bf336d 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -346,7 +346,8 @@ struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs, #endif #ifndef CONFIG_SPL_BUILD printf("SF: Detected %s with page size ", flash->name); - print_size(flash->page_size, ", total "); + print_size(flash->page_size, ", erase size "); + print_size(flash->erase_size, ", total "); print_size(flash->size, ""); if (flash->memory_map) printf(", mapped at %p", flash->memory_map); -- 1.8.3

1 0

[U-Boot] [PATCH v3 23/28] sf: probe: Use print_size arg as page_size
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Use flash->page_size arg in print_size() instead of flash->sector_size while printing detected flas part details. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index 61ffe50..4cd9992 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -346,7 +346,7 @@ struct spi_flash *spi_flash_probe(unsigned int bus, unsigned int cs, #endif #ifndef CONFIG_SPL_BUILD printf("SF: Detected %s with page size ", flash->name); - print_size(flash->sector_size, ", total "); + print_size(flash->page_size, ", total "); print_size(flash->size, ""); if (flash->memory_map) printf(", mapped at %p", flash->memory_map); -- 1.8.3

1 0

[U-Boot] [PATCH v3 22/28] sf: probe: Add support for S25FL512S_256K
by Jagannadha Sutradharudu Teki 15 Sep '13

15 Sep '13

Add support for Spansion S25FL512S_256K SPI flash. Signed-off-by: Jagannadha Sutradharudu Teki <jaganna(a)xilinx.com> --- Changes for v3: - none Changes for v2: - none drivers/mtd/spi/spi_flash_probe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/spi_flash_probe.c b/drivers/mtd/spi/spi_flash_probe.c index 45ca4c0..61ffe50 100644 --- a/drivers/mtd/spi/spi_flash_probe.c +++ b/drivers/mtd/spi/spi_flash_probe.c @@ -77,6 +77,7 @@ static const struct spi_flash_params spi_flash_params_table[] = { {"S25FL128S_64K", 0x012018, 0x4d01, 64 * 1024, 256, 0}, {"S25FL256S_256K", 0x010219, 0x4d00, 64 * 1024, 512, 0}, {"S25FL256S_64K", 0x010219, 0x4d01, 64 * 1024, 512, 0}, + {"S25FL512S_256K", 0x010220, 0x4d00, 64 * 1024, 1024, 0}, {"S25FL512S_64K", 0x010220, 0x4d01, 64 * 1024, 1024, 0}, #endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */ -- 1.8.3

1 0