October 2013 - U-Boot

[U-Boot] [PATCH] mmc: sdhci: Avoid commands errors by simple timeout adaptation.
by Przemyslaw Marczak 31 Oct '13

31 Oct '13

Old command timeout value was too small and it caused I/O errors which led to uncompleted read/write/erase operations and filesystem errors. Timeout adaptation fixes this issue. Changes in sdhci_send_command() function: - change timeout variable to static - increase default command timeout to 100 ms - add definition of max command timeout value, which can be redefined in each board config file - wait for card ready state for max defined time if it doesn't exceed defined maximum or return COMM_ERR Once successfully increased timeout value will be used in next function call. This fix was tested on Goni, Trats, Trats2 boards by testing UMS on MMC storage. Signed-off-by: Przemyslaw Marczak <p.marczak(a)samsung.com> --- drivers/mmc/sdhci.c | 34 +++++++++++++++++++++++++++------- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 4261991..af11fc5 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -110,6 +110,22 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data, return 0; } +/* + * No command will be sent by driver if card is busy, so driver must wait + * for card ready state. + * Every time when card is busy after timeout then (last) timeout value will be + * increased twice but only if it doesn't exceed global defined maximum. + * Each function call will use last timeout value. Max timeout can be redefined + * in board config file. + */ +#ifndef CONFIG_SDHCI_CMD_MAX_TIMEOUT +#define CONFIG_SDHCI_CMD_MAX_TIMEOUT 3200 +#endif +#define CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT 100 + +/* Timeout unit - ms */ +static unsigned int cmd_timeout = CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT; + int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data) { @@ -118,12 +134,9 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, int ret = 0; int trans_bytes = 0, is_aligned = 1; u32 mask, flags, mode; - unsigned int timeout, start_addr = 0; + unsigned int time = 0, start_addr = 0; unsigned int retry = 10000; - /* Wait max 10 ms */ - timeout = 10; - sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_STATUS); mask = SDHCI_CMD_INHIBIT | SDHCI_DATA_INHIBIT; @@ -133,11 +146,18 @@ int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd, mask &= ~SDHCI_DATA_INHIBIT; while (sdhci_readl(host, SDHCI_PRESENT_STATE) & mask) { - if (timeout == 0) { + if (time == cmd_timeout) { printf("Controller never released inhibit bit(s).\n"); - return COMM_ERR; + if (2 * cmd_timeout <= CONFIG_SDHCI_CMD_MAX_TIMEOUT) { + cmd_timeout += cmd_timeout; + debug("Increasing command timeout to: %u ms.\n", + cmd_timeout); + } else { + error("Command timeout is set to max.\n"); + return COMM_ERR; + } } - timeout--; + time++; udelay(1000); } -- 1.7.9.5

4 13

[U-Boot] [PATCH] mmc: dw_mmc: change the callback function name.
by Jaehoon Chung 31 Oct '13

31 Oct '13

To prevent the confusion, use the get_mmc_clk() instead of mmc_clk(). get_mmc_clk() is more exactly name. Signed-off-by: Jaehoon Chung <jh80.chung(a)samsung.com> --- drivers/mmc/dw_mmc.c | 6 +++--- drivers/mmc/exynos_dw_mmc.c | 2 +- include/dwmmc.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 9a803a0..174e3b5 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -220,12 +220,12 @@ static int dwmci_setup_bus(struct dwmci_host *host, u32 freq) if ((freq == host->clock) || (freq == 0)) return 0; /* - * If host->mmc_clk didn't define, + * If host->get_mmc_clk didn't define, * then assume that host->bus_hz is source clock value. * host->bus_hz should be set from user. */ - if (host->mmc_clk) - sclk = host->mmc_clk(host->dev_index); + if (host->get_mmc_clk) + sclk = host->get_mmc_clk(host->dev_index); else if (host->bus_hz) sclk = host->bus_hz; else { diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c index 4ef9fec..1f2c53f 100644 --- a/drivers/mmc/exynos_dw_mmc.c +++ b/drivers/mmc/exynos_dw_mmc.c @@ -74,7 +74,7 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel) host->clksel = exynos_dwmci_clksel; host->dev_index = index; - host->mmc_clk = exynos_dwmci_get_clk; + host->get_mmc_clk = exynos_dwmci_get_clk; /* Add the mmc channel to be registered with mmc core */ if (add_dwmci(host, DWMMC_MAX_FREQ, DWMMC_MIN_FREQ)) { debug("dwmmc%d registration failed\n", index); diff --git a/include/dwmmc.h b/include/dwmmc.h index 08ced0b..ecaa763 100644 --- a/include/dwmmc.h +++ b/include/dwmmc.h @@ -138,7 +138,7 @@ struct dwmci_host { struct mmc *mmc; void (*clksel)(struct dwmci_host *host); - unsigned int (*mmc_clk)(int dev_index); + unsigned int (*get_mmc_clk)(int dev_index); }; struct dwmci_idmac { -- 1.7.9.5

2 1

[U-Boot] [PATCH 0/2] mmc: Fix capacity calculation and erase_group_size
by Oliver Metz 31 Oct '13

31 Oct '13

These patches are addressing two issues that I had after activating enhanced user area feature for a 4GB card so the capacity was less than 2 GB afterwards. 1. The capacity for a high density device is calculated in a wrong way. I was not able to find any hints for this implementation in JEDEC 4.41. Anyhow, if we have ext_csd revision >= 2 we can use SEC_COUNT field to calculate the size. 2. If we have a partitioned device, e.g. enhanced user area, the ERASE_GROUP_DEF bit in ext_csd shall be set (see JEDEC 4.41, chapter 7.2.3 Configure partitions). This bit defaults to "0" on power on. Oliver Metz (2): When using a high capacity card with a density less than 2 GB a wrong size is shown. According to JEDEC 4.41 there is no differentiation for C_SIZE register between low and high capacity cards EXT_CSD_ERASE_GROUP_DEF is lost every time after a reset or reboot. Set it if device has enhanced partitions. drivers/mmc/mmc.c | 49 +++++++++++++++++++++++-------------------------- include/mmc.h | 2 ++ 2 files changed, 25 insertions(+), 26 deletions(-) -- 1.8.4

2 4

[U-Boot] [PATCH] kirkwood: ib62x0: use device tree and update config
by Luka Perkov 31 Oct '13

31 Oct '13

Signed-off-by: Luka Perkov <luka(a)openwrt.org> CC: Prafulla Wadaskar <prafulla(a)marvell.com> --- v1->v2: * keep CONFIG_MACH_TYPE define for backwards compatibility --- include/configs/ib62x0.h | 38 +++++++++++++++++++++++--------------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/include/configs/ib62x0.h b/include/configs/ib62x0.h index 7fa0c53..186fd35 100644 --- a/include/configs/ib62x0.h +++ b/include/configs/ib62x0.h @@ -28,6 +28,11 @@ #define CONFIG_MACH_TYPE MACH_TYPE_NAS6210 /* + * Enable device tree support + */ +#define CONFIG_OF_LIBFDT + +/* * Compression configuration */ #define CONFIG_BZIP2 @@ -41,6 +46,7 @@ #define CONFIG_SYS_MVFS #include <config_cmd_default.h> #define CONFIG_CMD_ENV +#define CONFIG_CMD_BOOTZ #define CONFIG_CMD_IDE #define CONFIG_CMD_MII #define CONFIG_CMD_NAND @@ -66,7 +72,7 @@ #define CONFIG_ENV_IS_NOWHERE #endif #define CONFIG_ENV_SIZE 0x20000 -#define CONFIG_ENV_OFFSET 0x80000 +#define CONFIG_ENV_OFFSET 0xe0000 /* * Default environment variables @@ -74,24 +80,26 @@ #define CONFIG_BOOTCOMMAND \ "setenv bootargs ${console} ${mtdparts} ${bootargs_root}; " \ "ubi part root; " \ - "ubifsmount ubi:root; " \ + "ubifsmount ubi:rootfs; " \ "ubifsload 0x800000 ${kernel}; " \ - "ubifsload 0x1100000 ${initrd}; " \ - "bootm 0x800000 0x1100000" - -#define CONFIG_MTDPARTS \ - "mtdparts=orion_nand:" \ - "0x80000@0x0(uboot)," \ - "0x20000@0x80000(uboot_env)," \ - "-@0xa0000(root)\0" - -#define CONFIG_EXTRA_ENV_SETTINGS \ + "ubifsload 0x700000 ${fdt}; " \ + "ubifsumount; " \ + "fdt addr 0x700000; fdt resize; fdt chosen; " \ + "bootz 0x800000 - 0x700000" + +#define CONFIG_MTDPARTS \ + "mtdparts=orion_nand:" \ + "0xe0000@0x0(uboot)," \ + "0x20000@0xe0000(uboot_env)," \ + "-@0x100000(root)\0" + +#define CONFIG_EXTRA_ENV_SETTINGS \ "console=console=ttyS0,115200\0" \ "mtdids=nand0=orion_nand\0" \ "mtdparts="CONFIG_MTDPARTS \ - "kernel=/boot/uImage\0" \ - "initrd=/boot/uInitrd\0" \ - "bootargs_root=ubi.mtd=2 root=ubi0:root rootfstype=ubifs\0" + "kernel=/boot/zImage\0" \ + "fdt=/boot/ib62x0.dtb\0" \ + "bootargs_root=ubi.mtd=2 root=ubi0:rootfs rootfstype=ubifs rw\0" /* * Ethernet driver configuration -- 1.8.4.2

2 1

[U-Boot] [PATCH] nand_util.c: Correct licensing
by Tom Rini 31 Oct '13

31 Oct '13

This file is GPL-2.0 with Freescale granting rights for GPL-2.0+. This part was dropped by accident in the SPDX updates. Cc: Scott Wood <scottwood(a)freescale.com> Signed-off-by: Tom Rini <trini(a)ti.com> --- drivers/mtd/nand/nand_util.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c index 5246bbf..36679c8 100644 --- a/drivers/mtd/nand/nand_util.c +++ b/drivers/mtd/nand/nand_util.c @@ -14,7 +14,14 @@ * Copyright (C) 2008 Nokia Corporation: drop_ffs() function by * Artem Bityutskiy <dedekind1(a)gmail.com> from mtd-utils * - * SPDX-License-Identifier: GPL-2.0+ + * Copyright 2010 Freescale Semiconductor + * The portions of this file whose copyright is held by Freescale and which + * are not considered a derived work of GPL v2-only code may be distributed + * and/or modified under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0 */ #include <common.h> -- 1.7.9.5

3 3

[U-Boot] squashfs
by Naitik Amin 31 Oct '13

31 Oct '13

Hi there, I have a rootfs image formatted in squashfs. I have a primary partition reserved for my rootfs on my sd card (mmc). Can i update my rootfs from uboot ? Thanks,

1 0

[U-Boot] Pull request: u-boot-video/master
by Anatolij Gustschin 30 Oct '13

30 Oct '13

Hey Tom, The following changes since commit 7e575c46c34b5f1316eab39025fdced197629ccb: usb: rename board_usb_init_type to usb_init_type (2013-10-22 17:33:09 -0400) are available in the git repository at: git://git.denx.de/u-boot-video.git master for you to fetch changes up to 1c6e9de53ba47afacd26fb784818aeb63a01baad: video, formike: change tag/val write (2013-10-30 10:48:41 +0100) ---------------------------------------------------------------- Fabio Estevam (1): video: ipu_disp: Fix clock polarity logic Heiko Schocher (2): video, cfb_console: make background and foreground color configurable video, formike: change tag/val write README | 5 +++++ drivers/video/cfb_console.c | 38 ++++++++++++++++++++------------------ drivers/video/formike.c | 7 ++++--- drivers/video/ipu_disp.c | 2 +- include/video_fb.h | 5 +++++ 5 files changed, 35 insertions(+), 22 deletions(-) Please pull. Thanks! Anatolij

2 1

[U-Boot] Pull-request: u-boot-mpc85xx/master
by York Sun 30 Oct '13

30 Oct '13

Tom, The following changes since commit 7e575c46c34b5f1316eab39025fdced197629ccb: usb: rename board_usb_init_type to usb_init_type (2013-10-22 17:33:09 -0400) are available in the git repository at: git://git.denx.de/u-boot-mpc85xx.git master for you to fetch changes up to 877bfe37dc00b0ae59f37742954a62bce3fdf3a0: mpc85xx: introduce the kmp204x reference design support (2013-10-24 09:36:26 -0700) ---------------------------------------------------------------- Po Liu (1): powerpc/c29xpcie: add DDR ECC on off config setting Valentin Longchamp (11): powerpc: cast bi_memsize to ulong for %ld usage km-powerpc: move SYS_MALLOC_LEN out of keymile-common.h KM: fix typo in default environment KM: define CONFIG_SYS_I2C_INIT_BOARD only for concerned board KM: add CONFIG_KM_COMMON_ETH_INIT for km common eth init mpc8xxx: call i2c_set_bus_num in __get_spd mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it net/fman: add a fm_enable_port function mtd/fsl_elbc: take NAND_ECC_SOFT_BCH config option into account fsl/mpc85xx: define common serdes_clock_to_string function mpc85xx: introduce the kmp204x reference design support ramneek mehresh (2): powerpc/usb:Define CONFIG_USB_MAX_CONTROLLER_COUNT for all 85xx socs powerpc/usb:Differentiate USB controller base address arch/powerpc/cpu/mpc83xx/cpu_init.c | 2 +- arch/powerpc/cpu/mpc85xx/fsl_corenet2_serdes.c | 21 + arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c | 17 + .../powerpc/cpu/mpc8xxx/ddr/common_timing_params.h | 1 + arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c | 7 +- arch/powerpc/cpu/mpc8xxx/ddr/ddr3_dimm_params.c | 4 + .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c | 5 + arch/powerpc/cpu/mpc8xxx/ddr/main.c | 6 +- arch/powerpc/cpu/mpc8xxx/fdt.c | 6 +- arch/powerpc/include/asm/config_mpc85xx.h | 26 +- arch/powerpc/include/asm/fsl_ddr_dimm_params.h | 1 + arch/powerpc/include/asm/fsl_serdes.h | 1 + arch/powerpc/include/asm/immap_512x.h | 6 +- arch/powerpc/include/asm/immap_83xx.h | 18 +- arch/powerpc/include/asm/immap_85xx.h | 9 +- arch/powerpc/lib/board.c | 2 +- board/freescale/b4860qds/b4860qds.c | 16 - board/freescale/c29xpcie/ddr.c | 8 + board/freescale/corenet_ds/corenet_ds.c | 14 - board/freescale/p2041rdb/p2041rdb.c | 14 - board/freescale/t1040qds/t1040qds.c | 14 - board/freescale/t4qds/t4240qds.c | 16 - board/keymile/common/common.c | 27 +- board/keymile/kmp204x/Makefile | 48 +++ board/keymile/kmp204x/ddr.c | 64 +++ board/keymile/kmp204x/eth.c | 71 +++ board/keymile/kmp204x/kmp204x.c | 258 +++++++++++ board/keymile/kmp204x/kmp204x.h | 15 + board/keymile/kmp204x/law.c | 40 ++ board/keymile/kmp204x/pbi.cfg | 35 ++ board/keymile/kmp204x/pci.c | 35 ++ board/keymile/kmp204x/rcw_kmp204x.cfg | 11 + board/keymile/kmp204x/tlb.c | 110 +++++ boards.cfg | 3 + drivers/mtd/nand/fsl_elbc_nand.c | 6 +- drivers/net/fm/b4860.c | 7 + drivers/net/fm/fm.h | 1 + drivers/net/fm/init.c | 8 + drivers/net/fm/p1023.c | 7 + drivers/net/fm/p4080.c | 7 + drivers/net/fm/p5020.c | 7 + drivers/net/fm/p5040.c | 7 + drivers/net/fm/t4240.c | 7 + drivers/usb/host/ehci-fsl.c | 15 +- drivers/usb/host/ehci-mpc512x.c | 4 +- include/configs/C29XPCIE.h | 2 + include/configs/km/keymile-common.h | 6 +- include/configs/km/km-powerpc.h | 6 + include/configs/km/km_arm.h | 8 +- include/configs/km/kmp204x-common.h | 450 ++++++++++++++++++++ include/configs/km82xx.h | 2 + include/configs/kmp204x.h | 68 +++ include/fm_eth.h | 1 + include/usb/ehci-fsl.h | 13 +- 54 files changed, 1428 insertions(+), 135 deletions(-) create mode 100644 board/keymile/kmp204x/Makefile create mode 100644 board/keymile/kmp204x/ddr.c create mode 100644 board/keymile/kmp204x/eth.c create mode 100644 board/keymile/kmp204x/kmp204x.c create mode 100644 board/keymile/kmp204x/kmp204x.h create mode 100644 board/keymile/kmp204x/law.c create mode 100644 board/keymile/kmp204x/pbi.cfg create mode 100644 board/keymile/kmp204x/pci.c create mode 100644 board/keymile/kmp204x/rcw_kmp204x.cfg create mode 100644 board/keymile/kmp204x/tlb.c create mode 100644 include/configs/km/kmp204x-common.h create mode 100644 include/configs/kmp204x.h Thanks, York

2 1

[U-Boot] Patch about mmc and sdhci, Please look it, i can not pull the patch. I copy it here.
by richie_wang 30 Oct '13

30 Oct '13

>From 133570dbb7f772f78558cfac9d8c558513d033a1 Mon Sep 17 00:00:00 2001 From: richie_wang <macro_system(a)163.com> Date: Wed, 25 Sep 2013 08:20:25 +0800 Subject: [PATCH 3/3] This commit solve mmc_write_blocks with async cmd12 hidden bug When the processor use mmc_write_blocks to write multi-block data to SD Memory card it will send CMD12 to finish the transfer. But if the code using PIO method and processor speed is high than the SD host sending the data in SD host buffer.There will be a condition CMD12 will on cmd line and some data still on data line, which will conflict will multi-write Time requirement in SPEC. This commit makes CPU send CMD12 after register 0x24 bit8 change to zero. Signed-off-by: richie_wang <macro_system(a)163.com> --- :100644 100644 aa2fdef... f2f982c... M drivers/mmc/mmc_write.c :100644 100644 dfb2eee... d66cc9a... M drivers/mmc/sdhci.c :100644 100644 74d06ae... a0c9e32... M include/sdhci.h drivers/mmc/mmc_write.c | 8 ++++++++ drivers/mmc/sdhci.c | 11 +++++++++++ include/sdhci.h | 4 ++++ 3 files changed, 23 insertions(+) diff --git a/drivers/mmc/mmc_write.c b/drivers/mmc/mmc_write.c index aa2fdef..f2f982c 100644 --- a/drivers/mmc/mmc_write.c +++ b/drivers/mmc/mmc_write.c @@ -10,6 +10,7 @@ #include <config.h> #include <common.h> #include <part.h> +#include <sdhci.h> #include "mmc_private.h" static ulong mmc_erase_t(struct mmc *mmc, ulong start, lbaint_t blkcnt) @@ -103,6 +104,7 @@ static ulong mmc_write_blocks(struct mmc *mmc, lbaint_t start, { struct mmc_cmd cmd; struct mmc_data data; + struct sdhci_host* host; int timeout = 1000; if ((start + blkcnt) > mmc->block_dev.lba) { @@ -142,6 +144,12 @@ static ulong mmc_write_blocks(struct mmc *mmc, lbaint_t start, cmd.cmdidx = MMC_CMD_STOP_TRANSMISSION; cmd.cmdarg = 0; cmd.resp_type = MMC_RSP_R1b; + + /* cmd12 async timing problem */ + host = (struct sdhci_host*)mmc->priv; + if(host->magic_num == SDHCI_MAGIC_NUM) + sdhci_cmd12_wait(host); + if (mmc_send_cmd(mmc, &cmd, NULL)) { printf("mmc fail to send stop cmd\n"); return 0; diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index dfb2eee..d66cc9a 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -410,6 +410,7 @@ int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk) struct mmc *mmc; unsigned int caps; + host->magic_num = SDHCI_MAGIC_NUM; mmc = malloc(sizeof(struct mmc)); if (!mmc) { printf("mmc malloc fail!\n"); @@ -482,3 +483,13 @@ int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk) return 0; } + + +void sdhci_cmd12_wait(struct sdhci_host *host) +{ + u32 mask = SDHCI_DOING_WRITE; + + while(sdhci_readl(host, SDHCI_PRESENT_STATE) & mask); + + return ; +} diff --git a/include/sdhci.h b/include/sdhci.h index 74d06ae..a0c9e32 100644 --- a/include/sdhci.h +++ b/include/sdhci.h @@ -233,7 +233,10 @@ struct sdhci_ops { #endif }; +#define SDHCI_MAGIC_NUM 0x20131001 + struct sdhci_host { + unsigned int magic_num; char *name; void *ioaddr; unsigned int quirks; @@ -332,4 +335,5 @@ static inline u8 sdhci_readb(struct sdhci_host *host, int reg) #endif int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk); +void sdhci_cmd12_wait(struct sdhci_host *host); #endif /* __SDHCI_HW_H */ -- 1.7.9.5 -- View this message in context: http://u-boot.10912.n7.nabble.com/Patch-about-mmc-and-sdhci-Please-look-it-… Sent from the U-Boot mailing list archive at Nabble.com.

3 2

[U-Boot] [PATCH 1/2 V2] esdhc: memset mmc struct before putting into use
by Haijun Zhang 30 Oct '13

30 Oct '13

struct mmc should be clear to all '0' after malloc to avoid unexpect variable value. Like mmc->has_init = xxx. In this case mmcinfo will believe the card had been initialized before and skip the initialization. Test on P5040 and T4240, Error Log: => mmcinfo Device: FSL_SDHC Manufacturer ID: 0 OEM: 0 Name: Tran Speed: 0 Rd Block Len: 0 MMC version 0.0 High Capacity: No Capacity: 0 Bytes Bus Width: 0-bit => Signed-off-by: Haijun Zhang <Haijun.Zhang(a)freescale.com> Signed-off-by: Xie Shaohui-B21989 <B21989(a)freescale.com> --- drivers/mmc/fsl_esdhc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index a7170b4..d4c1eef 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -521,6 +521,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg) if (!mmc) return -ENOMEM; + memset(mmc, 0, sizeof(struct mmc)); sprintf(mmc->name, "FSL_SDHC"); regs = (struct fsl_esdhc *)cfg->esdhc_base; -- 1.8.4

3 3