November 2012 - U-Boot

[U-Boot] [PATCH 1/2] tegra: i2c: Add function to know about current bus
by Simon Glass 13 Nov '12

13 Nov '12

Rather than using a variable in various places, add a single function, tegra_i2c_get_bus(), which returns a pointer to information about a bus. This will make it easier to move to the new i2c framework. Signed-off-by: Simon Glass <sjg(a)chromium.org> --- drivers/i2c/tegra_i2c.c | 78 ++++++++++++++++++++++++++++++++++++---------- 1 files changed, 61 insertions(+), 17 deletions(-) diff --git a/drivers/i2c/tegra_i2c.c b/drivers/i2c/tegra_i2c.c index efc77fa..3e157f4 100644 --- a/drivers/i2c/tegra_i2c.c +++ b/drivers/i2c/tegra_i2c.c @@ -262,7 +262,8 @@ exit: return error; } -static int tegra_i2c_write_data(u32 addr, u8 *data, u32 len) +static int tegra_i2c_write_data(struct i2c_bus *bus, u32 addr, u8 *data, + u32 len) { int error; struct i2c_trans_info trans_info; @@ -273,14 +274,15 @@ static int tegra_i2c_write_data(u32 addr, u8 *data, u32 len) trans_info.num_bytes = len; trans_info.is_10bit_address = 0; - error = send_recv_packets(&i2c_controllers[i2c_bus_num], &trans_info); + error = send_recv_packets(bus, &trans_info); if (error) debug("tegra_i2c_write_data: Error (%d) !!!\n", error); return error; } -static int tegra_i2c_read_data(u32 addr, u8 *data, u32 len) +static int tegra_i2c_read_data(struct i2c_bus *bus, u32 addr, u8 *data, + u32 len) { int error; struct i2c_trans_info trans_info; @@ -291,7 +293,7 @@ static int tegra_i2c_read_data(u32 addr, u8 *data, u32 len) trans_info.num_bytes = len; trans_info.is_10bit_address = 0; - error = send_recv_packets(&i2c_controllers[i2c_bus_num], &trans_info); + error = send_recv_packets(bus, &trans_info); if (error) debug("tegra_i2c_read_data: Error (%d) !!!\n", error); @@ -302,18 +304,48 @@ static int tegra_i2c_read_data(u32 addr, u8 *data, u32 len) #error "Please enable device tree support to use this driver" #endif +/** + * Check that a bus number is valid and return a pointer to it + * + * @param bus_num Bus number to check / return + * @return pointer to bus, if valid, else NULL + */ +static struct i2c_bus *tegra_i2c_get_bus(unsigned int bus_num) +{ + struct i2c_bus *bus; + + if (bus_num >= TEGRA_I2C_NUM_CONTROLLERS) { + debug("%s: Invalid bus number %u\n", __func__, bus_num); + return NULL; + } + bus = &i2c_controllers[bus_num]; + if (!bus->inited) { + debug("%s: Bus %u not available\n", __func__, bus_num); + return NULL; + } + + return bus; +} + unsigned int i2c_get_bus_speed(void) { - return i2c_controllers[i2c_bus_num].speed; + struct i2c_bus *bus; + + bus = tegra_i2c_get_bus(i2c_bus_num); + if (!bus) + return 0; + return bus->speed; } int i2c_set_bus_speed(unsigned int speed) { - struct i2c_bus *i2c_bus; + struct i2c_bus *bus; - i2c_bus = &i2c_controllers[i2c_bus_num]; - i2c_bus->speed = speed; - i2c_init_controller(i2c_bus); + bus = tegra_i2c_get_bus(i2c_bus_num); + if (!bus) + return 0; + bus->speed = speed; + i2c_init_controller(bus); return 0; } @@ -426,7 +458,7 @@ void i2c_init(int speed, int slaveaddr) } /* i2c write version without the register address */ -int i2c_write_data(uchar chip, uchar *buffer, int len) +int i2c_write_data(struct i2c_bus *bus, uchar chip, uchar *buffer, int len) { int rc; @@ -438,7 +470,7 @@ int i2c_write_data(uchar chip, uchar *buffer, int len) debug("\n"); /* Shift 7-bit address over for lower-level i2c functions */ - rc = tegra_i2c_write_data(chip << 1, buffer, len); + rc = tegra_i2c_write_data(bus, chip << 1, buffer, len); if (rc) debug("i2c_write_data(): rc=%d\n", rc); @@ -446,13 +478,13 @@ int i2c_write_data(uchar chip, uchar *buffer, int len) } /* i2c read version without the register address */ -int i2c_read_data(uchar chip, uchar *buffer, int len) +int i2c_read_data(struct i2c_bus *bus, uchar chip, uchar *buffer, int len) { int rc; debug("inside i2c_read_data():\n"); /* Shift 7-bit address over for lower-level i2c functions */ - rc = tegra_i2c_read_data(chip << 1, buffer, len); + rc = tegra_i2c_read_data(bus, chip << 1, buffer, len); if (rc) { debug("i2c_read_data(): rc=%d\n", rc); return rc; @@ -470,12 +502,16 @@ int i2c_read_data(uchar chip, uchar *buffer, int len) /* Probe to see if a chip is present. */ int i2c_probe(uchar chip) { + struct i2c_bus *bus; int rc; uchar reg; debug("i2c_probe: addr=0x%x\n", chip); + bus = tegra_i2c_get_bus(i2c_get_bus_num()); + if (!bus) + return 1; reg = 0; - rc = i2c_write_data(chip, &reg, 1); + rc = i2c_write_data(bus, chip, &reg, 1); if (rc) { debug("Error probing 0x%x.\n", chip); return 1; @@ -492,11 +528,15 @@ static int i2c_addr_ok(const uint addr, const int alen) /* Read bytes */ int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len) { + struct i2c_bus *bus; uint offset; int i; debug("i2c_read: chip=0x%x, addr=0x%x, len=0x%x\n", chip, addr, len); + bus = tegra_i2c_get_bus(i2c_bus_num); + if (!bus) + return 1; if (!i2c_addr_ok(addr, alen)) { debug("i2c_read: Bad address %x.%d.\n", addr, alen); return 1; @@ -508,13 +548,13 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len) data[alen - i - 1] = (addr + offset) >> (8 * i); } - if (i2c_write_data(chip, data, alen)) { + if (i2c_write_data(bus, chip, data, alen)) { debug("i2c_read: error sending (0x%x)\n", addr); return 1; } } - if (i2c_read_data(chip, buffer + offset, 1)) { + if (i2c_read_data(bus, chip, buffer + offset, 1)) { debug("i2c_read: error reading (0x%x)\n", addr); return 1; } @@ -526,11 +566,15 @@ int i2c_read(uchar chip, uint addr, int alen, uchar *buffer, int len) /* Write bytes */ int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len) { + struct i2c_bus *bus; uint offset; int i; debug("i2c_write: chip=0x%x, addr=0x%x, len=0x%x\n", chip, addr, len); + bus = tegra_i2c_get_bus(i2c_bus_num); + if (!bus) + return 1; if (!i2c_addr_ok(addr, alen)) { debug("i2c_write: Bad address %x.%d.\n", addr, alen); return 1; @@ -540,7 +584,7 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buffer, int len) for (i = 0; i < alen; i++) data[alen - i - 1] = (addr + offset) >> (8 * i); data[alen] = buffer[offset]; - if (i2c_write_data(chip, data, alen + 1)) { + if (i2c_write_data(bus, chip, data, alen + 1)) { debug("i2c_write: error sending (0x%x)\n", addr); return 1; } -- 1.7.7.3

4 20

[U-Boot] Want to burn a u-boot to a customized board
by narke 13 Nov '12

13 Nov '12

Hi, List I've just built an u-boot boot-loader based on the configuration of smdk2410. I built this by using buildroot, without additional customizing and modifications. My problem is, I want to use the boot-loader to boot another s3c2410 board which is a customized board cannot found configurations in the u-boot source tree. I don't have smdk2410 actually, I choose this board just for making a good starting point. My customized S3C2410 board looks not a strange one, it have common components usually found on other S3C2410 boards, such as Flash, SD Card Socket, Serial Ports and Ethernet interfaces. My question is, if I download the boot-loader I just built for smdk2410 to my customized board, how much chance I can see it can boot the board with success? At this step, I don't expect I can load a Linux kernel successfully, I just what to see it can boot and give me a prompt on the serial console. How much is that possible? -- woody I can't go back to yesterday - because I was a different person then.

3 3

[U-Boot] [PATCH 1/7] i2c: Use __weak instead of __attribute__((weak, alias))
by Marek Vasut 13 Nov '12

13 Nov '12

Use __weak from linux/compiler.h instead of __attribute__((weak, alias)) to define overridable function. This patch is intended as a cleanup patch to bring some consistency into the code. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Heiko Schocher <hs(a)denx.de> --- common/cmd_i2c.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index 4438db5..c8990ef 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -82,6 +82,7 @@ #include <i2c.h> #include <malloc.h> #include <asm/byteorder.h> +#include <linux/compiler.h> /* Display values from last command. * Memory modify remembered values are different from display memory. @@ -133,30 +134,27 @@ DECLARE_GLOBAL_DATA_PTR; #define DISP_LINE_LEN 16 /* implement possible board specific board init */ -static void __def_i2c_init_board(void) +__weak +void i2c_init_board(void) { return; } -void i2c_init_board(void) - __attribute__((weak, alias("__def_i2c_init_board"))); /* TODO: Implement architecture-specific get/set functions */ -static unsigned int __def_i2c_get_bus_speed(void) +__weak +unsigned int i2c_get_bus_speed(void) { return CONFIG_SYS_I2C_SPEED; } -unsigned int i2c_get_bus_speed(void) - __attribute__((weak, alias("__def_i2c_get_bus_speed"))); -static int __def_i2c_set_bus_speed(unsigned int speed) +__weak +int i2c_set_bus_speed(unsigned int speed) { if (speed != CONFIG_SYS_I2C_SPEED) return -1; return 0; } -int i2c_set_bus_speed(unsigned int) - __attribute__((weak, alias("__def_i2c_set_bus_speed"))); /* * get_alen: small parser helper function to get address length -- 1.7.10.4

2 10

[U-Boot] wanting a couple clarifications on the boards.cfg file
by Robert P. J. Day 13 Nov '12

13 Nov '12

after some playing around, i think i have a pretty good handle on the structure and usage of the boards.cfg file, except for what are apparently some oddities (not errors, just redundancies in some sense). first, with lines like this: apx4devkit arm arm926ejs apx4devkit bluegiga mxs apx4devkit m28evk arm arm926ejs m28evk denx mxs m28evk mx28evk arm arm926ejs mx28evk freescale mxs mx28evk that last field would seem to be redundant, since the default value is just the name of the first (target) field, correct? also odd is something like this: mx31ads arm arm1136 - freescale mx31 mx31pdk arm arm1136 - freescale mx31 mx31pdk:NAND_U_BOOT given that nothing else in the entire file refers to mx31pdk, it seems overly complicated for mx31pdk to refer to its own config file, only to add a preprocessor definition. other than that, i might try to add an entry for a NAND-less beagle xm. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================

2 2

[U-Boot] MPC8306SOM U-Boot issue
by Easwar Balasubramanian 13 Nov '12

13 Nov '12

Hi, Im using a board similar to MPC8306SOM, We are using the same DDR, NOR, NAND and Processor. Even the part number is not changed. We tried to boot U-Boot from NOR flash, but there is no response on the Serial Console. We checked the data lines and address lines, everything appears to be working. We noticed that processor is keeping the chip select continuously. We suspected the reset configuration word, but it appeared normal to. So we thought trying NAND flash, we get "NAND boot...transfering control" and nothing happens. We checked the jump address everything appears ok. When we google it, we saw many others facing the same issue as we are facing. Kindly guide us in what needs to be done. Regards, Easwar

2 1

[U-Boot] kwboot: Boot Marvell Kirkwood SoCs over a serial link.
by Daniel Stodden 13 Nov '12

13 Nov '12

Hey. I wrote a utility to boot Marvell SoCs over serial. If that sounds generally useful, would you be so kind to merge git://github.com/dns42/u-boot.git at dns/kwboot-1 If it's missing sth for that to happen, lemme know. Cheers, Daniel

6 8

[U-Boot] U-Boot 2012.10 PXA270 - saveenv / Kernel issue
by Andreas Puls 13 Nov '12

13 Nov '12

Hello everyone, i have a problem with the latest stable U-Boot 2012.10 and a Toradex Colibri PXA270 V2.4a Board and a upating the kernel. The problem apears when i erase the hole NOR Flash, copy the uboot and the uImage. Here are my steps. 1. unprotect and erase the hole flash. 2. copy the latest u-boot.bin to flash 2.1 usb start 2.2 fatload usb 0:1 0xa0000000 u-boot.bin 2.3 protect off 0x0 0x3ffff 2.4 erase 0x0 0x3ffff 2.5 cp.b 0xa0000000 0x0 $filesize 3 reset to look the u-boot is installed 3.1 see that CRC is bad (normal behavier couse no defaults are written) 3.2 savenv and powercyle 4. all fine 5. copy kernel image to flash 5.1 usb start 5.2 fatload usb 0:1 0xa0000000 uimage-2.6.35.9-toradex-pxa270v22b 5.3 protect off 0xc0000 0x47ffff 5.4 erase 0xc0000 0x47ffff 5.5 cp.b 0xa0000000 0xc0000 $filesize 6. check the uImage 6.1 iminfo 0xC00000 - OK 7. hard reset (power cycle) Now comes the part that i dosen't understand The U-Boot loader sayes again that the CRC is bad and using default values. I use "saveenv" again and make a powercycle. The CRC error is no more but the u-boot isnt able to boot the uImage. It sayes unkown Image format Sory for the long description. I search the mailing but didnt found something. The latest Toradex Bootloader is u-boot 1.3.3 there is the saveenv and Kernel update working. But the USB support isnt working. Could anybody give me hint or maybe know the solution ? Kind regards Andreas

4 8

[U-Boot] [PATCH 0/6] EXYNOS5: FDT Support for I2C
by Rajeshwari Shinde 12 Nov '12

12 Nov '12

This patch set adds FDT support for I2C driver and API's to acess the bus number using the fdt node and also reset the port. Rajeshwari Shinde (6): EXYNOS5: FDT: Add I2C device node data EXYNOS5 : FDT: Add Aliases for I2C device EXYNOS5: FDT: Add compatible string for I2C FDT: Api to find compatible id for a given node I2C: Driver changes for FDT support SMDK5250: Populate I2C data using FDT. arch/arm/dts/exynos5250.dtsi | 64 +++++++++++++++++++++ board/samsung/dts/exynos5250-smdk5250.dts | 11 ++++ board/samsung/smdk5250/smdk5250.c | 7 ++- drivers/i2c/s3c24x0_i2c.c | 89 ++++++++++++++++++++++++++++- drivers/i2c/s3c24x0_i2c.h | 7 ++ include/fdtdec.h | 15 +++++ include/i2c.h | 28 +++++++++ lib/fdtdec.c | 13 ++++ 8 files changed, 231 insertions(+), 3 deletions(-) -- 1.7.4.4

3 14

[U-Boot] UBIFS fails on SheevaPlug
by Dimax 12 Nov '12

12 Nov '12

HI, After power short u-boot fails to mount UBIFS and board stuck. Below is a trace of u-boot Marvell>> boot UBI: mtd1 is detached from ubi0 Creating 1 MTD partitions on "nand0": 0x000000500000-0x000020000000 : "mtd=2" UBI: attaching mtd1 to ubi0 UBI: physical eraseblock size: 131072 bytes (128 KiB) UBI: logical eraseblock size: 129024 bytes UBI: smallest flash I/O unit: 2048 UBI: sub-page size: 512 UBI: VID header offset: 512 (aligned 512) UBI: data offset: 2048 UBI: attached mtd1 to ubi0 UBI: MTD device name: "mtd=2" UBI: MTD device size: 507 MiB UBI: number of good PEBs: 4055 UBI: number of bad PEBs: 1 UBI: max. allowed volumes: 128 UBI: wear-leveling threshold: 4096 UBI: number of internal volumes: 1 UBI: number of user volumes: 1 UBI: available PEBs: 0 UBI: total number of reserved PEBs: 4055 UBI: number of PEBs reserved for bad PEB handling: 40 UBI: max/mean erase counter: 1/0 UBIFS: recovery needed Error reading superblock on volume 'ubi:rootfs'! UBIFS not mounted, use ubifs mount to mount volume first! UBIFS not mounted, use ubifs mount to mount volume first! Wrong Image Format for bootm command ERROR: can't get kernel image! Marvell>> To recover from this situation I boot from USB stick and simply mounts the same UBIFS partition: root@debian:~# mount -t ubifs ubi0:rootfs /mnt [ 306.205029] UBIFS: recovery needed [ 309.341987] UBIFS: recovery completed [ 309.345705] UBIFS: mounted UBI device 0, volume 0, name "rootfs" [ 309.351738] UBIFS: file system size: 515192832 bytes (503118 KiB, 491 MiB, 3993 LEBs) [ 309.359789] UBIFS: journal size: 25804800 bytes (25200 KiB, 24 MiB, 200 LEBs) [ 309.367495] UBIFS: media format: w4/r0 (latest is w4/r0) [ 309.373352] UBIFS: default compressor: lzo [ 309.377479] UBIFS: reserved for root: 4952683 bytes (4836 KiB) As you can see mount manage to recover partition. Is where any way to make u-boot to recover UBIFS partition as well? What else can I do to make my system stable and survive power shorts? Thanks.

6 32

[U-Boot] any value in defining specifically a beagleboard xM config file?
by Robert P. J. Day 12 Nov '12

12 Nov '12

i'll guess this topic has come up before but is there any value in defining a config file explicitly for the beagle xM, which differs from the beagle classic primarily in that it has no onboard flash? on my current xM, i have a perfectly fine booting u-boot which i'm thinking i got from the circuitco site, and it works terrifically except that it comes with numerous commands related to flash, of which there is of course none. the stock omap3_beagle.h file, unsurprisingly, configures all of the MTD and NAND settings relevant for the classic, which are entirely superfluous for the xM. and given the number of commands that represents, there's lots of stuff that obviously has no value on the xM. would there be any value in defining an omap3_beagle_xm.h file that simply includes the current beagle file, then undefines any settings related to flash? i can't imagine that would be hard to do. rday p.s. weirdly, while my working u-boot has all sorts of flash-related commands, it *doesn't* have "flinfo", which seems odd and kind of inconsistent. will investigate further ... -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================

3 3